Commit Graph

7578 Commits (e0c02f8b25ebc5048fa8cbd07344851b2e4c319a)

Author SHA1 Message Date
Alexandru2909 1051a98c02 For #24710 - Remove Event.wrapper for RecentBookmarks telemetry 2 years ago
Alexandru2909 9ff4f373ec For #24707 - Remove Event.wrapper for CreditCards telemetry 2 years ago
mcarare b8a59b2602 For #24711: Remove wrapper from recent tabs metrics. 2 years ago
Mozilla L10n Automation Bot 5d72e42e5e Import l10n. 2 years ago
Gabriel Luong cf53a84278 For #24747 - Remove unused store property in SessionControlAdapter and SessionControlView 2 years ago
Alexandru2909 cc893aa641 For #24706 - Remove Event.wrapper for Autofill related telemetry 2 years ago
mcarare eb82cfef78 For #24206: Remove wrapper from context menu metrics. 2 years ago
Arturo Mejia 120113abff Enable messaging framework in nightly 2 years ago
Mozilla L10n Automation Bot 61bffb6685 Import l10n. 2 years ago
Roger Yang bf7b8f97c4 Issue #24733: Setup search for Unified Search experimentation 2 years ago
Gabriel Luong 8fe9c5bdd1 For #24297 - Add a search engine menu that shows the search engine and search settings 2 years ago
mcarare dfe23e8b77 For #24211: Remove wrapper from search related metrics.
Removes wrapper from search labeled counter and performed search event.
2 years ago
mcarare 00156907c0 For #24211: Remove wrapper from "has open tabs" boolean metric. 2 years ago
Andrei Joltan 8c42f7f6ff
For #24495 fix and re-enable settingsPrivacyItemsTest UI test. (#24705)
* Fix delete browsing data on quit ambiguous matcher

* Add missing HTTPS-Only Mode assertions to settingsPrivacyItemsTest UI test

* SettingsRobot refactoring work

Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
AndiAJ 6e2fa202e9 For #24381 re-enable firstRunScreenTest UI test 2 years ago
MatthewTighe eca84dfa3d for #24718: add two remote firefox wallpapers 2 years ago
Alexandru2909 e558ec279a For #24701 - Remove Event.wrapper for Pocket related telemetry 2 years ago
Alexandru2909 06fba96dfb For #24709 - Remove Event.wrapper for Wallpapers telemetry 2 years ago
mcarare bd599caa83 For #24205: Remove wrapper from set default browser toolbar menu.
This metric is recorded in the context of the default browser experiment.
2 years ago
mcarare 3c8e539366 For #24715: Remove obsolete addon installed metric. 2 years ago
mcarare b0c5148de9 For #24715: Remove wrapper from addons metrics. 2 years ago
Mugurell 13e1a22a8d For #24596 - Only restore Pocket categories selections once
This fixes a regression from migrating from HomeStore to Appstore but
indirectly by ensuring that previous categories selections are only restored
once, not everytime user selects a new category and that change is persisted.
2 years ago
Alexandru2909 120176f3b4 For #24605 - Remove Event.wrapper for MediaState telemetry 2 years ago
Alexandru2909 fd021b2819 For #24642 - Remove Event.wrapper for TopSites metrics 2 years ago
Alexandru2909 b57219b190 For #24708 - Remove Event.wrapper for DarkThemeSelected telemetry 2 years ago
Mozilla L10n Automation Bot e7df75b5af Import l10n. 2 years ago
MatthewTighe 414a54ed02 for #24549: add telemetry for recent synced tab 2 years ago
Alexandru2909 08ce8fb3c5 For #24703 - Replace Mockito mocks with Mockk mocks 2 years ago
Mozilla L10n Automation Bot 525188d768 Import l10n. 2 years ago
Mozilla L10n Automation Bot a2289c5b2f Import l10n. 2 years ago
Mozilla L10n Automation Bot 4bdb49e8c8 Import l10n. 2 years ago
Mugurell e413245b3f For #24618 - Replace a Mockito mock with a Mockk mock
And in such fix seemingly intermittently failing tests preventing the merge.
2 years ago
Mugurell e006538c63 For #24618 - Add WebNotificationIntentProcessor to IntentReceiverActivity
The processor from Android-Components will know how to handle the intent
specific to web notifications clicks.
2 years ago
Mugurell 5383d3ed63 For #24618 - Add Fenix own ServiceWorkerSupport
This replaces the default implementation from Android-Components to add the
functionality to first navigate to the browser fragment before responding to
service workers' requests of opening new tabs.

This will register itself when the main activity is created and unregister
itself when that activity is destroyed to support requests even when the
activity is in background but prevent any leaks.
2 years ago
Alexandru2909 4d0b79192d For #24638 - Remove Event.wrapper for Logins telemetry 2 years ago
Alexandru2909 f170772f0c For #24599 - Remove Event.wrapper for Tab telemetry 2 years ago
Alexandru2909 8c617b7c07 For #24640 - Remove Event.wrapper for VoiceSearch telemetry 2 years ago
Alexandru2909 3c78b14321 For #24215 - Remove Event.wrapper for CustomTab metrics 2 years ago
Alexandru2909 43bed6e765 For #24591 - Remove Event.wrapper for ReaderMode telemetry 2 years ago
Alexandru2909 eaaa5ddcdb For #24603 - Remove Event.wrapper for MediaNotification telemetry 2 years ago
Mozilla L10n Automation Bot dfdf41d9b1 Import l10n. 2 years ago
Mozilla L10n Automation Bot 64ddee0da3 Import l10n. 2 years ago
Alexandru2909 e571f0bb3a For #24498 - Remove Event.wrapper for History metrics 2 years ago
MatthewTighe dbfd5ffca0 for #24177: sync tabs when home is shown 2 years ago
Gabriel Luong 38bde17fc4 For #24653 - Fix Text Action Secondary color in FirefoxTheme 2 years ago
Mugurell e485cf508e For #24648 - Add a Modifier extension method to draw a dashed border
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
Gabriel Luong b6bcbfe346 For #24649 - Fix spelling of shortcuts in @string/snackbar_added_to_shortcuts 2 years ago
Gabriel Luong 6564c510e1 For #24645 - Update dark theme Action Secondary to LightGrey30 2 years ago
mcarare 49f352d52d For #24210: Remove wrapper from preference toggled events. 2 years ago
mcarare ac1eeec57a For #24210: Remove wrapper from opened link event. 2 years ago
mcarare 09e5394af6 For #24210: Remove wrapper from opened synced tab event. 2 years ago
mcarare a9c41774ea For #24210: Remove wrapper from recently closed tabs opened event. 2 years ago
mcarare dbc329f8b6 For #24210: Remove wrapper from copy url event. 2 years ago
mcarare cbcf2d12dd For #24210: Remove wrapper from home button clicked event. 2 years ago
mcarare 496b42db0a For #24210: Remove wrapper from tab list view setting changed event. 2 years ago
mcarare 319d3846c2 For #24210: Remove wrapper from whats new tapped event. 2 years ago
mcarare 668008c341 For #24210: Remove wrapper from uri opened count. 2 years ago
mcarare 6f2de0e2bd For #24210: Remove wrapper from displaying toolbar menu event. 2 years ago
mcarare 1d457a8f2f For #24210: Remove wrapper from "default browser" events. 2 years ago
mcarare 3947a613f4 For #24210: Remove wrapper from "browser menu item tapped" event. 2 years ago
mcarare 3931cd5c1e For #24210: Remove wrapper from "url entered" event. 2 years ago
mcarare 51df82acb1 For #24210: Remove wrapper from "search bar tapped" event. 2 years ago
mcarare 4c738cbf10 For #24210: Remove wrapper from "app opened" event. 2 years ago
AndiAJ f73b2542a4 For #24508 re-enable private browsing UI tests 2 years ago
Mozilla L10n Automation Bot 003211ac8b Import l10n. 2 years ago
Gabriel Luong 8b01528f5b For #24616 - Update all the strings that references "top site" to "shortcut" 2 years ago
Roger Yang a4dc80adbc Issue #24298: Refactor Scan button from the search toolbar into the display toolbar 2 years ago
Arturo Mejia b6dd45798c For #24621: Update HTTP only mode strings 2 years ago
Gabriel Luong c5d6012b91 For #24581 - Fix row spacing between Top Sites 2 years ago
Alexandru2909 ee7c268302 For #24576 - Record delete collection metric 2 years ago
Roger Yang e6ca009e6a Issue #24611: Enable history improvement feature 2 years ago
Gabriel Luong 31e24e96f5 For #24607 - Remove all unused strings marked moz:removedIn <= 98 2 years ago
James Hugman 733da8694d Move experimenter.json to experimenter.yaml 2 years ago
jknair c38320c7c0 For #24461 - Increase touch target for scan, search engine & voice search button 2 years ago
AndiAJ 4382227b92 Ignore and remove recently_saved_show_all unused resource 2 years ago
AndiAJ 06bef25f0b For #24375 and #24384 fix and re-enable jumpBackInOptionTest and recentBookmarksOptionTest UI tests 2 years ago
Mugurell 526b9a17d7 For #24593 - Initialize Glean on all builds. Avoid Fennec check.
This completes the work for removing the Fennec migration support.
Before that, for Fenix release and beta, apps to which users might update to
from old Fennec builds the Glean initialization was done separately in
MigratingFenixApplication to allow time to first migrate user's telemetry
setting.
With the removal of the migration support it is now safe to initialize Glean in
the same way for all builds and remove that Fennec check.
2 years ago
Mozilla L10n Automation Bot 4cd2a7fb90 Import l10n. 2 years ago
AndiAJ 2171d47613 For #24436 fix and re-enable home screen UI tests 2 years ago
Roger Yang 36c271cab3 Close #24550: Hide edit suggestion button for history and bookmarks search suggestions 2 years ago
AndiAJ b20a16f279 For #24462 #24376 #24377 #20418 re-enable top sites UI tests 2 years ago
AndiAJ e3cc090c8a Skip onboarding in TopSitesTest class 2 years ago
AndiAJ 413387c37c Remove duplicate add top site from main menu UI test 2 years ago
Gabriel Luong 81167eb953 For #24556 - Handle preference change for the Contile preference 2 years ago
Sammy Khamis b6a0b41536
Don't crash when receiving a bad uri via send tab (#24326)
* don't crash when receiving a bad uri via send tab

* changed searchfox link to permalink

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
jhugman 2b36ca75bf Add defaults to FML, add control behaviour 2 years ago
Alexandru2909 480ab3dca7 For #24454 - Remove Event.wrapper for SyncAccount metrics 2 years ago
Alexandru2909 54e17f4e2d For #24512 - Remove Event.wrapper for RecentlyClosedTabs metrics 2 years ago
Alexandru2909 623bfd0a03 For #24452 - Remove MetricController checks from BackgroundServicesTest 2 years ago
Alexandru2909 258f329046 For #24452 - Remove Event.wrapper for SyncAuth metrics 2 years ago
Alexandru2909 82901297cb For #24214 - Move bookmark removal events to BookmarkController 2 years ago
Alexandru2909 0a5b8c49a0 For #24214 - Remove Event.wrapper for BookmarksManagement metrics 2 years ago
Alexandru2909 740566992a For #24099 - Remove Event.wrapper for Collections telemetry 2 years ago
Pedro Coelho e5e286f843 For #22308 - Changed constraint of tab tray overflow 2 years ago
sarah541 3a039ca918 For #23971 - Migrate CollectionHeaderViewHolder to Compose
fix ktlint
2 years ago
Roger Yang 582d8ef52d Issue #24502: Sanitize external intents 2 years ago
Mugurell 6fb54b08f2 For #24331 - Support for opening new tabs when requested by service workers
Use the new `ServiceWorkerSupport` AC components for this.
Had to be installed in `FenixApplication` since there is a circular dependency
between the initialization of the required engine the `tabsUseCases` arguments.
2 years ago
Alexandru2909 da723ee2fd For #24209 - Remove Event.wrapper for CustomizeHome telemetry 2 years ago
Alexandru2909 0e5f75bfe2 For #24147 - Remove Event.wrapper for Search widget telemetry 2 years ago
AndiAJ 455e5853a2 Disable failing deleteCollectionTest UI test 2 years ago
Gabriel Luong 8652ff5bcf For #24519 - Add Private theme to FirefoxTheme 2 years ago
Gabriel Luong 33cb72b561 For #24518 - Enable Contile feature flag 2 years ago
Grigory Kruglov f1bd1a4ce1 Do not report caught exceptions to Sentry on release channel 2 years ago
Alexandru2909 a1243a8e9f For #24450 - Remove Event.wrapper for ErrorPage metrics 2 years ago
Alexandru2909 7cedc8b440 For #24208 - Remove Event.wrapper for LoginDialogFacts telemetry 2 years ago
Alexandru2909 f924f74434 For #24207 - Remove Event.wrapper for ToolbarSettings telemetry 2 years ago
Arturo Mejia 4389da7811 For #24222: Persist user interactions with nimbus messages 2 years ago
Gabriel Luong e950ec3f4d For #24319 - Migrate PrivateBrowsingDescriptionViewHolder to Compose 2 years ago
Eitan Isaacson f9369a5535 For #24490 - Remove index selectors in UI tests. 2 years ago
Mugurell fab6b8d1d8 For #23337 - Customize the https-only mode error page 2 years ago
Roger Yang 26767a79bc No issue: Renew/remove metrics set to expire in v101 2 years ago
Noah Bond ccd8084dd4 For #24467 - Enable Contile setting telemetry 2 years ago
Alexandru2909 df702a2694 For #24204 - Remove Event.wrapper for Search_shortcuts telemetry 2 years ago
Mugurell dc87226e42 For #16952 - Temporarily disable settingsPrivacyItemsTest ui test
Pending refactoring following the addition of a new setting, work to be done in
https://github.com/mozilla-mobile/fenix/issues/24495
2 years ago
Mugurell 46d757ab54 For #16952 - Https-only mode support.
Default will be disabled with users having the possibility to enable this from
a new setting in the `Privacy and security` section.
If enabled then by default this force https for all tabs with the option for
users to switch to forcing https only on private tabs.
2 years ago
AndiAJ 541b2be184 For #24381 disable failing firstRunScreenTest UI test 2 years ago
Alexandru2909 28db4caa8c For #24212 - Remove Event.wrapper for Preferences metrics 2 years ago
mike a a0f02b27be Closes #24276: add documentation to classes marked as UndocumentedPublicClass by lint 2 years ago
mike a 8ca01de0fa Closes #24276
– capitalize and stylize comments
– fix history items duplication
– fix refresh glitching after removing multiple history items
2 years ago
mike a ebf4ce2fe7 Closes #24276:
– remove unused import
– remove HistoryViewModel
2 years ago
mike a 5b481ad204 Closes #24276:
– make comments inside HistoryDataSource capitalized and informative
– remove scroll to first item in swipe-to-refresh
– change adapter initialization
– fixed SitePermissionsExceptionsFragment flickering empty state
2 years ago
mike a 548ff770f3 Closes #24276: removed unused Log import 2 years ago
mike a b934f3659c Closes #24276: fix history list displaying empty state until refresh 2 years ago
mike a 386c4da765 Closes #24276: moved getHistory() to suspend 2 years ago
mike a 9f699e2b40 Closes #24276: fixed history tests 2 years ago
mike a 019e244f0d Closes #24276: updated tests 2 years ago
mike a be3c53a73c Closes #24276: removed deprecated paging from SitePermissionsExceptionsFragment 2 years ago
mike a 7b5d3181df Closes #24276: updating pagination library, changing history related classes 2 years ago
Alexandru2909 ffbcaa82de For #24203 - Remove Event.wrapper for Onboarding telemetry 2 years ago
sarah541 3b39b4668f For #23968 - Migrate homescreen recent tabs to compose
For #23968 - Migrate homescreen recent tabs to compose
2 years ago
sarah541 ce7d2d1962 For #23969 - Migrate homescreen recent bookmarks to compose 2 years ago
sarah541 e11c9b2e8f For #23970 - Migrate homescreen recent visits header to compose 2 years ago
Brais Gabín 1f633edd7d For #23046 - Align detekt config between Fenix and Android Components
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
Noah Bond 57238fa5ca For #24467 - Enable Contile setting telemetry 2 years ago
Michael Comella d9169af323 For #24486: change perf telemetry expiration email. 2 years ago
MatthewTighe 387be0a135 closes #24442: refactor recent tabs to use common composables 2 years ago
Arturo Mejia bfeceb562d For #24224: Send telemetry events related to the messaging framework 2 years ago
AndiAJ 20b738c69d For #24375 #23481 #24458 #24462 #24376 disable flaky UI tests 2 years ago
mcarare 1b00141d78 For #24148: Update tests for tracking protection metrics. 2 years ago
mcarare 74eb9b9c1b For #24148: Remove wrapper from tracking protection metrics. 2 years ago
mcarare cb14837bc6 For #24098: Update tests for tabs tray metrics. 2 years ago
mcarare 1f18f62a5a For #24098: Remove wrapper from tabs tray metrics. 2 years ago
AndiAJ 21df5a1a4a For #20418 and #24436 disable failing UI tests 2 years ago
Sebastian Kaspari 834d0ee12d Issue #22489: Remove "Fennec to Fenix" migration code 2 years ago
Jonathan Almeida f953c5ec94 For #24220 and #24223: Connect GleanPlumb messages with the new tab ui card.
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2 years ago
Elise Richards 0b981dde5f
For #23503: Respect studies and telemetry prefs when manually opting in to studies (#23955)
* For #23503: Respect studies pref and telemetry enabled pref when manually opting in to studies

* Add button to snackbar in nimbus secret settings that allows user to go directly to their data collection prefs

* Remove refactoring

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Noah Bond 280afc9d0b For #24394 - Replace custom synced tabs header with new generic header 2 years ago
Oana Horvath d14a52671b Disables failing tests: selectAndSearchTextTest, recentBookmarksOptionTest 2 years ago
Christian Sadilek 47f55924e1 Address breaking changes in A-C 100.0.20220324222826 2 years ago
Mozilla L10n Automation Bot 0386e4c969 Import l10n. 2 years ago
Roger Yang db46dd3a13 Close #24414: Enable Clear Site Data 2 years ago
Noah Bond f8a4661691 For #24337 - Make a reusable section header for lists in Compose 2 years ago
mike a 61d1ec2eff Closes #23517: add a check to handleDeleteAbnormal() test to also verify
removal of items inside abnormal list
2 years ago
mike a ee79ad629e Closes #23517: updated the tests 2 years ago
mike a 9aa613c443 Closes #23517: history items are not being removed after deletion 2 years ago
Christian Sadilek 8b595fa30c Closes #24407: Allow query parameters in AMO installation URLs 2 years ago
Oana Horvath a2d93d99b2 For #24377: Disables verifyRenameTopSite UI test 2 years ago
Gabriel Luong b4725429e8 For #24334 - Add FeatureFlag for Unified Search feature 2 years ago
MatthewTighe c1d2a9fb70 closes #24366: reset strict mode after locale read 2 years ago
Mozilla L10n Automation Bot 846751009d Import l10n. 2 years ago
Gabriel Luong 634ed4f164 For #24114 - Decrease EXPECTED_SUPPRESSION_COUNT value to fix StartupExcessiveResourceUseTest 2 years ago
Gabriel Luong b72c915d77 For #24114 - Dispatch the current mode when the HomeFragment is created 2 years ago
Gabriel Luong 48635fb031 For #24114 - Check feature settings to show and hide home screen sections 2 years ago
Gabriel Luong 4f3e891484 For #24114 - Refactor ext/HomeFragmentStateTest to ext/AppStateTest 2 years ago
Gabriel Luong 15d6d34a01 For #24114 - Change all HomeFragment[Store|State|Action] usage to App[Store|State|Action] in existing tests 2 years ago
Gabriel Luong 6ae4f9b4c5 For #24114 - Refactor HomeFragmenStoreTest to AppStoreTest 2 years ago
Gabriel Luong d7a9e304fb For #24114 - Refactor initial HomeFragmentState into AppState 2 years ago
Gabriel Luong aaa3d7b977 For #24114 - Refactor HomeFragmentStore parameters to AppStore 2 years ago
Gabriel Luong c2e3d251cb For #24114 - Refactor HomeFragmentState into AppState 2 years ago
Gabriel Luong 09df4dd787 For #24114 - Refactor ext/HomeFragmentState to ext/AppState 2 years ago
Mugurell 81604e8612 For #24342 - Actually log when Pocket stories are shown
Based on this we'll send telemetry and rotate the stories shown to prioritize
fresh ones instead of the ones already shown.
2 years ago
Mozilla L10n Automation Bot 6d7206a8dd Import l10n. 2 years ago
Mozilla L10n Automation Bot 8db26b5b71 Import l10n. 2 years ago
Mozilla L10n Automation Bot cd4bed4eab Import l10n. 2 years ago
Arturo Mejia 55c707a412 Closes #24305: Remove false wallpaper NPE Sentry report 2 years ago
Mozilla L10n Automation Bot f3a63c4a60 Import l10n. 2 years ago
MatthewTighe 9d681a9de0 closes #24306: add nav argument to open tabs tray to an initial page 2 years ago
MatthewTighe 9853ca13ae no issue: update accessibility comment for device icon 2 years ago
AndiAJ eb8f118e79 Remove SmokeTest annotation for closeTabCrashedReporterTest and restoreTabCrashedReporterTest 2 years ago
AndiAJ 686bcbfedc New useAppWhileTabIsCrashedTest and privateBrowsingUseAppWhileTabIsCrashedTest UI tests 2 years ago
AndiAJ 06dd147b8a Create new Crash Report test class and move the previously created UI smoke tests and refactoring work 2 years ago
indu 468ab0ffa8 For #24037: Do voice search in a separate task
This allows voice search to open in a separate window instead of opening in the same Picture-In-Picture window,  thereby making it easier to interact with the voice search.
2 years ago
Grigory Kruglov cbd0c07c6f For #23697: Allow pasting plain text in toolbar long press 2 years ago
Grigory Kruglov fc39c187cd For #23697: Treat text/x-moz-url mime type clipboard text as url
It seems like this is the MIME type we're getting from the clipboard in
certain scenarios, e.g. after copying a link from Chrome or Gmail on
some devices.
2 years ago
MatthewTighe 5674a4066b closes #24289: reset strict mode after WallpaperManager construction 2 years ago
Noah Bond 161b971aa6 For #24286 - Create new test for synced tabs error mapping 2 years ago
Arturo Mejia 0aab006a1c For #23489: Update SentryService reference to use the latest Sentry SDK. 2 years ago
mcarare a9bb913653 For #19929: Use AC extension functions for window insets compat. 2 years ago
Mozilla L10n Automation Bot a4fa1f5a52 Import l10n. 2 years ago
Roger Yang ed71b8a92c Close #12717: Add bookmark search 2 years ago
MatthewTighe 3727d55b88 for #24177: add ui wireframe for synced recent tab 2 years ago
Gabriel Luong 221ce814ef For #24235 - Remove Tip from HomeFragmentStore 2 years ago
Gabriel Luong 0448530440 For #24235 - Remove MasterPasswordTipProvider 2 years ago
Gabriel Luong 788b83bfaa For #24229 - Remove unused MigrationTipProvider 2 years ago
Oana Horvath 5310b220fb For #23716: Disables mediaSystemNotificationInPrivateModeTest 2 years ago
Oana Horvath 6845eef5c3 For #21002: Ads new search group UI tests
Fixed and re-enabled editCustomSearchEngineTest with custom MockWebServer URL
2 years ago
Alexandru2909 787d506c82 For #24187 - Avoid creating multiple inactive CFR dialogs 2 years ago
Mozilla L10n Automation Bot e0999f1bed Import l10n. 2 years ago
MatthewTighe 154ec3402e closes #24194: switch to IO dispatcher when cleaning wallpapers 2 years ago
Gabriel Luong ad95f950bb For #24252 - Rename contrastText attribute to textOnColorPrimary 2 years ago
Gabriel Luong e5d8f1e8d2 For #24252 - Rename unused snackbar attribute 2 years ago
Gabriel Luong a6c8f8b313 For #24252 - Rename destructive attribute to textWarning 2 years ago
Gabriel Luong a59d319eb0 For #24252 - Rename disabled attribute to textDisabled 2 years ago
Gabriel Luong 4263e1fd62 For #24252 - Rename above attribute to layer2 2 years ago
Gabriel Luong 9817be4fd0 For #24252 - Rename foundation attribute to layer1 2 years ago
Gabriel Luong 331dc3a8ec For #24252 - Rename secondaryText attribute to textSecondary 2 years ago
Gabriel Luong f1e7b49425 For #24252 - Rename primaryText attribute to textPrimary 2 years ago
Gabriel Luong a14c437924 For #24264 - Enable Contile feature for Nightly 2 years ago
Noah Bond 75414ae1df For #24219 - Refactor Favicon to fix previews 2 years ago
Gabriel Luong 779660f615 For #24246 - Refactor Tab from HomeFragmentStore 2 years ago
MatthewTighe 10d5bf0e66 no issue: update layer3 dark pallete color to match token 2 years ago
Gabriel Luong 4fada310b7 For #24242 - Update EditText background tint to use Border Primary 2 years ago
Gabriel Luong ec53937dd9 For #24249 - Use Border Primary for Dividers 2 years ago
Alexandru2909 ef678b4d17 Fixes #24188 - Use app_name for InactiveTabAutoClose message 2 years ago
Alexandru2909 7e1edc828e For #23719 - Replace preference framework strings with string resources 2 years ago
Mozilla L10n Automation Bot 598dd1a86e Import l10n. 2 years ago
Gabriel Luong cc27bcdf59 No issue - Add license to ic_share_clipboard.xml 2 years ago
Roger Yang d45543ec40 Close #14313: Always add copy to clipboard action in share actions 2 years ago
Mozilla L10n Automation Bot df4d7a9004 Import l10n. 2 years ago
Grigory Kruglov 5daa06f7dc For #23697: Avoid NPEs while pasting URLs from the clipboard
It's possible for clipboard contents to have changed in the time between we've constructed
the onClick listeners and when they're actually invoked. Code before assumed that 'text'
will be not-null, and would crash otherwise. With this change, we're capturing contents of
the clipboard before constructing onClick handlers (while also asserting correct behaviour
of 'ClipboardHandler').

With this change, we'll log an error if we were told that clipboard contains a URL, but immediately
after that check 'text' was actually null. This would indicate one of two things:
- issues within the ClipboardHandler
- changing contents of the ClipboardHandler within a tiny time window between our check and querying
2 years ago
Gabriel Luong c9a47d08a8 For #24130 - Change Shortcuts setting to toggle the display of Top Sites 2 years ago
Noah Bond 2ea99c9a1c For #23219 - Add favicons to synced tabs list 2 years ago
Mugurell 06ffc33ca2 For #23415 - Add support for GeckoView Screen Orientation APIs 2 years ago
Oana Horvath a6c78d8364 For #21002: Ads new wallpapers UI tests 2 years ago
Mozilla L10n Automation Bot 26d2aceb79 Import l10n. 2 years ago
Gabriel Luong bb94bc86e5 For #24141 - Replace @color/button_text_color with @color/fx_mobile_[text|icon]_color_action_secondary 2 years ago
Gabriel Luong 76c2f1e210 For #24141 - Replace @color/grey_button_color with @color/fx_mobile_action_color_secondary 2 years ago
Gabriel Luong ef0db6fd12 For #24141 - Add Icon Action Primary and Secondary design tokens 2 years ago
Mozilla L10n Automation Bot c49eb6deeb Import l10n. 2 years ago
Grigory Kruglov 02dd67b8d1 Remove duplicate 'start' call for the account manager
We are already starting the account manager in BackgroundServices,
so this call is a no-op (its gets dropped by the state machine).
2 years ago
Arturo Mejia ba5a4affb7 For #23489: Update SentryService reference to use legacy component. 2 years ago
Alexandru2909 c1431c5c12 For #22189 - Replace app name with 'Firefox' for Sync strings 2 years ago
Grigory Kruglov 7ca7190199 Bump Android-Components version to 100.0.20220309001717 2 years ago
Grigory Kruglov 6c793e035b Closes #15882: check for account state abnormalities after account manager is ready 2 years ago
Mozilla L10n Automation Bot a320d75b61 Import l10n. 2 years ago
Gabriel Luong 1f935e4bdc For #24108 - Use Layer3 for swipe to delete background color 2 years ago
Gabriel Luong 90e49c71d6 For #24107 - Use Layer1 for tab tray list item background color 2 years ago
Gabriel Luong 61ef3907a4 For #24082 - Use Icon Secondary for the tab tray globe thumbnail icon color 2 years ago
Gabriel Luong 97ecf4e45e For #24082 - Use Layer2 for the tab tray thumbnail item background color 2 years ago
Gabriel Luong 4c699c74d6 For #24156 - Remove all unused strings marked moz:removedIn <= 97 2 years ago
Mozilla L10n Automation Bot 1cbf2b2c75 Import l10n. 2 years ago
Mozilla L10n Automation Bot 9cc28a2f47 Import l10n. 2 years ago
Mozilla L10n Automation Bot b88600f4d6 Import l10n. 2 years ago
Mozilla L10n Automation Bot ded4266928 Import l10n. 2 years ago
Gabriel Luong a0f8c2a1a5 For #24102 - Use Layer Accent Opaque color for the selected tab tray item background in list view 2 years ago
Gabriel Luong 11b440f8f1 For #24102 - Add Layer Accent Opaque design token 2 years ago
Gabriel Luong ab74d55cfe For #24102 - Rename layerNonOpaque to layerAccentNonOpaque in FirefoxThemes 2 years ago
Gabriel Luong 65b1716495 For #23990 - Allow for Nimbus experimentation for Contile top sites 2 years ago
mcarare 094cd63242 For #24075: Add PDF download metrics. 2 years ago
mcarare 653f149cc2 For #24075: Add PDF download metrics. 2 years ago
Mozilla L10n Automation Bot ae727f1236 Import l10n. 2 years ago
Gabriel Luong 50a7a8499c For #24080 - Use layer accent non opaque for the tabs tray and history selected background color 2 years ago
Gabriel Luong 56022546f2 For #23893 - Add telemetry for Contile services 2 years ago
Gabriel Luong ae1a2f3625 For #24055 - Use Primary Button design colors for Save Collection Primary Button 2 years ago
Gabriel Luong c2bc0eefc4 For #24055 - Replace snackbar attribute with actionPrimary attribute 2 years ago
Gabriel Luong aebd2d4b3a For #24055 - Replace ?inset with Action Primary color Primary Buttons 2 years ago
Gabriel Luong b97d28db59 For #24055 - Replace ?contrastText with Icon On Color color for Primary Buttons 2 years ago
Gabriel Luong d67720d7f3 For #24055 - Replace ?contrastText with Action Primary Text for Primary buttons 2 years ago
Gabriel Luong d19f7a7fad For #24055 - Replace ?accent with Action Primary for Primary Buttons 2 years ago
mcarare 597cc84a76 For #23399: Add tabs tray multi-select telemetry. 2 years ago
Mozilla L10n Automation Bot fe0e4e9215 Import l10n. 2 years ago
Gabriel Luong bd3f1a420e For #24069 - Use the correct design tokens for Powered by Pocket text 2 years ago
Gabriel Luong 50ab3d451e For #24066 - Use secondary text color for the No Collections description 2 years ago
Gabriel Luong 691e303677 For #24062 - Remove showHomeBehindSearch feature flag 2 years ago
Gabriel Luong 09101eb787 For #24051 - Remove showStartOnHomeSettings feature flag 2 years ago
Mozilla L10n Automation Bot 4becaaa8cc Import l10n. 2 years ago
Gabriel Luong ae59f5a7a7 For #23388 - Update scrim to match design system 2 years ago
Arturo Mejia 1c66804c0b Add remote wallpapers 2 years ago
Gabriel Luong b6f066c9ed For #24042- Remove inactive tabs survey 2 years ago
mcarare 1aac79357a For #22189: Replace placeholder with app name. 2 years ago
Alexandru2909 19d1e227ed For #23936 - Show dialog on credit card delete 2 years ago
mcarare 47077fe2ec For #21743: Use isNumericAddress to validate Ipv4 and Ipv6 for SDK>=29. 2 years ago
Mugurell 4cc9a74c3d Revert "For #23871 - Update compose to 1.1.0 and kotlin to 1.6.10"
This reverts commit 23f41c9c68.
2 years ago
Mozilla L10n Automation Bot 19ea02077c Import l10n. 2 years ago
Noah Bond ae9f3ab074 For #23238 - Refactor synced tabs sections to be collapsible 2 years ago
Noah Bond e3037ad767 For #23991 - Fix synced tabs error text mapping 2 years ago
MatthewTighe f6872407f3 closes #23997: add day/night versions of applicable wallpapers 2 years ago
Gabriel Luong a6b5ab6726 For #24006 - Return a null change payload if the new top sites list is larger than the old 2 years ago
Gabriel Luong e643591338 For #24014 - Replace @color/secondary_text_private_theme with @color/fx_mobile_private_text_color_secondary 2 years ago
Gabriel Luong 41cb226cf7 For #24014 - Replace @color/caption_text_private_theme with @color/fx_mobile_private_text_color_secondary 2 years ago
Gabriel Luong 5872b0a148 For #24014 - Replace @color/caption_text_normal_theme with @color/fx_mobile_text_color_secondary 2 years ago
AndiAJ 48740095bf Disable rememberAllowAudioVideoPermissionChoiceTest UI test 2 years ago
Gabriel Luong 6fbffa3807 For #24008 - Only refresh the contile top sites cache if feature is enabled 2 years ago
Mozilla L10n Automation Bot 48a93d7ade Import l10n. 2 years ago
Gabriel Luong 9834e818cb For #24017 - Replace @color/foundation_private_theme with @color/fx_mobile_private_layer_color_1 2 years ago
Gabriel Luong 4ae5e8bfb7 For #24022 - Use Border Primary color for Inactive Tabs border 2 years ago
Mozilla L10n Automation Bot 59a09c1d4c Import l10n. 2 years ago
Mozilla L10n Automation Bot 12efddd643 Import l10n. 2 years ago
MatthewTighe 9b4a85942d fixes #23981: open download function and override for test 2 years ago
Sarah541 a222ea521d
For #23821 - Add telemtry for RecentlyVisted Homepage (#23909)
Add test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
2 years ago
Mozilla L10n Automation Bot a9fb2dc718 Import l10n. 2 years ago
Roger Yang c4c263abcb Close #23894: Simplify distinct history algorithm 2 years ago
Gabriel Luong 5e96a6f233 For #23975 - Replace tooltip gradient with Layer Gradient Start, End design tokens 2 years ago
Gabriel Luong 97bf5647c3 For #23880 - Use borderPrimary attribute in empty_session_control_background.xml 2 years ago
Gabriel Luong dfdf386f0b For #23957 - Rename toolbarDivider attribute to borderPrimary 2 years ago
Gabriel Luong f7d317fb4e For #23951 - Replace @color/toolbar_divider_color_private_theme with @color/fx_mobile_private_border_color_divider 2 years ago
Mozilla L10n Automation Bot 4cf82bd8f9 Import l10n. 2 years ago
Roger Yang 77c2ad90b4 Close #13336: Open bookmark in current tab if browsing mode is not private or previous fragment is not home 2 years ago
Gabriel Luong 8fdea8455e For #23949 - Use @color/fx_mobile_private_layer_color_4 for the toolbar gradient in the private theme 2 years ago
Gabriel Luong ed6fe26256 For #23947 - Inline @color/toolbar_menu_transparent 2 years ago
Gabriel Luong 783d2037b6 For #23738 - Integrate the Contile top sites updater 2 years ago
Roger Yang a7442c4474 Close #23804: Use version instead of date for telemetry/metrics expiration 2 years ago
Gabriel Luong 9f04af3557 For #23921 - Remove unused attributes in attrs.xml 2 years ago
Gabriel Luong 2f30442610 For #23905 - Update onboarding icons to use Icon Active color 2 years ago
Gabriel Luong 0f3c82c16b For #23907 - Replace tabTrayItemMediaBackground attribute with accent
tabTrayItemMediaBackground and accent are equivalent
2 years ago
Gabriel Luong d71e31188f For #23888 - Replace @color/white_color with @color/fx_mobile_[icon|text]_color_oncolor
@color/white_color and @color/fx_mobile_[icon|text]_color_oncolor are equivalent
2 years ago
Gabriel Luong f14850bb48 For #23919 - Replace tabRing attribute with accent 2 years ago
Gabriel Luong f71edcd309
Update Android Components version to 99.0.20220223143136. (#23942) 2 years ago
MatthewTighe 9b54df4145 closes #23912: remove sentry reporting from WallpaperDownloader 2 years ago
Christian Sadilek 5ebd4e1569 Revert "For #14321 - Dismiss search dialog buttons on edit cancel"
This reverts commit 2d75ff7d47.
2 years ago
Gabriel Luong 4a7e723009 For #23925 - Update tab counter and reader mode colors to use the design system 2 years ago
mcarare 9a5cd634ab For #23408: Fix pinned top sites count from the cached list. 2 years ago
Gabriel Luong 7a8711247d For #23900 - Update search widget colours to use design tokens 2 years ago
Mozilla L10n Automation Bot e0d1685846 Import l10n. 2 years ago
Roger Yang d1c0e9bf9b Revert "For #13336: Open bookmarks in current tab (#23169)"
This reverts commit e73deb23ac.
2 years ago
Gabriel Luong 1b44f47cd8 For #23902 - Update the top sites pinned icon color to @color/fx_mobile_icon_color_primary 2 years ago
Gabriel Luong 4e8615326e For #23829 - Update private theme design token based on the latest UX changes 2 years ago
MatthewTighe 2cc9ca3773 for #23069: add blocklist middleware for home 2 years ago
Gabriel Luong 0b26bac220 For #23839 - Replace @color/contrast_text_normal_theme with @color/fx_mobile_[text|icon]_color_oncolor 2 years ago
Gabriel Luong 8ae31f625c For #23882 - Use textAccent attribute for Smartblock Learn More link 2 years ago
Gabriel Luong 7713305df1 For #23850 - Replace @color/neutral_text with @color/fx_mobile_[icon|text]_color_oncolor 2 years ago
Gabriel Luong d06c1f5cc0 For #23886 - Use @color/fx_mobile_icon_color_active for tabIndicatorColor 2 years ago
Mugurell 23f41c9c68 For #23871 - Update compose to 1.1.0 and kotlin to 1.6.10 2 years ago
Mozilla L10n Automation Bot 81d8c38de5 Import l10n. 2 years ago
Mozilla L10n Automation Bot 514a8c4437 Import l10n. 2 years ago
Mozilla L10n Automation Bot be78574669 Import l10n. 2 years ago
Mozilla L10n Automation Bot c52880ecb9 Import l10n. 2 years ago
Noah Bond 15c58b7261 For #23808 - Add secret setting for enabling Task Continuity feature 2 years ago
Alexandru2909 5153cee0e0 For #22189 - Replace the 'Firefox' word in all strings with placeholder 2 years ago
Gabriel Luong f47a428f44
For #23771 - Set correct destructive text color for card editor error messages (#23803)
Co-authored-by: tristan-jea <>
Co-authored-by: Tristan <99796140+tristan-jea@users.noreply.github.com>
2 years ago
Roger Yang ef077c5fb1 No issue: Renew/remove metrics set to expire in April 2022 2 years ago
Noah Bond bd4742004c For #19942 - Add support for sticky headers to the synced tabs list 2 years ago
Geordan Neukum 7271f33eff For #23500: creditcards: focus cardNumberInput in createView
Right now, when the user navigates to the "Add Card" screen, the "Card Number"
title will be focused by default. Instead, let's make it so that the first
field for data entry is focused.

Since we're focusing the first field, let's also make sure that the soft
keyboard opens and that the cursor is placed at the end of whatever text has
already been input.
2 years ago
Geordan Neukum 6b78fa3295 For #23500: creditcards: hide keyboard when pausing fragment
Right now, the soft keyboard will remain open when we exit the "Add Card"
screen. Let's make it so that the soft keyboard is automatically closed when
leaving this screen.
2 years ago
Arturo Mejia 64ae748835 For #23752: Address switch is off the screen in the Wallpaper settings. 2 years ago
sunil9211 de4ea0a086 For #23551 - Change the spacing between Pocket header and content to 16dp 2 years ago
Mozilla L10n Automation Bot 208d510ae9 Import l10n. 2 years ago
Roger Yang 7dc969103b No issue: Renew/remove metrics set to expire in March 2022 2 years ago
Roger Yang 20094cd1e9
No issue: Renew/remove metrics set to expire in April 2022 (#23786) 2 years ago
Gabriel Luong c3a2c355a2 For #23769 - Replace @color/destructive_normal_theme with @color/fx_mobile_text_color_warning 2 years ago
Alexandru2909 e1f91aacd3 For #18758 - Update colors on share layout 2 years ago
Gabriel Luong 37683531e7 For #23456 ⁃ Use lifecycleScope in TopSiteItemViewHolder 2 years ago
Mozilla L10n Automation Bot fab2e762c1 Import l10n. 2 years ago
Roger Yang 1559afe7b9 No issue: Update history search string ID 2 years ago
Gabriel Luong 4281dda447 For #23761 - Add Icon Warning Button design token 2 years ago
Gabriel Luong e568f2e151 For #23761 - Add Text Warning Button design token 2 years ago
Gabriel Luong 2ec29b8101 For #23761 - Update Text Warning, Icon Warning and Border Warning light theme to Red70 2 years ago
Gabriel Luong 35212ae6ca For #23761 - Update Action Secondary light theme to LightGrey30 2 years ago
Gabriel Luong bdb6f18d8f For #23761 - Add Text On Color Secondary design token 2 years ago
Gabriel Luong 99d636c23c For #23761 - Rename Text On Color to Text On Color Primary 2 years ago
Roger Yang 3f0b5799f8 Close #23657: Add voice search for history search 2 years ago
Roger Yang 7d8bad05cd Close #23694: Add telemetry for history search 2 years ago
Gabriel Luong cd5be08d2b For #23321 - Replace @color/toolbar_divider_color_normal_theme with @color/fx_mobile_border_color_primary 2 years ago
Matt Tighe 96cda67806 closes #23727: Add a fenix.git tag of the current hash to Sentry reports 2 years ago
Gabriel Luong 3d4340e7ec For #23341 - Replace @color/disabled_normal_theme with @color/fx_mobile_text_color_disabled 2 years ago
Gabriel Luong 869f4c89ee For #23731 - Use the disk cache for the Contile top sites 2 years ago
Mugurell 42282987f8 For #22722 - Rename fragment_crash_reporter to view_crash_reporter
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
2 years ago
Mugurell efc57762f6 For #22722 - Rename CrashReporterFragment to CrashContentView
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
2 years ago
Mugurell bc59ede073 For #22722 - Reacting to the crashed flag
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is true we will show an in-app crash reporter
with the usual close tab / restore tab options and also the option to report
all current non-fatal crashes to Mozilla if the setting for sending the crash
reports is enabled in app settings.
This closely mimics the previous crash reporter UI but there might be some
subtle differences stemming from migrating to using a ComposeView.

Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is false we will set the in-app crash reporter
to have a View.GONE visibility effectively removing it from the layout.

The functionality for receiving the non-fatal crashes from the AC CrashReporter
through an Intent is still kept and these crashes will be persisted in memory
until the user closes / restores a tab and so also makes a decision about
sending or not these crashes.

Currently more tabs can crash following just one since more share the same
process and as such there is no way to differentiate between them or link a
certain Crash to a certain tab.
They will all be acted upon at once from any tab the user chooses to close or
restore.
2 years ago
Mozilla L10n Automation Bot 1e38205f17 Import l10n. 2 years ago
Grigory Kruglov a42018f124 Convert recently closed tabs code to use light-weight TabState
To lighten-up our memory usage and startup performance, all of the RecentlyClosed
machinery was converted to use a light-weight TabState - specifically, it's missing
EngineSessionState, which is expensive to obtain during startup, and potentially
very costly to keep in-memory.

When we actually need EngineSessionState (at the point of restoration of a tab), we
read and rehydrate it using provided storage implementation.
2 years ago
Noah Bond 48141b25a9 For #21900 - Delete files from Synced Tabs XML implementation 2 years ago
Noah Bond 584b2cd83c For #21900 - Delete files from Synced Tabs XML implementation 2 years ago
Gabriel Luong bf70616d93 For #23713 - Replace @color/secondary_text_normal_theme with @color/fx_mobile_text_color_secondary 2 years ago
Matt Tighe f146cefcb8 closes #23662: replace wallpaper thumbnail lazyverticalgrid with manual scroll layout 2 years ago
Gabriel Luong 5bbf8437b3 For #23711 - Replace @color/primary_text_normal_theme with @color/fx_mobile_text_color_primary 2 years ago
Mozilla L10n Automation Bot 45f530b573 Import l10n. 2 years ago
AndiAJ 1baddfaf2d Save logins and external links in custom tabs UI test 2 years ago
Rohan Maity df0d196759 For #20634 remove some lint issues from baseline 2 years ago
Oana Horvath 3d25de721a For #21002: Adds UI test for Addons in private mode 2 years ago
Mozilla L10n Automation Bot 2fee285f77 Import l10n. 2 years ago
Matt Tighe 9643e96244 fixes #23644: reload wallpapers on orientation change 2 years ago
Arturo Mejia 11601770eb For #23679 Update the wallpaper settings switch text 2 years ago
Mozilla L10n Automation Bot 72f0191fcb Import l10n. 2 years ago
Mozilla L10n Automation Bot eea4b07cb5 Import l10n. 2 years ago
Gabriel Luong 37a0edceb6 For #23431 - Display the order of Contile Top Sites correctly 2 years ago
Roger Yang 80c9ad9100 No issue: Update history search string 2 years ago
Mugurell 5bd6f1cb8c For #21854 - Split the big ComposeView in 3 smaller ones
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
Arturo Mejia 9b7e07ab0e Remove stale strings for version 96 2 years ago
mcarare 18f785ddb9 For #22958: Set content description only when view is visible.
This avoids additional processing.
2 years ago
AndiAJ c0918a3d1a New browser functionalities in custom tabs tests 2 years ago
Alexandru2909 2d75ff7d47 For #14321 - Dismiss search dialog buttons on edit cancel 2 years ago
Alexandru2909 d7803e6dc7 For #14954 - Use TabSessionState.id to check if tab is selected 2 years ago
Mozilla L10n Automation Bot 4c4062362c Import l10n. 2 years ago
Noah Bond c0942eadb2 For #23526 - Add telemetry for Contile interactions 2 years ago
jhugman b230c39a7f
Fixes #23492: Perf regression of calling isFirefoxDefault from main thread (#23556)
* Fixes #23492 — Fixup perf regression of calling isFirefoxDefault from the main thread

* Tightening of near defunct default browser message

* Fixup early crash in debug build

* ktlint
2 years ago
AndiAJ 534838c0fb Add and remove most visited top sites UI test 2 years ago
AndiAJ b77496d59d Refactoring work top sites tests 2 years ago
Matt Tighe 0c297dcee2 closes #23540: scale wallpaper and translate to bottom of image 2 years ago
Roger Yang 1d1412c766 Close #23626: Do not exit edit mode in history search toolbar 2 years ago
Mozilla L10n Automation Bot fa8cb6bb34 Import l10n. 2 years ago
Matt Tighe 24d2abd2b2 fixes #23619: use well-defined name for fetching remote wallpaper assets 2 years ago
Sarah Khan 26c7562e62 For #23596 and #23309 - Add deeplink to wallpaper settings 2 years ago
Matt Tighe b7b601eee1 closes #23616: add final path separator to reote path 2 years ago
Jonathan Almeida 4c953bc910 No issue: Update debug app name to Fenix
We don't use the "Preview" naming any more and it's easier to find the app when "Fenix" is in the app name.
2 years ago
Arturo Mejia c90dcaa314 For #23577: Make description text on the wallpapers settings page align with the start of the switch 2 years ago
AndiAJ 84a8030daa New verifyMultipleLoginsSelectionsTest UI Smoke test 2 years ago
Oana Horvath f45c5876dc Re-write toggleSearchBookmarksAndHistoryTest 2 years ago
Oana Horvath 143df5251f Ads new voice search UI test 2 years ago
Oana Horvath 886b4049cb Re-organize existing tests to their own SettingsSearchTest class 2 years ago