For #13336: Open bookmarks in current tab (#23169)

* For #13336: Open bookmarks in current tab

* For #13336: Fix tests to verify bookmark opening in current tab

* Change test name for handleBookmarkTapped
upstream-sync
Lucius C 2 years ago committed by GitHub
parent 39f83e20fa
commit e73deb23ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -77,7 +77,7 @@ class DefaultBookmarkController(
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
openInNewTabAndShow(
item.url!!,
true,
false,
BrowserDirection.FromBookmarks,
activity.browsingModeManager.mode,
flags

@ -110,7 +110,7 @@ class BookmarkControllerTest {
}
@Test
fun `handleBookmarkTapped should load the bookmark in a new tab`() {
fun `handleBookmarkTapped should load the bookmark in the current tab`() {
var invokePendingDeletionInvoked = false
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
@ -124,7 +124,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
true,
false,
BrowserDirection.FromBookmarks,
flags = flags
)
@ -290,7 +290,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
true,
false,
BrowserDirection.FromBookmarks,
flags = flags
)

Loading…
Cancel
Save