Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Code Issues Releases Wiki Activity

For #24051 - Remove showStartOnHomeSettings feature flag

Browse Source
This commit is contained in:
Gabriel Luong 2022-03-01 18:05:46 -05:00 committed by mergify[bot]
parent 4becaaa8cc
commit 09101eb787
6 changed files with 3 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
View File

@ -23,11 +23,6 @@ object FeatureFlags {
*/
val addressesFeature = Config.channel.isNightlyOrDebug
/**
* Enables the Start On Home feature in the settings page.
*/
const val showStartOnHomeSettings = true
/**
* Enables the "recent" tabs feature in the home screen.
*/

7
app/src/main/java/org/mozilla/fenix/HomeActivity.kt
View File

@ -241,9 +241,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
if (!shouldStartOnHome() && shouldNavigateToBrowserOnColdStart(savedInstanceState)) {
navigateToBrowserOnColdStart()
} else {
if (FeatureFlags.showStartOnHomeSettings) {
components.analytics.metrics.track(Event.StartOnHomeEnterHomeScreen)
}
components.analytics.metrics.track(Event.StartOnHomeEnterHomeScreen)
}
Performance.processIntentIfPerformanceTest(intent, this)
@ -1011,9 +1009,6 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
* links from an external apps should always opened in the [BrowserFragment].
*/
fun shouldStartOnHome(intent: Intent? = this.intent): Boolean {
if (!FeatureFlags.showStartOnHomeSettings) {
return false
}
return components.strictMode.resetAfter(StrictMode.allowThreadDiskReads()) {
// We only want to open on home when users tap the app,
// we want to ignore other cases when the app gets open by users clicking on links.

4
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -537,9 +537,7 @@ class HomeFragment : Fragment() {
}
binding.tabButton.setOnClickListener {
if (FeatureFlags.showStartOnHomeSettings) {
requireComponents.analytics.metrics.track(Event.StartOnHomeOpenTabsTray)
}
requireComponents.analytics.metrics.track(Event.StartOnHomeOpenTabsTray)
openTabsTray()
}

6
app/src/main/java/org/mozilla/fenix/settings/HomeSettingsFragment.kt
View File

@ -5,10 +5,9 @@
package org.mozilla.fenix.settings
import android.os.Bundle
import androidx.preference.CheckBoxPreference
import androidx.navigation.findNavController
import androidx.preference.CheckBoxPreference
import androidx.preference.Preference
import androidx.preference.PreferenceCategory
import androidx.preference.PreferenceFragmentCompat
import androidx.preference.SwitchPreference
import org.mozilla.fenix.FeatureFlags
@ -87,9 +86,6 @@ class HomeSettingsFragment : PreferenceFragmentCompat() {
isVisible = FeatureFlags.showWallpapers
}
requirePreference<PreferenceCategory>(R.string.pref_key_start_on_home_category).isVisible =
FeatureFlags.showStartOnHomeSettings
addToRadioGroup(
openingScreenRadioHomepage,
openingScreenLastTab,

1
app/src/main/res/values/preference_keys.xml
View File

@ -264,7 +264,6 @@
<string name="pref_key_start_on_home_after_four_hours" translatable="false">pref_key_start_on_home_after_four_hours</string>
<string name="pref_key_start_on_home_always" translatable="false">pref_key_start_on_home_always</string>
<string name="pref_key_start_on_home_never" translatable="false">pref_key_start_on_home_never</string>
<string name="pref_key_start_on_home_category" translatable="false">pref_key_start_on_home_category</string>
<string name="pref_key_camera_permissions_needed" translatable="false">pref_key_camera_permissions_needed</string>
<string name="pref_key_inactive_tabs_category" translatable="false">pref_key_inactive_tabs_category</string>
<string name="pref_key_inactive_tabs" translatable="false">pref_key_inactive_tabs</string>

2
app/src/main/res/xml/home_preferences.xml
View File

@ -45,8 +45,6 @@
android:layout="@layout/preference_cat_style"
android:title="@string/preferences_opening_screen"
app:allowDividerAbove="true"
app:isPreferenceVisible="false"
android:key="pref_key_start_on_home_category"
app:iconSpaceReserved="false">
<org.mozilla.fenix.settings.RadioButtonPreference