Revert "For #13336: Open bookmarks in current tab (#23169)"

This reverts commit e73deb23ac.
upstream-sync
Roger Yang 2 years ago committed by mergify[bot]
parent 1b44f47cd8
commit d1c0e9bf9b

@ -77,7 +77,7 @@ class DefaultBookmarkController(
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
openInNewTabAndShow(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
activity.browsingModeManager.mode,
flags

@ -110,7 +110,7 @@ class BookmarkControllerTest {
}
@Test
fun `handleBookmarkTapped should load the bookmark in the current tab`() {
fun `handleBookmarkTapped should load the bookmark in a new tab`() {
var invokePendingDeletionInvoked = false
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
@ -124,7 +124,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
flags = flags
)
@ -290,7 +290,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
flags = flags
)

Loading…
Cancel
Save