Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
8,028 Commits 67 Branches 115 Tags 1.2 GiB
dd714d3a15
Commit Graph

6694 Commits

Author SHA1 Message Date
Arturo Mejia
fc42d08c06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18629: add support for SmartBlock exceptions 2021-09-13 21:26:47 +00:00
Arturo Mejia
5d55e07dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen. 2021-09-13 03:23:43 +00:00
Arturo Mejia
ea5d0ee63d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21211 hide the ETP in custom tabs. 2021-09-13 02:55:39 +00:00
Mozilla L10n Automation Bot
d7355dc309 [fenix] Import l10n. 2021-09-12 00:33:34 +00:00
Mozilla L10n Automation Bot
4ff053609b [fenix] Import l10n. 2021-09-11 00:34:58 +00:00
AndiAJ
aa63facce4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21133 fix openMainMenuSyncItemTest UI test 2021-09-10 12:22:58 +00:00
bendk
739d93372e [fenix] Handle breaking changes from a-s 83.0.0 (https://github.com/mozilla-mobile/fenix/pull/21215) 2021-09-09 19:41:55 -07:00
Mozilla L10n Automation Bot
a9cdb1984c [fenix] Import l10n. 2021-09-10 00:36:30 +00:00
Noah Bond
434c0b6918 [fenix] Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/20637 - Fixed bug causing the tabs tray to scroll to the wrong tab when opened 2021-09-09 22:39:02 +00:00
mcarare
1d78c8b1a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6968: Use close instead of read to close the response stream. 2021-09-09 22:10:28 +00:00
Arturo Mejia
42a5fcc880 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 allow users to configure their home screen. 2021-09-09 14:38:26 -04:00
Elise Richards
d0757d386a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19947: manually add login (https://github.com/mozilla-mobile/fenix/pull/21199) 
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it.
Fixed bindings.

* [WIP] Removed "reveal password" button

* [WIP] Added interactor for the add login screen

* [WIP] Trying to check for duplicates

* [WIP] Renaming "addNew..." with "add..."

* [WIP] Check for duplicates

* [WIP] Fixes after merge

* Cleaning up the layout and making edit text for hostname selectable

* Error handling on add login screen. Tests for interactors and controllers

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-09 16:30:33 +00:00
Mozilla L10n Automation Bot
0ea0ce4532 [fenix] Import l10n. 2021-09-09 00:42:03 +00:00
Michael Comella
df0b8e5886 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove view hierarchy depth check from excessive resource test. 
This doesn't seem to be a high value test: increasing the view hierarchy
depth will only result in a performance problem on low end devices
if there is enough content on the new layer to cause the traversal to
take longer. It's more likely to result in a hard-to-workaround false
positive so we can remove it, like component init count.
 2021-09-08 23:06:08 +00:00
Michael Comella
88f34d654e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove lazyMonitored wrapper functionality. 
We're not using the functionality so there's no sense in doing the work.
However, we keep the wrapper: see the code comments for details.
 2021-09-08 23:06:08 +00:00
Michael Comella
afea6772f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove component init check from excessive resource test. 
This check doesn't seem high value because initializing a component
only indicates a performance problem if it's slow, which is not most
components, so it's likely to result in many false positives. To fix
the intermittent, we won't lose much if we remove it.
 2021-09-08 23:06:08 +00:00
Arturo Mejia
c42b4d7481 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection panel strings 2021-09-08 22:20:00 +00:00
Noah Bond
691fe57943 [fenix] Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. (https://github.com/mozilla-mobile/fenix/pull/21141) 
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab.

* Fixed RecentTabsListFeatureTest unit test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-08 20:17:54 +00:00
Arturo Mejia
1e64f87d67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20881 print if the build is a MozillaOnline 2021-09-08 16:03:59 +00:00
Mozilla L10n Automation Bot
03932cc800 [fenix] Import l10n. 2021-09-08 01:17:08 +00:00
Elise Richards
4be9b84c20 [fenix] Dont clip bounds on recently saved bookmarks 2021-09-08 00:39:35 +00:00
Michael Comella
c5b2185119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21138: change EXPECTED_RUNBLOCKING to range. 
Compared with my local runs, CI sees +1 runBlockingIncrement calls so seems to
take other code paths. As such, we search for a range of rather than a single
value. The main downside I can think of is this could make the test trickier to
debug but we can wait and see if that's a problem in practice before taking
action on it.
 2021-09-07 21:53:43 +00:00
Michael Comella
d4c2608670 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21138: re-enable excessive resource use test. 
This test wasn't running in CI
https://github.com/mozilla-mobile/fenix/issues/20386 so we changed the
CI configuration so that it will. However, the test was then failing so
this is the revision that unignores the test.

I wonder if componentInit count is useful - it seems like it'd cause
more false positives than not - but I figure we can leave it in and see
how it goes.
 2021-09-07 21:53:43 +00:00
Roger Yang
e7c3145fec [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill 2021-09-07 19:16:04 +00:00
Mozilla L10n Automation Bot
5fe3efeb98 [fenix] Import l10n. 2021-09-07 00:34:03 +00:00
Mozilla L10n Automation Bot
09eb475097 [fenix] Import l10n. 2021-09-06 00:33:56 +00:00
Mozilla L10n Automation Bot
dac9585e2d [fenix] Import l10n. 2021-09-05 00:33:45 +00:00
Mozilla L10n Automation Bot
ce52e5510b [fenix] Import l10n. 2021-09-04 00:37:01 +00:00
Mozilla L10n Automation Bot
6c724c7f13 [fenix] Import l10n. 2021-09-03 08:10:58 +00:00
Arturo Mejia
c0e8005c76 [fenix] For 20892 Update connection icons in address bar 2021-09-02 23:52:55 +00:00
Christian Sadilek
193016b662 [fenix] Remove mocked lambdas from AccountSettingsInteractorTest 2021-09-02 21:44:35 +00:00
Christian Sadilek
e9b1f3fb81 [fenix] Add missing androidx.lifecycle dependencies 2021-09-02 21:44:35 +00:00
Mozilla L10n Automation Bot
9865ade3f8 [fenix] Import l10n. 2021-09-02 11:50:36 +00:00
czlucius
2d6dffe36a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18727: Exit PiP when launched externally with Intents 2021-09-02 09:04:13 +00:00
Mickey Moz
dccc1133b1 [fenix] Update Android Components version (https://github.com/mozilla-mobile/fenix/pull/21109) 
* Update Android Components version to 93.0.20210901143120.

* For https://github.com/mozilla-mobile/fenix/issues/21043 - Integrate AC changes

* Fix breaking API changes of RestoreAction

Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-09-01 18:08:19 -04:00
Christian Sadilek
cda4440bad [fenix] Do not run unit tests in parallel 
This is to investigate the intermittent mockk class
generation/loading issues. Since we can not reproduce
locally and the failures are intermittent they could
be caused by us running unit tests in parallel.
 2021-09-01 16:27:07 -04:00
codrut.topliceanu
bde4c0207a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19166: Increases tab_tray_list bottom padding 
... to fit snackbar and FAB
 2021-09-01 07:59:16 +00:00
Mozilla L10n Automation Bot
b4bf6f22fd [fenix] Import l10n. 2021-09-01 00:47:49 +00:00
Gabriel Luong
9d12ec623c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21078 - Remove unused creditCardsFeature feature flag 2021-08-31 20:10:53 +00:00
Elise Richards
061e5bf6af [fenix] Include data review for renewed metrics 2021-08-31 18:28:05 +00:00
Elise Richards
2d433166a8 [fenix] Remove banner open in app telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
edd26c3363 [fenix] Remove search suggestions in private telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
4d2c0b9caf [fenix] Remove user specified search engine telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
17ad77ea02 [fenix] Remove private browsing shortcut telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
49c3b46145 [fenix] Fix data-review listed for default_browser_changed, toolbar_menu_visible, and toolbar_menu_clicked 2021-08-31 18:28:05 +00:00
Elise Richards
5abec1fb15 [fenix] Remove private browsing mode telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
1e05446283 [fenix] Remove tip telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
83416415b8 [fenix] Remove enable private search suggestions telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
49e6325de4 [fenix] Remove open links in private tab telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
61d95c4967 [fenix] Remove find in page telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
9c5bb84cb1 [fenix] Remove total uri count telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
dd398def06 [fenix] Remove about page telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
09132f35ac [fenix] Remove downloads management telemetry 2021-08-31 18:28:05 +00:00
Elise Richards
9a432d9f64 [fenix] Remove downloads misc telemetry. 2021-08-31 18:28:05 +00:00
Elise Richards
dbf3897680 [fenix] Remove download notification telemetry. 2021-08-31 18:28:05 +00:00
Elise Richards
cf2d620e0e [fenix] Remove master password telemetry. 2021-08-31 18:28:05 +00:00
Elise Richards
feb4af320b [fenix] Renew probes set to expire in September 2021-08-31 18:28:05 +00:00
Elise Richards
cc642da2e8 [fenix] Renew probes set to expire in October 2021-08-31 18:28:05 +00:00
Gabriel Luong
41f1202daa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21037 - Add a delete history menu item 
This removes the existing "Delete history" button in the History in favour of a menu item
 2021-08-31 18:02:09 +00:00
Arturo Mejia
938992c39a [fenix] Add tint to settings icon on Tracking protection panel 2021-08-31 02:14:24 +00:00
Mozilla L10n Automation Bot
acb12761e4 [fenix] Import l10n. 2021-08-31 01:38:53 +00:00
AndiAJ
3af7f3dfd4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 update and add missing tabs setting validations 2021-08-31 01:09:16 +00:00
Oana Horvath
2642dfc203 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20702: fix tests flakiness 2021-08-30 20:33:03 +00:00
Sebastian Kaspari
e38ed593d4 [fenix] Enable Android Autofill support in all build types. 2021-08-30 18:20:22 +00:00
Mozilla L10n Automation Bot
1bbf5bda7c [fenix] Import l10n. 2021-08-30 00:32:56 +00:00
Mozilla L10n Automation Bot
4df5f7f8b9 [fenix] Import l10n. 2021-08-29 00:39:20 +00:00
Gabriel Luong
054f6b5626 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21035 - Refactor HistoryViewInteractor from HistoryView into HistoryInteractor 2021-08-26 21:04:49 +00:00
Oana Horvath
e619f4b030 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21002: added page main menu items tests 2021-08-26 08:21:10 +00:00
Christian Sadilek
690f3e72f5 [fenix] Dedupe history metadata in groups based on url 2021-08-25 20:19:50 +00:00
Elise Richards
19c10c3779 [fenix] Update search metric expiration dates (https://github.com/mozilla-mobile/fenix/pull/21016) 2021-08-25 14:43:17 -04:00
Arturo Mejia
115cc74bb8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 add confirm dialog when turning on/off experiments 2021-08-24 23:47:14 +00:00
Arturo Mejia
38c5617b7e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20871 mark strings for removal 2021-08-24 23:15:06 +00:00
Elise Richards
d105e8bc19 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19931: Add telemetry probes for recent bookmarks on home screen (https://github.com/mozilla-mobile/fenix/pull/20316) 
* Add telemetry probes for recent bookmarks on home screen. Tests for controller.

* Make the events into counters in the metrics ping

Update tests to reflect new metrics

Add data review link for new metrics

Mock new settings for startup metrics tests

Update metrics

Add test for recent bookmark glean events

* Recent bookmarks controller tests
 2021-08-24 12:30:13 -07:00
Mugurell
7b7a252ecf [fenix] For https://github.com/mozilla-mobile/fenix/issues/20507 - Inactive tabs telemetry 
Two new events are added:
- "inactive_tabs_expanded" for when the inactive tabs section is expanded
- "inactive_tabs_collapsed" for when the inactive tabs section is collapsed

For tracking when an inactive tab is opened / closed I've repurposed the
existing tabs tray telemetry (since the functionality uses the same code)
- tabs_tray.opened_existing_tab
- tabs_tray.closed_existing_tab
to support an extra "source" key indicating the feature from which a tab was
opened or closed. The current values for this new key are:
- "Tabs tray" for when a tab was opened/closed from tabs tray
- "Inactive tabs" for when a tab was openes/closed from the Inactive tabs
section of the tabs tray.
 2021-08-24 12:10:58 +00:00
Mugurell
785a42edfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the Kotlin synthetics Lint detector 
Since all usages of Kotlin synthetics are removed and no such code is generated
anymore there is no need to keep around this Detector anymore.
 2021-08-24 10:26:36 +00:00
Mugurell
4466a39727 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the kotlin-android-extensions plugin 
This means no code will be generated by Kotlin Android Extensions for caching
views and also for @Parcelize annotated classes.

As recommended in the official documentation
https://developer.android.com/topic/libraries/view-binding/migration#gradle
we need to switch on using `kotlinx.parcelize.Parcelize` instead of
`import kotlinx.android.parcel.Parcelize`

For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the `kotlin-android-extensions` plugin

This means no code will be generated by Kotlin Android Extensions for caching
views and also for @Parcelize annotated classes.

As recommended in the official documentation
https://developer.android.com/topic/libraries/view-binding/migration#gradle
we need to switch on using `kotlinx.parcelize.Parcelize` instead of
`import kotlinx.android.parcel.Parcelize`
 2021-08-24 10:26:36 +00:00
Mugurell
9959334a26 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Finish migrating all synthetics usages 2021-08-24 10:26:36 +00:00
codrut.topliceanu
ecae7a61be [fenix] For https://github.com/mozilla-mobile/fenix/issues/20328 - Adds telemetry for recentlyClosed button 
...from tabsTray, inactiveTabs section.
 2021-08-24 09:52:33 +00:00
Oana Horvath
d689ee206f [fenix] For https://github.com/mozilla-mobile/fenix/issues/20716: re-enables mainMenuInstallPWATest UI test 2021-08-24 08:25:34 +00:00
Oana Horvath
eb8aeec73e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20868, https://github.com/mozilla-mobile/fenix/issues/18764: Update Tracking Protection UI tests 2021-08-24 08:25:34 +00:00
Grisha Kruglov
dd1b4ba5ae [fenix] Closes 20975: Run metadata cleanup after Megazord.init() 
This ensures that we do not attempt places initialization before
Megazord.init() finishes, and that touching BrowserStore does not
kick-off places initialization (due to the `cleanup` call being a
side-effect of creating metadata middleware, used as part of the
BrowserStore).

Glean initialization happens before initialize megazord, and it touches
core.store BrowserStore instance, kicking-off places initialization on
an IO thread (due to the cleanup call), which raced megazord
initialization on the main thread.

App init sequence is a bit of a mine-field, so this patch takes the easy
way out and doesn't attempt to re-order initialization sequence. Also,
initializing places as a side-effect of touching BrowserStore was also,
clearly, a bug.
 2021-08-23 22:29:46 +00:00
codrut.topliceanu
48eff4f831 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in add-ons 2021-08-23 15:49:22 +00:00
Mugurell
f826174109 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20586 - Put everything behing a secret setting 
Not ready for prime-time. Lot of work still to be done.
 2021-08-23 14:38:06 +00:00
Mugurell
b1cc91a9ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/20586 - Basic Jetpack Compose implementation. 
This is just the basic skeleton for the feature.
 2021-08-23 14:38:06 +00:00
Arturo Mejia
96042fa50a [fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection icons in quick settings 2021-08-23 13:35:45 +00:00
mcarare
2adea3fd40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20927: Replace icons with AC icons. 2021-08-23 08:16:55 +00:00
rxu
d457385e79 [fenix] Use armeabi-v7a version code for MozillaOnline builds 2021-08-23 05:51:00 +00:00
Arturo Mejia
06f86c42c4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quite the app when turning on/off experiments 2021-08-23 03:39:55 +00:00
Rohan Maity
7ffaefd3fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove startup timeline probes 2021-08-22 00:57:10 +00:00
Jonathan Almeida
d2b9962319 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20945: Fix failing test in AccountSettingsInteractorTest 2021-08-20 21:23:25 +00:00
Jonathan Almeida
eae779d231 [fenix] Speculative fixes intermittent test in DeleteAndQuitTest 2021-08-20 19:26:42 +00:00
Arturo Mejia
b50ecb92b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quit the after removing a study. 2021-08-20 15:07:00 +00:00
codrut.topliceanu
4e917c5eac [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in tabs tray 2021-08-20 14:18:39 +00:00
Mugurell
5b99139048 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate home from Kotlin synthetics to View Binding. 2021-08-20 13:45:05 +00:00
Mugurell
b38f717c4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate browser from Kotlin synthetics to View Binding. 2021-08-20 13:15:39 +00:00
codrut.topliceanu
c0d03b3d1e [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in Login Exceptions 2021-08-20 09:44:12 +00:00
rxu
36aed742b3 [fenix] Add event ping telemetry for the Baidu top site click 2021-08-20 03:46:20 +00:00
Grisha Kruglov
988712dd63 [fenix] Enable recording of history metadata for all builds 
This allows recording part of history metadata to ride the trains.
The UI features are still guarded by the secret settings flag (or,
enabled on debug builds).
 2021-08-19 23:07:06 +00:00
Arturo Mejia
a82a02a9e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20890 when TP is off globally hide TP section on quick settings. 2021-08-19 22:36:25 +00:00
Roger Yang
1928220c0d [fenix] Restore unused string tab_collection_dialog_negative 2021-08-19 21:46:56 +00:00
Grisha Kruglov
9268b550c2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20901: Do not record viewTime observations when we do not have a set lastAccess 
The bug here was that we'd try to record `now - 0` as a viewTime delta.
This isn't just an obviously wrong value to record, but it will also
overflow our storage - we'll end up with a value on disk that doesn't
fit into an i32, but HistoryMetadata.total_view_time is i32 in our Rust
struct. Once that happens, reads that touch this bad row will result in
an overflow and a crash.
 2021-08-19 13:30:32 -07:00
Roger Yang
0a2cdff945 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2783: Add snackbar to collection deletion 2021-08-19 17:06:45 +00:00
codrut.topliceanu
c4bc780c28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20716 - Disables Intermittent failing UI test 2021-08-19 16:10:12 +00:00
Sebastian Kaspari
b9d7552339 [fenix] metrics.yaml: Add data review URL for Android Autofill metrics 2021-08-19 15:13:37 +00:00
Roger Yang
52cb17d12a [fenix] Update Android Components version 2021-08-19 14:04:18 +00:00
Jonathan Almeida
aded72af41 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20864: Speculative fix for HomeFragmentTest failures 2021-08-18 08:55:45 +00:00
codrut.topliceanu
5e0b094e4f [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in tracking protection(2) 2021-08-18 07:40:26 +00:00
Michael Comella
c80a53f93e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20824: use fast service loader for MainDispatcherFactory. 
For details on the root cause, see the commit. We replaced the similar
proguard rules because:
- the key line was returning false instead of true
- the other line had the same outcome as the written code. I believe it
  was a micro-optimization. Since perf seems fine without it, let's
  remove it

I benchmarked this change on COLD MAIN first frame. We see an
improvement of 89ms:
- before: 1346ms
- after: 1257ms
 2021-08-18 03:59:44 +00:00
codrut.topliceanu
a4a1f6ddaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in Share views 2021-08-18 03:27:17 +00:00
codrut.topliceanu
179dd793ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in Onboarding Tests 2021-08-18 02:47:50 +00:00
Arturo Mejia
33ac87cbd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 use block color on disabled permissions 2021-08-17 01:42:42 +00:00
Mozilla L10n Automation Bot
841b304f0d [fenix] Import l10n. 2021-08-17 00:36:38 +00:00
Jonathan Almeida
591d6744df [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796: Additional fixes for intermittent failing test 
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
 2021-08-16 22:54:22 +00:00
Arturo Mejia
93f23aa750 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding. 2021-08-16 16:42:39 -04:00
Arturo Mejia
2e60b8d80a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 fix ui tests 2021-08-16 16:42:39 -04:00
Gabriel Luong
2d6dcb814c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog 2021-08-16 16:42:39 -04:00
Arturo Mejia
39dc0701a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation 2021-08-16 16:42:39 -04:00
Gabriel Luong
c9575d0d62 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR 2021-08-16 16:42:39 -04:00
Gabriel Luong
609acda69c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Use the new "Details" text for navigating to ETP details 2021-08-16 16:42:39 -04:00
Arturo Mejia
ab1e4228c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu. 2021-08-16 16:42:39 -04:00
Gabriel Luong
7d8ca1ec98 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-08-16 16:42:39 -04:00
Gabriel Luong
66192cc136 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add right arrowheader to tracking protection navigators 2021-08-16 16:42:39 -04:00
Gabriel Luong
9bb39fe7b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings 2021-08-16 16:42:39 -04:00
Gabriel Luong
23d57b151f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add navigation from quick settings to tracking protection panel 2021-08-16 16:42:39 -04:00
Gabriel Luong
70d55f4746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator 2021-08-16 16:42:39 -04:00
Mozilla L10n Automation Bot
0196a85e19 [fenix] Import l10n. 2021-08-16 16:49:49 +00:00
Jonathan Almeida
8c5bccf445 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853: Fix intermittent failing test in HomeFragmentStoreTest 2021-08-16 16:19:38 +00:00
Jonathan Almeida
b9c243c0ec [fenix] Update TabSessionState.createdAt for inactive tabs debugging 2021-08-16 15:53:25 +00:00
Arturo Mejia
d735df1dd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string 2021-08-16 11:24:42 -04:00
Sebastian Kaspari
7e548348e3 [fenix] Android Autofill: Use AppCompat theme for UnlockActivity. 2021-08-16 08:00:13 +00:00
Arturo Mejia
3dc3db856c [fenix] Remove duplicated line in TabsSettingsFragment 2021-08-16 07:29:52 +00:00
Sebastian Kaspari
eb35f06802 [fenix] Use theming in debug screen. 2021-08-16 07:03:29 +00:00
Jonathan Almeida
632311b1ea [fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168: Remove intermittent failing test in ToolbarViewTest 
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.

This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.

It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.

So therefore.. 🔥
 2021-08-14 01:52:52 -04:00
Jonathan Almeida
d32727eff9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796: Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest 2021-08-14 01:52:52 -04:00
Jonathan Almeida
14735a61ae [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795: Speculative fix for intermittent test failures in HomeFragmentTest 
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
 2021-08-14 01:52:52 -04:00
Jonathan Almeida
a590fd2b74 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797: Fix intermittent test failures in ShortcutsSuggestionProviderTest 2021-08-14 01:52:52 -04:00
Jonathan Almeida
9b20f9c1c0 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792: Fix intermittent test failures in QuickSettingsFragmentReducerTest 2021-08-14 01:52:52 -04:00
Aaron Train
f2fe9ae61d [fenix] Filter out test target packages in Flank-x86 (https://github.com/mozilla-mobile/fenix/pull/20841) 
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
 2021-08-13 15:00:10 -04:00
Michael Comella
fce543516e [fenix] No issue: move kotlin-allopen outside appVariants loop. 
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
 2021-08-12 20:39:27 +00:00
Elise Richards
cc2f37b040 [fenix] Use header20 style on collections to match other home items. Add margin above collections. (https://github.com/mozilla-mobile/fenix/pull/20633) 2021-08-12 19:32:38 +00:00
Jonathan Almeida
00cb0c74f3 [fenix] Update the description for an inactive tabs string 2021-08-12 17:44:56 +00:00
Steven Knipe
982dc4410f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets 2021-08-12 13:54:13 +00:00
codrut.topliceanu
4082b5eb90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20098: Allow PB PiP video screenshots 
...when `Allow screenshots in private browsing` is enabled
 2021-08-12 06:49:55 +00:00
Rohan Maity
620d034134 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes 2021-08-11 22:31:52 +00:00
Arturo Mejia
d4a2d1ac83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments 2021-08-11 16:14:13 -04:00
Arturo Mejia
be0f7d9dcc [fenix] Disable intermittent tests. 2021-08-11 19:05:06 +00:00
Arturo Mejia
8ff9adb54e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account 2021-08-11 17:39:33 +00:00
codrut.topliceanu
f4f6b18cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in history screens 2021-08-11 15:29:35 +00:00
codrut.topliceanu
c441adb0d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in collections 2021-08-11 08:01:58 +00:00
Vitaly V. Pinchuk
21fedbf45f [fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes. 2021-08-10 12:01:29 +00:00
Michael Comella
b8f673380f [fenix] No issue: remove unnecessary robolectric annotations. 
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
 2021-08-10 00:22:44 +00:00
Elise Richards
7273536742 [fenix] For FNXV2-17067: always show home in background behind search dialog (https://github.com/mozilla-mobile/fenix/pull/20573) 
* Navigate to home on toolbar click. Handle back press from search dialog

Update tests to show home behind search dialog. Remove unused test.

Jump back in show all button is clickable behind search dialog

Recently saved bookmarks show all button is clickable behind search dialog

* Add feature flag

* Past explorations show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests.

Allow collections to be visible behind search dialog

Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard

Verify navigateUp in tests

Adding ignore for flaky UI test

Only resize home behind search dialog

Add ignore for collection intermittent test

Cleanup
 2021-08-09 15:40:41 +00:00
codrut.topliceanu
33b08b6b83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in downloads screen 2021-08-09 11:06:28 +00:00
mcarare
dcbd978c73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Re-add tests for class BookmarksUseCaseTest. 2021-08-09 09:46:27 +00:00
AndiAJ
8f3313ad02 [fenix] Start on home UI tests 2021-08-09 07:34:16 +00:00
Mozilla L10n Automation Bot
2120e07768 [fenix] Import l10n. 2021-08-09 00:41:53 +00:00
Mozilla L10n Automation Bot
8c1a00b21c [fenix] Import l10n. 2021-08-08 00:40:54 +00:00
Jonathan Almeida
feb8f5e363 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726: Fix intermittent failure in AddonsManagementViewTest 2021-08-06 22:27:28 +00:00
Jonathan Almeida
0a0af212f0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20718: Show url if title is missing for inactive tabs 2021-08-06 22:00:38 +00:00
Elise Richards
3bfd5d1827 [fenix] Correct search_count telemetry after revert 2021-08-06 21:26:43 +00:00
Roger Yang
1612db86c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20723: Fix credit card management fragment binding 2021-08-06 20:59:38 +00:00
Michael Comella
b4ce5abf0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697: replace mockked lambda in DownloadControllerTest. 
This is expected to fix the intermittent failure in this test.
 2021-08-06 20:32:16 +00:00
Michael Comella
13249f7080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679: revert allowaccessmodification proguard disabling. 
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.

This commit reverts the following commits:

Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.

Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
 2021-08-06 20:07:32 +00:00
Jonathan Almeida
3c66fa4833 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19956: Add telemetry for tab view setting changes 
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in https://github.com/mozilla-mobile/fenix/issues/19809).
 2021-08-06 19:33:54 +00:00
Christian Sadilek
18a51be61c [fenix] Update Android Components version to 92.0.20210806164329 (https://github.com/mozilla-mobile/fenix/pull/20722) 
Addresses breaking change in ShortcutsSuggestionProvider
 2021-08-06 14:19:56 -04:00
codrut.topliceanu
6c15482c9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in bookmarks screen 2021-08-06 15:52:00 +00:00
Jonathan Almeida
d4ab4f3572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663: Make inactive card collapsible 
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.

In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
 2021-08-06 15:23:10 +00:00
Mugurell
75aeb961e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector 
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
 2021-08-06 14:09:15 +00:00
codrut.topliceanu
2971cd309d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray 2021-08-06 12:37:44 +00:00
Grisha Kruglov
39561f3644 [fenix] External source support 
Adds handling of information about external referrer (package, category)
when dealing with external intents.
 2021-08-05 17:30:00 -07:00
Roger Yang
333840f02e [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill (https://github.com/mozilla-mobile/fenix/pull/19548)" 
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
 2021-08-05 18:53:46 +00:00
Roger Yang
cffad4f424 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping (https://github.com/mozilla-mobile/fenix/pull/19733)" 
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
 2021-08-05 18:53:46 +00:00
Mozilla L10n Automation Bot
60da5771b7 [fenix] Import l10n. 2021-08-05 16:53:04 +00:00
Mugurell
b583864643 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI 
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
 2021-08-05 15:52:06 +00:00
Mugurell
19767246f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Use CombinedHistorySuggestionProvider for history suggestions 
This should ensure user is always presented with history results for his
searches.
 2021-08-05 15:52:06 +00:00
Mozilla L10n Automation Bot
317bf219d0 [fenix] Import l10n. 2021-08-05 14:48:56 +00:00
Jonathan Almeida
cdade5b44a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664: Do not consider newly created tabs as inactive 2021-08-05 01:37:43 +00:00
Jonathan Almeida
cb4a24d6a6 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20674: Remove elevation from inactive tabs card 2021-08-05 01:37:43 +00:00
Sebastian Kaspari
5949766c5d [fenix] Enable Android Autofill in Beta builds. 2021-08-04 21:07:42 +00:00
mcarare
a710775406 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Use View binding in quick settings. 2021-08-04 09:32:08 -04:00
Mozilla L10n Automation Bot
bd036901ae [fenix] Import l10n. 2021-08-04 01:09:21 +00:00
Arturo Mejia
39ea051a14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19970 [Crash] IllegalStateException when navigating to TP panel 2021-08-04 00:17:13 +00:00
Christian Sadilek
24b4a03d32 [fenix] Fix intermittent test failures in ToolbarViewTest 2021-08-03 23:34:02 +00:00
Roger Yang
b901490a1b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650: Revert to manually close tab as default setting 2021-08-03 22:44:14 +00:00
Arturo Mejia
724fb8b60f [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Undo Use View binding in quick Settings. 2021-08-03 15:34:38 -04:00
Michael Comella
68bef957b5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20461: remove app_received_intent probe. 2021-08-03 18:19:12 +00:00
Sebastian Kaspari
6109d61cd7 [fenix] Fix UI tests: SettingsPrivacyTest, DeepLinkTest. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
6e4060fa5a [fenix] Add preference for enabling/disabling Android Autofill from within the app. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
7f6cdd491b [fenix] Add dialog-like theme for AutofillSearchActivity 2021-08-03 11:10:21 +00:00
Michael Comella
d0ca64a9a4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631: remove @Ignore on StorageStats tests. 
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
 2021-08-03 08:53:44 +00:00
Sebastian Kaspari
4a3576d299 [fenix] Fix intermittent test failures in TabsTouchHelperTest 2021-08-03 01:10:38 +00:00
Mozilla L10n Automation Bot
46a11a3f56 [fenix] Import l10n. 2021-08-03 00:36:57 +00:00
Sebastian Kaspari
7d59c1f786 [fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest 2021-08-02 23:20:46 +00:00
Sebastian Kaspari
5272c60934 [fenix] Fix intermittent test failures in DefaultSessionControlControllerTest. 2021-08-02 22:54:05 +00:00
Michael Comella
85309f1d25 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627: replace mocked lambda in HistoryItemMenuTest. 
This will prevent intermittent failures with Java 11.
 2021-08-02 22:21:54 +00:00
Michael Comella
e0e46cda2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: disable metrics we don't want to renew. 2021-08-02 19:12:25 +00:00
Michael Comella
f3f4526124 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: link to data renewal request. 2021-08-02 19:12:25 +00:00
Michael Comella
d23a7639ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: renew perf telemetry probes (August expiry). 
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
 2021-08-02 19:12:25 +00:00
Elise Richards
1bad9ad91c [fenix] No issue: fix glean metrics tests for expired metrics (https://github.com/mozilla-mobile/fenix/pull/20621) 
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
 2021-08-02 18:14:17 +00:00
fevziomurtekin
a84d30689d [fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16396 Fix text contrast ratio on "recently closed tabs" 2021-08-02 11:48:11 +02:00
Jonathan Almeida
3fcd0878d4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20349: Add inactive tab grouping to tabs tray 2021-08-02 11:44:13 +02:00
Jonathan Almeida
0ae2f837b6 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20590: 'Jump back in' should obey feature flags 2021-08-02 10:46:38 +02:00
Christian Sadilek
bb3071457a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of DefaultCollectionCreationControllerTest 2021-08-02 10:45:17 +02:00
Rohan Maity
eafb11112d [fenix] https://github.com/mozilla-mobile/fenix/issues/7346 update lint-baseline.xml and remove activity_addons.xml as unused resource 2021-08-02 10:22:34 +02:00
Gabriel Luong
b0c410ce60 [fenix] Add history metadata feature to the settings menu 2021-07-30 19:31:03 +00:00
Christian Sadilek
fb66b53852 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultSessionControlControllerTest 2021-07-30 16:56:44 +00:00
Gabriel Luong
f3027746bf [fenix] Add more context for the Past Exploration localization comment 2021-07-30 15:20:33 +00:00
Christian Sadilek
0d7aa7a57a [fenix] Keep history metadata for 14 days 2021-07-30 14:50:33 +00:00
Sebastian Kaspari
fa26d61a8f [fenix] Fix intermittent test failures of ModeTest 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
6ea19d4b17 [fenix] Run ktlintFormat to adapt to latest formatting rules. 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
bc41dd0b52 [fenix] Add telemetry for Android Autofill feature. 2021-07-30 09:37:43 +00:00
Christian Sadilek
acc5dc1220 [fenix] Fix intermittent test failures of LoginExceptionFragmentStoreTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
2a67850677 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of ExceptionsListItemViewHolderTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
9ed161ff27 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures in SearchDialogControllerTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
a5716396be [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultTabsTrayControllerTest 2021-07-30 09:12:00 +00:00
mcarare
e3b9c8b633 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in settings screens. 2021-07-30 08:20:58 +00:00
Mozilla L10n Automation Bot
a1ac269c73 [fenix] Import l10n. 2021-07-30 00:28:28 +00:00
Elise Richards
2fdd3cc5e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20516: Renew product telemetry probes expiring in August (https://github.com/mozilla-mobile/fenix/pull/20517) 
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-29 19:14:31 +00:00
mcarare
cc18008cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/19955 https://github.com/mozilla-mobile/fenix/issues/20393: Add telemetry for home screen recent tabs. 2021-07-29 15:46:02 +00:00
Christian Sadilek
b36321a8ed [fenix] Fix intermittent test failures in WebPushEngineIntegrationTest 2021-07-29 14:46:17 +00:00
Christian Sadilek
2c38047d32 [fenix] Fix intermittent test failures in FenixSnackbarKtTest 2021-07-29 14:46:17 +00:00
mcarare
dfb5ee8746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in lists. 2021-07-29 14:10:36 +00:00
Christian Sadilek
9e42de220f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent test failures in DefaultQuickSettingsControllerTest 2021-07-29 08:07:49 +00:00
Jonathan Almeida
c49e052da2 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19785: Let WebAuthnFeature ride the trains 2021-07-29 06:52:07 +00:00
Arturo Mejia
cef6144944 [fenix] Put the Start On home setting behind a feature flag. 2021-07-28 16:53:03 -04:00
Christian Sadilek
ad8312ea31 [fenix] Fix intermittent test failures in NavigationInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
696561599e [fenix] Fix intermittent test failures in PagedHistoryProviderTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
bcf051b559 [fenix] Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
ddd3964fb7 [fenix] Fix intermittent test failures in BookmarkControllerTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
a29d89ef7a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of HistoryControllerTest 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
d9faf84790 [fenix] RemoveTabUseCaseWrapperTest: Do not mock lambdas. 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
0400ede268 [fenix] DefaultRecentlyClosedControllerTest: Do not mock functions 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
3fde165e1c [fenix] Do not mock lambdas in TrackingProtectionPanelInteractorTest. 2021-07-28 17:52:53 +00:00
Christian Sadilek
b612a76e07 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent failures of DefaultBrowserToolbarMenuControllerTest 2021-07-28 17:52:53 +00:00
Michael Comella
f6404a2008 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20540: always swipe twice to openSettings in ThreeDotMenuMainRobot. 2021-07-28 15:29:03 +00:00
Mozilla L10n Automation Bot
0e280db7ac [fenix] Import l10n. 2021-07-28 14:26:32 +00:00
codrut.topliceanu
8593bfd0fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20440 - Forces TopSitePager bind if no. of pages changed 2021-07-27 16:19:31 +00:00
Sebastian Kaspari
cb0f5facd9 [fenix] Render debug info screen with Jetpack Compose. 2021-07-27 09:54:24 +00:00
Christian Sadilek
3bc9ed6cba [fenix] Fix init order in TrackingProtectionExceptionsViewTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
0f8e4450a2 [fenix] Fix race condition in ShareViewModelTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
2a6d83146a [fenix] Remove unused imports in PwaOnboardingObserverTest.kt 2021-07-27 10:08:32 +02:00
Christian Sadilek
a56fdc175c [fenix] Use MainCoroutineRule in PwaOnboardingObserverTest 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
2e02e54516 [fenix] Update Robolectric and mockk. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
ccd84ee8e5 [fenix] Remove over-eager protobuf stripping. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
70ae207572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19662: Use Java 11. 2021-07-27 10:08:32 +02:00
Oana Horvath
1e55287003 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20297: close tab to avoid saving the same tab to collection 2021-07-27 07:12:37 +00:00
Mozilla L10n Automation Bot
5e82503179 [fenix] Import l10n. 2021-07-27 00:30:24 +00:00
codrut.topliceanu
ac4779de6d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20449 - Fixes Show most visited sites crash on disable 2021-07-26 21:23:56 +00:00
mcarare
9348be6526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Update AC version 2021-07-26 13:59:46 +00:00
mcarare
bb27316944 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Do not show recent bookmarks older than 10 days. 2021-07-26 13:59:46 +00:00
Mozilla L10n Automation Bot
ff3191f966 [fenix] Import l10n. 2021-07-26 00:30:01 +00:00
Mozilla L10n Automation Bot
b87268288e [fenix] Import l10n. 2021-07-25 00:35:01 +00:00
Mozilla L10n Automation Bot
4a13b27102 [fenix] Import l10n. 2021-07-24 00:37:36 +00:00
Mugurell
2f57358d6a [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Re-enable shortcutButtonTest 
The issue affecting this was resolved in AC.
 2021-07-23 10:47:33 +00:00
Mugurell
df0b2e0d59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20402 - Re-enable "in progress media tab" 
The crash for when media starts playing in a custom tab is now resolved in AC.
 2021-07-22 22:28:54 +00:00
Gabriel Luong
1341b1e7cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 2021-07-22 22:28:54 +00:00
Gabriel Luong
229aab88f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20438 - Display a list of history metadata groups 2021-07-22 19:19:50 +00:00
Mozilla L10n Automation Bot
5daa184477 [fenix] Import l10n. 2021-07-22 16:24:18 +00:00
Michael Comella
f6e71d4e40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: correct spacing in comment on how to run 
Co-authored-by: Jonathan Almeida <git@jonalmeida.com>
 2021-07-22 15:24:35 +00:00
Michael Comella
40fed783ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: integrate Jetback Benchmark (microbenchmark). 2021-07-22 15:24:35 +00:00
Christian Sadilek
35538a209f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16330: Remove remaining usages of Sentry.capture 2021-07-21 20:07:30 +00:00
Mozilla L10n Automation Bot
64571cf4c7 [fenix] Import l10n. 2021-07-21 14:36:56 +00:00
codrut.topliceanu
8541d3f449 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20367 - Fixes removeAllTabs adding to recently closed 
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
 2021-07-20 22:00:04 +00:00
Arturo Mejia
24e2991759 [fenix] Fix search_add_custom_engine_search_string_example lint warning. 2021-07-20 22:00:04 +00:00
jhugman
cc44b33f9d [fenix] Allow branch enrollment and unenrollment in Nimbus secret menu (https://github.com/mozilla-mobile/fenix/pull/20050) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-20 15:45:37 +00:00
codrut.topliceanu
8e35c61327 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15499 - Smoothly updates topSites list on remove 
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
 2021-07-20 15:07:16 +00:00
Mozilla L10n Automation Bot
b8836b3eec [fenix] Import l10n. 2021-07-20 00:40:11 +00:00
Mugurell
603bbdd520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Temporarily disable SearchTest#shortcutButtonTest 2021-07-19 10:12:41 +00:00
Sebastian Kaspari
b637a576f2 [fenix] Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1. 2021-07-19 09:20:50 +00:00
Sebastian Kaspari
d9ca412bec [fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 2021-07-19 09:20:50 +00:00
Jonathan Almeida
0522cbe007 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20402: Disable LastMediaAccessMiddleware temporarily 
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.

The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.

For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
 2021-07-17 01:21:13 +00:00
Mozilla L10n Automation Bot
cccfc982f5 [fenix] Import l10n. 2021-07-17 00:27:34 +00:00
Mozilla L10n Automation Bot
ed598f1183 [fenix] Import l10n. 2021-07-16 00:34:42 +00:00
Roger Yang
9df7c99ed2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19847: Add telemetry for the default browser notification 2021-07-15 19:35:45 +00:00
Oana Horvath
276cd60ed4 [fenix] No issue: adds warning comment to beta & release running tests 2021-07-15 19:03:13 +00:00
Roger Yang
674dbafd94 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20307: Clear sharedViewModel selectedFolder when backing out of bookmark fragment 2021-07-15 15:28:29 +00:00
Roger Yang
213df0b403 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19989: Add rounded corners to recently tabs' icon 2021-07-15 14:20:11 +00:00
Mugurell
e469026805 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19933 - Show a media tab item on homescreen for the last tab with media 2021-07-15 10:05:20 +03:00
Roger Yang
e671e5314e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19846: Make sure default browser notification only happens once 2021-07-15 02:17:24 +00:00
Mozilla L10n Automation Bot
814f0ef0c9 [fenix] Import l10n. 2021-07-15 00:29:47 +00:00
Mugurell
1c733e918e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20229 - Use the AC common implementation for ads/search telemetry 
Everything should work exactly as before.
 2021-07-14 17:55:24 +03:00
mcarare
ef09a9c0e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20292: Use tint for home button icon. 2021-07-14 07:48:13 +00:00
mcarare
e44cc8ee69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17808: Remove deprecated systemUiVisibility and flags. 2021-07-14 07:19:25 +00:00
Mozilla L10n Automation Bot
abfbbbae16 [fenix] Import l10n. 2021-07-14 00:59:46 +00:00
Oana Horvath
972c83ea36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10915: fix tests by removing existing session 2021-07-13 08:18:50 +00:00
Rohan Maity
a92ae5b9b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1268 Add Unit test for PrivateShortcutCreateManager 2021-07-13 10:48:52 +03:00
Mozilla L10n Automation Bot
44ddf895ce [fenix] Import l10n. 2021-07-13 00:39:50 +00:00
Mozilla L10n Automation Bot
fc9aa22b9a [fenix] Import l10n. 2021-07-12 23:27:16 +00:00
Jonathan Almeida
c12a5b98ba [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20320: Use scope from testDispatcher in RecentBookmarksFeatureTest 2021-07-12 23:05:03 +00:00
Jonathan Almeida
c695a5c533 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20267: Filter out network errors from Nimbus 2021-07-12 22:42:05 +00:00
Marc Leclair
4cbc383520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Restore logic to original behavior 2021-07-12 22:20:03 +00:00
Marc Leclair
e4d8d3e9a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: checkDefaultBrowser moved to helper function 2021-07-12 22:20:03 +00:00
Marc Leclair
6c2115cf4a [fenix] For 19804:Fixed call order in the 2021-07-12 22:20:03 +00:00
Marc Leclair
6e811abdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Changed var isDefaultBrowser to a function 
The change to the function makes it so when the Settings.kt class is initialized, the isDefaultBrowser, which calls the
BrowserCache, won't get called right away. `isDefaultBrowser()` is known to take quite a while on start up on the G5+ (approx
30-40ms).
 2021-07-12 22:20:03 +00:00
Michael Comella
aac9149bb5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20127: fix app_received_intent extras. 
Apparently, it had been using the wrong mapping this whole time. I can't
wrap my head around fenix's glean wrapper so I'm not sure if this
resulted in bugs or if my change changes the behavior. However, I don't
think anyone is using this probe so I'm requesting to remove it. If we
don't end up removing it, then we can check for bugs/changes in
behavior. This isn't ideal but I'd rather not spend the time on it if we
don't have to.
 2021-07-12 21:53:54 +00:00
Michael Comella
154defa3b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup from metrics.yaml. 2021-07-12 21:53:54 +00:00
Michael Comella
f59df714f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup integration. 2021-07-12 21:53:54 +00:00
Mozilla L10n Automation Bot
f183e9a9ef [fenix] Import l10n. 2021-07-11 00:30:23 +00:00
Mozilla L10n Automation Bot
44e9c55c64 [fenix] Import l10n. 2021-07-10 00:33:37 +00:00
Roger Yang
37758f8934 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20285: Remove unused GeckoProvider 2021-07-09 22:40:26 +00:00
Elise Richards
611774676d [fenix] For FNX-22339: Recently saved bookmarks (https://github.com/mozilla-mobile/fenix/pull/19835) 
* Title and button for home screen recently saved bookmarks section

Create bookmark item view with favicon and title

* View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

Make a use case for retrieving and updating the list of recently saved bookmarks

Add adapter items and define header viewholder binding

Use session interactor for header button clicks. Bind in the adapter

* Retrieve list of bookmarks asynchronously on home

Interactor and controller tests

Address review comments

Split up tests for recent bookmarks

Update to new interactors

Dark mode and light mode styles

Refactor bookmarks home stuff

* Add RecentBookmarksFeature to home

Move interactor to SessionControlInteractor

Clean up lint, styles, and dimens.

* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.

* View holder tests

* Match ux to designs for colors, margins, and scrolling

* Clean up clean up

* Tests for the view bound feature

* Controller test

* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-07-09 19:36:20 +00:00
Mozilla L10n Automation Bot
b76fe64eb3 [fenix] Import l10n. 2021-07-09 00:35:12 +00:00
Roger Yang
38cce79e1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Update default browser notification strings 2021-07-08 22:04:13 +00:00
Roger Yang
9fdd99943e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Only add default browser notification work if work is not pending 2021-07-08 18:36:14 +00:00
Roger Yang
048abd7f4c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Show Default Browser Notification if browser is not default 2021-07-08 17:52:08 +00:00
codrut.topliceanu
02d170a5b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20257 - Sets min no. of grid columns to 2 in TabsTray 2021-07-08 14:54:43 +00:00
codrut.topliceanu
ae19555d25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20250 - Adds FLAG_SECURE to TabsTray dialog 2021-07-08 08:49:06 +00:00
codrut.topliceanu
c805dd3320 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17855 - Stops SecureWindowFeature from removing FLAG_SECURE 2021-07-08 08:02:35 +00:00
Mozilla L10n Automation Bot
da25ab1b8e [fenix] Import l10n. 2021-07-08 00:38:02 +00:00
Grisha Kruglov
21dda6b6ab [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20276: Fall-back to URL parsing for tabs with parents to obtain search terms 2021-07-07 15:01:26 +00:00
Oana Horvath
1fa807ca1f [fenix] No issue: New UI smoke test for the Language menu 2021-07-07 12:18:16 +00:00
mcarare
42bfec3846 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20029: Remove animations when recreating activity on locale change. 2021-07-07 10:12:51 +00:00
codrut.topliceanu
55c0be886f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Adds kdoc to TopSitePagerPayload 2021-07-07 07:22:45 +00:00
codrut.topliceanu
58657ebdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Fixes top sites refresh and interactability 2021-07-07 07:22:45 +00:00
Mozilla L10n Automation Bot
a2c509b9af [fenix] Import l10n. 2021-07-07 00:36:50 +00:00
Roger Yang
d6150b8310 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20274: Limit about:config to Nightly and Beta 2021-07-06 23:32:16 +00:00
Roger Yang
50101046c3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090: Show snackbar on adding to bookmarks from tabs tray 2021-07-06 22:13:38 +00:00
mcarare
613671c9c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in onboarding cards. 2021-07-06 16:29:09 +00:00
Christian Sadilek
c3ebf3d738 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20123: PlacesException when recording history metadata 2021-07-05 17:12:54 -04:00
Jonathan Almeida
34199d5b72 [fenix] Move Nimbus strings to static_strings 
Goes with 6bb89f346e01edd431056bfcd7472bc3082a39a5
 2021-07-05 19:30:58 +00:00
mcarare
84a2627f91 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20219: Fix constraints in sign-in onboarding card. 2021-07-05 08:38:30 +00:00
mcarare
83c15a1331 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20154: Override AC fill colors for icons. 2021-07-05 08:15:34 +00:00
Mozilla L10n Automation Bot
0abec99757 [fenix] Import l10n. 2021-07-05 00:31:23 +00:00
Mozilla L10n Automation Bot
8a554e5c76 [fenix] Import l10n. 2021-07-04 00:32:48 +00:00
Mozilla L10n Automation Bot
00a1478e5d [fenix] Import l10n. 2021-07-02 00:29:59 +00:00
codrut.topliceanu
98ac6d30c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19558 - Adds proper tint to "Report Site Issue" 2021-07-01 14:40:03 +00:00
Oana Horvath
1953a9cafe [fenix] For https://github.com/mozilla-mobile/fenix/issues/20000: Re-try swipe on collection items 2021-07-01 11:45:22 +00:00
Mozilla L10n Automation Bot
a0bb1ae5d3 [fenix] Import l10n. 2021-07-01 00:35:28 +00:00
Codrut Topliceanu
b1d830e323 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check (https://github.com/mozilla-mobile/fenix/pull/20203) 
* For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check
 2021-06-30 18:37:16 +03:00
mcarare
1880077575 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20190: Mirror back button in RTL. 2021-06-30 15:35:11 +03:00
mcarare
3564817bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/20154: Override AC fill colors for icons. 2021-06-30 15:04:08 +03:00
Mozilla L10n Automation Bot
0b60001784 [fenix] Import l10n. 2021-06-29 00:32:15 +00:00
Mozilla L10n Automation Bot
a6aff234b1 [fenix] Import l10n. 2021-06-28 00:30:01 +00:00
Mozilla L10n Automation Bot
a5090ad038 [fenix] Import l10n. 2021-06-27 00:34:31 +00:00
Mozilla L10n Automation Bot
274d3cb6d4 [fenix] Import l10n. 2021-06-26 00:30:31 +00:00
Mozilla L10n Automation Bot
21c459705f [fenix] Import l10n. 2021-06-25 13:01:07 +00:00
Oana Horvath
546cd82033 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20123: Disable historyMetadataFeature flag 2021-06-25 10:11:03 +00:00
Mozilla L10n Automation Bot
1913986dcf [fenix] Import l10n. 2021-06-24 00:37:38 +00:00
Travis Long
ea8738967d [fenix] [SDK-279] Adds a way to switch to the "preview" collection in Nimbus 
This adds a toggle/switch to the debug settings menu that causes Nimbus to use the "preview" collection rather than the "main" collection when it initializes.  Since it is only applied during init, it does require a restart in order to take effect.
 2021-06-23 22:20:31 +00:00
Gabriel Luong
69f2e22a04 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19951 - Use Proton icon for new home button 2021-06-23 17:34:31 +00:00
Arturo Mejia
ca851a38be [fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Fix the default autoplay setting to be block audio only 2021-06-23 09:02:04 -04:00
Mozilla L10n Automation Bot
16b1b94fbe [fenix] Import l10n. 2021-06-23 00:28:26 +00:00
Mugurell
f9c1338826 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20046 - Show the last accessed tab in Jump back in 2021-06-22 22:03:33 +00:00
jhugman
fad92d06fa [fenix] Add error reporting via sentry to Nimbus caught exceptions (https://github.com/mozilla-mobile/fenix/pull/20049) 2021-06-22 13:27:32 +00:00
Roger Yang
2ef093a35e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19182: Close Tabs Tray when sharing completes 2021-06-22 02:53:02 +00:00
Roger Yang
63775af142 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19921: Update appcompat and fragment dependencies to 1.3.x 2021-06-22 01:39:52 +00:00
Mozilla L10n Automation Bot
ee875b2474 [fenix] Import l10n. 2021-06-22 00:29:33 +00:00
Arturo Mejia
51f0ba6668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Update the default autoplay setting to be block audio only 2021-06-21 16:46:54 -04:00
Jonathan Almeida
3e2f501795 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20054: Update recent tab on title or icon changes 2021-06-21 18:27:33 +00:00
Arturo Mejia
10e4bf1d7f [fenix] Improvements to site permissions 2021-06-21 17:21:16 +00:00
codrut.topliceanu
b511e4a8b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19739 - Adds start tabsTray with multiSelect support 2021-06-21 16:17:09 +00:00
codrut.topliceanu
33eaa6f12d [fenix] For https://github.com/mozilla-mobile/fenix/issues/16330 - Replaces Sentry.capture with submitCaughtException 2021-06-21 09:05:33 +00:00
Mozilla L10n Automation Bot
a75b7c0202 [fenix] Import l10n. 2021-06-21 00:59:30 +00:00
Mozilla L10n Automation Bot
5e75d4852a [fenix] Import l10n. 2021-06-20 00:29:50 +00:00
Mozilla L10n Automation Bot
67f595df8c [fenix] Import l10n. 2021-06-19 00:31:15 +00:00
Mugurell
08222b299a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Remove FenixAccountManager#authenticatedAccount 
This api had a bug stemming from the property name - authenticatedAccount which
may return even an unauthenticated account.
After the recent refactorings it was left unused so best to remove it to
prevent from future misuses.
 2021-06-18 17:09:25 +03:00
Mugurell
c2b11553f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Use the FXA email only if the account is authenticated 
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
 2021-06-18 17:09:25 +03:00
Mugurell
60725fc1f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Remove FenixAccountManager#signedInToFxa 
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
 2021-06-18 17:09:25 +03:00
Mugurell
00e54ff915 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Home menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
4873b79123 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Browser menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
efebcc2bc8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - New FenixAccountManager#getAccountState() 
This new method allows a single source of truth for getting the up-to-date
account status without clients interesting in this needing to know what to
check for.
 2021-06-18 17:09:25 +03:00
Elise Richards
db5fa44113 [fenix] Define the width/height for homescreen empty collections button (https://github.com/mozilla-mobile/fenix/pull/20082) 2021-06-17 17:57:21 -05:00
Grisha Kruglov
5ec85f2f4b [fenix] Obtain searchTerms from previous page in tab's history 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-06-17 18:02:36 -04:00
Elise Richards
f974ca8aac [fenix] Define the width/height for sync sign in button on tabs tray (https://github.com/mozilla-mobile/fenix/pull/20080) 2021-06-17 16:49:03 -05:00
bharat0to
60c2d848e9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18581 ETP Standard option is truncated (https://github.com/mozilla-mobile/fenix/pull/18586) 2021-06-17 16:42:08 -05:00
Elise Richards
62ee6d6b34 [fenix] Update glean notification emails to new email group (https://github.com/mozilla-mobile/fenix/pull/20070) 2021-06-17 14:48:34 -05:00
Arturo Mejia
5ad8dd91e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19881 add telemetry for start on Home. 2021-06-17 13:09:28 -04:00
Jonathan Almeida
8764e7dcec [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19950: Fix intermittent failure in SearchDialogControllerTest 2021-06-17 11:37:05 -04:00
Mihai Adrian Carare
f20c7ed527 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19813: Invalidate tab tray adapter structure on screen rotation. (https://github.com/mozilla-mobile/fenix/pull/20044) 2021-06-17 13:57:50 +03:00
Jonathan Almeida
3eb90af822 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20053: Disabling collection smoke tests temporarily 
The changes from https://github.com/mozilla-mobile/fenix/issues/19090 did not fix the issue consistently, and are
causing failures intermittently on-unrelated PRs.

Disabling these tests again until we have another fix for https://github.com/mozilla-mobile/fenix/issues/19090.
 2021-06-17 10:25:08 +03:00
Christian Sadilek
efc698e115 [fenix] HistoryMetadataMiddleware: Use state ext. functions from A-C 2021-06-16 19:22:56 -07:00
Mozilla L10n Automation Bot
1a0f47040d [fenix] Import l10n. 2021-06-17 00:28:28 +00:00
mcarare
f82b0342c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20024: Visit FAB after synced tabs in a11y traversal. 
This helps focus on FAB without going through whole tab lists.
 2021-06-16 19:01:24 -04:00
Jonathan Almeida
d4369c6adf [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/19739 - Adds start tabsTray with multiSelect support" 
This reverts commit 9f105db9e11dac7b481c889bc64fb3f911eeb9fd.
 2021-06-16 16:57:59 -04:00
Jonathan Almeida
241f32d1e4 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/19739 - Moves argument to initial state init" 
This reverts commit e8948798bff353fcd55ff2df45a651f77790880e.
 2021-06-16 16:57:59 -04:00
codrut.topliceanu
94311316ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/19739 - Moves argument to initial state init 2021-06-16 13:16:18 -04:00
codrut.topliceanu
d746c0849c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19739 - Adds start tabsTray with multiSelect support 2021-06-16 13:16:18 -04:00
Mihai Adrian Carare
8af5109268 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20007: Multiselect title is important for a11y just in select mode. (https://github.com/mozilla-mobile/fenix/pull/20008) 2021-06-16 13:13:42 +03:00
mcarare
65dc1122b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19820: Specify usage of labels for a11y services. 2021-06-16 08:49:12 +03:00
Mozilla L10n Automation Bot
0d1e98e2a3 [fenix] Import l10n. 2021-06-16 00:43:59 +00:00
Elise Richards
c2926b84c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19923: renew telemetry probes (https://github.com/mozilla-mobile/fenix/pull/19924) 2021-06-15 18:08:01 -05:00
Gabriel Luong
756e54a037 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19988 - Part 2: Load tab icon from BrowserIcons cache if needed for the recent tab 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
Gabriel Luong
71ca6f7f5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19988 - Part 1: Move RecentTabsListFeature into recenttabs package 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
AndiAJ
b2195ea4ba [fenix] Text selection tests 2021-06-15 17:07:13 +03:00
Mugurell
31707aa40d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Offer more context for why STATE_HALF_EXPANDED is not used 2021-06-15 10:01:49 +03:00
Mugurell
65f75412cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Set different offsets for expanded trays 
As in the previous version of tabs tray when tray is expanded while in portrait
it should have a 40dp offset and when the tray is expanded while in landscape
it should have a 0dp offset - effectively making it fullscreen.

These values were set in code, always overriding the xml set value so I
removed that xml declaration.
 2021-06-15 10:01:49 +03:00
Mugurell
74a14fe91c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Expand the tabs tray in landscape 
Track the current orientation and collapse / expand it the tabs tray depending
on the orientation and the number of opened tabs.
 2021-06-15 10:01:49 +03:00
Mugurell
515ae82e9b [fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Refactor the behavior code to support more functionality later 
Setup a new TabSheetBehaviorManager with all the dependencies it needs to
set the initial tray's behavior.
This same manager will later be called to update behavior's properties.
 2021-06-15 10:01:49 +03:00
Sammy Khamis
8192f53f08 [fenix] changes required for uniffi-ing logins component= 2021-06-14 23:54:29 -07:00
Christian Sadilek
0913ebfe40 [fenix] Issue FNX-22435: Introduce History metadata 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-06-14 16:30:00 -04:00
mcarare
7675e4e8c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19938: Remove a11y workaround for tab tray new tab button. 
Historically, button was introduced in a3dc565c10,
because FAB was not selectable by a11y in previous implementation of tab tray.
 2021-06-14 22:34:58 +04:00
Jan-Erik Rediger
80133db1ce [fenix] Suppress deprecation warnings for now-deprecated Glean APIs 
Glean v39 allows to specify types for event extra keys.
The old API is therefore deprecated.
To avoid to much churn right now and keep the build going let's suppress
the deprecation warnings.
 2021-06-14 13:32:46 -04:00
mcarare
3f213a1f9c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19915: Add telemetry for the toolbar Home screen button. 2021-06-14 19:23:24 +03:00
Mozilla L10n Automation Bot
64f7fed778 [fenix] Import l10n. 2021-06-14 00:25:37 +00:00
Mozilla L10n Automation Bot
e394ab7492 [fenix] Import l10n. 2021-06-12 00:29:54 +00:00
Elise Richards
79a22ba92e [fenix] For FNX-22339: UI components for recently added bookmarks (https://github.com/mozilla-mobile/fenix/pull/19953) 
* Top level layout with recyclerview for recent bookmarks

* Add layout for recent bookmarked item, including strings and styles.

* Header layout for recently saved bookmarks

* Address review comments

* Include the header for recent bookmarks in the component layout

* Add dark theme colors for button and title styles

* Recent bookmark card title text color for dark mode/light mode
 2021-06-11 15:03:58 -05:00
Oana Horvath
deeca45cff [fenix] For https://github.com/mozilla-mobile/fenix/issues/19090: Re-enable createFirstCollectionTest, shareCollectionTest, deleteCollectionTest 2021-06-11 15:25:40 +03:00
Oana Horvath
76e4acdb54 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10587: Fix and re-enable old CollectionTest.kt 2021-06-11 15:25:40 +03:00
AndiAJ
d819ebc81d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19585: disables failing restoreTabCrashedReporterTest UI test 2021-06-11 12:20:38 +03:00
Gabriel Luong
e8352f7d63 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19916 - Add last viewed tab to home screen 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-10 16:22:57 -04:00
Sebastian Kaspari
da19e6bc59 [fenix] Update Android Components to 91.0.20210610143711. (https://github.com/mozilla-mobile/fenix/pull/19946) 2021-06-10 15:36:44 -04:00
Christian Sadilek
1b6aa1dfff [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17800: Cleanup and fix request desktop site from home 2021-06-10 12:49:13 -04:00
Arturo Mejia
80fb799bb7 [fenix] Fix site permissions breaking changes 2021-06-09 16:34:42 -04:00
Sebastian Kaspari
e25cfcdc48 [fenix] Complete browser-state migration and remove browser-session dependency. 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-06-09 18:30:21 +02:00
Oana Horvath
3646becb54 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18986: re-enable changeAccessibiltySettings UI test, not failing anymore 2021-06-09 13:52:47 +03:00
Mozilla L10n Automation Bot
2abb02d374 [fenix] Import l10n. 2021-06-09 07:56:14 +00:00
Codrut Topliceanu
fcd7414d62 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19815 - Keeps tabTray FAB from obstructing last tab (https://github.com/mozilla-mobile/fenix/pull/19891) 
* For https://github.com/mozilla-mobile/fenix/issues/19815 - Keeps tabTray FAB from obstructing last tab
 2021-06-09 10:16:47 +03:00
Gabriel Luong
5c4a9f964c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19876 - Part 3: Add a FeatureFlag to keep the Home screen button in Nightly 2021-06-08 18:05:14 -04:00
Gabriel Luong
155c119513 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19876 - Part 2: Add a Home screen button to the browser toolbar 2021-06-08 18:05:14 -04:00
Gabriel Luong
0e5e244e45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19876 - Part 1: Refactor BrowserToolbarInteractor 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
 2021-06-08 18:05:14 -04:00
Arturo Mejia
891acbfb74 [fenix] Address typos on start on home strings (https://github.com/mozilla-mobile/fenix/pull/19903) 2021-06-08 18:04:54 -04:00
rxumoz
04e9da4065 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10300 - Fix Baidu search telemetry (https://github.com/mozilla-mobile/fenix/pull/19127) 2021-06-08 17:59:14 -04:00
Jonathan Almeida
b26989607f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19178: Apply new styling to Synced Tabs list 2021-06-08 20:46:56 +04:00
codrut.topliceanu
3b5e51d2ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/19738 - Adds tests for SecureTabsTrayBinding.kt 2021-06-08 20:29:37 +04:00
codrut.topliceanu
d113daa53f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19738 - Secure mode enabled in private tabs tray 
Prevents screenshots while tabs tray with private tabs page is open.
 2021-06-08 20:29:37 +04:00
Mozilla L10n Automation Bot
d970d53682 [fenix] Import l10n. 2021-06-08 00:33:38 +00:00
Arturo Mejia
42e0c6d672 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19789 Start on Home after some amount of time 2021-06-07 16:29:36 -04:00
Mihai Adrian Carare
973be4214e [fenix] For https://github.com/mozilla-mobile/fenix/issues/19820 - Add labels for month and year spinners. (https://github.com/mozilla-mobile/fenix/pull/19870) 
This follows the guidelines described in
developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role
 2021-06-07 16:29:01 -04:00
Gabriel Luong
016379fbca [fenix] For https://github.com/mozilla-mobile/fenix/issues/19495 - Add validation for the name on card (https://github.com/mozilla-mobile/fenix/pull/19836) 
- We want to ensure that name on card in the credit card is not empty when submitted. Display an appropriate error when the field is invalid.
 2021-06-07 15:44:49 -04:00
Oana Horvath
1cb4361ef8 [fenix] Changes to https://github.com/mozilla-mobile/fenix/issues/17416, https://github.com/mozilla-mobile/fenix/issues/19686, https://github.com/mozilla-mobile/fenix/issues/19770 UI smoke tests to remove flakiness 2021-06-07 17:20:25 +03:00
Mozilla L10n Automation Bot
e13be13716 [fenix] Import l10n. 2021-06-07 00:26:13 +00:00
Christian Sadilek
5779f4dd36 [fenix] Suppress TooGenericExceptionCaught for NimbusApi.withExperiment 2021-06-06 09:56:16 -04:00
James Hugman
2164f8943d [fenix] Re-instate catch-all to withExperiment 2021-06-06 09:56:16 -04:00
Mozilla L10n Automation Bot
a597d41883 [fenix] Import l10n. 2021-06-06 00:51:45 +00:00
Mozilla L10n Automation Bot
3c4391abdf [fenix] Import l10n. 2021-06-05 00:29:39 +00:00
Jonathan Almeida
f5a50057a5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19792: Add content description for tab tray action button 2021-06-05 02:44:33 +04:00
Roger Yang
125e70ae1b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090: Show snackbar on adding to bookmarks from tabs tray (https://github.com/mozilla-mobile/fenix/pull/19807) 2021-06-04 14:45:20 -04:00
Jonathan Almeida
3225b7ae30 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809: Change default tab tray view to grid layout 2021-06-04 22:26:22 +04:00
Jonathan Almeida
da9d218700 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809: Remove Grid layout info banner in tabs tray 2021-06-04 22:26:22 +04:00
codrut.topliceanu
7da6976770 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19191 - Fixes missing multi-select checkmarks 2021-06-04 19:56:10 +04:00
Oana Horvath
3fc5d43336 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18647: Fixed and re-enabled customTrackingProtectionSettingsTest UI test 2021-06-04 15:54:14 +03:00
Jonathan Almeida
57df4f3fcc [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112: Remove old Synced Tabs code 2021-06-04 02:18:37 +04:00
Jonathan Almeida
aa8d5795b2 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112: Remove old tab tray code 2021-06-04 02:18:37 +04:00
Neha Binwal
322c7b4613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19307: Increased contrast ratio of chevron symbol in Collections (For Dark theme) (https://github.com/mozilla-mobile/fenix/pull/19377) 
* For https://github.com/mozilla-mobile/fenix/issues/19307: Increased contrast ratio of chevron symbol in Collections (Dark Theme)

- Made a code change in collection_home_list_row.xml which fixes the colour of the chevron symbol in Dark theme

* Replaced android:src with app:srcCompat to pass Lint check
 2021-06-03 13:54:55 -05:00
Neha Binwal
10aaee9965 [fenix] Increased text contrast ratio of TextViews in 'Share tab' (https://github.com/mozilla-mobile/fenix/pull/18880) 
- Changed share_tab_url color to @color/photonLightGrey60
- Changed appName and recent_apps_link_header color to @color/photonDarkGrey10
 2021-06-03 13:54:05 -05:00
Mugurell
a1d0f1b171 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18877 - Support updated PromptRequest AC APIs (https://github.com/mozilla-mobile/fenix/pull/19767) 
* For https://github.com/mozilla-mobile/fenix/issues/18877 - Support updated PromptRequest AC APIs

This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.

* Update Android Components version to 91.0.20210603145049

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-06-03 12:13:43 -04:00
Gabriel Luong
e24a4cdb42 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19746 - Remove FeatureFlags.nimbusExperiments (https://github.com/mozilla-mobile/fenix/pull/19771) 2021-06-03 11:35:05 -04:00
ZianeA
c745b83740 [fenix] For #[15083]: Add multi select to recently closed tabs 2021-06-03 05:23:59 +04:00
Mozilla L10n Automation Bot
65f64d1929 [fenix] Import l10n. 2021-06-03 00:39:39 +00:00
Elise Richards
bcd257172b [fenix] For https://github.com/mozilla-mobile/fenix/issues/19746 - Remove feature flag for the three-dot menu redesign (https://github.com/mozilla-mobile/fenix/pull/19750) 
* Remove feature flag for the three-dot menu redesign

* Remove menu feature flag from unit tests
 2021-06-02 14:19:00 -05:00
codrut.topliceanu
2ec93a964b [fenix] For https://github.com/mozilla-mobile/fenix/issues/19571 - Adds gdprForgetMe when stopping Adjust 2021-06-02 19:02:28 +04:00
Mihai Adrian Carare
22a47beab1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19419 - Label edit boxes for a11y services. (https://github.com/mozilla-mobile/fenix/pull/19762) 2021-06-02 10:56:30 -04:00
Oana Horvath
60b8cfa916 [fenix] No issue: Add more smoke tests coverage 2021-06-02 10:30:59 +03:00
Oana Horvath
ddf02bbac2 [fenix] No issue: Change hardcoded package and app name in tests 2021-06-02 10:30:59 +03:00
Mozilla L10n Automation Bot
8e3c6deabb [fenix] Import l10n. 2021-06-02 00:33:12 +00:00
Mozilla L10n Automation Bot
13f05d9676 [fenix] Import l10n. 2021-06-01 00:32:28 +00:00
Gabriel Luong
7bdf0474b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19734 - Enable Credit cards autofill for Release (https://github.com/mozilla-mobile/fenix/pull/19735) 2021-05-31 17:40:04 -04:00
Gabriel Luong
5ab6b35346 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping (https://github.com/mozilla-mobile/fenix/pull/19733) 2021-05-31 17:35:47 -04:00
Jonathan Almeida
da6ac8459b [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19731: Track metrics before we dismiss the tabs tray 2021-05-31 21:46:13 +04:00
Mihai Adrian Carare
fc5f56c9ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/19564: Explicitly update switch state for a11y event announcements. (https://github.com/mozilla-mobile/fenix/pull/19589) 2021-05-31 16:50:23 +03:00
Mozilla L10n Automation Bot
c43d29c07c [fenix] Import l10n. 2021-05-31 00:29:30 +00:00
Mozilla L10n Automation Bot
a4d0d5f378 [fenix] Import l10n. 2021-05-29 01:35:38 +00:00
Gabriel Luong
c0ce74f75e [fenix] For https://github.com/mozilla-mobile/fenix/issues/19693 - Display a biometric prompt when a credit card is selected to autofill (https://github.com/mozilla-mobile/fenix/pull/19697) 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-05-28 20:10:03 -04:00
Gabriel Luong
67f91bff90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19693 - Add new string for the prompt to authenticate to use a stored credit card (https://github.com/mozilla-mobile/fenix/pull/19708) 2021-05-28 19:04:26 -04:00
Grisha Kruglov
1608dbc495 [fenix] Enable addresses sync for nightly/debug builds 2021-05-28 00:22:32 -07:00
Grisha Kruglov
9647ae5fad [fenix] Minor cleanup of the account settings 2021-05-28 00:22:32 -07:00
Elise Richards
0bedcba4e5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill (https://github.com/mozilla-mobile/fenix/pull/19548) 2021-05-27 23:54:11 -05:00
Mozilla L10n Automation Bot
05611f5826 [fenix] Import l10n. 2021-05-28 00:29:28 +00:00
Jonathan Almeida
369ef222fd [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19459: Use Store.waitUntilIdle in intermittent failing test (https://github.com/mozilla-mobile/fenix/pull/19683) 2021-05-27 18:51:00 -04:00
Gabriel Luong
d67678c9c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card (https://github.com/mozilla-mobile/fenix/pull/19692) 
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
 2021-05-27 18:44:00 -04:00
Christian Sadilek
451d286705 [fenix] Migrate test code to no longer use Nimbus FeatureConfig 2021-05-27 16:09:44 -04:00
Christian Sadilek
9026e1d20a [fenix] Fix breaking change in MetricController 2021-05-27 16:09:44 -04:00
Christian Sadilek
2adaed1d2f [fenix] Fix lint/detekt issues 2021-05-27 16:09:44 -04:00
James Hugman
9e84d12281 [fenix] Add an experiment to demontrate the Feature API 
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
 2021-05-27 16:09:44 -04:00
Oana Horvath
ba1ebb1413 [fenix] No issue: cleanup of unused tabs related code in HomeScreenRobot.kt 
Deleted SmokeTest#selectTabsButtonVisibilityTest, feature removed
 2021-05-27 11:13:56 +03:00
Oana Horvath
4219f12c67 [fenix] No issue: added smoke tests from MediaNotificationTest.kt 2021-05-27 11:13:56 +03:00
Elise Richards
c334a5ae30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18264 - Add biometric prompt to credit card settings (https://github.com/mozilla-mobile/fenix/pull/19505) 2021-05-27 03:45:35 -04:00
Oana Horvath
65105f2854 [fenix] No issue: Added custom tab UI smoke test 2021-05-27 10:22:30 +03:00
Jonathan Almeida
5dd7d94432 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19647: Navigate to browser from home via Synced Tabs page 2021-05-27 05:21:57 +04:00
Mozilla L10n Automation Bot
26fcdb5f63 [fenix] Import l10n. 2021-05-27 00:48:18 +00:00
Gabriel Luong
d46ed809a6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19680 - Show the card number when editing a credit card (https://github.com/mozilla-mobile/fenix/pull/19681) 2021-05-26 20:22:11 -04:00
Gabriel Luong
a61586886b [fenix] For https://github.com/mozilla-mobile/fenix/issues/18271 - [Saved cards] Display the credit card provider icon and report the correct card type (https://github.com/mozilla-mobile/fenix/pull/19652) 2021-05-26 16:44:05 -04:00
Mugurell
e077d268ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/18263 - Allow dynamically toggling credit cards autofill 2021-05-26 19:38:16 +03:00
Ionut Cristian Bedregeanu
dc4c14400a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19653 - Address 19643 PR comments 
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
 2021-05-26 19:06:37 +03:00
Mugurell
6cc2dfd41f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19638 - Don't show extracted text UI for name when editing cards (https://github.com/mozilla-mobile/fenix/pull/19673) 
This comes to ensure consistency with the behavior for when editing the card
number.
 2021-05-26 12:05:21 -04:00
Bedregeanu Ionut
126b678693 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19654 - Add RTL support for the "Add credit card" button from "Saved cards" (https://github.com/mozilla-mobile/fenix/pull/19666) 
Co-authored-by: Ionut Cristian Bedregeanu <ionut.bedregeanu@softvision.ro>
 2021-05-26 11:58:49 -04:00
Codrut Topliceanu
3a74d32302 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19569 - Decrease the credit card expiry year width to ensure the month is fully visible (https://github.com/mozilla-mobile/fenix/pull/19582) 2021-05-26 11:16:29 -04:00
Mugurell
693a65646c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Introduce a DefaultTabsTrayInteractor 
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
 2021-05-26 15:45:54 +03:00
Mugurell
2825595c5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Cleanup - respect naming scheme in TabsTrayController 
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.

Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
 2021-05-26 15:45:54 +03:00
isabelrios
abff667349 [fenix] Stop depending on JCenter - Screengrab and Falcon 2021-05-26 11:04:58 +02:00
Mozilla L10n Automation Bot
945799c1bf [fenix] Import l10n. 2021-05-26 00:43:20 +00:00
Sebastian Kaspari
21b40d89d8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Update detekt to 1.17.1 2021-05-25 17:19:57 -04:00
Ionut Cristian Bedregeanu
b0caa66de7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18881 - Create a new layout for 'Add credit card' button 
Add functionality for 'Add credit card' button

Add unit tests for 'Add credit card' functionality
 2021-05-25 20:34:49 +03:00
Mugurell
4c3dd87916 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19620 - Have MenuScreenShotTest screenshot DefaultBrowser setting again 
As a regression from https://github.com/mozilla-mobile/fenix/issues/19590 which added a new setting above the existing
"Set as default browser" setting the settingsTest() needed to be updated to
allow clicking and screenshot of what happens after clicking on the
"Set as default browser" setting which can now be pushed offscreen.
 2021-05-25 16:04:39 +03:00
Codrut Topliceanu
6c5d98e939 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display (https://github.com/mozilla-mobile/fenix/pull/19420) 
* For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display
 2021-05-25 14:32:17 +03:00
Oana Horvath
7ca40a2fcf [fenix] For https://github.com/mozilla-mobile/fenix/issues/19415: fixed private browsing button visibility issue 2021-05-25 10:49:13 +03:00
mcarare
c555252e0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19554: Add SyncEngine.CreditCards to sync supportedEngines. 2021-05-25 09:44:03 +03:00
Mozilla L10n Automation Bot
67989b37d4 [fenix] Import l10n. 2021-05-25 00:32:09 +00:00
mcarare
ec95ba0822 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17538: Perform autofill storage warm-up after visual completeness. 2021-05-24 23:23:15 +03:00
Oana Horvath
44e9a9099f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18603: Fix and re-enable startBrowsingButtonTest 2021-05-24 19:26:37 +03:00
AndiAJ
ccc2e62961 [fenix] Fix settingsPrivacyItemsTest 2021-05-24 14:12:35 +03:00
mcarare
daef124cd1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19600: Set manage cards preference visible by default. 2021-05-24 13:10:57 +03:00
mcarare
c1a90b6e3c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19600: Change manage cards preference UI dynamically. 2021-05-24 11:09:59 +03:00
mcarare
4c2c1b4473 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19600: Change manage cards preference UI dynamically. 2021-05-24 11:09:59 +03:00
Oana Horvath
570c497a7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/15754: Get playback state using MediaSession in MediaNotificationTests 2021-05-24 09:48:49 +03:00
Mozilla L10n Automation Bot
8aeb3fa030 [fenix] Import l10n. 2021-05-24 00:29:05 +00:00
Mozilla L10n Automation Bot
2d0615f86d [fenix] Import l10n. 2021-05-23 00:30:49 +00:00
Mozilla L10n Automation Bot
fd1d6123e9 [fenix] Import l10n. 2021-05-22 00:25:29 +00:00
Mugurell
3ad7bff786 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19590 - Enable credit card autofill in Debug and Nightly (https://github.com/mozilla-mobile/fenix/pull/19601) 2021-05-21 11:37:49 -04:00
Mozilla L10n Automation Bot
c084a95612 [fenix] Import l10n. 2021-05-21 12:03:21 +00:00
Codrut Topliceanu
d0bd0eb8a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19570 - Set appropriate theme color for delete card button (https://github.com/mozilla-mobile/fenix/pull/19581) 2021-05-20 19:38:14 -04:00
Sebastian Kaspari
ea2b2316f9 [fenix] AutofillConfiguration: Correctly specify autofill confirm activity. 2021-05-20 16:06:59 +02:00
Mozilla L10n Automation Bot
2e9ed281fc [fenix] Import l10n. 2021-05-20 02:18:05 +00:00
Mihai Adrian Carare
ac35cf37da [fenix] For https://github.com/mozilla-mobile/fenix/issues/19054 - Navigate to the Credit card screen when deleting last card. (https://github.com/mozilla-mobile/fenix/pull/19451) 2021-05-19 12:55:15 -04:00
Tim D. Smith
43956c9687 [fenix] Fix case of item extras in browser_menu_action event (https://github.com/mozilla-mobile/fenix/pull/19487) 
* Fix case of item extras in browser_menu_action event

Update the event description to match the values observed in telemetry.

* Line length
 2021-05-19 11:12:27 -05:00
Mihai Adrian Carare
43965a3255 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18507 - Prevent screenshots on credit card screens. (https://github.com/mozilla-mobile/fenix/pull/19560) 2021-05-19 12:07:33 -04:00
mcarare
3061600148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8370: Remove extra characters from name mapping. 2021-05-19 14:15:11 +03:00
Mozilla L10n Automation Bot
a23de0165f [fenix] Import l10n. 2021-05-19 00:32:03 +00:00
Arturo Mejia
07b4f64970 [fenix] Remove feature flag for proton icons re-design https://github.com/mozilla-mobile/fenix/issues/18132 2021-05-18 07:24:22 -04:00
Mozilla L10n Automation Bot
54433dee2a [fenix] Import l10n. 2021-05-18 00:26:01 +00:00
mcarare
ed3cf07f11 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19418: Allow multiple lines title for sync cards preference. 2021-05-17 13:39:39 +03:00
Mozilla L10n Automation Bot
d80f218034 [fenix] Import l10n. 2021-05-17 00:27:21 +00:00
Gabriel Luong
13d977b0d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18287 - Display a credit card autofill prompt (https://github.com/mozilla-mobile/fenix/pull/19477) 2021-05-13 21:18:18 -04:00
Arturo Mejia
d6912dd0f9 [fenix] For issue AChttps://github.com/mozilla-mobile/fenix/issues/10231 update proton icons third batch 2021-05-13 21:16:21 -04:00
Priyanka
27756aa4f6 [fenix] created string resource for close (https://github.com/mozilla-mobile/fenix/pull/19500) 
Co-authored-by: priyanka0906 <priyanka02amb@reddiffmail.com>
 2021-05-13 14:25:33 -05:00
Elise Richards
2803f54537 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17537: Add preferences for syncing credit cards and addresses (https://github.com/mozilla-mobile/fenix/pull/19471) 
* Add preferences for enable/disable sync for cc and addresses

* Set pref visibility based on feature flags

* Helper function for pin warning preferences and set default values for cc and addresses to false.

* Kdocs for relevant sync functions in account settings

* Default visibility to false for credit cards and addresses in account settings
 2021-05-13 14:08:46 -05:00
Jonathan Almeida
f10aebe8e8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19176: Exit select mode when removing tab (https://github.com/mozilla-mobile/fenix/pull/19486) 2021-05-13 09:31:04 +03:00
Mozilla L10n Automation Bot
e3b90eae64 [fenix] Import l10n. 2021-05-13 00:32:41 +00:00
mcarare
42d3d1edb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19258: Replace default Android back button with a custom icon. 2021-05-12 16:56:49 +03:00
AndiAJ
1a8155edfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/19468 and https://github.com/mozilla-mobile/fenix/issues/19478 fix intermittent UI tests 2021-05-12 15:18:54 +03:00
Mozilla L10n Automation Bot
8e16b102f6 [fenix] Import l10n. 2021-05-12 08:56:08 +00:00
Codrut Topliceanu
099b301288 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19091 - Fix Undo of close multiple tabs (https://github.com/mozilla-mobile/fenix/pull/19466) 
Fixes the issue where closing multiple selected tabs and then pressing Undo would only restore one of the tabs.
 2021-05-12 10:12:03 +03:00
Roger Yang
b7ecc05811 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19147: Move set startup metrics off main thread 2021-05-12 06:44:31 +04:00
Jonathan Almeida
8cc83017b2 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Correct naming of pager viewholders 2021-05-11 19:40:14 +04:00
Jonathan Almeida
cf9a9dd6dc [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Use a single BrowserTrayList for normal/private list 
We now have a BrowserTrayList.
 - Renamed from `BaseBrowserTrayList`.
 - Removed the abstract `configuration` and used a `lateinit var`
 instead.
 - Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
 2021-05-11 19:40:14 +04:00
Jonathan Almeida
9ace0c8551 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Correct browser viewholder naming 2021-05-11 19:40:14 +04:00
Jonathan Almeida
31a0602b9b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Move TabsTrayViewHolder to browser package 2021-05-11 19:40:14 +04:00
Jonathan Almeida
44973342da [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Remove unused TrayItem interface 2021-05-11 19:40:14 +04:00
Jonathan Almeida
8b8b96d7d4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002: Use AbstractBinding from lib-state 2021-05-11 19:39:50 +04:00
Mugurell
ecaf009a61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18672 - Renaming a TopSite changes just the title 
Previously renaming a TopSite would bind that as a new item and in such update
the entire list. This could potentially leading changes in the list and then
it's ViewPager parent's layout.

This patch switches the code to use the existing TopSitePayload and so do a
partial update of an on-screen TopSite instead of rebind it as a new item.

If a layout is requested while showing <=4 TopSites on the second page, by
having "offscreenPageLimit = 1" the biggest height of ViewPager pages is used
preventing an edgecase where the ViewPager would hide half of the items from
the first page.
 2021-05-11 17:33:10 +03:00
kanish671
9190ef1c11 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18672 - Rename TopSites even on the second page 
Index calculation for notifying changes while renaming a top site in the second
page was being wrongly calculated. Since it is page 2, we would need to take a
mod with the number of top sites per page to get the actual index of the top
site that was being renamed.
 2021-05-11 17:33:10 +03:00
Mozilla L10n Automation Bot
1822be6c64 [fenix] Import l10n. 2021-05-11 00:31:17 +00:00
Neha Binwal
57f0fb0f6d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19401 - Replace hard-coded hex color values with their respective photon color variable (https://github.com/mozilla-mobile/fenix/pull/19406) 
* Replaced https://github.com/mozilla-mobile/fenix/issues/20123A with @color/photonInk80 in values\colors.xml

* Replaced #F9F9FB with @color/photonLightGrey10 in values\colors.xml

* Replaced #E0E0E6 with @color/photonLightGrey30 in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/pull/592ACB with @color/photonViolet70 in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/pull/312A65 with @color/photonInk20 in values\colors.xml

* Replaced #FBFBFE with @color/photonLightGrey05 in values\colors.xml

* Replaced #52525E with @color/photonDarkGrey10 in values\colors.xml

* Replaced #ffffff with @color/photonWhite in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/pull/5B5B66 with @color/photonDarkGrey05 in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/issues/1C1B22 with @color/photonDarkGrey80 in values\colors.xml

* Replaced #737373 with @color/photonGrey50 in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/issues/9059FF with @color/photonViolet50 in values\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/pull/5B5B66 with @color/photonDarkGrey05 in values-night\colors.xml

* Replaced https://github.com/mozilla-mobile/fenix/pull/3A3944 with @color/photonDarkGrey40 in values-night\colors.xml
 2021-05-10 19:26:10 -04:00
Jonathan Almeida
a9254b79b9 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19175: Fix SyncTabs list not updating on changes 
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.

The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
 2021-05-10 21:37:32 +04:00
mcarare
3f404375d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19357: Remove bookmarks experiment and keep star-with-line icon. 2021-05-10 15:38:52 +03:00
Mozilla L10n Automation Bot
88a894ed3a [fenix] Import l10n. 2021-05-10 00:43:35 +00:00
Mozilla L10n Automation Bot
0acc879521 [fenix] Import l10n. 2021-05-09 00:35:54 +00:00
William Lachance
adb10fab4e [fenix] No issue - Stop generating metrics.md and direct to Glean Dictionary instead (https://github.com/mozilla-mobile/fenix/pull/19411) 
Now that the Glean Dictionary (https://dictionary.telemetry.mozilla.org)
has hit production, our guidance is to move away from generating
metrics.md files. The Glean Dictionary is a better solution for this task
for a couple of reasons:

1. The Glean Dictionary contains a complete reference of all metrics
and pings sent by an application (not just those defined in the
application itself, as is the case with the markdown documentation)
2. The Glean Dictionary provides additional context and links beyond
what is provided by the documentation (for example, information on
how to access metric information via BigQuery or GLAM) as well as
annotations provided by data scientists in the course of analyzing data
(see, for example, the commentary section for:
https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/metrics_search_count).

This should also reduce some of the churn/burden on people when
they submit PRs, as there is no longer any need to update metrics.md
as a part of them.
 2021-05-07 20:52:01 -04:00
Mozilla L10n Automation Bot
dc73ae411d [fenix] Import l10n. 2021-05-08 00:33:33 +00:00
Neha Binwal
8e0c0c905c [fenix] For https://github.com/mozilla-mobile/fenix/issues/8984: Added color for "Share" menu's "Recently Used" in Dark theme (https://github.com/mozilla-mobile/fenix/pull/18839) 
* Added color for "Share" menu's "Recently Used" in Dark theme

- Changed HEX code for inset_dark_theme in values/colors.xml

* Replaced #52525E in values/colors.xml with @color/photonDarkGrey10

* Added color for "Share" menu's "Recently Used" in Dark theme

- Created a separate attribute recentlyUsedSharedMenu to be used by 'recently used' panel of tab share menu
- It specifies colors to be used for Light and Dark theme
 2021-05-07 14:48:35 -05:00
Neha Binwal
a235c00112 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18226: Fixed display of tabs for when text size is set to largest (https://github.com/mozilla-mobile/fenix/pull/19046) 
- Made website titles clearly visible in Grid view of tab tray
- Made website URLs clearly visible in List view of tab tray
 2021-05-07 14:45:09 -05:00
Elise Richards
50e5ebebd2 [fenix] Move locale restoration on startup to the visual completeness queue to prevent perf impact (https://github.com/mozilla-mobile/fenix/pull/19315) 2021-05-07 14:12:40 -05:00
Dharan Aditya
9b8e77e372 [fenix] Fixed mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/18641: [Bug] Fill link from clipboard overlaps search engines (https://github.com/mozilla-mobile/fenix/pull/18657) 2021-05-07 14:25:41 -04:00
Gabriel Luong
744e447c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18993 - Nimbus: Allow internal tooling to opt into specific branches of an experiment (https://github.com/mozilla-mobile/fenix/pull/19333) 2021-05-07 14:21:03 -04:00
AndiAJ
9855b1d05a [fenix] Fix flaky UI Tests https://github.com/mozilla-mobile/fenix/issues/19306 https://github.com/mozilla-mobile/fenix/issues/19160 https://github.com/mozilla-mobile/fenix/issues/19404 https://github.com/mozilla-mobile/fenix/issues/19373 2021-05-07 17:14:23 +03:00
Roger Yang
f9477db816 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3728: Add secret menu switch for allowing third party root certificates (https://github.com/mozilla-mobile/fenix/pull/19398) 2021-05-06 21:52:55 -04:00
Arturo Mejia
99d5305709 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/19290 update to proton icons second batch 2021-05-06 10:35:39 -04:00
mcarare
3681f15501 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18266: Validate credit card entry info. 2021-05-06 17:06:33 +03:00
mcarare
8155ca4c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18266: Refactor fragment and view to remove duplicate code. 2021-05-06 17:06:33 +03:00
Codrut Topliceanu
744357e211 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18262 - [Credit cards] Turn the "Sync cards across devices" button into a "Sync cards" toggle (https://github.com/mozilla-mobile/fenix/pull/19207) 
* For https://github.com/mozilla-mobile/fenix/issues/18262 - Turns "Sync cards/logins" into toggle
 2021-05-06 14:43:27 +03:00
mcarare
52d3f0813b [fenix] For https://github.com/mozilla-mobile/fenix/issues/19281: Add border radius for top sites favicons. 2021-05-06 13:56:24 +03:00
kglazko
646a12f318 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19055 - Add a ScrollView to the Credit Card Editor Fragment (https://github.com/mozilla-mobile/fenix/pull/19117) 2021-05-05 15:43:09 -04:00
Mozilla L10n Automation Bot
9b1c91315e [fenix] Import l10n. 2021-05-05 15:33:22 +00:00
Roger Yang
2d709b67a7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19147: Move startup metrics to right after Glean initialization (https://github.com/mozilla-mobile/fenix/pull/19252) 2021-05-05 11:11:02 -04:00
codrut.topliceanu
47327e0100 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19132 - Fix navigation on disconnect started from tabsTray 
- Added checks to popBackStack from the Disconnect Logged-in User Dialog, either back to settings, browserFragment or homeFragment.
 2021-05-05 09:55:10 +04:00
Jonathan Almeida
964b03a65f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19259: Pass CoroutineContext to nav interactor constructor 2021-05-04 20:13:10 +04:00
Mozilla L10n Automation Bot
0425ceb59f [fenix] Import l10n. 2021-05-04 00:31:21 +00:00
Roger Yang
0884711ab1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253: Bookmark and History open new tabs in the background (https://github.com/mozilla-mobile/fenix/pull/19275) 2021-05-03 17:27:19 -04:00
Mozilla L10n Automation Bot
f1899ec400 [fenix] Import l10n. 2021-05-03 00:28:38 +00:00
Mozilla L10n Automation Bot
0eab51db90 [fenix] Import l10n. 2021-05-02 00:32:00 +00:00
Mozilla L10n Automation Bot
29211178e8 [fenix] Import l10n. 2021-05-01 00:27:28 +00:00
Sebastian Kaspari
cf11703649 [fenix] Unit tests: Bump max heap size to 3072m. 2021-04-30 16:40:42 +02:00
Mozilla L10n Automation Bot
bd5c0d95cf [fenix] Import l10n. 2021-04-30 00:30:50 +00:00
Priyanka
97f25e8f8d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19273 - Ensure a new line at the EOF is available in all xml files (https://github.com/mozilla-mobile/fenix/pull/19295) 2021-04-29 15:06:46 -04:00
Elise Richards
4565b0f1ea [fenix] Turn on feature flag for three-dot menu redesign for beta. (https://github.com/mozilla-mobile/fenix/pull/19111) 2021-04-29 11:34:57 -05:00
Sebastian Kaspari
3da6fe471e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 - Fix UI test: settingsPrivacyItemsTest 2021-04-29 19:13:33 +04:00
Sebastian Kaspari
1d8ff55891 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 - Update marketing data setting description 2021-04-29 19:13:33 +04:00
Sebastian Kaspari
c1e6f6c9e6 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/10941: Align Nightly version with Gecko/A-C version. 
Instead of using a timestamp this will synchronize the Nightly version with the version
of Gecko / A-C. So when using 90.0.20210426143115 then the Nightly version will be
90.0a1 - similar to what Firefox desktop uses.
 2021-04-29 09:50:07 +02:00
Mozilla L10n Automation Bot
ff7194591e [fenix] Import l10n. 2021-04-29 00:31:49 +00:00
Roger Yang
9f608d6b0a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253: Remove spaces from Addons telemetry comma-separated list (https://github.com/mozilla-mobile/fenix/pull/19292) 2021-04-28 12:09:27 -04:00
Codrut Topliceanu
676a1298a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19113 - Change top site corner radius to 8dp (https://github.com/mozilla-mobile/fenix/pull/19262) 2021-04-27 18:42:40 -04:00
Arturo Mejia
cb4c6b2132 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18132 update to proton icons first batch 2021-04-27 15:42:15 -04:00
mcarare
ee2e653ebb [fenix] For https://github.com/mozilla-mobile/fenix/issues/19213: Adjust synced tabs to properly show in RTL. 2021-04-27 22:26:34 +04:00
Mugurell
6acdc32aad [fenix] For https://github.com/mozilla-mobile/fenix/issues/11819 - Show the mic in widget only if setting is enabled 
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
 2021-04-27 17:28:41 +03:00
Mozilla L10n Automation Bot
a210538479 [fenix] Import l10n. 2021-04-27 01:39:26 +00:00
Arturo Mejia
00e4051b15 [fenix] Fix openFile breaking changes 2021-04-26 20:24:47 -04:00
William Lachance
283bae5ff1 [fenix] No issue - Properly quote description for ad metric (https://github.com/mozilla-mobile/fenix/pull/19243) 
This is pedantic, but strictly something called <provider-name> is considered an HTML tag
unless it's in a code block (backticks). 

See mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/549 and mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/497. I'm going to fix this upstream
but figured I might as well file a PR here to fix the underlying issue.
 2021-04-26 19:24:23 -04:00
Sebastian Kaspari
7c11a19369 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040: Remove Leanplum (Nightly) 2021-04-26 19:08:10 +02:00
Grisha Kruglov
632ba92ad5 [fenix] Fix breaking changes introduced by credit card encryption APIs 2021-04-26 10:41:45 +02:00
Sebastian Kaspari
3425689113 [fenix] Use new SearchSuggestionProvider flag. 2021-04-26 10:41:45 +02:00
Mozilla L10n Automation Bot
253e2e4485 [fenix] Import l10n. 2021-04-26 00:32:02 +00:00
Mozilla L10n Automation Bot
9125fa9659 [fenix] Import l10n. 2021-04-25 00:29:11 +00:00
Mozilla L10n Automation Bot
a51bd7dbf4 [fenix] Import l10n. 2021-04-24 00:29:05 +00:00
Mozilla L10n Automation Bot
298846bdee [fenix] Import l10n. 2021-04-23 00:40:41 +00:00
Mihai Adrian Carare
7dea66e1e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19065 - Add extension functions to be used with credit cards. (https://github.com/mozilla-mobile/fenix/pull/19187) 2021-04-22 18:22:20 -04:00
Mugurell
d2faf47d3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18591 - Update tests 
Some tests trying to "Add to top sites" may fail because of the sticky navbar
now covering that menu item -> scroll the menu up a little.

Some tests that previously were trying to scroll to the bottom of the menu to
interact with navbar options now don't have to. Them trying to interact with
navbar option with the menu opened as collapsed is a good test for the navbar
stickyness.
 2021-04-22 21:09:37 +03:00
Mugurell
b04c52d115 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18591 - Make the navbar sticky in the new menu 2021-04-22 21:09:37 +03:00
Roger Yang
fffa196da9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18816: Disable TabsTray FAB on accessibility enabled (https://github.com/mozilla-mobile/fenix/pull/19170) 2021-04-22 12:48:10 -04:00
mcarare
d94dcd6bd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19125: Move top site pin net to title. 2021-04-22 18:53:50 +03:00
Gabriel Luong
33a81d217a [fenix] No issue - Replace local photon colors with ui-colors (https://github.com/mozilla-mobile/fenix/pull/19167) 2021-04-22 10:37:34 -04:00
mcarare
748c70d3e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19180: Fix tab counter not entirely visible on RTL layout. 2021-04-22 17:02:01 +03:00
Sebastian Kaspari
692611fa13 [fenix] Remove browser-search references. 2021-04-22 13:18:10 +02:00
mcarare
f28b815561 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18267: Updates preferences visibility depending on creditCardsStore 2021-04-22 10:45:57 +03:00
Mozilla L10n Automation Bot
09c32a05b7 [fenix] Import l10n. 2021-04-22 00:30:11 +00:00
Elise Richards
e009e920fa [fenix] Remove strings marked as deprecated that are no longer being used. (https://github.com/mozilla-mobile/fenix/pull/19060) 2021-04-21 16:02:14 -05:00
Elise Richards
3eff41bd2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/19114: check state of sync account when navigating from sync sign in menu item (https://github.com/mozilla-mobile/fenix/pull/19118) 2021-04-21 14:13:44 -05:00
mcarare
a579e7b1af [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608: Also add default browser item in new menu. 2021-04-21 15:54:21 +03:00
Arturo Mejia
e2af9f8372 [fenix] Address WebExtensionBrowserMenuBuilder breaking change 2021-04-21 11:44:37 +02:00
Sebastian Kaspari
41f7cc9d24 [fenix] Update to Mozilla Android Components 90.0 2021-04-21 11:44:37 +02:00
Roger Yang
73b0bcf3c1 [fenix] No issue: Suppress deprecation for LoginStorageDelegate (https://github.com/mozilla-mobile/fenix/pull/19145) 2021-04-20 16:25:01 -04:00
mcarare
04c0e062af [fenix] No issue: Rename Event for naming consistency. 2021-04-20 14:48:07 -04:00
mcarare
6774f41d26 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18852: Add metrics for default browser settings experiment. 2021-04-20 14:48:07 -04:00
Elise Richards
c56f3835be [fenix] For https://github.com/mozilla-mobile/fenix/issues/19005: new tab three-dot menu sync sign in (https://github.com/mozilla-mobile/fenix/pull/19037) 
* Show synced tabs or sync account in new tab menu

* Sync sign in item navigates to account settings

* Check account auth and get sync item title

* Look for sync sign in item on home menu for UI test

* Sync sign in menu item UI test
 2021-04-20 12:18:19 -05:00
mcarare
7543d25b80 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18240: Adjust preference screen to fit UX specs. 2021-04-20 19:32:14 +03:00
Christian Hernandez
5c7de09133 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18830 - Remove card nickname from credit card editor (https://github.com/mozilla-mobile/fenix/pull/18891) 
* Removed all views with regards to credit card nickname. Removed the TextInputLayout and TextInputEditText where information would be typed in. Also removed the credit card nickname title text view. I added a margin of 16 dp to the bottom ConstraintLayout that houses the delete, cancel, and save buttons as requested.

* https://github.com/mozilla-mobile/fenix/issues/18830 - Removed all views with regards to credit card nickname. Removed the TextInputLayout and TextInputEditText where information would be typed in. Also removed the credit card nickname title text view. I added a margin of 16 dp to the bottom ConstraintLayout that houses the delete, cancel, and save buttons as requested.
 2021-04-20 12:09:09 -04:00
Jonathan Almeida
c6fe6bd93e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19094: Open sign-in flow if no account is created for tabs tray 2021-04-19 23:18:37 +04:00
Kate Glazko
3818b88fef [fenix] For https://github.com/mozilla-mobile/fenix/issues/18745: Add Shadow To Shortcut Tiles 2021-04-19 11:01:08 -07:00
Jonathan Almeida
ed14d32d97 [fenix] No issue: Allow tabstray rewrite to ride the trains 2021-04-19 20:08:24 +04:00
Jonathan Almeida
be8873f8d4 [fenix] Disabling tabstray collection tests until https://github.com/mozilla-mobile/fenix/issues/19090 is fixed 2021-04-19 18:10:43 +04:00
Jonathan Almeida
bc86a34797 [fenix] No issue: Fix regression in last tab deleted 
When we allow the homescreen to handle undo for the last tab, we no
longer need to handle this ourselves with our own binding.

In the future, we should re-think this logic to be more robust and less
spread out across multiple screens.
 2021-04-19 18:10:43 +04:00
Jonathan Almeida
b0d0e1b8c9 [fenix] No issue: Use same open tabs tray everywhere 2021-04-19 18:10:43 +04:00
Jonathan Almeida
b0764f9042 [fenix] No issue: Fix the initial select mode check 2021-04-19 18:10:43 +04:00
Jonathan Almeida
8ce71d589f [fenix] No issue: Do not create a new instance of TabsTrayStore 
We only need one. :)
 2021-04-19 18:10:43 +04:00
Jonathan Almeida
2c4d36392f [fenix] Attempt at fixing openAllTabsInCollectionTest test 2021-04-19 18:10:43 +04:00
Jonathan Almeida
a63d26f673 [fenix] Disable/fix tests that rely on Select Tabs button 2021-04-19 18:10:43 +04:00
Jonathan Almeida
7a372f13f9 [fenix] No issue: Enable tabs tray re-write by default in nightly 2021-04-19 18:10:43 +04:00
mcarare
7caceac997 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18496: Set activity theme in onCreate before call to super. 2021-04-19 13:32:45 +03:00
Mozilla L10n Automation Bot
21cfdbb62f [fenix] Import l10n. 2021-04-19 00:31:22 +00:00
Mozilla L10n Automation Bot
c021fdf786 [fenix] Import l10n. 2021-04-18 00:32:58 +00:00
Jonathan Almeida
4c69372287 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19064: Focus on tab page with the BrowsingModeManager 2021-04-17 04:30:38 +04:00
Roger Yang
cf70cb61b3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18946: Add undo toast for tabstray 2021-04-17 02:30:39 +04:00
Michael Comella
5d92d409e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: address onCreate method length detekt issue. 2021-04-16 15:30:26 -07:00
Michael Comella
e83004d81b [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add & integrate StartupTypeTelemetry. 2021-04-16 15:30:26 -07:00
Michael Comella
c7f94915cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add metric perf.startup.startup_type. 2021-04-16 15:30:26 -07:00
Michael Comella
1035ad0fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupPathProvider + tests. 2021-04-16 15:30:26 -07:00
Michael Comella
bdca7337ce [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: address lint errors for StartupStateProvider*. 2021-04-16 15:30:26 -07:00
Michael Comella
825e035db6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add getStartupStateForStartedActivity method. 2021-04-16 15:30:26 -07:00
Michael Comella
4adb237b88 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add isHotStartForStartedActivity and tests. 2021-04-16 15:30:26 -07:00
Michael Comella
b7e04b6590 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add isWarmStartForStartedActivity, tests. 2021-04-16 15:30:26 -07:00
Michael Comella
d7ad0bb813 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: shorten isColdStart... and rm questionable test. 
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
 2021-04-16 15:30:26 -07:00
Michael Comella
895f8efe13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add VIEW to warm and hot entries. 2021-04-16 15:30:26 -07:00
Michael Comella
f5943d894c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor tests to forEachHotStartEntries. 2021-04-16 15:30:26 -07:00
Michael Comella
ca1364f3b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor test into forEachWarmStartEntries. 2021-04-16 15:30:26 -07:00
Michael Comella
e7d166052c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor tests into forEachColdStartEntries. 2021-04-16 15:30:26 -07:00
codrut.topliceanu
2b69fd5b2a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19023 - Expands tabsTray when tabs over certain number 
TabsTray should be collapsed when there are only a few tabs on screen, otherwise it should go straight to STATE_EXPANDED.
 2021-04-16 23:35:14 +04:00
Julien Cristau
b2a420f624 [fenix] Update A-C to 75.0.20210415213638 2021-04-16 12:01:51 -04:00
Mugurell
c2a4f16fe8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18439 - Open link from QR code only if activity is not null 2021-04-16 13:08:01 +03:00
Kate Glazko
68b17ba7e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18520: Add Empty Tab State To Browser Tray List 2021-04-16 05:22:44 +04:00
Mozilla L10n Automation Bot
d57bcda8ef [fenix] Import l10n. 2021-04-16 00:29:09 +00:00
Jonathan Almeida
2ce93ef3a4 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19024: Fix intermittent test failure in NavigationInteractor 2021-04-16 02:34:23 +04:00
Jonathan Almeida
da6cd0c128 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19030: Allow homescreen to be scrollable with extra content 2021-04-16 02:33:53 +04:00
Jonathan Almeida
4f95404df6 [fenix] No issue: Set tray dismissal from background tap 2021-04-16 02:31:13 +04:00
Jonathan Almeida
c6b9bf80d5 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19045: Dismiss tabstray when last tab in a page is closed 2021-04-16 02:31:13 +04:00
Elise Richards
395853235f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18867: remove "signed in as" string in three-dot menu (https://github.com/mozilla-mobile/fenix/pull/19035) 
* Remove signed in as string from sync menu item

* Nav to sync account settings on click

For https://github.com/mozilla-mobile/fenix/issues/18806: navigate to settings account page or sign in on clicking menu item.

* Confirm account exists and retrieve item title

* Remove string
 2021-04-15 12:49:19 -05:00
Christian Sadilek
f134595809 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18819: Hide Credit Card pref by default (for settings w/o icons) (https://github.com/mozilla-mobile/fenix/pull/19058) 2021-04-15 13:29:22 -04:00
Gabriel Luong
fd0b41c798 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information (https://github.com/mozilla-mobile/fenix/pull/19032) 2021-04-15 12:40:48 -04:00
Gabriel Luong
baea2cdf4d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card (https://github.com/mozilla-mobile/fenix/pull/19029) 2021-04-15 11:18:29 -04:00
Codrut Topliceanu
1c24731b4f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab (https://github.com/mozilla-mobile/fenix/pull/19021) 
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab

* For https://github.com/mozilla-mobile/fenix/issues/18521 - Addressed comments
 2021-04-15 18:09:22 +03:00
Arturo Mejia
2119cfadae [fenix] Telemetry for https://github.com/mozilla-mobile/fenix/issues/18855, https://github.com/mozilla-mobile/fenix/issues/18851 and https://github.com/mozilla-mobile/fenix/issues/18857 
For https://github.com/mozilla-mobile/fenix/issues/18857 [Telemetry] Send a Glean event when users change their default browser

For https://github.com/mozilla-mobile/fenix/issues/18855 [Telemetry] Send an event when users open the toolbar menu

For https://github.com/mozilla-mobile/fenix/issues/18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
 2021-04-15 11:29:13 +03:00
Roger Yang
d72289a43d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19003: Add account setting to tabstray synced tab menu (https://github.com/mozilla-mobile/fenix/pull/19034) 2021-04-15 00:46:26 -04:00
Mozilla L10n Automation Bot
1484a591c6 [fenix] Import l10n. 2021-04-15 00:36:37 +00:00
Roger Yang
4f9a341746 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948: Update tabstray telemetry (https://github.com/mozilla-mobile/fenix/pull/19004) 2021-04-14 15:32:45 -04:00
mcarare
8e8a872127 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18854: Add metrics for home screen being displayed. 2021-04-14 21:21:28 +03:00
mcarare
c4609f6e35 [fenix] No issue: Fix indenting in onViewCreated. 2021-04-14 21:21:28 +03:00
mcarare
8f34c26bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/18376: Add experiment for set default browser settings card. 2021-04-14 19:28:38 +03:00
mcarare
9dede18ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18853: Add metrics for default browser new tab experiment. 2021-04-14 19:22:27 +03:00
mcarare
4ff47f6c1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18856: Add metrics for opening settings screen from home menu. 2021-04-14 18:50:15 +03:00
mcarare
62f839d75a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18815: Expand app bar on onboarding dismissal and browsing start. 2021-04-14 18:09:51 +03:00
Jonathan Almeida
d10792a96e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19011: Always have a click listener in TabTrayViewHolder 2021-04-14 19:08:39 +04:00
Jonathan Almeida
bc628f6770 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18934: Do not nullify adapter on window detached 
Previously, to fix a memory leak, we were removing the adapter reference
entirely in order to have the `onDetachedFromRecyclerView` callback
invoked. This causes a side-effect where we can no longer reference the
adapter any more when we re-attach.

The simpler solution is to just invoke the needed callback directly
instead.
 2021-04-14 19:00:51 +04:00
Gabriel Luong
ac29b50dfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen (https://github.com/mozilla-mobile/fenix/pull/18884) 2021-04-14 10:56:23 -04:00
Oana Horvath
0ad9590e60 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18986 & https://github.com/mozilla-mobile/fenix/issues/19016: disabled failing tests changeThemeSetting & changeAccessibiltySettings 2021-04-14 13:34:58 +03:00
MarcLeclair
4c45f615bb [fenix] 16900 make navgraph inflation asynchronous (https://github.com/mozilla-mobile/fenix/pull/18889) 
* For https://github.com/mozilla-mobile/fenix/issues/16900: implement async navgraph inflation

For https://github.com/mozilla-mobile/fenix/issues/16900: removed nav graph from xml

For https://github.com/mozilla-mobile/fenix/issues/16900: inflate navGraph programatically

For https://github.com/mozilla-mobile/fenix/issues/16900: Made NavGraph inflation asynchronous

For https://github.com/mozilla-mobile/fenix/issues/16900: Changed to block with runBlocking

For https://github.com/mozilla-mobile/fenix/issues/16900: Refactored blocking call into a function

For 16900: NavGraph inflation is now async

We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)

For 16900: rebased upstream master

For 16900: Rebase on master

For https://github.com/mozilla-mobile/fenix/issues/16900: Fixed Async Navgraph navigation per review comments.

1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()

For https://github.com/mozilla-mobile/fenix/issues/16900: inflateNavGraphAsync now takes navController

For https://github.com/mozilla-mobile/fenix/issues/16900: Pass lifecycleScope to NavGraphProvider

For https://github.com/mozilla-mobile/fenix/issues/16900: removed unused mock

For https://github.com/mozilla-mobile/fenix/issues/16900: Added linter rules for navigate calls

We need linting rules to make sure no one calls the NavController.navigate() methods

For https://github.com/mozilla-mobile/fenix/issues/16900: Added TestRule to help abstract the mocks in the code

For 16900: Fix linting problems

For https://github.com/mozilla-mobile/fenix/issues/16900: Cleaned duplicated code in tests

For https://github.com/mozilla-mobile/fenix/issues/16900: cleaned up NavGraphTestRule for finished test

For https://github.com/mozilla-mobile/fenix/issues/16900: had to revert an accidentally edited file

For https://github.com/mozilla-mobile/fenix/issues/16900: rebased master

* For https://github.com/mozilla-mobile/fenix/issues/16900: Review nits for async navgraph

This is composed of squash commits, the original messages can be found below:

-> DisableNavGraphProviderAssertionRule + kdoc.

Use test rule in RobolectricApplication.

Fix failing CrashReporterControllerTest

Fix blame by -> navigate in tests.

This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```

Fix various blame

This is expected to be squashed into the first commit so, if so, it'd
fix the blame.

Move test rule to helpers pkg.

add missing license header

Add import change I missed

fix unused imports

Replace robolectricTestrunner with test rule.

Improve navGraphProvider docs

Remove unnecessary rule as defined by robolectric.

add clarifying comment to robolectric

remove unnecessary space

* For https://github.com/mozilla-mobile/fenix/issues/16900: nit fixes for MozillaNavigateCheck and lint fixes

3 squash commits:
 *Changed violation message and fixed the lint rule for MozillaNavigateCheck
 *Added suppression to NavController.kt
 *Fixed detekt violations

* For 16900: Fixed failing tests

Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
 2021-04-13 20:48:45 -04:00
Mozilla L10n Automation Bot
9d3edcecea [fenix] Import l10n. 2021-04-14 00:32:38 +00:00
Michael Comella
e7a15807a4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: rename CreatedActivityLogEntry -> LogEntry.ActivityCreated and similar. 
It's too much work to squash "correctly".
 2021-04-13 15:10:36 -07:00
Michael Comella
073a4dc221 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: note refactor in metrics docs. 2021-04-13 15:10:36 -07:00
Michael Comella
c04e4f392d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: replace StartupActivityStateProvider with StartupStateProvider. 
The StartupActivityStateProvider uses an imperative implementation,
driven by callbacks, to set the state of the application. This is hard
to follow as you need to understand which callbacks will be called in
which order. For example, to make sense of an implementation like this,
COLD, WARM, AND HOT would likely need to be implemented in separate
ActivityLifecycleCallbacks.

I feel the StartupStateProvider is an improvement because it leverages
the StartupActivityLog to query a linear state for a more understandable
implementation. Furthermore, it seems accessible to write COLD, WARM,
and HOT in the same class because they can all be approached the same
way.
 2021-04-13 15:10:36 -07:00
Michael Comella
4411a9c84a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupStateProvider. 2021-04-13 15:10:36 -07:00
Michael Comella
7d0024ab93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: prevent StartupActivityLog from growing infinitely. 
We do this is as a separate commit over the original implementation
because it's simpler to implement the class without this optimization.
 2021-04-13 15:10:36 -07:00
Michael Comella
7286daabe9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupActivityLog, tests. 2021-04-13 15:10:36 -07:00
Jonathan Almeida
5000e54aaf [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18931: Implement add to collections in interactor 
We moved the collection dialog code out from the old fragment, because it
had nothing to do with tabs tray, and into the collections package to be
re-usable in other parts of the app.

In addition, we also make use of it in the new tabs tray's
NavigationInteractor.
 2021-04-14 01:48:35 +04:00
Jonathan Almeida
e50350db14 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931: Move dialog adapter to collections package 2021-04-14 01:48:35 +04:00
Jonathan Almeida
35947762b7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931: Rename class to CollectionsListAdapter 2021-04-14 01:48:35 +04:00
Christian Sadilek
858320fe6b [fenix] Upgrade to Android Components 75.0.20210413143139 2021-04-13 12:10:36 -04:00
Jonathan Almeida
167d925c12 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18934: Remove adapter when deataching from window 2021-04-13 19:00:01 +04:00
Jonathan Almeida
4ba99372f2 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18885: Dismiss FAB icon when tabs tray is closed 2021-04-13 18:59:16 +04:00
mcarare
ed8d36520e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18375: Add experiment for set default browser New Tab card. 2021-04-13 17:25:51 +03:00
Elise Richards
a5d8e40932 [fenix] Add ignores for intermittent toolbar tests 2021-04-13 13:21:29 +03:00
Mozilla L10n Automation Bot
aae8d26393 [fenix] Import l10n. 2021-04-13 00:55:06 +00:00
Jonathan Almeida
df807cf612 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18973: Fix references to info banner 2021-04-13 04:15:43 +04:00
Roger Yang
425c9d857b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18522: Re-add call to action in tabs tray 2021-04-13 02:01:42 +04:00
Elise Richards
856e133f4d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18806: Show sync tabs or sync account sign in based on feature flag (https://github.com/mozilla-mobile/fenix/pull/18859) 
* Show sync tabs or sync account sign in based on feature flag. Sign in navigates to account settings on click.

* lint and nits
 2021-04-12 16:01:33 -05:00
Roger Yang
820f3f1521 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18899: Update content description string for synced tabs icon (https://github.com/mozilla-mobile/fenix/pull/18963) 2021-04-12 15:16:38 -04:00
Jonathan Almeida
5819a7c0a4 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18862: Add multi-select banner to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18932) 
* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add new addBookmark BookmarksUseCase

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add class for state binding features

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add delete multiple tabs to tray interactor

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add new actions to navigation interactor

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Enable select mode from main tray menu

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add menu when in select mode

* Close https://github.com/mozilla-mobile/fenix/issues/18862: Add multi-select banner to tabs tray

* Close https://github.com/mozilla-mobile/fenix/issues/18862: Add select support for handle UI

We apply various layout changes to the "handle" UI in the tabs tray when
switching modes. It isn't quite clear to my, why we do this, if it's
really needed to meet the end result, and if there is a better way.

For now, we're simplying moving over that logic that we can re-evaluate
at a later time.
 2021-04-12 14:57:01 -04:00
Elise Richards
298c4c2814 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18960: Remove nav in homescreen three dot menu (https://github.com/mozilla-mobile/fenix/pull/18962) 
* Remove nav in homescreen three dot menu

* Remove back and forward items
 2021-04-12 13:05:58 -05:00
Arturo Mejia
22176de02c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 only show the experiment for set default browser MenuItem when Nightly, Beta, Release are not the default browser 2021-04-12 13:26:52 -04:00
Sören Hentzschel
0344ebb250 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18898 - implement quit button in page menu (https://github.com/mozilla-mobile/fenix/pull/18942) 2021-04-12 12:02:14 -05:00
Gabriel Luong
fd09f532a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18940 - Remove reserved icon spacing for "Nimbus Experiments" setting preference (https://github.com/mozilla-mobile/fenix/pull/18949) 
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
 2021-04-12 12:32:55 -04:00
Oana Horvath
8a20fdec59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17979 & https://github.com/mozilla-mobile/fenix/issues/17840: fix and re-enable UI tests affected by main menu changes 2021-04-12 19:16:17 +03:00
Oana Horvath
7d7f64f839 [fenix] Fix screenshots tests: showDefaultHomeScreen, bookmarksManagementTest 2021-04-12 16:21:35 +03:00
Mozilla L10n Automation Bot
62c179feee [fenix] Import l10n. 2021-04-12 00:38:10 +00:00
Mozilla L10n Automation Bot
b9678e5dea [fenix] Import l10n. 2021-04-11 00:25:07 +00:00
Mozilla L10n Automation Bot
ef233b706a [fenix] Import l10n. 2021-04-10 00:31:18 +00:00
Jonathan Almeida
b543a2bd4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 - Correct one more instance of the onboarding string (https://github.com/mozilla-mobile/fenix/pull/18906) 2021-04-09 15:21:26 -04:00
Gabriel Luong
e6912113d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18742 - Resize the top site item sizes (https://github.com/mozilla-mobile/fenix/pull/18751) 2021-04-09 11:47:35 -04:00
Mugurell
87b9259885 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18122 - Update browser layout for find in page bar with bottom toolbar 
With a dynamic bottom toolbar the  browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.

To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
 2021-04-09 14:48:51 +03:00
Mugurell
a7deb00521 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18616 - Update browser and toolbar layout when toolbar is at top 
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
 2021-04-09 14:48:51 +03:00
Sebastian Kaspari
a23da507c5 [fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background. 2021-04-09 12:36:27 +02:00
Sebastian Kaspari
0d5d585dd1 [fenix] Move TelemetryMiddleware to telemetry sub package. 2021-04-09 12:36:27 +02:00
mcarare
44d32189cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/18829: Adjust bookmark item color to UX specs. 2021-04-09 10:32:33 +03:00
Jonathan Almeida
6acd9c7925 [fenix] Update kdocs of navigation interactor 2021-04-09 06:50:05 +04:00
Jonathan Almeida
ab00590d17 [fenix] Call stop in deattach for feature binding 2021-04-09 06:50:05 +04:00
Jonathan Almeida
d2ca8da836 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18845: Adds swipe-to-delete to tabs tray refactor 
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.

We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
 2021-04-09 06:50:05 +04:00
Mozilla L10n Automation Bot
a02ea9b6ab [fenix] Import l10n. 2021-04-09 00:27:10 +00:00
Arturo Mejia
09b4cf71ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 Add experiment for set default browser MenuItem. 2021-04-08 15:58:43 -04:00
MarcLeclair
7ab0ea8c7f [fenix] For https://github.com/mozilla-mobile/fenix/issues/17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1 (https://github.com/mozilla-mobile/fenix/pull/18832) 
* For https://github.com/mozilla-mobile/fenix/issues/17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1

* For https://github.com/mozilla-mobile/fenix/issues/17759: fixed Android code from INT to actual version name
 2021-04-08 15:20:18 -04:00
Elise Richards
854bfa20f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17870 - Enable new three-dot menu redesign on nightly builds (https://github.com/mozilla-mobile/fenix/pull/18883) 2021-04-08 15:19:05 -04:00
Elise Richards
f674d42d7a [fenix] Settings menu item should be tinted if there is an account issue (https://github.com/mozilla-mobile/fenix/pull/18849) 2021-04-08 13:10:55 -05:00
Elise Richards
d2ad816af9 [fenix] PWA install to homescreen is available in main menu (https://github.com/mozilla-mobile/fenix/pull/18850) 2021-04-08 12:14:28 -05:00
Gabriel Luong
ee594f885e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18268, https://github.com/mozilla-mobile/fenix/issues/18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage (https://github.com/mozilla-mobile/fenix/pull/18808) 2021-04-08 12:09:57 -04:00
Gabriel Luong
71321acb0e [fenix] Update app/src/main/java/org/mozilla/fenix/ext/Activity.kt 2021-04-08 14:23:06 +03:00
Arturo Mejia
c057684ecd [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 made set a default browser functionality publicly available. 2021-04-08 14:23:06 +03:00
rxu
91a05f1dd1 [fenix] Add domestic China FxA service for Mozilla Online builds 
China fxa related string

Add switch preference in settings to use local/global fxa server

inherit fennec FxA settings

Present or hide fxa switch according to isMozillaonline

Allow China fxa server auto login during migration
 2021-04-07 23:40:59 -07:00
Mozilla L10n Automation Bot
585fc80689 [fenix] Import l10n. 2021-04-08 00:39:56 +00:00
Jonathan Almeida
94e39ff584 [fenix] No issue - Enable the tabs tray refactor in nightly (https://github.com/mozilla-mobile/fenix/pull/18858) 2021-04-07 19:02:15 -04:00
codrut.topliceanu
dc1f62eb6e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Added Icon and sync functionality 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-04-08 02:45:16 +04:00
codrut.topliceanu
695c777306 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Adds FAB to TabsTray rewrite 2021-04-08 02:45:16 +04:00
Gabriel Luong
33c1d58580 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18743 - Change the top sites label colour and size (https://github.com/mozilla-mobile/fenix/pull/18752) 2021-04-07 17:39:11 -04:00
Roger Yang
eccdb6bf8d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068: Track custom fill link from clipboard clicked (https://github.com/mozilla-mobile/fenix/pull/18827) 2021-04-07 16:31:41 -04:00
Jonathan Almeida
1adcbf6b0d [fenix] No issue: Move UseCase wrappers to the interactor; it's only usage 2021-04-07 21:23:09 +04:00
Jonathan Almeida
a890d0210e [fenix] No issue: Move menu to separate integrations class 2021-04-07 21:23:09 +04:00
Jonathan Almeida
d18854c54c [fenix] No issue: Add test for share tab in navigation interactor 
Co-authored-by: Roger Yang <royang@mozilla.com>
 2021-04-07 21:23:09 +04:00
Jonathan Almeida
3c3bf65d93 [fenix] No issue: Observe only normal tabs when updating counter 2021-04-07 21:23:09 +04:00
Jonathan Almeida
398b5823a4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Fix long parameter warnings in detekt 2021-04-07 19:14:54 +04:00
Jonathan Almeida
16f87e47e3 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774: Migrate mutli-selection to store 
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).
 2021-04-07 19:14:54 +04:00
Jonathan Almeida
0b1336868c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Move SelectionInteractor to new package 
The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.
 2021-04-07 19:14:54 +04:00
Arturo Mejia
d024b9bc93 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16557 set autoplay block audio only 
by default
 2021-04-07 07:04:59 -04:00
Mozilla L10n Automation Bot
922110c303 [fenix] Import l10n. 2021-04-07 00:26:52 +00:00
Elise Richards
16c4823bef [fenix] For https://github.com/mozilla-mobile/fenix/issues/18770 - Correct addons position in three dot menu based on toolbar position (https://github.com/mozilla-mobile/fenix/pull/18828) 2021-04-06 15:40:32 -04:00
Grisha Kruglov
242ea763de [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17361: Extend perf.awesomebar.* metrics 2021-04-06 11:50:08 -07:00
Gabriel Luong
77a540b659 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18819 - Hide the Credit Card preference by default (https://github.com/mozilla-mobile/fenix/pull/18820) 2021-04-06 13:43:51 -04:00
Mozilla L10n Automation Bot
cb30e7fde7 [fenix] Import l10n. 2021-04-06 17:28:45 +00:00
Roger Yang
7b72b9e85b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18513: Re-add menu to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18756) 2021-04-06 10:26:41 -04:00
Jonathan Almeida
3ec3c16c70 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Set the span count for grid view 2021-04-06 09:57:33 +04:00
Jonathan Almeida
8fa60a67af [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Do not animate first scroll to position 
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
 2021-04-06 09:57:33 +04:00
Jonathan Almeida
9e3bd75692 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Move list/grid viewholders to browser package 2021-04-06 09:57:33 +04:00
Kate Glazko
a5ea92912f [fenix] For 17798: Sync Menu Item 2021-04-05 14:34:34 -07:00
Jonathan Almeida
94688bf59b [fenix] Close https://github.com/mozilla-mobile/fenix/issues/17821: Add TabsTrayStore with actions and reducer (https://github.com/mozilla-mobile/fenix/pull/18773) 2021-04-05 15:12:07 -04:00
Jonathan Almeida
5beadfdb15 [fenix] No issue - Make TabLayoutMediator lifecycle aware (https://github.com/mozilla-mobile/fenix/pull/18779) 2021-04-05 15:10:29 -04:00
Travis Long
5b26effc9a [fenix] [SDK-246] Change Nimbus channel input to use the same method as Glean (https://github.com/mozilla-mobile/fenix/pull/18766) 
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean

* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-04-05 12:30:25 -04:00
VaishnaviShri
4536a2a35e [fenix] For https://github.com/mozilla-mobile/fenix/issues/8545: Fix unnecessary scroll in home screen 
Changed the height of the recycler view inside the home fragment
to ‘wrap_content’ to avoid scrolling if the viewport is not filled
with elements.

Closes https://github.com/mozilla-mobile/fenix/issues/8545
 2021-04-05 09:15:06 +03:00
Mozilla L10n Automation Bot
ddb145b3cb [fenix] Import l10n. 2021-04-05 00:28:16 +00:00
Mozilla L10n Automation Bot
dba715e17a [fenix] Import l10n. 2021-04-04 00:29:06 +00:00
Gabriel Luong
d45e4c4e42 [fenix] Use photon colors from ui-color (https://github.com/mozilla-mobile/fenix/pull/18760) 2021-04-03 10:26:53 -04:00
Gabriel Luong
46e6ea9e85 [fenix] No issue - Remove generic strings for more specificity (https://github.com/mozilla-mobile/fenix/pull/18769) 2021-04-02 15:24:28 -04:00
Mugurell
91cc54d75b [fenix] For https://github.com/mozilla-mobile/fenix/issues/17772 - Collapse browser menu to "Add to Home screen" 
The menu will start as collapsed.
Users can then swipe up to expand it.
 2021-04-02 18:45:27 +03:00
Gabriel Luong
a13c6f3f2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18265 - [Add card] Integrate the credit card storage and handle adding a new credit card (https://github.com/mozilla-mobile/fenix/pull/18719) 2021-04-02 10:40:44 -04:00
Michael Comella
028cfd0597 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18731: remove anonymous classes from StrictModeManager. 
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
 2021-04-01 13:19:49 -07:00
Gabriel Luong
5224c11879 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18729 - Use consistent string naming for generic strings (https://github.com/mozilla-mobile/fenix/pull/18730) 2021-03-31 18:20:04 -04:00
Elise Richards
990fe44056 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17770: New tab three-dot menu reorder (https://github.com/mozilla-mobile/fenix/pull/18427) 
* Create new menu order for new tab

* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.

* Lint

Lint and refactoring tests

* Tests for default toolbar menu

* Feature flag for request desktop site

Add todos for UI test issue 17979

Add todos for UI tests
 2021-03-31 16:05:44 -05:00
mcarare
bcbd67bb07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18717: Use normal theme color for tab tray synced tabs. 2021-03-31 18:30:05 +04:00
Mugurell
433b0f0bdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/18617 - Use the new EngineView#getInputResultDetail() 
All functionality should remain the same.
 2021-03-31 15:36:38 +03:00
AndiAJ
5f52f0140f [fenix] Disable failing UI Tests 2021-03-31 13:06:18 +03:00
mcarare
df747ca855 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17797: Add bookmarks menu item. 2021-03-31 11:12:58 +03:00
Roger Yang
c164b2308b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18706 - Remove unneeded add-on telemetry calls (https://github.com/mozilla-mobile/fenix/pull/18707) 2021-03-30 16:19:00 -04:00
rxumoz
305bb7f48a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18386 - Change language display name to traditional/simplified Chinese for Chinese locale (https://github.com/mozilla-mobile/fenix/pull/18387) 2021-03-30 16:18:31 -04:00
Mihai Adrian Carare
4da13e56c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. (https://github.com/mozilla-mobile/fenix/pull/18653) 2021-03-30 16:12:46 -04:00
Roger Yang
56fcf0e457 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18514: Re-add tab counter in tabs tray (https://github.com/mozilla-mobile/fenix/pull/18659) 2021-03-30 15:43:07 -04:00
Michael Comella
b26d782c2f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add data review links. 2021-03-30 10:38:44 -07:00
Michael Comella
9c3ad5608a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: warn about flaw in app_opened_all_startup probe. 2021-03-30 10:38:44 -07:00
Michael Comella
c5bfc690d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: record cold start duration telemetry. 2021-03-30 10:38:44 -07:00
Michael Comella
f5accce70f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add StartupActivityStateProvider. 
This will be used to filter conditions for the start up telemetry we're
adding.
 2021-03-30 10:38:44 -07:00
Michael Comella
ee31fe29c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add ApplicationStartReasonProvider. 
We need to know this state to add a correct COLD MAIN probe.
 2021-03-30 10:38:44 -07:00
Michael Comella
04af130922 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add DefaultActivityLifecycleCallbacks. 
We'll extend this in subsequent commits.
 2021-03-30 10:38:44 -07:00
Oana Horvath
6dff34ee33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18644: fix metod to verify system notifications 2021-03-30 18:19:02 +03:00
Jonathan Almeida
9feca460c1 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14117: Add Synced Tabs as a page in the tabs tray 2021-03-30 19:09:50 +04:00
Oana Horvath
e4614fd8a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18421: Ignore the ContextMenusTest class because of test failures 2021-03-30 17:12:49 +03:00
Gabriel Luong
4cab53bb65 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18247 - [Add card] Populate the Credit card expiry year drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
57c0eb196a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18246 - [Add card] Populate the Credit card expiry month drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
5f5d03ee19 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18243 - Add a credit card editor screen 2021-03-29 21:37:03 -04:00
Jonathan Almeida
e6d88f4669 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18521: Focus on page corresponding to selected tab 
This first part of https://github.com/mozilla-mobile/fenix/issues/18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
 2021-03-30 03:08:01 +04:00
Jonathan Almeida
11b1e0a461 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668: Add stable ID cache for TabAdapter.getItemId 2021-03-30 02:58:54 +04:00
yichiehc
1006a699c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16830: Increase the Show in private sessions option in Search Preferences Settings (https://github.com/mozilla-mobile/fenix/pull/18689) 
* For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605)

* For https://github.com/mozilla-mobile/fenix/issues/16830: Increase the Show in private sessions option in Search Preferences Settings

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-03-29 17:06:29 -05:00
Aaron Klotz
6c8838adb7 [fenix] Explicitly set android:extractNativeLibs to true in ApplicationManifest.xml 
The Android Gradle Plugin's default for android:extractNativeLibs changed from
true to false beginning with version 3.6.0. Based on GeckoView's needs, we
should ensure that this attribute is explicitly set to true.
 2021-03-29 12:52:34 -07:00
Michael Droettboom
2fb552617a [fenix] Bug 1689162: Update Glean metrics.yaml schema (https://github.com/mozilla-mobile/fenix/pull/18683) 2021-03-29 11:53:45 -04:00
Kershan
bd7ca49b17 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18453 - Show SUMO for default browser deeplink on Android <N 
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
 2021-03-29 18:14:15 +03:00
Arturo Mejia
d23cc020cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Improve Onboarding strings 2021-03-27 08:48:13 -04:00
Jonathan Almeida
debb6bbc7b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443: Move viewholders to separate files and package 2021-03-27 03:42:34 +04:00
Jonathan Almeida
5f2ac9fbc0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443: Fix changes between grid/list viewholders 2021-03-27 03:42:34 +04:00
Jonathan Almeida
0e3def9e83 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18443: Use recyclerview-selection for multi-select mode in tray 
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
 2021-03-27 03:42:34 +04:00
Gabriel Luong
83e350ed4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/17291 - Display a list of all active Nimbus experiments (https://github.com/mozilla-mobile/fenix/pull/17515) 2021-03-26 13:58:30 -04:00
yichiehc
6dd598c8db [fenix] For https://github.com/mozilla-mobile/fenix/issues/18594: Highlight the "Default browser" system setting on Android >= N 
Although not public APIs we can use specific extras in the Intent used to open
system settings such that the "Default browser" setting is highlighted to
provide a better UX for users looking to set Fenix as default.
 2021-03-26 18:25:56 +02:00
rxumoz
c22c6c1b3d [fenix] Update top sites to add PDD for MozillaOnline builds (https://github.com/mozilla-mobile/fenix/pull/18615) 2021-03-26 12:18:46 -04:00
Mihai Adrian Carare
89321fbec1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18260 - Add pin to default sites. (https://github.com/mozilla-mobile/fenix/pull/18618) 2021-03-26 11:36:27 -04:00
Roger Yang
d4fa548812 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18535: Re-add grid layout to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18638) 2021-03-26 10:33:46 -04:00
Oana Horvath
b9aa2166ca [fenix] Disable customTrackingProtectionSettingsTest 2021-03-26 16:25:14 +02:00
Oana Horvath
8950cb0b73 [fenix] Re-enable working UI tests from https://github.com/mozilla-mobile/fenix/issues/18644 2021-03-26 16:25:14 +02:00
Mozilla L10n Automation Bot
0875ac09ed [fenix] Import l10n. 2021-03-26 11:39:00 +00:00
Mugurell
baab77eb92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 - Temporarily disabling UI tests that fail on Firebase. 
This is a quick solution to resume PR merges.
Investigations and a proper fix is to follow on this same ticket.
 2021-03-26 13:06:05 +02:00
Arturo Mejia
c9f822d0d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Optimize the order and messages of onboarding cards 2021-03-24 22:16:00 -04:00
Aaron Train
5a89e3da5d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18623: Fix Gradle task name in gradlewbuild.py (https://github.com/mozilla-mobile/fenix/pull/18624) 2021-03-24 15:33:17 -04:00
Roger Yang
e1404fab67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17644: Record when user taps on a add-on's setting (https://github.com/mozilla-mobile/fenix/pull/18504) 2021-03-24 14:31:39 -04:00
Mozilla L10n Automation Bot
a1b234a67b [fenix] Import l10n. 2021-03-24 00:25:33 +00:00
Jonathan Almeida
101061cae3 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18538: Add BrowserTabsAdapter for tabs tray 2021-03-24 02:37:06 +04:00
Gabriel Luong
b3421edcf8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605) 2021-03-23 16:00:41 -04:00
mcarare
f5c72efb38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17790: Remove app from recents screen on quit. 2021-03-23 23:02:01 +04:00
Elise Richards
25d14c9a8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/17190: notifications are updated when locale is changed (https://github.com/mozilla-mobile/fenix/pull/18179) 
* Add intent processor for locale changes

* Recreate notification and notify in the service

* Use locale use cases to update notification

* Use notification id instead of tag

* Add locale use cases and restore locale in application

* Send locale to service instead of string

* Controller tests for locale

* Update Android Components version to 74.0.20210323143308

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-03-23 14:16:30 -04:00
Gabriel Luong
9272994178 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18240 - Add a Credit Card preference screen (https://github.com/mozilla-mobile/fenix/pull/18410) 
- Removes an unused preference key "pref_key_credit_cards_addresses"
 2021-03-23 11:59:32 -04:00
Roger Yang
baa22e0645 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17791: Use updated URL with custom tabs when copying to clipboard (https://github.com/mozilla-mobile/fenix/pull/18590) 2021-03-23 10:31:53 -04:00
Mugurell
ea39380daa [fenix] For https://github.com/mozilla-mobile/fenix/issues/18585 - Don't use hardcoded String values in Onboarding unit test (https://github.com/mozilla-mobile/fenix/pull/18597) 
Test if the welcome message has the expected structure and uses the expected
String values, not what the string values are.
 2021-03-23 15:54:24 +02:00