Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/18240: Adjust preference screen to fit UX specs.

Browse Source
This commit is contained in:
mcarare 2021-04-20 14:31:23 +03:00 committed by Mihai Adrian Carare
parent 1018039983
commit 7543d25b80
3 changed files with 4 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
app/src/main/res/layout/preference_credit_cards_add_credit_card.xml
View File

@ -1,40 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="@dimen/credit_cards_add_credit_card_button_height"
android:background="?android:selectableItemBackground"
android:clickable="true"
android:focusable="true"
android:paddingStart="@dimen/top_bar_alignment_margin_start"
tools:ignore="RtlSymmetry">
<ImageView
android:id="@+id/add_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:importantForAccessibility="no"
android:textAlignment="textStart"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:srcCompat="@drawable/ic_new" />
<TextView
android:id="@+id/add_credit_card_text"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/credit_cards_add_credit_card_text_horizontal_margin"
android:layout_marginEnd="@dimen/credit_cards_add_credit_card_text_horizontal_margin"
android:text="@string/preferences_credit_cards_add_credit_card"
android:textColor="?primaryText"
android:textSize="@dimen/credit_cards_add_credit_card_text_size"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/add_icon"
app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>

7
app/src/main/res/values/dimens.xml
View File

@ -214,13 +214,6 @@
<dimen name="top_sites_text_margin_top">8dp</dimen>
<!-- Credit Cards Fragment -->
<!-- The height of the "Add credit card" button in the Credit Cards fragment.
This should be the same value as search_engine_radio_button_height. -->
<dimen name="credit_cards_add_credit_card_button_height">48dp</dimen>
<!-- The horizontal margin for the "Add credit card" text.
This should be the same value as radio_button_padding_horizontal. -->
<dimen name="credit_cards_add_credit_card_text_horizontal_margin">16dp</dimen>
<dimen name="credit_cards_add_credit_card_text_size">16sp</dimen>
<dimen name="credit_cards_saved_cards_item_margin_start">16dp</dimen>
<dimen name="credit_cards_saved_cards_item_margin_end">48dp</dimen>

6
app/src/main/res/xml/credit_cards_preferences.xml
View File

@ -14,10 +14,12 @@
android:title="@string/preferences_credit_cards_sync_cards_across_devices"
app:allowDividerBelow="true" />
<Preference
android:icon="@drawable/ic_new"
android:key="@string/pref_key_credit_cards_add_credit_card"
android:title="@string/preferences_credit_cards_add_credit_card"
android:layout="@layout/preference_credit_cards_add_credit_card" />
app:allowDividerAbove="true" />
<Preference
android:key="@string/pref_key_credit_cards_manage_saved_cards"
android:title="@string/preferences_credit_cards_manage_saved_cards" />
android:title="@string/preferences_credit_cards_manage_saved_cards"
app:allowDividerAbove="true" />
</PreferenceScreen>