Commit Graph

45737 Commits (jgrpp)

Author SHA1 Message Date
Tyler Trahan 4cbaac6dac
Fix #10239: Use elevated snow height for roads on flat foundations (#12776) 3 months ago
Loïc Guilloux d7137651f2
Fix #12787: boostrap doesn't have main vindow (#12788) 3 months ago
Peter Nelson b991a399ef
Codechange: Split MakeNWidget to improve readability. (#12785)
Split MakeNWidget() into two stages, widget-creation and attribute-applying, to reduce function size and make it clearer.
3 months ago
Peter Nelson 22d70f9334
Codechange: Pass NewGRF ByteReader by reference. (#12786)
ByteReader must be present and not null, so don't use a pointer.
3 months ago
Peter Nelson b68172c225
Codechange: Use std::endian instead of TTD_ENDIAN where trivial. (#12778) 3 months ago
Peter Nelson f9f07e9001
Fix #12775: Text truncated incorrectly on Windows. (#12782)
Caused by a -1 in the wrong place, which moved glyphs left one pixel.
3 months ago
Peter Nelson 7b7e00123e Codechange: Shuffle RoadStop members to reduce size.
Size is reduced from 40 bytes to 32 bytes on 64 bit platforms.
3 months ago
Peter Nelson 77f62e0c90 Codechange: Shuffle OrderList members to reduce size.
Size is reduced from 40 bytes to 32 bytes on 64 bit platforms.
3 months ago
Jonathan G Rennison ffbc5aff6d Fix various formatting and spelling issues 3 months ago
Jonathan G Rennison de36e9545e Merge branch 'master' into jgrpp
# Conflicts:
#	src/cargopacket.h
#	src/cargotype.h
#	src/station_base.h
#	src/station_cmd.cpp
#	src/timer/timer_game_common.h
#	src/town.h
3 months ago
Peter Nelson 4b169426dc Fix #12764: Crash when opening Detailed performance rating window with no companies. (#12765)
(cherry picked from commit df1b6a933b)
3 months ago
Jonathan G Rennison fff46974fd Scheduled dispatch: Allow naming departure slot tags 3 months ago
Jonathan G Rennison fe294403aa Add std::string_view variant of SetDParamStr 3 months ago
Jonathan G Rennison ef91ed1dfb Scheduled dispatch: Fix string names for departure tag 3 months ago
Jonathan G Rennison 6a03992a03 Scheduled dispatch: Add dividers to management dropdowns 3 months ago
translators 219995c643 Update: Translations from eints
polish: 1 change by pAter-exe
3 months ago
Peter Nelson 55314513ce
Codechange: Pass NWidgetParts as span instead of begin/end pointers. (#12779) 3 months ago
translators 81b5a7c7c6 Update: Translations from eints
german: 62 changes by Wuzzy2
3 months ago
Peter Nelson 4cf6d1dd79
Codechange: Pass WindowDesc by reference instead of pointer. (#12771)
WindowDesc as passed to Windows is not optional so don't allow to it to be nullptr.
3 months ago
Jonathan G Rennison c67f14dc88 Merge branch 'master' into jgrpp
# Conflicts:
#	src/fileio.cpp
#	src/fileio_func.h
#	src/industry_cmd.cpp
#	src/ini.cpp
#	src/openttd.cpp
#	src/os/windows/win32_main.cpp
#	src/settingsgen/settingsgen.cpp
#	src/strgen/strgen.cpp
#	src/strings.cpp
3 months ago
Jonathan G Rennison 79fe829e98 Allow road vehicle overtaking in road waypoint tiles 3 months ago
Jonathan G Rennison 102ba8932e Remove use of non-threadsafe strerror
Add helper class to use strerror_r or strerror_s
3 months ago
Jonathan G Rennison 81ba704477 Fix e53998ec0: Incorrect handling of changed path separators in strgen 3 months ago
translators 18bce69623 Update: Translations from eints
galician: 3 changes by pvillaverde
danish: 1 change by bscargo
polish: 5 changes by pAter-exe
3 months ago
Steve Goldman 7db756e602 Change: Do not automatically connect double depots with track 3 months ago
Jonathan G Rennison fa82dd6096 Fix #12030: Water infrastructure totals when using DC_FORCE_CLEAR_TILE
To remove objects on water
3 months ago
Qwest8K 162015433e
Update: Russian translation to ''af102d1'' commit (#703)
Update: Russian translation to ''af102d1''
3 months ago
Peter Nelson b4b2fad8e0
Fix #12648: Ensure all uses of std::filesystem::path use native encoding. (#12650)
std::filesystem::path does not expect UTF-8 strings, so they must be converted to native format first (and back to utf-8 after.)
3 months ago
Peter Nelson fce9361bf2 Change: Position caret on left or right of glyph depending on language direction. 3 months ago
Peter Nelson 5cd81a980e Codechange: Store both left and right glyph positions in a run.
This also allows the end of a run to be known without using an extra position entry.
3 months ago
Peter Nelson 80ddcb9d7d Codechange: Move GetCharPosInString/GetCharAtPosition to gfx_layout.
These functions are related more to layouting than graphics.
3 months ago
Peter Nelson bbbf2b5282 Codechange: Return read-only span instead of vector from layout run functions. 3 months ago
translators 6bf214af6e Update: Translations from eints
vietnamese: 3 changes by KhoiCanDev
polish: 13 changes by pAter-exe
4 months ago
Jonathan G Rennison e53998ec01 Merge branch 'master' into jgrpp
# Conflicts:
#	src/cheat_gui.cpp
#	src/industry_gui.cpp
#	src/linkgraph/linkgraphschedule.cpp
#	src/misc/getoptdata.h
#	src/music/dmusic.cpp
#	src/network/core/os_abstraction.cpp
#	src/newgrf_engine.cpp
#	src/openttd.cpp
#	src/order_gui.cpp
#	src/os/windows/win32.cpp
#	src/pathfinder/npf/queue.cpp
#	src/smallmap_gui.cpp
#	src/strgen/strgen.cpp
4 months ago
Peter Nelson 79c1492a73
Codechange: Use unique_ptr in MemoryDumper. (#12766)
This replaces C-style manual memory management.
4 months ago
Jonathan G Rennison af7ad964dd
Codechange: Avoid unnecessary allocation of temporaries in layout line cache (#12737) 4 months ago
translators d7eb29d292 Update: Translations from eints
dutch: 2 changes by Afoklala
4 months ago
Peter Nelson df1b6a933b
Fix #12764: Crash when opening Detailed performance rating window with no companies. (#12765) 4 months ago
translators 79b573704b Update: Translations from eints
french: 1 change by ottdfevr
portuguese: 2 changes by azulcosta
polish: 33 changes by pAter-exe
4 months ago
Peter Nelson 66044472d7 Codechange: Use std::unordered_map for NewGRF language_map.
NewGRFs only use a small subset of the available language IDs. Using an unordered_map allows only the reference languages to have space allocated.

This avoids manual new/delete of array.
4 months ago
Peter Nelson fee73f3253 Codechange: Split types out of newgrf_text.h 4 months ago
translators fa24a3ec6b Update: Translations from eints
korean: 1 change by telk5093
4 months ago
Jonathan G Rennison af102d123b Add button to toggle train purchase window dual pane mode 4 months ago
Jonathan G Rennison 8a134d0f94 Fix narrowing cast warning 4 months ago
Jonathan G Rennison 827146de00 Dirty settings window when using mode toggle in signal window 4 months ago
Jeremy Gao bca37ef9e7 Change: correct punctuations in zh_CN 4 months ago
Jonathan G Rennison fa9db4ed6d Debug: Fix missing newlines in multi-line vehicle flags 4 months ago
Jonathan G Rennison f9b75ed304 Merge branch 'master' into jgrpp
# Conflicts:
#	cmake/scripts/FindVersion.cmake
#	src/airport_gui.cpp
#	src/industry_gui.cpp
#	src/newgrf.cpp
#	src/newgrf_class_func.h
#	src/newgrf_object.h
#	src/newgrf_roadstop.cpp
#	src/newgrf_roadstop.h
#	src/object_gui.cpp
#	src/rail_gui.cpp
#	src/road_cmd.h
#	src/road_gui.cpp
#	src/station_cmd.h
#	src/strings.cpp
#	src/waypoint_cmd.h
4 months ago
Jonathan G Rennison 2aefeec225 Fix infrastructure totals when removing canals in ForceClearWaterTile 4 months ago
Jonathan G Rennison 226c3d5d17 Apply limit train acceleration setting before acceleration scaling
See: #699
4 months ago
Jonathan G Rennison c3829f5088 Show scheduled dispatch tag in order window 4 months ago
translators 1f636d94d4 Update: Translations from eints
finnish: 2 changes by hpiirai
4 months ago
Peter Nelson 57186d4650
Fix: Editbox behaved improperly with RTL languages. (#12746)
Text in the editbox was always left-aligned and did not scroll with the caret position.
4 months ago
Peter Nelson 579ce8eae0
Codefix: Find GRF override entries properly. (#12743)
My naive code from 16 years ago tested for GRF overrides in a way that will create empty 0 entries for each source GRF tested.
4 months ago
translators 342a7cebd6 Update: Translations from eints
english (au): 2 changes by krysclarke
chinese (simplified): 2 changes by WenSimEHRP
urdu: 6 changes by haidermazhar
russian: 2 changes by Ln-Wolf
catalan: 3 changes by J0anJosep
latvian: 2 changes by lexuslatvia
portuguese (brazilian): 2 changes by pasantoro
4 months ago
Peter Nelson 5fd23a2d70
Codechange: Pre-reserve vectors during NewGRF loading. (#12748)
Call reserve when we are given the number of elements up front. This reduces the number of reallocations and over-allocations done during loading.
4 months ago
translators 01c75fc578 Update: Translations from eints
urdu: 24 changes by haidermazhar
4 months ago
Jonathan G Rennison 9aca7ed2b4 Fix logging of game load times in crash and desync logs 4 months ago
Peter Nelson 1ab280a27a
Change: Use UK OSK layout for English (UK) (#12720) 4 months ago
translators 0d10c5e93c Update: Translations from eints
greek: 1 change by gh658804
4 months ago
Jonathan G Rennison 05915b2129 Fix handling of reservations when reserving at one way tunnel-bridge exit 4 months ago
Peter Nelson 6d2424c0ef
Codechange: Update each town label dimensions once during map gen. (#12742)
This avoids re-layouting the label for each change in population as the town is grown.
4 months ago
Peter Nelson 96fc367bcf
Change: [NewGRF] Treat house max year 0xFFFF as MAX_YEAR. (#12740) 4 months ago
translators 3827229c74 Update: Translations from eints
english (us): 1 change by 2TallTyler
finnish: 1 change by hpiirai
dutch: 1 change by Afoklala
4 months ago
Alistair Lynn 7ef8706ed2 Add: Setting to uniformly slow the acceleration and braking of realistic trains
This does not affect the maximum speed.
4 months ago
Jonathan G Rennison 0351734729 Fix narrowing warning using packet GetDeserialisationPosition 4 months ago
Jonathan G Rennison 7997430688 Add various missing includes 4 months ago
Jonathan G Rennison f09f412c43 Add hash table index to EngineOverrideManager
Use for EngineOverrideManager::GetID lookups
4 months ago
Jonathan G Rennison 556722399a Move EngineOverrideManager to separate header 4 months ago
Jonathan G Rennison b42d12deb2 Add do/while wrappers around grfmsg/GrfMsg 4 months ago
Jonathan G Rennison 32b8ec34ff Merge branch 'master' into jgrpp
# Conflicts:
#	src/autoreplace_gui.cpp
#	src/build_vehicle_gui.cpp
#	src/cheat_gui.cpp
#	src/company_gui.cpp
#	src/debug.cpp
#	src/engine_gui.h
#	src/error_gui.cpp
#	src/group_gui.cpp
#	src/industry_cmd.cpp
#	src/industry_gui.cpp
#	src/misc_gui.cpp
#	src/network/network_gui.cpp
#	src/newgrf.cpp
#	src/newgrf_debug_gui.cpp
#	src/newgrf_gui.cpp
#	src/order_gui.cpp
#	src/rail_gui.cpp
#	src/road_gui.cpp
#	src/saveload/saveload.cpp
#	src/screenshot_gui.cpp
#	src/sound/win32_s.cpp
#	src/statusbar_gui.cpp
#	src/strgen/strgen.cpp
#	src/table/newgrf_debug_data.h
#	src/timetable_gui.cpp
#	src/toolbar_gui.cpp
#	src/town_gui.cpp
#	src/vehicle_gui.cpp
#	src/video/sdl2_v.cpp
#	src/video/sdl_v.cpp
#	src/viewport.cpp
4 months ago
Peter Nelson 7e914a0568 Fix #12738, de16655f: Fallback font searcher failure since ? substitution removed.
Fallback font searcher looked for the substituted ? glyph, which was removed by #12736.

Instead of comparing against a sprite, test against the font returning a missing glyph.

This should also improve performance of fallback font searching, as previously glyphs were actually rendered while searching.
4 months ago
translators 5bca185923 Update: Translations from eints
english (au): 1 change by krysclarke
chinese (simplified): 1 change by WenSimEHRP
russian: 1 change by Ln-Wolf
slovak: 20 changes by Kukoluk
latvian: 1 change by lexuslatvia
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
4 months ago
Rubidium 31085230a6 Codechange: use std::vector for the available neighbours 4 months ago
Rubidium 2864f3b3eb Cleanup: remove C-style hash, binary heap and priority queue 4 months ago
Rubidium 0e75dfd49f Codechange: migrate aystar to use YAPF's nodelist infrastructure 4 months ago
Peter Nelson 48539992e8 Codechange: Use std::unordered_map for storing TrueTypeFontCache's GlyphEntry. 4 months ago
Peter Nelson 7b717fcccb Codechange: Replace AllocatorProc with SpriteAllocator class.
This allows for state to be passed to or maintained by the allocator.
4 months ago
Jonathan G Rennison c6c7191b16 Avoid unnecessary allocation of temporaries in layout line cache 4 months ago
Jonathan G Rennison 99e6b75337 Move NewGRF sprite dump declarations to new header file 4 months ago
Jonathan G Rennison dc6ba9b9d8 Move NewGRF shadow copy groups into internal header 4 months ago
Peter Nelson de16655f76
Change: [UI] Remove substitution of missing glyph with '?' glyph. (#12736)
When a glyph does not exist, we substitute it with the '?' glyph instead, but layouters are not aware of this substitution.
4 months ago
Jonathan G Rennison 56356bb761 Change container type for several uses of std::map/std::set 4 months ago
Jonathan G Rennison 853ed272be Merge branch 'master' into jgrpp
# Conflicts:
#	src/airport_gui.cpp
#	src/blitter/32bpp_optimized.cpp
#	src/blitter/32bpp_simple.cpp
#	src/blitter/32bpp_sse2.cpp
#	src/blitter/8bpp_optimized.cpp
#	src/blitter/8bpp_simple.cpp
#	src/blitter/null.cpp
#	src/build_vehicle_gui.cpp
#	src/company_gui.cpp
#	src/crashlog.cpp
#	src/dropdown.cpp
#	src/dropdown_type.h
#	src/genworld_gui.cpp
#	src/gfx.cpp
#	src/main_gui.cpp
#	src/newgrf_debug_gui.cpp
#	src/news_gui.cpp
#	src/news_type.h
#	src/openttd.cpp
#	src/order_gui.cpp
#	src/settings.cpp
#	src/settings_gui.cpp
#	src/signs.cpp
#	src/smallmap_gui.cpp
#	src/spritecache.cpp
#	src/spriteloader/grf.cpp
#	src/texteff.cpp
#	src/toolbar_gui.cpp
#	src/town_cmd.cpp
#	src/vehicle.cpp
#	src/vehicle_gui.cpp
#	src/video/opengl.cpp
#	src/viewport.cpp
#	src/waypoint_cmd.cpp
#	src/zoom_type.h
4 months ago
Peter Nelson 9c19cf06e4
Change: [UI] Use SetMinimalTextLines to set label height correctly. (#12734)
SetMinimalSize does not know about font size, so these labels were incorrectly sized if the font height is different from normal.
4 months ago
Peter Nelson 0f230244fe
Codechange: [UI] Remove redundant SetMinimalSize for WWT_EDITBOX widgets. (#12733) 4 months ago
Tyler Trahan deb77463b0
Fix #12492: Clarify helptext for "minutes per year" setting (#12726) 4 months ago
Jonathan G Rennison 85918fc23e Fix: Water infrastructure total when changing owner of object on water 4 months ago
Jonathan G Rennison cb1e41fc88 Remove use of memcmp in CheckCaches 4 months ago
Peter Nelson 2e7819927f
Fix: Invalidate game options window after changing base sounds set. (#12731) 4 months ago
translators 51e170a8d0 Update: Translations from eints
swedish: 12 changes by sereneavatar
4 months ago
Jonathan G Rennison 2b539a2d37 Fix water infrastructure total when changing owner of object on water 4 months ago
Jonathan G Rennison 1e9fb74451 Merge branch 'master' into jgrpp
# Conflicts:
#	.github/workflows/release-windows.yml
#	src/autoreplace_gui.cpp
#	src/cargotype.cpp
#	src/company_base.h
#	src/company_cmd.cpp
#	src/company_gui.cpp
#	src/currency.h
#	src/date_gui.cpp
#	src/dropdown.cpp
#	src/dropdown_func.h
#	src/dropdown_type.h
#	src/game/game_gui.cpp
#	src/genworld.cpp
#	src/genworld_gui.cpp
#	src/ground_vehicle.hpp
#	src/group_gui.cpp
#	src/house.h
#	src/industry_gui.cpp
#	src/network/network_client.cpp
#	src/network/network_server.cpp
#	src/network/network_type.h
#	src/newgrf_class_func.h
#	src/newgrf_house.cpp
#	src/newgrf_roadstop.h
#	src/openttd.cpp
#	src/order_gui.cpp
#	src/saveload/saveload.cpp
#	src/saveload/saveload.h
#	src/screenshot_gui.cpp
#	src/settings_gui.cpp
#	src/settings_type.h
#	src/slider.cpp
#	src/smallmap_gui.cpp
#	src/station_cmd.cpp
#	src/stdafx.h
#	src/survey.cpp
#	src/tile_map.h
#	src/town_cmd.cpp
#	src/town_gui.cpp
#	src/vehicle.cpp
#	src/vehicle_gui.cpp
#	src/vehicle_gui_base.h
4 months ago
Jonathan G Rennison cbea3b8b46 Add console command to merge two companies 4 months ago
Peter Nelson f220ed179d
Codechange: Use std::unordered_map for SpriteFontCache's glyph map. (#12724)
Replaces a C-style malloc'd array and malloc'd contents, and no manual memory clean up is necessary.
4 months ago
Peter Nelson 3d4b98845a
Codechange: Remove initial colour from layouter cache. (#12728)
Initial colour is now always TC_INVALID, which is substituted with the desired colour when drawing the layout line.

This allows strings which differ only by initial colour to use the same layout cache entry, increasing the efficacy of the cache.
4 months ago
Jonathan G Rennison f2f8692fb2 Add setting to allow track editing to ignore realistic braking restrictions 4 months ago
translators 605dff4920 Update: Translations from eints
swedish: 9 changes by joeax910
english (us): 2 changes by 2TallTyler
luxembourgish: 4 changes by phreeze83
catalan: 2 changes by J0anJosep
latvian: 27 changes by lexuslatvia
4 months ago
Tyler Trahan 37f68a65ee
Fix #12283: Vehicle group dropdown shouldn't have default action (#12727) 4 months ago
Jonathan G Rennison 7874fb7a12 Add public key auth support for settings_access console command 4 months ago
Jonathan G Rennison 84a0dd326f Merge branch 'master' into jgrpp
# Conflicts:
#	src/console_cmds.cpp
#	src/network/core/config.h
#	src/network/core/packet.h
#	src/network/core/tcp.cpp
#	src/network/core/tcp_game.cpp
#	src/network/core/tcp_game.h
#	src/network/network_client.cpp
#	src/network/network_client.h
#	src/network/network_gui.h
#	src/network/network_server.cpp
#	src/network/network_server.h
#	src/table/settings/network_secrets_settings.ini
4 months ago
Peter Nelson f6c5da4cad
Fix: Incorrect dump_info output with labels outside of ascii range. (#12723)
An unspecified cargo label is 0x00000000, which terminates C-strings.
4 months ago
Peter Nelson 4b81b62b72
Change: Don't reinitialise font caches when setting initial interface scale. (#12722) 4 months ago
translators 692943669d Update: Translations from eints
galician: 34 changes by pvillaverde
greek: 3 changes by gh658804
4 months ago
Peter Nelson 517dab35b1
Codechange: Use range-for to iterate base media files. (#12721) 4 months ago
Peter Nelson 3c42f701d7
Fix: Allow changing size of default OpenTTD font. (#12641)
* Fix: Allow changing size of default OpenTTD font.

Size configuration for default font was ignored as a different code path to load the font was followed.

Resolved by removing this additional path and conditionally selecting the default font.
4 months ago
Jonathan G Rennison effaf6acc4 Allow removing reservation boundary signal in realistic braking
All other operations were permitted so only disallowing removal
was not useful and could be trivially bypassed
4 months ago
Jonathan G Rennison 431a6a1262 Allow sorting by average order occupancy in shared order group mode
See: #698
4 months ago
Jonathan G Rennison d39bdd352b Merge PR #700 into jgrpp 4 months ago
Peter Nelson 2c70ccb137
Add: [NewGRF] Extended custom waypoint classes. (#12653)
This allows waypoints to be split into categories just like stations, instead of all being lumped together.

Station class labels with the first byte set to 0xFF will be treated in the same way as the 'WAYP' class.
4 months ago
pvillaverde dc465000f7 🌐 Update Galician Translations 2024-05-26 4 months ago
translators d11823df36 Update: Translations from eints
korean: 2 changes by telk5093
4 months ago
Koen Bussemaker 6efc1fa250 Codechange: Removed unused yapf PfNodeCachFlush function 4 months ago
translators c325a2ebd4 Update: Translations from eints
estonian: 3 changes by siimsoni
dutch: 2 changes by Afoklala
french: 2 changes by ben20471
portuguese: 2 changes by azulcosta
4 months ago
Peter Nelson 676d64037d
Fix d6ccfdb: GetCharPosition failed for RTL text. (#12710)
Changes in d6ccfdb assumed that character indexes only incremented, which is not true for RTL text.
4 months ago
translators d9cadb49b0 Update: Translations from eints
english (au): 2 changes by krysclarke
chinese (simplified): 7 changes by WenSimEHRP
korean: 4 changes by telk5093
russian: 2 changes by Ln-Wolf
finnish: 2 changes by hpiirai
portuguese (brazilian): 2 changes by pasantoro
4 months ago
Peter Nelson 5fefe0b61f
Fix: Reverse left/right keypress when editing RTL text. (#12711)
When editing RTL text, pressing left should increment instead of decrement the character position to move left, and vice versa.
4 months ago
Peter Nelson f87c6990b0
Fix: Memory leak in CoreTextFontCache. (#12662)
Temporary buffer for rendering glyphs was not freed after use. Instead let CGBitmapContextCreate() handle the buffer.

> data may be a pointer to pixels. If you pass NULL, the context will create its own buffer and free that buffer itself later. If you pass your own buffer, the context will not free it; it remains your buffer that you must free after you release the context, hopefully for the last time.
4 months ago
Jonathan G Rennison 1d70c781c6 Fix vehicle window showing profit last year in wallclock timekeeping mode 4 months ago
yeah-its-gloria 071796660d Fix: Implement support for secure state coding on macOS
Fixes a warning when running on macOS 14 and newer about not officially supporting secure state coding.
4 months ago
Jonathan G Rennison b2572c7ca8 Fix #12563: Race condition setting finish flag in WinHTTP 4 months ago
Qwest8K 6dfe5c4da9
Update: Russian translation (#695)
Russian localization update
4 months ago
translators 9f13d3ff2b Update: Translations from eints
chinese (simplified): 2 changes by WenSimEHRP
greek: 11 changes by gh658804
4 months ago
Tyler Trahan 8f6e21617f
Fix #12591: Give descriptive error when station construction fails due to wrong layout (#12678) 4 months ago
Rubidium b2f1a06def Change: support listing/updating authorized keys of companies by the admin in the console 4 months ago
Rubidium fea9ffa808 Codechange: also allow removing clients from the company allow lists 4 months ago
Peter Nelson 8a6745b26f
Codechange: Use PIP instead of spacer widgets for OSK spacing. (#12709)
This (slightly) simplifies the OSK widget layout.
4 months ago
Peter Nelson 766350bfd2
Fix: Hide empty house 'classes' in house picker. (#12694)
Picker class list should not list classes with no items. The house picker could break this 'rule' with NewGRFs loaded.
4 months ago
Peter Nelson 7e12b5ff0f
Fix: Crash if interface scale or font size changes with chat box present. (#12705)
Caused by the chat box being undrawn with the new dimensions, leading to out-of-bounding memory access.
4 months ago
Jonathan G Rennison 42fc32243d
Fix #12681: Abstract filetype not set for network client join savegames (#12701) 4 months ago
Peter Nelson 19ca4089a1
Codechange: Use std::filesystem::exists instead of access. (#12702) 4 months ago
translators 5bc3723bcc Update: Translations from eints
czech: 11 changes by vladoschreiner
4 months ago
Jonathan G Rennison a8d830aa3e Fix signal side when using both sides signal style with no-entry signals 4 months ago
Jonathan G Rennison a24d72f0d7 Fix flag values in CustomSignalSpriteContextFlags 4 months ago
Peter Nelson 5442b0dd2d
Fix: Make progress bars obey language direction. (#12704)
With RTL languages, progress bars should start from the right.
4 months ago
Jonathan G Rennison 8907b9aa31 Reduce diff with upstream for console command functionality 4 months ago
Peter Nelson 28e814f62a
Codechange: Use L"" instead of _T("") (#12703) 4 months ago
Jonathan G Rennison 88d7be1d99 Change FormatArrayAsHex to be uppercase by default
To match upstream
4 months ago
translators fb4a370d3f Update: Translations from eints
vietnamese: 13 changes by KhoiCanDev
chinese (simplified): 1 change by WenSimEHRP
finnish: 11 changes by hpiirai
french: 29 changes by ottdfevr
polish: 1 change by aefoes
4 months ago
Jonathan G Rennison 5e971bfc02 Fix abstract filetype not being set for network client join savegames 4 months ago
Jonathan G Rennison fc5b3b90b4 Remove incorrect assertion as temporary fix for #692
See: https://github.com/OpenTTD/OpenTTD/issues/12651
4 months ago
Rubidium 1d13ac7280 Fix #12655, 4f6d75f: inconsistent state in client list and potential crash after client leaves
(cherry picked from commit f939e81bf0)
4 months ago
Peter Nelson f62eb72fcb Fix #12685: nullptr dereference when checking for equal loaded/loading groups. (#12686)
Always treat empty groups as non-equal. Given that the case of both being empty is handled earlier, they cannot both be equal and empty.

Additionally if a loaded or loading set are all the same, only add one reference.

(cherry picked from commit 856ec901ca)
4 months ago
translators 46d7586ab1 Update: Translations from eints
estonian: 8 changes by siimsoni
chinese (simplified): 4 changes by ahyangyi
korean: 13 changes by telk5093
4 months ago
Jonathan G Rennison 3df3ed6690 Reduce frequency of brake overheating breakdowns
Decay overheat state more quickly
Avoid double-triggering overheating
Make overheating speed-dependent
4 months ago
Jonathan G Rennison 66d03530dc Adjust handling of vehicle subspeed with realistic braking
In particular when descending a steep slope with insufficient braking
4 months ago
Loïc Guilloux 29ce013eda
Codechange: Pass avail(able) as reference instead of pointer since they are never nullptr (#12696) 4 months ago
Jonathan G Rennison 6d1f3b673e Fix non-percentage servicing interval when using wallclock mode 4 months ago
Peter Nelson ba47d1ca2b
Fix: Allow resolving house parent scope (town) of unbuilt houses. (#12695)
Return unavailable variable result, instead of nullptr dereference.
4 months ago
Jonathan G Rennison 89902c8ab1 Fix advisory max speed being higher than strict max for reservation end
In GetCurrentMaxSpeedInfoInternal
4 months ago
Peter Nelson 3f5a354f37
Codechange: Use emplace with ICURun and UniscribeRun. (#12693) 4 months ago
Peter Nelson 856ec901ca
Fix #12685: nullptr dereference when checking for equal loaded/loading groups. (#12686)
Always treat empty groups as non-equal. Given that the case of both being empty is handled earlier, they cannot both be equal and empty.

Additionally if a loaded or loading set are all the same, only add one reference.
4 months ago
translators 7fd2487c46 Update: Translations from eints
swedish: 6 changes by joeax910
chinese (simplified): 2 changes by WenSimEHRP
dutch: 27 changes by Afoklala
4 months ago
Peter Nelson 8d26d032e1
Fix #12497: [NewGRF] Increase vehicle motion counter for all parts. (#12561)
NewGRFs relied on the incorrectly motion counter that was 'fixed' in #12229, so always update v->motion_counter for all vehicle parts.
4 months ago
Peter Nelson c85481564f
Codechange: Use reusable temporary buffer in Win32FontCache. (#12666)
This avoids allocating and deleting a temporary buffer for every glyph that is rendered into a sprite.
4 months ago
Peter Nelson 4940b6ff0b
Codefix: Compile warning with newer C++ compiler on MinGW. (#12689)
> template-id not allowed for constructor in C++20
4 months ago
translators 26113e3622 Update: Translations from eints
english (au): 11 changes by krysclarke
swedish: 7 changes by joeax910
english (us): 11 changes by 2TallTyler
chinese (simplified): 11 changes by WenSimEHRP
russian: 11 changes by Ln-Wolf
catalan: 11 changes by J0anJosep
portuguese: 13 changes by azulcosta
portuguese (brazilian): 11 changes by pasantoro
4 months ago
Peter Nelson ca52da6c95
Fix: Unable to choose a font containing hyphen. (#12684)
FcNameParse may require some characters be escaped. Instead, pass name as FC_FAMILY.
4 months ago
Peter Nelson d1b7619822
Change: Ignore min/max years for manual house placer. (#12687) 4 months ago
translators 56ea002283 Update: Translations from eints
catalan: 16 changes by J0anJosep
latvian: 2 changes by lexuslatvia
4 months ago
Peter Nelson 980dcaac6e
Cleanup: Remove GetFontTable from FontCache. (#12677)
This interface is no longer used, so does not need to be implemented.

Removes manual memory management with malloc/free.
4 months ago
Peter Nelson f901722066 Codechange: Rename BuildTownHouse to TryBuildTownHouse. 4 months ago
Peter Nelson ed67aedabf Feature: Allow manually placing town buildings in scenario editor.
House picker is accessed from the Landscaping toolbar as there is no town toolbar.

Once placed these houses behave like any other and can be removed by players and towns.

Uses the unified picker system, so also supports used/saved favourites. As town building don't have class labels, town zones are use to imitate them.
4 months ago
Peter Nelson 874cfe000b Codechange: Set underlying type for HouseSpec enums. 4 months ago
Peter Nelson b731ab0632 Change: Allow sprite resolver to evaluate non-existent houses.
This could previous be done but only with a town and tile in mind, but for drawing in the UI, neither of those exist yet.
4 months ago
Peter Nelson d99c1337a2 Add: Command to build an individual house on a specific tile. 4 months ago
Tyler Trahan bb77d16e40
Add: Shade button to waypoint picker (#12682) 4 months ago
Muxy 486af1a6fc Fix: [Admin] #12411 Send Network Welcome Packet to admin port after game creation completed
WelcomeAll moved into NetworkOnGameStart

Signed-off-by: Muxy <muxy@goulp.net>
4 months ago
Peter Nelson 460fab920c
Fix #12418, 338def1b06: Filename extension taken from wrong string. (#12680) 4 months ago
Jonathan G Rennison 242e87652b Fix setting display for industry cargo scaling 4 months ago
Jonathan G Rennison b81da24a64 Fix setting default value for industry cargo scaling mode in old saves 4 months ago
Rubidium 00c4b232b3 Fix #12550: files were not saved in the right location when binary and configuration are in the same folder 4 months ago
translators 3f06aa441b Update: Translations from eints
english (us): 17 changes by 2TallTyler
greek: 147 changes by KyriakosMich
4 months ago
Tyler Trahan 9f63b9f65d
Fix #12594: Give descriptive error when company takeover fails due to vehicle limit (#12676) 4 months ago
translators 870149406a Update: Translations from eints
chinese (simplified): 23 changes by WenSimEHRP
russian: 17 changes by Ln-Wolf
portuguese (brazilian): 8 changes by pasantoro
4 months ago
Peter Nelson 18e56df5e1
Fix #12674: Non-NewGRF Build Station widgets may not fill window properly. (#12675)
Allow labels in Build Station window to fill width as needed.
4 months ago
Jonathan G Rennison bdd1d36bd9 Fix road vehicle restart loading at same station when using implicit orders 4 months ago
Peter Nelson f2f7573c3f
Fix #12668: Crash opening picker window with filter when no results available. (#12669)
When first opening the picker window, we attempt to find a valid class and type to select. If the picker window was closed with filters enabled, there may not be anything list that is usable.

Resolve this by using callbacks to find the first usable type when no types are listed.
4 months ago
Rubidium 77c188e6da Codechange: use std::vector instead of malloced array 4 months ago
Rubidium 6cea49c117 Codechange: replace uint with size_t in binary heap 4 months ago
Rubidium 8349203038 Cleanup: remove unused Aystar variables 4 months ago
Peter Nelson 77a7113ba6
Cleanup: Remove unused parameters from FreeTypeFontCache::SetFontSize. (#12663) 4 months ago
Rubidium f939e81bf0 Fix #12655, 4f6d75f: inconsistent state in client list and potential crash after client leaves 4 months ago
translators 95a89e43b2 Update: Translations from eints
english (au): 16 changes by krysclarke
chinese (simplified): 16 changes by XiaoJi-Game
korean: 19 changes by telk5093
russian: 1 change by Ln-Wolf
finnish: 16 changes by hpiirai
lithuanian: 1 change by khamper
portuguese: 17 changes by azulcosta
portuguese (brazilian): 16 changes by pasantoro
4 months ago
Peter Nelson 34da94ffc8
Fix: Use widget resize step instead of window resize step. (#12659)
Build Picker class list filter could be drawn incorrectly depending on how the window can be resized.
4 months ago
Peter Nelson d78f39a9df
Cleanup: Remove GetUnitsPerEM and units_per_em. (#12656)
GetUnitsPerEM is never called.
4 months ago
TELK b1faf3d39f Update: Korean translation 4 months ago
translators 721cd2b8ad Update: Translations from eints
ukrainian: 1 change by Quantom2
dutch: 5 changes by Afoklala
lithuanian: 1 change by khamper
4 months ago
Peter Nelson b30fe0d7da Feature: Ctrl-click to toggle favourites in build-pickers.
This allows ctrl-click on a type in a build-picker window to remember it
as a favourite. An new filter button to show only favourites makes it
simpler to use these types.

Favourite types are saved locally in favs.cfg, so are remembered between
games.
4 months ago
Peter Nelson fde3b35a24 Feature: New filter to show only used types in build-pickers.
This filters the build-picker type lists to only show types that have
already been placed in the current game, making it simpler to get to
build matching features.
4 months ago
Peter Nelson b76517816e Feature: Add "All" filter to build-picker show types from all classes.
Toggling the "All" filter causes the class selection to be ignored, so
that items from all classes can be displayed together. The class text
filter is still applied.

This makes it easier to search amongst types for a feature.
4 months ago
Peter Nelson cdc356e7bf Change: Unify station/waypoint/roadstop/object build-picker window code.
These windows now share a common code base for choosing and display class and types.

An additional text filter is added to search types by name instead of just classes.
4 months ago
Peter Nelson d2c8b476b5 Codechange: Add functions to test if a station/roadstop class is a waypoint.
This is now checked by class label instead of by index.
4 months ago
Peter Nelson 9f8c9724be Codechange: Add station/roadstop class labels for DFLT/WAYP.
This avoids repeating the same multichar literal value.
4 months ago
Peter Nelson d5671030b1 Codechange: Add NewGRFSpecsBase class to hold class/index information.
Standardises how the class index is stored in the spec, instead of relying ot the Spec structs having the same members.

This allows retrieving class_index and index without searching or using pointer arithmetic.

'cls_id' is renamed to 'class_index' to make it clearer that it is an index rather than the multichar label of the class.
4 months ago
Peter Nelson 733284cc16 Codechange: Return std::vector from GetMusicCatEntryData.
Return std::vector instead of pointer to array with manual memory management.
4 months ago
Peter Nelson 31c306c6cd Codechange: Return std::string from GetMusicCatEntryName.
Return std::string instead of pointer to C-string with manual memory management.
4 months ago
frosch dc22edc556 Doc: [Script] Extend API documentation on calendar- vs economy-time 4 months ago
frosch 04cc0c8125 Codechange: [Script] Document relation between ScriptErrorType and ErrorMessages enums 4 months ago
frosch 40e6230900 Codechange: Add main page to script API documentation 4 months ago
frosch dfa2622153 Codechange: Unify naming of squirrel built-in types in Script API docs 4 months ago
frosch e436e2ef40 Codefix: broken links and syntax issues in script API documentation 4 months ago
frosch 64e1f1d4d9 Codefix: Script API documentation about IDs was incomplete 4 months ago
frosch 4bf2dc3148 Codefix: Script API did not link simple types correctly 4 months ago
frosch c1375cecf8 Codefix: [Script] script_types was excluded from API documentation 4 months ago
frosch ffe76a0133 Update: Doxyfiles to doxygen 1.9.4 4 months ago
merni-ns c3ee5e58a3 Cleanup: Move remaining NPF files into pathfinder directory 4 months ago
merni-ns 798ec4184b Cleanup: Remove unused function InvalidateShipPathCache
This was only used in the callback when changing the ship pathfinder setting.
4 months ago
merni-ns 55a7c59d13 Remove: NPF and pathfinder change settings 4 months ago
translators a5c2543efc Update: Translations from eints
chinese (simplified): 7 changes by WenSimEHRP, 4 changes by ahyangyi
5 months ago
Rubidium cef9417c9f Fix: always allow setting company settings, company/president name/face
There is a nice feature that synchronises the client settings upon setting up the company. Before
this, those commands would not be executed when no-actions-while-paused is set. This means that,
silently and depending on the server configuration, your wished for configuration might not be
there.

Similarly there is the president's face that's being set while creating a new company and setting
of the president/company name upon creation, when no-actions-while-paused is set.

So, just allow these operations also while paused to get a uniform experience when joining. To
keep the UI somewhat consistent, apply this "freedom" also to the other bits set from the company
UI; specifically company name and company colour.
5 months ago
Rubidium a313676189 Doc: reason for using ::SendNet over ::Post in few cases 5 months ago
Rubidium ed888c617b Codechange: just use ::Post over ::SendNet for creating new companies 5 months ago
Koen Bussemaker 59ac27f385 Fix #12643: _is_water_region_valid is not cleared/reset in AllocateWaterRegions 5 months ago
TELK d3fc9997d1
Update: Korean translation up to 0.59.0 (#689)
* Update: Korean translation up to 0.59.0

* Update: Korean translation up to fc4ea241

* Update: Korean translation / missing ones
5 months ago
Peter Nelson ec61951512
Cleanup: Remove Windows 9x font locale workaround. (#12644) 5 months ago
Peter Nelson 5b35fbd6f5
Change: Use button aspect ratio for buttons that show vehicle icons. (#12636) 5 months ago
translators 132e226b27 Update: Translations from eints
greek: 169 changes by KyriakosMich
lithuanian: 21 changes by khamper
polish: 1 change by pAter-exe
5 months ago
ladysadie 00cfd572ff
Cleanup: Remove unneeded CheckMissingGlyphs call (#12640) 5 months ago
Peter Nelson d7f029344f Codechange: Don't delete news items or NewGRF window when EffectVehicle is deleted. (#12334)
EffectVehicles never create news and can't be debugged, so searching for news items and windows to delete just wastes time.

(cherry picked from commit 737e3feaf0)
5 months ago
translators cb3f99859c Update: Translations from eints
english (au): 1 change by krysclarke
estonian: 25 changes by siimsoni
korean: 3 changes by telk5093
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
catalan: 5 changes by J0anJosep
latvian: 30 changes by lexuslatvia
lithuanian: 140 changes by khamper
portuguese: 1 change by azulcosta
portuguese (brazilian): 3 changes by pasantoro
5 months ago
Peter Nelson b74a7e749b
Fix: Console command scrolling did not take account of padding and cursor width. (#12642) 5 months ago
Peter Nelson 731d46beb5
Change: Don't include midi file processing in dedicated server build. (#12632) 5 months ago
Peter Nelson 9008d793ab
Change: Use per-company group numbers. (#12297)
This is used by the default group name, replacing the use of group index.
5 months ago
Jonathan G Rennison fc4ea241b0 Merge branch 'master' into jgrpp 5 months ago
Jonathan G Rennison 6d4f616706 Fix crash when sorting by capacity in autoreplace window
Move capacity cache into GUIList sort parameter

See: #690
5 months ago
Jonathan G Rennison 5e24882c18 Use template specialisation for GUIList parameter reference/init behaviour 5 months ago
Jonathan G Rennison 8710e9b8c8 Fix #12608: SDL keycode to vkey mapping 5 months ago
Jonathan G Rennison 18a42664fc Merge branch 'master' into jgrpp
Remove 'byte' typedef
5 months ago
translators ab7e2a1883 Update: Translations from eints
english (au): 2 changes by krysclarke
english (us): 2 changes by 2TallTyler
greek: 4 changes by gh658804
russian: 2 changes by Ln-Wolf
finnish: 4 changes by hpiirai
danish: 2 changes by bscargo
lithuanian: 170 changes by khamper
french: 1 change by ben20471
portuguese: 2 changes by azulcosta
portuguese (brazilian): 2 changes by pasantoro
polish: 2 changes by pAter-exe
5 months ago
Rubidium 1250ce8fdc Codechange: support storing std::string vectors/deques in the savegame 5 months ago
Rubidium 1a3cbaec56 Cleanup: remove warning about server administrators being able to read passwords 5 months ago
Rubidium 849d1fa1b3 Cleanup: remove UI for asking user for company password 5 months ago
Rubidium 457d51fc49 Cleanup: remove company password hashing and anything related to it 5 months ago
Rubidium a9318cf653 Cleanup: remove UI for changing the password 5 months ago
Rubidium 9dc1fdc385 Cleanup: remove client side password checks when moving to a different company 5 months ago
Rubidium 16639939e9 Cleanup: remove command line option for company password 5 months ago
Rubidium ca4bef1504 Cleanup: remove company password related network packets 5 months ago
Rubidium 71fc907584 Change: remove company passwords over client allow lists 5 months ago
Rubidium a002803d1c Remove: autoclean_unprotected settings; all companies will be protected 5 months ago
Rubidium 4f3db8eeaf Feature: authorize specific clients to join network company without password 5 months ago
Rubidium 66354ab9eb Codechange: introduce allow list infrastructure for companies 5 months ago
Jonathan G Rennison f1c0f864f5 Add setting to shorten vehicle view status text 5 months ago
Jonathan G Rennison 0a0b42a931 Bump OpenTTD content version to 14.1 5 months ago
Jonathan G Rennison 3e57319c0b Fix SDL keycode to vkey mapping 5 months ago
translators 4e9a280ef8 Update: Translations from eints
swedish: 2 changes by sereneavatar
norwegian (bokmal): 2 changes by eriksorngard
welsh: 19 changes by Ansbaradigeidfran
english (us): 2 changes by 2TallTyler
czech: 1 change by JsSusenka
lithuanian: 97 changes by khamper
french: 2 changes by Lishouuu
portuguese (brazilian): 1 change by pasantoro
polish: 2 changes by pAter-exe
5 months ago
Rubidium b9c894b717 Fix: for GUI network servers, name the first company the same as any other company 5 months ago
Rubidium 455e202e03 Fix: server's client is shown incorrectly in some cases 5 months ago
Peter Nelson 6de4fa921c Change: Use standard padding for company password window.
Also use now-established OnResize pattern for setting height of password warning widget.

(cherry picked from commit 0090431e99b8301c9e3ee14fb3435075708294d5)
5 months ago
Peter Nelson 4740eeaa43
Add: 'Get Content' buttons next to base set dropdowns in Game Options. (#12627)
This allows base set content to be downloaded more easily, filtered by type and next to where it is set up.
5 months ago
Koen Bussemaker d2f98440bb Codechange: Make assert in follow_track easier to understand and debug 5 months ago
Peter Nelson 84ebae0bf5
Codechange: Tweak layout of network client list. (#12624)
Use PIP spacing instead of spacers and more used of standard WidgetDimensions.
5 months ago
Jonathan G Rennison f993e30850 Take cargo refit into account in build vehicle window capacity sort modes 5 months ago
Jonathan G Rennison 1e5c96ef87 De-duplicate filling TestedEngineDetails in build vehicle windows 5 months ago
Peter Nelson cf94bd321d
Codechange: Remove redundant SetMinimalSize of preview buttons. (#12622)
These widgets are also sized in UpdateWidgetSize where the current bevel width is accounted for as well.
5 months ago
Peter Nelson 72b2840a97
Codechange: Use PIP spacing instead of spacers in tree picker window. (#12623) 5 months ago
Jonathan G Rennison fe374a1db0 Allow sorting by cargo capacity/running cost in dual pane train purchase window 5 months ago
translators 99f497cb08 Update: Translations from eints
english (au): 2 changes by krysclarke
korean: 2 changes by telk5093
russian: 2 changes by Ln-Wolf
finnish: 2 changes by hpiirai
danish: 2 changes by bscargo
lithuanian: 4 changes by dziugas1959
portuguese: 2 changes by azulcosta
portuguese (brazilian): 4 changes by pasantoro
5 months ago
Rubidium 9fe9e4d398 Codechange: use vector instead of manual memory management for decompressing text files 5 months ago
Jonathan G Rennison 126173a839 Fix text filter in dual-pane purchase window with GRF custom names 5 months ago
Peter Nelson d074ab909c
Codechange: Replace Array/FixedSizeArray with std::deque. (#12409)
Array/FixedSizeArray is actually a resizeable container that allocates space in chunks and allows resizing without invalidating pointers.

This is also a behaviour of std::deque, so use that instead.
5 months ago
Peter Nelson f629d3c921
Codechange: Use vectors instead of CallocT/free for cache checks. (#12619)
Vectors are reused for each vehicle chain to save on reallocations.
5 months ago
Peter Nelson 115ac2629b
Cleanup: Remove TileMatrix that hasn't been used for 4+ years. (#12621)
This 'nice' structure was left around from #8258 just in case it might be used again.

Spoiler alert: it hasn't.

This removes manual memory management. And otherwise unused and untested code.
5 months ago
translators 60cf37e0d1 Update: Translations from eints 5 months ago
Jonathan G Rennison e89a40994a Reduce diff with upstream for fileio.cpp 5 months ago
Peter Nelson a2bd2efec1 Codechange: Remove support for links in tar files. (#12571)
This was a feature to support the original 32bpp sprite system and is no longer relevant.

(cherry picked from commit ef55cc7979)

# Conflicts:
#	src/fileio.cpp
5 months ago
Loïc Guilloux 716ba5fd2a Fix #12584: Improved error handling during tar scan (#12586)
(cherry picked from commit 99b74c1064)

# Conflicts:
#	src/fileio.cpp
5 months ago
Peter Nelson 8769318653 Codechange: Ensure SDLK mappings stay in the expected order. (#12608)
Add a constexpr constructor that ensures at compile-time that the source SDLK range matches the target range.

(cherry picked from commit 90029beb49)

# Conflicts:
#	src/video/sdl2_v.cpp
#	src/video/sdl_v.cpp
5 months ago
Fen fd183914c8 Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable (#12596)
* Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable

* Cleanup: List sdl2 numpad mappings individually

(cherry picked from commit 2559bdfa6f)
5 months ago
Peter Nelson 9a7c30a109 Codechange: Let ClickSliderWidget handle rounding to nearest mark. 5 months ago
Peter Nelson 9d2efd4c96 Codechange: Use callback function to set labels of slider widget marks.
Slider widgets can only use a predefined list of values and strings to draw labels. This makes it difficult to vary the display by context.

Instead of providing a predefined list as a std::map, use a callback function instead. This function can decide what text to display, and can call SetDParam to dynamically set up strings.
5 months ago
Rubidium 8b6661d486 Codefix 90029be: build failure for SDL 1.2 5 months ago
translators e0048d798f Update: Translations from eints
hungarian: 5 changes by egri-nagy
5 months ago
Peter Nelson 90029beb49
Codechange: Ensure SDLK mappings stay in the expected order. (#12608)
Add a constexpr constructor that ensures at compile-time that the source SDLK range matches the target range.
5 months ago
Koen Bussemaker ef99aa81a3 Codechange: Store validity of water regions in separate vector 5 months ago
Peter Nelson cf96d49ced
Codechange: Use vector for airport tile layouts. (#12607)
Simplify AirportSpec data by storing layout information together in a vector, instead of separate arrays.

This removes manual memory management and separate count members.

The default layouts will be copied instead of always referring to the originals.
5 months ago
translators 65c9df49d9 Update: Translations from eints
chinese (simplified): 8 changes by XiaoJi-Game
catalan: 3 changes by J0anJosep
5 months ago
Fen 2559bdfa6f
Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable (#12596)
* Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable

* Cleanup: List sdl2 numpad mappings individually
5 months ago
Jonathan G Rennison 9647fe1d05 Change: [Linkgraph] Improve distance scaling algorithm in demand scaler
Improve scaling at values other than 0% and 100%
Fix erratic scaling and increase effect size at large setting values
5 months ago
Peter Nelson f146680121
Codechange: Use vector for industry random sounds. (#12606)
Use a vector to store the list of random sounds played for an industry.

The removes manual memory allocation, flags to control memory management, a separate count member, and a try/catch block.
5 months ago
Peter Nelson 7147fe9e7a
Codechange: Use range-for when loading NewGRF deterministic sprite groups. (#12605) 5 months ago
Peter Nelson 532ce1a907
Codechange: Use Recv/Send_bytes for md5sum. (#12602)
Use existing functions to handle serialisation of arrays instead of indexed for-loop.
5 months ago
Peter Nelson 1424a184d8
Codechange: Use vector/span when loading wagon overrides. (#12604)
Replaces manual memory allocation and passing pointer with size.
5 months ago
translators 96d82b4363 Update: Translations from eints
chinese (simplified): 1 change by WenSimEHRP
greek: 52 changes by KyriakosMich
german: 3 changes by Wuzzy2
basque: 36 changes by Porrumentzio
danish: 3 changes by bscargo
5 months ago
Calvin Sykes 69cb68a3e2 Override remain at station behaviour for road vehicles with explicit stop direction set
(cherry picked from commit 8f8d635baf3dc1506de206a3378498bedfd020bf)

See: #686
5 months ago
Jonathan G Rennison 247b40c95b Adjust setting texts for show running costs per year setting 5 months ago
Jonathan G Rennison d90c540f9e Enable economy day length scaling in wallclock timekeeping mode 5 months ago
translators 4df44fea38 Update: Translations from eints
swedish: 3 changes by joeax910
galician: 63 changes by pvillaverde
5 months ago
Jonathan G Rennison 9a07f14f56 Show running costs in calendar years by default 5 months ago
Jonathan G Rennison c5cd598217 Debug: Log number of GRFs at level sl=2 when loading a game
Add helper to get the number of non-static GRFs in a GRF config
5 months ago
Jonathan G Rennison adc7840f01 Scheduled dispatch: Caveat text for number of vehicles required 5 months ago
Jonathan G Rennison a14f850f33 Debug: Show unreachable error groups in sprite dump when show details enabled 5 months ago
Peter Nelson 96ddabb30c Codechange: Remove write-only spec_id from RoadStopSpec. (#12582)
Comment is incorrect about its value too.

(cherry picked from commit 72c55128d2)
5 months ago
Peter Nelson cc6e4768a9
Fix: Out-of-order window set up due to deferred window resize. (#12592)
Deferred window resize was being applied to the initial window resize event, resulting in some window state (e.g. scroll bar capacity) not being initialised when expected.
5 months ago
translators b852a3f408 Update: Translations from eints
english (us): 3 changes by 2TallTyler
korean: 3 changes by telk5093
hungarian: 2 changes by meskobalazs
5 months ago
rubidium42 fd4cf699e5
Codefix 37a03b5: the return value of maxdim should always be assigned (#12590) 5 months ago
Rubidium 98d37338df Codechange: use ranged for loop instead of one with lengthof 5 months ago
Rubidium 24b6ec80a9 Codechange: use ranged for loop and vector to determine the disaster to deploy 5 months ago
Rubidium 87dbd4a833 Codechange: use ranged for loop to determine widest title 5 months ago
Rubidium d183d8e587 Codechange: remove INVALID_STRING_ID now drop down uses spans 5 months ago
Rubidium 37a03b513f Codechange: refactor string list dimension finding into a separate function 5 months ago
Rubidium 546a996d95 Codechange: pass options to ShowDropDownMenu using a span 5 months ago
Rubidium ad50c4f298 Codechange: inline sorter name definitions and use proper static accessor instead of (implying) this-> 5 months ago
Peter Nelson ef55cc7979
Codechange: Remove support for links in tar files. (#12571)
This was a feature to support the original 32bpp sprite system and is no longer relevant.
5 months ago
Loïc Guilloux 99b74c1064
Fix #12584: Improved error handling during tar scan (#12586) 5 months ago
Rubidium 826deaee57 Codechange: refactor CalcHeightdiff to remove some magic numbers 5 months ago
Rubidium 97a34bf06e Codechange: use C++ containers for the colour schemes 5 months ago
translators ee9895a970 Update: Translations from eints
norwegian (bokmal): 3 changes by eriksorngard
french: 3 changes by ottdfevr
portuguese: 3 changes by azulcosta
5 months ago
Peter Nelson 440a633fcc Codechange: Remove shrink_to_fit for more lists.
A comment about "will actually do nothing" is out of date as that is not the case with std::vector.

These lists are always short lived (either within a command handler or in a window) so don't shrink_to_fit.
5 months ago
Peter Nelson 33aedc43a5 Codechange: Shrink GUIList vectors less often, reserve before use.
After sorting and filter lists for GUI, we often shirnk them to reduce size. However this has very little benefit:

1) The memory has already been allocated, so it doesn't prevent that memory being required.
2) It causes a new allocation and copy when the vector is shrunk, actually using more memory.
3) The list is in window state, so the lifetime is only while the window is open.
4) When a filter is clearer, the original size will be needed again, which will cause another allocation.

In fact it is beneficial to reserve to the known maximum in most cases, so do that instead.
5 months ago
Jonathan G Rennison 991b7a958e Do not reset lateness on auto-timetable congestion detection, when using scheduled dispatch 5 months ago
translators 8308998388 Update: Translations from eints
english (au): 3 changes by krysclarke
russian: 3 changes by Ln-Wolf
finnish: 6 changes by hpiirai
dutch: 6 changes by Afoklala
portuguese (brazilian): 4 changes by pasantoro
polish: 3 changes by pAter-exe
5 months ago
Peter Nelson bf8de188ec
Codechange: Use member initialization of GRFFilePropsBase. (#12581)
Don't blame compilers for our sloppy initialisation.

Removes memset, and lengthof.
5 months ago
Peter Nelson 72c55128d2
Codechange: Remove write-only spec_id from RoadStopSpec. (#12582)
Comment is incorrect about its value too.
5 months ago
Peter Nelson a6d401debf
Fix: Properly test for presence of waypoint in NewGRF resolver. (#12579)
Test whether the BaseStation itself a Station or Waypoint, instead of by the station class ID assigned to it.
5 months ago
translators a60a81f34e Update: Translations from eints
swedish: 7 changes by joeax910
vietnamese: 15 changes by anmatngu
greek: 31 changes by gh658804, 2 changes by KyriakosMich
hungarian: 2 changes by egri-nagy
portuguese (brazilian): 2 changes by pasantoro
5 months ago
Rubidium 0fdabca605 Codechange: use std::span instead of custom span in TGP 5 months ago
Peter Nelson f44d8fa2e4
Codechange: Remove CDECL from filter functions. (#12578)
These functions are not passed to qsort()...
5 months ago
Peter Nelson 0075a95278
Codefix: Make three _filter_funcs definitions distinct. (#12573)
Rename the GUIList function lists defined as the same symbol.
5 months ago
Peter Nelson 5bc9854be2
Codechange: Make sort list function lists safer. (#12574)
GUIList has a pointer only to the start of each sort/filter func list, which has the potential for UB as it is unable to validate that the selected sort or filter type is in range.

Use a std::span instead and check if the selected type is in range before using it.
5 months ago
Jonathan G Rennison 9b747a173d Fix #12509: Maintain timer sort invariants when changing period 5 months ago
Jonathan G Rennison 11ec156b64 Codechange: Add a priority field to TimerGameTick::TPeriod
Use this as the primary sort key for TimerGameTick::TPeriod,
to avoid container sort order changes on timer period saveload.
See: #12509
5 months ago
André Cheng 57f5d27427 Doc: Fix documentation of GetDefaultValueCallback 5 months ago
André Cheng ceb0053dd9 Codechange: Correct return type of GetDefaultValueCallback 5 months ago
André Cheng 339b0ea0ff Change: Show correct default value and unit for vehicle service interval setting 5 months ago
André Cheng fd80a1ec66 Fix #11345: Use correct default button value for vehicle service interval setting 5 months ago
André Cheng a4071b78d7 Codechange: Add callback to IntSettingDesc to support more default values 5 months ago
translators e8d25d68b9 Update: Translations from eints
russian: 2 changes by George-VB
5 months ago
Peter Nelson e8249e9075
Codechange: Pass buffers for TarFile's ExtractString as span. (#12567)
ExtractString does not need to find a string terminator as StrMakeValid already does this, so simply pass the full bounds of the buffer.

Removes lengthof, array indices, and needs only the buffer as a parameter.
5 months ago
Peter Nelson 5159aa81d4
Codechange: Use iterators when enabling industries. (#12569)
Removes lengthof and array indices.
5 months ago
Peter Nelson 26bb87ebf1
Codechange: Replace SaveLoad var length arrays with switch block and sizeof. (#12570)
SlCalcConvMemLen(), SlCalcConfFileLen() and CalcOldVarLen() follow a pattern of looking up part of a value in an array.

These function returns the size of bytes of a variable type, but is not very clear. Replace with a switch block instead.

Removes lengthof, array indices, and magic numbers.
5 months ago
Peter Nelson 1dc94d0670
Codechange: Construct string_view with first+last. (#12568)
Avoids needing to calculate size when we already have last.
5 months ago
Peter Nelson 6a3f50aa72
Codechange: Replace separate EffectVehicle arrays. (#12565)
Combine 3 separate arrays into a single struct. This keeps related data together, and avoids needing to check that each array is same length.

Use of constexpr construct ensures data in the array is not default-initialised.

Removes lengthof.
5 months ago
Peter Nelson e20f48799e
Codechange: Make StringToContentType() clearer. (#12566)
Decouples string to ContentType mapping from position within enum.

Slightly less efficient, but removes lengthof, array indices, and casting.
5 months ago
Peter Nelson 5e689ce25e
Codechange: Store cursor sprites in vector. (#12564)
Combine two separate fixed length arrays to allow simpler iteration.

No need to check that arrays are all the same length.
No need to separately store the number of sprites to draw.
Removes the upper limit of the number of sprites that can be drawn.

Removes lengthof and array indices.
5 months ago
TELK b39bd33c1c
Update: Korean translation up to 980de73 (#688)
* Update: ko-KR / Colouring some setting

* Update: Korean translation - time

* Update: Korean translation up to 980de735
5 months ago
Jonathan G Rennison 29871e412c Fix 69e7c1697: Add missing include for MSVC 5 months ago
translators 9121770582 Update: Translations from eints
korean: 3 changes by telk5093
catalan: 3 changes by J0anJosep
french: 7 changes by ottdfevr
polish: 7 changes by pAter-exe
5 months ago
Jonathan G Rennison ce40e85ccc Fix ROADSTOP_DRAW_MODE_WAYP_GROUND when used with RSF_DRAW_MODE_REGISTER 5 months ago
Jonathan G Rennison 07cfa5f602 Fix documentation comment for RSF_DRAW_MODE_REGISTER 5 months ago
Jonathan G Rennison 980de7353d TBTR: Fix replacement servicing condition when using infinite money 5 months ago
Peter Nelson ac6a945e26
Revert 2408a68910: Remove work around for an MSVC bug from 17 years ago. (#12557) 5 months ago
Koen Bussemaker bef11941c6 Change: Allow rail and road depot overbuilding in current orientation in order to connect to rail or road 5 months ago
translators 95de90dd4e Update: Translations from eints
norwegian (bokmal): 7 changes by eriksorngard
danish: 7 changes by bscargo
portuguese (brazilian): 4 changes by pasantoro
5 months ago
Peter Nelson 3814adaba8
Codechange: Simplify GetScrolledItemFromWidget() (#12556)
Return `auto`, which allows working with const containers, and use std::next instead of std::advance.
5 months ago
Jonathan G Rennison 69e7c1697e Win32: Increase buffer size and count in wave out sound driver
Ensure that wave structs are zero-inited and buffers are freed
5 months ago
translators c82a2575d7 Update: Translations from eints
english (au): 3 changes by krysclarke
english (us): 3 changes by 2TallTyler
greek: 3 changes by gh658804
russian: 3 changes by Ln-Wolf
finnish: 5 changes by hpiirai
turkish: 7 changes by BeratSJ
portuguese: 3 changes by azulcosta
portuguese (brazilian): 3 changes by pasantoro
5 months ago
Rubidium ded4d63db2 Codechange: simplify access to the current screenshot format 5 months ago
Jonathan G Rennison 3136f08b86 Debug: Fix display of engine cargo age period and reliability decay speed 5 months ago
Peter Nelson d465257dd0
Fix 952d111: Houses and industry tiles could accept incorrect cargo. (#12547)
Default cargo label was not cleared (set to CT_INVALID) when using older 3-slot acceptance properties for house and industry tiles.

Missed in #12053 and #12062.
5 months ago
Peter Nelson 3b01d31280
Fix 8746be8: Reinstate current order test when removing road stop. (#12552)
#12144 replaced pool iteration with FindVehiclesWithOrder, however the test for current_order being OT_GOTO_STATION was erroneously removed.
5 months ago
translators c073165e34 Update: Translations from eints
greek: 5 changes by gh658804
finnish: 2 changes by hpiirai
catalan: 4 changes by J0anJosep
5 months ago
Jonathan G Rennison 33baceaef7 Maintain timer sort invariants when changing period
See: https://github.com/OpenTTD/OpenTTD/issues/12509
5 months ago
Jonathan G Rennison 674642f9cc Add a priority field to TimerGameTick::TPeriod
Use this as the primary sort key for TimerGameTick::TPeriod,
to avoid container sort order changes on timer period saveload.
5 months ago
Jonathan G Rennison d5b8f51bf9 Rename variable to fix Windows header name collision 5 months ago
Rubidium aa895535e6 Fix 5008706: improved scenario editor tooltips in map generation stages are out of place 5 months ago
Jonathan G Rennison 71227f61d8 Use MoveFileExW to implement FioRenameFile on Windows
This is to allow renaming over an existing file
5 months ago
Peter Nelson 959ced71bb
Codechange: Add constants for original input/output cargo counts. (#12548)
This replaces some magic 3s and 2s.
5 months ago
Jonathan G Rennison 083d91a582 Remove use of shell API function for rename 5 months ago
Peter Nelson 653e217bb1 Fix: Signature validation did not close its file. (#12479)
(cherry picked from commit 3316b27496)
5 months ago
Peter Nelson 8fdc91bd9f Fix a29766d: Wrong scrolling dropdown list position with RTL. (#12412)
(cherry picked from commit 9750826590)
5 months ago
Loïc Guilloux 54093fb8b2 Fix: [Win32] Force font mapper to only use TrueType fonts (#12406)
(cherry picked from commit 11aa3694fa)
5 months ago
Jonathan G Rennison 98dc6c3c81 Fix NewGRF byte order when using -q 5 months ago
Peter Nelson ae16df2d61 Fix #12497: Add workaround for motion_counter being implemented correctly.
#12229 stopped updating motion_counter for non-engine parts of trains, and in doing so accidentally followed the spec for NewGRF var 46, which breaks NewGRFs that used to... accidentally work.

Make var 46 return motion_counter of the first engine, regardless of self or parent scope. This means var 46 is always in sync with the head engine, and avoids further changes to when motion_counter is updated.

(cherry picked from commit 9539b02455f672e11f3ac32302a00cffa5507770)
5 months ago
Peter Nelson b4e00fa738
Codechange: Replace C-casts in pool functions. (#12541) 5 months ago
Loïc Guilloux c5ef47ee09
Codechange: [Script] Use std::unique_ptr for Company::ai_instance (#12544) 5 months ago
Rubidium 1dfd0c19f4 Fix: allow only 255 league tables, as 255 is the invalid id sentinel 5 months ago
Rubidium c377c4740d Codechange: replace cpp_lengthof with safe alternatives 5 months ago
Peter Nelson a1a01e21cf
Change: Use std::make_unique instead of passing new() (#12539) 5 months ago
Rubidium fc7f184dbd Codechange: move knowledge about 'packed' orders to the saveload code 5 months ago
Rubidium 1691b41b54 Codechange: use C++ containers for parsing the settings int lists 5 months ago
Rubidium 434c49a1f8 Codechange: remove now unused endof macro 5 months ago
Rubidium 8fe5fdf122 Codechange: use std::none_of to express clearer what the code does 5 months ago
Rubidium 8986fb0385 Codechange: replace C-style array-pointer methods with the appropriate C++ methods 5 months ago
Peter Nelson 2114888485
Change: De-template BaseSetTextfileWindow. (#12536)
The BaseSet type is not needed after the window is constructed, only the filename and name are required, which can be passed as parameters from `ShowBaseSetTextfileWindow()` instead.

This avoids compiling three instances of `BaseSetTextfileWindow`.
5 months ago
Rubidium e441033d68 Codechange: use std::array instead of C-style array for produced/accepts cargo 5 months ago
Peter Nelson 40fa45a76a Codechange: Emplace std::pair into vectors.
This creates the pair in the vector, instead of creating it then copying it in.
5 months ago
Peter Nelson ed2db80990 Codechange: Use map.emplace() instead of map.insert(std::pair).
This avoids a copy of the pair into the map.
5 months ago
Peter Nelson 57d7359b1a
Codechange: Remove old group liveries savegame conversion. (#12537)
Conversion to set default group livery is in the wrong place (not in `AfterLoadGame()`), however it is not necessary any more as `AfterLoadGame()` always calls the function `UpdateCompanyLiveries()` which will do the same thing.
5 months ago
Peter Nelson 699c7e4c9d
Fix 3de8853e29: Industries accept/produce no cargo for pre-SLV_78 saves. (#12508)
Industry accepted/produced was trimmed too early for original and pre-SLV_78 saves, as cargo type was not stored per slot so all slots look invalid to the trim function.
5 months ago
Peter Nelson 1c31e4b68c
Change: Disallow using Action A to load sprites above the baseset unless reserved. (#12435)
Using Action A above the baseset is error prone as the sprites are not fixed and can be moved around.

Any NewGRF doing so is likely to break in the future, so force it to break instead.
5 months ago
Peter Nelson e028c15555
Codechange: Use std::accumulate to get infrastructure total rail/road pieces. (#12442) 5 months ago
translators 08140fdca3 Update: Translations from eints
dutch: 4 changes by Afoklala
5 months ago
Peter Nelson 6cbb8d02cf Change: Use aspect ratio for shared order list button. 5 months ago
Peter Nelson 5df5e3f45c Change: Use aspect ratio for file home button. 5 months ago
Peter Nelson 2a833a8968 Change: Use aspect ratio for rail station platforms/tracks buttons. 5 months ago
Peter Nelson 7e049aa2b1 Change: Use aspect ratio for common left/right buttons. 5 months ago
Peter Nelson 16eb17418b Change: Use aspect ratios for some common widgets. 5 months ago
Peter Nelson 61c6ebaacc Change: Automatically set aspect ratio of common window decorations. 5 months ago
Peter Nelson d43ff8dc49 Change: Ability to set aspect ratio of a widget.
This allows setting the shape of a widget without dealing with absolute pixel sizes.
5 months ago
Peter Nelson f267b37a33
Codechange: Use std::initializer_list/array in framerate window. (#12441) 5 months ago
Peter Nelson a28ab8cac2
Codechange: Replace C-style casts to size_t with static_cast. (#12455)
* Codechange: Replace C-style casts to size_t with static_cast.

This touches only simple value-type casts.

* Codechange: Replace static_cast<size_t>(-1) with SIZE_MAX

Co-authored-by: Rubidium <rubidium@openttd.org>
5 months ago
Peter Nelson 6ee31a2a22
Codechange: Use string_view in IniItem/IniGroup/IniFile. (#12535)
This avoids making extra copies of strings.
5 months ago
Peter Nelson 3b80a8255f
Fix #12433: Width of unit number display was too narrow. (#12534)
Digit width was counted, but ignored the thousands separator.
5 months ago
translators 7848e80f71 Update: Translations from eints
english (us): 4 changes by 2TallTyler
korean: 11 changes by telk5093
5 months ago
dP 0d1fc47edb
Cleanup: Remove redundant break statement (#12527) 5 months ago
Peter Nelson 774f811217
Codechange: Use std::optional for town parent scope resolver. (#12530)
When resolving NewGRF, the parent town_scope is lazily initialised as it does not always need to be used.

Replace the manually managed pointer with std::optional to simplify. Using std::optional avoids extra memory allocation.
5 months ago
Peter Nelson 3b75d8bbf8 Fix: Use modern comparisons instead of memcmp in cache check.
This uses C++20 default operator<=> to provide comparisons of some objects.

This works properly with caches that containers.
5 months ago
Peter Nelson 21d11ee361 Codechange: Move cache check function to own file. 5 months ago
Peter Nelson db56499c01 Codechange: Use std::array for company infrastructure arrays. 5 months ago
Peter Nelson fe7bd3a266 Codechange: Use std::array for cached town zone radius. 5 months ago
Peter Nelson d57bf84196
Codechange: Remove some unnecessary c_str() when passing std::strings. (#12532)
Functions have been updated from `char *` to `std::string` since without removing `c_str()`.
5 months ago
Peter Nelson 45886e50b2
Codechange: Unify where rail station tile flags are set. (#12531)
This avoids repeating the logic in three places.
5 months ago
Jonathan G Rennison 6056a00222 Fix incorrect train weight used for infrastructure sharing track fees 5 months ago
Peter Nelson 4170c9923a
Fix: Inconsistent space between console history and current line. (#12528) 5 months ago
Tyler Trahan 78b83190cc
Fix: Mark vehicle status bars dirty when a vehicle leaves unbunching depot (#12516) 5 months ago
Patric Stout 715f8c0218
Codefix: cast to "CommandCallback *" in a way cast-function-type-mismatch doesn't mind (#12529) 5 months ago
Jonathan G Rennison 0150f8f570 Merge branch 'master' into jgrpp
# Conflicts:
#	src/network/network_server.cpp
5 months ago
translators c355e98c58 Update: Translations from eints
english (au): 4 changes by krysclarke
russian: 4 changes by Ln-Wolf
finnish: 7 changes by hpiirai
portuguese: 4 changes by azulcosta
portuguese (brazilian): 5 changes by pasantoro
polish: 4 changes by pAter-exe
5 months ago
Peter Nelson 63ce81570c Remove: Custom opendir implementation for Windows no longer needed.
std::filesystem::directory_iterator is now used instead.
5 months ago
Peter Nelson 42523379d9 Codechange: Use directory_iterator in ScanPath.
Replaces use of custom ttd_opendir.
5 months ago
Peter Nelson d7c547d0db Codechange: Use directory_iterator to list directories in file list windows.
This replaces use of custom ttd_opendir. Files are listed separately using ScanPath as that handles downloaded content.
5 months ago
Peter Nelson 5a523cf212 Codechange: Simplify FioCreateDirectory.
`std::filesystem` provides `create_directories()` as a cross-platform way to create a directory tree.
5 months ago
Peter Nelson 6458980413
Change: Draw group hierarchy tree lines. (#12522) 5 months ago
Jonathan G Rennison 83d99ec11d
Fix #12506: Update station/industry nearby lists in BuildOilRig (#12511) 5 months ago
Patric Stout f7bd080015
Codechange: improve desync documentation (#12521) 5 months ago
Patric Stout 07b162ffc4
Codechange: skip all commands of the past during desync replay (#12520) 5 months ago
Patric Stout a0636d8200
Codechange: use infinite-fast-forward when rerunning command-log (#12519) 5 months ago
Patric Stout a09749f6a6
Codefix: don't send desync=0 log messages to commands.log (#12517)
They are only used during replay, and you want to see those in
the console; not in the log.
5 months ago
Patric Stout 1005c86c62
Codechange: record cache warnings with a "warning" prefix (#12518) 5 months ago
Tyler Trahan a02da5476e
Fix: Don't show train waiting for unbunching as waiting for free path (#12515) 5 months ago
Tyler Trahan 5878d09ef2
Fix: Smooth outliers in unbunching round trip calculations (#12513) 5 months ago
Tyler Trahan 824687d1f0
Codefix: Don't mix signed and unsigned ints in unbunching calculations (#12514) 5 months ago
Jonathan G Rennison 0b9029b69c Fix: Station/industry nearby list checks in CheckCaches 5 months ago
Peter Nelson ef8eb66a2b
Fix c38df2d58: Use VehicleID instead of pointer in map of vehicles to replace. (#12512)
This affects the sort order, VehicleID is deterministic, Vehicle * is not.
5 months ago
Paco Esteban b477a8458c Codechange: Use arc4random_buf on random_func.cpp for OpenBSD 5 months ago
Jonathan G Rennison e17c6da46a Fix industry cargoes when loading newer vanilla savegames 5 months ago
Jonathan G Rennison d70c824056 Linkgraph: Increase effect strength of distance scaling setting
Updates: 3d049895
5 months ago
Jonathan G Rennison d52d447603 Update station/industry nearby lists in BuildOilRig
See: https://github.com/OpenTTD/OpenTTD/issues/12506
5 months ago
translators 018326321c Update: Translations from eints
english (us): 5 changes by 2TallTyler
latvian: 1 change by lexuslatvia
5 months ago
Koen Bussemaker 257d312a58 Fix #12228, Fix #12231: CheckShipReverse only restricts path when it has to 5 months ago
Rubidium b2218e75d4 Codefix: missing space between close parenthesis and open curly brace 5 months ago
Jonathan G Rennison 41543498f4 Fix ships leaving dots behind in viewport map mode
Fixes: 57db9a41
5 months ago
Jonathan G Rennison 1e38e513ae Fix EnginesDailyLoop being called on new economy day instead of calendar 5 months ago
Peter Nelson 48eb9b8bc9
Add: Check that towns can build roads before generating map. (#12503) 5 months ago
translators 8e2ccddd77 Update: Translations from eints
portuguese (brazilian): 2 changes by pasantoro
5 months ago
Peter Nelson 3ad143c43a
Codechange: Use `x = y` instead of `x{y}` for value-type member initialisation. (#12501)
This is easier to read and less likely to look like an array definition.
5 months ago
ladysadie 727392e0b3
Codechange: Remove per font AA settings. (#12413)
OpenTTD will use the global AA font setting for all fonts from now on.
5 months ago
Peter Nelson a1b03ee69e
Codechange: Replace platform-specific calls with std::filesystem::last_write_time. (#12487) 5 months ago
dP f5a50a874f
Codechange: Update doxygen comment to reflect removed parameter (#12499) 5 months ago
translators cd108fd9e4 Update: Translations from eints
greek: 10 changes by gh658804
5 months ago
Jonathan G Rennison 0dcbcedbac Fix ScriptRail::BuildSignal when using realistic braking with block signals 5 months ago
Peter Nelson 839f486074
Codechange: Use directory_iterator to find language files. (#12495)
This avoids using custom ttd_opendir, along with C-style string comparisons against file names.
5 months ago
Peter Nelson 4eaeccdaeb
Codechange: Introduce FioRemove() to remove files. (#12491)
New function FioRemove() handles OTTD2FS conversion, and uses std::filesystem::remove instead of unlink, all in one location.
5 months ago
FedelloKirfed 46d71463d9 🌐 Update Galician Translations 2024-04-14 5 months ago
translators 29e932e087 Update: Translations from eints
ukrainian: 13 changes by imlystyi
lithuanian: 19 changes by dziugas1959
french: 7 changes by ottdfevr
portuguese (brazilian): 14 changes by pasantoro
5 months ago
translators 090c3b3abf Update: Translations from eints
danish: 5 changes by bscargo
dutch: 5 changes by Afoklala
portuguese (brazilian): 7 changes by pasantoro
5 months ago
Peter Nelson e83e2df023
Fix: Build industry window did not take width of count into account. (#12476) 5 months ago
Peter Nelson 12125bad82
Fix 3de8853e: Industry cargo types callback no longer functioned due to container change. (#12489)
Use defined INDUSTRY_NUM_INPUTS/INDUSTRY_NUM_OUTPUTS values instead of container size, which is now empty at this point.
5 months ago
Peter Nelson c1520cf682
Fix 25aeb1c: Driver parameter documentation was not updated. (#12486) 5 months ago
Peter Nelson ca73f03334
Codechange: Use std::filesystem::remove/rename in settingsgen. (#12483) 5 months ago
Peter Nelson 44b8210037
Codechange: settingsgen's CopyFile actually appends. (#12485) 5 months ago
Peter Nelson 003906becb
Codechange: std::filesystem::rename does not need remove first. (#12484) 5 months ago
translators bb9b8b90c7 Update: Translations from eints
swedish: 6 changes by sereneavatar
portuguese (brazilian): 11 changes by pasantoro
5 months ago
Peter Nelson 9915c1f032
Fix #12477: Use std::filesystem::rename instead of Windows Shell API call. (#12478) 5 months ago
Rubidium eda10abc8c Codechange: pass command line arguments as std::span to openttd_main 5 months ago
Peter Nelson 3316b27496
Fix: Signature validation did not close its file. (#12479) 5 months ago
Rubidium afd7878de0 Codechange: internally use a span of arguments for GetOptData 5 months ago
Rubidium 5592b4409b Codechange: use ranged for loop and separate function instead of goto 5 months ago
Rubidium e8a56db21d Codechange: use designated initializers for OptionData and pass as span 5 months ago
Rubidium 4f2412a272 Codechange: range based for loops instead of C-style for loops 5 months ago
Rubidium 2587a21400 Codechange: use zero-initialization instead of C-style loop 5 months ago
Rubidium ff27b9e76a Codechange: use std::any_of instead of custom loop 5 months ago
translators 6cade18053 Update: Translations from eints
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe
5 months ago
rubidium42 442daf58da Codechange: replace lengthof with std::size in Windows specific code 5 months ago
Peter Nelson 6bc4a62c27 Codechange: Pass std::string_view from blitters instead of char *. 5 months ago
Peter Nelson 332cbca36e Codechange: Pass std::string_view from drivers instead of char *. 5 months ago
Peter Nelson a42aa1a086
Codechange: Remove cargo_suffix C-array from GetIndustryString. (#12472)
The information is pushed onto a vector, so string ownership can be moved there instead of using a pointer into to the CargoSuffix array.
5 months ago
Jonathan G Rennison 6642b7e12c Temporary fix for click/tooltip alignment of cargo lines in industry chains window
See: #681
See: https://github.com/OpenTTD/OpenTTD/issues/12465
5 months ago
Peter Nelson 144bcbbaf1
Fix: Use clear() to clear std::string. (#12471) 5 months ago
Rubidium 21b640b5ff Codechange: simplify president name generation 5 months ago
Jonathan G Rennison 8e0fa32d33 Fix merge/editing error in IndustryCargoesWindow 5 months ago
translators f0f97c698b Update: Translations from eints
norwegian (bokmal): 11 changes by eriksorngard
russian: 5 changes by Ln-Wolf
spanish: 5 changes by MontyMontana
portuguese (brazilian): 7 changes by pasantoro
6 months ago
Jonathan G Rennison 3d04989507 Link graph: Change distance scaling algorithm in demand scaler
Fix erratic scaling and increase effect at large setting values
6 months ago
Peter Nelson 1773c5b810
Change: Increase object/station/roadstop class limit. (#12094)
The class limit is arbitrary and not stored in game state.

This change prevents all entities in classes after the 255th class from being dumped into the first class.
6 months ago
Rubidium df8eeb1b10 Codechange: use C++ algorithms to determine the SaveLoadFormat 6 months ago
Peter Nelson 77f27e0804 Change: Expose NewGRF classes and specs as spans and simplify iteration.
This replaces some index-based loops with range loops.
6 months ago
Peter Nelson 052f421327 Change: Use vector/iterators/algorithms instead of C-array/loops for NewGRF classes. 6 months ago
Peter Nelson 34758d0921 Change: Allow string mapping by function instead of pointer.
This allows mapping of strings to objects that may be moved between loading stages.
6 months ago
Peter Nelson 90ca3515da
Fix #12459, f6a88e4: Crashes when deleting news messages. (#12460)
The updated logic in f6a88e4 for deleting news messages did things in the wrong order.
6 months ago
Jonathan G Rennison 3712b84d2e Fix narrowing conversion warnings 6 months ago
Peter Nelson 2976a46d06
Fix 54be756: Terminating NUL byte was not skipped in ReadString(). (#12462) 6 months ago
Rubidium 883d3e7a9f Codechange: use std::span instead of pointer + length 6 months ago
Peter Nelson 54be756aae
Codechange: Pass NewGRF strings as std::string_view instead of char *. (#12461) 6 months ago
Peter Nelson dc7c2bb30d
Fix: Draw continuation lines for engine variant hierarchy tree. (#12434) 6 months ago
Peter Nelson de4e00c93f
Codechange: Pass by reference to UpdateWidgetSize. (#12457)
These parameters are always provided and not optional.
6 months ago
translators b5ad28022d Update: Translations from eints
english (au): 5 changes by krysclarke
chinese (simplified): 1 change by WenSimEHRP
catalan: 7 changes by J0anJosep
portuguese (brazilian): 27 changes by pasantoro
6 months ago
Peter Nelson 1b127628cb
Codechange: Use dynamic_cast with FindWindowById. (#12458)
Missed from 74e09ab.
6 months ago
Rubidium bf0cb3c43f Codechange: let lengthof fail when anything that isn't a C-style array is passed
(cherry picked from commit 97bea563d7)
6 months ago
Jonathan G Rennison 28e74005d0 Remove various uses of lengthof on std::array 6 months ago
Rubidium 919830db7a Fix: do not use lengthof() for non C-style arrays
(cherry picked from commit c544a2be0a)
6 months ago
Peter Nelson c5b854a422 Codechange: Avoid lengthof() on std::array.
(cherry picked from commit 295508fc53)
6 months ago
Peter Nelson 9b830e9eb2 Fix: Aircraft crash counter was too low to reach ground. (#12425)
Aircraft can float above the ground when crashed as the counter limit to reach the ground is too low.

Instead reset the counter until the aircraft reaches the ground, then continue the timer.

(cherry picked from commit 83da886093)
6 months ago
Peter Nelson cc6322e0a3 Fix #12233: Mini order list overlaps vehicle group name. (#12423)
Move mini order list down one line to make room.

(cherry picked from commit e8c78df39e)
6 months ago
Peter Nelson df03366cf5 Fix #12114: Viewport coords of crashed aircraft not updated when falling. (#12424)
This results in the aircraft glitching as the wrong viewport area is drawn.

(cherry picked from commit d11622b9a0)
6 months ago
Peter Nelson 7e28605830 Fix: Use reinterpret_cast instead of C-style cast to align pointers. 6 months ago
Peter Nelson 4daf95b878 Fix: Use static_cast instead of C-cast to avoid hidden errors. 6 months ago
Peter Nelson cdfffb551c Fix: sym->sym accidentally changed to sym prevented keys working with SDL. 6 months ago
Peter Nelson 74e09abf76
Codechange: Use dynamic_cast instead of C-cast after FindWindowById. (#12448)
dynamic_cast was used in most places, but not all.
6 months ago
Rubidium 4e6d4fcf32 Codechange: replace for loops with endof with range-based for loops 6 months ago
translators 095bdf32fe Update: Translations from eints
greek: 5 changes by gh658804
finnish: 7 changes by hpiirai
ukrainian: 56 changes by Quantom2, 14 changes by imlystyi
latvian: 14 changes by lexuslatvia
portuguese: 14 changes by azulcosta
portuguese (brazilian): 10 changes by pasantoro
polish: 5 changes by pAter-exe
6 months ago
Rubidium 62f5c595f3 Codechange: use range-based for loops and let count be correct count 6 months ago
rubidium42 4718971ccc Codechange: use std::size instead of lengthof for town names 6 months ago
Peter Nelson 995fca58a2
Codechange: Use begin/end instead of endof for some industry arrays. (#12447) 6 months ago
Rubidium d7fa614a9d Codechange: use range-based for loop for debug levels and fix global variable naming 6 months ago
Rubidium 1fcf1a136d Codechange: use single function returning std::span over two functions that return size and begin 6 months ago
Jonathan G Rennison 89e3b009c3 Fix changing sprite alignment in sprite aligner window 6 months ago
translators 0f6bf90731 Update: Translations from eints 6 months ago
Peter Nelson eb094a953c
Codefix: Social Plugins widget parts were not constexpr. (#12443)
Widget lists were made constexpr except these.
6 months ago
Peter Nelson 34ba969c74
Change: Display more useful information in sprite aligner than sprite ID. (#12439)
Sprite IDs are not useful information given they change don't refer to anything outside the loaded game.

Instead, include the filename and nfo line at minimum, and include action A or action 5 sprite replacement information if applicable.
6 months ago
Peter Nelson fbdf26800b
Codechange: Use std::initializer_list and range-for for credits window. (#12431)
Replaces C-style array, indexed looping, and char * strings.
6 months ago
Peter Nelson a4c2f0778a
Codechange: Use range-for to iterate keycode-to-name lookups. (#12429)
Replaces C-style looping.
6 months ago
Peter Nelson b905209421
Fix: Viewport signs assume small font is smaller than normal font. (#12422)
If the small font is set to a larger size than the normal font for some reason, viewport signs would be drawn incorrect as the area marked dirty only considered the normal size font.
6 months ago
Peter Nelson 830c9e2de8 Codechange: Simplify iteration of framerate performance elements. 6 months ago
Rubidium 97bea563d7 Codechange: let lengthof fail when anything that isn't a C-style array is passed 6 months ago
Rubidium c544a2be0a Fix: do not use lengthof() for non C-style arrays 6 months ago
translators eaafc57de6 Update: Translations from eints
swedish: 6 changes by joeax910
norwegian (bokmal): 2 changes by eriksorngard
chinese (simplified): 2 changes by WenSimEHRP
dutch: 2 changes by Afoklala
6 months ago
Peter Nelson 8e881471c1 Codechange: Pass replacement blitter name as string_view instead char *. 6 months ago
Peter Nelson 6771dbe62b Codechange: Use range-for to find replacement blitter. 6 months ago
Peter Nelson a866166673
Codechange: Use initializer_list and range-for for OpenTTD title. (#12430)
Replaces C-style array and looping.
6 months ago
Peter Nelson 2cc700d606
Codechange: Replace colour_dropdown array with StringID arithmetic. (#12426)
This assumes that the string colours are in order, but that is already assumed elsewhere.

Removes old C-style array access.
6 months ago
Peter Nelson 83da886093
Fix: Aircraft crash counter was too low to reach ground. (#12425)
Aircraft can float above the ground when crashed as the counter limit to reach the ground is too low.

Instead reset the counter until the aircraft reaches the ground, then continue the timer.
6 months ago
Jonathan G Rennison 1a6a4c9a6c Fix path-only signal cycle mode being ignored when using realistic braking 6 months ago
Peter Nelson e8c78df39e
Fix #12233: Mini order list overlaps vehicle group name. (#12423)
Move mini order list down one line to make room.
6 months ago
Peter Nelson d11622b9a0
Fix #12114: Viewport coords of crashed aircraft not updated when falling. (#12424)
This results in the aircraft glitching as the wrong viewport area is drawn.
6 months ago
translators df3e5ade11 Update: Translations from eints
korean: 2 changes by telk5093
portuguese (brazilian): 1 change by pasantoro
6 months ago
Peter Nelson 7572cfd103 Codechange: Redefine ZOOM_LVL so that ZOOM_LVL_NORMAL is 1x zoom.
This matches expectations of what normal zoom means.
6 months ago
Peter Nelson 9854553e10 Codechange: ZOOM_LVL_SHIFT/BASE are not actually ZOOM_LVLs.
Rename to ZOOM_BASE_SHIFT and ZOOM_BASE respectively, and derive from ZOOM_LVL instead of numeric value.
6 months ago
Peter Nelson 3c94e81665 Codechange: Use ZOOM_LVL_MIN to refer to first zoom level.
Many uses of ZOOM_LVL_NORMAL actually just want the first zoom level slot, so use ZOOM_LVL_MIN to make this clearer.
6 months ago
Peter Nelson 7c322ebcf1 Codechange: Define a ZOOM_LVL for minimum text effect visibility. 6 months ago
Peter Nelson 197fb00d31
Fix #12395: Ensure president name widget is tall enough. (#12419) 6 months ago
Peter Nelson 338def1b06
Fix: Segfault when using -q without providing a . character. (#12418)
Use std::filesystem::path to find extension instead of strrchr.
6 months ago
Peter Nelson f6a88e40a4
Codechange: Use std::list for News Items. (#12338) 6 months ago
translators 08cf106fc6 Update: Translations from eints
english (us): 2 changes by 2TallTyler
finnish: 2 changes by hpiirai
ukrainian: 2 changes by Quantom2
danish: 2 changes by beruic
portuguese (brazilian): 22 changes by pasantoro
6 months ago
Jonathan G Rennison a9dbd793b4 Implement Vehicle::GetCargoTile for (multi-part) ships 6 months ago
Loïc Guilloux 3cf43de059 Fix #12415, 9c49a61, df400ef: Aircraft::tile is valid only for front vehicle (#12416)
(cherry picked from commit 243c6bead3)

# Conflicts:
#	src/economy.cpp
6 months ago
Loïc Guilloux 243c6bead3
Fix #12415, 9c49a61, df400ef: Aircraft::tile is valid only for front vehicle (#12416) 6 months ago
translators 931aa39018 Update: Translations from eints
english (au): 2 changes by krysclarke
swedish: 2 changes by joeax910
greek: 2 changes by gh658804
russian: 3 changes by its5Q
catalan: 2 changes by J0anJosep
spanish: 2 changes by MontyMontana
portuguese: 2 changes by azulcosta
portuguese (brazilian): 27 changes by pasantoro
polish: 2 changes by pAter-exe
6 months ago
Peter Nelson 9750826590
Fix a29766d: Wrong scrolling dropdown list position with RTL. (#12412) 6 months ago
translators 72b5c6a591 Update: Translations from eints
vietnamese: 1 change by KhoiCanDev
greek: 83 changes by gh658804
german: 3 changes by Wuzzy2
ukrainian: 54 changes by Quantom2
spanish: 4 changes by MontyMontana
portuguese (brazilian): 2 changes by pasantoro
6 months ago
Peter Nelson 2047c27445 Codechange: Move drop down list item definitions to separate header.
This reduces the scope of the definitions which are no longer needed to create the common lists.
6 months ago
Peter Nelson 56cac21086 Codechange: Use functions to create common drop down list items. 6 months ago
Loïc Guilloux 11aa3694fa
Fix: [Win32] Force font mapper to only use TrueType fonts (#12406) 6 months ago
Peter Nelson f79ec7955a Codechange: Explicitly reset old industry data before loading games. 6 months ago
Peter Nelson 3de8853e29 Codechange: Store accepted and produced cargo in vector instead of array.
Most industries do not use the full 16 slots, so this can save a little memory and iteration time.
6 months ago
Peter Nelson bd2a92331b Codechange: Use inline and std::array for old industry structures.
This avoids separate declaration/definition, and less C-style arrays.
6 months ago
Peter Nelson 00e0021e3a Codechange: Don't assume accepted/produced slot exists. 6 months ago
Peter Nelson 295508fc53 Codechange: Avoid lengthof() on std::array. 6 months ago
Peter Nelson f6b38e8e06 Codechange: Remove optional MakeCargo() parameters that are never changed.
Default values are always used, so don't need to be parameters.
6 months ago
Peter Nelson e4fc8ef595 Codechange: Use std::span for industry cargo window instead of pointer + length. 6 months ago