217570edff
[fenix] Import l10n.
3 years ago
a6d7128c7e
[fenix] No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
a672d27ca6
[fenix] No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
7d5bac64d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21025 : Set long term business-critical metrics as non-expiring ( https://github.com/mozilla-mobile/fenix/pull/21038 )
...
* Set long term business-critical metrics as non-expiring.
* Remove quotes around "never"
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
8daaca51af
[fenix] Use identifiers instead of hard coded strings
3 years ago
eaed414831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21747 re-enable start on homepage UI test and refactoring work
3 years ago
20541aab38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21754 re-enable general settings UI test and refactoring work
3 years ago
7a4658627e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
0c5e1f3442
[fenix] No issue: Add external load flag
3 years ago
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
775929a293
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21628 : catch ComposeNotIdleException
3 years ago
8a2df4be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
...
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
af4a03a0f3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714 : Login button visibility fix on saved logins page
3 years ago
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
b566e3ed7f
[fenix] Import l10n.
3 years ago
e7695f25ef
[fenix] Import l10n.
3 years ago
3516c38f1f
[fenix] Import l10n.
3 years ago
2a52bffeae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
1336a4f72d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
9a784f8484
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
91e7121fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
2f7d5c03f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
888e9365cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
d09f8d1a00
[fenix] Import l10n.
3 years ago
53db79d50e
[fenix] No issue: Only report telemetry when tabs tray is first opened
3 years ago
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
8fc6c5952f
[fenix] No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
9688a90c29
[fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
e17721e795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
99988cd74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
c4bce2422e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test
3 years ago
231ee9a9c3
[fenix] Import l10n.
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
f3f8f717f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors
3 years ago
6f80d2871f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
e8cd66b619
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED
3 years ago
e7f6b6fc14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55
3 years ago
0abac59277
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA
3 years ago
f928428f5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
c3d86f8dc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF
3 years ago
1a01f638c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18
3 years ago
4783442368
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75
3 years ago
98dd4016ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
521b564fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF
3 years ago
a77c5b8fad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787
3 years ago
18a9ffed66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64
3 years ago
013530110e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff
3 years ago
2e762f0327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27
3 years ago
9a901e0cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E
3 years ago
453c6f9f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2
3 years ago
e5a197c402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587
3 years ago
bfce9bc796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A
3 years ago
a8cdbb4524
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF
3 years ago
a63441e402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB
3 years ago
c07d13ba2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042
3 years ago
648f3261c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1
3 years ago
d50ff294a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5
3 years ago
ebcc1024ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF
3 years ago
98c315c7e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000
3 years ago
d51e2df39a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
d7521f168e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list
3 years ago
0a5ba09d26
[fenix] Import l10n.
3 years ago
aabd1999ee
[fenix] CI for 21827 ( https://github.com/mozilla-mobile/fenix/pull/22004 )
...
* Remove redundant calls to setHasOptionsMenu(false)
Fix memory leaks for credit card and login fragments
* Fixes:
Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt
* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
906b7a168c
[fenix] Import l10n.
3 years ago
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
c1c42385c4
[fenix] Improve tabsSettingsMenuItemsTest UI test coverage
3 years ago
bee0854156
[fenix] Import l10n.
3 years ago
70919737fd
[fenix] Import l10n.
3 years ago
952ba35095
[fenix] Import l10n.
3 years ago
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
299406fc89
[fenix] Import l10n.
3 years ago
09d1c997d8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944 : Top sites rendered slowly on first load of HomeFragment
3 years ago
b7a03ea6d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : linting fixes
...
For https://github.com/mozilla-mobile/fenix/issues/21700 : nit fixes
3 years ago
c261feb602
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Added option to open in browser instead of automatically doing it
3 years ago
c558e11cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : fixed comments
3 years ago
60fa679e9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Created benchmark script runner and edited benchmark gradle file
3 years ago
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
5372f1bcca
[fenix] Make linters happy
3 years ago
84773fa9a2
[fenix] Register the logins key provider
...
This is required for sync to work
3 years ago
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
0672471708
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section
3 years ago
c8d89a3bba
[fenix] Fix for ambiguous tabstray_title and with text matcher for audio page
3 years ago
45bdd68df1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test
3 years ago
f5fa9d4217
[fenix] No issue: Always show Make inactive for debug builds
3 years ago
fa4b9996c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20
3 years ago
1e84ef3843
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Add shadow to recent bookmarks section
3 years ago
ac7e445eb0
[fenix] Import l10n.
3 years ago
ed3560d1b9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917 : Update pocket stories card elevation to match other cards
3 years ago
18a8788812
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707 : Correct search grouping logic in extensions
...
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.
The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.
Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
cb7cc7a7eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources
3 years ago
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
4fee8036a0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Remove rotation; rely on state activated
...
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
7638040a3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest
3 years ago
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
1bb5f1479d
[fenix] Disable editCustomSearchEngineTest UI test
3 years ago
d6ae910c74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK.
3 years ago
6a7c42a398
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test
3 years ago
f0091a768c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test
3 years ago
ec442f575f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings
3 years ago
7f9dab5654
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest
3 years ago
3ea7755592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005 : fixed ETP status info display
3 years ago
897aa4b662
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21522 : Wrap section titles on home
3 years ago
86029b181c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew fission metrics expiring in December
3 years ago
c7232a0bdb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Stop using internally stored tabs list in adapters
3 years ago
f10d226f92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
...
To get smaller shadows.
3 years ago
cde1c3b911
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates.
3 years ago
e22e33c3c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake.
3 years ago
b916fc4a85
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437 : Fix default of start_on_home setting in UI
3 years ago
ff62ffe70a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section
3 years ago
d13f0ef797
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Reverse chevron for inactive tabs
3 years ago
16ed26781d
[fenix] Update Android Components version to 95.0.20211008105820.
3 years ago
aa6387809d
[fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests
3 years ago
153bfcce38
[fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests
3 years ago
3317d98b34
[fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description
3 years ago
7dd7b2e5b2
[fenix] Fix for ambiguous tabstray_title and with text
3 years ago
d6755b5580
[fenix] Fix for ambiguous tabstray_close
3 years ago
75606a8786
[fenix] Fix for ambiguous tab_item
3 years ago
822775eb9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash
3 years ago
363e563fc7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Move submitList calls into TabsAdapter
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
d73ea2cf98
[fenix] Enable pocket stories in CA
3 years ago
185121606c
[fenix] Prepare nimbus features default values for release 95
3 years ago
2fc70778a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20579 : Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode
3 years ago
a4fcc93d0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience
3 years ago
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
257ae4b118
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424 : add marker for StrictMode.resetAfter.
...
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
e3b2309ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol
3 years ago
b772f6d080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen ( https://github.com/mozilla-mobile/fenix/pull/21722 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text
* PR: Fixed lint warning. Reverted preference keys
* PR: added ignore for UI test
* PR: Added ignore for UI test
3 years ago
259b2e5d30
[fenix] No issue: Update Pocket categories spacing to 16dp.
3 years ago
a4e21f4fbb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102 : Set compileSdkVersion to 31.
3 years ago
c9d8e826ca
[fenix] No issue: Small layout update for Pocket Stories
3 years ago
398bdac5aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size
3 years ago
e487bc6f59
[fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often
3 years ago
3e01e9df25
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Show the jump back in Contextual Hints independently of the home onboarding dialog.
3 years ago
f4f7c1b0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : disabled the homescreen onboarding dialog.
3 years ago
2594eac89e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Update design for jump back in section and recently bookmarked section
3 years ago
bdc54a1465
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
...
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
622e713c07
[fenix] Update feature flags for 94.
3 years ago
09c8890055
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test
3 years ago
5baa97270c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links
3 years ago
f372c5c69f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup
3 years ago
e606d8c42a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
...
Added from the ViewHolders, the same as for XML Views.
3 years ago
dc66fea1e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items
3 years ago
07d08eb655
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description
3 years ago
8f6a6d0980
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items
3 years ago
11b92bbd99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding
3 years ago
2e597529c8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582 : Use ThumbnailStorage in recent tabs on home
3 years ago
fde5b755e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited
3 years ago
8a78101fc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches
3 years ago
33cf85203a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642 : Remove in-progress media tab from homescreen
3 years ago
5385b96abe
[fenix] Move tabs out of search group if direct load occurs
...
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.
However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
3db298543e
[fenix] CI for Fix description for home_screen_displayed metric ( https://github.com/mozilla-mobile/fenix/pull/21697 )
...
* Fix description for `home_screen_displayed` metric
The current description appears to be incorrect by my reading of the source.
* Update app/metrics.yaml
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
3631014159
[fenix] CI for Docs: Add extra context to events.browser_menu_action ( https://github.com/mozilla-mobile/fenix/pull/21696 )
...
* Docs only: Add extra context to `events.browser_menu_action`
This came up as a potential point of confusion in a discussion with DS. This is a docs only change.
* Update metrics.yaml
Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
efab5cbb1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions
3 years ago
3d69371557
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671 : Remove Recently Closed from Inactive Tabs
3 years ago
7e65b07930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
...
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
6261e570c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
...
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
4f4586d85f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
...
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
7b031b0504
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test
3 years ago
884c8c2224
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576 : Hide 'Other' title when there are no search groups
3 years ago
20f07022d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties
3 years ago
8a4bb26526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618 : Integrate Nimbus with MR2 Home Page to enable experimentation
3 years ago
21480b89ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in Contextual Hints
3 years ago
51000bcfa4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632 : Correct inactive tabs survey string ( https://github.com/mozilla-mobile/fenix/pull/21669 )
3 years ago
c1f2c33a76
[fenix] Make search term grouping tolerant to (parent tab) navigation
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
d70d0610d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21648 : match Pocket sections on home to designs
3 years ago
0c5285cf05
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641 : Do not add a group of only one tab
3 years ago
ad1cff2300
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21653 : pre-land section title for tab preferences
3 years ago
4f07d1a40f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups ( https://github.com/mozilla-mobile/fenix/pull/21615 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup
* PR: Added missing licenses and possibly fixed UI test
* PR: Added a "scrollTo" to potentially fix a UI test
* PR: Added potential fix for alwaysStartOnHomeTest
* PR: Added temporary ignore to alwaysStartOnHomeTest
* PR: added missing ignore comment
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
f12124b948
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21646 : Update section titles and customize button name on home
3 years ago
b9f5e56c37
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21643 : Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. ( https://github.com/mozilla-mobile/fenix/pull/21645 )
3 years ago
44f1f679e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message ( https://github.com/mozilla-mobile/fenix/pull/21636 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message
* PR: Updated String descriptions and added temporary tools ignore
3 years ago
33381f78f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey
3 years ago
bd610d394f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16437 : Remove unnecessary space for tracking protection exceptions
3 years ago
4e5047d203
[fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions.
3 years ago
1d537cb332
[fenix] Allow opening pocket stories when search dialog is active
3 years ago
1f628f8e52
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 , https://github.com/mozilla-mobile/fenix/issues/21620 : disables failing UI tests
3 years ago
4967527781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21441 , https://github.com/mozilla-mobile/fenix/issues/21477 , https://github.com/mozilla-mobile/fenix/issues/21500 , https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476 , https://github.com/mozilla-mobile/fenix/issues/21474 : retry dismissing the search bar
3 years ago
1da6397453
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610 : Update Strings for Tab Settings
3 years ago
2311ac81df
[fenix] Import l10n.
3 years ago
5e57ece039
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in contextual hint text
3 years ago
1f11b81bc4
[fenix] No issue: Make sure jump back in group always have more than one tab
3 years ago
4d23db624f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
dc1e5e640e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21287 : long press menu on recently visited homescreen groups
3 years ago
e1a2b9ccfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21608 : Update strings for home screen dialog features
3 years ago
485ca898f2
[fenix] Do not show home screen behind search if we have search terms
...
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
0a08c61e8d
[fenix] Don't manually exclude glean-native
...
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
3 years ago
f2b7eea088
[fenix] Inactive tabs changes ( https://github.com/mozilla-mobile/fenix/pull/21524 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code
Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup
* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings
* PR: Fixed lint warnings
* PR: Removed redundant feature check
* PR - Ignore test until search term tab groups switch is done
3 years ago
4fac910adf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories
3 years ago
92bc5e93b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
...
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
3 years ago
e7b2578a5a
[fenix] No issue: Fix AssertionError in openThreeDotMenu
...
fix: ktlint
3 years ago
c7658e352d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test
3 years ago
e7077466ff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : suppress MaxLineLength in Fact.toEvent.
...
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
3 years ago
d0ceaf7a7a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : remove allocations in Fact.toEvent.
...
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat
My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.
---
The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.
It was straightforward to remove these allocations so that's what this
change does.
The primary risk from this change is that it's difficult to test each
case to ensure it's working.
3 years ago
08a11127aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : change `when (condition) {` `when {` in Fact.toEvent.
...
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
3 years ago
32c8709148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : add partial test for existing factToEvent code.
...
When we refactor, this will help ensure we've done it correctly.
3 years ago
ed55813676
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs
3 years ago
738e7b68d5
[fenix] Import l10n.
3 years ago
8a77a20614
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : Move the homescreen onboarding card behind a feature flag
3 years ago
ad0f428f39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu
3 years ago
08a71a5366
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
...
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
710a94b9ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test ( https://github.com/mozilla-mobile/fenix/pull/21563 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
c0c59f266b
[fenix] No issue: Improve rendering of jump back in
3 years ago
7ed672d7ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test
3 years ago
005d0f01a3
[fenix] Fixed verifyAboutFirefoxPreview test according with new steps
3 years ago
01e865fee0
[fenix] Fixed disabled UI test openExternalLinksInPrivateTest
3 years ago
55da682e79
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552 : Remove Extra Subtitle In Jump Back In Item
3 years ago
f90fd65ccd
[fenix] Fix recent tabs intermittent tests ( https://github.com/mozilla-mobile/fenix/pull/21557 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b777fa32ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21339 : update styles for homescreen show all buttons and jump back in spacing ( https://github.com/mozilla-mobile/fenix/pull/21342 )
...
For https://github.com/mozilla-mobile/fenix/issues/21339 : Add ignores for intermittent ui tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
219561d304
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown
3 years ago
4702a66203
[fenix] Do not capture search terms when user navigates away via app ( https://github.com/mozilla-mobile/fenix/pull/21527 )
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
f4a38f0a65
[fenix] Delete browsing data tests UI tests
3 years ago
c1d3d97cc8
[fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work
3 years ago
32d6ee0dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : renewing performance awesomebar metrics ( https://github.com/mozilla-mobile/fenix/pull/21315 )
3 years ago
f65770a34f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451 : Add active search term tab groups on home
3 years ago
c4eb7ea28b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections
3 years ago
6da619deb7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding
3 years ago
012b854d69
[fenix] Fix disabled shortcutButtonTest UI test
3 years ago
d701a81103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Add categories support
3 years ago
c37f1e550b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Cleanup
...
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
5a5507b490
[fenix] Import l10n.
3 years ago
f5588635a2
[fenix] Import l10n.
3 years ago
9dd6d98748
[fenix] Import l10n.
3 years ago
7ea5cdbe39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21087 : Updates Recently Saved design
3 years ago
c9e1bfe3dc
[fenix] Fix mapping between history visits and groups to use createdAt
...
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
7f17484989
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441 : Fix changeAccessibiltySettings
3 years ago
d7c1238dac
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366 : Speculative fix for failing test in TitleHeaderBindingTest
3 years ago
a6a6b6f257
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 : Dedupe urls/site in history groups
3 years ago
cb4b5fc613
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu
3 years ago
bc452b6adc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17847 : adding back editCustomSearchEngineTest UI test
3 years ago
cc65e13b50
[fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests
3 years ago
8976e193d9
[fenix] Fix for disabled saveLoginFromPromptTest
3 years ago
ba990dd118
[fenix] Import l10n.
3 years ago
e3bc494414
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs
3 years ago
e87af643cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen
3 years ago
15a3e30bf0
[fenix] No issue: re-enabled swipeToSwitchTabTest
3 years ago
023612b87d
[fenix] Fix logic so `isFirstRun` can be called multiple times on first run
3 years ago
b4886fe546
[fenix] [SDK-344] Pass in first-run information to Nimbus for targeting
3 years ago
450055a729
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder
3 years ago
4a6c5b8296
[fenix] Various UI test fixes and disabling of intermittents
3 years ago
10f5aa228b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172 : Refactor UI tests accessing awesomebar suggestions.
3 years ago
74500adfb5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172 : Replace BrowserAwesomeBar view with AwesomeBar() composable.
3 years ago
bc30e53e5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case
3 years ago
793ceb8e28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history
3 years ago
2b55e561fb
[fenix] Exit onboarding tour UI tests
3 years ago
13ce5a86bd
[fenix] Import l10n.
3 years ago
275ac7ad5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21126 : process performancetest intent for AC too.
3 years ago
1b6c555758
[fenix] Fix QR scan button not showing up when choosing a RTL language
3 years ago
c3df9a26d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen
3 years ago
e18fbdfbfc
[fenix] Make sure to only record view time once for a given tab access
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
16f3396473
[fenix] Import l10n.
3 years ago
d387f7281c
[fenix] No issue: remove escape chars on add logins string
3 years ago
6297f2cce9
[fenix] Use UpdateUrlAction to record viewTime observations
...
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.
This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.
The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.
Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
3 years ago
48c0d7faee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21337 : rename recently saved section on home
3 years ago
473f671f1c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21388 : Only parse clipboard content when search fragment is attached
3 years ago
9d6367a607
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21366 : Fix intermittent test failure in TitleHeaderBindingTest
3 years ago
0884f54fe8
[fenix] Improve coverage for verifyAboutFirefoxPreview
3 years ago
1ae41010df
[fenix] Import l10n.
3 years ago
530d6a0cf8
[fenix] Import l10n.
3 years ago
1f0efff72e
[fenix] Import l10n.
3 years ago
9c2e6eee78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21296 : add ProfilerMarkers.addForDispatchTouchEvent.
3 years ago
49294996e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21299 : add duration markers for HomeActivity Create/Start.
...
We only instrument these methods because they're the only ones that
noticeably long running in the current implementation.
3 years ago
4a132b958b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21299 : add duration marker for IntentReceiverActivity.onCreate.
...
We only instrument onCreate because it's the only one with an
implementation.
While declaring this as a function that accepts a lambda is less
fragile, we've previously had issues with it such as suspected memory
leaks when used for telemetry. Therefore, we go with the simpler
approach.
3 years ago
f53adc5b12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21299 : add markers for all activity lifecycle callbacks.
...
We implement these all in the same track because between it'd create a
lot noise between this and fragment lifecycle callbacks.
3 years ago
21c8f3d1a0
[fenix] Update tabs tray title header string comment to clarify what it does.
3 years ago
8d5a7606f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21335 : return self instead of mock in FenixSnackbarKtTest.
...
This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.
Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.
See d396c9eb41298cc07fbf136f1de971010bc45d97 for a prior attempt to
address the intermittents in this class.
3 years ago
c2d385f142
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fixes empty tray visibility logic
...
This is a bug we noticed after landing search term grouping.
An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.
Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
b239d7d934
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291 : SearchDialogFragment: Get URL from clipboard once and not for every state update
3 years ago
02cbf2953f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section ( https://github.com/mozilla-mobile/fenix/pull/21177 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section in tabs tray
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Scroll to selected tab + various tab fixes for groupings
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fix failing test
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
47805dc6bb
[fenix] Import l10n.
3 years ago
96e083e5b3
[fenix] Update strings comments
3 years ago
336d681451
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21309 : add profiler markers on global layout.
3 years ago
595a81aec2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21309 : set up HomeActivityBinding the recommended way.
...
The recommended way is here:
https://developer.android.com/topic/libraries/view-binding
I was concerned with the existing implementation that binding was being
set conditionally.
3 years ago
6e63dce89d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21309 : remove outdated comment regarding async nav graph.
3 years ago
2dc9cfec20
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18102 : remove intermittent failing App onCreate duration measurement test.
...
The test as it exists relies on the robolectric lifecycle, which is hard
to predict, so it doesn't seem worth fixing the test. Writing the test
any other way would require excessive mocking, which also seems
impractical.
3 years ago
e78754d598
[fenix] Add default topsite 58 for MozillaOnline builds
3 years ago
5ce4a31be5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen.
3 years ago
b057d6a76f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs
3 years ago
d4a454442b
[fenix] Sort history metadata on home and allow limiting results
3 years ago
ae40da34f8
[fenix] Import l10n.
3 years ago
b0957a77ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21120 - ImageLoader with a shimmer effect placeholder
3 years ago
ba70d609f1
[fenix] New deleteBookmarkInEditModeTest UI test
3 years ago
9cf25c9c64
[fenix] Improve coverage for copyBookmarkURLTest
3 years ago
42ddf1faa4
[fenix] Import l10n.
3 years ago
1e1a52e6f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20654 : Handle private mode switching from home behind search dialog.
...
Add tests for controller and interactor to handle private mode switches
3 years ago
9a78d339b5
[fenix] Fix history metadata API breakage in unit tests
3 years ago
2ab11137aa
[fenix] Ensure glean-native is excluded
3 years ago
3ea7d78268
[fenix] Use glean-native in tests
...
The Glean core native code is now shipped through GeckoView directly
(through its `-omni` packages).
For local tests we need a library matching the host-platform, which is
available in the glean-native package.
3 years ago
9bfba77957
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20634 : remove some unused color resources
3 years ago
b1ee43a7ed
[fenix] Improve coverage for addPrivateBrowsingShortcut Ui test
3 years ago
fc42d08c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18629 : add support for SmartBlock exceptions
3 years ago
5d55e07dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen.
3 years ago
ea5d0ee63d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21211 hide the ETP in custom tabs.
3 years ago
d7355dc309
[fenix] Import l10n.
3 years ago
4ff053609b
[fenix] Import l10n.
3 years ago
aa63facce4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21133 fix openMainMenuSyncItemTest UI test
3 years ago
739d93372e
[fenix] Handle breaking changes from a-s 83.0.0 ( https://github.com/mozilla-mobile/fenix/pull/21215 )
3 years ago
a9cdb1984c
[fenix] Import l10n.
3 years ago
434c0b6918
[fenix] Issue mozilla-mobile https://github.com/mozilla-mobile/fenix/issues/20637 - Fixed bug causing the tabs tray to scroll to the wrong tab when opened
3 years ago
1d78c8b1a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6968 : Use close instead of read to close the response stream.
3 years ago
42a5fcc880
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 allow users to configure their home screen.
3 years ago
d0757d386a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19947 : manually add login ( https://github.com/mozilla-mobile/fenix/pull/21199 )
...
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it.
Fixed bindings.
* [WIP] Removed "reveal password" button
* [WIP] Added interactor for the add login screen
* [WIP] Trying to check for duplicates
* [WIP] Renaming "addNew..." with "add..."
* [WIP] Check for duplicates
* [WIP] Fixes after merge
* Cleaning up the layout and making edit text for hostname selectable
* Error handling on add login screen. Tests for interactors and controllers
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
0ea0ce4532
[fenix] Import l10n.
3 years ago
df0b8e5886
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21183 : remove view hierarchy depth check from excessive resource test.
...
This doesn't seem to be a high value test: increasing the view hierarchy
depth will only result in a performance problem on low end devices
if there is enough content on the new layer to cause the traversal to
take longer. It's more likely to result in a hard-to-workaround false
positive so we can remove it, like component init count.
3 years ago
88f34d654e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21183 : remove lazyMonitored wrapper functionality.
...
We're not using the functionality so there's no sense in doing the work.
However, we keep the wrapper: see the code comments for details.
3 years ago
afea6772f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21183 : remove component init check from excessive resource test.
...
This check doesn't seem high value because initializing a component
only indicates a performance problem if it's slow, which is not most
components, so it's likely to result in many false positives. To fix
the intermittent, we won't lose much if we remove it.
3 years ago
c42b4d7481
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection panel strings
3 years ago
691fe57943
[fenix] Issue mozilla-mobile https://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. ( https://github.com/mozilla-mobile/fenix/pull/21141 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab.
* Fixed RecentTabsListFeatureTest unit test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
1e64f87d67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20881 print if the build is a MozillaOnline
3 years ago
03932cc800
[fenix] Import l10n.
3 years ago
4be9b84c20
[fenix] Dont clip bounds on recently saved bookmarks
3 years ago
c5b2185119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21138 : change EXPECTED_RUNBLOCKING to range.
...
Compared with my local runs, CI sees +1 runBlockingIncrement calls so seems to
take other code paths. As such, we search for a range of rather than a single
value. The main downside I can think of is this could make the test trickier to
debug but we can wait and see if that's a problem in practice before taking
action on it.
3 years ago
d4c2608670
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21138 : re-enable excessive resource use test.
...
This test wasn't running in CI
https://github.com/mozilla-mobile/fenix/issues/20386 so we changed the
CI configuration so that it will. However, the test was then failing so
this is the revision that unignores the test.
I wonder if componentInit count is useful - it seems like it'd cause
more false positives than not - but I figure we can leave it in and see
how it goes.
3 years ago
e7c3145fec
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill
3 years ago
5fe3efeb98
[fenix] Import l10n.
3 years ago
09eb475097
[fenix] Import l10n.
3 years ago
dac9585e2d
[fenix] Import l10n.
3 years ago
ce52e5510b
[fenix] Import l10n.
3 years ago
6c724c7f13
[fenix] Import l10n.
3 years ago
c0e8005c76
[fenix] For 20892 Update connection icons in address bar
3 years ago
193016b662
[fenix] Remove mocked lambdas from AccountSettingsInteractorTest
3 years ago
e9b1f3fb81
[fenix] Add missing androidx.lifecycle dependencies
3 years ago
9865ade3f8
[fenix] Import l10n.
3 years ago
2d6dffe36a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18727 : Exit PiP when launched externally with Intents
3 years ago
dccc1133b1
[fenix] Update Android Components version ( https://github.com/mozilla-mobile/fenix/pull/21109 )
...
* Update Android Components version to 93.0.20210901143120.
* For https://github.com/mozilla-mobile/fenix/issues/21043 - Integrate AC changes
* Fix breaking API changes of RestoreAction
Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
cda4440bad
[fenix] Do not run unit tests in parallel
...
This is to investigate the intermittent mockk class
generation/loading issues. Since we can not reproduce
locally and the failures are intermittent they could
be caused by us running unit tests in parallel.
3 years ago
bde4c0207a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19166 : Increases tab_tray_list bottom padding
...
... to fit snackbar and FAB
3 years ago
b4bf6f22fd
[fenix] Import l10n.
3 years ago
9d12ec623c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21078 - Remove unused creditCardsFeature feature flag
3 years ago
061e5bf6af
[fenix] Include data review for renewed metrics
3 years ago
2d433166a8
[fenix] Remove banner open in app telemetry
3 years ago
edd26c3363
[fenix] Remove search suggestions in private telemetry
3 years ago
4d2c0b9caf
[fenix] Remove user specified search engine telemetry
3 years ago
17ad77ea02
[fenix] Remove private browsing shortcut telemetry
3 years ago
49c3b46145
[fenix] Fix data-review listed for default_browser_changed, toolbar_menu_visible, and toolbar_menu_clicked
3 years ago
5abec1fb15
[fenix] Remove private browsing mode telemetry
3 years ago
1e05446283
[fenix] Remove tip telemetry
3 years ago
83416415b8
[fenix] Remove enable private search suggestions telemetry
3 years ago
49e6325de4
[fenix] Remove open links in private tab telemetry
3 years ago
61d95c4967
[fenix] Remove find in page telemetry
3 years ago
9c5bb84cb1
[fenix] Remove total uri count telemetry
3 years ago
dd398def06
[fenix] Remove about page telemetry
3 years ago
09132f35ac
[fenix] Remove downloads management telemetry
3 years ago
9a432d9f64
[fenix] Remove downloads misc telemetry.
3 years ago
dbf3897680
[fenix] Remove download notification telemetry.
3 years ago
cf2d620e0e
[fenix] Remove master password telemetry.
3 years ago
feb4af320b
[fenix] Renew probes set to expire in September
3 years ago
cc642da2e8
[fenix] Renew probes set to expire in October
3 years ago
41f1202daa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21037 - Add a delete history menu item
...
This removes the existing "Delete history" button in the History in favour of a menu item
3 years ago
938992c39a
[fenix] Add tint to settings icon on Tracking protection panel
3 years ago
acb12761e4
[fenix] Import l10n.
3 years ago
3af7f3dfd4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 update and add missing tabs setting validations
3 years ago
2642dfc203
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20702 : fix tests flakiness
3 years ago
e38ed593d4
[fenix] Enable Android Autofill support in all build types.
3 years ago
1bbf5bda7c
[fenix] Import l10n.
3 years ago
4df5f7f8b9
[fenix] Import l10n.
3 years ago
054f6b5626
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21035 - Refactor HistoryViewInteractor from HistoryView into HistoryInteractor
3 years ago
e619f4b030
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 : added page main menu items tests
3 years ago
690f3e72f5
[fenix] Dedupe history metadata in groups based on url
3 years ago
19c10c3779
[fenix] Update search metric expiration dates ( https://github.com/mozilla-mobile/fenix/pull/21016 )
3 years ago
115cc74bb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 add confirm dialog when turning on/off experiments
3 years ago
38c5617b7e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20871 mark strings for removal
3 years ago
d105e8bc19
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19931 : Add telemetry probes for recent bookmarks on home screen ( https://github.com/mozilla-mobile/fenix/pull/20316 )
...
* Add telemetry probes for recent bookmarks on home screen. Tests for controller.
* Make the events into counters in the metrics ping
Update tests to reflect new metrics
Add data review link for new metrics
Mock new settings for startup metrics tests
Update metrics
Add test for recent bookmark glean events
* Recent bookmarks controller tests
3 years ago
7b7a252ecf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20507 - Inactive tabs telemetry
...
Two new events are added:
- "inactive_tabs_expanded" for when the inactive tabs section is expanded
- "inactive_tabs_collapsed" for when the inactive tabs section is collapsed
For tracking when an inactive tab is opened / closed I've repurposed the
existing tabs tray telemetry (since the functionality uses the same code)
- tabs_tray.opened_existing_tab
- tabs_tray.closed_existing_tab
to support an extra "source" key indicating the feature from which a tab was
opened or closed. The current values for this new key are:
- "Tabs tray" for when a tab was opened/closed from tabs tray
- "Inactive tabs" for when a tab was openes/closed from the Inactive tabs
section of the tabs tray.
3 years ago
785a42edfd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the Kotlin synthetics Lint detector
...
Since all usages of Kotlin synthetics are removed and no such code is generated
anymore there is no need to keep around this Detector anymore.
3 years ago
4466a39727
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the `kotlin-android-extensions` plugin
...
This means no code will be generated by Kotlin Android Extensions for caching
views and also for @Parcelize annotated classes.
As recommended in the official documentation
https://developer.android.com/topic/libraries/view-binding/migration#gradle
we need to switch on using `kotlinx.parcelize.Parcelize` instead of
`import kotlinx.android.parcel.Parcelize`
For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the `kotlin-android-extensions` plugin
This means no code will be generated by Kotlin Android Extensions for caching
views and also for @Parcelize annotated classes.
As recommended in the official documentation
https://developer.android.com/topic/libraries/view-binding/migration#gradle
we need to switch on using `kotlinx.parcelize.Parcelize` instead of
`import kotlinx.android.parcel.Parcelize`
3 years ago
9959334a26
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Finish migrating all synthetics usages
3 years ago
ecae7a61be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20328 - Adds telemetry for recentlyClosed button
...
...from tabsTray, inactiveTabs section.
3 years ago
d689ee206f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20716 : re-enables mainMenuInstallPWATest UI test
3 years ago
eb8aeec73e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20868 , https://github.com/mozilla-mobile/fenix/issues/18764 : Update Tracking Protection UI tests
3 years ago
dd1b4ba5ae
[fenix] Closes 20975: Run metadata cleanup after Megazord.init()
...
This ensures that we do not attempt places initialization before
Megazord.init() finishes, and that touching BrowserStore does not
kick-off places initialization (due to the `cleanup` call being a
side-effect of creating metadata middleware, used as part of the
BrowserStore).
Glean initialization happens before initialize megazord, and it touches
core.store BrowserStore instance, kicking-off places initialization on
an IO thread (due to the cleanup call), which raced megazord
initialization on the main thread.
App init sequence is a bit of a mine-field, so this patch takes the easy
way out and doesn't attempt to re-order initialization sequence. Also,
initializing places as a side-effect of touching BrowserStore was also,
clearly, a bug.
3 years ago
48eff4f831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in add-ons
3 years ago
f826174109
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20586 - Put everything behing a secret setting
...
Not ready for prime-time. Lot of work still to be done.
3 years ago
b1cc91a9ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20586 - Basic Jetpack Compose implementation.
...
This is just the basic skeleton for the feature.
3 years ago
96042fa50a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection icons in quick settings
3 years ago
2adea3fd40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20927 : Replace icons with AC icons.
3 years ago
d457385e79
[fenix] Use armeabi-v7a version code for MozillaOnline builds
3 years ago
06f86c42c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quite the app when turning on/off experiments
3 years ago
7ffaefd3fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove startup timeline probes
3 years ago
d2b9962319
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20945 : Fix failing test in AccountSettingsInteractorTest
3 years ago
eae779d231
[fenix] Speculative fixes intermittent test in DeleteAndQuitTest
3 years ago
b50ecb92b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quit the after removing a study.
3 years ago
4e917c5eac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tabs tray
3 years ago
5b99139048
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `home` from Kotlin synthetics to View Binding.
3 years ago
b38f717c4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `browser` from Kotlin synthetics to View Binding.
3 years ago
c0d03b3d1e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Login Exceptions
3 years ago
36aed742b3
[fenix] Add event ping telemetry for the Baidu top site click
3 years ago
988712dd63
[fenix] Enable recording of history metadata for all builds
...
This allows recording part of history metadata to ride the trains.
The UI features are still guarded by the secret settings flag (or,
enabled on debug builds).
3 years ago
a82a02a9e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20890 when TP is off globally hide TP section on quick settings.
3 years ago
1928220c0d
[fenix] Restore unused string tab_collection_dialog_negative
3 years ago
9268b550c2
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20901 : Do not record viewTime observations when we do not have a set lastAccess
...
The bug here was that we'd try to record `now - 0` as a viewTime delta.
This isn't just an obviously wrong value to record, but it will also
overflow our storage - we'll end up with a value on disk that doesn't
fit into an i32, but HistoryMetadata.total_view_time is i32 in our Rust
struct. Once that happens, reads that touch this bad row will result in
an overflow and a crash.
3 years ago
0a2cdff945
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2783 : Add snackbar to collection deletion
3 years ago
c4bc780c28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20716 - Disables Intermittent failing UI test
3 years ago
b9d7552339
[fenix] metrics.yaml: Add data review URL for Android Autofill metrics
3 years ago
52cb17d12a
[fenix] Update Android Components version
3 years ago
aded72af41
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20864 : Speculative fix for HomeFragmentTest failures
3 years ago
5e0b094e4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tracking protection(2)
3 years ago
c80a53f93e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20824 : use fast service loader for MainDispatcherFactory.
...
For details on the root cause, see the commit. We replaced the similar
proguard rules because:
- the key line was returning false instead of true
- the other line had the same outcome as the written code. I believe it
was a micro-optimization. Since perf seems fine without it, let's
remove it
I benchmarked this change on COLD MAIN first frame. We see an
improvement of 89ms:
- before: 1346ms
- after: 1257ms
3 years ago
a4a1f6ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Share views
3 years ago
179dd793ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Onboarding Tests
3 years ago
33ac87cbd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 use block color on disabled permissions
3 years ago
841b304f0d
[fenix] Import l10n.
3 years ago
591d6744df
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Additional fixes for intermittent failing test
...
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
3 years ago
93f23aa750
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding.
3 years ago
2e60b8d80a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 fix ui tests
3 years ago
2d6dcb814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog
3 years ago
39dc0701a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation
3 years ago
c9575d0d62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR
3 years ago
609acda69c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Use the new "Details" text for navigating to ETP details
3 years ago
ab1e4228c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu.
3 years ago
7d8ca1ec98
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
66192cc136
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add right arrowheader to tracking protection navigators
3 years ago
9bb39fe7b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings
3 years ago
23d57b151f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add navigation from quick settings to tracking protection panel
3 years ago
70d55f4746
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator
3 years ago
0196a85e19
[fenix] Import l10n.
3 years ago
8c5bccf445
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853 : Fix intermittent failing test in HomeFragmentStoreTest
3 years ago
b9c243c0ec
[fenix] Update TabSessionState.createdAt for inactive tabs debugging
3 years ago
d735df1dd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string
3 years ago
7e548348e3
[fenix] Android Autofill: Use AppCompat theme for UnlockActivity.
3 years ago
3dc3db856c
[fenix] Remove duplicated line in TabsSettingsFragment
3 years ago
eb35f06802
[fenix] Use theming in debug screen.
3 years ago
632311b1ea
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168 : Remove intermittent failing test in ToolbarViewTest
...
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.
This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.
It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.
So therefore.. 🔥
3 years ago
d32727eff9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest
3 years ago
14735a61ae
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795 : Speculative fix for intermittent test failures in HomeFragmentTest
...
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
a590fd2b74
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797 : Fix intermittent test failures in ShortcutsSuggestionProviderTest
3 years ago
9b20f9c1c0
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792 : Fix intermittent test failures in QuickSettingsFragmentReducerTest
3 years ago
f2fe9ae61d
[fenix] Filter out test target packages in Flank-x86 ( https://github.com/mozilla-mobile/fenix/pull/20841 )
...
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
3 years ago
fce543516e
[fenix] No issue: move kotlin-allopen outside appVariants loop.
...
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
3 years ago
cc2f37b040
[fenix] Use header20 style on collections to match other home items. Add margin above collections. ( https://github.com/mozilla-mobile/fenix/pull/20633 )
3 years ago
00cb0c74f3
[fenix] Update the description for an inactive tabs string
3 years ago
982dc4410f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets
3 years ago
4082b5eb90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20098 : Allow PB PiP video screenshots
...
...when `Allow screenshots in private browsing` is enabled
3 years ago
620d034134
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes
3 years ago
d4a2d1ac83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments
3 years ago
be0f7d9dcc
[fenix] Disable intermittent tests.
3 years ago
8ff9adb54e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account
3 years ago
f4f6b18cbe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in history screens
3 years ago
c441adb0d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in collections
3 years ago
21fedbf45f
[fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes.
3 years ago
b8f673380f
[fenix] No issue: remove unnecessary robolectric annotations.
...
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.
---
To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt
I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
failureElements = tests.querySelectorAll('.failures');
// TODO: extract the test names
Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt
And undid the changes to the failing files:
for i in $(cat robolectric_not_needed.txt); do git checkout $i; done
Then I removed the import statements on those files:
for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
7273536742
[fenix] For FNXV2-17067: always show home in background behind search dialog ( https://github.com/mozilla-mobile/fenix/pull/20573 )
...
* Navigate to home on toolbar click. Handle back press from search dialog
Update tests to show home behind search dialog. Remove unused test.
Jump back in show all button is clickable behind search dialog
Recently saved bookmarks show all button is clickable behind search dialog
* Add feature flag
* Past explorations show all button is clickable behind search dialog
Handle keyboard in controllers instead of viewholders. Update tests.
Allow collections to be visible behind search dialog
Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard
Verify navigateUp in tests
Adding ignore for flaky UI test
Only resize home behind search dialog
Add ignore for collection intermittent test
Cleanup
3 years ago
33b08b6b83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in downloads screen
3 years ago
dcbd978c73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20425 : Re-add tests for class BookmarksUseCaseTest.
3 years ago
8f3313ad02
[fenix] Start on home UI tests
3 years ago
2120e07768
[fenix] Import l10n.
3 years ago
8c1a00b21c
[fenix] Import l10n.
3 years ago
feb8f5e363
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726 : Fix intermittent failure in AddonsManagementViewTest
3 years ago
0a0af212f0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20718 : Show url if title is missing for inactive tabs
3 years ago
3bfd5d1827
[fenix] Correct search_count telemetry after revert
3 years ago
1612db86c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20723 : Fix credit card management fragment binding
3 years ago
b4ce5abf0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697 : replace mockked lambda in DownloadControllerTest.
...
This is expected to fix the intermittent failure in this test.
3 years ago
13249f7080
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679 : revert allowaccessmodification proguard disabling.
...
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.
This commit reverts the following commits:
Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.
Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
3 years ago
3c66fa4833
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19956 : Add telemetry for tab view setting changes
...
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in https://github.com/mozilla-mobile/fenix/issues/19809 ).
3 years ago
18a51be61c
[fenix] Update Android Components version to 92.0.20210806164329 ( https://github.com/mozilla-mobile/fenix/pull/20722 )
...
Addresses breaking change in ShortcutsSuggestionProvider
3 years ago
6c15482c9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in bookmarks screen
3 years ago
d4ab4f3572
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663 : Make inactive card collapsible
...
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.
In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
3 years ago
75aeb961e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector
...
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
3 years ago
2971cd309d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray
3 years ago
39561f3644
[fenix] External source support
...
Adds handling of information about external referrer (package, category)
when dealing with external intents.
3 years ago
333840f02e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill ( https://github.com/mozilla-mobile/fenix/pull/19548 )"
...
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
3 years ago
cffad4f424
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping ( https://github.com/mozilla-mobile/fenix/pull/19733 )"
...
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
3 years ago
60da5771b7
[fenix] Import l10n.
3 years ago
b583864643
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI
...
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
3 years ago
19767246f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Use CombinedHistorySuggestionProvider for history suggestions
...
This should ensure user is always presented with history results for his
searches.
3 years ago
317bf219d0
[fenix] Import l10n.
3 years ago
cdade5b44a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664 : Do not consider newly created tabs as inactive
3 years ago
cb4a24d6a6
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20674 : Remove elevation from inactive tabs card
3 years ago
5949766c5d
[fenix] Enable Android Autofill in Beta builds.
3 years ago
a710775406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Use View binding in quick settings.
3 years ago
bd036901ae
[fenix] Import l10n.
3 years ago
39ea051a14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19970 [Crash] IllegalStateException when navigating to TP panel
3 years ago
24b4a03d32
[fenix] Fix intermittent test failures in ToolbarViewTest
3 years ago
b901490a1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650 : Revert to manually close tab as default setting
3 years ago
724fb8b60f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Undo Use View binding in quick Settings.
3 years ago
68bef957b5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20461 : remove app_received_intent probe.
3 years ago
6109d61cd7
[fenix] Fix UI tests: SettingsPrivacyTest, DeepLinkTest.
3 years ago
6e4060fa5a
[fenix] Add preference for enabling/disabling Android Autofill from within the app.
3 years ago
7f6cdd491b
[fenix] Add dialog-like theme for AutofillSearchActivity
3 years ago
d0ca64a9a4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631 : remove @Ignore on StorageStats tests.
...
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
3 years ago
4a3576d299
[fenix] Fix intermittent test failures in TabsTouchHelperTest
3 years ago
46a11a3f56
[fenix] Import l10n.
3 years ago
7d59c1f786
[fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest
3 years ago
5272c60934
[fenix] Fix intermittent test failures in DefaultSessionControlControllerTest.
3 years ago
85309f1d25
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627 : replace mocked lambda in HistoryItemMenuTest.
...
This will prevent intermittent failures with Java 11.
3 years ago
e0e46cda2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : disable metrics we don't want to renew.
3 years ago
f3f4526124
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : link to data renewal request.
3 years ago
d23a7639ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : renew perf telemetry probes (August expiry).
...
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
3 years ago
1bad9ad91c
[fenix] No issue: fix glean metrics tests for expired metrics ( https://github.com/mozilla-mobile/fenix/pull/20621 )
...
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.
* Add ignores for performance metrics that have expired.
* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.
* Remove metrics controller from signature and remove in tests
3 years ago
a84d30689d
[fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16396 Fix text contrast ratio on "recently closed tabs"
3 years ago
Mozilla L10n Automation Bot
Jonathan Almeida
Jonathan Almeida
Michael Droettboom
AndiAJ
Roger Yang
Sebastian Kaspari
Oana Horvath
Arturo Mejia
Mayank Agarwal
Mugurell
Michael Comella
Andrei Joltan
Gabriel Luong
xlog-null
Noah Bond
Christian Sadilek
Marc Leclair
Grisha Kruglov
Ben Dean-Kawamura
sunil9211
Elise Richards
MickeyMoz
codrut.topliceanu
Noah Bond
Rohan Maity
Biren-Nayak
Jan-Erik Rediger
Aaron Train
Travis Long
rayanHappy
rxu
bendk
mcarare
czlucius
Mickey Moz
Rohan Maity
Steven Knipe
Vitaly V. Pinchuk
fevziomurtekin