Commit Graph

7232 Commits (a9717da0d30d98cf7891aed88adbf50addcbe6f1)

Author SHA1 Message Date
alberth 4ff755ac90 (svn r17573) -Codechange: NWID_SELECTION containers have a selected widget-plane, and optionally an index in the nested_array. 15 years ago
alberth d54028fde8 (svn r17572) -Codechange: Use the Window::GetWidget() function to access nested widgets through the nested_array. 15 years ago
rubidium 1be2568438 (svn r17571) -Fix [FS#3213] (r17569): town view didn't show the right town in most of the cases 15 years ago
rubidium 310465da07 (svn r17570) -Fix: a number of Doxygen warnings about missing parameters, which were sometimes missing and sometimes just typos 15 years ago
alberth d3577d3d5d (svn r17569) -Codechange: Town view window runs with nested widgets. 15 years ago
translators 58723c4789 (svn r17568) -Update from WebTranslator v3.0:
romanian - 28 changes by kkmic
russian - 7 changes by Lone_Wolf
vietnamese - 53 changes by nglekhoi
15 years ago
rubidium 06e490fadc (svn r17567) -Fix: some doxygen warnings 15 years ago
rubidium 0f370be9aa (svn r17566) -Fix: ai_basestation.hpp.sq linked to the wrong header; it did work though 15 years ago
rubidium e840c983a6 (svn r17563) -Fix: memory leak when viewing the NewGRF settings of a server 15 years ago
rubidium d9519fdf64 (svn r17562) -Fix [FS#2972]: the NewGRF settings of (remote) network games did not get properly updated when the NewGRFs were rescanned causing reading of freed data 15 years ago
smatz 9f4f7a2892 (svn r17561) -Fix: diacritics was missing at few places 15 years ago
translators cb1d50ce59 (svn r17560) -Update from WebTranslator v3.0:
finnish - 94 changes by Tve4
german - 1 changes by dihedral
latvian - 3 changes by LDZ
turkish - 3 changes by niw3
vietnamese - 48 changes by nglekhoi
15 years ago
rubidium afb1217449 (svn r17559) -Fix [FS#3206]: close the "Add NewGRF" window when you close the "NewGRF Settings" window. The add window has a pointer to the settings which means that not deleting it would cause dereferencing an already freed pointer 15 years ago
rubidium 0c2f375230 (svn r17558) -Feature [NewGRF]: callbacks for houses to disable drawing foundations and to disable slope changes, like industry tile callbacks 30 and 3C. 15 years ago
alberth 09371d5561 (svn r17557) -Codechange: Pass left and right edge to DrawOrderString(). 15 years ago
translators 70078f7582 (svn r17555) -Update from WebTranslator v3.0:
czech - 4 changes by SmatZ
hebrew - 47 changes by dnd_man
italian - 1 changes by lorenzodv
russian - 3 changes by Lone_Wolf
vietnamese - 71 changes by nglekhoi
15 years ago
rubidium ac427837de (svn r17553) -Update: some documentation about the callbacks 15 years ago
rubidium 4db98357ea (svn r17552) -Codechange: rename load_unload_time_rem to something more generic as it's used for more than just load/unload. Also add some documentation about where it is used. 15 years ago
rubidium ba1af15b7a (svn r17551) -Fix [FS#3201] (r17222): vehicles waiting for their time table didn't load anymore after their initial load was completed 15 years ago
frosch 8f5622ebad (svn r17550) -Fix (r8973): Aircraft are good enough, don't make them even better. 15 years ago
frosch bd2aa4d6d0 (svn r17549) -Fix (r17128): Distance limit for town to town subsidies got lost. 15 years ago
translators eeff0f2ad5 (svn r17548) -Update from WebTranslator v3.0:
catalan - 2 changes by arnau
simplified_chinese - 1 changes by Gavin
english_US - 1 changes by agenthh
french - 1 changes by glx
greek - 17 changes by fumantsu
hebrew - 55 changes by dnd_man
indonesian - 1 changes by prof
russian - 26 changes by Lone_Wolf
serbian - 1 changes by etran
spanish - 2 changes by Terkhen
vietnamese - 138 changes by nglekhoi
15 years ago
rubidium 335a542722 (svn r17547) -Feature: [NewGRF] Implement callback 145 (custom station rating) 15 years ago
rubidium 3325d91c6e (svn r17546) -Fix (r9617): sign extending of profit calculation didn't work 15 years ago
rubidium 83be7b09ea (svn r17545) -Fix [FS#3202]: [NoAI] AIs had 'infinite' time when running code from the global scope 15 years ago
rubidium 3e3927cfcc (svn r17544) -Fix [FS#3202]: [NoAI] Crash when doing commands in the 'global' scope 15 years ago
rubidium f7f0a567a7 (svn r17543) -Fix [FS#3200]: allegro's sound output was worse than excepted 15 years ago
yexo 6fb7012bc6 (svn r17542) -Fix: don't access variables in the company struct after it has been deleted
-Cleanup: remove some never-used code
15 years ago
frosch bdc86b7280 (svn r17541) -Feature: Filtering in Add-NewGRF dialog. 15 years ago
smatz 2b4458da63 (svn r17540) -Codechange: move functionality of PlaceProc_Town() to FoundTownWindow::OnPlaceObject() 15 years ago
frosch c192bbe800 (svn r17539) -Codechange: Replace a magic number. 15 years ago
frosch 804b40b48c (svn r17538) -Codechange: Rename STR_CONTENT_FILTER_(OSKTITLE|TOOLTIP) for more general usage. 15 years ago
smatz b9852168c0 (svn r17537) -Fix: don't crash while printing gamelog in crash handler if we crashed before while gamelog action was active 15 years ago
translators b4b8089c08 (svn r17536) -Update from WebTranslator v3.0:
english_US - 4 changes by agenthh
hungarian - 3 changes by alyr
russian - 64 changes by Lone_Wolf
vietnamese - 23 changes by nglekhoi
15 years ago
rubidium 989f53b9dd (svn r17535) -Fix: compiling without networking failed; also unhackify the crash logger a bit. 15 years ago
rubidium c2c0f4403e (svn r17534) -Codechange: unify the naming of callback masks/flags 15 years ago
smatz 4a269ce545 (svn r17533) -Fix: missing 'const' 15 years ago
frosch 0e36260337 (svn r17532) -Codechange: Rename several Invalidate functions to SetDirty for more consistency and distinguishability. 15 years ago
rubidium 9a0a14f4a8 (svn r17531) -Fix: wrong @file for ai_basestation.hpp 15 years ago
rubidium 1854c5efec (svn r17530) -Codechange: use QSortT instead of qsort for sorting EngineIDs 15 years ago
translators 6c4cb673ff (svn r17529) -Update from WebTranslator v3.0:
finnish - 81 changes by jpx_
greek - 207 changes by fumantsu
portuguese - 5 changes by SupSuper
vietnamese - 55 changes by nglekhoi
15 years ago
rubidium ca78c69924 (svn r17528) -Codechange: use QSortT instead of qsort for sorting FiosItems 15 years ago
rubidium f0f63077f2 (svn r17527) -Codechange: use QSortT instead of qsort for sorting smallmaps 15 years ago
rubidium fd04d4ed00 (svn r17526) -Codechange: use QSortT instead of qsort for sorting the language list in the network GUI 15 years ago
frosch 263952f557 (svn r17525) -Cleanup: Remove SetWindowDirty(), it is completely covered by other functions already. 15 years ago
rubidium 36739925a2 (svn r17524) -Codechange: use QSortT instead of qsort for sorting NewGRFs 15 years ago
frosch b3fd812eee (svn r17523) -Fix (r17514): InvalidateWindowClasses() only does SetDirty(), which is no longer enough. 15 years ago
frosch 3511a6a7c4 (svn r17522) -Fix: Scroll to selected content after sorting the list and after updating the scrollbar maximum. 15 years ago
rubidium 7fd584a95b (svn r17521) -Change: don't assume that there is always 'another' industry tile after two '0x18' industry tiles 15 years ago
rubidium e620debf2c (svn r17518) -Document: some of the callback 'masks' 15 years ago
rubidium 79f6fde5bf (svn r17515) -Fix [FS#3189]: [Squirrel] In some cases the call stack would not be cleaned up properly during crash handling. Occasionally this causes asserts to be triggered or crashes. 15 years ago
frosch 4317f1a010 (svn r17514) -Codechange: Nestify Add-NewGRF dialog. 15 years ago
translators 6c36447e90 (svn r17513) -Update from WebTranslator v3.0:
catalan - 1 changes by arnau
simplified_chinese - 39 changes by EraserKing
dutch - 18 changes by habell
greek - 55 changes by fumantsu
indonesian - 60 changes by prof
vietnamese - 7 changes by nglekhoi
15 years ago
rubidium 677f510dcc (svn r17512) -Add: some basic information about the loaded AIs in the crash log 15 years ago
frosch d9ece3698a (svn r17511) -Codechange: Simplify ShowNewGRFInfo() by passing 'right' instead of 'width'. 15 years ago
frosch 0867784862 (svn r17510) -Fix [FS#3197]: When loading GRFConfigs from ini file, validate them wrt. duplicate GRF IDs. 15 years ago
rubidium f727662df6 (svn r17509) -Fix [FS#3196]: if building a part fails during cloning, sell what was already cloned instead of leaving it 'for free'
-Fix: make cloning multiheaded trains possible with with 'max - 1' vehicles existing
15 years ago
rubidium 27ad14ee99 (svn r17508) -Fix [FS#3195] (r16859): join station window didn't get updated when stations were removed from the pool 15 years ago
alberth 6e113b0e0b (svn r17507) -Codechange: Make some methods of the OrdersWindow non-static. 15 years ago
rubidium da2008ae23 (svn r17506) -Fix [FS#3191]: signs partly drawn out of the rectangle in 4/8x zoom out. 15 years ago
alberth 2895bb0e36 (svn r17505) -Codechange: WWT_EMPTY is not a special case any more for invalidating widgets. 15 years ago
alberth 029c711732 (svn r17504) -Codechange: un-inlining SetFocusedWidget() as it is not often used. 15 years ago
alberth be7056c2b3 (svn r17503) -Fix (r17502): Save all files before commit. 15 years ago
alberth ed5a0dfaf1 (svn r17502) -Codechange [FS#3184]: Extend QueryStringBaseWindow to support windows with nested widgets (by Terkhen with a few tweaks). 15 years ago
translators 0432b0ac3b (svn r17501) -Update from WebTranslator v3.0:
catalan - 20 changes by arnau
traditional_chinese - 19 changes by josesun
15 years ago
yexo 9218078424 (svn r17500) -Fix (r16502): The wrong value was restored to SetAllowDoCommand possible resulting in an AI that wasn't allowed to do any actions 15 years ago
yexo f38bb4cdb5 (svn r17499) -Fix (r17498): remove 2 unused functions so some compilers stop warning about them 15 years ago
yexo f922a7ca8e (svn r17498) -Add [NoAI]: Enable the squirrel std math library 15 years ago
frosch 254cfda3fc (svn r17497) -Codechange: Macrofy AirportMovingData. 15 years ago
translators 1634b53ae4 (svn r17496) -Update from WebTranslator v3.0:
catalan - 39 changes by arnau
english_US - 2 changes by agenthh
italian - 4 changes by lorenzodv
romanian - 5 changes by kkmic
russian - 3 changes by Lone_Wolf
ukrainian - 42 changes by Madvin
15 years ago
rubidium 91024042ea (svn r17495) -Codechange: replace 'Depot::Get(GetDepotIndex(tile))->index' with GetDepotIndex(tile) 15 years ago
rubidium f93e63fa22 (svn r17494) -Codechange: improve algorithmic complexitiy of Depot::GetByTile from O(n) to O(1) 15 years ago
rubidium 10c3af4642 (svn r17493) -Codechange: store the depot index on the map 15 years ago
rubidium 4fef835e52 (svn r17492) -Codechange: don't store the town index for road depots. 15 years ago
rubidium 4c548cca34 (svn r17491) -Fix [FS#3188]: road vehicles could get lost when the prelimiary destination (for the pathfinder heuristics) is unreachable. 15 years ago
translators 0c797d5bef (svn r17490) -Update from WebTranslator v3.0:
dutch - 47 changes by habell
english_US - 1 changes by agenthh
french - 4 changes by glx
german - 4 changes by Roujin, planetmaker
indonesian - 6 changes by prof
italian - 2 changes by lorenzodv
russian - 1 changes by Lone_Wolf
spanish - 13 changes by Terkhen
turkish - 3 changes by niw3
15 years ago
rubidium 5a8eefc478 (svn r17489) -Fix [FS#3187] (r17471): the tooltip said the inverse of what actually happened 15 years ago
rubidium aeb59f8e19 (svn r17488) -Feature [FS#2339]: add the date to all logging in the (real, not in-game) console if show_date_in_console is set. For dedicated server binaries the default is 'on', for the rest it is 'off'. 15 years ago
rubidium 69a13877c3 (svn r17487) -Fix: silence some MSVC warnings 15 years ago
rubidium a8975e9e72 (svn r17486) -Add [NoAI]: a vehicle list for all vehicle that are ordered to a specific depot 15 years ago
rubidium 97d1314a47 (svn r17485) -Change [FS2459]: make the performance ratings harder to exploit; only count profitable vehicles and recently serviced stations. 15 years ago
rubidium 2f2a6279da (svn r17484) -Fix: squirrel export didn't like one of the casts 15 years ago
yexo 39286cd325 (svn r17483) -Fix (r17405): when an aircraft starts flying in circles make it turn in the correct direction first before continuing 15 years ago
yexo 9432d16d8d (svn r17482) -Fix (r17405): helicopters were not able to land anymore on the intercontinental airport 15 years ago
rubidium 8c09d46e96 (svn r17481) -Fix (r16998): in cases where the northern most tile of an airport-to-build didn't touch the station you wanted it to join, but another part did, it wouldn't join the airport to the existing station 15 years ago
yexo bed4415d8d (svn r17480) -Fix (r17405): fast aircraft could get stuck flyin gin circles trying to reach a certain point 15 years ago
rubidium 00b147eb92 (svn r17479) -Fix: silence compile warning that's only triggered when you're using a broken iconv. 15 years ago
smatz 427690be22 (svn r17478) -Document [NoAI]: descibe changes in subsidy logic in AI changelog 15 years ago
translators e8810a6f4c (svn r17477) -Update from WebTranslator v3.0:
afrikaans - 36 changes by Maccie123
catalan - 2 changes by arnau
simplified_chinese - 1 changes by Gavin
english_US - 115 changes by agenthh
french - 2 changes by glx
german - 2 changes by planetmaker
hebrew - 77 changes by dnd_man
indonesian - 2 changes by prof
italian - 33 changes by lorenzodv
portuguese - 32 changes by SupSuper
russian - 6 changes by Lone_Wolf
serbian - 1 changes by etran
spanish - 11 changes by Terkhen
15 years ago
glx 0ab291391e (svn r17475) -Codechange: show path to crash.log and crash.dmp in crash window. Also tells the user where crash.sav is when saving succeeded. 15 years ago
rubidium ec00da379e (svn r17473) -Codechange: use the post destructor for destroying companies too instead of complicating the graph GUI invalidate code. 15 years ago
rubidium 6b25288ba1 (svn r17472) -Fix [FS#3182]: industry list was rebuilt too early during industry removal causing the removed industry to be still in the list after removal 15 years ago
rubidium 08d9873001 (svn r17471) -Change: when removing a station or waypoint keep the rail unless Ctrl is pressed. This makes the behaviour consistent between the two. 15 years ago
smatz ebe2bc0a02 (svn r17470) -Fix (r17460): possible crash when overbuiling rail by station 15 years ago
rubidium 8a3386bb7a (svn r17469) -Change: make the AI compatability wrapper not whine about deprecation (yet), but make it clear that the wrapper is running and what (slight) changes there are w.r.t. to 0.7. 15 years ago
rubidium 0153e7a211 (svn r17467) -Change: show the client id in join messages at the server (patch by dihedral) 15 years ago
rubidium 2aa84f7973 (svn r17466) -Feature: reconnect console command (based on patch of bilbo) 15 years ago
smatz 17993769c0 (svn r17465) -Codechange: use builtin static_assert() for assert_compile() if available 15 years ago
smatz 4c342c6f76 (svn r17464) -Codechange: use C++0x mode when compiling with gcc >= 4.3 or icc >= 11.0 15 years ago
frosch bb5a31faab (svn r17463) -Change (r17453): Retrigger the abort signal after writing the crashlog, so the next one can catch it again (e.g. to write a core dump). 15 years ago
rubidium 441297d0f2 (svn r17461) -Document: that a certain compiler warning when compiled without asserts in gcc 4.4+ isn't our fault but GCC's. Includes a reference to the appropriate GCC bug report 15 years ago
rubidium c631790b6f (svn r17460) -Feature: allow building rail stations over existing rail without signals but will upgrade normal rail to electrified rail if necessary (based on patch by laurijh) 15 years ago
translators 88d610c219 (svn r17458) -Update from WebTranslator v3.0:
simplified_chinese - 1 changes by Gavin
french - 28 changes by glx
german - 16 changes by Roujin, dihedral
hebrew - 77 changes by dnd_man
italian - 3 changes by lorenzodv
russian - 29 changes by Lone_Wolf
serbian - 5 changes by etran
spanish - 39 changes by Terkhen
15 years ago
yexo d384908d56 (svn r17455) -Codechange: use sprite names instead of magic numbers in table/clear_land.h and change some names 15 years ago
rubidium a595d3f8c3 (svn r17453) -Add: crash logger for all Unixy OSes; should work for all, but I don't have all exotic machines so it might break compilation on the more exotic configurations 15 years ago
rubidium 4d75bebbe4 (svn r17452) -Fix (r17450): emergency savegames weren't rejected by the crash logger anymore 15 years ago
smatz 0abc1b914e (svn r17451) -Fix (r17442): loading of TTO/TTD savegames failed 15 years ago
rubidium 1d7619fdb5 (svn r17450) -Codechange: refactor the windows crash logger so parts of it can be reused by other crash logger implementations 15 years ago
rubidium ab935f3085 (svn r17449) -Fix (r17436): MSVC compile warning about comparing signed and unsigned values 15 years ago
rubidium dd88fe5e6e (svn r17448) -Change [FS#2997]: buy vehicles instead of building them; makes it consistent with selling. Based on a patch by planetmaker 15 years ago
rubidium 251573775a (svn r17447) -Codechange: rename a local variable so it doesn't collide with the name of a global function 15 years ago
rubidium f660dd7109 (svn r17446) -Codechange: rename BUILD with BUY for strings that are about building (in the future buying) vehicles. 15 years ago
smatz 2fafa87aa1 (svn r17445) -Fix (r17318): force resort after changing sort type in the industry list window 15 years ago
rubidium 33e1a11aa9 (svn r17444) -Fix [FS#3173]: when building roads isn't allowed for town, then don't build the initial piece either 15 years ago
rubidium 389e1bdfbe (svn r17443) -Fix (r17442): clear the depot tile after removing the depot in all cases instead of only for ships; makes removing road/rail depots not crash :) 15 years ago
rubidium 6bdef071d6 (svn r17442) -Fix [FS#3180]: destruction of depots didn't remove any vehicle lists related to the depot, causing windows pointing to deleted depots and (thus) crashes 15 years ago
rubidium 66b2bf3218 (svn r17441) -Fix (r16900): close the vehicle list of the vehicle type that visits the waypoint instead of for all vehicle types 15 years ago
rubidium 7a1ffc6501 (svn r17440) -Fix [FS#3179] (r17375): long scrollbars would scroll when that was not intended. They would also not properly mark the window dirty. 15 years ago
smatz 5d622fd840 (svn r17439) -Fix (r17436): you weren't paid for cargo delivered to houses and headquarters anymore 15 years ago
rubidium ef42e87e31 (svn r17438) -Fix (r17428): ofcourse some part of the OSX port would be forgotten due to it being so much different than the rest :( 15 years ago
smatz 587ae07799 (svn r17437) -Change: don't accept cargo produced in the same industry (generalise and improve the check used only for valuables) 15 years ago
smatz 7c978ce5cd (svn r17436) -Change: pay only for cargo actually delivered, not for all cargo unloaded at station (can differ with 'stockpiling' industries) 15 years ago
frosch d7bf8b74c7 (svn r17435) -Codechange: Move _cargo_payment_rates[] to CargoSpec::current_payment. 15 years ago
frosch 64f5f1d02c (svn r17433) -Codechange: Store cumulated inflation in savegame and compute all prices from that instead of storing all prices separately.
Note: Savegame conversion computes the inflation from max loan. Prices from modified savegames will get lost. TTO savegames will also behave slightly different.
-Change: NewGRF price modifiers now take effect everytime when loading NewGRFs instead of once on gamestart.
15 years ago
translators d403ae78ca (svn r17432) -Update from WebTranslator v3.0:
catalan - 21 changes by arnau
simplified_chinese - 4 changes by Gavin
danish - 7 changes by silentStatic
dutch - 6 changes by Bart
hebrew - 47 changes by dnd_man
korean - 18 changes by darkhasa
15 years ago
smatz 7dd7f622cd (svn r17431) -Fix (r16735): oldloader wasn't updated 15 years ago
smatz d0beb1721e (svn r17429) -Fix (r16378): conversion of TTO/TTD savegames failed when vehicle 0 was a wagon 15 years ago
rubidium ad201e5a00 (svn r17428) -Codechange: add a function to get the name of a driver 15 years ago
alberth 3c1aa02560 (svn r17427) -Codechange: Removing some unneeded widget parts (for reduced compilation time). 15 years ago
smatz 6572bce9c1 (svn r17426) -Fix (r1): economy recession would never end when economy is set to Steady while in recession 15 years ago
translators ddc4a3035c (svn r17425) -Update from WebTranslator v3.0:
arabic_egypt - 7 changes by kasakg
catalan - 3 changes by arnau
traditional_chinese - 2 changes by josesun
french - 4 changes by glx
indonesian - 5 changes by prof
italian - 4 changes by lorenzodv
spanish - 4 changes by Terkhen
turkish - 2 changes by niw3
urdu - 4 changes by yasirniazkhan
15 years ago
alberth d5bf1cc118 (svn r17424) -Change: Unify 'list is empty' strings of the windows to '- None -'. 15 years ago
alberth a76da0e36a (svn r17423) -Fix [FS#3174]: Show '- None -' with empty town or industry list, and use that text in the size computation as well. 15 years ago
alberth 6dfe5909dc (svn r17422) -Codechange: Remove magic constants and compute vertical minimal size of the sign list window. 15 years ago
alberth aa0abf9c91 (svn r17421) -Fix (r17418): Don't output debug information in signs list. 15 years ago
smatz dc73d5432d (svn r17420) -Codechange: replace assert() by assert_compile() where possible 15 years ago
yexo d3b8de0162 (svn r17419) -Fix (r-old, r16378): the index of orders loaded from old savegames was owerwritten with an unitialized value, causing asserts. The issue has present for a long time but only since the new pool system did it trigger a (correct) assert 15 years ago
alberth 6352a5481d (svn r17418) -Codechange [FS#3144]: Signs list window uses nested widget tree (mostly by Nickman). 15 years ago
rubidium 06d4507f5f (svn r17416) -Codechange: move the build date/time 'determination' to rev.cpp as that's the file most likely to be regularly recompiled 15 years ago
yexo 3cfb59b5b9 (svn r17415) -Change: make sure aircraft don't move while turning as long as they are on the ground. This prevents a lot of unnecesary turns when leaving terminals 15 years ago
rubidium f3372f6bc1 (svn r17414) -Codechange: only send/read the number of bits that can be actually useful when building industries 15 years ago
rubidium ebe53440be (svn r17413) -Fix: assert when trying to build an invalid industry type it did 15 years ago
translators 300e8b4343 (svn r17412) -Update from WebTranslator v3.0:
catalan - 50 changes by arnau
estonian - 23 changes by KSiimson
lithuanian - 7 changes by mtxd
portuguese - 46 changes by SupSuper
russian - 2 changes by Lone_Wolf
15 years ago
rubidium 3a0b63d4bf (svn r17411) -Codechange: silence an ICC compile warning 15 years ago
rubidium fab411abdc (svn r17410) -Codechange: use the same define for determining whether windows does crash reports instead of using several that aren't necessarily equal 15 years ago
rubidium 22192d96c2 (svn r17409) -Codechange: split the crash log and other windows 'glue' code 15 years ago
glx 042391ce63 (svn r17408) -Codechange: remove unused win32 stuff 15 years ago
translators c4e7e37919 (svn r17406) -Update from WebTranslator v3.0:
hungarian - 2 changes by alyr
15 years ago
yexo d963a44d3a (svn r17405) -Fix (r100): aircraft shouldn't be allowed to make turns bigger then 45 degrees while in flight 15 years ago
rubidium 684706b6b0 (svn r17404) -Change (r17379): silence gcc warning caused by inlining of a virtual function 15 years ago