Commit Graph

6437 Commits (86f80f265264b0f78e1a25eea157a9db14defd07)

Author SHA1 Message Date
Gabriel Luong bfce9bc796 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A 3 years ago
Gabriel Luong a8cdbb4524 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF 3 years ago
Gabriel Luong a63441e402 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB 3 years ago
Gabriel Luong c07d13ba2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042 3 years ago
Gabriel Luong 648f3261c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1 3 years ago
Gabriel Luong d50ff294a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5 3 years ago
Gabriel Luong ebcc1024ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF 3 years ago
Gabriel Luong 98c315c7e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000 3 years ago
Gabriel Luong d51e2df39a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4 3 years ago
Mugurell d7521f168e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list 3 years ago
Mozilla L10n Automation Bot 0a5ba09d26 [fenix] Import l10n. 3 years ago
Mugurell aabd1999ee [fenix] CI for 21827 (https://github.com/mozilla-mobile/fenix/pull/22004)
* Remove redundant calls to setHasOptionsMenu(false)

Fix memory leaks for credit card and login fragments

* Fixes:

Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt

* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
Mozilla L10n Automation Bot 906b7a168c [fenix] Import l10n. 3 years ago
Arturo Mejia 9d3d9b3421 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI 3 years ago
AndiAJ c1c42385c4 [fenix] Improve tabsSettingsMenuItemsTest UI test coverage 3 years ago
Mozilla L10n Automation Bot bee0854156 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 70919737fd [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 952ba35095 [fenix] Import l10n. 3 years ago
Roger Yang 1647e4f613 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893: Keep search group when second to last search term tab is removed 3 years ago
Mozilla L10n Automation Bot 299406fc89 [fenix] Import l10n. 3 years ago
Christian Sadilek 09d1c997d8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944: Top sites rendered slowly on first load of HomeFragment 3 years ago
Marc Leclair b7a03ea6d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: linting fixes
For https://github.com/mozilla-mobile/fenix/issues/21700: nit fixes
3 years ago
Marc Leclair c261feb602 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Added option to open in browser instead of automatically doing it 3 years ago
Marc Leclair c558e11cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: fixed comments 3 years ago
Marc Leclair 60fa679e9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Created benchmark script runner and edited benchmark gradle file 3 years ago
Jonathan Almeida c380d1e622 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910: Fix intermittent failures in SelectTabUseCaseWrapperTest 3 years ago
Grisha Kruglov 997fd9ba64 [fenix] Do less work while navigating Logins views
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:

- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
  `list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
  view
3 years ago
Grisha Kruglov 5372f1bcca [fenix] Make linters happy 3 years ago
Ben Dean-Kawamura 84773fa9a2 [fenix] Register the logins key provider
This is required for sync to work
3 years ago
Ben Dean-Kawamura 204ad8834d [fenix] Updating Fenix to work with the new logins API
Switched to always using `Login` instead of the `SavedPassword` alias.

Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`.  This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.

Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`.  This simplifies the error handling a
bit.

Refactored dupe-checking code to use findLoginToUpdate()

Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method.  I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104.  I would love to address https://github.com/mozilla-mobile/fenix/issues/24102,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
Arturo Mejia 0672471708 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section 3 years ago
AndiAJ c8d89a3bba [fenix] Fix for ambiguous tabstray_title and with text matcher for audio page 3 years ago
AndiAJ 45bdd68df1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test 3 years ago
Jonathan Almeida f5fa9d4217 [fenix] No issue: Always show Make inactive for debug builds 3 years ago
Gabriel Luong fa4b9996c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20 3 years ago
Roger Yang 1e84ef3843 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Add shadow to recent bookmarks section 3 years ago
Mozilla L10n Automation Bot ac7e445eb0 [fenix] Import l10n. 3 years ago
Roger Yang ed3560d1b9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917: Update pocket stories card elevation to match other cards 3 years ago
Jonathan Almeida 18a8788812 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707: Correct search grouping logic in extensions
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.

The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.

Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
Gabriel Luong cb7cc7a7eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources 3 years ago
Grisha Kruglov 7efdddcaeb [fenix] Fix up HistoryMetadataController tests 3 years ago
Grisha Kruglov eef2ad800a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.

This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).

This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.

After this patch, we:
 - dispatch two actions (on browserstore, on homefragmentstore) which
   remove the search groups from any relevant in-memory state; any UI bound to
   this state will be automatically "refreshed"
 - no longer navigate as part of the remove action, so the UI doesn't
   move and removal happens "in-place"
3 years ago
Christian Sadilek 0751190582 [fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
Upgrades to A-C 95.0.20211013154351
3 years ago
Jonathan Almeida 4fee8036a0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Remove rotation; rely on state activated
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
sunil9211 45330287b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17393: Dead code removed around Delete downloads 3 years ago
AndiAJ 7638040a3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest 3 years ago
Arturo Mejia 0658de464f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt 3 years ago
AndiAJ 1bb5f1479d [fenix] Disable editCustomSearchEngineTest UI test 3 years ago
Arturo Mejia d6ae910c74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK. 3 years ago
AndiAJ 6a7c42a398 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test 3 years ago
AndiAJ f0091a768c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test 3 years ago
Mugurell ec442f575f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings 3 years ago
AndiAJ 7f9dab5654 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest 3 years ago
Oana Horvath 3ea7755592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005: fixed ETP status info display 3 years ago
Elise Richards 897aa4b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21522: Wrap section titles on home 3 years ago
Elise Richards 86029b181c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew fission metrics expiring in December 3 years ago
Roger Yang c7232a0bdb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Stop using internally stored tabs list in adapters 3 years ago
Mugurell f10d226f92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
To get smaller shadows.
3 years ago
Mugurell cde1c3b911 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates. 3 years ago
Mugurell e22e33c3c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake. 3 years ago
Christian Sadilek b916fc4a85 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437: Fix default of start_on_home setting in UI 3 years ago
Gabriel Luong ff62ffe70a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section 3 years ago
Jonathan Almeida d13f0ef797 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Reverse chevron for inactive tabs 3 years ago
MickeyMoz 16ed26781d [fenix] Update Android Components version to 95.0.20211008105820. 3 years ago
AndiAJ aa6387809d [fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests 3 years ago
AndiAJ 153bfcce38 [fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests 3 years ago
AndiAJ 3317d98b34 [fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description 3 years ago
AndiAJ 7dd7b2e5b2 [fenix] Fix for ambiguous tabstray_title and with text 3 years ago
AndiAJ d6755b5580 [fenix] Fix for ambiguous tabstray_close 3 years ago
AndiAJ 75606a8786 [fenix] Fix for ambiguous tab_item 3 years ago
codrut.topliceanu 822775eb9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash 3 years ago
Jonathan Almeida 363e563fc7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Move submitList calls into TabsAdapter
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Noah Bond 39a3aacc78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings 3 years ago
Christian Sadilek d73ea2cf98 [fenix] Enable pocket stories in CA 3 years ago
Arturo Mejia 185121606c [fenix] Prepare nimbus features default values for release 95 3 years ago
Rohan Maity 2fc70778a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20579: Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode 3 years ago
Arturo Mejia a4fcc93d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience 3 years ago
Mugurell e6a73b5118 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry 3 years ago
Michael Comella 257ae4b118 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424: add marker for StrictMode.resetAfter.
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
Gabriel Luong e3b2309ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol 3 years ago
Noah Bond b772f6d080 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen (https://github.com/mozilla-mobile/fenix/pull/21722)
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen

* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text

* PR: Fixed lint warning. Reverted preference keys

* PR: added ignore for UI test

* PR: Added ignore for UI test
3 years ago
Roger Yang 259b2e5d30 [fenix] No issue: Update Pocket categories spacing to 16dp. 3 years ago
Sebastian Kaspari a4e21f4fbb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102: Set compileSdkVersion to 31. 3 years ago
Roger Yang c9d8e826ca [fenix] No issue: Small layout update for Pocket Stories 3 years ago
Gabriel Luong 398bdac5aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size 3 years ago
Sebastian Kaspari e487bc6f59 [fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 3 years ago
Arturo Mejia 3e01e9df25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 3 years ago
Arturo Mejia f4f7c1b0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: disabled the homescreen onboarding dialog. 3 years ago
Roger Yang 2594eac89e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Update design for jump back in section and recently bookmarked section 3 years ago
codrut.topliceanu bdc54a1465 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
Arturo Mejia 622e713c07 [fenix] Update feature flags for 94. 3 years ago
AndiAJ 09c8890055 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test 3 years ago
Mugurell 5baa97270c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links 3 years ago
codrut.topliceanu f372c5c69f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup 3 years ago
Mugurell e606d8c42a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
Added from the ViewHolders, the same as for XML Views.
3 years ago
Mugurell dc66fea1e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items 3 years ago
Mugurell 07d08eb655 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description 3 years ago
Mugurell 8f6a6d0980 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items 3 years ago
Mugurell 11b92bbd99 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding 3 years ago
Jonathan Almeida 2e597529c8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582: Use ThumbnailStorage in recent tabs on home 3 years ago
Gabriel Luong fde5b755e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited 3 years ago
Gabriel Luong 8a78101fc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches 3 years ago
Jonathan Almeida 33cf85203a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642: Remove in-progress media tab from homescreen 3 years ago
Christian Sadilek 5385b96abe [fenix] Move tabs out of search group if direct load occurs
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
Elise Richards 3db298543e [fenix] CI for Fix description for home_screen_displayed metric (https://github.com/mozilla-mobile/fenix/pull/21697)
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Elise Richards 3631014159 [fenix] CI for Docs: Add extra context to events.browser_menu_action (https://github.com/mozilla-mobile/fenix/pull/21696)
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
Gabriel Luong efab5cbb1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions 3 years ago
Jonathan Almeida 3d69371557 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671: Remove Recently Closed from Inactive Tabs 3 years ago
Mugurell 7e65b07930 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
Mugurell 6261e570c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
Mugurell 4f4586d85f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
AndiAJ 7b031b0504 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test 3 years ago
Jonathan Almeida 884c8c2224 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576: Hide 'Other' title when there are no search groups 3 years ago
Mugurell 20f07022d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties 3 years ago
Arturo Mejia 8a4bb26526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation 3 years ago
Arturo Mejia 21480b89ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in Contextual Hints 3 years ago
Jonathan Almeida 51000bcfa4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632: Correct inactive tabs survey string (https://github.com/mozilla-mobile/fenix/pull/21669) 3 years ago
Christian Sadilek c1f2c33a76 [fenix] Make search term grouping tolerant to (parent tab) navigation
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Elise Richards d70d0610d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21648: match Pocket sections on home to designs 3 years ago
Jonathan Almeida 0c5285cf05 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641: Do not add a group of only one tab 3 years ago
Elise Richards ad1cff2300 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21653: pre-land section title for tab preferences 3 years ago
Noah Bond 4f07d1a40f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups (https://github.com/mozilla-mobile/fenix/pull/21615)
* For https://github.com/mozilla-mobile/fenix/issues/21360  - Added toggle for search term tab groups

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Elise Richards f12124b948 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21646: Update section titles and customize button name on home 3 years ago
Elise Richards b9f5e56c37 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (https://github.com/mozilla-mobile/fenix/pull/21645) 3 years ago
Noah Bond 44f1f679e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message (https://github.com/mozilla-mobile/fenix/pull/21636)
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
3 years ago
Gabriel Luong 33381f78f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey 3 years ago
Biren-Nayak bd610d394f [fenix] For https://github.com/mozilla-mobile/fenix/issues/16437: Remove unnecessary space for tracking protection exceptions 3 years ago
Mugurell 4e5047d203 [fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions. 3 years ago
Christian Sadilek 1d537cb332 [fenix] Allow opening pocket stories when search dialog is active 3 years ago
Oana Horvath 1f628f8e52 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540, https://github.com/mozilla-mobile/fenix/issues/21620: disables failing UI tests 3 years ago
Oana Horvath 4967527781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21441, https://github.com/mozilla-mobile/fenix/issues/21477, https://github.com/mozilla-mobile/fenix/issues/21500, https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476, https://github.com/mozilla-mobile/fenix/issues/21474: retry dismissing the search bar 3 years ago
Roger Yang 1da6397453 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610: Update Strings for Tab Settings 3 years ago
Mozilla L10n Automation Bot 2311ac81df [fenix] Import l10n. 3 years ago
Arturo Mejia 5e57ece039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in contextual hint text 3 years ago
Roger Yang 1f11b81bc4 [fenix] No issue: Make sure jump back in group always have more than one tab 3 years ago
Gabriel Luong 4d23db624f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards dc1e5e640e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21287: long press menu on recently visited homescreen groups 3 years ago
Arturo Mejia e1a2b9ccfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21608: Update strings for home screen dialog features 3 years ago
Grisha Kruglov 485ca898f2 [fenix] Do not show home screen behind search if we have search terms
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
Jan-Erik Rediger 0a08c61e8d [fenix] Don't manually exclude glean-native
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
3 years ago
Noah Bond f2b7eea088 [fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524)
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
3 years ago
Mugurell 4fac910adf [fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories 3 years ago
Mugurell 92bc5e93b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
3 years ago
Aaron Train e7b2578a5a [fenix] No issue: Fix AssertionError in openThreeDotMenu
fix: ktlint
3 years ago
AndiAJ c7658e352d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test 3 years ago
Michael Comella e7077466ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: suppress MaxLineLength in Fact.toEvent.
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
3 years ago
Michael Comella d0ceaf7a7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: remove allocations in Fact.toEvent.
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
3 years ago
Michael Comella 08a11127aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change `when (condition) {` `when {` in Fact.toEvent.
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
3 years ago
Michael Comella 32c8709148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: add partial test for existing factToEvent code.
When we refactor, this will help ensure we've done it correctly.
3 years ago
codrut.topliceanu ed55813676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs 3 years ago
Mozilla L10n Automation Bot 738e7b68d5 [fenix] Import l10n. 3 years ago
Elise Richards 8a77a20614 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: Move the homescreen onboarding card behind a feature flag 3 years ago
Mugurell ad0f428f39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu 3 years ago
Mugurell 08a71a5366 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
Andrei Joltan 710a94b9ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test (https://github.com/mozilla-mobile/fenix/pull/21563)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Roger Yang c0c59f266b [fenix] No issue: Improve rendering of jump back in 3 years ago
AndiAJ 7ed672d7ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test 3 years ago
Oana Horvath 005d0f01a3 [fenix] Fixed verifyAboutFirefoxPreview test according with new steps 3 years ago
Oana Horvath 01e865fee0 [fenix] Fixed disabled UI test openExternalLinksInPrivateTest 3 years ago
Roger Yang 55da682e79 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552: Remove Extra Subtitle In Jump Back In Item 3 years ago
Roger Yang f90fd65ccd [fenix] Fix recent tabs intermittent tests (https://github.com/mozilla-mobile/fenix/pull/21557)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Elise Richards b777fa32ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/21339: update styles for homescreen show all buttons and jump back in spacing (https://github.com/mozilla-mobile/fenix/pull/21342)
For https://github.com/mozilla-mobile/fenix/issues/21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell 219561d304 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown 3 years ago
Christian Sadilek 4702a66203 [fenix] Do not capture search terms when user navigates away via app (https://github.com/mozilla-mobile/fenix/pull/21527)
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
AndiAJ f4a38f0a65 [fenix] Delete browsing data tests UI tests 3 years ago
AndiAJ c1d3d97cc8 [fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work 3 years ago
Elise Richards 32d6ee0dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: renewing performance awesomebar metrics (https://github.com/mozilla-mobile/fenix/pull/21315) 3 years ago
Roger Yang f65770a34f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451: Add active search term tab groups on home 3 years ago
Arturo Mejia c4eb7ea28b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections 3 years ago
codrut.topliceanu 6da619deb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding 3 years ago
AndiAJ 012b854d69 [fenix] Fix disabled shortcutButtonTest UI test 3 years ago
Mugurell d701a81103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Add categories support 3 years ago
Mugurell c37f1e550b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Cleanup
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
Mozilla L10n Automation Bot 5a5507b490 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot f5588635a2 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 9dd6d98748 [fenix] Import l10n. 3 years ago
codrut.topliceanu 7ea5cdbe39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21087: Updates Recently Saved design 3 years ago
Christian Sadilek c9e1bfe3dc [fenix] Fix mapping between history visits and groups to use createdAt
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
Aaron Train 7f17484989 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441: Fix changeAccessibiltySettings 3 years ago
Jonathan Almeida d7c1238dac [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366: Speculative fix for failing test in TitleHeaderBindingTest 3 years ago
Christian Sadilek a6a6b6f257 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893: Dedupe urls/site in history groups 3 years ago
Gabriel Luong cb4b5fc613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 3 years ago
Oana Horvath bc452b6adc [fenix] For https://github.com/mozilla-mobile/fenix/issues/17847: adding back editCustomSearchEngineTest UI test 3 years ago
AndiAJ cc65e13b50 [fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 3 years ago
AndiAJ 8976e193d9 [fenix] Fix for disabled saveLoginFromPromptTest 3 years ago
Mozilla L10n Automation Bot ba990dd118 [fenix] Import l10n. 3 years ago
Gabriel Luong e3bc494414 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 3 years ago
Arturo Mejia e87af643cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen 3 years ago
Oana Horvath 15a3e30bf0 [fenix] No issue: re-enabled swipeToSwitchTabTest 3 years ago
Travis Long 023612b87d [fenix] Fix logic so `isFirstRun` can be called multiple times on first run 3 years ago
Travis Long b4886fe546 [fenix] [SDK-344] Pass in first-run information to Nimbus for targeting 3 years ago
Gabriel Luong 450055a729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder 3 years ago
Aaron Train 4a6c5b8296 [fenix] Various UI test fixes and disabling of intermittents 3 years ago
Sebastian Kaspari 10f5aa228b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Refactor UI tests accessing awesomebar suggestions. 3 years ago
Sebastian Kaspari 74500adfb5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Replace BrowserAwesomeBar view with AwesomeBar() composable. 3 years ago
Gabriel Luong bc30e53e5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case 3 years ago
Gabriel Luong 793ceb8e28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history 3 years ago
AndiAJ 2b55e561fb [fenix] Exit onboarding tour UI tests 3 years ago
Mozilla L10n Automation Bot 13ce5a86bd [fenix] Import l10n. 3 years ago
Michael Comella 275ac7ad5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21126: process performancetest intent for AC too. 3 years ago
rayanHappy 1b6c555758 [fenix] Fix QR scan button not showing up when choosing a RTL language 3 years ago
Arturo Mejia c3df9a26d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen 3 years ago
Christian Sadilek e18fbdfbfc [fenix] Make sure to only record view time once for a given tab access
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Mozilla L10n Automation Bot 16f3396473 [fenix] Import l10n. 3 years ago
Elise Richards d387f7281c [fenix] No issue: remove escape chars on add logins string 3 years ago
Grisha Kruglov 6297f2cce9 [fenix] Use UpdateUrlAction to record viewTime observations
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.

This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.

The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.

Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
3 years ago
Elise Richards 48c0d7faee [fenix] For https://github.com/mozilla-mobile/fenix/issues/21337: rename recently saved section on home 3 years ago
Christian Sadilek 473f671f1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21388: Only parse clipboard content when search fragment is attached 3 years ago
Jonathan Almeida 9d6367a607 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21366: Fix intermittent test failure in TitleHeaderBindingTest 3 years ago
AndiAJ 0884f54fe8 [fenix] Improve coverage for verifyAboutFirefoxPreview 3 years ago
Mozilla L10n Automation Bot 1ae41010df [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 530d6a0cf8 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 1f0efff72e [fenix] Import l10n. 3 years ago
Michael Comella 9c2e6eee78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21296: add ProfilerMarkers.addForDispatchTouchEvent. 3 years ago
Michael Comella 49294996e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration markers for HomeActivity Create/Start.
We only instrument these methods because they're the only ones that
noticeably long running in the current implementation.
3 years ago
Michael Comella 4a132b958b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration marker for IntentReceiverActivity.onCreate.
We only instrument onCreate because it's the only one with an
implementation.

While declaring this as a function that accepts a lambda is less
fragile, we've previously had issues with it such as suspected memory
leaks when used for telemetry. Therefore, we go with the simpler
approach.
3 years ago
Michael Comella f53adc5b12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add markers for all activity lifecycle callbacks.
We implement these all in the same track because between it'd create a
lot noise between this and fragment lifecycle callbacks.
3 years ago
Roger Yang 21c8f3d1a0 [fenix] Update tabs tray title header string comment to clarify what it does. 3 years ago
Michael Comella 8d5a7606f4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21335: return self instead of mock in FenixSnackbarKtTest.
This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.

Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.

See d396c9eb41298cc07fbf136f1de971010bc45d97 for a prior attempt to
address the intermittents in this class.
3 years ago
Jonathan Almeida c2d385f142 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fixes empty tray visibility logic
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Sebastian Kaspari b239d7d934 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291: SearchDialogFragment: Get URL from clipboard once and not for every state update 3 years ago
Roger Yang 02cbf2953f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section (https://github.com/mozilla-mobile/fenix/pull/21177)
* For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section in tabs tray

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Scroll to selected tab + various tab fixes for groupings

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fix failing test

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Mozilla L10n Automation Bot 47805dc6bb [fenix] Import l10n. 3 years ago
Arturo Mejia 96e083e5b3 [fenix] Update strings comments 3 years ago
Michael Comella 336d681451 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: add profiler markers on global layout. 3 years ago
Michael Comella 595a81aec2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: set up HomeActivityBinding the recommended way.
The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
3 years ago
Michael Comella 6e63dce89d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: remove outdated comment regarding async nav graph. 3 years ago
Michael Comella 2dc9cfec20 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18102: remove intermittent failing App onCreate duration measurement test.
The test as it exists relies on the robolectric lifecycle, which is hard
to predict, so it doesn't seem worth fixing the test. Writing the test
any other way would require excessive mocking, which also seems
impractical.
3 years ago
rxu e78754d598 [fenix] Add default topsite 58 for MozillaOnline builds 3 years ago
Arturo Mejia 5ce4a31be5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen. 3 years ago
Gabriel Luong b057d6a76f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs 3 years ago
Christian Sadilek d4a454442b [fenix] Sort history metadata on home and allow limiting results 3 years ago
Mozilla L10n Automation Bot ae40da34f8 [fenix] Import l10n. 3 years ago
Mugurell b0957a77ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21120 - ImageLoader with a shimmer effect placeholder 3 years ago
AndiAJ ba70d609f1 [fenix] New deleteBookmarkInEditModeTest UI test 3 years ago
AndiAJ 9cf25c9c64 [fenix] Improve coverage for copyBookmarkURLTest 3 years ago
Mozilla L10n Automation Bot 42ddf1faa4 [fenix] Import l10n. 3 years ago
Elise Richards 1e1a52e6f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20654: Handle private mode switching from home behind search dialog.
Add tests for controller and interactor to handle private mode switches
3 years ago
Christian Sadilek 9a78d339b5 [fenix] Fix history metadata API breakage in unit tests 3 years ago
Jan-Erik Rediger 2ab11137aa [fenix] Ensure glean-native is excluded 3 years ago
Jan-Erik Rediger 3ea7d78268 [fenix] Use glean-native in tests
The Glean core native code is now shipped through GeckoView directly
(through its `-omni` packages).
For local tests we need a library matching the host-platform, which is
available in the glean-native package.
3 years ago
Rohan Maity 9bfba77957 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20634: remove some unused color resources 3 years ago
AndiAJ b1ee43a7ed [fenix] Improve coverage for addPrivateBrowsingShortcut Ui test 3 years ago
Arturo Mejia fc42d08c06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18629: add support for SmartBlock exceptions 3 years ago
Arturo Mejia 5d55e07dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen. 3 years ago
Arturo Mejia ea5d0ee63d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21211 hide the ETP in custom tabs. 3 years ago
Mozilla L10n Automation Bot d7355dc309 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 4ff053609b [fenix] Import l10n. 3 years ago
AndiAJ aa63facce4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21133 fix openMainMenuSyncItemTest UI test 3 years ago
bendk 739d93372e [fenix] Handle breaking changes from a-s 83.0.0 (https://github.com/mozilla-mobile/fenix/pull/21215) 3 years ago
Mozilla L10n Automation Bot a9cdb1984c [fenix] Import l10n. 3 years ago
Noah Bond 434c0b6918 [fenix] Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/20637 - Fixed bug causing the tabs tray to scroll to the wrong tab when opened 3 years ago
mcarare 1d78c8b1a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6968: Use close instead of read to close the response stream. 3 years ago
Arturo Mejia 42a5fcc880 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 allow users to configure their home screen. 3 years ago
Elise Richards d0757d386a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19947: manually add login (https://github.com/mozilla-mobile/fenix/pull/21199)
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it.
Fixed bindings.

* [WIP] Removed "reveal password" button

* [WIP] Added interactor for the add login screen

* [WIP] Trying to check for duplicates

* [WIP] Renaming "addNew..." with "add..."

* [WIP] Check for duplicates

* [WIP] Fixes after merge

* Cleaning up the layout and making edit text for hostname selectable

* Error handling on add login screen. Tests for interactors and controllers

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot 0ea0ce4532 [fenix] Import l10n. 3 years ago
Michael Comella df0b8e5886 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove view hierarchy depth check from excessive resource test.
This doesn't seem to be a high value test: increasing the view hierarchy
depth will only result in a performance problem on low end devices
if there is enough content on the new layer to cause the traversal to
take longer. It's more likely to result in a hard-to-workaround false
positive so we can remove it, like component init count.
3 years ago
Michael Comella 88f34d654e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove lazyMonitored wrapper functionality.
We're not using the functionality so there's no sense in doing the work.
However, we keep the wrapper: see the code comments for details.
3 years ago
Michael Comella afea6772f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21183: remove component init check from excessive resource test.
This check doesn't seem high value because initializing a component
only indicates a performance problem if it's slow, which is not most
components, so it's likely to result in many false positives. To fix
the intermittent, we won't lose much if we remove it.
3 years ago
Arturo Mejia c42b4d7481 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection panel strings 3 years ago
Noah Bond 691fe57943 [fenix] Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. (https://github.com/mozilla-mobile/fenix/pull/21141)
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab.

* Fixed RecentTabsListFeatureTest unit test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia 1e64f87d67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20881 print if the build is a MozillaOnline 3 years ago
Mozilla L10n Automation Bot 03932cc800 [fenix] Import l10n. 3 years ago
Elise Richards 4be9b84c20 [fenix] Dont clip bounds on recently saved bookmarks 3 years ago
Michael Comella c5b2185119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21138: change EXPECTED_RUNBLOCKING to range.
Compared with my local runs, CI sees +1 runBlockingIncrement calls so seems to
take other code paths. As such, we search for a range of rather than a single
value. The main downside I can think of is this could make the test trickier to
debug but we can wait and see if that's a problem in practice before taking
action on it.
3 years ago
Michael Comella d4c2608670 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21138: re-enable excessive resource use test.
This test wasn't running in CI
https://github.com/mozilla-mobile/fenix/issues/20386 so we changed the
CI configuration so that it will. However, the test was then failing so
this is the revision that unignores the test.

I wonder if componentInit count is useful - it seems like it'd cause
more false positives than not - but I figure we can leave it in and see
how it goes.
3 years ago
Roger Yang e7c3145fec [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill 3 years ago
Mozilla L10n Automation Bot 5fe3efeb98 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 09eb475097 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot dac9585e2d [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot ce52e5510b [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 6c724c7f13 [fenix] Import l10n. 3 years ago
Arturo Mejia c0e8005c76 [fenix] For 20892 Update connection icons in address bar 3 years ago
Christian Sadilek 193016b662 [fenix] Remove mocked lambdas from AccountSettingsInteractorTest 3 years ago
Christian Sadilek e9b1f3fb81 [fenix] Add missing androidx.lifecycle dependencies 3 years ago
Mozilla L10n Automation Bot 9865ade3f8 [fenix] Import l10n. 3 years ago
czlucius 2d6dffe36a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18727: Exit PiP when launched externally with Intents 3 years ago
Mickey Moz dccc1133b1 [fenix] Update Android Components version (https://github.com/mozilla-mobile/fenix/pull/21109)
* Update Android Components version to 93.0.20210901143120.

* For https://github.com/mozilla-mobile/fenix/issues/21043 - Integrate AC changes

* Fix breaking API changes of RestoreAction

Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Christian Sadilek cda4440bad [fenix] Do not run unit tests in parallel
This is to investigate the intermittent mockk class
generation/loading issues. Since we can not reproduce
locally and the failures are intermittent they could
be caused by us running unit tests in parallel.
3 years ago
codrut.topliceanu bde4c0207a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19166: Increases tab_tray_list bottom padding
... to fit snackbar and FAB
3 years ago
Mozilla L10n Automation Bot b4bf6f22fd [fenix] Import l10n. 3 years ago
Gabriel Luong 9d12ec623c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21078 - Remove unused creditCardsFeature feature flag 3 years ago
Elise Richards 061e5bf6af [fenix] Include data review for renewed metrics 3 years ago
Elise Richards 2d433166a8 [fenix] Remove banner open in app telemetry 3 years ago
Elise Richards edd26c3363 [fenix] Remove search suggestions in private telemetry 3 years ago
Elise Richards 4d2c0b9caf [fenix] Remove user specified search engine telemetry 3 years ago
Elise Richards 17ad77ea02 [fenix] Remove private browsing shortcut telemetry 3 years ago
Elise Richards 49c3b46145 [fenix] Fix data-review listed for default_browser_changed, toolbar_menu_visible, and toolbar_menu_clicked 3 years ago
Elise Richards 5abec1fb15 [fenix] Remove private browsing mode telemetry 3 years ago
Elise Richards 1e05446283 [fenix] Remove tip telemetry 3 years ago
Elise Richards 83416415b8 [fenix] Remove enable private search suggestions telemetry 3 years ago
Elise Richards 49e6325de4 [fenix] Remove open links in private tab telemetry 3 years ago
Elise Richards 61d95c4967 [fenix] Remove find in page telemetry 3 years ago
Elise Richards 9c5bb84cb1 [fenix] Remove total uri count telemetry 3 years ago
Elise Richards dd398def06 [fenix] Remove about page telemetry 3 years ago
Elise Richards 09132f35ac [fenix] Remove downloads management telemetry 3 years ago
Elise Richards 9a432d9f64 [fenix] Remove downloads misc telemetry. 3 years ago
Elise Richards dbf3897680 [fenix] Remove download notification telemetry. 3 years ago
Elise Richards cf2d620e0e [fenix] Remove master password telemetry. 3 years ago
Elise Richards feb4af320b [fenix] Renew probes set to expire in September 3 years ago