Commit Graph

6437 Commits (86f80f265264b0f78e1a25eea157a9db14defd07)

Author SHA1 Message Date
Christian Sadilek 243a456c1b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21332: Ignore intermittently failing WebPushEngineIntegrationTest 3 years ago
Christian Sadilek dc552d78c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952: Ignore intermittently failing FenixSnackbarDelegateTest 3 years ago
Gabriel Luong 41ddc9226c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21888 - Use Hero images for Jump back in 3 years ago
Arturo Mejia a529140c8d [fenix] No issue update strings ids 3 years ago
AndiAJ e62c814006 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests 3 years ago
Gabriel Luong 43d6e2234d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_light_theme redirection 3 years ago
Gabriel Luong 8aa133339d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/inset_dark_theme redirection 3 years ago
Gabriel Luong 7a0b6301d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_dark_theme redirection 3 years ago
Gabriel Luong 10c1bbd3e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/synced_tabs_separator_dark_theme redirection 3 years ago
Gabriel Luong 7b26640382 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection 3 years ago
Gabriel Luong d5d302da69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the collection color variables 3 years ago
Gabriel Luong 6b38dd5259 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the tabs tray color variables 3 years ago
Gabriel Luong 7a494b556a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/caption_text_dark_theme redirection 3 years ago
Gabriel Luong 57e117e9b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/contrast_text_dark_theme redirection 3 years ago
Gabriel Luong cbe4de50ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/secondary_text_dark_theme redirection 3 years ago
Gabriel Luong 5408bc5178 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Use destructive_normal_theme in place of R.color.design_color 3 years ago
Mozilla L10n Automation Bot a08a575365 [fenix] Import l10n. 3 years ago
Michael Comella da44c15a49 [fenix] For https://github.com/mozilla-mobile/android-components/issues/11161: pass profiler into AwesomeBar.
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update

This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
AndiAJ ba3f51814c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests 3 years ago
Arturo Mejia ecb13fa173 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22170: Add telemetry for the auto-close prompt 3 years ago
Arturo Mejia abb1c2631e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Update strings removal version 3 years ago
Mozilla L10n Automation Bot 22bfc8897a [fenix] Import l10n. 3 years ago
Grisha Kruglov ef375069eb [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22083 - Match history groups to history pages by all items within the group
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.

This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.

That's all correct, but the assumption around group matching to history is now incorrect.

This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards 1de688e7d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew metrics for December - never expire updates (https://github.com/mozilla-mobile/fenix/pull/21788)
* For https://github.com/mozilla-mobile/fenix/issues/21313: Renew metrics for December - never expire updates

* For https://github.com/mozilla-mobile/fenix/issues/21313: data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia 07742ec701 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close 3 years ago
MickeyMoz a68de609c2 [fenix] Update Android Components version to 95.0.20211026143215.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong b8bf426e4e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Call chain on collection type may be simplified 3 years ago
Gabriel Luong d46da02cde [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Add package path to TabGroupViewHolder 3 years ago
Gabriel Luong 45e9bf6693 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols 3 years ago
Gabriel Luong 759194a625 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Class member can have 'private' visibility 3 years ago
Gabriel Luong 230536c9b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace Java static method with Kotlin analog 3 years ago
Gabriel Luong 999f0ab3c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace 'isEmpty' with 'ifEmpty' 3 years ago
Gabriel Luong 853e159476 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - 'protected' visibility is effectively 'private' in a final class 3 years ago
Gabriel Luong 71bfe46ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Local 'var' is never modified and can be declared as 'val' 3 years ago
Gabriel Luong 6be34a4023 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused imports 3 years ago
Gabriel Luong 29dfb8ee7f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary type argument 3 years ago
Gabriel Luong 314d61d21e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary parentheses from function call with lambda 3 years ago
Gabriel Luong cd77dbce96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove redundant qualifier name 3 years ago
Gabriel Luong 5fbd63386d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant SAM constructor 3 years ago
Gabriel Luong 4bcb6d7796 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry 3 years ago
Gabriel Luong 2defb17c08 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove val from constructor parameter that are never used as a property 3 years ago
codrut.topliceanu 4b726e786b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21732 - Adds inactive tabs survey on disable + telemetry 3 years ago
Mugurell 6a5a2b842c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21933 - Refresh history items everytime the fragment is opened 3 years ago
Mozilla L10n Automation Bot 217570edff [fenix] Import l10n. 3 years ago
Jonathan Almeida a6d7128c7e [fenix] No issue: Replace TabsTray.Tab with TabSessionState
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida a672d27ca6 [fenix] No issue: Disable FenixSnackbarDelegateTest intermittents 3 years ago
Michael Droettboom 7d5bac64d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21025: Set long term business-critical metrics as non-expiring (https://github.com/mozilla-mobile/fenix/pull/21038)
* Set long term business-critical metrics as non-expiring.

* Remove quotes around "never"

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
AndiAJ 8daaca51af [fenix] Use identifiers instead of hard coded strings 3 years ago
AndiAJ eaed414831 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21747 re-enable start on homepage UI test and refactoring work 3 years ago
AndiAJ 20541aab38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21754 re-enable general settings UI test and refactoring work 3 years ago
AndiAJ 7a4658627e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 3 years ago
Roger Yang 0c5e1f3442 [fenix] No issue: Add external load flag 3 years ago
Sebastian Kaspari 6f4c47613a [fenix] Update Kotlin and Jetpack Compose versions. 3 years ago
Oana Horvath 775929a293 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21628: catch ComposeNotIdleException 3 years ago
Arturo Mejia 8a2df4be14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
Mayank Agarwal af4a03a0f3 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714: Login button visibility fix on saved logins page 3 years ago
Mugurell bf76a1871c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
This is the same previously used approach and the same used for tabs tray.
3 years ago
Mozilla L10n Automation Bot b566e3ed7f [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot e7695f25ef [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 3516c38f1f [fenix] Import l10n. 3 years ago
Michael Comella 2a52bffeae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
Michael Comella 1336a4f72d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add duration for some BrowserFragment lifecycle markers.
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
Michael Comella 9926c27e43 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add durations for some HomeFragment lifecycle markers. 3 years ago
Michael Comella 9a784f8484 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add and register MarkersFragmentLifecycleCallbacks. 3 years ago
Michael Comella 91e7121fa8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
Michael Comella 2f7d5c03f6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22054: add marker for root view layout/measure.
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.

Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Oana Horvath 888e9365cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/22095: fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test 3 years ago
Mugurell fe8c112513 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang 593b08780f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061: Let TabSorter decide if title header should be shown in tabs tray 3 years ago
Mozilla L10n Automation Bot d09f8d1a00 [fenix] Import l10n. 3 years ago
Roger Yang 53db79d50e [fenix] No issue: Only report telemetry when tabs tray is first opened 3 years ago
Mugurell 18127e2f5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal 3 years ago
Michael Comella ad1bcec0d9 [fenix] No issue - post: fix ProfilerMarkerFactProcessor tests. 3 years ago
Michael Comella 8fc6c5952f [fenix] No issue: use Fact.value as detailText for markers.
This allows Facts emitted from ac to provide more details in markers.
3 years ago
Michael Comella 9688a90c29 [fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
Oana Horvath e17721e795 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20754: fix intermittent click failure in verifyAboutFirefoxPreview test 3 years ago
Andrei Joltan 99988cd74f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test (https://github.com/mozilla-mobile/fenix/pull/22068)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
AndiAJ c4bce2422e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test 3 years ago
Mozilla L10n Automation Bot 231ee9a9c3 [fenix] Import l10n. 3 years ago
Gabriel Luong 2e7f52f63a [fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color 3 years ago
Gabriel Luong f3f8f717f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors 3 years ago
xlog-null 6f80d2871f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen 3 years ago
Gabriel Luong 2c4ccea6cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol 3 years ago
Noah Bond 1c21e2face [fenix] MR2 Inactive tabs telemetry (https://github.com/mozilla-mobile/fenix/pull/21908)
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong e8cd66b619 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED 3 years ago
Gabriel Luong e7f6b6fc14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55 3 years ago
Gabriel Luong 0abac59277 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA 3 years ago
Gabriel Luong f928428f5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4 3 years ago
Gabriel Luong c3d86f8dc5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF 3 years ago
Gabriel Luong 1a01f638c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18 3 years ago
Gabriel Luong 4783442368 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75 3 years ago
Gabriel Luong 98dd4016ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C 3 years ago
Gabriel Luong 521b564fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF 3 years ago
Gabriel Luong a77c5b8fad [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787 3 years ago
Gabriel Luong 18a9ffed66 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64 3 years ago
Gabriel Luong 013530110e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff 3 years ago
Gabriel Luong 2e762f0327 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27 3 years ago
Gabriel Luong 9a901e0cff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E 3 years ago
Gabriel Luong 453c6f9f8d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2 3 years ago
Gabriel Luong e5a197c402 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587 3 years ago
Gabriel Luong bfce9bc796 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A 3 years ago
Gabriel Luong a8cdbb4524 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF 3 years ago
Gabriel Luong a63441e402 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB 3 years ago
Gabriel Luong c07d13ba2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042 3 years ago
Gabriel Luong 648f3261c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1 3 years ago
Gabriel Luong d50ff294a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5 3 years ago
Gabriel Luong ebcc1024ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF 3 years ago
Gabriel Luong 98c315c7e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000 3 years ago
Gabriel Luong d51e2df39a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4 3 years ago
Mugurell d7521f168e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list 3 years ago
Mozilla L10n Automation Bot 0a5ba09d26 [fenix] Import l10n. 3 years ago
Mugurell aabd1999ee [fenix] CI for 21827 (https://github.com/mozilla-mobile/fenix/pull/22004)
* Remove redundant calls to setHasOptionsMenu(false)

Fix memory leaks for credit card and login fragments

* Fixes:

Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt

* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
Mozilla L10n Automation Bot 906b7a168c [fenix] Import l10n. 3 years ago
Arturo Mejia 9d3d9b3421 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI 3 years ago
AndiAJ c1c42385c4 [fenix] Improve tabsSettingsMenuItemsTest UI test coverage 3 years ago
Mozilla L10n Automation Bot bee0854156 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 70919737fd [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 952ba35095 [fenix] Import l10n. 3 years ago
Roger Yang 1647e4f613 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893: Keep search group when second to last search term tab is removed 3 years ago
Mozilla L10n Automation Bot 299406fc89 [fenix] Import l10n. 3 years ago
Christian Sadilek 09d1c997d8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944: Top sites rendered slowly on first load of HomeFragment 3 years ago
Marc Leclair b7a03ea6d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: linting fixes
For https://github.com/mozilla-mobile/fenix/issues/21700: nit fixes
3 years ago
Marc Leclair c261feb602 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Added option to open in browser instead of automatically doing it 3 years ago
Marc Leclair c558e11cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: fixed comments 3 years ago
Marc Leclair 60fa679e9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Created benchmark script runner and edited benchmark gradle file 3 years ago
Jonathan Almeida c380d1e622 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910: Fix intermittent failures in SelectTabUseCaseWrapperTest 3 years ago
Grisha Kruglov 997fd9ba64 [fenix] Do less work while navigating Logins views
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:

- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
  `list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
  view
3 years ago
Grisha Kruglov 5372f1bcca [fenix] Make linters happy 3 years ago
Ben Dean-Kawamura 84773fa9a2 [fenix] Register the logins key provider
This is required for sync to work
3 years ago
Ben Dean-Kawamura 204ad8834d [fenix] Updating Fenix to work with the new logins API
Switched to always using `Login` instead of the `SavedPassword` alias.

Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`.  This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.

Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`.  This simplifies the error handling a
bit.

Refactored dupe-checking code to use findLoginToUpdate()

Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method.  I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104.  I would love to address https://github.com/mozilla-mobile/fenix/issues/24102,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
Arturo Mejia 0672471708 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section 3 years ago
AndiAJ c8d89a3bba [fenix] Fix for ambiguous tabstray_title and with text matcher for audio page 3 years ago
AndiAJ 45bdd68df1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test 3 years ago
Jonathan Almeida f5fa9d4217 [fenix] No issue: Always show Make inactive for debug builds 3 years ago
Gabriel Luong fa4b9996c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20 3 years ago
Roger Yang 1e84ef3843 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Add shadow to recent bookmarks section 3 years ago
Mozilla L10n Automation Bot ac7e445eb0 [fenix] Import l10n. 3 years ago
Roger Yang ed3560d1b9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917: Update pocket stories card elevation to match other cards 3 years ago
Jonathan Almeida 18a8788812 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707: Correct search grouping logic in extensions
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.

The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.

Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
Gabriel Luong cb7cc7a7eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources 3 years ago
Grisha Kruglov 7efdddcaeb [fenix] Fix up HistoryMetadataController tests 3 years ago
Grisha Kruglov eef2ad800a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.

This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).

This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.

After this patch, we:
 - dispatch two actions (on browserstore, on homefragmentstore) which
   remove the search groups from any relevant in-memory state; any UI bound to
   this state will be automatically "refreshed"
 - no longer navigate as part of the remove action, so the UI doesn't
   move and removal happens "in-place"
3 years ago
Christian Sadilek 0751190582 [fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
Upgrades to A-C 95.0.20211013154351
3 years ago
Jonathan Almeida 4fee8036a0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Remove rotation; rely on state activated
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
sunil9211 45330287b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17393: Dead code removed around Delete downloads 3 years ago
AndiAJ 7638040a3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest 3 years ago
Arturo Mejia 0658de464f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt 3 years ago
AndiAJ 1bb5f1479d [fenix] Disable editCustomSearchEngineTest UI test 3 years ago
Arturo Mejia d6ae910c74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK. 3 years ago
AndiAJ 6a7c42a398 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test 3 years ago
AndiAJ f0091a768c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test 3 years ago
Mugurell ec442f575f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings 3 years ago
AndiAJ 7f9dab5654 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest 3 years ago
Oana Horvath 3ea7755592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005: fixed ETP status info display 3 years ago
Elise Richards 897aa4b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21522: Wrap section titles on home 3 years ago
Elise Richards 86029b181c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew fission metrics expiring in December 3 years ago
Roger Yang c7232a0bdb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Stop using internally stored tabs list in adapters 3 years ago
Mugurell f10d226f92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
To get smaller shadows.
3 years ago
Mugurell cde1c3b911 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates. 3 years ago
Mugurell e22e33c3c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake. 3 years ago
Christian Sadilek b916fc4a85 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437: Fix default of start_on_home setting in UI 3 years ago
Gabriel Luong ff62ffe70a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section 3 years ago
Jonathan Almeida d13f0ef797 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Reverse chevron for inactive tabs 3 years ago
MickeyMoz 16ed26781d [fenix] Update Android Components version to 95.0.20211008105820. 3 years ago
AndiAJ aa6387809d [fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests 3 years ago
AndiAJ 153bfcce38 [fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests 3 years ago
AndiAJ 3317d98b34 [fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description 3 years ago
AndiAJ 7dd7b2e5b2 [fenix] Fix for ambiguous tabstray_title and with text 3 years ago
AndiAJ d6755b5580 [fenix] Fix for ambiguous tabstray_close 3 years ago
AndiAJ 75606a8786 [fenix] Fix for ambiguous tab_item 3 years ago
codrut.topliceanu 822775eb9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash 3 years ago
Jonathan Almeida 363e563fc7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Move submitList calls into TabsAdapter
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Noah Bond 39a3aacc78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings 3 years ago
Christian Sadilek d73ea2cf98 [fenix] Enable pocket stories in CA 3 years ago
Arturo Mejia 185121606c [fenix] Prepare nimbus features default values for release 95 3 years ago
Rohan Maity 2fc70778a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20579: Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode 3 years ago
Arturo Mejia a4fcc93d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience 3 years ago
Mugurell e6a73b5118 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry 3 years ago
Michael Comella 257ae4b118 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424: add marker for StrictMode.resetAfter.
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
Gabriel Luong e3b2309ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol 3 years ago
Noah Bond b772f6d080 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen (https://github.com/mozilla-mobile/fenix/pull/21722)
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen

* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text

* PR: Fixed lint warning. Reverted preference keys

* PR: added ignore for UI test

* PR: Added ignore for UI test
3 years ago
Roger Yang 259b2e5d30 [fenix] No issue: Update Pocket categories spacing to 16dp. 3 years ago
Sebastian Kaspari a4e21f4fbb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102: Set compileSdkVersion to 31. 3 years ago
Roger Yang c9d8e826ca [fenix] No issue: Small layout update for Pocket Stories 3 years ago
Gabriel Luong 398bdac5aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size 3 years ago
Sebastian Kaspari e487bc6f59 [fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 3 years ago
Arturo Mejia 3e01e9df25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 3 years ago
Arturo Mejia f4f7c1b0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: disabled the homescreen onboarding dialog. 3 years ago
Roger Yang 2594eac89e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Update design for jump back in section and recently bookmarked section 3 years ago
codrut.topliceanu bdc54a1465 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
Arturo Mejia 622e713c07 [fenix] Update feature flags for 94. 3 years ago
AndiAJ 09c8890055 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test 3 years ago
Mugurell 5baa97270c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links 3 years ago
codrut.topliceanu f372c5c69f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup 3 years ago
Mugurell e606d8c42a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
Added from the ViewHolders, the same as for XML Views.
3 years ago
Mugurell dc66fea1e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items 3 years ago
Mugurell 07d08eb655 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description 3 years ago
Mugurell 8f6a6d0980 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items 3 years ago
Mugurell 11b92bbd99 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding 3 years ago
Jonathan Almeida 2e597529c8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582: Use ThumbnailStorage in recent tabs on home 3 years ago