7a4658627e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
0c5e1f3442
[fenix] No issue: Add external load flag
3 years ago
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
775929a293
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21628 : catch ComposeNotIdleException
3 years ago
8a2df4be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
...
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
af4a03a0f3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714 : Login button visibility fix on saved logins page
3 years ago
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
b566e3ed7f
[fenix] Import l10n.
3 years ago
e7695f25ef
[fenix] Import l10n.
3 years ago
3516c38f1f
[fenix] Import l10n.
3 years ago
2a52bffeae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
1336a4f72d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
9a784f8484
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
91e7121fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
2f7d5c03f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
888e9365cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
d09f8d1a00
[fenix] Import l10n.
3 years ago
53db79d50e
[fenix] No issue: Only report telemetry when tabs tray is first opened
3 years ago
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
8fc6c5952f
[fenix] No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
9688a90c29
[fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
e17721e795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
99988cd74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
c4bce2422e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test
3 years ago
231ee9a9c3
[fenix] Import l10n.
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
f3f8f717f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors
3 years ago
6f80d2871f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
e8cd66b619
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED
3 years ago
e7f6b6fc14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55
3 years ago
0abac59277
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA
3 years ago
f928428f5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
c3d86f8dc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF
3 years ago
1a01f638c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18
3 years ago
4783442368
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75
3 years ago
98dd4016ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
521b564fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF
3 years ago
a77c5b8fad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787
3 years ago
18a9ffed66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64
3 years ago
013530110e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff
3 years ago
2e762f0327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27
3 years ago
9a901e0cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E
3 years ago
453c6f9f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2
3 years ago
e5a197c402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587
3 years ago
bfce9bc796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A
3 years ago
a8cdbb4524
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF
3 years ago
a63441e402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB
3 years ago
c07d13ba2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042
3 years ago
648f3261c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1
3 years ago
d50ff294a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5
3 years ago
ebcc1024ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF
3 years ago
98c315c7e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000
3 years ago
d51e2df39a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
d7521f168e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list
3 years ago
0a5ba09d26
[fenix] Import l10n.
3 years ago
aabd1999ee
[fenix] CI for 21827 ( https://github.com/mozilla-mobile/fenix/pull/22004 )
...
* Remove redundant calls to setHasOptionsMenu(false)
Fix memory leaks for credit card and login fragments
* Fixes:
Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt
* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
906b7a168c
[fenix] Import l10n.
3 years ago
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
c1c42385c4
[fenix] Improve tabsSettingsMenuItemsTest UI test coverage
3 years ago
bee0854156
[fenix] Import l10n.
3 years ago
70919737fd
[fenix] Import l10n.
3 years ago
952ba35095
[fenix] Import l10n.
3 years ago
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
299406fc89
[fenix] Import l10n.
3 years ago
09d1c997d8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944 : Top sites rendered slowly on first load of HomeFragment
3 years ago
b7a03ea6d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : linting fixes
...
For https://github.com/mozilla-mobile/fenix/issues/21700 : nit fixes
3 years ago
c261feb602
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Added option to open in browser instead of automatically doing it
3 years ago
c558e11cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : fixed comments
3 years ago
60fa679e9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Created benchmark script runner and edited benchmark gradle file
3 years ago
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
5372f1bcca
[fenix] Make linters happy
3 years ago
84773fa9a2
[fenix] Register the logins key provider
...
This is required for sync to work
3 years ago
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
0672471708
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section
3 years ago
c8d89a3bba
[fenix] Fix for ambiguous tabstray_title and with text matcher for audio page
3 years ago
45bdd68df1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test
3 years ago
f5fa9d4217
[fenix] No issue: Always show Make inactive for debug builds
3 years ago
fa4b9996c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20
3 years ago
1e84ef3843
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Add shadow to recent bookmarks section
3 years ago
ac7e445eb0
[fenix] Import l10n.
3 years ago
ed3560d1b9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917 : Update pocket stories card elevation to match other cards
3 years ago
18a8788812
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707 : Correct search grouping logic in extensions
...
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.
The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.
Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
cb7cc7a7eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources
3 years ago
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
4fee8036a0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Remove rotation; rely on state activated
...
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
7638040a3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest
3 years ago
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
1bb5f1479d
[fenix] Disable editCustomSearchEngineTest UI test
3 years ago
d6ae910c74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK.
3 years ago
6a7c42a398
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test
3 years ago
f0091a768c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test
3 years ago
ec442f575f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings
3 years ago
7f9dab5654
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest
3 years ago
3ea7755592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005 : fixed ETP status info display
3 years ago
897aa4b662
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21522 : Wrap section titles on home
3 years ago
86029b181c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew fission metrics expiring in December
3 years ago
c7232a0bdb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Stop using internally stored tabs list in adapters
3 years ago
f10d226f92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
...
To get smaller shadows.
3 years ago
cde1c3b911
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates.
3 years ago
e22e33c3c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake.
3 years ago
b916fc4a85
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437 : Fix default of start_on_home setting in UI
3 years ago
ff62ffe70a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section
3 years ago
d13f0ef797
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Reverse chevron for inactive tabs
3 years ago
16ed26781d
[fenix] Update Android Components version to 95.0.20211008105820.
3 years ago
aa6387809d
[fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests
3 years ago
153bfcce38
[fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests
3 years ago
3317d98b34
[fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description
3 years ago
7dd7b2e5b2
[fenix] Fix for ambiguous tabstray_title and with text
3 years ago
d6755b5580
[fenix] Fix for ambiguous tabstray_close
3 years ago
75606a8786
[fenix] Fix for ambiguous tab_item
3 years ago
822775eb9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash
3 years ago
363e563fc7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Move submitList calls into TabsAdapter
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
d73ea2cf98
[fenix] Enable pocket stories in CA
3 years ago
185121606c
[fenix] Prepare nimbus features default values for release 95
3 years ago
2fc70778a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20579 : Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode
3 years ago
a4fcc93d0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience
3 years ago
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
257ae4b118
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424 : add marker for StrictMode.resetAfter.
...
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
e3b2309ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol
3 years ago
b772f6d080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen ( https://github.com/mozilla-mobile/fenix/pull/21722 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text
* PR: Fixed lint warning. Reverted preference keys
* PR: added ignore for UI test
* PR: Added ignore for UI test
3 years ago
259b2e5d30
[fenix] No issue: Update Pocket categories spacing to 16dp.
3 years ago
a4e21f4fbb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102 : Set compileSdkVersion to 31.
3 years ago
c9d8e826ca
[fenix] No issue: Small layout update for Pocket Stories
3 years ago
398bdac5aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size
3 years ago
e487bc6f59
[fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often
3 years ago
3e01e9df25
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Show the jump back in Contextual Hints independently of the home onboarding dialog.
3 years ago
f4f7c1b0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : disabled the homescreen onboarding dialog.
3 years ago
2594eac89e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Update design for jump back in section and recently bookmarked section
3 years ago
bdc54a1465
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
...
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
622e713c07
[fenix] Update feature flags for 94.
3 years ago
09c8890055
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test
3 years ago
5baa97270c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links
3 years ago
f372c5c69f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup
3 years ago
e606d8c42a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
...
Added from the ViewHolders, the same as for XML Views.
3 years ago
dc66fea1e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items
3 years ago
07d08eb655
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description
3 years ago
8f6a6d0980
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items
3 years ago
11b92bbd99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding
3 years ago
2e597529c8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582 : Use ThumbnailStorage in recent tabs on home
3 years ago
fde5b755e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited
3 years ago
8a78101fc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches
3 years ago
33cf85203a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642 : Remove in-progress media tab from homescreen
3 years ago
5385b96abe
[fenix] Move tabs out of search group if direct load occurs
...
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.
However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
3db298543e
[fenix] CI for Fix description for home_screen_displayed metric ( https://github.com/mozilla-mobile/fenix/pull/21697 )
...
* Fix description for `home_screen_displayed` metric
The current description appears to be incorrect by my reading of the source.
* Update app/metrics.yaml
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
3631014159
[fenix] CI for Docs: Add extra context to events.browser_menu_action ( https://github.com/mozilla-mobile/fenix/pull/21696 )
...
* Docs only: Add extra context to `events.browser_menu_action`
This came up as a potential point of confusion in a discussion with DS. This is a docs only change.
* Update metrics.yaml
Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
efab5cbb1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions
3 years ago
3d69371557
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671 : Remove Recently Closed from Inactive Tabs
3 years ago
7e65b07930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
...
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
6261e570c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
...
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
4f4586d85f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
...
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
7b031b0504
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test
3 years ago
884c8c2224
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576 : Hide 'Other' title when there are no search groups
3 years ago
20f07022d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties
3 years ago
8a4bb26526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618 : Integrate Nimbus with MR2 Home Page to enable experimentation
3 years ago
21480b89ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in Contextual Hints
3 years ago
51000bcfa4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632 : Correct inactive tabs survey string ( https://github.com/mozilla-mobile/fenix/pull/21669 )
3 years ago
c1f2c33a76
[fenix] Make search term grouping tolerant to (parent tab) navigation
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
d70d0610d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21648 : match Pocket sections on home to designs
3 years ago
0c5285cf05
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641 : Do not add a group of only one tab
3 years ago
ad1cff2300
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21653 : pre-land section title for tab preferences
3 years ago
4f07d1a40f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups ( https://github.com/mozilla-mobile/fenix/pull/21615 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup
* PR: Added missing licenses and possibly fixed UI test
* PR: Added a "scrollTo" to potentially fix a UI test
* PR: Added potential fix for alwaysStartOnHomeTest
* PR: Added temporary ignore to alwaysStartOnHomeTest
* PR: added missing ignore comment
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
f12124b948
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21646 : Update section titles and customize button name on home
3 years ago
b9f5e56c37
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21643 : Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. ( https://github.com/mozilla-mobile/fenix/pull/21645 )
3 years ago
44f1f679e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message ( https://github.com/mozilla-mobile/fenix/pull/21636 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message
* PR: Updated String descriptions and added temporary tools ignore
3 years ago
33381f78f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey
3 years ago
bd610d394f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16437 : Remove unnecessary space for tracking protection exceptions
3 years ago
4e5047d203
[fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions.
3 years ago
1d537cb332
[fenix] Allow opening pocket stories when search dialog is active
3 years ago
1f628f8e52
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 , https://github.com/mozilla-mobile/fenix/issues/21620 : disables failing UI tests
3 years ago
4967527781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21441 , https://github.com/mozilla-mobile/fenix/issues/21477 , https://github.com/mozilla-mobile/fenix/issues/21500 , https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476 , https://github.com/mozilla-mobile/fenix/issues/21474 : retry dismissing the search bar
3 years ago
1da6397453
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610 : Update Strings for Tab Settings
3 years ago
2311ac81df
[fenix] Import l10n.
3 years ago
5e57ece039
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in contextual hint text
3 years ago
1f11b81bc4
[fenix] No issue: Make sure jump back in group always have more than one tab
3 years ago
4d23db624f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
dc1e5e640e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21287 : long press menu on recently visited homescreen groups
3 years ago
e1a2b9ccfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21608 : Update strings for home screen dialog features
3 years ago
485ca898f2
[fenix] Do not show home screen behind search if we have search terms
...
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
0a08c61e8d
[fenix] Don't manually exclude glean-native
...
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
3 years ago
f2b7eea088
[fenix] Inactive tabs changes ( https://github.com/mozilla-mobile/fenix/pull/21524 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code
Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup
* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings
* PR: Fixed lint warnings
* PR: Removed redundant feature check
* PR - Ignore test until search term tab groups switch is done
3 years ago
4fac910adf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories
3 years ago
92bc5e93b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
...
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
3 years ago
e7b2578a5a
[fenix] No issue: Fix AssertionError in openThreeDotMenu
...
fix: ktlint
3 years ago
c7658e352d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test
3 years ago
e7077466ff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : suppress MaxLineLength in Fact.toEvent.
...
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
3 years ago
d0ceaf7a7a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : remove allocations in Fact.toEvent.
...
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat
My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.
---
The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.
It was straightforward to remove these allocations so that's what this
change does.
The primary risk from this change is that it's difficult to test each
case to ensure it's working.
3 years ago
08a11127aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : change `when (condition) {` `when {` in Fact.toEvent.
...
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
3 years ago
32c8709148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : add partial test for existing factToEvent code.
...
When we refactor, this will help ensure we've done it correctly.
3 years ago
ed55813676
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs
3 years ago
738e7b68d5
[fenix] Import l10n.
3 years ago
8a77a20614
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : Move the homescreen onboarding card behind a feature flag
3 years ago
ad0f428f39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu
3 years ago
08a71a5366
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
...
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
710a94b9ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test ( https://github.com/mozilla-mobile/fenix/pull/21563 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
c0c59f266b
[fenix] No issue: Improve rendering of jump back in
3 years ago
7ed672d7ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test
3 years ago
005d0f01a3
[fenix] Fixed verifyAboutFirefoxPreview test according with new steps
3 years ago
01e865fee0
[fenix] Fixed disabled UI test openExternalLinksInPrivateTest
3 years ago
55da682e79
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552 : Remove Extra Subtitle In Jump Back In Item
3 years ago
f90fd65ccd
[fenix] Fix recent tabs intermittent tests ( https://github.com/mozilla-mobile/fenix/pull/21557 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b777fa32ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21339 : update styles for homescreen show all buttons and jump back in spacing ( https://github.com/mozilla-mobile/fenix/pull/21342 )
...
For https://github.com/mozilla-mobile/fenix/issues/21339 : Add ignores for intermittent ui tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
219561d304
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown
3 years ago
4702a66203
[fenix] Do not capture search terms when user navigates away via app ( https://github.com/mozilla-mobile/fenix/pull/21527 )
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
f4a38f0a65
[fenix] Delete browsing data tests UI tests
3 years ago
c1d3d97cc8
[fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work
3 years ago
32d6ee0dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : renewing performance awesomebar metrics ( https://github.com/mozilla-mobile/fenix/pull/21315 )
3 years ago
f65770a34f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451 : Add active search term tab groups on home
3 years ago
c4eb7ea28b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections
3 years ago
6da619deb7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding
3 years ago
012b854d69
[fenix] Fix disabled shortcutButtonTest UI test
3 years ago
d701a81103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Add categories support
3 years ago
c37f1e550b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Cleanup
...
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
5a5507b490
[fenix] Import l10n.
3 years ago
f5588635a2
[fenix] Import l10n.
3 years ago
9dd6d98748
[fenix] Import l10n.
3 years ago
7ea5cdbe39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21087 : Updates Recently Saved design
3 years ago
c9e1bfe3dc
[fenix] Fix mapping between history visits and groups to use createdAt
...
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
7f17484989
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441 : Fix changeAccessibiltySettings
3 years ago
d7c1238dac
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366 : Speculative fix for failing test in TitleHeaderBindingTest
3 years ago
a6a6b6f257
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 : Dedupe urls/site in history groups
3 years ago
cb4b5fc613
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu
3 years ago
bc452b6adc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17847 : adding back editCustomSearchEngineTest UI test
3 years ago
cc65e13b50
[fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests
3 years ago
8976e193d9
[fenix] Fix for disabled saveLoginFromPromptTest
3 years ago
ba990dd118
[fenix] Import l10n.
3 years ago
e3bc494414
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs
3 years ago
e87af643cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen
3 years ago
15a3e30bf0
[fenix] No issue: re-enabled swipeToSwitchTabTest
3 years ago
023612b87d
[fenix] Fix logic so `isFirstRun` can be called multiple times on first run
3 years ago
b4886fe546
[fenix] [SDK-344] Pass in first-run information to Nimbus for targeting
3 years ago
450055a729
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder
3 years ago
4a6c5b8296
[fenix] Various UI test fixes and disabling of intermittents
3 years ago
10f5aa228b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172 : Refactor UI tests accessing awesomebar suggestions.
3 years ago
74500adfb5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172 : Replace BrowserAwesomeBar view with AwesomeBar() composable.
3 years ago
bc30e53e5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case
3 years ago
793ceb8e28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history
3 years ago
2b55e561fb
[fenix] Exit onboarding tour UI tests
3 years ago
13ce5a86bd
[fenix] Import l10n.
3 years ago
275ac7ad5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21126 : process performancetest intent for AC too.
3 years ago
AndiAJ
Roger Yang
Sebastian Kaspari
Oana Horvath
Arturo Mejia
Mayank Agarwal
Mugurell
Mozilla L10n Automation Bot
Michael Comella
Andrei Joltan
Gabriel Luong
xlog-null
Noah Bond
Christian Sadilek
Marc Leclair
Jonathan Almeida
Grisha Kruglov
Ben Dean-Kawamura
sunil9211
Elise Richards
MickeyMoz
codrut.topliceanu
Noah Bond
Rohan Maity
Biren-Nayak
Jan-Erik Rediger
Aaron Train
Travis Long