Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity
6,520 Commits 67 Branches 116 Tags 1.2 GiB
5c28e7d2ba
Commit Graph

5495 Commits

Author SHA1 Message Date
mcarare
cb246ed4bb For #18075: Add SaveVideoAudioCandidate for custom tabs context menu. 2021-02-22 10:05:46 +02:00
Mozilla L10n Automation Bot
6fd93dfe15 Import l10n. 2021-02-21 00:28:51 +00:00
Jonathan Almeida
2f6fcbf196 Close #13892: Remove Synced Tabs appended to tabs tray 2021-02-20 23:02:18 +04:00
Mozilla L10n Automation Bot
516a6a343f Import l10n. 2021-02-20 00:35:38 +00:00
Michael Comella
359f27abc1 For #17972: split frameworkStart into two metrics. 
We do this in order to make it easier to analyze in GLAM: see the metric
descriptions for more details.

Additionally, we change the time unit to milliseconds to make it easier
to analyze in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
012cc21521 For #17972: add client id to startup-timeline ping, update docs. 
This addresses the root problem we're experiencing for this issue - data
not showing up in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
993428cd0f For #17969: add duration probes for App.onCreate and HomeActivity.onCreate. 2021-02-19 13:20:34 -08:00
Mugurell
6e0a64897b For #17899 - Expand toolbar when returning from fullscreen video 
This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.

When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
 2021-02-19 17:46:49 +02:00
Roger Yang
64f32b9d95
Closes #17089: Add metric to track both normal and private URI opened (#17935) 2021-02-19 10:37:07 -05:00
Sebastian Kaspari
a2566f9e9e Issue #12731: Collect telemetry about the content process of tabs getting killed. 2021-02-19 11:32:56 +01:00
Sebastian Kaspari
fc80dbfb57 Update Kotlin to 1.4.30 and Coroutines to 1.4.2. 2021-02-19 11:31:15 +01:00
Mozilla L10n Automation Bot
666833c2e5 Import l10n. 2021-02-19 00:31:43 +00:00
Arturo Mejia
21d10aa931 Update toolbar autoplay strings 2021-02-18 16:40:43 -05:00
Christian Sadilek
e07f4ac590 Deprecate SessionManager component 2021-02-18 14:28:28 -05:00
Christian Sadilek
2d87307144 Remove remaining usages of Session[Manager] in BrowserFragment 2021-02-18 14:28:28 -05:00
Christian Sadilek
c9b8f57f96 Refactor BrowserToolbarMenuController to use browser store 2021-02-18 14:28:28 -05:00
Arturo Mejia
b6ac5079b2 For issue #18049 Download complete dialog is not showing in custom tab. 2021-02-18 12:43:52 -05:00
Victor
2193be27b2 Solves Leaks on SavedLoginFragment 
disables options menu to avoid leak
 removes on click listener to avoid leak
 2021-02-18 19:00:44 +02:00
Sebastian Kaspari
9b65e63422 Closes #18006: DefaultSessionControlControllerTest: Correctly unmock SearchStateKt class. 
The test class left SearchStateKt mocked and caused other tests to fail intermittently when
running after it.
 2021-02-18 15:49:31 +01:00
mcarare
af9c32983f For #17807: Fix systemWindowInset deprecation. 2021-02-18 09:14:53 -05:00
Oana Horvath
d7f1117e17 For #16317 UI tests: save longTap preference to restore it 2021-02-18 13:46:09 +02:00
Mozilla L10n Automation Bot
7e70eccca0 Import l10n. 2021-02-18 00:36:55 +00:00
Ryan Kelly
56914cd42d Reset experiment telemetry identifiers on data prefs change. 
When the user opts out of telemetry, we need to reset the user identifiers
used by the experiment system, so that there's no risk of tracking the
user across the reset event if they later decide to re-enable telemetry.
 2021-02-17 16:07:57 -05:00
Oana Horvath
4e4bbcc334 For #16317: resets long press delay at the end of UI tests 2021-02-17 16:39:44 +02:00
Mozilla L10n Automation Bot
dfc5628ca1 Import l10n. 2021-02-17 00:39:54 +00:00
Jan-Erik Rediger
3e9ab1b150 Glean: Check for renamed reason 2021-02-16 16:32:14 -05:00
Mugurell
611ff8f25b For #17195 - Don't try setting an idle resource if the View is already off screen 
Speculative fix based on the Firebase logs which shows that on a second check
of R.id.tab_wrapper it is not found the screen.
It may be because after `advanceToHalfExpandedState` and before getting a
reference to it in `waitForTabTrayBehaviorToIdle` it was already animated off
the screen.
With this in mind I've added a null check for the view reference before trying
to register an idling resource on it's Behavior.

Also added and used a way to click at a specific location in a View, not just
in the default middle in the View.
It was observed from the Firebase videos that a "click" on the topBar actually
selected the private tabs section. This would leave us to believe that the
"click" was caught by that other View which was placed above the x,y middle of
the topBar.
 2021-02-16 16:26:17 +02:00
Mugurell
32493491fa For #17195 - Test a potential fix for the test 2021-02-16 16:26:17 +02:00
Oana Horvath
23cc3522aa For #17484, #18003 UI tests: retry closing tab if it fails 2021-02-16 14:28:26 +02:00
Mozilla L10n Automation Bot
f5cb3a9920 Import l10n. 2021-02-16 00:29:18 +00:00
Christian Sadilek
5a5cf9cd12 Refactor BrowserToolbarController to use browser store 2021-02-15 15:01:29 +01:00
Codrut Topliceanu
ec54397637
For #17352 - Fixes deleted downloads reappearing (#17930) 
* For #17352 - Fixes deleted downloads reappearing

The `getDeleteDownloadItemsOperation` job would check fragment context not null after the fragment was stopped. Removing that check and only passing the downloadUseCase as a parameter fixes the problem.
 2021-02-15 11:22:09 +02:00
Mozilla L10n Automation Bot
9fee349600 Import l10n. 2021-02-15 00:40:59 +00:00
Mozilla L10n Automation Bot
ed0a188e7e Import l10n. 2021-02-14 00:36:56 +00:00
Mozilla L10n Automation Bot
3c54562504 Import l10n. 2021-02-13 01:55:06 +00:00
Elise Richards
bab7693b9d
Remove unneeded temporary UI test ignores (#17980) 2021-02-12 17:01:38 -06:00
Mugurell
3311e68d14 For #17686 - Use a custom behavior to scroll InfoBanner with the top toolbar 
Previously when the toolbar was on top the banner was inflated in the toolbar's parent - an AppBarLayout.
After migrating to use a custom behavior for scrolling the toolbar and not use
anymore the AppbarLayout for this we needed a new solution.
Using a new behavior to keep this banner in sync with the y translation of the
toolbar gives us most of the old behavior back.
 2021-02-12 16:05:19 +02:00
Elise Richards
d0fd3e82c5
For #17771: three-dot menu reorder (#17838) 
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.

* Handle toolbar items in menu controller

* Menu controller tests

* Make icons invisible

* Lint

* UI tests reflect design change

* Refactor test names

* Lint fixes

* UI tests
 2021-02-11 18:55:12 -06:00
Mozilla L10n Automation Bot
eabde04679 Import l10n. 2021-02-12 00:24:31 +00:00
Michael Comella
b41041c739 For #17920: move manufacturer StrictMode exception to ignores function. 
I think this is more consistent and centralizes the violation ignores.
 2021-02-11 15:22:50 -08:00
Michael Comella
5cb296b098 For #17920: use StrictMode penaltyDeathWithIgnores. 2021-02-11 15:22:50 -08:00
Michael Comella
a86b4ef1bd For 17920: add ThreadPenaltyDeathWithIgnoresListener, tests, helpers. 2021-02-11 15:22:50 -08:00
Michael Comella
e9e067615a For #17920: add ManufacturerCodes. 2021-02-11 15:22:50 -08:00
Michael Comella
2e45483eb0 For #17816: add ProfilerFactProcessor and register it, tests. 2021-02-11 14:52:36 -08:00
Mugurell
41f9388380 For #17803 - Use the main looper for Handler()s 
This was already the one inferred.
Targeting Android 11 means we need to pass it explicitly.
 2021-02-11 19:42:33 +02:00
Codrut Topliceanu
d56b4a2b92
For #17418 - Added telemetry for Google Default Top Site (#17637) 
* For #17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For #17418 - Adds TopSite PerformedSearch back in

* For #17418 - Check now looks for equality with GOOGLE_URL

* For #17418 - Adds test for topSite changes
 2021-02-11 11:31:01 -05:00
Mozilla L10n Automation Bot
9d07b7ae03 Import l10n. 2021-02-11 09:45:42 +00:00
Sebastian Kaspari
a3b556aa35 ToolbarIntegration: Use global public suffix list instance. 2021-02-11 09:33:40 +02:00
Roger Yang
8dfa4525ca
Fix OpenSpecificTabIntentProcessorTest to remove AbstractMediaService (#17955) 2021-02-10 13:33:39 -05:00
Sebastian Kaspari
f4f5e4b663 Issue #17174: Remove usage of old media APIs. 2021-02-10 16:42:58 +01:00
Christian Sadilek
88facc4608 Closes #17889: Wrong tab selected/reloaded when restored from collection 2021-02-10 10:46:13 +01:00
Mozilla L10n Automation Bot
ca57a132c7 Import l10n. 2021-02-10 00:29:59 +00:00
ekager
08a1e0f728 For #17906 - Allow screenshots for private home screenshot test 2021-02-09 12:52:46 -07:00
Oana Horvath
a98b40896d For #15259 UI test: waits for home screen to be visible 2021-02-09 17:22:24 +02:00
AndiAJ
e31b4f49e9 For #17195 Fix Intermittent UI test verifyTabTrayNotShowingStateHalfExpanded 2021-02-09 16:46:31 +02:00
AndiAJ
e0c70582b8 For #17852 Change and Fix Intermittent UI test openNewTabTest 2021-02-09 16:43:56 +02:00
Michael Comella
b3ef8a11e8 For #17816: add profiler marker for onPreDraw via HomeActivity.onStart. 
This may be useful for MAIN start up to determine when the user begins
seeing content.
 2021-02-08 17:46:32 -08:00
Michael Comella
4de49c7585 For #17816: add profiler marker for 2x Activity.onCreate. 
The IntentReceiverActivity one is particularly useful to quickly determine
when we can begin executing code in the WARM VIEW case (i.e. "Set selection
begin here").

The HomeActivity one is useful for COLD start up analysis in similar
ways and to see the Activity transitions in WARM VIEW.
 2021-02-08 17:46:32 -08:00
Mozilla L10n Automation Bot
4084664d30 Import l10n. 2021-02-09 00:42:20 +00:00
ekager
5e9fb855f5 For #17915 - Do not launch system settings on Role Request Intent cancel 2021-02-08 09:56:38 -07:00
AndiAJ
46888cc70f For #14523 Fix Intermittent tests verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab 2021-02-08 18:15:14 +02:00
Oana Horvath
c6bf949a03 For #17847: Removes editCustomSearchEngineTest UI test 2021-02-08 17:47:05 +02:00
Mozilla L10n Automation Bot
e24580f0b7 Import l10n. 2021-02-08 00:34:20 +00:00
Arturo Mejia
3a1d56d7c8 For #17817 Change the feature prompt references from fragment to activity. 2021-02-07 08:10:57 -05:00
Mozilla L10n Automation Bot
b057dead45 Import l10n. 2021-02-07 00:39:01 +00:00
Abhinav Gupta
13f5df33a1 Hiding the usernameview if the data item.username is blank. 2021-02-06 13:20:22 -07:00
ekager
f6455b0148
Closes #17871 - use viewLifecycleOwner for TopSitesFeature owner on HomeFragment (#17873) 2021-02-05 19:47:25 -05:00
Mozilla L10n Automation Bot
dc8c88fa50 Import l10n. 2021-02-06 00:25:11 +00:00
Roger Yang
993cf74e72
Closes #17174: Remove the New Media Session API Feature Flag (#17863) 2021-02-05 18:54:37 -05:00
ekager
0defc54449 Closes #13089 - Adds correct animations for account settings 2021-02-05 14:03:18 -07:00
ekager
f5b068a453 For #17785 - Use screenshots setting when adding secure flag 2021-02-05 13:17:47 -07:00
jhugman
1ef4102e13
Fixes #17738 - Early initialization of Nimbus (#17834) r=christian 2021-02-05 18:54:47 +00:00
Mugurell
8bf1cae2ca For #10686 - Use the AC custom behavior for both the top and bottom toolbars 
This comes to unify the experience (with improvements but also specific issues)
for the url toolbar irrespective of it being placed at the bottom or at the top
Going further this will ease development and ensure the best UX for users.
 2021-02-05 18:23:32 +01:00
Gabriel Luong
a3d401a3b7
For #17418 - Add event ping telemetry for the Google Top Site click (#17862) 
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-02-05 12:06:32 -05:00
jhugman
0b764fd3e4
Fixes #17833 - increment A/A experiment id (#17835) r=christian 2021-02-05 16:41:46 +00:00
Christian Sadilek
50e66b469d Remove SessionManager reference from FenixApplication 2021-02-05 14:16:35 +01:00
Oana Horvath
f0b7b3b987 For #17847: disables editCustomSearchEngineTest 2021-02-05 11:11:33 +02:00
MickeyMoz
378e68f3a6 Update Android Components version to 73.0.20210204143136. 2021-02-04 18:21:26 +01:00
Andrei Joltan
936966596a
For #16020 Fix Intermittent tests caused by the Menu Button (#17829) 2021-02-04 11:42:58 -05:00
Oana Horvath
9783930ac5 For #16615: UI smoke test customTrackingProtectionSettingsTest 2021-02-04 12:17:23 +02:00
AndiAJ
a4a2a59b7d For #12895 Fix Intermittent test navigateBookmarksFoldersTest 2021-02-04 10:06:39 +02:00
hwinnemo
c488bb0e11 For #17724: Wait for tab to be fully created before showing ETP Onboarding if ETP is active 2021-02-03 17:24:23 -07:00
Sebastian Kaspari
f4a7b4c066 Remove TabsUseCases methods that take a Session object. 2021-02-03 15:16:39 -05:00
Grisha Kruglov
3ce9bf93bc Exclude separators from the bookmarks UI 2021-02-03 11:09:01 -08:00
Grisha Kruglov
ebca575e26 Reuse helper functions in bookmark tests 2021-02-03 11:09:01 -08:00
Mugurell
40fc9c1085 For #12414 - Support sharing images through ShareDownloadFeature 
Register a ViewBoundFeatureWrapper<ShareDownloadFeature> that will respond to
"Share image" from the browser contextual menu
 2021-02-03 18:35:20 +02:00
Michael Droettboom
fedc2e1187 Update bug numbers to URLs for activation ping 
Earlier versions of Glean supported bug numbers of the metadata, but this causes
ambiguity, particularly for Fenix where issues exist in both Bugzilla and
Github. This just updates the Bugzilla numbers to full URLs.

We made the use of numbers an error sometime ago, but neglected to enforce this
on "pings" in addition to "metrics".  A future version of `glean_parser` [1] will make
this an error and this will set Fenix up to be ready for that.

[1] https://github.com/mozilla/glean_parser/pull/262
 2021-02-03 09:45:28 -05:00
mcarare
994ec4d55a For #17364: Make hint scrollable and do not overlap other elements. 2021-02-03 14:54:03 +02:00
mcarare
d7ad203544 For #17364: Do not show search suggestion hint before starting to type. 2021-02-03 14:54:03 +02:00
rxu
542071a344 Add mozcn safebrowsing for release variant 2021-02-03 10:35:32 +01:00
Christian Sadilek
e76445b299 Refactor WebAppSiteControlsBuilder to use browser store 2021-02-03 10:16:06 +01:00
Mozilla L10n Automation Bot
dca0cb8c10 Import l10n. 2021-02-03 00:27:35 +00:00
Christian Sadilek
3dc638700f Refactor tryReloadTabBy to use browser store 2021-02-02 17:13:13 -05:00
Sebastian Kaspari
28c105dcb3 Remove SessionManager dependency from CustomTabsIntegration. 2021-02-02 14:17:46 -05:00
Elise Richards
854a5e676f
Increase date on expired metrics (#17766) 2021-02-02 12:27:10 -06:00
Arturo Mejia
e3b6f060ae For #12822 - Opt-in of scoped storage 2021-02-02 12:58:44 -05:00
Jonathan Almeida
824f3fd821 Issue #1340: Forward Activity results to the fragment 2021-02-02 19:46:20 +04:00
Oana Horvath
f180d932c8 For #16959: verify page url not content in swipeToSwitchTabTest 2021-02-02 15:19:00 +02:00
AndiAJ
c8c0131d00 Go Forward Test Fix 2021-02-02 10:23:29 +02:00
AndiAJ
5eb1a3d210 For #17641 Fix Intermittent test addPredefinedSearchEngineTest 2021-02-02 10:23:22 +02:00
AndiAJ
23e6f7aa91 For #16615: UI Smoke Tests for Tab Crash Reporter 2021-02-02 10:23:04 +02:00
Mozilla L10n Automation Bot
4c2a4f4d2e Import l10n. 2021-02-02 01:48:13 +00:00
jhugman
72f977771d
Re-enable Nimbus with Off the main thread I/O and non-blocking networking (#17684) 
* Moved Nimbus setup from Analytics to its own file

* Change experiment identifiers to fit new run of the experiment

* Re-enable nimbus for debug and nightly builds

* ./gradlew ktlint && detekt
 2021-02-01 23:50:07 +00:00
Christian Sadilek
d8085480ad Increase AMO collection cache timeout to 2 days 2021-02-01 17:08:34 -05:00
Michael Comella
cdc008f6a3 For #17553: renew storage.stats metrics. 2021-02-01 16:33:08 -05:00
Christian Sadilek
89ad370eb2 Remove SessionManager references from UI tests 2021-02-01 10:58:46 -05:00
mawen7
1df656cd0e
Include selected session in session suggestions if opened from home fragment (#17127) 2021-02-01 10:17:49 +02:00
MickeyMoz
4bc6b85237 Update Android Components version to 73.0.20210129195412. 2021-01-31 02:55:37 +00:00
Mozilla L10n Automation Bot
4507560325 Import l10n. 2021-01-31 00:36:55 +00:00
Mozilla L10n Automation Bot
9afb78de3f Import l10n. 2021-01-30 00:29:45 +00:00
Michael Comella
d48bb2a4cc Revert "For #17447: add intentional delay to cold start up in debug and nightly." 
This reverts commit 093470a8b3. This
intentional regression was only intended to be temporary so now we're
removing it.
 2021-01-29 14:59:27 -08:00
Roger Yang
d434ff13a5
For #17092: Dismiss toolbar menu when configuration change occurs (#17682) 2021-01-29 15:16:21 -05:00
Jonathan Almeida
66b94ced14 Close #1340: Add support for WebAuthnFeature 2021-01-29 22:57:49 +04:00
rxu
be0382fca7 Pop out privacy notice in first launch in MozillaOnline builds 
Add privacy notice related strings

Pop out privacy notice with onboarding

Using embeded geckoview to display details about privacy

Present or hide privacy pop window according to isMozillaOnline

Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
 2021-01-29 09:35:57 -05:00
Codrut Topliceanu
e188185b15
For #16828 - Adds telemetry for open in app banner (#17049) 
* For #16828 - Adds telemetry for open in app banner

Specifically: Banner displayed, Dismiss action, Go to Settings action.
 2021-01-29 10:14:32 +02:00
Jonathan Almeida
81e08b2e7f Close #15979: Add MOZILLA_OFFICIAL flag for release builds 
When we build release APKs on Mozilla infrastructure, we want a way to
know this in code for features that would only work on them.
 2021-01-29 10:51:33 +04:00
Mozilla L10n Automation Bot
41e6c7247e Import l10n. 2021-01-29 00:29:36 +00:00
Elise Richards
43b0b27819
Update metrics when an addon is installed or enabled (#17669) 2021-01-28 14:30:59 -06:00
Oana Horvath
d7b8af78c9 For #9188: wait for page content to appear in Reader mode tests 2021-01-28 17:33:40 +02:00
Mozilla L10n Automation Bot
f3d332dd8b Import l10n. 2021-01-28 00:32:43 +00:00
Mihai Adrian Carare
8993a0acb2
For #17655: Do not pass threshold if showTopFrecentSites is false. (#17657) 
* For #17655: Do not pass threshold if showTopFrecentSites is false.

* For #17655: Add unit tests for getTopSitesConfig.
 2021-01-27 16:54:48 -05:00
Christian Sadilek
45c0ac85ec Remove SessionManager from BrowserFragment/ToolbarGestureHandler 2021-01-27 16:24:25 -05:00
Roger Yang
124c2baf30
Closes #17531: Use top sites count fact for top sites telemetry (#17664) 2021-01-27 12:46:16 -05:00
Oana Horvath
67ff4d460a For #9188: wait for page load in Reader mode 2021-01-27 18:14:27 +02:00
Roger Yang
eaef276345
Closes #17530: Update has open tabs metrics when tabs are opened or closed (#17557) 2021-01-27 10:51:03 -05:00
mcarare
780e3362a5 For #17464: Handle selected item background programmatically. 2021-01-27 09:14:42 -05:00
Mozilla L10n Automation Bot
4877b77073 Import l10n. 2021-01-27 01:14:34 +00:00
Christian Sadilek
ef8d07fadf Fix breaking API change in FennecMigrator 2021-01-26 19:06:02 -05:00
Gabriel Luong
171c466ada For #14302 - Skip one time pages visit from frecent top sites 2021-01-26 19:06:02 -05:00
mcarare
278ed658b6 For #17635: Check if id corresponds to a custom tab before removing it. 2021-01-26 13:10:45 -05:00
Christian Sadilek
87d6f32374 Refactor HomeFragment to use browser store 2021-01-26 10:08:02 +01:00
Mozilla L10n Automation Bot
009bb89003 Import l10n. 2021-01-26 00:27:53 +00:00
Elise Richards
39f79778a2
For #17084: Use in-app browser switching dialog (#17628) 
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
 2021-01-25 16:16:24 -06:00
Elise Richards
f7b7b25213
For #16485: Tabs tray grid view telemetry (#17442) 
* Tabs tray CFR telemetry interactions

* Create CFR events and implementation

* Tests for tab tray controller
 2021-01-25 15:25:56 -06:00
Sebastian Kaspari
023ddcc131 Refactor ExternalAppBrowserActivity and ExternalAppBrowserFragment to not use Session(Manager). 2021-01-25 13:13:26 -05:00
Arturo Mejia
b419ff82af Remove external download manager FeatureFlags 2021-01-25 13:00:22 -05:00
Arturo Mejia
f99c175ceb Remove autoplay indicator FeatureFlags 2021-01-25 12:04:06 -05:00
Oana Horvath
46487105d5 For #16615 & #11191: re-enabled ReaderViewTest and added a UI smoke test 2021-01-25 16:16:43 +02:00
Mozilla L10n Automation Bot
c21b41c1b2 Import l10n. 2021-01-25 00:30:42 +00:00
Mozilla L10n Automation Bot
48419633be Import l10n. 2021-01-24 00:26:08 +00:00
Mozilla L10n Automation Bot
ea7e8e4581 Import l10n. 2021-01-23 00:34:07 +00:00
Jonathan Almeida
65c69c6b9f Fix breaking APIs in ActivityResultHandler 2021-01-22 16:45:35 -05:00
Christian Sadilek
7001fa1735 Closes #17473: Intermittent failues of PwaOnboardingObserver 2021-01-22 16:44:36 -05:00
Gabriel Luong
70dc975299
For #17304 - Implement top site search engine attribution (#17580) 2021-01-22 14:23:46 -05:00
Sebastian Kaspari
0c41316c31 Revert "For #17044: Explicitly set a new default engine when default is deleted." 
This reverts commit 633bf384e2.
 2021-01-22 20:10:03 +01:00
Oana Horvath
d202daf47e For #16615: UI smoke test mainMenuInstallPWATest 2021-01-22 10:25:03 +02:00
Mozilla L10n Automation Bot
5f1b177bd7 Import l10n. 2021-01-22 00:28:04 +00:00
Michael Comella
d711874285 Closes #17451: remove verbose logs with proguard. 2021-01-21 18:31:25 -05:00
ekager
083fe26f57 For #17542 - Removes flash on renaming top site and fixes title not being updated 2021-01-21 16:10:04 -07:00
William Durand
0537594810 Add new BuildConfig variables to support AMO non-production envs 2021-01-21 17:42:55 -05:00
fevziomurtekin
ddd49170d6 For issue: #16394 Fix UI for consider increasing some elements from ETP-Exceptions page 2021-01-21 16:59:42 -05:00
Jonathan Almeida
d32b3015c4 Use a smaller request code for WebAuthnFeature 
We can't see the private API that we interact with on the OS, but after
some internal investigation it appears that there might be an upper
limit to the request code we can use.

For now, let's try a value similar to that use in the GVE code to see
our requests are failing because of that.
 2021-01-21 11:37:18 -05:00
Christian Sadilek
c34d68d915 Closes #17548: Remove SessionManager reference from TabTrayDialogFragment 2021-01-21 11:12:16 -05:00
Christian Sadilek
0de948e8ae Issue #17548: Remove SessionManager reference from TabHistoryDialog 2021-01-21 11:12:16 -05:00
Christian Sadilek
7358a313bf Issue #17548: Remove SessionManager reference from FenixTabsAdapter 2021-01-21 11:12:16 -05:00
Oana Horvath
7c56df41df For #17309, #13447, #14534 UI tests: changed the way page Url is verified 2021-01-21 10:07:13 +02:00
Codrut Topliceanu
928ad21c51
For #17481 - Remove unused long_press_tapped metric (#17544) 2021-01-21 10:02:26 +02:00
Mozilla L10n Automation Bot
9f5838ecda Import l10n. 2021-01-21 00:31:24 +00:00
AndiAJ
c8c19077ed For #16615: UI Smoke Tests for No history in PB and Add to home screen 2021-01-20 18:08:43 +02:00
mcarare
633bf384e2 For #17044: Explicitly set a new default engine when default is deleted. 2021-01-20 17:33:35 +02:00
Codrut Topliceanu
20f2135578
For #17377 - Fix for empty awesomeBar on searchFragment open (#17435) 
The awesomeBar was set to stay hidden for the first consumeFrom(store) if the SearchDialogFragment.kt. However, recent changes send an additional store update when the view is created. To work around it we can take a look at AwesomeBarView.update(), we see that the awesomeBar suggestions get provided only if the query != url. So we can use the same method to keep the awesomeBar hidden until the user changes anything in the url.
 2021-01-20 14:18:59 +02:00
Mozilla L10n Automation Bot
959dcd2854 Import l10n. 2021-01-20 00:36:23 +00:00
Kate Glazko
ae528e5ab2 For #15181: Remove All Downloads From Settings 2021-01-19 14:21:44 -08:00
Christian Sadilek
54da078bd3 Refactor QuickSettingsDialog to use browser store 2021-01-19 17:19:51 -05:00
Arturo Mejia
570383a54d Add dot notification for autoplay blocked content 2021-01-19 15:04:58 -05:00
mcarare
af1af358a3 For #14011: Remove new line character and spaces from string. 2021-01-19 15:41:10 +02:00
Jonathan Almeida
6dfd7ef757 Add experimental WebAuthn support for Nightly only 
When testing out WebAuthn support with the privileged API,
we need our app to be signed by an allowed signing key.

We're seeing our tests fail with this error when testing locally:

```
  [FidoApiImpl] updateTransaction is called for stop
  [FidoApiImpl] finishSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.
```

Our theory is that if we try this code on our signed APK, we should see
it work.
 2021-01-19 07:54:58 -05:00
AndiAJ
f8ea4c5ca1 For #16615: UI Smoke Tests for Tabs Tray 2021-01-19 11:38:18 +02:00
Christian Sadilek
d8c5f8887a Refactor OpenSpecificTabIntentProcessor to use browser store 2021-01-18 17:54:47 -05:00
Christian Sadilek
be9b478906 Remove SessionManager from TrackingProtectionPanelDialogFragment 2021-01-18 15:55:42 -05:00
Christian Sadilek
f96fdc34eb Refactor CrashReporterFragment to use browser store 2021-01-18 15:33:57 -05:00
Christian Sadilek
810200f2ab Switch to use case when selecting tab for extensions 2021-01-18 15:12:34 -05:00
Christian Sadilek
c03e6377ae Remove unused NotificationsIntentProcessor 2021-01-18 15:12:34 -05:00
Christian Sadilek
eb4beb252f Remove unused SessionManager reference from RecentlyClosedController 2021-01-18 15:12:34 -05:00
Jonathan Almeida
d3dcf69064 A-C 71.0.20210118134928: Fix breaking API in TabCounterToolbarButton 2021-01-18 13:03:21 -05:00
Sebastian Kaspari
fb64c7c076 SearchDialogController: Pass tab ID instead of Session instance. 2021-01-18 12:57:40 -05:00
MickeyMoz
d945cdc4c8 Update Android Components version to 71.0.20210117143132. 2021-01-18 13:56:48 +01:00
AndiAJ
eb910ff5e8 For #16615: UI Smoke Tests for Bookmarks 
For #16615: UI Smoke Tests for Bookmarks
 2021-01-18 14:55:05 +02:00
Oana Horvath
58cefbbb94 For #16615: Collections UI smoke tests 2021-01-18 10:08:43 +02:00
Michael Comella
093470a8b3 For #17447: add intentional delay to cold start up in debug and nightly. 
I validated:
- that the log statement appeared in Nightly but not in Beta.
- that the local runtimes of our perftest increased (the median diff is 124ms)
 2021-01-17 18:38:12 -08:00
Arturo Mejia
b9bdc288cb For issue: #16846 Add ui for controlling exceptions for auto play 2021-01-15 15:51:31 -05:00
Sebastian Kaspari
0035417616 Add unit tests for FennecWebAppIntentProcessor. 2021-01-15 14:35:16 -05:00
Mugurell
d8dc1c4803
For #16519: Add space above Delete History button (#17492) 
add space above Delete History button

Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
 2021-01-15 11:20:49 -05:00
Sebastian Kaspari
051988ecff Migrate some "selected tab" reads from SessionManager to BrowserStore. 2021-01-15 16:52:59 +01:00
Arturo Mejia
a6495347fd For issue #17457: Prevent page refresh when tapping the security icon 2021-01-15 10:18:59 -05:00
codrut.topliceanu
90575e6dd7 For #16238 - Back button now dismisses Suggested Logins 
By using PromptFeature's onBackPressed the user can now press back to dismiss the Suggested Logins prompt without inadvertently navigating back
 2021-01-15 10:17:05 -05:00
Mozilla L10n Automation Bot
2a19967a32 Import l10n. 2021-01-15 14:33:24 +00:00
mcarare
8fa83a7bab For #10417: Improve reload collection tab testing. 2021-01-15 15:30:48 +02:00
mcarare
edcee71287 For #17400: Select tab opened from collection. 2021-01-15 15:30:48 +02:00
mcarare
e110bb322f For #16393: Don't show divider above general category when not signed in 2021-01-15 15:28:58 +02:00
Christian Sadilek
978b555387 Closes #17443: IllegalStateException in startPostponedEnterTransition on HomeFragment 2021-01-14 12:55:00 -05:00
isabelrios
d8584ed632
Changes to run tests on beta builds (#16786) 
* Changes to run tests on beta builds

* remove dontoptime and fix bookmarks tests

* fix ktlint and smokeTest

* add variable for package name

* rebase and fix conflicts

* add yml files and modify script to run tests

* fix yml file indentation

* changes in kind file and add try_task

* fix error kind file

* fix error kind file 2

* fix error kind file 3

* fix reviewer comments

* remove mockwebserver implementation as per reviewer comment

* run beta tests only on releases branches

* reg exp for master branch

* reg exp for master branch2

* modify try_task with release branch

* remove try file

* let's start by running only one test

* address latest reviewers comments

* double check correct tasks for release branch

* remove try file after confirming beta build run

Co-authored-by: isabel rios <isabelrios@MBP-de-isabel-2.home>
 2021-01-14 15:47:36 +01:00
Christian Sadilek
53f77e422b Closes #17441: NPE when invalidating toolbar in response to reader changes 2021-01-13 16:52:52 -05:00
jhugman
7a3524fae5
SDK-158 Use disabled/no-op version of Nimbus object to eliminate unnecessary Rust call (#17372) r=christian 2021-01-13 18:26:06 +00:00
Arturo Mejia
00d971e9d3 For #16847: Allow autoplay to controlled via the toolbar. 2021-01-13 15:51:49 +01:00
Sebastian Kaspari
0761f391fc Update to latest feature-intent and feature-recentlyclosed APIs (and update Android Components). 2021-01-13 15:51:49 +01:00
Oana Horvath
7983a7fc89 For #16615: UI smoke test editCustomSearchEngineTest 2021-01-13 14:39:20 +02:00
hakkikaancaliskan
542bc89284 For #12732: Match notification accent color with app theme 2021-01-12 10:31:38 -05:00
Mihai Adrian Carare
3bb074b133
For #13522: Also remove history entries from tab history. (#17392) 
* For #13522: Also remove history entries from tab history.

* For #13522: Test that deleting history also removes it from tab history.
 2021-01-12 09:13:24 -05:00
AndiAJ
fc964862e0 For #16615: UI Smoke Tests for Recently Closed Tabs 2021-01-12 14:38:09 +02:00
Mozilla L10n Automation Bot
837eaa3282 Import l10n. 2021-01-12 00:25:09 +00:00
Oana Horvath
7ac4af46bc For #10798 & #14526: Apply auto-download test file fix for download UI tests 2021-01-11 18:42:11 +02:00
Oana Horvath
23789c86c4 For #16615: UI smoke test manageDownloadsInDownloadsMenuTest 2021-01-11 18:42:11 +02:00
mcarare
4e736625bd For #8716: Authentication custom tab now considers browsing mode. 2021-01-11 17:28:10 +02:00
Mozilla L10n Automation Bot
6a84eed552 Import l10n. 2021-01-11 12:43:17 +00:00
Mozilla L10n Automation Bot
7fc0ef5379 Import l10n. 2021-01-10 00:27:09 +00:00
Christian Sadilek
cef56bef17 Update Android Components version to 71.0.20210108190105 2021-01-08 16:10:23 -05:00
Suraj Shah
15f3743ca0
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar (#16741) 2021-01-08 13:06:15 -05:00
Mugurell
484f167714 For #16249 - ClipboardHandler cleans up returned text 2021-01-08 11:14:56 +02:00
mcarare
d110464a91 For #17117: Use proper custom tab session for custom tab toolbar menu. 2021-01-08 09:27:02 +02:00
Mozilla L10n Automation Bot
1fbf227a61 Import l10n. 2021-01-08 00:25:50 +00:00
Arturo Mejia
0aa44c93cd Closes issue #16945 Refactor TrackingProtectionOverlay to observe session via store. 2021-01-07 17:23:13 -05:00
Christian Sadilek
9a53054b28 Use new RestoreUseCase in A-C to handle tab timeouts 2021-01-07 15:50:54 -05:00
Mozilla L10n Automation Bot
9966a85bd5 Import l10n. 2021-01-07 00:31:02 +00:00
Arturo Mejia
743ba6918f Closes issue #16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store. 2021-01-06 12:36:02 -05:00
mcarare
156dee29d8 For #15464: Always dismiss search dialog on url committed. 2021-01-06 08:58:17 +02:00
Hakkı Kaan Çalışkan
e41cc5a414 For #17303: Move ext fun runIfFragmentIsAttached to utils 
move to ext
 2021-01-05 21:55:45 -08:00
Gabriel Luong
d0fc086fc4
For #16790 - Allow top sites to have an empty name when renamed (#17290) 2021-01-05 16:59:41 -05:00
Roger Yang
afa0454f2b
Closes #16603: Disable pull down when in fullscreen (#17314) 2021-01-05 15:34:44 -05:00
Marcello Galhardo
381f22449b
Closes #17118: Fix font spacing when long pressing a URL (#17164) 2021-01-05 13:26:14 -06:00
Sebastian Kaspari
1b6cebf4d4 Switch to new SessionStorage / session restore API. 2021-01-05 17:11:57 +01:00
Oana Horvath
d7a35ed6bd For #16966: Remove unnecessary step from mainMenuAddToHomeScreenTest 2021-01-05 10:31:59 +02:00
ekager
d5f625c945 For #17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing 2021-01-04 20:23:43 -08:00
Mozilla L10n Automation Bot
f95547c271 Import l10n. 2021-01-05 00:29:50 +00:00
Roger Yang
7527851cf0
Closes #17298: Turn on new MediaSession feature for all builds (#17302) 2021-01-04 15:12:43 -05:00
Marcello Galhardo
e3a77cb750
Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect (#17169) 
* Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect

* For #14009: Add 'onboarding_padded_background_color' instead of rely on OS theme/color

Both previous solution, '?android:attr/colorControlHighlight' and '@color/ripple_material_light' were using a OS theme attr or color, which caused problems. To fix it, we introduced a 'onboarding_padded_background_color' which manually define the ripple effect color of the onboarding manual sign in button.
 2021-01-04 11:55:47 -05:00
MarcLeclair
24bce64e0b
16373 Count the # of inflations done on startup (#16778) 
* For #16373: Added performance Inflater to counter # of inflations

This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)

* For #16373: Added test for PerformanceInflater

This test got quite awkward / complicated fast.  I wanted to test the  to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.

* For #16373: Overrode getSystemService to return PerformanceInflater

This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.

* For #16373: Added UI test for # of inflations

* For #16373: Lint fix

* For #167373: Changed the LayoutInflater cloneInContext to take this instead of inflater

The inflater parameter is set on the first call from the OS from  the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.

* For #16373: Fixed code issues for PR. No behavior change

* For #16373: fixed some code nits
 2021-01-04 11:00:34 -05:00
mcarare
251d652833 For #16027: Allow elements to be selected separately by a11y services. 2021-01-04 17:50:26 +02:00
Gabriel Luong
487ba32441
For #17292 - Remove unused static_strings (#17293) 2021-01-04 10:36:25 -05:00
mcarare
2d1df018ff For #15061: Fix error text color in SyncedTabsFragment. 2021-01-04 16:42:30 +02:00
Codrut Topliceanu
c0f0c401f3
For #11580 - Tracks text selection context menu usage (#16968) 
* For #11580 - Tracks text selection context menu usage

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-01-04 16:28:01 +02:00
Marcello Galhardo
b34cc24f88
For #9778 - Site permission settings item height set to 48dp (#17134) 2021-01-04 08:55:08 -05:00
Mozilla L10n Automation Bot
9c776f1d7f Import l10n. 2021-01-02 00:28:19 +00:00
Mozilla L10n Automation Bot
bad65b5017 Import l10n. 2021-01-01 00:29:19 +00:00
Mozilla L10n Automation Bot
f8f677ce7f Import l10n. 2020-12-30 00:34:22 +00:00
Mozilla L10n Automation Bot
96be55067d Import l10n. 2020-12-29 00:32:57 +00:00
Mozilla L10n Automation Bot
16ab8bf1ab Import l10n. 2020-12-28 00:25:24 +00:00
Mozilla L10n Automation Bot
33272d5447 Import l10n. 2020-12-27 00:32:45 +00:00
Mozilla L10n Automation Bot
96b63485cc Import l10n. 2020-12-26 00:37:54 +00:00
Mozilla L10n Automation Bot
57d453dc7f Import l10n. 2020-12-25 00:32:16 +00:00
Christian Sadilek
801ce85898 For #17073: Stop observers after test run 2020-12-24 10:27:27 -05:00
Mozilla L10n Automation Bot
5445e61b6a Import l10n. 2020-12-24 00:35:02 +00:00
Arturo Mejia
81f208bda1 For issue #13981 Use DEEP_LINK_SCHEME instead of hard-coded fenix 2020-12-23 10:47:57 -05:00
Mozilla L10n Automation Bot
7bf0f7595c Import l10n. 2020-12-23 01:26:11 +00:00
Elise Richards
6dadecacc2
For #15703 and #17133: allow ETP redirect trackers setting to be customized (#17137) 
* Remove ETP redirect trackers feature flag. Add category to ETP panel view.

* Add redirect tracker category to ETP custom settings
 2020-12-22 11:43:04 -06:00
ekager
d3e1045ab9 For #17165 - Use application context to get notification localized strings 2020-12-22 09:39:30 -08:00
Christian Sadilek
7a01fcbfa9 Closes #17073: Fix intermittent failures in PwaOnboardingObserverTest 2020-12-22 11:47:58 -05:00
Oana Horvath
095d07598a Code cleanup in BookmarksRobot and BookmarksTest 2020-12-22 11:55:52 +02:00
Christian Sadilek
36a6d364a7 For #17086 #17143: Temporarily turn off Nimbus 2020-12-21 10:45:03 -05:00
jhugman
4565d7381b
No bug- protect nimbus init from StrictMode (#17033) r=christian 2020-12-19 15:26:48 +00:00
Christian Sadilek
0b99669753 Closes #16949: Refactor OpenInAppOnboardingObserver to use browser store 2020-12-17 11:25:29 -05:00
Oana Horvath
0a0dbeb132 Added a description to each smoke test 2020-12-17 14:47:07 +02:00
Oana Horvath
b0277c3f39 For #16615: UI smoke test noCrashWithAddonInstalledTest 2020-12-17 14:47:07 +02:00
Sebastian Kaspari
d2b8decaeb Switch to new feature-tab-collections API. 2020-12-16 15:32:53 -05:00
ekager
30df43d057
For #13321 - Do not hide toolbar when opening multiple bookmarks (#17038) 2020-12-16 12:58:46 -05:00
mcarare
04bd9c61a6 For #16483: Rotate edit arrow when toolbar position is set to bottom. 2020-12-16 16:36:35 +02:00
Mugurell
9c15267de9 For #11578 - Cleanup download telemetry - metrics ping reference 
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
 2020-12-16 15:17:11 +02:00
mcarare
e24ec1c941 For #16068: Update SUMO links. 2020-12-16 14:03:36 +02:00
Mugurell
4d38440594
For #15367 - Cleanup metrics ping reference (#17071) 
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
 2020-12-16 14:00:48 +02:00
mcarare
e0c3193162 For #17061: Prevent appBarLayout from leaking. 2020-12-16 13:53:45 +02:00
mcarare
fc43e85e4d For #16827: Send copy url metrics correctly. 2020-12-16 13:50:38 +02:00
mcarare
ab0a5a84fb For #15369: Send synced tabs metrics correctly. 2020-12-16 13:45:55 +02:00
Oana Horvath
f24c6e1316 For #16615: UI smoke test redirectToAppPermissionsSystemSettingsTest 2020-12-16 10:32:04 +02:00
Kate Glazko
233018df84 For #298: Fenix Quarantine For Delete Downloads UX 2020-12-15 14:30:40 -08:00
Christian Sadilek
5157a3f50e Closes #17045: Crash caused by calling consumeFlow on wrong thread 2020-12-15 13:28:04 -05:00
ekager
419f895364 For #16973 - Use controller handled action instead of toolbar focus 2020-12-15 09:33:08 -08:00
Gabriel Luong
846d618c06
For #16941 - [Telemetry] Bookmark Counts (#16942) 2020-12-15 11:30:24 -05:00
Christian Sadilek
d8f3127e08 Closes #16946: Refactor PwaOnboardingObserver to use browser store 2020-12-15 10:15:54 -05:00
Sebastian Kaspari
46813dd89c
Add search current/home region to debug screen. (#17015) 2020-12-15 09:34:17 -05:00
Codrut Topliceanu
d0b09b7d69
For #15368 - Adds telemetry for fullscreen, pip (#16833) 2020-12-15 14:46:15 +02:00
mcarare
01db5160ee For #16827: Add copy url from long press metrics. 2020-12-15 12:14:27 +02:00
mcarare
c006ae5056 For #16827: Add documentation for copy url metrics. 2020-12-15 12:14:27 +02:00
mcarare
93b13ac977 For #15369: Add synced tabs usage metrics. 2020-12-15 11:36:47 +02:00
mcarare
1d5fa23026 For #15369: Add documentation for synced tabs opening metrics. 2020-12-15 11:36:47 +02:00
mcarare
d233229ce4 For #15366: Add recently closed tabs metrics from history fragment. 2020-12-15 10:52:11 +02:00
mcarare
2f360eb474 For #15366: Add recently closed tabs metrics. 2020-12-15 10:52:11 +02:00
mcarare
d0f2209cae For #15366: Add documentation for recently closed tabs metrics. 2020-12-15 10:52:11 +02:00
mcarare
a59195e2ee For #16422: Handle theme for tab history bottom sheet. 2020-12-15 10:44:41 +02:00
Mugurell
574eac4636
For #15367 - DownloadsFragment telemetry (#16728) 
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
 2020-12-15 09:14:20 +02:00
Mugurell
d5b33aec43
For #11578 - Add telemetry for how many times we download something (#16730) 2020-12-15 08:39:22 +02:00
mcarare
4b2dc28d57 For #16992: Align clipboard link and text with scan button. 2020-12-14 14:34:46 -05:00
Michael Debertol
95860eba49
For #4333: Open the keyboard when a search engine is selected (#14353) 
Co-authored-by: Elise Richards <erichards@mozilla.com>
 2020-12-14 12:53:59 +02:00
Arturo Mejia
f263b7333a For issue #16847 Show the autoplay icon in the toolbar 2020-12-13 19:03:01 -05:00
ekager
3b0e70a856 For #16937 - Ensure FIP is removed on navigation 2020-12-11 14:51:30 -08:00
ekager
2796a7ff18 For #16675 For #16398 - Fix button styling 2020-12-11 14:45:37 -08:00
Jeff Boek
cf61c10c39
For #15403 - Adds a secret debug info screen in settings (#15540) 
Co-authored-by: Elise Richards <erichards@mozilla.com>
 2020-12-11 16:13:37 -05:00
ekager
1ca34a2bc9 For #16807 - Make sure there's only one instance of search dialog 2020-12-11 11:47:30 -08:00
Elise Richards
813693f1d3
Remove hidden fab in tabs tray (#16972) 2020-12-11 11:01:04 -05:00
Codrut Topliceanu
556fea5591
For #15636 - Focus a11y collection on snackbar view tap (#16853) 
With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
 2020-12-11 14:32:37 +02:00
jhugman
9a984f10f1
Add withExperiment extension method to Nimbus (#16926) r=christian, sebastian 
* Fixes #16925 Add withExperiment extension method to Nimbus
* Don't call Nimbus at all if not enabled by FeatureFlag
 2020-12-10 17:34:31 +00:00
Oana Horvath
9d5ec47ec3 Fix #16960 & #16959: updateSavedLoginTest, swipeToSwitchTabTest UI smoke tests 2020-12-10 17:09:42 +02:00
Roger Yang
ca605d8a95
Closes #16075: Add distribution_id in telemetry startup metrics (#16821) 2020-12-10 09:36:05 -05:00
Christian Sadilek
f0078097f8 Prepare for A-C Session[Manager] observable deprecation 2020-12-10 14:40:54 +01:00
Mozilla L10n Automation Bot
cecb8385e7 Import l10n. 2020-12-10 00:29:01 +00:00
ekager
dd2615b554
For #16442 - Check if fragment is still attached before updating site permissions rules (#16954) 2020-12-09 18:42:39 -05:00
jhugman
459f1e970f
Fixes #16948: call nimbus.updateExperiments on startup (#16950) r=gl 2020-12-09 20:18:48 +00:00
mcarare
a2ad9f7a27 For #16894: Handle adding voice search button depending on state. 2020-12-09 15:38:28 +02:00
mcarare
0a77f4bccf For #16775: Fallback to light mode drawable when ui mode is not resolved 2020-12-09 14:12:51 +02:00
mcarare
b4a81c2219 For #15640: Remove private resources from RadioButtonPreference. 2020-12-09 14:12:40 +02:00
mcarare
fa08afbc03 For #15640: Remove private resources from TextPercentageSeekBarPref. 2020-12-09 14:12:40 +02:00
mcarare
0a6808d0bc For #15640: Increase PrivateResource warning severity to error. 2020-12-09 14:12:40 +02:00
Mozilla L10n Automation Bot
0ed5ba68c6 Import l10n. 2020-12-09 00:35:32 +00:00
ekager
2bb7bea258 For #16668 - Fix keyboard show/hide from search dialog fragment 2020-12-08 13:31:32 -08:00
Kate Glazko
ef01cdcefe For #16541: Download UX Updates 2020-12-08 11:35:23 -08:00
Christian Sadilek
faf765a57d Update IntentProcessors after breaking API change 2020-12-08 14:19:01 -05:00
Emilio Cobos Álvarez
9d5afd501e Add support for EME permission. 
This accompanies the changes in mozilla-mobile/android-components#9121.

Closes #1175
 2020-12-08 14:19:01 -05:00
Mugurell
f2191bdbb5 For #13427 - Disable the "selected tab" decoration when in Multiselect 
Selecting a tab while in Multiselect would add a different decoration to the one
already set for the last tab opened and this would confuse users.
Let's avoid this.
 2020-12-08 14:19:01 -05:00
Christian Sadilek
d1345e8f93 Closes #11290: Refactor ToolbarMenu to use browser store 2020-12-08 14:19:01 -05:00
Roger Yang
2ff7ba75c7
Closes #16896: Integrate new MediaSession API to nightly or debug builds (#16909) 2020-12-08 11:04:56 -05:00
Oana Horvath
80ad6dea32 For #16615: UI smoke test updateSavedLoginTest 2020-12-08 13:46:40 +02:00
Oana Horvath
5e046c8f04 For #16615: UI smoke test startBrowsingButtonTest 2020-12-08 13:46:40 +02:00
Mozilla L10n Automation Bot
5cc66f532f Import l10n. 2020-12-08 00:39:38 +00:00
Elise Richards
948db6f77b
Reload restored tabs from collection (#16865) 2020-12-07 11:32:27 -06:00
Sebastian Kaspari
2cada405d8 Update Android Components to 69.0.20201207103252. 2020-12-07 15:21:08 +01:00
Mozilla L10n Automation Bot
507445a400 Import l10n. 2020-12-07 00:24:53 +00:00
Mozilla L10n Automation Bot
68ae35027f Import l10n. 2020-12-06 00:35:02 +00:00
ekager
e428694a51 For #16397 - Fixes SignOutFragment crash and invisible button 2020-12-04 10:59:22 -08:00
Oana Horvath
7a08175568 For #16615: Smoke UI test swipeToSwitchTabTest 2020-12-04 18:49:28 +02:00
Mugurell
c89a7193f5
For #16248 - Cleanup error pages of inlined code (#16834) 
Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
 2020-12-04 18:47:30 +02:00
Roger Yang
3c3ddb4f44
For #16133: Simplify OpenInAppOnboardingObserver condition (#16851) 2020-12-04 10:44:36 -05:00
Philipp Klein
2be3fd05f2
For #15362: Remove swipe to delete for bookmarks (#16646) 
Removed now obsolete feature flag and tests.
Removed obsolete swipe refresh state from BookmarkFragmentState
Also adapted tests and remove obsolete ones.
 2020-12-04 13:54:45 +02:00
Mozilla L10n Automation Bot
c63a14af14 Import l10n. 2020-12-04 00:37:43 +00:00
Elise Richards
77f061c362 Closes #8791: Use A-C tab counter and upgrades to A-C 69.0.20201203202830 
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
 2020-12-03 17:45:01 -05:00
Codrut Topliceanu
79d1c08402
For #16629 - Fix for collection snackbar View button (#16679) 2020-12-03 15:30:00 -05:00
Oana Horvath
8a579ee62b For #16838: deleted mainMenuOpenInAppTest 2020-12-03 18:47:02 +02:00
Jonathan Almeida
c99b2157fb Fix breaking changes from FCM SDK update 2020-12-03 11:32:40 -05:00
jhugman
ea9f692007
Nimbus-SDK-119 Get Nimbus server endpoint at build time. (#16682) 
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2].

For production use, this requires a secret named `nimbus_url` to be put into CI.

Note: Nimbus is currently behind a feature flag.

If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.:

```
nimbus.remote-settings.url=https://settings.stage.moz4ws.net
```

Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment.

[1]: https://github.com/mozilla-mobile/android-components/pull/9024
[2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
 2020-12-03 16:30:20 +00:00
jhugman
3cd4ff9ac8
Adding menu configuration for A/A experiment and A/B experiment (#16692) 2020-12-03 12:24:46 +00:00
Mozilla L10n Automation Bot
eab87555dc Import l10n. 2020-12-03 00:38:46 +00:00
Christian Sadilek
3722033a5c For #16032: Support installing recommended add-ons from AMO 2020-12-02 17:30:48 -05:00
Roger Yang
26051f7c0e
Closes #16603: Disable pull down refresh when activity is in immersive mode (#16793) 2020-12-02 11:40:44 -05:00
Oana Horvath
5867d2830a Split UI smoke tests into smaller tests 2020-12-02 16:06:26 +02:00
Mozilla L10n Automation Bot
a2b6ddf457 Import l10n. 2020-12-02 00:37:09 +00:00
Mozilla L10n Automation Bot
e587f814c7 Import l10n. 2020-12-01 00:29:26 +00:00
Sebastian Kaspari
57ebc0cb99 ExternalAppBrowserActivity: Add additional test cases. 2020-11-30 17:19:17 -05:00
Sebastian Kaspari
788a8309c2 Issue #16435: Open custom tab in Fenix: Force launch outside of and remove current task. 2020-11-30 17:19:17 -05:00
Sebastian Kaspari
776b64f959 Issue #16435: Finish ExternalAppBrowserActivity and remove task if linked tab doesn't exist anymore. 
This doesn't fix the underlying issue of #16435, but a symptom we have seen quite often in different
situations: When the ExternalAppBrowserActivity is not linked to a tab anymore then it falls back
to displaying a (partially broken) browser UI. With multiple browser activities at the same time
sooner or later we crash with a "display already acquired" error because both activities try to
render the same tab.
 2020-11-30 17:19:17 -05:00
mcarare
0bd3654bc7 For #16759: Prevent crash on showing info banner. 2020-11-30 16:23:21 -05:00
Sebastian Kaspari
055c76b7ba FenixApplication: Remove unused kinto endpoint. 2020-11-30 15:50:38 -05:00
Sebastian Kaspari
23edda5f65 Introduce build flag for configuring test build type. 2020-11-30 18:54:20 +01:00
Sebastian Kaspari
0a419efa92 Introduce build flag for disabling optmization. 2020-11-30 18:54:20 +01:00
Sebastian Kaspari
d84b8ebdc6 Issue #12731: Log and record breadcrumb when onTrimMemory() gets invoked. 2020-11-30 15:42:29 +01:00
Mozilla L10n Automation Bot
e8fa1a66f0 Import l10n. 2020-11-30 00:37:12 +00:00
Mozilla L10n Automation Bot
7e56b0cd53 Import l10n. 2020-11-29 00:33:16 +00:00
Mozilla L10n Automation Bot
806ed78b7f Import l10n. 2020-11-28 00:36:35 +00:00
Oana Horvath
c8f8e2e665 Updates to UI tests using the modified recyclerViewIdlingResources minItemCount 2020-11-27 15:08:32 +02:00
Oana Horvath
894b25855e For #16615: UI smoke test toggleSearchSuggestions 2020-11-27 15:08:32 +02:00
Mozilla L10n Automation Bot
2e676a047d Import l10n. 2020-11-27 00:34:14 +00:00
Mihai Adrian Carare
b2b558fe39
For #16745 - Allow preference layout to increase height if needed. (#16752) 2020-11-26 13:36:39 -05:00
Mihai Adrian Carare
34b4dad614
For #16735 - Do not show grid view CFR if grid view is already selected. (#16740) 2020-11-26 13:09:49 -05:00
ekager
d49d710343 For #16676 - Do not switch mode on last private tab via tab context menu 2020-11-26 10:04:48 -05:00
Mozilla L10n Automation Bot
94c59cb3ca Import l10n. 2020-11-26 00:32:16 +00:00
Oana Horvath
2d652acbf2 For #16615: UI smoke test addPredefinedSearchEngineTest 2020-11-25 13:32:31 +02:00
Mozilla L10n Automation Bot
23460fac51 Import l10n. 2020-11-25 00:31:14 +00:00
Codrut Topliceanu
4b56aeb12f
For #16592 - Fix missing collection snackbar for a11y (#16593) 
Set null anchor for snackbar when using a11y services
 2020-11-24 09:11:27 +02:00
Mozilla L10n Automation Bot
f89f6fd2a2 Import l10n. 2020-11-24 00:29:55 +00:00
mcarare
f823a5d246 For #16353: Avoid strict mode death on reading onboarding preference. 2020-11-23 13:33:05 +02:00
mcarare
de1fa74ac1 For #16353: Add unit tests for onboarding finishing conditions. 2020-11-23 10:15:37 +02:00
mcarare
089c79f868 For #16353: Finish onboarding on loading a web page, with exceptions. 2020-11-23 10:15:37 +02:00
mcarare
451f60b095 For #16353: Do not finish onboarding on search dialog opening. 2020-11-23 10:15:37 +02:00
Mozilla L10n Automation Bot
c5b9491619 Import l10n. 2020-11-23 00:27:20 +00:00
Mozilla L10n Automation Bot
7166cf2b48 Import l10n. 2020-11-22 00:26:22 +00:00
Mozilla L10n Automation Bot
9cd2757502 Import l10n. 2020-11-21 00:30:41 +00:00
ekager
b9737bde95 For #16351 - Add divider lines for search dialog 2020-11-20 12:12:07 -08:00
Sebastian Kaspari
2b759e9d6f Integrate new search code from Android Components into Fenix. 2020-11-20 17:45:45 +01:00
MickeyMoz
2904ca8ac0 Update Android Components version to 68.0.20201120125142. 2020-11-20 15:34:45 +00:00
Mozilla L10n Automation Bot
4e598d16fc Import l10n. 2020-11-19 22:46:17 -08:00
mcarare
36475fc3fe For #15788: Remove fixed issues from lint baseline. 2020-11-19 20:34:37 +02:00
jhugman
9cdfb6db4a
Nimbus Global Opt Out (#16543) r=gl 2020-11-19 11:17:25 +00:00
Mozilla L10n Automation Bot
359759753c Import l10n. 2020-11-18 23:03:14 -08:00
ekager
b7fe809ae4 For #16351 - Make homescreen interactive when search dialog is up 2020-11-18 13:53:33 -08:00
mcarare
519885da43 For #15788: Remove nested constraint layout in tabs tray. 2020-11-18 11:31:44 -08:00
mcarare
cf162c69d1 For #15788: Remove nested layouts in search dialog layout. 2020-11-18 11:31:25 -08:00
Oana Horvath
2d6d49324e For #16615: UI smoke test firstRunScreenTest 2020-11-18 09:30:40 +02:00
mozilla-l10n-automation-bot
01ec558811
Import l10n. (#16625) 2020-11-17 21:28:11 -05:00
Jonathan Almeida
cebab81e07
Update Android Components to 67.0.20201117165227 (#16619) 2020-11-17 15:29:54 -05:00
ekager
f520586dcd
For #12062 - Remove feature flag for return to browser (#16622) 2020-11-17 15:28:59 -05:00
Mugurell
ef5846dc3e
For #16614 - Ensure a stable order for the items in tabs tray. (#16618) 
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items

This order should also be kept after returning from Multiselect mode.
 2020-11-17 13:33:41 -05:00
Bryan Kok
5f9de1e261 Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu 2020-11-17 09:16:55 -08:00
ekager
614471495d
For #15091 - Fixes RecentlyClosedAdapter DiffCallback (#16608) 2020-11-17 10:40:33 -05:00
Mozilla L10n Automation Bot
edfb85b021 Import l10n. 2020-11-16 17:33:42 -08:00
Christian Sadilek
1d5f74d865 Closes #16153: Intermittent failures of ShareControllerTest.handleShareToApp 2020-11-16 18:50:48 -05:00
mcarare
0d37c8f268 For #16420: Make search bar first view focused by a11y services on open. 2020-11-16 17:30:52 -05:00
Christian Sadilek
88f3f3564e Issue #16587: Make sure tab counter correctly reflects private/normal tab counts 2020-11-16 13:41:51 -08:00
Christian Sadilek
fbbc25b54e Closes #16053: Fix crash when closing private tabs via notification 2020-11-16 13:41:51 -08:00
MickeyMoz
2c4f0624fd Update Android Components version to 67.0.20201115143123. 2020-11-16 11:37:03 +01:00
Mozilla L10n Automation Bot
4895cf4e91 Import l10n. 2020-11-16 10:34:18 +01:00
Jonathan Almeida
78715c3020
For #13477 - Move BiometricPrompt to a separate feature (#16498) 
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
 2020-11-14 12:20:05 -05:00
Mihai Adrian Carare
85dd2f8313
For #16511 - Change a11y parent of button without breaking the tab list. (#16555) 2020-11-13 22:57:06 -05:00
Mozilla L10n Automation Bot
af666d8c57 Import l10n. 2020-11-13 17:09:02 -08:00
Michael Comella
94bbf90f3c No issue: move TestStrictModeManager to perf sub package. 2020-11-13 16:07:59 -08:00
Michael Comella
e8bf955893 No issue: move StrictModeManager to perf package. 
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
 2020-11-13 16:07:59 -08:00
Michael Comella
72ab058551 For #16376: move Startup*Test to perf pkg under code owners. 
Instead of listing many different files here, we should just put them in
/perf/ packages and code owner them.
 2020-11-13 15:39:06 -08:00
Michael Comella
54c7dc70e7 For #16376: assert num ConstraintLayout direct descend RecyclerView. 
I'm not convinced this is a useful test because the performance
characteristics seem unfortunately nuanced: if the test fails, it implies
you shouldn't add more but that isn't necessarily true (for example, if
your RV child has a large depth). Furthermore, we haven't measured in a
variety of circumstances that layouts like LinearLayout perform better
as RecyclerView children so maybe it only held for the one small case we
used it in.
 2020-11-13 15:39:06 -08:00
Michael Comella
b0a1e0884e For #16376: test view hierarchy depth in StartupExcessive*Test. 2020-11-13 15:39:06 -08:00
Jocelyne Abi Haidar
88233ef42d For #15725: Set up preferences in onCreatePreferences instead of onResume 
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
 2020-11-13 18:14:02 -05:00
Oana Horvath
10dadb838e Closes #12899: fixed UI test for ETP off 2020-11-13 13:00:46 +02:00
mcarare
d45bdfb0f4 For #16477: Switch to using an extension to update a11y collection info. 2020-11-13 11:17:47 +02:00
mcarare
e2322a18f9 For #16477: Migrate updateAccessibilityCollectionItemInfo to extension. 2020-11-13 11:17:47 +02:00
mcarare
b52f069573 For #16477: Update a11y info to collection item for both grid and list. 2020-11-13 11:17:47 +02:00
Bryan Kok
92b93081e5
Replace lingering occurence of ic_hollow_share with ic_share_filled (#16548) 2020-11-13 10:46:21 +02:00
Mugurell
c6de8632de
For #16461 - Ensure the proper items order after exiting Multiselect (#16482) 2020-11-13 07:32:45 +02:00
LeoMaldonado
a06b30a73d Fixes Comment on #16563: DefaultToolbarMenu registering for bookmark changes 
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
 2020-11-12 19:57:36 -08:00
LeoMaldonado
2d8fe7a9ad Closes #16345: Update share icon shape 
updating share icon to a filled shape, like default toolbar menu across all app
 2020-11-12 19:57:36 -08:00
LeoMaldonado
84eda3d38f For #16345: use same share icon across all app 
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
 2020-11-12 19:57:36 -08:00
Gabriel Luong
27ee2ba4f6
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16546) 
* For #15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag

* For #15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
 2020-11-12 21:14:34 -05:00
mozilla-l10n-automation-bot
6ebc90deae
Import l10n. (#16486) 2020-11-12 19:56:19 -05:00
Gabriel Luong
e9d335cb24
Revert "For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535)" (#16544) 
This reverts commit 7499d33b32.
 2020-11-12 17:17:36 -05:00
rxumoz
409041ae3b
For #16451 - Change default top sites to Baidu & JD in China build (#16515) 
* Add top sites related strings

* Change default top sites to Baidu & JD in China build
 2020-11-12 16:53:50 -05:00
Gabriel Luong
7499d33b32
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535) 2020-11-12 15:17:38 -05:00
Mugurell
d1f2705d99
For #16076 - Link data review for the share_image telemetry (#16534) 2020-11-12 20:14:59 +02:00
ekager
1ed9ebf622 For #16132 - Rename normal mode menu item, remove telemetry 2020-11-12 09:11:16 -08:00
Gabriel Luong
ebadbdb352
For #14920 - Show a Tabs Tray CFR Banner for grid view tip (#16466) 2020-11-12 11:52:59 -05:00
Sebastian Kaspari
5530e102f1
For #16302 - Use larger heap size when running unit tests and fork new process after every 80 test classes. (#16526) 2020-11-12 11:09:27 -05:00
Codrut Topliceanu
f3edce5f16
For #11376 - Reverse tabs list order (#16245) 2020-11-12 10:58:02 -05:00
Oana Horvath
ae407a7367 Closes #13217: fixed UI test for main menu items 2020-11-12 16:33:54 +02:00
Johan Lorenzo
4570f5a14f Revert "Update Android Components version to 66.0.20201111143206." 
This reverts commit dbdb68ac72.
 2020-11-12 12:48:00 +01:00
Kate Glazko
6c68e79a22 For #14772: Crash in Downloads 2020-11-11 12:17:28 -08:00
Mugurell
a097b135b3 For #16076 - Add new "share_image" telemetry event 2020-11-11 11:12:53 -08:00
MickeyMoz
dbdb68ac72 Update Android Components version to 66.0.20201111143206. 2020-11-11 10:18:01 -08:00
Mugurell
c3179512de
For #16500 - Ensure CardView clips ImageView on lower APIs (#16507) 
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
 2020-11-11 20:10:12 +02:00
mcarare
c427ebf8d5 For #16416: Remove save to collection button from tab a11y list. 2020-11-11 12:13:35 +02:00
ekager
a8db85fc22 For #16132 - Revise multiselect mode UI 2020-11-10 17:15:19 -08:00
mozilla-l10n-automation-bot
c8aee39db1
Import l10n. (#16468) 2020-11-10 16:14:29 +02:00
Mugurell
5e58377948
For #16424 - Focus the right item in tabs tray when using Talkback (#16472) 
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
 2020-11-10 15:10:50 +02:00
Codrut Topliceanu
6e4393a199
For #15720 - Remove unused telemetry (#15887) 2020-11-09 17:24:46 -05:00
Gabriel Luong
b5c25ccf3b
For #15960 - Enable Grid View in Nightly only (#16462) 2020-11-09 17:09:31 -05:00
mcarare
928d320836 For #16426: Allow multiselect title to be selected by a11y services. 2020-11-09 10:23:51 -08:00
mozilla-l10n-automation-bot
517ff91753
Import l10n. (#16447) 2020-11-09 09:39:52 -05:00
Christian Sadilek
0fbc8410a4 Closes #16430: ExternalAppBrowserActivity should not handle incoming intents 2020-11-09 09:29:55 +01:00
mozilla-l10n-automation-bot
2fb7383684
Import l10n. (#16441) 2020-11-06 19:48:10 -05:00
Mihai Adrian Carare
c641ed72dc
For #15764 - Update Tabs summary description. (#16428) 2020-11-06 17:30:59 -05:00
Christian Sadilek
96e2123f86
Update Android Components version to 66.0.20201106143126 (#16439) 2020-11-06 17:22:46 -05:00
Oana Horvath
5e745d0bc3 For #15847: use Espresso's RecyclerView scrollTo action 2020-11-06 15:28:31 +02:00
Mozilla L10n Automation Bot
1ad5ea58a2 Import l10n. 2020-11-06 14:19:41 +01:00
Christian Sadilek
4abd399002 Closes #16327: Refactor MenuPresenter to use browser store 2020-11-05 16:45:10 -05:00
Arturo Mejia
50d7792330 For issue #15934 fix ConcurrentModificationException 
on WifiConnectionMonitor
 2020-11-05 14:24:37 -05:00
Sebastian Kaspari
1dca411515 Fix GeckoProvider for beta and release variant. 2020-11-05 14:23:25 -05:00
rxu
686f7bd7c6 Add mozcn safebrowsing 2020-11-05 18:02:30 +01:00
Michael Comella
afa080c956 For #15279 - review: set LazyMonitored to private. 2020-11-05 07:48:17 -08:00
Michael Comella
c96e16112f For #15279: add component init count to StartupExcessiveResourceUseTest. 2020-11-05 07:48:17 -08:00
Michael Comella
090650485f For #15279: remove redundant lazy wrapper from storage APIs. 
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
 2020-11-05 07:48:17 -08:00
Michael Comella
89541a17f7 For #15279: LazyMonitored implement Lazy + update built-in API use. 
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
 2020-11-05 07:48:17 -08:00
Michael Comella
901c78684c For #15279: replace lazy with lazyMonitored in component groups. 
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".

There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
 2020-11-05 07:48:17 -08:00
Michael Comella
f37ace0630 For #15279: add LazyMonitored and tests. 2020-11-05 07:48:17 -08:00
mozilla-l10n-automation-bot
de3c4bc635
Import l10n. (#16380) 2020-11-04 18:58:23 -08:00
Kate Glazko
0ae268914b For #352: Delete a download 2020-11-04 13:32:24 -08:00
ekager
c0e01373e1 No issue: Update stable androidx and material versions 2020-11-04 12:00:32 -08:00
Mugurell
88bfaaabe7
For #6521 - Remove auto sigin onboarding card (#16315) 
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when #15694 would add
to Fenix the ability to serve as a custom account provider.
 2020-11-04 17:23:19 +02:00
Mugurell
1358e09d7e
For #16323 - Use 10dp corner radius for the selected outer border of a grid item (#16364) 
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
 2020-11-04 10:03:43 -05:00
Mugurell
172977f698
For #14980 - Effectively disable tabs tray STATE_HALF_EXPANDED (#16052) 
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
 2020-11-04 11:22:46 +02:00
Mihai Adrian Carare
db58022fbb
For #13172 - Tab swipe order follows text direction from oldest to newest (#16178) 2020-11-03 15:48:00 -05:00
Rafał Opiłowski
96fb9f4676
For #12971 - Show collection saved snackbar above FAB (#16311) 2020-11-03 15:45:23 -05:00
Oana Horvath
c3204b7644
For #15847 - Disables verifyAboutFirefoxPreview UI test (#16346) 2020-11-03 15:31:36 -05:00
Mugurell
34f0c84d46
For #16339 - Initialize FxaAccountManager with also a CrashReporter (#16340) 2020-11-03 14:46:08 +02:00
Sebastian Kaspari
baaa85db80 Closes #16256: Introduce build flag for "Mozilla Online" variant. 
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
 2020-11-03 10:34:25 +01:00
Oana Horvath
4ff2635423 For #13446 UI tests: wait for historyList to exist 2020-11-03 10:59:33 +02:00
Mozilla L10n Automation Bot
e61e5b80dd Import l10n. 2020-11-02 19:44:47 -08:00
Gabriel Luong
2bd2a5651d
For #14636 - Update preference section headers to use correct color, spacing and rulers (#16332) 2020-11-02 19:56:41 -05:00
Michael Comella
2b621fcb1b No issue - review: clarify thread safety of suppressionCount. 2020-11-02 15:37:04 -08:00
Michael Comella
bff8a0d6a7 No issue: make StrictMode suppression count thread safe. 2020-11-02 15:37:04 -08:00
Christian Sadilek
d7688c8427 For #12062: Switch to consumeFlow and add tests 2020-11-02 14:23:33 -08:00
ekager
bd2c407943 For #4652 - Remove activityViewModels workarounds 2020-11-02 11:30:37 -08:00
MarcLeclair
7b1af41b40
15278 detekt rule runblocking (#15942) 
* For #15278: added CoroutineManager to count runBlocking calls

* For #15278: Added actual detekt rule for runblocking and its config to the yaml

* For #15278: Added unit test for RunblockingCounter

* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For #15278: made runblocking a Long to prevent overflow

* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For #15278: Added setup for unit test, since it failed without restting counter

* For #15278: Fixed naming for RunBlocking lint check

* For #15278: removed changes made to test to use runBlockingIncrement

* For #15728: added test exclusion for runBlocking check

* For #15278: changed null check and added Synchronized to count setter

* For #15278: fix for nits

* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For #15278: fixed for nits

* For #15278: Moved increment function to extension function and fixed indentation

* For #15278: Added tests for Atomic Integer extension and nit fix
 2020-11-02 12:49:17 -05:00
ekager
d46fc7b142 For #6313 - Remove unneeded delay in BrowserAnimator 2020-11-02 09:38:15 -08:00
Roger Yang
b65c798450
For #16268 - Allowing multiple task while sharing (#16275) 2020-11-02 11:16:29 -05:00
Jocelyne Abi Haidar
1b204158e5
For #15931: Sort Downloads from newest to oldest (#15939) 2020-11-02 11:06:30 -05:00
mcarare
142d7a418c For #15430: Fix StrictMode death on opening app from widget voice search. 2020-11-02 15:50:12 +02:00
mcarare
5b0bdda974 For #15430: Fix StrictMode death on opening app from widget text search. 2020-11-02 15:50:12 +02:00
mcarare
adbb262787 For #14552: Do not display back button when there is no tab history. 2020-11-02 14:25:49 +02:00
Mozilla L10n Automation Bot
bf69519dc9 Import l10n. 2020-11-02 00:12:21 -05:00
Mugurell
a6092c34cc For #15963 - Increase touch target for the close button in the tabs tray grid layout 
We need to ensure it has at least 48dp while also not appearing too big.
 2020-10-30 18:13:50 -04:00
Mugurell
83bd80c873 For #15757 - Avoid the double spacing issues for grid items in tabs tray 
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
 2020-10-30 18:13:50 -04:00
Mugurell
0324baef03 For #15968 - Show a border for the selected tab in the grid based tabs tray 
The border for the grid item will now be updated in the same method that
updates the background for the list item.
 2020-10-30 18:13:50 -04:00
Mugurell
482739ba8c For #15756 - Add a play/pause button in the tabs tray grid layout 
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
 2020-10-30 18:13:50 -04:00
Gabriel Luong
66210469c0
For #9548 - Ability to rename top sites (#16285) 
* Ability to rename top sites, closes #9548

* Highlight the "Remove" top site action as destructive

With more menu items in the top site contextual menu, it makes sense to differentiate

* Added test for the top site renaming action

* Fixed lint check (wildcard imports, blank spaces)

* Applied suggestions from code review

* Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Implemented dialog click listener with manual dismiss/cancel

Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
 2020-10-30 15:08:04 -04:00
ekager
9bb3440fce No issue: Make sure we are cleaning up test coroutines 2020-10-29 18:57:23 -07:00
mozilla-l10n-automation-bot
d1ec6cac86
Import l10n. (#16274) 2020-10-29 21:40:40 -04:00
ekager
4246293a93 For #16161 - Fixes Saved Login toolbar layout 2020-10-29 16:10:06 -07:00
Codrut Topliceanu
975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump (#16229) 
* For #14637 - Compatibility patch for AC - 8554

* Update Android Components version to 65.0.20201029143039

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-10-29 19:08:31 -04:00
mozilla-l10n-automation-bot
e21c81a0dd
Import l10n. (#16240) 2020-10-29 10:42:14 -04:00
mcarare
3cb2c83980 For #16250: Disable remote USB debugging for SDK <23. 2020-10-29 15:02:02 +01:00
Mihai Adrian Carare
0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. (#16081) 
* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
 2020-10-28 13:46:02 -07:00
mcarare
9748c65c71 For #15413: Use proper url when bookmarking a page. 2020-10-28 16:33:48 +02:00
Oana Horvath
e36e61b2c3 For #10690: re-enable editBookmarkTest 2020-10-28 16:09:52 +02:00
Mozilla L10n Automation Bot
5739140ff3 Import l10n. 2020-10-28 10:54:41 +01:00
Arturo Mejia
bb7d821804 Fix AddonsManagementFragment detekt error 2020-10-27 19:23:32 -04:00
Christian Sadilek
c330426bb7 No issue: Fix onConfigurationChange crashes in Debug build 2020-10-27 18:54:07 -04:00
Christian Sadilek
601aa19176 Closes #11285: Replace Session[Manager] observers in BaseBrowserFragment 2020-10-27 17:40:58 -04:00
Grisha Kruglov
655a5cbf54 Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context 2020-10-27 16:18:19 -04:00
mcarare
21a67de947 For #15379: Use proper url when sharing. 2020-10-27 14:15:56 -04:00
ekager
9b2162fca2 For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent 2020-10-27 09:13:13 -07:00
Arturo Mejia
0ae0b89d65 Fix add-on translation braking changes 2020-10-27 11:33:18 -04:00
Aaron Train
b8fff8cef1
For #8169 - Upgrade Mockwebserver (#16186) 
Upgrades Mockwebserver to 4.9.0
 2020-10-27 10:19:24 -04:00
mozilla-l10n-automation-bot
b8d6dbd426
Import l10n. (#16198) 2020-10-26 20:28:45 -04:00
Lorenzo Stanco
90220678cf
For #16122 - Add a dark theme color for the top sites pin icon (#16180) 2020-10-26 18:50:41 -04:00
mozilla-l10n-automation-bot
7d59a58134
Import l10n. (#16163) 2020-10-26 12:07:02 -04:00
mozilla-l10n-automation-bot
6353e9979e
Import l10n. (#16154) 2020-10-23 22:18:34 -04:00
ekager
e15f50712a For #6313 - Set session ClearColor through Engine DefaultSettings 2020-10-22 20:36:04 -07:00
mozilla-l10n-automation-bot
4acf3c601d
Import l10n. (#16138) 2020-10-22 23:12:05 -04:00