Commit Graph

40658 Commits (f4fcb83efd3fbda53b4c72210790e7f987bf31f2)

Author SHA1 Message Date
Jonathan G Rennison a58d910a0b Debug: Include cost multipliers in rail and road type debug info 2 years ago
Jonathan G Rennison 3d8187261a Debug: Include values when logging GRF base cost changes 2 years ago
Jonathan G Rennison 681b9e08f0 Fix fc5e2071: Incorrect translation string codes 2 years ago
Jonathan G Rennison 08bb440b47 Merge branch 'master' into jgrpp 2 years ago
translators 81388d9425 Update: Translations from eints
chinese (simplified): 7 changes by XiaoJi-Game
2 years ago
Jonathan G Rennison 9c255850a5 Add AI/GS method to get annual expense category value
See: #425
2 years ago
Jonathan G Rennison 2ff11017dc Fix #432: Fix false positive warning in CheckCaches with very old saves 2 years ago
Jonathan G Rennison bc3b928d34 Fix improved breakdowns being enabled after loading old/other savegame 2 years ago
Jonathan G Rennison c7e4dbf2f6 Fix displayed capacities/weights of articulated vehicles in build window
Simplify handling of multi-part capacities and refits

See: https://github.com/OpenTTD/OpenTTD/issues/9954
See: https://github.com/OpenTTD/OpenTTD/issues/10032
2 years ago
translators 0c8db77154 Update: Translations from eints
dutch: 6 changes by Afoklala
2 years ago
Jonathan G Rennison f61562efef Fix network clients setting old company settings for new companies 2 years ago
Jonathan G Rennison 175ef00985 Avoid dangling company purchase timeout when no clients connected to company 2 years ago
Jonathan G Rennison 839746d2bb Fix template train move/sell command category for build while paused 2 years ago
Jonathan G Rennison fc5e20719d Fix #423: Max TE/weight should not be shown for maglevs 2 years ago
translators b38051c9ad Update: Translations from eints
galician: 11 changes by pvillaverde
polish: 5 changes by pAter-exe
2 years ago
Jonathan G Rennison 5825fec5bf Fix #427: Recursive DoCommandP call issuing CMD_DECLINE_BUY_COMPANY
Ignore shift and pause states for CMD_DECLINE_BUY_COMPANY command
2 years ago
Jonathan G Rennison bd2593ca48 Add function to enqueue a DoCommandP call 2 years ago
Jonathan G Rennison 5cb6d2240a Add command flag to disable shift-key estimate mode in DoCommandP 2 years ago
translators 984e0b1263 Update: Translations from eints
spanish (mexican): 5 changes by absay
catalan: 6 changes by J0anJosep
2 years ago
Jonathan G Rennison ece0a43146 Merge branch 'master' into jgrpp
# Conflicts:
#	src/newgrf_station.cpp
2 years ago
Fedello 3150151aa6
[Feat] Updated Galician translations up to v0.48.2 (#428)
* [Feat] Subsidy fix

* [Feat] Updated Galician Translation 0.48.2

* [Doc] Command used to obtain translations

Co-authored-by: pvillaverde <pvillaverde@qualigy.com>
2 years ago
translators d29289addb Update: Translations from eints
english (us): 6 changes by 2TallTyler
russian: 2 changes by Ln-Wolf
portuguese: 6 changes by azulcosta
2 years ago
dP 64453cb134
Fix: Incorrect player name in online players window (#10013) 2 years ago
Andy 129979acf7
Change: 'string' is spurious in 'Filter string:' labels for filter UI widgets (#10022) 2 years ago
Andy 039f90d05f
Feature: add sticky pin to Object Selection UI panel (#10019) 2 years ago
frosch e2c46fda3f Fix: [NewGRF] Ensure that stations always have an even number of sprite layouts.
The drawing code has a special fallbacks for zero layouts, but fails hard for one layout.
(odd numbers >= 3 are weird, but do not fail as badly as 1)
2 years ago
frosch 5c66de860d Fix: [NewGRF] Result bit 0 of callback 14 was not ignored in the GUI. 2 years ago
frosch f7022925d3 Cleanup: [NewGRF] Callback 14 used a weird value for var10 in the GUI.
The value 0x2110000 probably originated from a mixup between callback 14 (sprite layout) and 24 (tile layout).
The latter does indeed use a var10 value like that.
2 years ago
Andy a06d323f03
Feature: add shade widget to Object Selection UI panel (#10020) 2 years ago
Jonathan G Rennison 143230d8f2 Allow changing road vehicle driving side when all road vehicles in depots 2 years ago
Jonathan G Rennison a8d5e56696 Crashlog: Only output dump files for MSVC builds 2 years ago
PeterN f279fc5772
Fix: DrawStringMultiLine() could overdraw (#10014)
This function did not take the line height into account when checking text will fit before the bottom bounds.
2 years ago
Jonathan G Rennison ad9d593a51 Fix assertion failure setting player face for new company in multiplayer
See: https://github.com/OpenTTD/OpenTTD/issues/10016
2 years ago
Jonathan G Rennison 22b2ce0bc6 Fix incorrect infrastructure totals when overbuilding bay road stop
With different road/tram type

See: https://github.com/OpenTTD/OpenTTD/issues/10011
2 years ago
Jonathan G Rennison 7a4b0417b0 Codechange: Fix unnecessary string reallocation in IConsoleLine constructor 2 years ago
Jonathan G Rennison 3a313324dc Fix #10010: Memory leak in IConsolePrint in non-dedicated case 2 years ago
Jonathan G Rennison f4f221b1e0 Fix crash which could occur when adding plans in single player 2 years ago
Jonathan G Rennison 751e0a2d9e Merge branch 'master' into jgrpp 2 years ago
Jonathan G Rennison 62ffa130c0 Fix #420: Wrong string code in STR_NEWS_VEHICLE_AUTORENEW_FAILED 2 years ago
translators 0355299639 Update: Translations from eints
dutch: 36 changes by Bouke
2 years ago
Jonathan G Rennison 7c4c75d181 Add tracerestrict conditional on direction of order target from signal 2 years ago
Jonathan G Rennison 4e368beaca Fix #417: Wrong window caption for cargo payment graph in average speed mode 2 years ago
Jonathan G Rennison da3b1b9c32 Template replacement: Show warning if chain not compatible with any rail type
See: #419
2 years ago
Jonathan G Rennison 764a67b168 Fix wrong header comment in CallVehicleTicks 2 years ago
Jonathan G Rennison 33e3e571d3 Return specific error when wagon purchase fails due to wrong depot type
See: #419
2 years ago
translators 0c848a9b3b Update: Translations from eints
dutch: 2 changes by Bouke
2 years ago
Jonathan G Rennison a97d5cb333 Fix incorrect template replacement error message when chain not buildable
And no specific error returned

See: #419
2 years ago
Bouke Haarsma 18c210b013 Fix: title positioning on HiDPI displays 2 years ago
Jonathan G Rennison 5a39734a1c Allow station cargo histories to record larger values than 64k
See: #414
2 years ago
Jonathan G Rennison 1d93cd59e7 Add utility function for integer dynamic range extension encoding 2 years ago
Peter Nelson 2d2a5dd966 Fix: Change duration of news window scroll depending on GUI zoom. 2 years ago
Peter Nelson 8b989d4999 Fix: Update news window viewport if GUI zoom is changed. 2 years ago
Jonathan G Rennison 1e7ca9f71a Merge branch 'master' into jgrpp 2 years ago
Jonathan G Rennison 4b9d5a437f Add GS methods to set inflation factors
See: #415
2 years ago
Jonathan G Rennison 81291c4ffc Add AI/GS methods to get inflation factors
See: #415
2 years ago
translators 57fa8690df Update: Translations from eints
dutch: 1 change by Bouke
2 years ago
Jonathan G Rennison 4049cb1407 MacOS: Use _exit instead of exit on execvp failure in crashlog 2 years ago
Jonathan G Rennison e64427d034 Crashlog: Unix: Add BFD inline info support 2 years ago
Jonathan G Rennison ad1e4ca334 Crashlog: Windows: Add BFD inline info support 2 years ago
Patric Stout 8ac0ab47b0
Update: to all the friends we have lost and those we have gained (#10000) 2 years ago
Jonathan G Rennison 3d39e439f6 Unix: Use _exit instead of exit on execvp failure in crashlog 2 years ago
Jonathan G Rennison 0811990d4a Unix: Try using addr2line for crash log backtrace symbol resolution 2 years ago
Jonathan G Rennison e3896b69d3 Fix #416: Division by zero for trains of 0 mass
In maximum achievable speed estimator
2 years ago
frosch 54ac304828
Fix: [NewGRF] Upper 16 random bits should be the same for all station tiles in callback 140. (#9992) 2 years ago
Jonathan G Rennison 0400f06d9e Debug: Show industry GRF local ID in debug window 2 years ago
Jonathan G Rennison 48d0a0e15c Fix #413: Truncation of expense type names in finance windows 2 years ago
Jonathan G Rennison 3d857333c8 Reduce delays with company bankrupcty/sale processing at high day lengths 2 years ago
Jonathan G Rennison 23fa7cd239 Improve handling of company sales
Avoid conflicts between bankruptcy and manual company sale paths
2 years ago
Jonathan G Rennison 142a5a95ec Merge branch 'master' into jgrpp
# Conflicts:
#	.github/workflows/release.yml
#	src/goal_cmd.h
#	src/industry_cmd.cpp
2 years ago
dP c839950791
Cleanup: Remove duplicate command_type.h include (#9986) 2 years ago
frosch 9529703cab
Codechange: When checking industry placement conditions, perform cheap checks first. (#9987)
1. Built-in checks on industry level.
2. Built-in checks on industry tiles.
3. NewGRF-defined checks on industry level.
4. NewGRF-defined checks on industry tiles.
2 years ago
Loïc Guilloux 31668b8f94
Fix #9914, 86818e5: prevent more useless pathfinder run for blocked vehicles (#9917) 2 years ago
Jonathan G Rennison dc5e073379 Merge branch 'master' into jgrpp 2 years ago
Tyler Trahan 788b06fe0f
Change: New player companies use favorite manager face, if saved (#9895) 2 years ago
Joel-Milligan 3937953f72
Fix #9363: Rebuild client list on reinit event (#9929) 2 years ago
dP ca23e8abcf Add step console command to advance n ticks
Cherry-picked from https://github.com/citymania-org/cmclient
Commit: 5ce2d21223a96934a83b8da43434c7a81f001ef0
2 years ago
Jonathan G Rennison 50965bbce7 Add road stops flag to disable auto road connections
Bump road stops version
2 years ago
Jonathan G Rennison 2a41854f6b VarAction2: Infer ternary add result is bool if both branches are bool 2 years ago
Jonathan G Rennison 8c94ba0dc8 VarAction2: Infer that multiplying two bools results in bool 2 years ago
Jonathan G Rennison 7c78b22c48 Show failure reason in message box when network savegame load fails
See: #412
2 years ago
Jonathan G Rennison edd8b29794 Don't trigger signal state/style desync message in GM_MENU mode
This occurs when loading a network savegame fails and the menu
game is reloaded
2 years ago
Niels Martin Hansen 5a0dd7e322 Fix #9971: Don't assert that time moves forward 2 years ago
Jonathan G Rennison 22a1fdff5e Log error message to console in LoadWithFilter exception handler
See: #412
2 years ago
Niels Martin Hansen 4253db28fa Fix #9972: Add some missing fill/resize flags on Framerate window widgets 2 years ago
translators db378e746b Update: Translations from eints
korean: 2 changes by telk5093
2 years ago
Jonathan G Rennison 1d08572cfa Merge branch 'master' into jgrpp
# Conflicts:
#	src/lang/english_AU.txt
#	src/openttd.cpp
#	src/viewport_sprite_sorter_sse4.cpp
2 years ago
Niels Martin Hansen e6aab701c9 Fix #9977: Use a deque rather than linked list for console buffer 2 years ago
Niels Martin Hansen aaab0610eb Fix: Only apply debuglevel changes after successful parse 2 years ago
Niels Martin Hansen c6953f13e4 Fix #9940: Print debuglevel parse errors to console when changed from console 2 years ago
translators dcdc8d187c Update: Translations from eints
dutch: 1 change by Bouke
2 years ago
frosch acf9d786f1
Fix: [NewGRF] Default value of RailVehicleInfo::railveh_type was inconsistent with other default properties. (#9967)
If a NewGRF assigned neither "power" nor "dual-headed" properties,
then "railveh_type" defaulted to "singlehead-engine", while "power=0" said "it's a wagon".
2 years ago
glx22 bba6ad1f4e Fix #9935: Use more selectivity when building SSE specific code 2 years ago
translators e9507e7ffa Update: Translations from eints
latvian: 31 changes by lexuslatvia
2 years ago
Jonathan G Rennison 602ac717aa Initial support for DSE and jumping over procedures with child groups 2 years ago
translators 04911822c1 Update: Translations from eints
indonesian: 1 change by K4smun1
2 years ago
Jonathan G Rennison 916441d943 VarAction2: Avoid turning skip on zero/LSB set sequences into jumps 2 years ago
Jonathan G Rennison 0bec49fa56 Skip sound effects handling earlier if effects volume is 0 2 years ago
Jonathan G Rennison 4fd8634ff9 VarAction2: Remove trivially redundant special stores 2 years ago
glx22 e3968cdf65 Fix #9974, aa5a8fe: strftime buffer maxsize is off by one
strftime() return value doesn't count NULL character, but buffer size must include it.
2 years ago
Jonathan G Rennison d9aa2d6138 VarAction2: Extend group cast to bool range elision
Handle opposite arrangement of range and default group
2 years ago
Jonathan G Rennison df6b9d355f VarAction2: Simplify store, load with bool/invert, ternary sequence in DSE 2 years ago
translators 882b8f45d9 Update: Translations from eints
hungarian: 31 changes by andrejmoltok
romanian: 27 changes by andrejmoltok
2 years ago
Jonathan G Rennison 173f867e1a VarAction2: Save calculated_result in shadow group struct 2 years ago
Jonathan G Rennison 14de8c7f34 VarAction2: Add quick exit case to last-level callback groups if possible 2 years ago
Jonathan G Rennison 35063b2176 VarAction2: Ensure group pruning can't break var 1C via random groups 2 years ago
Jonathan G Rennison 3676b0912d VarAction2: Fix inference handling when pruning ops prior to RST 2 years ago
Jonathan G Rennison c60e3fed99 VarAction2: Do not re-assign error group
When pruning ranges of group with constant result
2 years ago
Jonathan G Rennison 0bcdaba0f9 VarAction2: Add constructor for AnalyseCallbackOperation 2 years ago
Jonathan G Rennison a0c894d067 Debug: Add a visual indicator in indent for var 0x7E procedure calls 2 years ago
translators 417f9bb48d Update: Translations from eints
french: 1 change by glx22
hindi: 18 changes by baijuch
2 years ago
Jonathan G Rennison 680e074a5f Debug: Fix sprite dumping of top level default group 2 years ago
Jonathan G Rennison 8688840e24 Viewport route step markers are now variable size to match font/text
See: #410
2 years ago
Jonathan G Rennison 8c0eca28a8 Recalculated route step sprite sizes when changing zoom levels 2 years ago
translators 88a046a76e Update: Translations from eints
korean: 7 changes by telk5093
2 years ago
Jonathan G Rennison 84da7ad7b6 Add setting to show group hierarchy in vehicle names
See: #405
2 years ago
Jonathan G Rennison e335c86e77 VarAction2: Elide group ranges as cast to bool when result is already bool 2 years ago
Jonathan G Rennison b04d1295cd VarAction2: Infer that unsigned mod 2 results in 0 or 1 2 years ago
Jonathan G Rennison ad00f5032a Add a setting to show the introduction year for train wagons 2 years ago
Jonathan G Rennison ad9e1a8fb3 Increase value of MAX_SL_OPS constant 2 years ago
Jonathan G Rennison e584ef7bba Move NewGRF analysis to separate files 2 years ago
Jonathan G Rennison 9c18835bd0 Move ProcessDeterministicSpriteGroupRanges into newgrf.cpp 2 years ago
Jonathan G Rennison 0f8dc86120 Remove setting string now unused since 309f1b47 2 years ago
Jonathan G Rennison 309f1b47d2 Only apply sprite_zoom_min setting when suitable zoom levels are available
Only discard sprite zoom levels when a suitable higher zoom level is
defined in the same colour mode

See: https://github.com/OpenTTD/OpenTTD/issues/9804
2 years ago
Jonathan G Rennison 27316f70ec Create enum for sprite cache control flag bits 2 years ago
Jonathan G Rennison 4e5e85e7aa Debug: Allow inspecting industry specs before industry is built
Add debug box to industry chains window
2 years ago
Jonathan G Rennison c58b94c376 VarAction2: DSE: Allow setting skip on zero flag on skippable procedures 2 years ago
Jonathan G Rennison 4601a1bfc6 Move NewGRF optimiser functions into a separate file
Create a new header for shared definitions with newgrf.cpp
2 years ago
Jonathan G Rennison 3d59c961a6 VarAction2: Avoid group variable tracking coupling through shared procs
Output dependencies on a procedure shouldn't propagate into input
dependencies on unrelated call sites in different groups
2 years ago
Jonathan G Rennison 00e32162a1 VarAction2: Allow DSE to remove procedure calls 2 years ago
Jonathan G Rennison 30ecdfe140 VarAction2: Allow jumping over constant stores to special registers
Insert suitable store(s) after the end block
2 years ago
Jonathan G Rennison 3a8bd7a589 VarAction2: Allow jumps to skip over procedure calls if possible 2 years ago
Jonathan G Rennison 9ed5b6e65c Debug: Change sprite group indentation handling 2 years ago
Jonathan G Rennison 41f2e92f5c VarAction2: Add a NOOP operator 2 years ago
translators be352ce1b6 Update: Translations from eints
catalan: 11 changes by J0anJosep
2 years ago
Jonathan G Rennison e143ab06d8 VarAction2: Track which temp stores may be overwritten by procedures
Instead of treating procedures as an unpredictable store
2 years ago
Jonathan G Rennison 06cc71b6c5 VarAction2: Mark suitable AND ops as jump insertion candidates 2 years ago
translators eb805b77b7 Update: Translations from eints
german: 1 change by SecretIdetity
2 years ago
Jonathan G Rennison aa49e17e39 Remove road vehicles during load which are uncorrectably invalid 2 years ago
Jonathan G Rennison bf618a3584 Debug: Add more stats to dump map and veh stats console commands 2 years ago
SamuXarick 374f0c7d11 Fix 6fe445e: Removing rail station parts without ctrl pressed was also removing tracks
The behaviour of holding ctrl key is swapped
2 years ago
Jonathan G Rennison 613c90e78f Fix GetClosestIndustry with invalid industry type when using cache 2 years ago
translators 6893135fef Update: Translations from eints
english (au): 536 changes by krysclarke
2 years ago
Jonathan G Rennison bc920df63a Fix excessive braking for slopes with realistic braking
Unit conversion issue between potential and kinetic energies
2 years ago
translators 5a404a17ee Update: Translations from eints
korean: 1 change by telk5093
polish: 1 change by pAter-exe
2 years ago
translators 6b4fd01eeb Update: Translations from eints
italian: 1 change by Rivarossi
2 years ago
Jonathan G Rennison 0bddf96f7f VarAction2: Set variable for ABS op to avoid unused read from var 0 2 years ago
Jonathan G Rennison dc69957dcc VarAction2: Cache industry distances in CBID_INDUSTRY_LOCATION 2 years ago
Jonathan G Rennison 0e1e892ca8 VarAction2: Use masking for sub-parts of industry var 67
Ensure that distance and count can't overflow on very large maps
2 years ago
Jonathan G Rennison 0a99440166 Debug: Always use head for vehicle debug window name in caption 2 years ago
translators b7462934e2 Update: Translations from eints
dutch: 1 change by Afoklala
2 years ago
Jonathan G Rennison dbc55274e2 Debug: Show callback ID names in sprite dump 2 years ago
Jonathan G Rennison 7af568f0f0 VarAction2: Handle case where expensive vars are only conditionally read
Within a JZ_LV and in prior DSGAF_SKIP_ON_ZERO op
2 years ago
Jonathan G Rennison 9a4c31b0da VarAction2: Add last_value variants of JZ/JNZ ops 2 years ago
Jonathan G Rennison cbc6199542 VarAction2: Add a JNZ op analogous to JZ for OR ops 2 years ago
Jonathan G Rennison 5ec802a3d4 VarAction2: Allow substituting perm store loads through temp store 2 years ago
Jonathan G Rennison cbabbb6db6 Fix train braking behaviour when lookahead is aspect limited
When lookahead end is within the reservation end
2 years ago
Jonathan G Rennison 71b6d7a502 Merge branch 'master' into jgrpp
# Conflicts:
#	src/lang/arabic_egypt.txt
#	src/station_cmd.cpp
#	src/station_cmd.h
#	src/timetable_cmd.cpp
#	src/train_cmd.cpp
2 years ago
translators ccb9d99880 Update: Translations from eints
arabic (egypt): 13 changes by AviationGamerX
persian: 16 changes by pooyana84
finnish: 33 changes by lanurmi
2 years ago
translators e3759931e7 Update: Translations from eints
english (us): 1 change by 2TallTyler
arabic (egypt): 62 changes by AviationGamerX
turkish: 1 change by ahmetlii
2 years ago
translators 97d79c8e52 Update: Translations from eints
spanish (mexican): 1 change by absay
catalan: 1 change by J0anJosep
2 years ago
Jonathan G Rennison c6817fab6e Don't use implicit orders for conditional order waiting loops
Fixes vehicles never leaving when the only order is an implicit order
(because vehicles were released with no orders)
2 years ago
translators d1d7e47896 Update: Translations from eints
russian: 1 change by Ln-Wolf
portuguese: 1 change by azulcosta
2 years ago
Jonathan G Rennison 70ef4c6d90
Merge pull request #407 from auge8472/lang-de
Translated most of the missing strings for German language, stand jgrpp 0.48.0
2 years ago
translators 77a8e3b649 Update: Translations from eints
polish: 1 change by pAter-exe
2 years ago
Heiko August 12aa409332 Change: translated most of the missing strings for German language 2 years ago
Nicolas Chappe 6d154e72dd Fix #8584: Vehicles with shared orders getting invalid or unexpected start dates 2 years ago
translators 67608350b6 Update: Translations from eints
finnish: 45 changes by lanurmi
portuguese (brazilian): 29 changes by rodigu
2 years ago
Jonathan G Rennison 67331fe946
Fix #9951: Scenario editor random industries button and persistent storage (#9952)
BasePersistentStorageArray::SwitchMode was not called
2 years ago
translators 8f772352ce Update: Translations from eints
italian: 1 change by Rivarossi
2 years ago
translators b199779ad4 Update: Translations from eints
chinese (simplified): 26 changes by ZZY2357
korean: 1 change by telk5093
2 years ago
Jonathan G Rennison 0735c4b851 Ensure that disabling infra sharing can't break realistic braking reservations 2 years ago
Jonathan G Rennison 856cea576f Fix infrastructure sharing checks not being executed when disabling 2 years ago
Jonathan G Rennison 27d4900fde Fix text colour for infrastructure sharing error messages 2 years ago
Jonathan G Rennison dc01d0cac4 Handle case where deleting a company removes part of a train's reservation
When realistic braking is enabled, which would ordinarily prevent
the track from being removed
2 years ago
Jonathan G Rennison ed737e1a8f VarAction2: Do not remove redundant adjusts when this would break var 1C 2 years ago
Jonathan G Rennison b9c22a0b9e VarAction2: Do not prune groups when this would break var 1C 2 years ago
Jonathan G Rennison ae746a1af4 VarAction2: Fix tracking of whether a sprite group needs var 1C 2 years ago
Jonathan G Rennison e497f0e78d Fix crash in tooltip window UpdateWidgetSize due to not using saved string 2 years ago
Jonathan G Rennison cd4a9fba68 Fix viewport map mode bridges/tunnels not appearing dotted at high zoom 2 years ago
Patric Stout 77a85e9b4c
Fix: CmdSetAutoReplace didn't validate group type and engine type match (#9950)
Basically, you could setup an auto-replace in a group for trains
to replace a ship with another ship.

Most of the code is surprisingly okay with this, it is only the
group statistics that doesn't like this.
2 years ago
Patric Stout 979704271b
Fix: reverse train direction command did not validate the given vehicle properly (#9947)
You could give a wagon in the chain to reverse (which makes no
functional sense ofc). In result, only parts of the vehicle were
reversing, leading to weird crashes.
2 years ago
Patric Stout 055121df80
Fix: depot-related commands did not validate depot tiles properly (#9948)
The bug comes in two slices:

1) the functions never actually checked if "tile" was a depot tile.
   This allowed executing the function on tile 0, where are the
   things like shadows of aircrafts are.
2) BuildDepotVehicleList() first checked if a vehicle is in a depot
   before checking if it was a primary vehicle. This is invalid
   for aircraft.

Fixing the first hides the second, and fixing the second makes the
first non-exploitable. But, fixing both felt like the best thing
to do.
2 years ago
Patric Stout 100aca1848
Fix: CmdRemoveRoadStop didn't validate the height property properly (#9945)
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.

But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
2 years ago
Patric Stout 9957675a66
Fix: autoreplace command did not validate the vehicle argument properly (#9946)
It first checked if the vehicle was in the depot, which for some types
is only a valid action for the primary vehicle. Afterwards, it checked
if the vehicle was a primary vehicle.
2 years ago
Patric Stout 4651ad94fe
Fix: commands with a RoadType in their arguments were not validated properly (#9944)
Although it was checked that RoadType was not 63 (INVALID_ROADTYPE),
and all values lower than 63 are fine, it also allowed values higher
than 63. As the RoadType is a "byte", it could contain values up
to 255.
2 years ago
Patric Stout 6810d09c1b
Fix: commands with Axis in their arguments were not validated properly (#9943)
When you don't type an Enum, it is a signed value. To validate
if an Axis is valid, it is checked to be lower than AXIS_END. Which
is the case for any value below 0.
2 years ago
Michael Lutz dd93244853 Fix: The first tile in commands received from a client wasn't validated properly. 2 years ago
Jonathan G Rennison 23e057cfac Don't apply show signals using default graphics settings for custom styles 2 years ago
TELK f2838768ca Update: Korean translation up to 0.48.0 2 years ago
TELK 3cace09207 Update: Match the lines of Korean lang. file with english's one 2 years ago
Jonathan G Rennison 96c63ab7fc Remove incorrect comment 2 years ago
Jonathan G Rennison 752e46dfcb Merge branch 'master' into jgrpp
# Conflicts:
#	src/station_cmd.cpp
2 years ago
glx22 44e3b05c50 Fix: Use more selectivity when building SSE specific code
See: https://github.com/OpenTTD/OpenTTD/issues/9935

(cherry picked from commit c3f55d53405af04bfe928d9e1a815e06c187ca50)
2 years ago
Jonathan G Rennison 432717b21d Enabled shared orders and occupancy buttons for competitor order windows 2 years ago
Jonathan G Rennison 4e8a8a5e0a Add conditional order to test if last/next dispatch slot is first/last 2 years ago
Jonathan G Rennison 116ddf4b35 Fix timetable automation with conditional order sequences 2 years ago
Jonathan G Rennison da57d75165 Debug: Print lookahead approach speeds for stations (using current order) 2 years ago
Jonathan G Rennison c6ae82b611 Fix 9ff161e4 boosting lookahead braking stats but not actual brake forces 2 years ago
Jonathan G Rennison bd28d5a239 Use order state at reservation time for signal mode tracerestrict eval 2 years ago
Jonathan G Rennison 12566f05ca Add tracerestrict actions used flags for order conditionals present 2 years ago
Jonathan G Rennison a5fb39b388 Use shunt for combined shunt/normal for routes into a bay with shunt exit 2 years ago
Jonathan G Rennison f98f5fd291 Fix not being able to build waypoints when custom types no longer present
And a custom type was previously selected
2 years ago
Jonathan G Rennison c19bd4473f Add signal style flag to require realistic braking 2 years ago
Jonathan G Rennison bdd97f1aea Add debug build console command to run tile loop handler on tile 2 years ago
Jonathan G Rennison e399853f2c Fix aspect propagation issues with combined shunt/normal signals 2 years ago
Jonathan G Rennison 05c7c528f5 Fix a6e3467d: Don't do cargo consistency checks after overriding cargo
This falsely triggers warning messages
2 years ago
Jonathan G Rennison 19af139631 Fix #9937: Station industries_near incorrect after removing part moved sign
RecomputeCatchment was being called before moving the sign tile
instead of afterwards
2 years ago
Jonathan G Rennison 6150edd3b4 Fix Station industries_near incorrect after removing part moved sign
RecomputeCatchment was being called before moving the sign tile
instead of afterwards

See: https://github.com/OpenTTD/OpenTTD/issues/9937
2 years ago
Jonathan G Rennison 91e0529a39 Fix train variable 0x63 using wrong rail type on dual rail type tiles 2 years ago
translators f72b9fa767 Update: Translations from eints
italian: 22 changes by Rivarossi
2 years ago
Jonathan G Rennison e6a6b50675 Include signal combined/normal style mask in aspect cfg hash 2 years ago
Jonathan G Rennison 1422cc871c Fix signal aspect re-calculation in bidi signal blocks with no junctions 2 years ago
Jonathan G Rennison e747f96c78 Fix signal aspect re-calculation with combined normal/shunt 2 years ago
Jonathan G Rennison d48912aa15 Add setting to show full group hierarchy in group names 2 years ago
Jonathan G Rennison d4a813e92e Show group name when grouping vehicles by shared orders
If all vehicles in shared order set are in the same group
2 years ago
Jonathan G Rennison 6a69a5495f Add tracerestrict action to set combined normal/shunt signal mode
Add associated conditional to get reservation end tile
2 years ago
Jonathan G Rennison 52f28eb5c1 Tracerestrict GUI: Refactor string handling for realistic braking warning 2 years ago
Jonathan G Rennison ae47b1636a Add a set of temporary std::strings which can be referenced by StringID 2 years ago
Jonathan G Rennison 4747e1d1d0 Merge PR #403 into jgrpp 2 years ago
Melvin Vermeeren d48234c81b
Add GUI setting to show order occupancy by default 2 years ago
Jonathan G Rennison 78ae295dfe Add combined normal and shunt aspect signal style flag 2 years ago
Jonathan G Rennison a6e3467d58 Fix virtual train consist change callbacks being run before cargotype set
When instantiating virtual train from non-buildable template train

See: #402

Also fixes instantiating virtual train from train not refitting leading
vehicle.
2 years ago
Jonathan G Rennison 759b00262e VarAction2: Allow more than one JZ to end on the same end block adjust 2 years ago
Jonathan G Rennison 9775f468e8 VarAction2: Fix jump insertion moving the end marker for another jump 2 years ago
Jonathan G Rennison 5b5fbaa476 Fix reservation error when a reserve through signal was the last tile
When there were no junctions earlier in the reservation
2 years ago
Jonathan G Rennison a451b76c45 Remove unused extern declaration 2 years ago
Jonathan G Rennison fa89036a27 Add function to get maximum signal aspect 2 years ago
Jonathan G Rennison 89f66236ff VarAction2: Fix SHR/SAR mixup in check for merge with prior RST 2 years ago
Jonathan G Rennison 5059054f0a Sending a vehicle to a depot for sale can now sell immediately
If the vehicle is already stopped in a suitable depot
2 years ago
Jonathan G Rennison 85e949a6ba Fix road/tram type check when moving depot orders to another depot 2 years ago
Jonathan G Rennison 21606df9d3 Fix adding second set of signals to tile not setting signal style 2 years ago
Jonathan G Rennison 8249f3d535 Fix land info window not having strings for no-entry signals 2 years ago
Jonathan G Rennison 04da11b668 Store signal style GRF to local map in savegame
Update existing signal style IDs as necessary
2 years ago
Jonathan G Rennison a73bc141a1 Remove unneeded calls to GetOtherTunnelBridgeEnd in AfterLoadCompanyStats 2 years ago
Jonathan G Rennison 0ed30d0200 Avoid maybe unintialised warning in struct UniscribeRun
See: #394
2 years ago
Jonathan G Rennison 96df13a032
Merge pull request #400 from telk5093/jgrpp
Update: Korean translation up to 10b415b
2 years ago
Jonathan G Rennison 2f7664fc93 Move signal style mask variables into a single struct 2 years ago
Jonathan G Rennison c1b54f1c31 Fix missing includes in newgrf_newsignals.h
See: #401
2 years ago
TELK 9c81951cef Update: Korean translation up to 10b415b 2 years ago
Jonathan G Rennison a311f12615 Add signals_style_lookahead_single_signal_only signal style property 2 years ago
Jonathan G Rennison 24e965061c Fix limit train lookahead to signal aspect when starting
From depot and within signal sighting distance (e.g. reverse)
2 years ago
translators ffd3c11ba7 Update: Translations from eints
italian: 8 changes by Rivarossi
spanish: 19 changes by MontyMontana
2 years ago
Jonathan G Rennison 10b415bf10 Level crossings: Clarify adjacent blocked crossing track status handler
Avoid unnecessary adjacent tile checks if crossing is not blocked
2 years ago
translators 68257e0d7d Update: Translations from eints
turkish: 1 change by jnmbk
spanish: 12 changes by MontyMontana
2 years ago
Jonathan G Rennison fcae909839 Add signal style flag for drawing on the opposite side 2 years ago
Jonathan G Rennison ff064e06b8 Fix race between network client disconnect and network window deletion 2 years ago
Jonathan G Rennison ccef4baea6 Remove header prototypes for non-existent functions 2 years ago
Jonathan G Rennison 3a064f127b Fix SetTrainReservationLookaheadEnd moving end nearer 2 years ago
Jonathan G Rennison 96cf0f95bf Adjust tunnel/bridge signal spacing to prefer a signal in the middle 2 years ago
Jonathan G Rennison b5d0c1d493 Debug: Show signalled tunnel/bridge info in debug window 2 years ago
Jonathan G Rennison 229613b06a VarAction2: Resolve jumps in advance to avoid needing to track nesting 2 years ago
Jonathan G Rennison b6e099121a Fix limit train lookahead to signal aspect within signalled tunnel/bridges 2 years ago
translators f64cf8679d Update: Translations from eints
chinese (traditional): 6 changes by wpi3
italian: 2 changes by Rivarossi
turkish: 1 change by jnmbk
2 years ago
translators 278c1d06cf Update: Translations from eints
italian: 6 changes by Rivarossi
turkish: 37 changes by jnmbk
2 years ago
Jonathan G Rennison 387e646439 VarAction2: Add group flag for whether to run jump insert pass 2 years ago
Jonathan G Rennison 3714fad790 VarAction2: Fix jump insertion using mul with bool as last value 2 years ago
Jonathan G Rennison 4af3022c45 VarAction2: Fix last variable read annotations being incorrect
This is because DSE variable substitutions/etc were applied afterwards
This broke jump insertion
2 years ago
translators 79af42e992 Update: Translations from eints
czech: 9 changes by LubosKolouch
2 years ago
Jonathan G Rennison 9ff161e453 Boost realistic braking stats of trains affected by the freight multiplier 2 years ago
Jonathan G Rennison 92723d4f5c Remove tunnel/bridge spacing setting, use usual signal drag spacing 2 years ago
Jonathan G Rennison 191f710c40 Add custom signal style properties to set electric/semaphore enabled types 2 years ago
Jonathan G Rennison 175c5d4d50 Add signal style flag to limit lookahead extra aspect 2 years ago
Jonathan G Rennison 22caac6529 Add game setting to limit train lookahead to signal aspect
In realistic braking mode when multi-aspect signalling enabled by GRF
2 years ago
Jonathan G Rennison bdd73a19a1 Add signal style flag for unconditional reserve through
Add map bits for unconditional reserve through
Adjust signal aspect/state handling
2 years ago
Jonathan G Rennison 7ae06124ae Add signal style flag for no aspect increase behaviour (banner repeater) 2 years ago
Jonathan G Rennison 6e4c4b35e7 Initial implementation of NewGRF custom signal styles 2 years ago
Jonathan G Rennison 4acccc232a Fix #9925: Industry tile layout validation for layouts of only one tile 2 years ago
Jonathan G Rennison 098bb74ed2 Fix industry tile layout validation when the layout has only one tile
See: https://github.com/OpenTTD/OpenTTD/issues/9925
2 years ago
Jonathan G Rennison 9870f2db3a Fix #399: Removing non-rectangular airports clearing non-airport tiles
Merge-conflict resolution error in 0b0d1547
2 years ago
Jonathan G Rennison 4d04a757cc Debug: Add new signals support to GRF debug window 2 years ago
Jonathan G Rennison 41117a52d2 Signals: Add variable for signal context (track, tunnel, bridge, etc) 2 years ago
Jonathan G Rennison cf5eef515e Signals: Add GRF restriction info bit for may reverse 2 years ago
Jonathan G Rennison 9cf33efe18
Merge pull request #393 from telk5093/jgrpp
Update: Korean translation up to v0.47.3
2 years ago
Jonathan G Rennison 4897fded95 Add hotkey to toggle via state of order
See: #398
2 years ago
Jonathan G Rennison 13fcde9ea0 VarAction2: Add a JZ operation, use for ternary style mul masking 2 years ago
Jonathan G Rennison 8687b82dd8 VarAction2: Mark various object variables as expensive 2 years ago
Jonathan G Rennison 77963c5e64 Debug: Add misc_debug bit for extra detail in sprite group dump 2 years ago
Jonathan G Rennison c0b1f867a3 VarAction2: Prefer tracking store content as clone of another store 2 years ago
Jonathan G Rennison 315f12f1e4 Fix spelling error in comment 2 years ago
Jonathan G Rennison 7bb0de247d Add GRF feature: New Landscape
Custom graphics using actions 1/2/3.

Currently only for rock tiles
2 years ago
Jonathan G Rennison 80281daa23 Fix wrong header guard comment in newgrf_newsignals.h 2 years ago
Jonathan G Rennison 67104b4dc1 Add a simple 32 bit to 32 bit hash function (MurmurHash3) 2 years ago
Jonathan G Rennison 65236bacc7 Debug: Fix crash when dumping null sprite group 2 years ago
Jonathan G Rennison ba52fbeb91 Signals: Add variable for restriction info, add bit for reserve through 2 years ago
Jonathan G Rennison 28724d651d Tracerestrict: Add button to highlight all signals using program 2 years ago
Jonathan G Rennison b37209c3af Tracerestrict: Programs maintain a list of signals referencing them 2 years ago
Jonathan G Rennison c06acd3c47 Tracerestrict: Avoid double lookup when setting is restricted map bit 2 years ago
Jonathan G Rennison ccfcc22c03 Tracerestrict: Return error instead of assert for unknown subcommands 2 years ago
translators 814c61a321 Update: Translations from eints
tamil: 20 changes by Aswn
2 years ago
Jonathan G Rennison 02dabad81e Tracerestrict: Add flag for whether reserve through is always set 2 years ago
Jonathan G Rennison 5a02a13885 VarAction2: Add abs() detection to bool/mul adjust combining 2 years ago
Jonathan G Rennison e554d7fdfb VarAction2: Generalise bool/mul adjust combining 2 years ago
Jonathan G Rennison 3e56837ae6 Fix bec2bf7e: Fix (anti-)commutative store/load re-arrangements 2 years ago
Jonathan G Rennison 34cd547325 Debug: Show if action 2s have been modified by action 6 in debug window 2 years ago
Jonathan G Rennison 6214d0d20d VarAction2: Add an ABS opcode 2 years ago
Jonathan G Rennison 3ca95a63d2 Settings: Fix wrong flags for town max height and min area settings 2 years ago
Jonathan G Rennison 7f1b3a965f VarAction2: Allow tracking stores as (inverted) clones of previous store 2 years ago
Jonathan G Rennison 8aac0ed639 VarAction2: Shrink size of RandomizedSpriteGroupCompareMode 2 years ago
Jonathan G Rennison bec2bf7e85 VarAction2: Initial temp store versioning in 1st pass 2 years ago
Jonathan G Rennison 4f3058ee06 VarAction2: Improve handling of variable 7B with a previous constant 2 years ago
Jonathan G Rennison 23e6d861fc VarAction2: Ensure that store simplification can't break var 7B 2 years ago
Jonathan G Rennison 3bddd55921 VarAction2: Add sprite group flag for if var 1C seen before proc 2 years ago
Niels Martin Hansen 470c902bdc Fix #9918: Reset industy last production year on scenario start 2 years ago
Niels Martin Hansen 2cdb0cb084 Codechange: Factor out OnStartScenario function 2 years ago
TELK 08726de24c Update: Korean translation up to v0.47.3 2 years ago
Jonathan G Rennison 16185e817e VarAction2: Merge compatible constant operations 2 years ago
Jonathan G Rennison 0343e9d9dd VarAction2: Replace sequences of the form: (var * flag) + (var * !flag) 2 years ago
Jonathan G Rennison 4553c22cee Debug: Move DeterministicSpriteGroupAdjust dumping to separate function 2 years ago
Jonathan G Rennison e5e984d92f VarAction2: Replace effective SMAX/SMIN sequences in DSE pass 2 years ago
Jonathan G Rennison 0484fbf941 VarAction2: Save/restore inference when going back to previous op with side effects 2 years ago
Jonathan G Rennison 376b434d53 VarAction2: Re-order commutative skip on zero operation sequences
Such that less expensive variables can be tested first
2 years ago
Jonathan G Rennison 0409bd88e8 VarAction2: Simplify tracking of sprite group feature 2 years ago
Jonathan G Rennison caebff85f5 VarAction2: Add helper functions for constant comparison adjust types 2 years ago
Jonathan G Rennison 249a20e47a VarAction2: Add helper functions for relational comparison ops 2 years ago
Jonathan G Rennison 31e96ff5e7 VarAction2: Add helper functions for anti-commutative ops 2 years ago
Jonathan G Rennison 5db30e559e VarAction2: Store substitutions can now handle inversions 2 years ago
Jonathan G Rennison b95116e4fc VarAction2: Apply XOR bool inversion conversions after DSE 2 years ago
Jonathan G Rennison 2bbfa37730 VarAction2: Replace reversed commutative/sub op via temp storage in DSE pass 2 years ago
Jonathan G Rennison 9a40b9fbb9 Merge PR #390 into jgrpp 2 years ago
Jonathan G Rennison 6f7f80c6cf Merge branch 'master' into jgrpp 2 years ago
Jonathan G Rennison 45ac1a89aa VarAction2: Apply XOR with 1 bool logic inversion in more cases
Fixes case of DSE-delayed var substitutions
2 years ago
Jonathan G Rennison 45798fa533 Debug: Add scroll to sprite number to debug window 2 years ago
Jonathan G Rennison 1c1e6a1042 VarAction2: Prune deterministic sprite group children again after DSE 2 years ago
Jonathan G Rennison 6e398f9cec VarAction2: DSE now takes into account DSE results from child groups 2 years ago
Jonathan G Rennison 65407210a6 VarAction2: Allow DSGA_OP_STO_NC to be used with DSGA_TYPE_EQ/NEQ 2 years ago
Jonathan G Rennison d3dce79d73 VarAction2: Substitute single-use vars through temp storage in DSE pass 2 years ago
Jonathan G Rennison 0310692acf VarAction2: Only substitute cheap vars through temp storage in 1st pass 2 years ago
Jonathan G Rennison f54530b1b2 VarAction2: Add checks for vars 7B, 7C when getting previous single load 2 years ago
translators 0d3756818f Update: Translations from eints
korean: 1 change by telk5093
2 years ago
Jonathan G Rennison a8c0e47dd8 VarAction2: If DSE results in a redundant load, remove it 2 years ago
Jonathan G Rennison 86324e0fda Debug: Add mode to sprite dump window to show unoptimised 2 years ago
Jonathan G Rennison 22e10462dc Debug: Redraw debug window content if line change moves scroll position 2 years ago
Jonathan G Rennison a818157c57 Debug: Add button to duplicate debug window 2 years ago
Jonathan G Rennison 74681f70d9 VarAction2: Replace inverted OR of bools with AND where this makes sense 2 years ago
Jonathan G Rennison e41a5d2f63 VarAction2: Add flags to skip adjust if value is 0 or LSB set 2 years ago
Jonathan G Rennison 236cbc4e83 VarAction2: Optimise SAR same as SHR on unsigned inputs 2 years ago
Jonathan G Rennison 9d04ebcc90 VarAction2: Remove operations which always do nothing when applied to 0 2 years ago
Jonathan G Rennison 26dd84f931 VarAction2: Optimise OR followed by XOR of same constant 2 years ago
Jonathan G Rennison 3aa0ccb97b VarAction2: Optimise OR which always produces 1 2 years ago
Jonathan G Rennison 9b0a7ac85e Debug: Don't unnecessarily show numeric value of adjust operator 2 years ago
Jonathan G Rennison dc8465dc68 VarAction2: Shrink enum fields of DeterministicSpriteGroupAdjust 2 years ago
Jonathan G Rennison 2663cc3fdc VarAction2: Adjust masking in GetNearbyTileInformation 2 years ago
Jonathan G Rennison 4b7288902d VarAction2: Consider industry tile vars 0x60 to 0x62 to be expensive 2 years ago
Jonathan G Rennison 3a5902ff77 VarAction2: Reduce cost of RecursiveDisallowDSEForProcedure
Fix disallowing DSE also disallowing store simplification
2 years ago
Jonathan G Rennison 894c8d8b5e NewGRF: Shrink various flags/enum fields 2 years ago
translators 8cdf303e72 Update: Translations from eints
indonesian: 30 changes by indrabagus
2 years ago
Jonathan G Rennison c342b4219b NewGRF: Use per-GRF text ID map in GetGRFStringID 2 years ago
Jonathan G Rennison 7a61b5d820 VarAction2: Cache refit capacity callback results which depend only on cargo 2 years ago
Jonathan G Rennison fcd9137a9f Change OTTD_PRINTFHEX... defines to uppercase 2 years ago
Jonathan G Rennison a9ca89d0f8 VarAction2: Move cb_result_found to a flags var in AnalyseCallbackOperation 2 years ago