Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
7,771 Commits 67 Branches 115 Tags 1.2 GiB
206074a45e
Commit Graph

6490 Commits

Author SHA1 Message Date
AndiAJ
8daaca51af [fenix] Use identifiers instead of hard coded strings 2021-10-25 17:37:54 +00:00
AndiAJ
eaed414831 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21747 re-enable start on homepage UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
20541aab38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21754 re-enable general settings UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
7a4658627e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 2021-10-25 17:13:13 +00:00
Roger Yang
0c5e1f3442 [fenix] No issue: Add external load flag 2021-10-25 18:02:51 +02:00
Sebastian Kaspari
6f4c47613a [fenix] Update Kotlin and Jetpack Compose versions. 2021-10-25 17:59:17 +02:00
Oana Horvath
775929a293 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21628: catch ComposeNotIdleException 2021-10-25 15:39:55 +00:00
Arturo Mejia
8a2df4be14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close 
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
 2021-10-25 10:42:22 -04:00
Mayank Agarwal
af4a03a0f3 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714: Login button visibility fix on saved logins page 2021-10-25 11:58:51 +02:00
Mugurell
bf76a1871c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available 
This is the same previously used approach and the same used for tabs tray.
 2021-10-25 09:54:06 +00:00
Mozilla L10n Automation Bot
b566e3ed7f [fenix] Import l10n. 2021-10-25 00:40:41 +00:00
Mozilla L10n Automation Bot
e7695f25ef [fenix] Import l10n. 2021-10-24 00:54:31 +00:00
Mozilla L10n Automation Bot
3516c38f1f [fenix] Import l10n. 2021-10-23 01:47:59 +00:00
Michael Comella
2a52bffeae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment. 
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
 2021-10-23 01:21:39 +00:00
Michael Comella
1336a4f72d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add duration for some BrowserFragment lifecycle markers. 
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
 2021-10-23 01:21:39 +00:00
Michael Comella
9926c27e43 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add durations for some HomeFragment lifecycle markers. 2021-10-23 01:21:39 +00:00
Michael Comella
9a784f8484 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: add and register MarkersFragmentLifecycleCallbacks. 2021-10-23 01:21:39 +00:00
Michael Comella
91e7121fa8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921: rename MarkersLifecycleCallbacks to ...ActivityLifecycle... 
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
 2021-10-23 01:21:39 +00:00
Michael Comella
2f7d5c03f6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22054: add marker for root view layout/measure. 
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.

Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
 2021-10-23 00:06:37 +00:00
Oana Horvath
888e9365cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/22095: fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test 2021-10-22 18:06:32 +00:00
Mugurell
fe8c112513 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore 
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
 2021-10-22 10:53:55 -04:00
Roger Yang
593b08780f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061: Let TabSorter decide if title header should be shown in tabs tray 2021-10-22 14:34:41 +00:00
Mozilla L10n Automation Bot
d09f8d1a00 [fenix] Import l10n. 2021-10-22 01:18:49 +00:00
Roger Yang
53db79d50e [fenix] No issue: Only report telemetry when tabs tray is first opened 2021-10-21 22:34:25 +00:00
Mugurell
18127e2f5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal 2021-10-21 22:10:26 +00:00
Michael Comella
ad1bcec0d9 [fenix] No issue - post: fix ProfilerMarkerFactProcessor tests. 2021-10-21 21:21:21 +00:00
Michael Comella
8fc6c5952f [fenix] No issue: use Fact.value as detailText for markers. 
This allows Facts emitted from ac to provide more details in markers.
 2021-10-21 21:21:21 +00:00
Michael Comella
9688a90c29 [fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText. 
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
 2021-10-21 20:55:47 +00:00
Oana Horvath
e17721e795 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20754: fix intermittent click failure in verifyAboutFirefoxPreview test 2021-10-21 20:24:15 +00:00
Andrei Joltan
99988cd74f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test (https://github.com/mozilla-mobile/fenix/pull/22068) 
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
 2021-10-21 11:39:49 -04:00
AndiAJ
c4bce2422e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test 2021-10-21 13:37:15 +00:00
Mozilla L10n Automation Bot
231ee9a9c3 [fenix] Import l10n. 2021-10-21 00:59:47 +00:00
Gabriel Luong
2e7f52f63a [fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color 2021-10-21 00:15:19 +00:00
Gabriel Luong
f3f8f717f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors 2021-10-21 00:15:19 +00:00
xlog-null
6f80d2871f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen 2021-10-20 23:49:22 +00:00
Gabriel Luong
2c4ccea6cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol 2021-10-20 23:08:14 +00:00
Noah Bond
1c21e2face [fenix] MR2 Inactive tabs telemetry (https://github.com/mozilla-mobile/fenix/pull/21908) 
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test

* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-20 22:30:59 +00:00
Gabriel Luong
e8cd66b619 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED 2021-10-20 20:11:52 +00:00
Gabriel Luong
e7f6b6fc14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55 2021-10-20 20:11:52 +00:00
Gabriel Luong
0abac59277 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA 2021-10-20 20:11:52 +00:00
Gabriel Luong
f928428f5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Gabriel Luong
c3d86f8dc5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
1a01f638c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18 2021-10-20 20:11:52 +00:00
Gabriel Luong
4783442368 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75 2021-10-20 20:11:52 +00:00
Gabriel Luong
98dd4016ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C 2021-10-20 20:11:52 +00:00
Gabriel Luong
521b564fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF 2021-10-20 20:11:52 +00:00
Gabriel Luong
a77c5b8fad [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787 2021-10-20 20:11:52 +00:00
Gabriel Luong
18a9ffed66 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64 2021-10-20 20:11:52 +00:00
Gabriel Luong
013530110e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff 2021-10-20 20:11:52 +00:00
Gabriel Luong
2e762f0327 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27 2021-10-20 20:11:52 +00:00
Gabriel Luong
9a901e0cff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E 2021-10-20 20:11:52 +00:00
Gabriel Luong
453c6f9f8d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2 2021-10-20 20:11:52 +00:00
Gabriel Luong
e5a197c402 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587 2021-10-20 20:11:52 +00:00
Gabriel Luong
bfce9bc796 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A 2021-10-20 20:11:52 +00:00
Gabriel Luong
a8cdbb4524 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
a63441e402 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB 2021-10-20 20:11:52 +00:00
Gabriel Luong
c07d13ba2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042 2021-10-20 20:11:52 +00:00
Gabriel Luong
648f3261c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1 2021-10-20 20:11:52 +00:00
Gabriel Luong
d50ff294a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5 2021-10-20 20:11:52 +00:00
Gabriel Luong
ebcc1024ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF 2021-10-20 20:11:52 +00:00
Gabriel Luong
98c315c7e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000 2021-10-20 20:11:52 +00:00
Gabriel Luong
d51e2df39a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Mugurell
d7521f168e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list 2021-10-20 07:59:35 +00:00
Mozilla L10n Automation Bot
0a5ba09d26 [fenix] Import l10n. 2021-10-20 00:39:06 +00:00
Mugurell
aabd1999ee [fenix] CI for 21827 (https://github.com/mozilla-mobile/fenix/pull/22004) 
* Remove redundant calls to setHasOptionsMenu(false)

Fix memory leaks for credit card and login fragments

* Fixes:

Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt

* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
 2021-10-19 10:52:01 +00:00
Mozilla L10n Automation Bot
906b7a168c [fenix] Import l10n. 2021-10-19 01:25:27 +00:00
Arturo Mejia
9d3d9b3421 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI 2021-10-19 00:40:55 +00:00
AndiAJ
c1c42385c4 [fenix] Improve tabsSettingsMenuItemsTest UI test coverage 2021-10-18 14:45:27 +00:00
Mozilla L10n Automation Bot
bee0854156 [fenix] Import l10n. 2021-10-18 00:37:31 +00:00
Mozilla L10n Automation Bot
70919737fd [fenix] Import l10n. 2021-10-17 00:36:57 +00:00
Mozilla L10n Automation Bot
952ba35095 [fenix] Import l10n. 2021-10-16 00:34:46 +00:00
Roger Yang
1647e4f613 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893: Keep search group when second to last search term tab is removed 2021-10-15 17:48:23 +00:00
Mozilla L10n Automation Bot
299406fc89 [fenix] Import l10n. 2021-10-15 00:35:47 +00:00
Christian Sadilek
09d1c997d8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944: Top sites rendered slowly on first load of HomeFragment 2021-10-14 18:04:17 -04:00
Marc Leclair
b7a03ea6d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: linting fixes 
For https://github.com/mozilla-mobile/fenix/issues/21700: nit fixes
 2021-10-14 21:03:05 +00:00
Marc Leclair
c261feb602 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Added option to open in browser instead of automatically doing it 2021-10-14 21:03:05 +00:00
Marc Leclair
c558e11cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: fixed comments 2021-10-14 21:03:05 +00:00
Marc Leclair
60fa679e9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21700: Created benchmark script runner and edited benchmark gradle file 2021-10-14 21:03:05 +00:00
Jonathan Almeida
c380d1e622 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910: Fix intermittent failures in SelectTabUseCaseWrapperTest 2021-10-14 18:52:47 +00:00
Grisha Kruglov
997fd9ba64 [fenix] Do less work while navigating Logins views 
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:

- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
  `list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
  view
 2021-10-14 17:34:20 +00:00
Grisha Kruglov
5372f1bcca [fenix] Make linters happy 2021-10-14 17:34:20 +00:00
Ben Dean-Kawamura
84773fa9a2 [fenix] Register the logins key provider 
This is required for sync to work
 2021-10-14 17:34:20 +00:00
Ben Dean-Kawamura
204ad8834d [fenix] Updating Fenix to work with the new logins API 
Switched to always using `Login` instead of the `SavedPassword` alias.

Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`.  This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.

Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`.  This simplifies the error handling a
bit.

Refactored dupe-checking code to use findLoginToUpdate()

Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method.  I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104.  I would love to address https://github.com/mozilla-mobile/fenix/issues/24102,
but I'm not sure what the correct behavior is there so I just kept that
the same.
 2021-10-14 17:34:20 +00:00
Arturo Mejia
0672471708 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section 2021-10-14 16:01:59 +00:00
AndiAJ
c8d89a3bba [fenix] Fix for ambiguous tabstray_title and with text matcher for audio page 2021-10-14 14:21:08 +00:00
AndiAJ
45bdd68df1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test 2021-10-14 14:21:08 +00:00
Jonathan Almeida
f5fa9d4217 [fenix] No issue: Always show Make inactive for debug builds 2021-10-14 07:52:39 +00:00
Gabriel Luong
fa4b9996c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20 2021-10-14 03:40:40 +00:00
Roger Yang
1e84ef3843 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Add shadow to recent bookmarks section 2021-10-14 02:53:35 +00:00
Mozilla L10n Automation Bot
ac7e445eb0 [fenix] Import l10n. 2021-10-14 00:38:56 +00:00
Roger Yang
ed3560d1b9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917: Update pocket stories card elevation to match other cards 2021-10-13 22:53:56 +00:00
Jonathan Almeida
18a8788812 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707: Correct search grouping logic in extensions 
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.

The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.

Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
 2021-10-13 22:01:07 +00:00
Gabriel Luong
cb7cc7a7eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources 2021-10-13 20:42:49 +00:00
Grisha Kruglov
7efdddcaeb [fenix] Fix up HistoryMetadataController tests 2021-10-13 15:45:00 -04:00
Grisha Kruglov
eef2ad800a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal 
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.

This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).

This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.

After this patch, we:
 - dispatch two actions (on browserstore, on homefragmentstore) which
   remove the search groups from any relevant in-memory state; any UI bound to
   this state will be automatically "refreshed"
 - no longer navigate as part of the remove action, so the UI doesn't
   move and removal happens "in-place"
 2021-10-13 15:45:00 -04:00
Christian Sadilek
0751190582 [fenix] Handle new OptimizedLoadUrlAction in history metadata middleware 
Upgrades to A-C 95.0.20211013154351
 2021-10-13 15:45:00 -04:00
Jonathan Almeida
4fee8036a0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Remove rotation; rely on state activated 
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
 2021-10-13 19:27:49 +00:00
sunil9211
45330287b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17393: Dead code removed around Delete downloads 2021-10-13 15:08:07 +00:00
AndiAJ
7638040a3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest 2021-10-13 14:01:02 +00:00
Arturo Mejia
0658de464f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt 2021-10-13 12:08:59 +00:00
AndiAJ
1bb5f1479d [fenix] Disable editCustomSearchEngineTest UI test 2021-10-13 06:37:00 +00:00
Arturo Mejia
d6ae910c74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK. 2021-10-12 19:31:35 -04:00
AndiAJ
6a7c42a398 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test 2021-10-12 16:06:09 +00:00
AndiAJ
f0091a768c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test 2021-10-12 15:14:19 +00:00
Mugurell
ec442f575f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings 2021-10-12 14:48:47 +00:00
AndiAJ
7f9dab5654 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest 2021-10-12 14:23:33 +00:00
Oana Horvath
3ea7755592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005: fixed ETP status info display 2021-10-12 06:26:44 +00:00
Elise Richards
897aa4b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21522: Wrap section titles on home 2021-10-09 04:16:40 +00:00
Elise Richards
86029b181c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew fission metrics expiring in December 2021-10-09 03:42:00 +00:00
Roger Yang
c7232a0bdb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Stop using internally stored tabs list in adapters 2021-10-09 02:43:26 +00:00
Mugurell
f10d226f92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge 
To get smaller shadows.
 2021-10-08 23:22:44 +00:00
Mugurell
cde1c3b911 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates. 2021-10-08 18:45:30 -04:00
Mugurell
e22e33c3c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake. 2021-10-08 18:45:30 -04:00
Christian Sadilek
b916fc4a85 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437: Fix default of start_on_home setting in UI 2021-10-08 18:33:55 -04:00
Gabriel Luong
ff62ffe70a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section 2021-10-08 20:37:56 +00:00
Jonathan Almeida
d13f0ef797 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Reverse chevron for inactive tabs 2021-10-08 20:04:40 +00:00
MickeyMoz
16ed26781d [fenix] Update Android Components version to 95.0.20211008105820. 2021-10-08 14:17:27 +00:00
AndiAJ
aa6387809d [fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests 2021-10-08 11:16:54 +00:00
AndiAJ
153bfcce38 [fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests 2021-10-08 11:16:54 +00:00
AndiAJ
3317d98b34 [fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description 2021-10-08 11:16:54 +00:00
AndiAJ
7dd7b2e5b2 [fenix] Fix for ambiguous tabstray_title and with text 2021-10-08 11:16:54 +00:00
AndiAJ
d6755b5580 [fenix] Fix for ambiguous tabstray_close 2021-10-08 11:16:54 +00:00
AndiAJ
75606a8786 [fenix] Fix for ambiguous tab_item 2021-10-08 11:16:54 +00:00
codrut.topliceanu
822775eb9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash 2021-10-08 07:59:42 +00:00
Jonathan Almeida
363e563fc7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Move submitList calls into TabsAdapter 
Co-authored-by: Roger Yang <royang@mozilla.com>
 2021-10-08 05:36:48 +00:00
Noah Bond
39a3aacc78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings 2021-10-07 23:45:43 +00:00
Christian Sadilek
d73ea2cf98 [fenix] Enable pocket stories in CA 2021-10-07 21:57:56 +00:00
Arturo Mejia
185121606c [fenix] Prepare nimbus features default values for release 95 2021-10-07 20:44:44 +00:00
Rohan Maity
2fc70778a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20579: Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode 2021-10-07 19:48:16 +00:00
Arturo Mejia
a4fcc93d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience 2021-10-07 15:30:18 +00:00
Mugurell
e6a73b5118 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry 2021-10-07 08:36:00 +00:00
Michael Comella
257ae4b118 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424: add marker for StrictMode.resetAfter. 
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
 2021-10-07 07:39:51 +00:00
Gabriel Luong
e3b2309ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol 2021-10-06 21:47:36 +00:00
Noah Bond
b772f6d080 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen (https://github.com/mozilla-mobile/fenix/pull/21722) 
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen

* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text

* PR: Fixed lint warning. Reverted preference keys

* PR: added ignore for UI test

* PR: Added ignore for UI test
 2021-10-06 21:01:16 +00:00
Roger Yang
259b2e5d30 [fenix] No issue: Update Pocket categories spacing to 16dp. 2021-10-06 19:52:55 +00:00
Sebastian Kaspari
a4e21f4fbb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102: Set compileSdkVersion to 31. 2021-10-06 17:30:08 +00:00
Roger Yang
c9d8e826ca [fenix] No issue: Small layout update for Pocket Stories 2021-10-06 17:01:32 +00:00
Gabriel Luong
398bdac5aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size 2021-10-06 15:38:35 +00:00
Sebastian Kaspari
e487bc6f59 [fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 2021-10-06 10:32:59 +00:00
Arturo Mejia
3e01e9df25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 2021-10-06 03:21:41 +00:00
Arturo Mejia
f4f7c1b0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: disabled the homescreen onboarding dialog. 2021-10-06 03:21:41 +00:00
Roger Yang
2594eac89e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573: Update design for jump back in section and recently bookmarked section 2021-10-05 21:43:08 +00:00
codrut.topliceanu
bdc54a1465 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border 
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
 2021-10-05 20:46:16 +00:00
Arturo Mejia
622e713c07 [fenix] Update feature flags for 94. 2021-10-05 18:02:38 +00:00
AndiAJ
09c8890055 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test 2021-10-05 11:09:29 +00:00
Mugurell
5baa97270c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links 2021-10-05 10:33:45 +00:00
codrut.topliceanu
f372c5c69f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup 2021-10-05 10:00:33 +00:00
Mugurell
e606d8c42a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables. 
Added from the ViewHolders, the same as for XML Views.
 2021-10-05 07:03:21 +00:00
Mugurell
dc66fea1e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items 2021-10-05 07:03:21 +00:00
Mugurell
07d08eb655 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description 2021-10-05 07:03:21 +00:00
Mugurell
8f6a6d0980 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items 2021-10-05 07:03:21 +00:00
Mugurell
11b92bbd99 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding 2021-10-05 07:03:21 +00:00
Jonathan Almeida
2e597529c8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582: Use ThumbnailStorage in recent tabs on home 2021-10-05 06:33:18 +00:00
Gabriel Luong
fde5b755e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited 2021-10-04 22:48:30 +00:00
Gabriel Luong
8a78101fc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches 2021-10-04 22:48:30 +00:00
Jonathan Almeida
33cf85203a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642: Remove in-progress media tab from homescreen 2021-10-04 18:03:34 -04:00
Christian Sadilek
5385b96abe [fenix] Move tabs out of search group if direct load occurs 
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
 2021-10-04 17:30:49 -04:00
Elise Richards
3db298543e [fenix] CI for Fix description for home_screen_displayed metric (https://github.com/mozilla-mobile/fenix/pull/21697) 
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-10-04 13:59:02 -07:00
Elise Richards
3631014159 [fenix] CI for Docs: Add extra context to events.browser_menu_action (https://github.com/mozilla-mobile/fenix/pull/21696) 
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
 2021-10-04 20:10:49 +00:00
Gabriel Luong
efab5cbb1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions 2021-10-04 19:06:30 +00:00
Jonathan Almeida
3d69371557 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671: Remove Recently Closed from Inactive Tabs 2021-10-04 15:50:27 +00:00
Mugurell
7e65b07930 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware 
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
 2021-10-04 11:54:42 +00:00
Mugurell
6261e570c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore 
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
 2021-10-04 11:54:42 +00:00
Mugurell
4f4586d85f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory 
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
 2021-10-04 11:54:42 +00:00
AndiAJ
7b031b0504 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test 2021-10-04 10:34:56 +00:00
Jonathan Almeida
884c8c2224 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576: Hide 'Other' title when there are no search groups 2021-10-04 08:56:20 +00:00
Mugurell
20f07022d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties 2021-10-04 07:33:31 +00:00
Arturo Mejia
8a4bb26526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation 2021-10-04 00:39:59 +00:00
Arturo Mejia
21480b89ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in Contextual Hints 2021-10-03 23:16:37 +00:00
Jonathan Almeida
51000bcfa4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632: Correct inactive tabs survey string (https://github.com/mozilla-mobile/fenix/pull/21669) 2021-10-03 14:29:39 +00:00
Christian Sadilek
c1f2c33a76 [fenix] Make search term grouping tolerant to (parent tab) navigation 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-10-02 08:51:25 +00:00
Elise Richards
d70d0610d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21648: match Pocket sections on home to designs 2021-10-02 08:24:09 +00:00
Jonathan Almeida
0c5285cf05 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641: Do not add a group of only one tab 2021-10-02 04:00:02 -04:00
Elise Richards
ad1cff2300 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21653: pre-land section title for tab preferences 2021-10-02 00:53:00 +00:00
Noah Bond
4f07d1a40f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups (https://github.com/mozilla-mobile/fenix/pull/21615) 
* For https://github.com/mozilla-mobile/fenix/issues/21360  - Added toggle for search term tab groups

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-02 00:25:12 +00:00
Elise Richards
f12124b948 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21646: Update section titles and customize button name on home 2021-10-01 23:51:48 +00:00
Elise Richards
b9f5e56c37 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (https://github.com/mozilla-mobile/fenix/pull/21645) 2021-10-01 14:23:24 -07:00
Noah Bond
44f1f679e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message (https://github.com/mozilla-mobile/fenix/pull/21636) 
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
 2021-10-01 20:37:51 +00:00
Gabriel Luong
33381f78f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey 2021-10-01 19:51:59 +00:00
Biren-Nayak
bd610d394f [fenix] For https://github.com/mozilla-mobile/fenix/issues/16437: Remove unnecessary space for tracking protection exceptions 2021-10-01 19:15:00 +00:00
Mugurell
4e5047d203 [fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions. 2021-10-01 18:03:12 +00:00
Christian Sadilek
1d537cb332 [fenix] Allow opening pocket stories when search dialog is active 2021-10-01 16:03:59 +00:00
Oana Horvath
1f628f8e52 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540, https://github.com/mozilla-mobile/fenix/issues/21620: disables failing UI tests 2021-10-01 15:03:35 +00:00
Oana Horvath
4967527781 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21441, https://github.com/mozilla-mobile/fenix/issues/21477, https://github.com/mozilla-mobile/fenix/issues/21500, https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476, https://github.com/mozilla-mobile/fenix/issues/21474: retry dismissing the search bar 2021-10-01 08:38:03 +00:00
Roger Yang
1da6397453 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610: Update Strings for Tab Settings 2021-10-01 06:31:50 +00:00
Mozilla L10n Automation Bot
2311ac81df [fenix] Import l10n. 2021-10-01 03:27:40 +00:00
Arturo Mejia
5e57ece039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Add jump back in contextual hint text 2021-09-30 22:40:30 -04:00
Roger Yang
1f11b81bc4 [fenix] No issue: Make sure jump back in group always have more than one tab 2021-09-30 22:33:50 -04:00
Gabriel Luong
4d23db624f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-09-30 22:30:19 -04:00
Elise Richards
dc1e5e640e [fenix] For https://github.com/mozilla-mobile/fenix/issues/21287: long press menu on recently visited homescreen groups 2021-09-30 22:00:18 -04:00
Arturo Mejia
e1a2b9ccfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21608: Update strings for home screen dialog features 2021-10-01 01:51:07 +00:00
Grisha Kruglov
485ca898f2 [fenix] Do not show home screen behind search if we have search terms 
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
 2021-09-30 18:14:16 -04:00
Jan-Erik Rediger
0a08c61e8d [fenix] Don't manually exclude glean-native 
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
 2021-09-30 19:51:29 +00:00
Noah Bond
f2b7eea088 [fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524) 
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
 2021-09-30 19:01:31 +00:00
Mugurell
4fac910adf [fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories 2021-09-30 15:54:21 +00:00
Mugurell
92bc5e93b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling 
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
 2021-09-30 14:57:17 +00:00
Aaron Train
e7b2578a5a [fenix] No issue: Fix AssertionError in openThreeDotMenu 
fix: ktlint
 2021-09-30 14:06:13 +00:00
AndiAJ
c7658e352d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix flaky editCustomSearchEngineTest UI test 2021-09-30 10:30:27 +00:00
Michael Comella
e7077466ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: suppress MaxLineLength in Fact.toEvent. 
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
 2021-09-30 09:13:53 +00:00
Michael Comella
d0ceaf7a7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: remove allocations in Fact.toEvent. 
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
 2021-09-30 09:13:53 +00:00
Michael Comella
08a11127aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change when (condition) { when { in Fact.toEvent. 
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
 2021-09-30 09:13:53 +00:00
Michael Comella
32c8709148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: add partial test for existing factToEvent code. 
When we refactor, this will help ensure we've done it correctly.
 2021-09-30 09:13:53 +00:00
codrut.topliceanu
ed55813676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Adds grey border to inactive tabs 2021-09-30 08:42:46 +00:00
Mozilla L10n Automation Bot
738e7b68d5 [fenix] Import l10n. 2021-09-30 00:43:30 +00:00
Elise Richards
8a77a20614 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: Move the homescreen onboarding card behind a feature flag 2021-09-29 22:52:42 +00:00
Mugurell
ad0f428f39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu 2021-09-29 19:55:26 +00:00
Mugurell
08a71a5366 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables 
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
 2021-09-29 19:15:07 +00:00
Andrei Joltan
710a94b9ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/21442 fix flaky deleteMultipleSelectionTest UI test (https://github.com/mozilla-mobile/fenix/pull/21563) 
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-29 13:45:08 -04:00
Roger Yang
c0c59f266b [fenix] No issue: Improve rendering of jump back in 2021-09-29 11:43:49 -04:00
AndiAJ
7ed672d7ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21478 fix flaky verifyOpenTopSiteNormalTab UI test 2021-09-29 15:21:34 +00:00
Oana Horvath
005d0f01a3 [fenix] Fixed verifyAboutFirefoxPreview test according with new steps 2021-09-29 16:01:35 +03:00
Oana Horvath
01e865fee0 [fenix] Fixed disabled UI test openExternalLinksInPrivateTest 2021-09-29 16:01:35 +03:00
Roger Yang
55da682e79 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552: Remove Extra Subtitle In Jump Back In Item 2021-09-29 02:46:34 +00:00
Roger Yang
f90fd65ccd [fenix] Fix recent tabs intermittent tests (https://github.com/mozilla-mobile/fenix/pull/21557) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-28 22:10:47 -04:00
Elise Richards
b777fa32ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/21339: update styles for homescreen show all buttons and jump back in spacing (https://github.com/mozilla-mobile/fenix/pull/21342) 
For https://github.com/mozilla-mobile/fenix/issues/21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-09-28 14:40:22 -07:00
Mugurell
219561d304 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown 2021-09-28 20:25:25 +00:00
Christian Sadilek
4702a66203 [fenix] Do not capture search terms when user navigates away via app (https://github.com/mozilla-mobile/fenix/pull/21527) 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-09-28 14:20:58 +00:00
AndiAJ
f4a38f0a65 [fenix] Delete browsing data tests UI tests 2021-09-28 09:50:00 +00:00
AndiAJ
c1d3d97cc8 [fenix] Fix disabled toggleSearchSuggestions UI Tets and refactoring work 2021-09-28 07:49:22 +00:00
Elise Richards
32d6ee0dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: renewing performance awesomebar metrics (https://github.com/mozilla-mobile/fenix/pull/21315) 2021-09-27 15:40:21 -07:00
Roger Yang
f65770a34f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451: Add active search term tab groups on home 2021-09-27 21:10:57 +00:00
Arturo Mejia
c4eb7ea28b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections 2021-09-27 19:22:34 +00:00
codrut.topliceanu
6da619deb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding 2021-09-27 13:32:06 -04:00
AndiAJ
012b854d69 [fenix] Fix disabled shortcutButtonTest UI test 2021-09-27 11:15:28 +00:00
Mugurell
d701a81103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Add categories support 2021-09-27 09:57:15 +00:00
Mugurell
c37f1e550b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Cleanup 
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
 2021-09-27 09:57:15 +00:00
Mozilla L10n Automation Bot
5a5507b490 [fenix] Import l10n. 2021-09-27 00:38:26 +00:00
Mozilla L10n Automation Bot
f5588635a2 [fenix] Import l10n. 2021-09-26 00:30:23 +00:00
Mozilla L10n Automation Bot
9dd6d98748 [fenix] Import l10n. 2021-09-25 00:44:49 +00:00
codrut.topliceanu
7ea5cdbe39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21087: Updates Recently Saved design 2021-09-24 07:42:29 +00:00
Christian Sadilek
c9e1bfe3dc [fenix] Fix mapping between history visits and groups to use createdAt 
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
 2021-09-23 21:15:48 +00:00
Aaron Train
7f17484989 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21441: Fix changeAccessibiltySettings 2021-09-23 19:59:59 +00:00
Jonathan Almeida
d7c1238dac [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366: Speculative fix for failing test in TitleHeaderBindingTest 2021-09-23 18:42:53 +00:00
Christian Sadilek
a6a6b6f257 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893: Dedupe urls/site in history groups 2021-09-23 16:09:43 +00:00
Gabriel Luong
cb4b5fc613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 2021-09-23 14:26:46 +00:00
Oana Horvath
bc452b6adc [fenix] For https://github.com/mozilla-mobile/fenix/issues/17847: adding back editCustomSearchEngineTest UI test 2021-09-23 08:58:52 +00:00
AndiAJ
cc65e13b50 [fenix] Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 2021-09-23 08:04:40 +00:00
AndiAJ
8976e193d9 [fenix] Fix for disabled saveLoginFromPromptTest 2021-09-23 07:09:15 +00:00
Mozilla L10n Automation Bot
ba990dd118 [fenix] Import l10n. 2021-09-23 01:06:49 +00:00
Gabriel Luong
e3bc494414 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 2021-09-22 21:30:45 +00:00
Arturo Mejia
e87af643cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen 2021-09-22 16:28:43 +00:00
Oana Horvath
15a3e30bf0 [fenix] No issue: re-enabled swipeToSwitchTabTest 2021-09-22 15:59:28 +00:00
Travis Long
023612b87d [fenix] Fix logic so isFirstRun can be called multiple times on first run 2021-09-22 15:35:28 +00:00
Travis Long
b4886fe546 [fenix] [SDK-344] Pass in first-run information to Nimbus for targeting 2021-09-22 15:35:28 +00:00
Gabriel Luong
450055a729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder 2021-09-22 14:20:16 +00:00
Aaron Train
4a6c5b8296 [fenix] Various UI test fixes and disabling of intermittents 2021-09-22 12:57:26 +00:00
Sebastian Kaspari
10f5aa228b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Refactor UI tests accessing awesomebar suggestions. 2021-09-22 12:57:26 +00:00
Sebastian Kaspari
74500adfb5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Replace BrowserAwesomeBar view with AwesomeBar() composable. 2021-09-22 12:57:26 +00:00
Gabriel Luong
bc30e53e5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case 2021-09-22 08:15:08 +00:00
Gabriel Luong
793ceb8e28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history 2021-09-22 08:15:08 +00:00
AndiAJ
2b55e561fb [fenix] Exit onboarding tour UI tests 2021-09-22 07:06:50 +00:00
Mozilla L10n Automation Bot
13ce5a86bd [fenix] Import l10n. 2021-09-22 01:59:21 +00:00
Michael Comella
275ac7ad5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21126: process performancetest intent for AC too. 2021-09-21 20:49:12 +00:00
rayanHappy
1b6c555758 [fenix] Fix QR scan button not showing up when choosing a RTL language 2021-09-21 16:20:56 -04:00
Arturo Mejia
c3df9a26d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen 2021-09-21 15:55:03 -04:00
Christian Sadilek
e18fbdfbfc [fenix] Make sure to only record view time once for a given tab access 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-09-21 12:37:44 -07:00
Mozilla L10n Automation Bot
16f3396473 [fenix] Import l10n. 2021-09-21 00:47:29 +00:00
Elise Richards
d387f7281c [fenix] No issue: remove escape chars on add logins string 2021-09-20 21:30:16 +00:00
Grisha Kruglov
6297f2cce9 [fenix] Use UpdateUrlAction to record viewTime observations 
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.

This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.

The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.

Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
 2021-09-20 20:14:04 +00:00
Elise Richards
48c0d7faee [fenix] For https://github.com/mozilla-mobile/fenix/issues/21337: rename recently saved section on home 2021-09-20 19:42:19 +00:00
Christian Sadilek
473f671f1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21388: Only parse clipboard content when search fragment is attached 2021-09-20 14:31:08 -04:00
Jonathan Almeida
9d6367a607 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21366: Fix intermittent test failure in TitleHeaderBindingTest 2021-09-20 17:47:17 +00:00
AndiAJ
0884f54fe8 [fenix] Improve coverage for verifyAboutFirefoxPreview 2021-09-20 09:41:23 +00:00
Mozilla L10n Automation Bot
1ae41010df [fenix] Import l10n. 2021-09-20 00:38:29 +00:00
Mozilla L10n Automation Bot
530d6a0cf8 [fenix] Import l10n. 2021-09-19 00:34:04 +00:00
Mozilla L10n Automation Bot
1f0efff72e [fenix] Import l10n. 2021-09-18 00:40:46 +00:00
Michael Comella
9c2e6eee78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21296: add ProfilerMarkers.addForDispatchTouchEvent. 2021-09-17 23:06:50 +00:00
Michael Comella
49294996e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration markers for HomeActivity Create/Start. 
We only instrument these methods because they're the only ones that
noticeably long running in the current implementation.
 2021-09-17 22:34:01 +00:00
Michael Comella
4a132b958b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration marker for IntentReceiverActivity.onCreate. 
We only instrument onCreate because it's the only one with an
implementation.

While declaring this as a function that accepts a lambda is less
fragile, we've previously had issues with it such as suspected memory
leaks when used for telemetry. Therefore, we go with the simpler
approach.
 2021-09-17 22:34:01 +00:00
Michael Comella
f53adc5b12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add markers for all activity lifecycle callbacks. 
We implement these all in the same track because between it'd create a
lot noise between this and fragment lifecycle callbacks.
 2021-09-17 22:34:01 +00:00
Roger Yang
21c8f3d1a0 [fenix] Update tabs tray title header string comment to clarify what it does. 2021-09-17 21:07:30 +00:00
Michael Comella
8d5a7606f4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21335: return self instead of mock in FenixSnackbarKtTest. 
This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.

Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.

See d396c9eb41298cc07fbf136f1de971010bc45d97 for a prior attempt to
address the intermittents in this class.
 2021-09-17 18:18:03 +00:00
Jonathan Almeida
c2d385f142 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fixes empty tray visibility logic 
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
 2021-09-17 13:48:08 -04:00
Sebastian Kaspari
b239d7d934 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291: SearchDialogFragment: Get URL from clipboard once and not for every state update 2021-09-17 08:10:04 +00:00
Roger Yang
02cbf2953f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section (https://github.com/mozilla-mobile/fenix/pull/21177) 
* For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section in tabs tray

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Scroll to selected tab + various tab fixes for groupings

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fix failing test

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-09-17 03:26:34 +00:00
Mozilla L10n Automation Bot
47805dc6bb [fenix] Import l10n. 2021-09-17 00:26:32 +00:00
Arturo Mejia
96e083e5b3 [fenix] Update strings comments 2021-09-16 22:41:49 +00:00
Michael Comella
336d681451 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: add profiler markers on global layout. 2021-09-16 22:09:44 +00:00
Michael Comella
595a81aec2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: set up HomeActivityBinding the recommended way. 
The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
 2021-09-16 22:09:44 +00:00
Michael Comella
6e63dce89d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: remove outdated comment regarding async nav graph. 2021-09-16 22:09:44 +00:00
Michael Comella
2dc9cfec20 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18102: remove intermittent failing App onCreate duration measurement test. 
The test as it exists relies on the robolectric lifecycle, which is hard
to predict, so it doesn't seem worth fixing the test. Writing the test
any other way would require excessive mocking, which also seems
impractical.
 2021-09-16 20:17:26 +00:00
rxu
e78754d598 [fenix] Add default topsite 58 for MozillaOnline builds 2021-09-16 19:42:54 +00:00
Arturo Mejia
5ce4a31be5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen. 2021-09-16 14:58:45 -04:00
Gabriel Luong
b057d6a76f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs 2021-09-16 07:07:20 +00:00
Christian Sadilek
d4a454442b [fenix] Sort history metadata on home and allow limiting results 2021-09-16 01:03:29 +00:00
Mozilla L10n Automation Bot
ae40da34f8 [fenix] Import l10n. 2021-09-16 00:32:52 +00:00
Mugurell
b0957a77ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21120 - ImageLoader with a shimmer effect placeholder 2021-09-15 12:00:49 +00:00
AndiAJ
ba70d609f1 [fenix] New deleteBookmarkInEditModeTest UI test 2021-09-15 07:01:59 +00:00
AndiAJ
9cf25c9c64 [fenix] Improve coverage for copyBookmarkURLTest 2021-09-15 06:27:55 +00:00
Mozilla L10n Automation Bot
42ddf1faa4 [fenix] Import l10n. 2021-09-15 00:59:20 +00:00
Elise Richards
1e1a52e6f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20654: Handle private mode switching from home behind search dialog. 
Add tests for controller and interactor to handle private mode switches
 2021-09-14 18:21:06 +00:00
Christian Sadilek
9a78d339b5 [fenix] Fix history metadata API breakage in unit tests 2021-09-14 13:14:36 -04:00
Jan-Erik Rediger
2ab11137aa [fenix] Ensure glean-native is excluded 2021-09-14 13:14:36 -04:00
Jan-Erik Rediger
3ea7d78268 [fenix] Use glean-native in tests 
The Glean core native code is now shipped through GeckoView directly
(through its `-omni` packages).
For local tests we need a library matching the host-platform, which is
available in the glean-native package.
 2021-09-14 13:14:36 -04:00
Rohan Maity
9bfba77957 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20634: remove some unused color resources 2021-09-14 13:10:03 -04:00
AndiAJ
b1ee43a7ed [fenix] Improve coverage for addPrivateBrowsingShortcut Ui test 2021-09-14 15:20:25 +00:00
Arturo Mejia
fc42d08c06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18629: add support for SmartBlock exceptions 2021-09-13 21:26:47 +00:00
Arturo Mejia
5d55e07dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen. 2021-09-13 03:23:43 +00:00
Arturo Mejia
ea5d0ee63d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21211 hide the ETP in custom tabs. 2021-09-13 02:55:39 +00:00
Mozilla L10n Automation Bot
d7355dc309 [fenix] Import l10n. 2021-09-12 00:33:34 +00:00