mirror of
https://github.com/fork-maintainers/iceraven-browser
synced 2024-11-03 23:15:31 +00:00
6297f2cce9
We discovered that in a tab restore scenario we were recording view time observations that were wrong - we'd record time deltas as-if user was looking at the page while the browser wasn't running. This happens because when we record a viewTime observation, we compare current time with lastAccess time of the tab. In a restore scenario, that lastAccess time happens to be from when the browser was last running - which could be days ago. The simplest solution was to not record a viewTime observation if the url for a tab didn't change during a load event. To achieve this, we needed to change which action we were using as a proxy for "navigation events" - UpdateUrlAction contains the new url, allowing us to compare against the current tab url. Alternative solutions would be to keep using loading actions, but dispatch a lastAccess event before performing a metadata update. This would have worked, but would result in two lastAccess events being dispatched for each navigation event instead of just one. |
||
|---|---|---|
| .. | ||
| sampledata | ||
| src | ||
| .gitignore | ||
| benchmark.gradle | ||
| build.gradle | ||
| lint-baseline.xml | ||
| lint.xml | ||
| metrics.yaml | ||
| pings.yaml | ||
| proguard-rules.pro | ||