26815f7405
(svn r3846) Add functions to set the type of stuff (clear, water, rail, road) under bridges
19 years ago
eeb5bf41a1
(svn r3831) Add and use GetRailDepotDirection()
19 years ago
0100871412
(svn r3830) Move IsTunnelTile() from tile.h to tunnel_map.h and add IsTunnel(), which just checks for a tunnel, but not the tile type as IsTunnelTile() does
19 years ago
ee03f15f27
(svn r3803) Change the second parameter of UpdateSignalsOnSegment() from Direction to DiagDirection as that's what it really operates on
19 years ago
8cfcdaa733
(svn r3783) Replace further ints and magic numbers by Direction, DiagDirection and friends
19 years ago
af42610321
(svn r3777) Add some functions to handle tunnels
19 years ago
49cb8eb470
(svn r3776) Replace many ints and magic numbers by Direction, DiagDirection and friends
19 years ago
4efa560ffc
(svn r3763) Adapt to the new 'map accessors go in foo_map.h'-scheme
19 years ago
8d3e42fe3c
(svn r3760) Replace some magic numbers for checking for a suitable slope for a level crossing by some less magic numbers. Quite similar to r3699, though this time for placing the rails
19 years ago
5d6ec6b4f0
(svn r3698) Add GetCrossingRailBits() and ComplementRoadBits(). Simplify the code by using them
19 years ago
7b106a3d8f
(svn r3697) Rename DIAG1/DIAG2 to X resp. Y as this conveys a bit better in which direction a pieces of rail goes
19 years ago
28fc670fe2
(svn r3696) Add functions to turn a tile into a normal rail tile/depot/waypoint. This is just a tiny step, the rail code needs way more love and caring
19 years ago
a8febcf209
(svn r3689) Add functions to turn a tile into either a normal road tile, a level crossing or a road depot
19 years ago
b26d54585f
(svn r3660) Convert further road bits and type references to the functions/enums
19 years ago
2f8e3dcc05
(svn r3658) Add functions and symbolic names to retrieve road tile types and road pieces
19 years ago
5352e9fbcb
(svn r3597) Miscellaneous (I like that word) changes: Fix some indentation, add consts, reduce indentation level by short-circuit logic, convert if cascades to switch, whitespace, bracing, plus some minor stuff
19 years ago
087fe86ed2
(svn r3564) Several smaller changes:
...
- Don't treat non-booleans as booleans
- Reduce variable scope
- Bracing
- Use DeMorgan's law to make conditionals easier to read
- if cascade -> switch
- Replace some magic numbers by symbolic names
- Avoid assignments within other statements
19 years ago
1c3e8630fe
(svn r3511) More whitespace ([FS#46] by Rubidium)
19 years ago
9712d6f639
(svn r3510) Fiddle with whitespace and parentheses
19 years ago
244d4ab5cb
(svn r3490) -Fix: A bunch (10) of off-by-one errors when checking if a TileIndex points to a tile on the map
19 years ago
4014e36aec
(svn r3472) - [PBS] Remove from trunk. Anyone interested can still find it in branch/pbs. This reverts revisions r3158, r3140, r3075, r2977, r2674, r2625, r2621, r2529, r2528, r2525, r2524, r2519, r2517, r2516, r2507, r2499. (in conjunction with Tron)
...
- The only change is that the nsignalsw.grf file is kept and that existing nightlies with PBS signals get those signals converted to combo-signals.
19 years ago
9eb1589827
(svn r3466) - Codechange: Some changes to increase readability of signals code.
19 years ago
461d76a40c
(svn r3389) -Fix: No fence was placed when placing fences and the neighbouring tile is a rail configuration which permits a fence but has a signal
...
(Per request of peter1138 the above line does not contain any commas)
19 years ago
72270695ed
(svn r3387) Restructure the code, which places fences along railroad tracks.
...
This includes no functional changes, just some cleanup before some bugfix
19 years ago
138761e78e
(svn r3369) - Codechange: Replace tables _signals_table, _signals_table_other and _signals_table_both by the equivalent calls to rail.h functions.
...
- Codechange: Add a few constants.
19 years ago
318fe153eb
(svn r3365) Staticise 36 functions
19 years ago
a2533d5ee6
(svn r3298) Remove unused and write-only variables
19 years ago
9822b4d755
(svn r3297) Staticise
19 years ago
80986fcd32
(svn r3282) - Codechange: Replace tests against CMD_ERROR with CmdFailed()
19 years ago
479a9c2e47
(svn r3212) - Waypoints/Depots: Store waypoint index in m2 for waypoints. This moves the ground type bits from m2 to m4 for waypoints and depots (leaving room for depot index in m2 in future), and moves the custom graphics ID to the waypoint struct.
...
- Waypoints: Until now stat_id was saved but never assigned to. Instead we now save the GRFID/local index of the custom graphics so that GRF file changes can leave graphics intact.
19 years ago
cd1ad24723
(svn r3210) -Codechange: use IsRailWaypoint where possible (instead of magicnumbers)
...
-Codechange: IsRailWaypoint should take 'tile', not 'm5'
19 years ago
a56ffc6a0f
(svn r3209) In TileLoop_Track(), use names based on function rather than their place in the map array.
19 years ago
3848d103c8
(svn r3187) Simplify overly complicated ifs, especially if (foo) return false; else return true; is confusing
19 years ago
84a16a0b30
(svn r3184) GB/SB
19 years ago
9d0e7b6458
(svn r3181) -Bracing
...
-Indentation
-Whitespace
-DeMorgan's Law
-Test with NULL or 0 for non-booleans
-'\0' instead of 0 for chars
-Remove redundantly redundant comments (like DoFoo(); // Do foo)
-Join multiple short lines with a single statement
-Split single lines with multiple statements
-Avoid assignments in if
19 years ago
53f00c8f9d
(svn r3173) Use the trinary operator and switch to improve readability
...
Also align short cases nicely
19 years ago
7bbf614796
(svn r3168) - NewGRF: Fix "typo" in waypoint drawer :/
19 years ago
ce9f2fe823
(svn r3166) Constify read-only accesses of custom stations
19 years ago
4c6a67a723
(svn r3141) Replace incorrect railtype bitmask in CmdRailTrackHelper with appropriate GB()
19 years ago
181d586a7c
(svn r3078) Some more stuff, which piled up:
...
- const, whitespace, indentation, bracing, GB/SB, pointless casts
- use the trinary operator where appropriate
- data types (uint[] -> AcceptedCargo, ...)
- if cascade -> switch
- if (ptr) -> if (ptr != NULL)
- DeMorgan's Law
- Fix some comments
- 0 -> '\0', change magic numbers to symbolic constants
19 years ago
0b936c3222
(svn r3077) static, const, bracing, indentation, 0 -> '\0'/NULL, typos in comments, excess empty lines, minor other changes
...
nothing spectacular, just some stuff, which piled up
19 years ago
d7cbd0d4c3
(svn r3073) int/byte -> EngineID/PlayerID/VehicleID
...
0/-1 -> INVALID_ENGINE
0x10 -> OWNER_NONE
19 years ago
71d293f2a3
(svn r3066) Constify the parameter of GetSlopeZ_*()
19 years ago
e3d1e43559
(svn r3049) Replace byte/int/uint by RailType where appropriate
19 years ago
7ab7d79190
(svn r3028) s/255/OWNER_SPECTATOR/
19 years ago
6423de9290
(svn r3025) -Fix: Rail convert issue introduced in r3019
19 years ago
39f5dbfd3b
(svn r3019) -Codechange: Replace explicit shifting/anding/oring with GB and SB
19 years ago
fdebfbe8d5
(svn r2998) -Codechange: Split rail drawing code off from DrawTile_Rail into a separate function to be used elsewhere. (Deja vu?)
19 years ago
4a58250cb9
(svn r2962) - const correctness for all Get* functions and most Draw* functions that don't change their pointer parameters
...
- change a lot of byte player types to PlayerID
- beautify header files, same "#endif /* filename */" ending
19 years ago
c0c75ef16e
(svn r2951) - Fix: [ 1259345 ] Changing engine in netgame opens train window for everyone
...
- Add IsLocalPlayer() which substitutes _local_player == _current_player
19 years ago
4936e93654
(svn r2948) -Fix: the old AI needs a special flag that triggers all kind of special
...
abilities you really don't want to know about (free bridges, etc..)
I removed this flag some revisions ago, but the Aircraft part
depends on it, so I re-enabled it again..
19 years ago
86fcdfbe2e
(svn r2890) Fix some signed/unsigned comparison warnings (tokai)
19 years ago
9a060a0f24
(svn r2781) Fix some of the issues with variables in .h files.
19 years ago
5352ad4582
(svn r2774) -Codechange: Removed TRACKTYPE_SPRITE_PITCH globally and replaced it by a member of RailtypeInfo
19 years ago
b8c9194b7c
(svn r2756) Renamed railtypes into _railtypes
...
Renamed railtypes.c into railtypes.h, all other tables are in .h files. (It should be in the tables dir but I couldn't figure out how to get it there without deleting it first).
Added const and extern.
19 years ago
f287f2ff8d
(svn r2753) -Codechange: Introduced a new struct "RailtypeInfo" to store rail type specific information. Begun populating it with a bunch of sprites, more to come later. This should result in cleaner, more compact code which allows easy introduction of new railtypes.
19 years ago
a3739aecdf
(svn r2702) -Codechange: Cleaned up the sprite code and replaced many magic numbers
...
by enums. There remains work in gfx.c to move the "transparency" and
"recolor" bits around to make space for more sprites. However, 2800
additional sprites can now be loaded. There also remains cleanup and
Doxygen work on many of the header files.
19 years ago
647cbd6bdd
(svn r2701) Insert Id tags into all source files
19 years ago
54cbd01825
(svn r2673) Include functions.h directly, not globally via openttd.h
19 years ago
1fed0046ac
(svn r2658) -Codechange: Use MAKE_TRANSPARENT to display a transparented sprite
19 years ago
f09638ad3d
(svn r2650) Convert many explicit shifts+ands to extract bits to invocations of GB - should be a bit nicer to read
19 years ago
d5b305852f
(svn r2621) - Fix: [pbs] When removing tracks, clear their reserved status.
19 years ago
de19186be3
(svn r2595) -Codechange: Introduced "IsSteepTileh" to find whether a tile is steep
...
(i.e. spans two height levels) and use it throughout the code.
-Codechange: Add CanBuildDepotByTileh to find if a tile is suitable to
build a depot on it. Wraps some bitmagic which seems quite unreadable at
first glance
19 years ago
a4bf608d40
(svn r2558) Change the internal map format from 7 arrays to one array of structs, this doesn't change the saved format for now. It's a stepping stone for further changes.
19 years ago
bf794fad62
(svn r2529) - Fix: PBS signals showed up as normal signals with the query tool
...
- Update landscape_grid.html to show busy bits used by PBS.
19 years ago
ab9c6f126d
(svn r2516) - Feature: [pbs] Implement path-based-signalling. This allows multiple trains within the same signal block, provided their paths dont intersect. For this the block must have all exit and entry signals be pbs signals. Place these by ctrl-clicking 4 times on a normal signal.
...
- Feature: [pbs] Implement autoplacement of pbs blocks, when a block has an entry and an exit pbs signal, covert the entire block to pbs. Can be turned off in the patch settings.
- Feature: [pbs] Allow showing of reserved status by making the tracks darker, when the pbs debug level is at least 1.
19 years ago
d07e1a875e
(svn r2515) -Codechange: Removed a good deal of magic sprite numbers in the rail drawing code, and placed neatly into arrays and enums. This also makes way to implement more railtypes without having to do tons of ugly hacks.
19 years ago
6923badbba
(svn r2505) Remove some unnecessary #includes
19 years ago
189a1c4017
(svn r2499) -Codechange: Moved the semaphore bit from bit 2 to bit 3 in _map_hi for rails, in order to make way for pbs
19 years ago
5cbd8b598c
(svn r2492) Remove some pointless casts and fix some nearby indentation
19 years ago
9617614b04
(svn r2487) Replace TILE_XY by TileXY/TileDiffXY
19 years ago
2b73dec567
(svn r2486) Turn TILE_FROM_XY into an inline function and rename it to TileVirtXY
19 years ago
a733fede9b
(svn r2483) Replace almost 500 "uint tile" (and variants) with "TileIndex tile"
19 years ago
a1d81b3558
(svn r2469) - Add: When removing tracks with the 'remove' tool, have it automatically remove signals on the tracks.
19 years ago
c6845d2f38
(svn r2460) - Fix: Prevent assertion failure when trying to drag signals starting from a non-rail tile.
...
- CodeChange: Remove unused variable in CmdSignalTrackHelper.
19 years ago
663e45eb57
(svn r2452) Fix defect in r2448 which caused building tracks unexpectedly fail or succeed
19 years ago
1876744744
(svn r2448) General cleanup of rail related code, more to follow.
...
* Add: rail.[ch] for rail-related enums and wrapper functions.
* Codechange: Removed dozens of magic numbers with below enums.
* Codechange: Rewrote CheckTrackCombination().
* Add: TILE_SIZE, TILE_PIXELS and TILE_HEIGHT constants.
* Add: enums RailTileType, RailTileSubtype, SignalType to mask against the map arrays.
* Add: enums Track, TrackBits, Trackdir, TrackdirBits for railway track data. (Note that the old RAIL_BIT constants are replaced by TRACK_BIT ones).
* Add: enums Direction and DiagDirection
* Codechange: Moved a bunch of track(dir) related lookup arrays from npf.[ch] to rail.[ch].
* Codechange: move RailType enum from tile.h to rail.h.
* Add: Wrapper functions for masking signal status in the map arrays: SignalAlongTrackdir, SignalAgainstTrackdir and SignalOnTrack.
* Add: Wrapper functions to access rail tiles, using above enums
* Add: Wrapper functions to modify tracks, trackdirs, directions, etc.
* Add: Wrapper functions for all lookup arrays in rail.[ch] (Arrays are still used in parts of the code)
* Codechange: Renamed some variables and arguments to better represent what they contain (railbit -> track, bits -> trackdirbits, etc.).
* Codechange: Don't use FindLandscapeHeight() in CmdRemoveSingleRail(), since it returns way too much info. Use GetTileSlope() instead.
* Codechange: [NPF] Removed some unused globals and code from npf.c.
19 years ago
aab5561c55
(svn r2434) Fix some defects in r2433
19 years ago
c37cf285ce
(svn r2433) - CodeChange: unmagicify all road/train crossings with IsLevelCrossing() function (peter1138)
19 years ago
daae0d315a
(svn r2428) - Feature: [newgrf] Implement shorter train vehicles (Therax), and the callback that goes with it.
...
- Codechange: Remove some magic numbers (PALETTE_CRASH)
19 years ago
24fd817420
(svn r2409) Missed one _map_owner -> IsTileOwner()
19 years ago
ff0030936e
(svn r2408) Introduce SetTileOwner() and use it
19 years ago
a9b95b3cbb
(svn r2407) Use {Get,Is}TileOwner to get/check the owner of a tile and fix some bogus reads of _map_owner
19 years ago
ba8c649fac
(svn r2397) - CodeChange: rename all "ttd" files to "openttd" files.
19 years ago
33bb043fb6
(svn r2322) - CodeChange: doxygen commented the tunnel-crash fix. Also if (bla) {return;} else {return;} is not proper code. It's if (bla) {return;} return; ;)
20 years ago
1436fa9d48
(svn r2320) - Fix: [ 1185176 ] Train in tunnel is not properly detected by signal code (Hackykid)
20 years ago
037ef4cd31
(svn r2317) - Fix: [ 1193048 ] Pre-signal stays red when there is only a single exit signal (dinno)
20 years ago
ddd4958164
(svn r2300) - CodeChange: check the last number of commands, now only the refit ones remain, and some server-only commands.
...
- CodeChange: remove cmd-misuses CmdStartScenario() and CmdDestroyCompanyHQ()
- Fix (invisible): when parameter checking CmdRestoreOrderIndex() the vehicle did not have its orders yet, so it would fail. So move doing this until AFTER the orders have been added back in RestoreVehicleOrders()
20 years ago
84b0d2d19d
(svn r2286) - CodeChange: paramcheck the next batch of commands.
...
- Fix (regression): fix up terraform land where every player can terraform land (towns, map generation), and player can terraform different corners; used for building tunnels
20 years ago
da1a7587af
(svn r2285) - Codechange: Fix up some of the missing things from server-checking; namely bridge-type, bridge-length, dragged end-tile (bridge/station), station_spread
...
- Fix: [ 1197256 ] max station spread patch < 7 does not work. Station spread was not taking into account when not using drag&drop. Fix this up, and add a callback to the settings window to immediately reflect the changes.
20 years ago
419af5cece
(svn r2279) - Fix: Check the parameters of the first 10 Commands. While there also add proper comments for the functions and fix up CmdFailed()
20 years ago
738ea43ce1
(svn r2223) When adding tracks to a railway tile reset the ground to bare land, fix for a glitch in r2131
20 years ago
1f5a66404f
(svn r2195) Add CmdFailed() as the One True Way(tm) to check if a command failed.
20 years ago
23b1617cdf
(svn r2173) -Fix: [ 1179380 ] Rail now builds on reserved land. Cause by the problem that CMD_ERROR is just the highest bit of the return value, but CMD_CLEAR_LANDSCAPE returns a negative value for owned land. So the highest bit is set as well. Note to self: Finish Command Patch
20 years ago
03569d1c49
(svn r2134) Return the correct error message if rail is already under a bridge, fix for r2131
20 years ago
ffe868a38a
(svn r2132) Fix copy&paste bug in r2131
20 years ago
e82468f627
(svn r2131) -Fix: Rewrite CmdBuildSingleRail(), this addresses several issues:
...
- Check input parameters for validity
- Adhere patch settings - you were able to build foundations under bridges even if foundations where deactivated
- Charge for foundations in all cases - foundations under bridges were for free
- Make the control flow more clear
20 years ago
7f6753ed89
(svn r2113) -Fix: first check if a vehicle is a train, before accessing u.rail
20 years ago
b2dd47f565
(svn r2102) Fix bug introduced in r2038, which gave you money for clearing occupied railway tiles ([1171926])
20 years ago
407b80656e
(svn r2095) In CheckTrackCombination(): if () cascade -> switch, improve readability
20 years ago
tron
Darkvater
matthijs
peter1138
truelight
ludde
celestar
hackykid