Commit Graph

717 Commits

Author SHA1 Message Date
michi_cc
b4b77221ce (svn r18778) -Fix [FS#3483]: [YAPP] Remove a special check for two-sided signals when reserving a path as this causes trains to get stuck in front of them. 2010-01-11 00:02:14 +00:00
peter1138
8651144bee (svn r18766) -Codechange: Make train acceleration type (rail/elrail/monorail vs maglev) a rail type property 2010-01-09 15:33:41 +00:00
rubidium
ad8d6e8dd2 (svn r18764) -Fix [FS#3422]: split the (un)load ticks counter and signal wait counter; sometimes they might get into eachother's way 2010-01-09 14:43:08 +00:00
peter1138
a70af30250 (svn r18674) -Feature (FS#3459): Configurable slope steepness for trains from 0% to 10%, default is 3% as before (mostly by Terkhen) 2009-12-31 10:41:03 +00:00
rubidium
27d9a3d840 (svn r18653) -Fix [FS#3442]: when trying to attach a wagon to an existing free wagon chain, don't attach it to itself 2009-12-28 18:26:39 +00:00
michi_cc
3ecd08be01 (svn r18647) -Fix: [YAPP] A train inside a station was not always found when checking for trains on a reserved path. 2009-12-27 14:37:50 +00:00
rubidium
e2c2370bc8 (svn r18628) -Fix [FS#3422]: (un)loading counter being reset while loading a train and changing the (path) signal setup around the station 2009-12-25 18:01:27 +00:00
rubidium
9d5a91ed07 (svn r18574) -Fix [FS#3392] (r18481): manually sending trains and RVs to depots didn't quite work 2009-12-20 16:19:47 +00:00
rubidium
e62a56e0f4 (svn r18515) -Change: make it visible when you're to pass the next signal on danger and possible to cancel it
-Fix [FS#2891]: when you pass a signal at danger, in a PBS controlled area, don't try to do the 'safe' thing and stop, but continue going; the user wanted the train to pass the signal at danger so (s)he has to suffer the consequences. Ofcourse one can always stop the train manually.
2009-12-16 16:23:44 +00:00
rubidium
75ed87aa71 (svn r18494) -Fix (r18474): crash when moving non-engine to new free wagon chain and group count was off when moving a front engine within the same train and the new front isn't an engine. 2009-12-13 22:17:12 +00:00
rubidium
f90086b696 (svn r18484) -Codechange: simplify the Is(Stopped)InDepot functions for trains 2009-12-13 17:13:20 +00:00
rubidium
899b3db66b (svn r18481) -Codechange: unify the curve pathfinder penalty defaults; 0.01 tile won't make a dent, 3 tiles might be a bit too much
-Feature-ish: make maximum pathfinder penalties for finding depots customisable, also increase it slightly to 20 tiles worth of penalties.
2009-12-13 10:48:44 +00:00
rubidium
689e7efe2f (svn r18474) -Fix (r18470): in some odd corner cases the group (vehicle) counts could be off 2009-12-12 23:49:30 +00:00
rubidium
54852d9a13 (svn r18473) -Fix (r18470): crash when moving a multiheaded part to be just after itself 2009-12-12 23:24:11 +00:00
rubidium
9eaf5edb53 (svn r18472) -Fix [FS#3146]: selling vehicles in the depot could create states that are not allowed by the NewGRF attach callback. 2009-12-12 22:59:48 +00:00
rubidium
f877cfb38a (svn r18470) -Codechange/Fix [part of FS#3146]: moving vehicles around in the depot could create states that are not allowed by the NewGRF attach callback. 2009-12-12 22:11:43 +00:00
rubidium
5fedaa4cca (svn r18466) -Codechange: use CmdMoveRailWagon to attach a just build wagon to a chain 2009-12-11 22:23:48 +00:00
rubidium
e80eabcc2c (svn r18465) -Codechange: simplify CheckTrainInDepot and remove some unneeded wrapper functions 2009-12-11 22:04:57 +00:00
rubidium
e253bda379 (svn r18463) -Codechange: some simplifications for finding the end of a vehicle 2009-12-11 19:28:28 +00:00
rubidium
d752254cfd (svn r18462) -Fix: when moving a wagon and only the last part of a dual headed engine you could split the dual headed engine over two vehicles. 2009-12-11 19:27:48 +00:00
rubidium
d9da9d46c5 (svn r18461) -Fix (r18456): when moving a wagon from the front of a train one could make a train 1 longer than allowed 2009-12-11 18:49:03 +00:00
rubidium
639e2986b7 (svn r18459) -Codechange: move the new train validity checking (attach callbacks) to a separate function 2009-12-11 16:16:36 +00:00
rubidium
e4439fd3d4 (svn r18458) -Codechange: make the 'check train length' code of CmdMoveRailVehicle a separate function 2009-12-11 15:50:07 +00:00
rubidium
9298f4d618 (svn r18456) -Codechange: make the length checking functionality of CmdMoveRailVehicle a separate function and simplify the logic 2009-12-11 13:37:01 +00:00
rubidium
5e2a1a46ed (svn r18420) -Codechange: split YAPF's track follower from the actual YAPF code 2009-12-07 08:41:18 +00:00
rubidium
6600610e47 (svn r18402) -Codechange: unify/centralise the code for crashing vehicles 2009-12-04 20:29:46 +00:00
rubidium
1c2214b430 (svn r18371) -Codechange: unify calling of the train pathfinders 2009-12-02 09:57:17 +00:00
rubidium
2f3053508d (svn r18364) -Codechange: move the pathfinders and their related files into a separate directory 2009-12-01 22:45:39 +00:00
rubidium
cbb87c41d5 (svn r18362) -Cleanup: remove OPF for RVs and NTP to clean up lots of code and simplify some things for the future 2009-12-01 22:18:51 +00:00
frosch
b5a07b3c70 (svn r18361) -Fix: Remove unneeded usage of invalid pointer. Also thank Hirundo and SmatZ. 2009-12-01 21:45:50 +00:00
frosch
e2b619392c (svn r18341) -Fix: Replace some GetNextVehicle() with GetNextUnit() where needed. 2009-11-29 18:46:54 +00:00
frosch
f60a437d36 (svn r18268) -Feature: [NewGRF] Make price base multipliers related to vehicles only apply to the GRF locally, if it defines engines of that type itself. 2009-11-24 13:15:58 +00:00
frosch
fe65c7f833 (svn r18266) -Codechange: Add a function to compute prices from price base and cost factor and use it consistently for vehicle purchase, running cost, and refit cost. 2009-11-24 13:12:34 +00:00
rubidium
d4774a2ce9 (svn r18123) -Codechange: try our best to keep the vehicles within the build vehicle list/autoreplace lists instead of overflowing. 2009-11-16 17:58:46 +00:00
rubidium
ddafe77904 (svn r18121) -Codechange: pass the maximum left/right location to the Draw*Engine functions 2009-11-16 17:15:42 +00:00
frosch
1bd8a982d5 (svn r18011) -Feature(ette): [NewGRF] CB 36 for roadvehicle property 09 'running cost factor'. 2009-11-08 13:02:05 +00:00
frosch
17039eaf42 (svn r18007) -Codechange: No need to call CB 36 'running cost factor' if the vehicle has no running cost class anyway. 2009-11-08 12:18:59 +00:00
alberth
5a97b64d73 (svn r17928) -Codechange: ShowErrorMessage() now takes the summary string before the details string.
Gentlemen, swap your string parameters.
2009-10-31 19:46:51 +00:00
frosch
020c53fc7e (svn r17899) -Codechange: Deduplicate code for refitting vehicles. 2009-10-28 21:09:37 +00:00
frosch
23980e6486 (svn r17897) -Fix [FS#3255]: CB15 and CB36 (capacity) were not always called when they should.
-Codechange: Move capacity calculation to a single function for all vehicle types, so the behaviour can be kept consistent easier.
2009-10-28 18:31:16 +00:00
frosch
61fbba4dc1 (svn r17894) -Fix: Invalidate cache of vehicle vars 40-43 after testruns of certain commands, that change them temporarily. 2009-10-27 20:37:55 +00:00
frosch
3a470a37cf (svn r17858) -Codechange: Unindent some code. 2009-10-24 19:16:18 +00:00
frosch
b25f03a447 (svn r17726) -Cleanup: Remove some unneeded/unused parameters. 2009-10-06 19:30:31 +00:00
frosch
4cb5a3e8a2 (svn r17725) -Codechange: Reduce usage of EngInfo and XxxVehInfo, esp. when a Engine * is already present. 2009-10-06 19:17:07 +00:00
rubidium
982b8ee5fc (svn r17693) -Cleanup: remove some unneeded includes 2009-10-04 17:16:41 +00:00
frosch
a9717da0d3 (svn r17684) -Fix: tcache.first_engine and rcache.first_engine need to be set before first callback/sprite-resolving. For RV fronts it was missing at all, causing livery selection to fail. 2009-10-03 14:46:48 +00:00
frosch
b6156da5e9 (svn r17616) -Codechange [FS#3222]: Enumerize properties used in callback 0x36. Based on Terkhen's work. 2009-09-22 19:28:57 +00:00
frosch
1192ed4c2d (svn r17594) -Fix: Vehicle image was not always updated when needed. 2009-09-20 19:36:27 +00:00
rubidium
4d378b946c (svn r17576) -Fix [FS#3208]: assertion triggered when the second vehicle in a 101+ (or 11+ if mammoth trains is disabled) vehicle free wagon chain is an engine and the first vehicle is moved to another chain 2009-09-19 13:55:37 +00:00
rubidium
06e490fadc (svn r17567) -Fix: some doxygen warnings 2009-09-18 14:23:58 +00:00
rubidium
4db98357ea (svn r17552) -Codechange: rename load_unload_time_rem to something more generic as it's used for more than just load/unload. Also add some documentation about where it is used. 2009-09-15 20:58:44 +00:00
rubidium
c2c0f4403e (svn r17534) -Codechange: unify the naming of callback masks/flags 2009-09-14 12:22:57 +00:00
frosch
0e36260337 (svn r17532) -Codechange: Rename several Invalidate functions to SetDirty for more consistency and distinguishability. 2009-09-13 19:15:59 +00:00
rubidium
91024042ea (svn r17495) -Codechange: replace 'Depot::Get(GetDepotIndex(tile))->index' with GetDepotIndex(tile) 2009-09-10 14:37:55 +00:00
rubidium
cd6b9ed7e4 (svn r17352) -Fix [FS#3162]: trains wouldn't show smoke if the load/unload counter wasn't 0, though there doesn't seem to be a reason to check that variable anyhow anymore 2009-09-01 18:35:24 +00:00
rubidium
99d46e0ad7 (svn r17248) -Fix: add GPL license notice where appropriate 2009-08-21 20:21:05 +00:00
smatz
d64bdb138c (svn r17168) -Codechange: apply coding style to if and while statements 2009-08-14 17:11:59 +00:00
michi_cc
2fb209c96a (svn r17152) -Fix: A stuck train could free the reservation of another train if it was reversed or did crash. 2009-08-10 23:52:44 +00:00
michi_cc
6c88e22cc7 (svn r17151) -Fix [FS#3104] (r13974): A train entering a PBS section through a block signal could cause a train crash if another reservation ending at a safe tile was already present in the section. 2009-08-10 23:52:40 +00:00
frosch
32a47df09a (svn r17121) -Fix [FS#3060]: Update vehicle position cache when the vehicle sprite changes. 2009-08-08 18:45:12 +00:00
smatz
096aca2479 (svn r17085) -Codechange: unify the place where vehicle's cargo ages 2009-08-06 12:44:10 +00:00
smatz
4a39f236fa (svn r17084) -Codechange: _age_cargo_skip_counter is common to all vehicle types 2009-08-06 12:33:13 +00:00
rubidium
d61be2637e (svn r17075) -Codechange: rename ~750 strings to be more uniform with their relatives 2009-08-05 17:59:21 +00:00
rubidium
5bb7b8ad35 (svn r17062) -Change: unify the naming of some 125 strings 2009-08-04 18:04:33 +00:00
rubidium
58563eafa7 (svn r16947) -Codechange: use TileArea instead of train_tile, trainst_w and trainst_h. 2009-07-25 08:54:19 +00:00
rubidium
196856f54e (svn r16939) -Codechange: s/RailwayStation/RailStation/ to unify the way it's written. 2009-07-24 11:47:12 +00:00
rubidium
100cb17fa8 (svn r16909) -Fix [FS#2996]: NewGRF stations would be triggering assertions all over the place when using the more advanced station types.
-Change: make (rail) waypoints sub classes of 'base stations', make buoys waypoints and unify code between them where possible.
2009-07-22 08:59:57 +00:00
rubidium
9eaee690bc (svn r16908) -Codechange: s/DepotWaypointReservation/DepotReservation/ 2009-07-22 08:52:41 +00:00
rubidium
f1d6561cc4 (svn r16907) -Codechange: make a more clear distinction between reservation functions that return a bool and that return TrackBits; GetRailStationReservation vs GetRailwayStationReservation, which one returns the bool and which one the TrackBits? 2009-07-21 22:37:10 +00:00
rubidium
84dec43208 (svn r16901) -Fix [FS#3046] (rpbs): when marking trains stuck don't reset the unload counter/stuck when the vehicle is unloading. It'll be automatically reset once the vehicle wants to leave the station 2009-07-21 17:14:05 +00:00
frosch
fec6129cd1 (svn r16894) -Codechange: Add [Specialised]Vehicle::Last(). 2009-07-20 19:58:33 +00:00
frosch
f1f4edfbd1 (svn r16884) -Codechange: Add Train::GetFirstEnginePart() and use it. 2009-07-19 19:17:41 +00:00
frosch
12ea92a257 (svn r16867) -Feature(ette): Turn variable 0E/8E (vertical offset for trains in depot) and variable 1E/9E bit 3 (wagon width in depot) into grf-local variables. 2009-07-17 22:00:13 +00:00
smatz
0b4b9dd764 (svn r16857) -Fix [FS#3036](r16652): crash when train partially in depot crashed 2009-07-17 13:54:06 +00:00
smatz
8718babe90 (svn r16849) -Codechange: replace GetCargo() by CargoSpec::Get() 2009-07-16 19:00:13 +00:00
rubidium
74f56861e9 (svn r16772) -Fix [FS#3019]: don't use the same error message for turning around road vehicles and flipping parts of trains in the depot 2009-07-08 22:11:55 +00:00
smatz
32bf91aa41 (svn r16723) -Codechange: make GetNextArticPart(), GetLastEnginePart(), GetNextVehicle(), GetPrevVehicle(), GetNextUnit(), GetPrevUnit() members of Train 2009-07-02 12:10:39 +00:00
smatz
9b10bc9cdf (svn r16720) -Codechange: make Set/ClearFrontEngine(), Set/ClearArticulatedPart(), Set/ClearWagon(), Set/ClearEngine(), Set/ClearFreeWagon() and Set/ClearMultiheaded() members of Train 2009-07-02 00:17:27 +00:00
smatz
1e1f0ab2cf (svn r16719) -Codechange: make IsArticulatedPart(), IsTrainEngine(), IsTrainWagon(), IsMultiheaded(), EngineHasArticPart() and IsRearDualheaded() members of Train 2009-07-01 23:57:20 +00:00
smatz
378d01f2f4 (svn r16718) -Codechange: make IsFreeWagon() member of Train 2009-07-01 23:49:13 +00:00
smatz
20fedeb3d6 (svn r16717) -Codechange: make IsFrontEngine() member of Train 2009-07-01 22:22:01 +00:00
smatz
c113303593 (svn r16655) -Codechange: use IsRailwayStationTile() more 2009-06-25 15:54:06 +00:00
smatz
d4538bc611 (svn r16652) -Codechange: use less strict, but faster check for quickly bailing out in FindTrainCollideEnum() (Bilbo)
-Codechange: shuffle the code a bit
2009-06-24 23:59:20 +00:00
smatz
a9602401f0 (svn r16646) -Codechange: rename GetDepotByTile() to Depot::GetByTile() 2009-06-24 19:26:41 +00:00
smatz
4b3bf5667a (svn r16641) -Codechange: reduce number of multiplications done in FindTrainCollideEnum() to minimum 2009-06-23 23:31:43 +00:00
smatz
9ec6fc8a61 (svn r16633) -Codechange: remove checks for consistency of newpool 2009-06-23 10:44:46 +00:00
rubidium
8ca2ccc456 (svn r16581) -Codechange: unify the access to Engine::lifelength. 2009-06-16 13:52:18 +00:00
rubidium
ee96d737b2 (svn r16580) -Codechange: rename Engine::image_index to original_image_index to not confuse it with image_index from *VehInfo. 2009-06-16 13:31:06 +00:00
smatz
632a3191f6 (svn r16571) -Fix [FS#2974](r16322): in some cases, train could be stuck in depot 2009-06-13 10:22:22 +00:00
smatz
ca9787b2ea (svn r16553) -Codechange: don't use TRACK_BIT_WORMHOLE and TRACK_BIT_DEPOT as bitmasks 2009-06-10 16:02:00 +00:00
smatz
5c934c621d (svn r16545) -Cleanup: tunnels have been returning correct SlopeZ since r1 2009-06-09 20:04:46 +00:00
smatz
af85994f7f (svn r16527) -Codechange: use static member functions instead of simple casts when converting Vehicle to specialised vehicle types. Includes safety check 2009-06-06 16:54:22 +00:00
frosch
c9eac207ea (svn r16498) -Codechange: Remove hardly used HASBITS. 2009-06-01 15:01:54 +00:00
smatz
c5240c770c (svn r16494) -Codechange: cache train's speed limit caused by curves 2009-06-01 13:14:56 +00:00
alberth
580e478e4e (svn r16491) -Codechange: Added parentheses around bitwise operators for code style. 2009-06-01 11:43:36 +00:00
frosch
6e06b592ad (svn r16480) -Fix (r15617): Invalidate newgrf variable caches of more vehicles in more places. Esp. they were only invalidated for trains. 2009-05-31 12:03:14 +00:00
smatz
e419fe6d3f (svn r16442) -Codechange: use new Vehicle accessors at more places 2009-05-26 22:45:48 +00:00
smatz
0c53f04c07 (svn r16441) -Codechange: new class SpecializedVehicle used as superclass for all vehicle types 2009-05-26 22:10:13 +00:00
yexo
f044ad6f80 (svn r16439) -Change: Make the default vehicle servicing settings company-based settings, so in a multiplayer game everyone can change them. 2009-05-26 21:59:49 +00:00
rubidium
82cdacb20c (svn r16427) -Codechange: replace a few magic numbers with an existing constant and unduplicate a few lines. 2009-05-26 08:53:16 +00:00
rubidium
c496a3e014 (svn r16421) -Codechange: do not unnecessarily remove constness or unnecessarily add it. 2009-05-24 20:29:04 +00:00
frosch
eeb3f75cfe (svn r16416) -Fix [FS#2912]: Rework deleting of news when referenced vehicles/stations/industries are deleted. 2009-05-24 16:52:42 +00:00
frosch
6e06e82bc4 (svn r16414) -Change: Make it harder to ignore/close important error messages. Esp. do not close them automatically after some time. 2009-05-24 12:50:58 +00:00
rubidium
6cfc38b97c (svn r16397) -Codechange: move GetVehicleOrder/GetLastVehicleOrder into Vehicle 2009-05-23 12:27:42 +00:00
rubidium
cd382b28a3 (svn r16394) -Codechange: move (NewGRF) cache variables into a separate struct so (some vehicle related) NewGRF cache 'desyncs' can be tested easier. 2009-05-23 09:10:56 +00:00
rubidium
4c0542c17f (svn r16393) -Codechange: move VehicleRail to Train. 2009-05-22 22:55:41 +00:00
rubidium
6350648a6c (svn r16392) -Codechange: move some variables (the ones that aren't caches) from VehicleRail to Train 2009-05-22 22:33:05 +00:00
rubidium
1324100d69 (svn r16391) -Codechange: use Train instead of Vehicle where appropriate. 2009-05-22 22:22:46 +00:00
rubidium
521c265282 (svn r16384) -Codechange: move u.effect to EffectVehicle 2009-05-22 18:56:25 +00:00
rubidium
86fc432293 (svn r16382) -Codechange: make GetVehicleTrackdir a member function of Vehicle. 2009-05-22 18:17:20 +00:00
smatz
50624d5c0f (svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation time, binary size and run time (with asserts disabled) should be improved 2009-05-22 15:13:50 +00:00
smatz
70d3ed15c8 (svn r16376) -Codechange: Vehicle::Tick() now returns false if the vehicle was deleted 2009-05-22 13:53:14 +00:00
smatz
512db5248e (svn r16352) -Codechange: use PoolItem::GetIfValid() instead of PoolItem::IsValidID() and PoolItem::Get() 2009-05-18 16:21:28 +00:00
smatz
05db91dc65 (svn r16349) -Codechange: rename IsPlainRailTile() to IsPlainRail(), introduce shiny new IsPlainRailTile() 2009-05-18 01:26:23 +00:00
smatz
0c10daa243 (svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index) 2009-05-17 01:00:56 +00:00
smatz
d495dc5dbc (svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index) 2009-05-16 23:34:14 +00:00
rubidium
3ab3cfcff3 (svn r16322) -Fix [FS#2873]: trains could get stuck in a depot when they wanted to go to the same depot again. 2009-05-16 20:08:49 +00:00
frosch
2431cc099e (svn r16303) -Codechange: Use the question mark as default sprite when creating vehicles, instead of arbitrary sprites not related to the vehicle. (though that also applies to the question mark) 2009-05-13 21:45:56 +00:00
smatz
c189a15e3e (svn r16302) -Codechange: remove Vehicle::AllocateList 2009-05-13 21:38:23 +00:00
smatz
3b6900baa8 (svn r16301) -Cleanup: remove unused parameter 2009-05-13 20:30:46 +00:00
frosch
8bb92c110d (svn r16260) -Codechange: Add Vehicle::IncrementOrderIndex() to deduplicate some code. 2009-05-09 13:37:18 +00:00
rubidium
241af768f0 (svn r16242) -Codechange: rework pausing
-Fix [FS#2864]: autopause and manual pausing conflict with eachother
-Fix: new game + pause on new game + autopause make the game not unpause on the first join
2009-05-06 15:06:57 +00:00
rubidium
5c5b357043 (svn r16118) -Change/cleanup: remove the hexadecimal 'in TTD the string had this ID' from 'some' strings and replace the string name with something more sensible. 2009-04-21 23:40:56 +00:00
rubidium
a166a300aa (svn r16087) -Fix (r16079): slow trains wouldn't crash into eachother anymore 2009-04-19 04:36:53 +00:00
rubidium
51288dee9d (svn r16079) -Fix [FS#2824]: insanely fast trains would not stop in time for stations
-Fix: insanely fast trains would sometimes 'jump' over waypoints/via stations within a tick, which would cause the order not to be processed causing the train to go in loops until (with luck) it 'hit' the tile
2009-04-18 13:43:05 +00:00
frosch
6731a8f1b8 (svn r16075) -Fix (r15792)[FS#2844]: Mixed up TRACK_BIT_X/Y. 2009-04-17 23:16:01 +00:00
rubidium
3d5a7496c7 (svn r16057) -Fix [FS#2834] (r16037): division by zero when having an order with only one station that has either middle or near end stop location and where the platform is (significantly) longer than the train. 2009-04-13 22:27:21 +00:00
rubidium
4c707c7414 (svn r16037) -Feature: allow (per order) to let a train stop at the near end, middle or far end of a platform from the point of view of the driver of the train that enters the station. 2009-04-12 14:11:14 +00:00
frosch
6900854383 (svn r15793) -Feature: Allow train vehicles to be shorten to 1/8 length, even if not at the end of the train. 2009-03-21 22:32:51 +00:00
frosch
12dbe1dd0f (svn r15792) -Codechange: Use a different algorithm for train vehicles to follow the vehicle in front of them. 2009-03-21 22:25:38 +00:00
frosch
25b70e8c0d (svn r15789) -Codechange: Add DiagdirBetweenTiles() and use it. 2009-03-21 21:43:23 +00:00
rubidium
c3e87f345d (svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too 2009-03-15 00:32:18 +00:00
frosch
d86e821f53 (svn r15701) -Fix [FS#2595]: Blame NewGRFs returning inconsistent information in purchase-list/after building before users have a chance to blame OpenTTD for incorrectly autorenewing/-replacing. 2009-03-13 21:28:40 +00:00
rubidium
404cff525b (svn r15677) -Fix [FS#2546]: vehicle images would be determined during the process of moving the vehicle which means that only the (orientation) data for the vehicles in front of it is valid. Now the data for the vehicles behind the vehicle are valid too. 2009-03-11 23:23:08 +00:00
rubidium
b003536ea8 (svn r15676) -Codechange: remove the need for BeginVehicleMove and merge VehiclePositionChanged and EndVehicleMove. 2009-03-11 20:43:14 +00:00
rubidium
b9aa5e17f2 (svn r15617) -Change [FS#2694]: vehicle variables 40-43 weren't cached (though spec stated they are). Caching these variables can yield a 10+% speed increase when those vehicle variables are queried often. 2009-03-04 23:32:23 +00:00
frosch
abe4692da2 (svn r15541) -Revert (r15399): 'v->cargo_type' is also used in other places, which cannot accept CT_INVALID.
-Codechange: Add Engine::GetDefaultCargoType() and Engine::CanCarryCargo() and use them.
-Fix [FS#2617]: When articulated parts have no available default cargo, use the cargo type of the first part for livery selection.
-Change: To decide whether a vehicle is refittable do not test its current capacity for being zero, but always use the 'capacity property'.
  Note: The property is used unmodifed without calling CB 15/36. By setting it to a non-zero value and returning zero in the callback vehicles can be refitted to/from zero capacity for e.g. livery effects.
  Note: It is intentional that you cannot control refittability by CB 36.
2009-02-21 12:52:41 +00:00
smatz
ff706b1e63 (svn r15497) -Fix (r15027): when trains crashed, AIEvent was created only for one train 2009-02-16 17:16:58 +00:00
smatz
26cdcb2dd5 (svn r15496) -Codechange: one division less in the train acceleration code 2009-02-16 01:57:55 +00:00
smatz
2c317b7321 (svn r15439) -Fix [FS#2626]: call Vehicle::LeaveStation() before reversing overlength loading train (station triggers were missed, PBS reservation could cause crash) 2009-02-10 12:49:12 +00:00
rubidium
5c8cf85613 (svn r15434) -Codechange: bit of type safety for the DC_xxx flags. 2009-02-09 21:20:05 +00:00
rubidium
89e1afdaa0 (svn r15428) -Codechange: consistently use colour instead of having both color and colour. 2009-02-09 02:57:15 +00:00
frosch
f6fa77d5f9 (svn r15358) -Add [NoAI]: AIEventVehicleCrashed::GetCrashReason() 2009-02-05 17:28:37 +00:00
peter1138
d9c143669b (svn r15320) -Codechange: Increase 'realistic' acceleration 'resolution' by one bit by reducing a division and removing a multiplication: 3/4*2 = 0; 3/2 = 1. And a smidgeon less CPU usage, hah. 2009-02-02 21:38:36 +00:00
michi_cc
c875cb18d6 (svn r15313) -Cleanup: Use helper functions we already have and add some documentation. 2009-02-02 01:28:42 +00:00
smatz
9021c20b5e (svn r15299) -Cleanup: remove many redundant includes 2009-01-31 20:16:06 +00:00
glx
1310ddf5b5 (svn r15269) -Codechange: reduced indentation in CmdBuildRail* 2009-01-25 15:35:21 +00:00
frosch
69766242b8 (svn r15268) -Fix: AIEventVehicleLost triggered at every pbs signal independent of the vehicle being lost. 2009-01-25 13:20:13 +00:00
glx
470da22ac3 (svn r15263) -Codechange: added Engine::GetCost() to remove some code duplication. 2009-01-25 00:57:03 +00:00
peter1138
598fdab47e (svn r15236) -Codechange: Rename realistic_acceleration patch option to train_acceleration_model, and change from boolean to value. Don't forget to update your settings. 2009-01-23 20:53:43 +00:00
peter1138
d7d7a55060 (svn r15208) -Codechange: Remove some kind (undocumented, so who really knows) of original attempt to limit maximum tractive effort from 'realistic' acceleration. 2009-01-22 14:34:29 +00:00
peter1138
4d8c467067 (svn r15205) -Revert (r7421, partial): Support for MaxTE solves problem in a better way 2009-01-22 09:57:31 +00:00
frosch
3940ed7e6f (svn r15125) -Fix [FS#2544]: Do not try to determine the next order destination, if there are no orders. 2009-01-17 16:25:32 +00:00
smatz
ca45774160 (svn r15077) -Codechange: enumify DAYS_IN_YEAR and DAYS_IN_LEAP_YEAR
-Change: when computing daily running cost, divide by 365 (instead of 364). Since r12134, the rounding errors don't need this correction anymore
2009-01-13 22:58:03 +00:00
truebrain
c2406cd42d (svn r15027) -Merge: tomatos and bananas left to be, here is NoAI for all to see.
NoAI is an API (a framework) to build your own AIs in. See:
   http://wiki.openttd.org/wiki/index.php/AI:Main_Page
 With many thanks to:
  - glx and Rubidium for their syncing, feedback and hard work
  - Yexo for his feedback, patches, and AIs which tested the system very deep
  - Morloth for his feedback and patches
  - TJIP for hosting a challenge which kept NoAI on track
  - All AI authors for testing our AI API, and all other people who helped in one way or another
-Remove: all old AIs and their cheats/hacks
2009-01-12 17:11:45 +00:00
frosch
69877b356f (svn r15009) -Fix [FS#2528]: No need to extent the reserved path when the vehicle is still loading. 2009-01-12 14:56:31 +00:00
frosch
83467061b7 (svn r14994) -Fix [FS#Aali]: Better handling of OT_LOADING and OT_LEAVESTATION in ChooseTrainTrack. 2009-01-11 16:33:03 +00:00
frosch
5719596ce2 (svn r14993) -Fix (r14957, r14975): Do not reverse the train with OT_LEAVESTATION as that breaks PBS prediction. 2009-01-11 15:39:49 +00:00
frosch
1fdd53e428 (svn r14975) -Fix (r14957): Do not immediatelly move the train when leaving the station and the destination is not yet known. 2009-01-10 17:39:43 +00:00
frosch
818b162b35 (svn r14957) -Fix [FS#2516]: Do not abort train movement, when we are just about to reach the end of the platform. 2009-01-10 15:27:57 +00:00
rubidium
28ea38ae55 (svn r14949) -Cleanup: pointer coding style 2009-01-10 00:31:47 +00:00
rubidium
054787f082 (svn r14943) -Cleanup: remove some rogue spaces/replace some rogue tabs with spaces 2009-01-09 22:48:57 +00:00
michi_cc
b201fb1226 (svn r14852) -Feature: Automatic reversing in front of block signals can now be disabled by setting pf.wait_oneway_signal respectively pf.wait_twoway_signal to 255. 2009-01-05 20:29:05 +00:00
michi_cc
fc9b6b8872 (svn r14851) -Fix: A train reversing in a non-PBS block can't be stuck. 2009-01-05 20:29:00 +00:00
michi_cc
b4289b40f4 (svn r14850) -Fix [FS#2503]: Reversing a stuck train that is then not stuck anymore did not always reset the waiting timer. 2009-01-05 20:28:56 +00:00
smatz
ec7ebf2170 (svn r14835) -Change: apply the 'warn if train's income is negative' setting to other vehicle types, too 2009-01-04 18:34:23 +00:00
smatz
b1f7ef7076 (svn r14831) -Codechange: use {VEHICLE} instead of Train/Ship/Road veh/Aircraft/{STRING} {COMMA} in lang files (part by Swallow) 2009-01-04 17:42:46 +00:00
smatz
91233ea596 (svn r14828) -Codechange: move most of save/load-specific code to separate files 2009-01-04 15:32:25 +00:00
rubidium
183f8df552 (svn r14826) -Fix [FS#2494]: infinite loop in order lookahead when reserving a path (Swallow) 2009-01-04 14:36:19 +00:00
rubidium
f316796629 (svn r14803) -Codechange: move order list management into it's own class and remove the order count from the savegame as we can easily count that (PhilSophus) 2009-01-03 13:52:06 +00:00
rubidium
abd3b8e0d7 (svn r14801) -Codechange: don't reference Vehicle::num_orders directly but through a method GetNumOrders() (PhilSophus) 2009-01-03 13:20:32 +00:00
rubidium
d91baac764 (svn r14785) -Fix [FS#2132]: vehicle list for station gets closed when station view is closed even when the vehicle list is stickied. Other vehicle lists are not deleted when their 'opening' window gets closed so do the same with the station view. 2009-01-02 20:59:04 +00:00
rubidium
56d108edf8 (svn r14779) -Fix (r14747) [FS#2485]: selling an articulated vehicle removed only the first part and not the rest. 2008-12-31 17:52:42 +00:00
rubidium
e83cca7d13 (svn r14754) -Codechange: get rid of _cmd_text and just pass it as (optional) parameter. 2008-12-28 14:37:19 +00:00
rubidium
0c6c3311c9 (svn r14748) -Codechange: unduplicate window updating when deleting vehicles. 2008-12-26 21:08:51 +00:00
rubidium
c34ce32f26 (svn r14747) -Codechange: remove DeleteVehicleChain in favour of the vehicle destructor as that was already doing the same for a few vehicle types. 2008-12-26 20:45:02 +00:00
smatz
c88a6199a7 (svn r14743) -Codechange: use INVALID_TILE to indicate station doesn't have queried facility (or station/roadstop is invalid) instead of 0 (Yexo) 2008-12-26 18:01:15 +00:00
frosch
6afd6a450f (svn r14699) -Fix (r14483): Do not use v->dest_tile for trains heading to a station. Reaching that tile does not mean reaching the station. 2008-12-20 00:16:23 +00:00
frosch
d64b89838e (svn r14695) -Cleanup: When NTP is not active there is no need to set up TrainTrackFollowerData. 2008-12-19 22:26:43 +00:00
rubidium
33008f5d8b (svn r14594) -Fix [FS#2412]: trains could get their their last visited station reset when still (un)loading causing an invalid state. 2008-11-19 14:48:12 +00:00
frosch
24bd9866f8 (svn r14578) -Fix (r2389, r10811)[FS#Vikthor]: Allow capacity callbacks (15, 36) to return zero capacity. 2008-11-13 20:26:06 +00:00
michi_cc
023ce24b1a (svn r14559) -Fix [FS#2387]: A train could be blocked inside a depot if it was reversed just after leaving the depot. 2008-11-02 19:32:24 +00:00
michi_cc
147304b83d (svn r14550) -Fix [FS#2391]: Don't assert on path look-ahead when processing a not-part-of-orders depot-order. 2008-10-31 16:46:34 +00:00
rubidium
33203c67c1 (svn r14526) -Fix [FS#2379]: make sure trains stop at the end of a station; a 3/8th length train did stop 2/8th of it's length too early causing a 63/8th long train not to fit in a 4 tile station. 2008-10-24 20:53:57 +00:00
glx
f28957bcc4 (svn r14521) -Fix [FS#2378]: fast trains could continue to move after a crash 2008-10-22 23:06:36 +00:00
michi_cc
4424c2e6fb (svn r14492) -Fix [FS#2366] (r14482): Conditional orders could lead to an infinite loop on path look-ahead.
Don't refactor things that don't want to be refactored, folks. And some comments can't hurt either.
2008-10-19 17:16:26 +00:00
michi_cc
5c781a921a (svn r14483) -Fix [FS#2340]: On reaching a waypoint a train could falsely be reported as lost when doing the look ahead for a path. 2008-10-18 13:13:31 +00:00
michi_cc
9a7270d147 (svn r14482) -Codechange: Use a class for saving the current train order when extending the reserved path beyond the current destination during pathfinding.
The class' destructor will make sure that the order is restored on function exit in all cases.
2008-10-18 13:13:27 +00:00
rubidium
b5e467978b (svn r14464) -Codechange: replace (uint)-1 with UINT_MAX (PhilSophus) 2008-10-14 18:38:51 +00:00
rubidium
3113cc17b9 (svn r14436) -Fix [FS#1793]: (fast) trains would sometimes move one time too often/little when moving from diagonal<->non-diagonal tracks (iguannab) 2008-10-03 12:55:39 +00:00
rubidium
e589c7e580 (svn r14422) -Codechange: also reflect the changes of r14421 in the filenames. 2008-09-30 20:51:04 +00:00
rubidium
f56e630e5c (svn r14421) -Codechange: rename all player variables/types to company *or* client so it is immediatelly clear which one you are working with. 2008-09-30 20:39:50 +00:00
frosch
423160f946 (svn r14405) -Fix [FS#2289]: Correct handling of selling free wagons while the following vehicle is an engine (i.e. a new train is created). 2008-09-26 19:25:49 +00:00
frosch
5fd49a8cd2 (svn r14403) -Fix (r14384): The condition was too restrictive. 2008-09-26 19:01:57 +00:00
peter1138
21a5c6bb7d (svn r14401) -Fix (r11724): Don't check articulated parts or rear multihead parts for callback 1D when moving a chain of wagons. 2008-09-26 06:52:06 +00:00
rubidium
48ece47bd9 (svn r14397) -Fix: possible buffer overrun, wrong parameter type passed to printf and && where || is meant. Found by MSVC's code analysis (Darkvater) 2008-09-24 23:25:24 +00:00
frosch
fb1fae001a (svn r14384) -Fix: Moving the first vehicle of a train elsewhere might require a new unitnumber for the remaining chain. 2008-09-22 19:28:53 +00:00
rubidium
7935517470 (svn r14371) -Fix [FS#2313]: loading indicator didn't stay with the front engine when turning a train in a station. 2008-09-21 18:28:35 +00:00
frosch
a4fd962adf (svn r14366) -Fix (r14362): Match multiheaded parts starting from the first vehicle in a chain. 2008-09-20 18:31:31 +00:00
frosch
6782d81142 (svn r14362) -Fix (r3403): Also connect multiheaded parts in free wagon chains. 2008-09-20 10:53:08 +00:00
smatz
7e4e999a97 (svn r14307) -Fix: when deleting a station, remove news items regarding it 2008-09-13 10:19:51 +00:00
michi_cc
5a28d3a54f (svn r14285) -Fix [FS#2263]: A train inside a wormhole could free the reservation of another train inside the wormhole. 2008-09-09 19:02:47 +00:00
michi_cc
e008f58350 (svn r14284) -Fix (r13958): Trains would not look ahead and extend their reservation on a waypoint tile in all cases. 2008-09-09 18:47:53 +00:00
rubidium
6e67ea1f9d (svn r14258) -Codechange: rework the way to query the vehicle hash to make sure it always results in the same irregardless of the order of the hash-linked-list.
-Fix: desync in PBS reservation following, vehicle flooding and road vehicle overtake/follow code.
2008-09-07 11:23:10 +00:00
frosch
f932e81127 (svn r14149) -Fix: When selling the front engine of a train consist with another engine at the second position, not all 'important' data was copied to the new head. 2008-08-23 23:31:27 +00:00
frosch
b66b3937ed (svn r14148) -Fix (r14096) [FS#2239]: Orders were freed while they were still shared by other vehicles. 2008-08-23 23:15:04 +00:00
frosch
2dd9bc672a (svn r14131) -Fix (r13952) [FS#2250]: The reservation of adjacent stations was sometimes not freed correctly. (michi_cc) 2008-08-22 22:42:21 +00:00
frosch
7020a48ea0 (svn r14130) -Fix (r13961) [FS#2248]: Clear the stuck state of a train that is reversing with the first vehicle inside a depot. (michi_cc) 2008-08-22 22:28:26 +00:00
rubidium
66b9ea9a5a (svn r14096) -Codechange: merge the shared order's vehicle list management to a single location. 2008-08-17 19:56:17 +00:00
rubidium
38905d596f (svn r14089) -Fix [FS#2219]: trains not being able to find a route to a depot when the front is already in the depot. 2008-08-17 11:04:37 +00:00
frosch
92f3c368b8 (svn r14083) -Fix [FS#1264, FS#2037, FS#2038, FS#2110]: Rewrite the autoreplace kernel. 2008-08-16 14:02:20 +00:00
peter1138
550fc3a3f5 (svn r14078) -Codechange: Rename *VehicleInfo::base_cost to cost_factor, indicating what it actually is. 2008-08-15 17:54:43 +00:00
frosch
c8e699cc35 (svn r14076) -Codechange: Merge the four start/stop commands into a single CMD_START_STOP_VEHICLE. 2008-08-15 13:57:43 +00:00
rubidium
19de9ac7e1 (svn r14039) -Fix [FS#2217]: reversing an overlength train at a station would try to find a route out and sometimes reset the unload counter making it wait 2.5 years before departing instead of waiting until the train would actually leave the station (michi_cc) 2008-08-10 21:56:47 +00:00
rubidium
f0347e5383 (svn r14036) -Fix [FS#2197,FS#2198]: trains crashing into eachother when signals are changed (michi_cc) 2008-08-10 13:37:09 +00:00
smatz
c665a2f233 (svn r14021) -Fix (r13957) [YAPP]: Overbuilding station tiles with non-track tiles could produce stale reservations. (michi_cc) 2008-08-08 13:29:18 +00:00
smatz
7fce33fb51 (svn r14001) -Fix (r13989): reading wrong variable, train crash on bridge crashes game 2008-08-05 13:25:49 +00:00
rubidium
33148eae6e (svn r13989) -Fix [FS#2186] (r13953): YAPP track reservation for crashed trains was broken for depots and wormholes (michi_cc). 2008-08-04 13:15:15 +00:00
frosch
8644a8915e (svn r13983) -Fix (r13953) [YAPP]: Crashed trains can be on different trackbits. Make sure there is still a track reservation when one vehicle is cleaned up. 2008-08-03 19:04:11 +00:00
frosch
fe058e2ec2 (svn r13976) -Fix (r13953) [YAPP]: A crashing train could sometimes free the reservation of another train. (assisted by michi_cc) 2008-08-03 17:16:39 +00:00
frosch
ba1b3c7f11 (svn r13974) -Fix [YAPP]: A train crash could lead to stale reservations. (michi_cc) 2008-08-03 14:16:57 +00:00
rubidium
8b10e70f39 (svn r13971) -Fix [YAPP]: segfault due to mixed up variables (michi_cc) 2008-08-03 08:20:04 +00:00
rubidium
1e549a0fcc (svn r13966) -Codechange [YAPP]: Bar level crossings upon path reservation. (michi_cc) 2008-08-02 22:57:18 +00:00
rubidium
14f6b1f49c (svn r13964) -Codechange [YAPP]: Check if a train needs servicing when reserving the next path segment. (michi_cc) 2008-08-02 22:56:50 +00:00
rubidium
e0e8f0e711 (svn r13963) -Codechange [YAPP]: Reserve a track when entering a PBS block through a conventional signal. (michi_cc) 2008-08-02 22:56:35 +00:00
rubidium
ed629f599b (svn r13962) -Codechange [YAPP]: Do not reverse in front of red signals when inside a PBS block and reversing of stuck trains is disabled. (michi_cc) 2008-08-02 22:56:21 +00:00
rubidium
a32fb70e1d (svn r13961) -Add [YAPP]: Handle train reversing. (michi_cc) 2008-08-02 22:56:07 +00:00
rubidium
e78a235293 (svn r13960) -Codechange [YAPP]: Reserve a path when exiting a depot into a PBS block. (michi_cc) 2008-08-02 22:55:52 +00:00
rubidium
0b38276d5a (svn r13959) -Codechange [YAPP]: Try to extend a train reservation as far as possible and only call into the pathfinder on track choices. (michi_cc) 2008-08-02 22:55:38 +00:00
rubidium
1415b19fad (svn r13958) -Add [YAPP]: Implement look-ahead for trains so they extend their reservation before reaching the end. (michi_cc) 2008-08-02 22:55:23 +00:00
rubidium
c213ff35e5 (svn r13955) -Codechange [YAPP]: Try to extend the path of a stuck train so it is able to continue. (michi_cc) 2008-08-02 22:54:38 +00:00
rubidium
49967b9077 (svn r13954) -Codechange [YAPP]: On reserving a path that ends at the destination, the path could end at a non-safe tile. In this case, extend the reservation based on the next vehicle orders. (michi_cc) 2008-08-02 22:54:23 +00:00
rubidium
f6bdf23527 (svn r13953) -Add [YAPP]: Free track reservations of crashed trains. (michi_cc) 2008-08-02 22:54:07 +00:00
rubidium
2e2a6d4909 (svn r13952) -Add [YAPP]: Trains now reserve paths trough PBS signals. Bump savegame version. (michi_cc) 2008-08-02 22:53:51 +00:00
rubidium
21e4904eb3 (svn r13951) -Codechange [YAPP]: A train leaving a tile should unreserve the track it came from if it was reserved. (michi_cc) 2008-08-02 22:53:37 +00:00
rubidium
a31e86c778 (svn r13950) -Add [YAPP]: Trains can now also be in a 'stuck' state when waiting on a path reservation. (michi_cc) 2008-08-02 22:53:21 +00:00
rubidium
2b6978e48e (svn r13912) -Codechange: remove some casts by returning the proper type instead of void*. 2008-08-01 15:07:31 +00:00
smatz
0a67e72df5 (svn r13911) -Fix (r13806): do not consider crashed train as waiting at signal, v->direction doesn't have to match track anyway 2008-08-01 13:25:19 +00:00
peter1138
93c279d6b4 (svn r13870) -Fix [FS#2167]: Callback 10 (visual effect and powered wagons setting) and powered wagons operation were not performed for articulated wagons. 2008-07-29 22:19:37 +00:00
smatz
c4c20c324f (svn r13817) -Cleanup (r13816): no need to check for ENABLE_NETWORK, _networking is defined anyway 2008-07-24 16:23:55 +00:00
smatz
f1c0555d2e (svn r13816) -Fix [FS#2150]: check for vehicle length changes outside a depot (callback 0x11) and give a warning about that 2008-07-24 15:19:26 +00:00
smatz
cf4aff4a86 (svn r13806) -Fix [FS#2162]: checking for train waiting at other side of two-way signal was broken 2008-07-23 18:23:12 +00:00
smatz
a47b118a80 (svn r13691) -Codechange: make it easier to determine whether a command is ran in the context of autoreplace or not 2008-07-09 20:55:47 +00:00
peter1138
7d877c0c05 (svn r13507) -Fix (r12856): first engine change should've been moved too 2008-06-13 13:28:55 +00:00
smatz
506cde94b6 (svn r13456) -Codechange: use AllocaM() macro instead of alloca() at most places 2008-06-10 21:59:22 +00:00
glx
b60a1326bf (svn r13390) -Codechange: introduce usererror() for fatal but not openttd related errors. Now all error() will 'crash' openttd after showing the message in win32 releases (MSVC), creating a crash.log and crash.dmp (like the '!' hack used before). On the other hand, usererror() will just close the game. So use error() only when it can be helpful to debugging, else use usererror(). 2008-06-05 20:54:52 +00:00
rubidium
e7a501100a (svn r13325) -Codechange: split the client-side only settings from the settings stored in the savegame so there is no need to have a duplicate copy of it for new games. 2008-05-29 15:13:28 +00:00
rubidium
d289464d69 (svn r13255) -Codechange: move _opt to _settings. 2008-05-25 22:36:44 +00:00
rubidium
dc77647ea4 (svn r13251) -Codechange: rename _patches to _settings as that is more logic.
-Codechange: move all Settings into substructs of _settings in a way that they are logically grouped.
2008-05-25 19:17:03 +00:00
peter1138
42f78d2fc3 (svn r13205) -Codechange: Remove unnecessary code-style-buggering-up macro. 2008-05-21 12:06:05 +00:00