b95234f9d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
f40c19f406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
3ae30a8446
[fenix] Import l10n.
3 years ago
3fc31d036b
[fenix] No issue: rename test resource file that was causing issues on Windows
3 years ago
03ddd32bb1
[fenix] Import l10n.
3 years ago
4d092c3a82
[fenix] Import l10n.
3 years ago
77892a785c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21816 : Filename in "Open" PDF dialog overflows screen
...
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
3 years ago
07636be02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22342 : Make layout constraint for 'recent bookmarks' the same as other sections
3 years ago
6aa2f0c4fa
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
7d11384733
[fenix] Import l10n.
3 years ago
ad076dd1c2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22299 : Add history search term group telemetry
3 years ago
31c2c7bf12
[fenix] No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
422a8e2a67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22304 & https://github.com/mozilla-mobile/fenix/issues/22256 : Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests
3 years ago
f1814afed2
[fenix] Import l10n.
3 years ago
67665ee689
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : add SearchDialogFragmentConstraintLayout; has markers.
...
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
3 years ago
7936660a8c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : change onMeasure/onLayout markers into a single track + draw.
...
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
3 years ago
a93ac9edc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : rename RootLinearLayout -> HomeActivityRoot...
...
This is so we can be more specific with the detail text in our markers.
3 years ago
3424aac1a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew product telemetry expiring in December ( https://github.com/mozilla-mobile/fenix/pull/21316 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Product telemetry renewals for December
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Data review for december product telemetry renewals
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
6ed1cb0c8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Remove expiring/unused metrics for December ( https://github.com/mozilla-mobile/fenix/pull/21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
dbceb279f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21659 : Add SERPs to history search groups
3 years ago
cbfc23f8cc
[fenix] Recent bookmark count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22293 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added event to track the count of recent bookmarks
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b1cb88fff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22078 Selecting search group in Jump back in switches active tab
3 years ago
008e453d6a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22281 Fix studies opt out learn more link
3 years ago
6d8071ccc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection
3 years ago
03cbf9f624
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/accent_dark_theme redirection
3 years ago
e0b7131f5c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/foundation_dark_theme redirection
3 years ago
113a1bc009
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection
3 years ago
621f5a58d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection
3 years ago
a1a3a13acb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection
3 years ago
42a72ab0e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection
3 years ago
788a8f16f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_media_background_dark_them redirection
3 years ago
94852bedb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_divider_dark_theme redirection
3 years ago
bd95bec9c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection
3 years ago
f0a4f3d8d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_background_dark_theme redirection
3 years ago
ab4aeaeb92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_url_dark_theme redirection
3 years ago
111cfabafa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_text_dark_theme redirection
3 years ago
8579079774
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22213 : add marker for LayoutInflater.inflate.
...
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
3 years ago
9fb7471f61
[fenix] No issue: Address tracking protection exceptions breaking changes
3 years ago
a599f10dad
[fenix] Improve deleteBookmarkInEditModeTest UI test coverage
3 years ago
6bb861b172
[fenix] Import l10n.
3 years ago
4bcd25b25e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 record auto-close prompt telemetry events
3 years ago
3ffe906bcb
[fenix] No issue: Show snackbar when opening non-http URL
3 years ago
5e2853ea47
[fenix] MR2 Telemetry: Recent tabs section probe ( https://github.com/mozilla-mobile/fenix/pull/22166 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Fixed lint errors
* For https://github.com/mozilla-mobile/fenix/issues/22107 - added data review number to metric
* For https://github.com/mozilla-mobile/fenix/pull/22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
d02a7b9b66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection
3 years ago
3aacbb54ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection
3 years ago
1c03194841
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/preference_section_header_dark_theme redirection
3 years ago
ef1e53ec9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection
3 years ago
fc7a61c934
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection
3 years ago
15f812d211
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection
3 years ago
f6a6eaa4dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_background_dark_theme redirection
3 years ago
976471faa1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection
3 years ago
bb13f9142a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection
3 years ago
6676610267
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_divider_color_dark_theme redirection
3 years ago
08070ae3f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/swipe_delete_background_dark_theme redirection
3 years ago
9c8417d62e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection
3 years ago
eed6603fd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection
3 years ago
56a250ceeb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/disabled_dark_theme redirection
3 years ago
93b4422105
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/shadow_dark_theme redirection
3 years ago
6770cea439
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_faded_dark_theme redirection
3 years ago
1037d980e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_dark_theme redirection
3 years ago
64b8bcbc34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_ring_dark_theme redirection
3 years ago
b5dec0ead6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimEnd_dark_theme redirection
3 years ago
73bb4f4526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimStart_dark_theme redirection
3 years ago
59a75bb57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/recently_used_share_menu_dark_theme redirection
3 years ago
9054bfb2fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_history_item_selected_background_light_theme redirection
3 years ago
e0c90b50e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/menu_item_button_light_theme redirection
3 years ago
39f9471c6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection
3 years ago
1aca9a4fd7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection
3 years ago
cefb9478e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection
3 years ago
8393fac307
[fenix] No issue: Merge our inactive tab interactor/controllers
3 years ago
4bd2cc7d0a
[fenix] No issue: Remove unused InactiveTabState code
3 years ago
3342f4a54a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
ba7d325bb4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22057 : Add search term groups telemetry
3 years ago
517f789958
[fenix] Introduce test rule to work around intermittent mockk failures
3 years ago
867f11e5d9
[fenix] Improve coverage for cancelCreateBookmarkFolderTest UI test
3 years ago
66862fa992
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests
3 years ago
d116c95205
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22138 - Install source metrics probe
3 years ago
33486f8434
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22226 - Open grouped history entries the same as individual ones
3 years ago
c0fde2bebb
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22172 : Add Recent searches telemetry
3 years ago
46f9f1ae2c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22103 : Add recent bookmarks telemetry
3 years ago
03ef78cfa4
[fenix] Import l10n.
3 years ago
55bf6f2839
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Add data review link
3 years ago
015be02422
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
ff1c34b9ee
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20704 : Use AppStore for inactive expanded state
3 years ago
5d8a920b5f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20704 : Add AppStore to Components
3 years ago
4807972089
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21397 : disabled homescreen features to improve collections visibility
3 years ago
d201f02bfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22192 add telemetry for studies
3 years ago
2f4da44511
[fenix] Import l10n.
3 years ago
f9118a465b
[fenix] Import l10n.
3 years ago
2fb5b29076
[fenix] Import l10n.
3 years ago
2a00f903e9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Reduce redirection of colors variables between dark and light theme - Part 3 ( https://github.com/mozilla-mobile/fenix/pull/22220 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/disabled_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimStart_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimEnd_light_theme reddirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/synced_tabs_separator_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_divider_color_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/fill_link_from_clipboard_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_background_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/swipe_delete_background_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_selected_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection
* For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
31c15daace
[fenix] Import l10n.
3 years ago
b49aeeddb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15624 & https://github.com/mozilla-mobile/fenix/issues/17484 : improves tab drawer locator & avoids homescreen refreshing
3 years ago
5a29e58535
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/destructive_light_theme redirection
3 years ago
908d86868f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/shadow_light_theme redirection
3 years ago
ed92aac728
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_faded_light_theme redirection
3 years ago
ceda1cfcd5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_light_theme redirection
3 years ago
f1f972568e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_ring_light_theme redirection
3 years ago
027bed0424
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/accent_high_contrast_light_theme redirection
3 years ago
818417b078
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/about_link_dark_theme redirection
3 years ago
eab820e930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/above_light_theme redirection
3 years ago
5df9de00d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/caption_text_light_theme redirection
3 years ago
5ceb4bfa12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/secondary_text_light_theme redirection
3 years ago
0732718e1c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21355 : Fix intermittent test failures in BookmarkItemMenuTest
3 years ago
bf2a718701
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarKtTest
3 years ago
d03598c9a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21438 : Ignore intermittently failing ExceptionsListItemViewHolderTest
3 years ago
3b686cec7b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22081 : Ignore intermittently failing DefaultBrowsingModeManagerTest
3 years ago
243a456c1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21332 : Ignore intermittently failing WebPushEngineIntegrationTest
3 years ago
dc552d78c6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarDelegateTest
3 years ago
41ddc9226c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21888 - Use Hero images for Jump back in
3 years ago
a529140c8d
[fenix] No issue update strings ids
3 years ago
e62c814006
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests
3 years ago
43d6e2234d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_light_theme redirection
3 years ago
8aa133339d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/inset_dark_theme redirection
3 years ago
7a0b6301d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/top_site_title_text_dark_theme redirection
3 years ago
10c1bbd3e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/synced_tabs_separator_dark_theme redirection
3 years ago
7b26640382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection
3 years ago
d5d302da69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the collection color variables
3 years ago
6b38dd5259
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove redirection of color variables for the tabs tray color variables
3 years ago
7a494b556a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/caption_text_dark_theme redirection
3 years ago
57e117e9b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/contrast_text_dark_theme redirection
3 years ago
cbe4de50ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/secondary_text_dark_theme redirection
3 years ago
5408bc5178
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Use destructive_normal_theme in place of R.color.design_color
3 years ago
a08a575365
[fenix] Import l10n.
3 years ago
da44c15a49
[fenix] For https://github.com/mozilla-mobile/android-components/issues/11161 : pass profiler into AwesomeBar.
...
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update
This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
ba3f51814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests
3 years ago
ecb13fa173
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 : Add telemetry for the auto-close prompt
3 years ago
abb1c2631e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Update strings removal version
3 years ago
22bfc8897a
[fenix] Import l10n.
3 years ago
ef375069eb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
1de688e7d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew metrics for December - never expire updates ( https://github.com/mozilla-mobile/fenix/pull/21788 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew metrics for December - never expire updates
* For https://github.com/mozilla-mobile/fenix/issues/21313 : data review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
07742ec701
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22034 : Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
a68de609c2
[fenix] Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
b8bf426e4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Call chain on collection type may be simplified
3 years ago
d46da02cde
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Add package path to TabGroupViewHolder
3 years ago
45e9bf6693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols
3 years ago
759194a625
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Class member can have 'private' visibility
3 years ago
230536c9b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace Java static method with Kotlin analog
3 years ago
999f0ab3c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Replace 'isEmpty' with 'ifEmpty'
3 years ago
853e159476
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
71bfe46ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
6be34a4023
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused imports
3 years ago
29dfb8ee7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary type argument
3 years ago
314d61d21e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
cd77dbce96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove redundant qualifier name
3 years ago
5fbd63386d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant SAM constructor
3 years ago
4bcb6d7796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry
3 years ago
2defb17c08
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove val from constructor parameter that are never used as a property
3 years ago
4b726e786b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21732 - Adds inactive tabs survey on disable + telemetry
3 years ago
6a5a2b842c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21933 - Refresh history items everytime the fragment is opened
3 years ago
217570edff
[fenix] Import l10n.
3 years ago
a6d7128c7e
[fenix] No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
a672d27ca6
[fenix] No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
7d5bac64d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21025 : Set long term business-critical metrics as non-expiring ( https://github.com/mozilla-mobile/fenix/pull/21038 )
...
* Set long term business-critical metrics as non-expiring.
* Remove quotes around "never"
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
8daaca51af
[fenix] Use identifiers instead of hard coded strings
3 years ago
eaed414831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21747 re-enable start on homepage UI test and refactoring work
3 years ago
20541aab38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21754 re-enable general settings UI test and refactoring work
3 years ago
7a4658627e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
0c5e1f3442
[fenix] No issue: Add external load flag
3 years ago
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
775929a293
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21628 : catch ComposeNotIdleException
3 years ago
8a2df4be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
...
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
af4a03a0f3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714 : Login button visibility fix on saved logins page
3 years ago
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
b566e3ed7f
[fenix] Import l10n.
3 years ago
e7695f25ef
[fenix] Import l10n.
3 years ago
3516c38f1f
[fenix] Import l10n.
3 years ago
2a52bffeae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
1336a4f72d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
9a784f8484
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
91e7121fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
2f7d5c03f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
888e9365cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
d09f8d1a00
[fenix] Import l10n.
3 years ago
53db79d50e
[fenix] No issue: Only report telemetry when tabs tray is first opened
3 years ago
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
8fc6c5952f
[fenix] No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
9688a90c29
[fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
e17721e795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
99988cd74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
c4bce2422e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test
3 years ago
231ee9a9c3
[fenix] Import l10n.
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
f3f8f717f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors
3 years ago
6f80d2871f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
e8cd66b619
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED
3 years ago
e7f6b6fc14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55
3 years ago
0abac59277
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA
3 years ago
f928428f5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
c3d86f8dc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF
3 years ago
1a01f638c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18
3 years ago
4783442368
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75
3 years ago
98dd4016ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
521b564fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF
3 years ago
a77c5b8fad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787
3 years ago
18a9ffed66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64
3 years ago
013530110e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff
3 years ago
2e762f0327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27
3 years ago
9a901e0cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E
3 years ago
453c6f9f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2
3 years ago
e5a197c402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587
3 years ago
bfce9bc796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A
3 years ago
a8cdbb4524
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF
3 years ago
a63441e402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB
3 years ago
c07d13ba2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042
3 years ago
648f3261c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1
3 years ago
d50ff294a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5
3 years ago
ebcc1024ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF
3 years ago
98c315c7e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000
3 years ago
d51e2df39a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
d7521f168e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list
3 years ago
0a5ba09d26
[fenix] Import l10n.
3 years ago
aabd1999ee
[fenix] CI for 21827 ( https://github.com/mozilla-mobile/fenix/pull/22004 )
...
* Remove redundant calls to setHasOptionsMenu(false)
Fix memory leaks for credit card and login fragments
* Fixes:
Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt
* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
906b7a168c
[fenix] Import l10n.
3 years ago
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
c1c42385c4
[fenix] Improve tabsSettingsMenuItemsTest UI test coverage
3 years ago
bee0854156
[fenix] Import l10n.
3 years ago
70919737fd
[fenix] Import l10n.
3 years ago
952ba35095
[fenix] Import l10n.
3 years ago
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
299406fc89
[fenix] Import l10n.
3 years ago
09d1c997d8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944 : Top sites rendered slowly on first load of HomeFragment
3 years ago
b7a03ea6d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : linting fixes
...
For https://github.com/mozilla-mobile/fenix/issues/21700 : nit fixes
3 years ago
c261feb602
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Added option to open in browser instead of automatically doing it
3 years ago
c558e11cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : fixed comments
3 years ago
60fa679e9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Created benchmark script runner and edited benchmark gradle file
3 years ago
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
5372f1bcca
[fenix] Make linters happy
3 years ago
84773fa9a2
[fenix] Register the logins key provider
...
This is required for sync to work
3 years ago
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
0672471708
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section
3 years ago
c8d89a3bba
[fenix] Fix for ambiguous tabstray_title and with text matcher for audio page
3 years ago
45bdd68df1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test
3 years ago
f5fa9d4217
[fenix] No issue: Always show Make inactive for debug builds
3 years ago
fa4b9996c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20
3 years ago
1e84ef3843
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Add shadow to recent bookmarks section
3 years ago
ac7e445eb0
[fenix] Import l10n.
3 years ago
ed3560d1b9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917 : Update pocket stories card elevation to match other cards
3 years ago
18a8788812
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707 : Correct search grouping logic in extensions
...
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.
The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.
Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
cb7cc7a7eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources
3 years ago
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
4fee8036a0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Remove rotation; rely on state activated
...
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
7638040a3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest
3 years ago
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
1bb5f1479d
[fenix] Disable editCustomSearchEngineTest UI test
3 years ago
d6ae910c74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK.
3 years ago
6a7c42a398
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test
3 years ago
f0091a768c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test
3 years ago
ec442f575f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings
3 years ago
7f9dab5654
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest
3 years ago
3ea7755592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005 : fixed ETP status info display
3 years ago
897aa4b662
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21522 : Wrap section titles on home
3 years ago
86029b181c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew fission metrics expiring in December
3 years ago
c7232a0bdb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Stop using internally stored tabs list in adapters
3 years ago
f10d226f92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
...
To get smaller shadows.
3 years ago
cde1c3b911
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates.
3 years ago
e22e33c3c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake.
3 years ago
b916fc4a85
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437 : Fix default of start_on_home setting in UI
3 years ago
ff62ffe70a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section
3 years ago
d13f0ef797
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Reverse chevron for inactive tabs
3 years ago
16ed26781d
[fenix] Update Android Components version to 95.0.20211008105820.
3 years ago
aa6387809d
[fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests
3 years ago
153bfcce38
[fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests
3 years ago
3317d98b34
[fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description
3 years ago
7dd7b2e5b2
[fenix] Fix for ambiguous tabstray_title and with text
3 years ago
d6755b5580
[fenix] Fix for ambiguous tabstray_close
3 years ago
75606a8786
[fenix] Fix for ambiguous tab_item
3 years ago
822775eb9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash
3 years ago
363e563fc7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Move submitList calls into TabsAdapter
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
d73ea2cf98
[fenix] Enable pocket stories in CA
3 years ago
185121606c
[fenix] Prepare nimbus features default values for release 95
3 years ago
2fc70778a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20579 : Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode
3 years ago
a4fcc93d0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience
3 years ago
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
257ae4b118
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424 : add marker for StrictMode.resetAfter.
...
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
e3b2309ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol
3 years ago
b772f6d080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen ( https://github.com/mozilla-mobile/fenix/pull/21722 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text
* PR: Fixed lint warning. Reverted preference keys
* PR: added ignore for UI test
* PR: Added ignore for UI test
3 years ago
259b2e5d30
[fenix] No issue: Update Pocket categories spacing to 16dp.
3 years ago
a4e21f4fbb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102 : Set compileSdkVersion to 31.
3 years ago
c9d8e826ca
[fenix] No issue: Small layout update for Pocket Stories
3 years ago
398bdac5aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size
3 years ago
e487bc6f59
[fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often
3 years ago
3e01e9df25
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Show the jump back in Contextual Hints independently of the home onboarding dialog.
3 years ago
f4f7c1b0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : disabled the homescreen onboarding dialog.
3 years ago
2594eac89e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Update design for jump back in section and recently bookmarked section
3 years ago
bdc54a1465
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21708 - Fixes missing header bottom border
...
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
622e713c07
[fenix] Update feature flags for 94.
3 years ago
09c8890055
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20814 fix flaky tabMediaControlButtonTest UI test
3 years ago
5baa97270c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21599 - Add UTM parameters for Pocket recommendations links
3 years ago
f372c5c69f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21565 - Adds inactive tabs onboarding popup
3 years ago
e606d8c42a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to home composables.
...
Added from the ViewHolders, the same as for XML Views.
3 years ago
dc66fea1e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all normal browsing home items
3 years ago
07d08eb655
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to the private browsing home description
3 years ago
8f6a6d0980
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Add 16dp horizontal spacing to all onboarding items
3 years ago
11b92bbd99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21621 - Remove the parent horizontal padding
3 years ago
2e597529c8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21582 : Use ThumbnailStorage in recent tabs on home
3 years ago
fde5b755e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited
3 years ago
8a78101fc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21694 - Only show the divider line in between items in the Recent Searches
3 years ago
33cf85203a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642 : Remove in-progress media tab from homescreen
3 years ago
5385b96abe
[fenix] Move tabs out of search group if direct load occurs
...
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.
However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
3db298543e
[fenix] CI for Fix description for home_screen_displayed metric ( https://github.com/mozilla-mobile/fenix/pull/21697 )
...
* Fix description for `home_screen_displayed` metric
The current description appears to be incorrect by my reading of the source.
* Update app/metrics.yaml
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
3631014159
[fenix] CI for Docs: Add extra context to events.browser_menu_action ( https://github.com/mozilla-mobile/fenix/pull/21696 )
...
* Docs only: Add extra context to `events.browser_menu_action`
This came up as a potential point of confusion in a discussion with DS. This is a docs only change.
* Update metrics.yaml
Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
efab5cbb1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21658 - Don't pass Client into composable functions
3 years ago
3d69371557
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21671 : Remove Recently Closed from Inactive Tabs
3 years ago
7e65b07930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
...
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
6261e570c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
...
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
4f4586d85f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
...
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
7b031b0504
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21644 fix disabled alwaysStartOnHomeTest UI test
3 years ago
884c8c2224
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576 : Hide 'Other' title when there are no search groups
3 years ago
20f07022d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21626 - Avoid showing story invalid properties
3 years ago
8a4bb26526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618 : Integrate Nimbus with MR2 Home Page to enable experimentation
3 years ago
21480b89ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in Contextual Hints
3 years ago
51000bcfa4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21632 : Correct inactive tabs survey string ( https://github.com/mozilla-mobile/fenix/pull/21669 )
3 years ago
c1f2c33a76
[fenix] Make search term grouping tolerant to (parent tab) navigation
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
d70d0610d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21648 : match Pocket sections on home to designs
3 years ago
0c5285cf05
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21641 : Do not add a group of only one tab
3 years ago
ad1cff2300
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21653 : pre-land section title for tab preferences
3 years ago
4f07d1a40f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups ( https://github.com/mozilla-mobile/fenix/pull/21615 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup
* PR: Added missing licenses and possibly fixed UI test
* PR: Added a "scrollTo" to potentially fix a UI test
* PR: Added potential fix for alwaysStartOnHomeTest
* PR: Added temporary ignore to alwaysStartOnHomeTest
* PR: added missing ignore comment
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
f12124b948
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21646 : Update section titles and customize button name on home
3 years ago
b9f5e56c37
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21643 : Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. ( https://github.com/mozilla-mobile/fenix/pull/21645 )
3 years ago
44f1f679e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21635 - Preland strings for tab auto close message ( https://github.com/mozilla-mobile/fenix/pull/21636 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21635 - Prelanded strings for tab auto close message
* PR: Updated String descriptions and added temporary tools ignore
3 years ago
33381f78f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21632 - Preland strings for the inactive tab survey
3 years ago
bd610d394f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16437 : Remove unnecessary space for tracking protection exceptions
3 years ago
4e5047d203
[fenix] For https://github.com/mozilla-mobile/fenix/pull/21392 - Update new strings descriptions.
3 years ago
1d537cb332
[fenix] Allow opening pocket stories when search dialog is active
3 years ago
1f628f8e52
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 , https://github.com/mozilla-mobile/fenix/issues/21620 : disables failing UI tests
3 years ago
4967527781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21441 , https://github.com/mozilla-mobile/fenix/issues/21477 , https://github.com/mozilla-mobile/fenix/issues/21500 , https://github.com/mozilla-mobile/fenix/issues/21499 https://github.com/mozilla-mobile/fenix/issues/21476 , https://github.com/mozilla-mobile/fenix/issues/21474 : retry dismissing the search bar
3 years ago
1da6397453
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21610 : Update Strings for Tab Settings
3 years ago
2311ac81df
[fenix] Import l10n.
3 years ago
5e57ece039
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21611 : Add jump back in contextual hint text
3 years ago
1f11b81bc4
[fenix] No issue: Make sure jump back in group always have more than one tab
3 years ago
4d23db624f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
dc1e5e640e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21287 : long press menu on recently visited homescreen groups
3 years ago
e1a2b9ccfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21608 : Update strings for home screen dialog features
3 years ago
485ca898f2
[fenix] Do not show home screen behind search if we have search terms
...
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
0a08c61e8d
[fenix] Don't manually exclude glean-native
...
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
3 years ago
f2b7eea088
[fenix] Inactive tabs changes ( https://github.com/mozilla-mobile/fenix/pull/21524 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code
Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup
* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings
* PR: Fixed lint warnings
* PR: Removed redundant feature check
* PR - Ignore test until search term tab groups switch is done
3 years ago
4fac910adf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories
3 years ago
92bc5e93b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21562 - Snap to next item when scrolling
...
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
3 years ago
Mugurell
Mozilla L10n Automation Bot
Grisha Kruglov
mike a
Sebastian Kaspari
Roger Yang
Oana Horvath
Michael Comella
Elise Richards
Christian Sadilek
Noah Bond
Arturo Mejia
Matt Boris
Gabriel Luong
AndiAJ
Jonathan Almeida
Jonathan Almeida
MickeyMoz
codrut.topliceanu
Michael Droettboom
Mayank Agarwal
Andrei Joltan
xlog-null
Marc Leclair
Ben Dean-Kawamura
sunil9211
Noah Bond
Rohan Maity
Biren-Nayak
Jan-Erik Rediger