Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
3,570 Commits 67 Branches 115 Tags 1.2 GiB
a3be78d7e8
Commit Graph

3071 Commits

Author SHA1 Message Date
Sawyer Blatz
4737e97eb4 [fenix] No issue: Fixes strings for data migration 2020-01-30 11:29:50 +01:00
Mihai Adrian
78f7132075 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6980: Add What's new card (https://github.com/mozilla-mobile/fenix/pull/7952) 2020-01-29 08:50:11 -08:00
Jonathan Almeida
4d2977589d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7788: Route search widget intents through IntentReceiverActivity 2020-01-29 14:27:14 +01:00
Mihai Branescu
a5642fdd16 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7679 - Replaced comparison by reference with value, added check for default in order to avoid double checkmark (example: default + English) (https://github.com/mozilla-mobile/fenix/pull/7729) 2020-01-28 19:22:04 +02:00
mcarare
b0ed29d03d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5905: Pre-land strings for Settings screen changes 2020-01-28 01:49:29 -08:00
Sören Hentzschel
f55a5190e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7730 - always show "Add private browsing shortcut" in sett… (https://github.com/mozilla-mobile/fenix/pull/7943) 2020-01-27 08:44:28 -08:00
ValentinTimisica
5c2478c102 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/7881: Send telemetry event when custom search engine is deleted 2020-01-27 12:04:28 +02:00
Sebastian Kaspari
8dcea31840 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7762: Initialize Glean later in Fennec builds. 2020-01-26 11:53:26 +01:00
Jonathan Almeida
ff6ccd2a8d [fenix] For https://github.com/mozilla-mobile/fenix/issues/7524: Remove DeviceConstellation polling from onResume (https://github.com/mozilla-mobile/fenix/pull/7908) 2020-01-25 11:04:24 -08:00
Mihai Adrian
9649cd5049 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7272: Show info when saved logins list is empty. (https://github.com/mozilla-mobile/fenix/pull/7891) 
* For https://github.com/mozilla-mobile/fenix/issues/7272: Show info when saved logins list is empty

* For https://github.com/mozilla-mobile/fenix/issues/7272: Updated unit tests
 2020-01-24 18:13:44 -08:00
Sebastian Kaspari
9b6dd72f68 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7818: Use different target activities for launcher activity alias (fenix vs. fennec). (https://github.com/mozilla-mobile/fenix/pull/7917) 
* With this patch fenix build variants will launch HomeActivity directly from the launcher.
  This will get rid of the performance regression outlined in https://github.com/mozilla-mobile/fenix/issues/7818.

* Fennec build variants will launch into MigrationDecisionActivity which will show the
  migration UI or launch normally into the app. This is faster than going through
  IntentReceiverActivity (measured and perceived).
 2020-01-24 18:03:25 -08:00
Sebastian Kaspari
f7fd71bbd9 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7890: Make migration screen scrollable. (https://github.com/mozilla-mobile/fenix/pull/7914) 2020-01-24 18:03:02 -08:00
Suraj Shah
1aee93ca48 [fenix] Connectivity manager tests (https://github.com/mozilla-mobile/fenix/pull/7317) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/7316
Adds tests for ConnectivityManager.isOnline

* Fixes detekt errors.

* Cleaning tests

* Cleaning tests to use boolean checks instead of object equals
 2020-01-24 17:43:28 -08:00
Michael Comella
b92d567d49 [fenix] No issue: don't export OssLicense*Activity. (https://github.com/mozilla-mobile/fenix/pull/7909) 
afaik, these Activities are only intended to be shown internally and
have no reason to be accessible to other apps on the system.
 2020-01-24 17:41:23 -08:00
Jonathan Almeida
5fd6c7fd28 [fenix] No issue: Update Firefox Logo in Migration UI (https://github.com/mozilla-mobile/fenix/pull/7916) 2020-01-24 17:33:15 -08:00
Emma Malysz
ccf371965e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7473, delay inflation of toolbar 
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
 2020-01-24 15:21:42 -08:00
Gabriel Luong
1742d10b7e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7525 - Add telemetry for opening a top site in normal and private mode and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
5ac336f840 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 7: Add menu for opening a top site in private tab and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
31281691e5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 6: Add top site view 2020-01-24 15:18:25 -08:00
Gabriel Luong
7b4c67bcc1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 5: Add top sites to the HomeFragmentStore 2020-01-24 15:18:25 -08:00
Gabriel Luong
74bee87394 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 4: Implement "Add to Firefox Home" browser menu item 
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
 2020-01-24 15:18:25 -08:00
Gabriel Luong
707118cf28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 3: Add TopSiteStorage wrapper around AC's TopSiteStorage 
This follows the existing pattern around TabCollectionStorage.
 2020-01-24 15:18:25 -08:00
Gabriel Luong
bcc77834dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 2: Add AC dependencies for top sites feature 2020-01-24 15:18:25 -08:00
Gabriel Luong
bbec1a4c90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 1: Add new strings for top sites feature 2020-01-24 15:18:25 -08:00
Aaron Train
1609077a12 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7920 - Disable ETP UI test for investigation into failure in https://github.com/mozilla-mobile/fenix/issues/7907 2020-01-24 12:51:25 -08:00
Sebastian Kaspari
483157f77b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7762: Enable glean based on setting for non-fennec builds. 2020-01-23 16:32:15 +01:00
Severin Rudie
fbfe5ea04e [fenix] No issue: clarify naming for showing a prompt to allow search suggestions (https://github.com/mozilla-mobile/fenix/pull/7870) 2020-01-22 19:08:07 -08:00
Emily Kager
cdfa305f73 [fenix] No issue: Enable about:config in beta builds 2020-01-22 16:34:51 -08:00
David Walsh
5141a25ab8 [fenix] Fix 4021 - Provide tab title during share 2020-01-22 14:42:27 -08:00
ekager
6377a946f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Add telemetry for save logins setting 2020-01-22 14:19:12 -08:00
Emily Kager
421f034e3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6812 - Navigate via openToBrowser to selected session from search 2020-01-22 14:13:16 -08:00
Sawyer Blatz
5a3a810d5e [fenix] No issue: Fixes ErrorResponse instantiation 2020-01-22 11:47:51 -08:00
Arturo Mejia
314310faea [fenix] No Issue: Add support for deleting individual tracking protection 
exceptions on nightly.
 2020-01-22 11:47:51 -08:00
Chenxia Liu
b7a62205ec [fenix] Fix breaking changes from new TrackingProtectionException 2020-01-22 11:47:51 -08:00
Michael Comella
ddd9463c20 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7423: remove redundant bottom_bar ConstraintLayout. 2020-01-22 11:20:47 -08:00
Michael Comella
e9286553e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7423: remove unnecessary CoordinatorLayout in fragment_home. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-22 11:20:47 -08:00
Michael Comella
100f06ade7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7423: remove unnecessary wordmark_spacer view. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-22 11:20:47 -08:00
Sawyer Blatz
17e74ecd6b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation (https://github.com/mozilla-mobile/fenix/pull/7840) 
* For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation

* Refactor for searchController
 2020-01-22 11:15:30 -08:00
Josh Vocal
0d27cc34cf [fenix] For https://github.com/mozilla-mobile/fenix/issues/4212: Control text not translated 2020-01-22 10:27:46 -08:00
Emily Kager
fee7cc764a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7814 - Updates dark shield icons (https://github.com/mozilla-mobile/fenix/pull/7838) 2020-01-22 07:42:08 -08:00
Michael Comella
6d20154f4c [fenix] No issue: fix typo in Performance.instrumentColdStartup... (https://github.com/mozilla-mobile/fenix/pull/7848) 2020-01-22 02:36:16 -05:00
mozilla-l10n-automation-bot
7d5f8192ef [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/7843) 2020-01-21 21:38:51 -08:00
Kaaira Gupta
eddabed040 [fenix] for https://github.com/mozilla-mobile/fenix/issues/7421 :removed collection from clear browsing history 2020-01-21 19:00:59 -08:00
Michael Comella
3889f4665f [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/50: instrument imperfect reportFullyDrawn. 
We don't capture the second RV draw yet. Unfortunately, I don't know if
it's the best use of my time to capture that as well.
 2020-01-21 18:34:38 -08:00
Chenxia Liu
ede833526d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6980 - Pre-land string changes to onboarding cards. 2020-01-21 16:28:36 -08:00
Mihai Carare
6cf9aeb006 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7029: Navigate to Search Fragment when pressing Start browsing 2020-01-21 16:26:43 -08:00
Kaaira Gupta
8547ba1a74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3813 - Create a save button for bookmark editing 2020-01-21 16:03:33 -08:00
Mozilla L10n Automation Bot
6c85b36387 [fenix] Import l10n. 2020-01-21 14:33:05 -08:00
Severin Rudie
4eb62cfc13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7506: show highlight on home 3-dot button (https://github.com/mozilla-mobile/fenix/pull/7665) 2020-01-21 13:02:14 -08:00
mcarare
11daba9778 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7714: Align engine name to viewStart to support RTL layouts 2020-01-21 12:27:19 -08:00
Mihai Adrian
cb0e5dbcff [fenix] For https://github.com/mozilla-mobile/fenix/issues/7574: Send toolbar position metrics in English. (https://github.com/mozilla-mobile/fenix/pull/7712) 2020-01-21 08:24:18 -08:00
Sebastian Kaspari
45a7a85304 [fenix] MigratingFenixApplication: Pass MigrationStore to FennecMigrator. 2020-01-21 14:38:08 +02:00
mozilla-l10n-automation-bot
7d4366c8c4 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/7744) 2020-01-20 11:07:18 -08:00
Jonathan Almeida
3cfe167fd9 [fenix] No issue: Update Migration UI with new API 2020-01-20 18:08:38 +01:00
Sebastian Kaspari
21cef2279c [fenix] Fennec home screen bookmarks: Select new tab. 2020-01-20 15:17:58 +01:00
Sebastian Kaspari
5a38c8885b [fenix] AboutFragment: Use SupportUtils.getWhatsNewUrl(). 2020-01-20 14:15:58 +01:00
Michael Comella
533d10e3b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7423: remove unnecessary CoordinatorLayout in fragment_home. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-17 16:59:03 -08:00
Michael Comella
901ddb03e9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7423: remove unnecessary wordmark_spacer view. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-17 16:59:03 -08:00
ekager
95f54f2715 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 For https://github.com/mozilla-mobile/fenix/issues/6553 - Update sync engine checkboxes and send telemetry once 2020-01-17 16:39:24 -08:00
Kate Glazko
14f7c9fec5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4904: Pressing back external link doesn't go back 2020-01-17 16:08:58 -08:00
Sawyer Blatz
1b6e2b2f2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6308: Remove unecessary telemetry & bump expiry date (https://github.com/mozilla-mobile/fenix/pull/7793) 
* For https://github.com/mozilla-mobile/fenix/issues/6308: Remove unecessary telemetry

* For https://github.com/mozilla-mobile/fenix/issues/6308: Bump expiry date on telemetry
 2020-01-17 15:13:20 -08:00
liuche
7fab2342e4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7093 - Pre-land strings for new onboarding cards. (https://github.com/mozilla-mobile/fenix/pull/7747) 2020-01-16 18:20:41 -08:00
Jeff Boek
5a4c6134c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Puts language picker behind a feature flag 2020-01-16 15:45:05 -08:00
ekager
7fd5a5295d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5080 - Move site permissions strings for l10n 2020-01-16 14:41:48 -08:00
Jeff Boek
1f2be69241 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1607 - Fixes SearchShortcutSelected to not leak any custom identifiers 2020-01-16 14:07:38 -08:00
Jonathan Almeida
1e6d68ce32 [fenix] For #ac-5601: Lock migration UI screen orientation 2020-01-16 13:46:01 -05:00
Jonathan Almeida
56d034fca2 [fenix] For #ac-5597: Fix unneeded dark theming in migration UI 2020-01-16 13:46:01 -05:00
Sebastian Kaspari
22b58de10a [fenix] Android manifest: Export shortcut target activity. 2020-01-16 19:29:15 +01:00
ValentinTimisica
d4fa64f541 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7751: Remove 'SearchWithCustomEngine' telemetry event 2020-01-16 10:14:07 -08:00
Sebastian Kaspari
f832b4d1d8 [fenix] Update list of tabs after onboarding screen was dismissed. 2020-01-16 18:47:33 +01:00
Mihai Adrian
02fed41fec [fenix] For https://github.com/mozilla-mobile/fenix/issues/7417 Wait for deletion to finish and loading of new UI (https://github.com/mozilla-mobile/fenix/pull/7572) 2020-01-16 11:03:59 -05:00
ValentinTimisica
a5e27570cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/6556: Adds Telemetry counts for Search Access Points 
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
 2020-01-16 10:23:48 +02:00
Grisha Kruglov
199e1d3986 [fenix] Enable firebase auto-init, force push renewal after migration 2020-01-16 01:11:21 -05:00
Jonathan Almeida
7c05e76de9 [fenix] Disable failing intent handling unit tests 2020-01-15 21:41:01 -08:00
Jonathan Almeida
abcaa070b8 [fenix] Add migration for telemetry identifiers to builder 2020-01-15 21:41:01 -08:00
Jonathan Almeida
59ae4e475c [fenix] Fix general Fenix build 2020-01-15 21:41:01 -08:00
Jonathan Almeida
b540467632 [fenix] Review comments, fix build failure and targetActivity 2020-01-15 21:41:01 -08:00
Jonathan Almeida
5c1dc2bbdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/7092: Add initial Migration UI 2020-01-15 21:41:01 -08:00
Sebastian Kaspari
6bb65151cf [fenix] Always initialize glean. Set upload flag after migration. (https://github.com/mozilla-mobile/fenix/pull/7717) 2020-01-15 15:31:51 -08:00
ekager
e7ed901f20 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5545 For https://github.com/mozilla-mobile/fenix/issues/5542 Closes https://github.com/mozilla-mobile/fenix/issues/6696 Integrate logins API, adds Settings for Autofilling/Saving Logins 2020-01-15 12:14:08 -08:00
Alessio Placitelli
59566d5a98 [fenix] Fix GleanMetricsService to use the new Glean APIs 2020-01-15 16:38:48 +02:00
Jonathan Almeida
ef061e1068 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7645: Disable push service when migrating 2020-01-15 02:10:56 -05:00
Mozilla L10n Automation Bot
03bc3d136b [fenix] Import l10n. 2020-01-14 18:53:13 -08:00
salvatorep
a6d13e22f1 [fenix] Added support for Intent.ACTION_SEARCH and Intent.ACTION_WEB_SEARCH actions 2020-01-14 16:50:45 -08:00
Christian Sadilek
364df1e2d5 [fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4893: Enable addon migration 2020-01-14 17:43:21 -05:00
Sebastian Kaspari
20c8281303 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7203: Move static_strings.xml to right directory. 2020-01-14 16:56:00 -05:00
Sebastian Kaspari
73a42a7d3f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7203: Add fennec icons for fennecNightly build type. 2020-01-14 16:56:00 -05:00
Aaron Train
6923449f74 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7693: Temp disable UI test verifyContextMixedVariations (https://github.com/mozilla-mobile/fenix/pull/7694) 2020-01-14 14:55:05 -05:00
Aaron Train
1d3f48b1ac [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7687: Temp disable UI test verifyContextCopyImageLocation and verifyContextSaveImage and verifyContextOpenImageNewTab 2020-01-14 14:07:53 -05:00
Marcin Wiącek
4c323704ff [fenix] Doesn't allow for hint in URL bar on main page in two lines 2020-01-14 09:36:39 -08:00
daphliu
0d5158eb22 [fenix] Modified onboarding card colors according to design 2020-01-14 09:18:45 -08:00
isabelrios
44b0dc4798 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7563 - Sync integration logins (https://github.com/mozilla-mobile/fenix/pull/7564) 
* sync-integration-logins-test

* improve checks for logins test

* fixing ktlint issues

* uncomment lines

* address reviewer comments

* fix ui tests after robot change

* fix lint
 2020-01-14 08:47:37 -08:00
Grisha Kruglov
038c99c4bd [fenix] Migrate 'settings' before app init 2020-01-14 17:27:41 +01:00
Kadeem M
81997a01bf [fenix] Added BuildDate Assertion for About Preview Screen; Added verification for external links in About Preview Screen (https://github.com/mozilla-mobile/fenix/pull/7413) 2020-01-13 13:53:35 -08:00
ValentinTimisica
f5c8ae7ba1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5884: Fixed Unit tests. 2020-01-13 12:31:23 -08:00
ValentinTimisica
8560ea17c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5884: Adds user-specified search engines telemetry 
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
 2020-01-13 12:31:23 -08:00
Colin Lee
7faa412772 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/7649: Fix missing NOT in asFeatureWebChannelsDisabled check (https://github.com/mozilla-mobile/fenix/pull/7650) 2020-01-13 13:37:13 -06:00
Colin Lee
f5a7312763 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5182: Loading experiments on startup is slow, remove Fretboard (https://github.com/mozilla-mobile/fenix/pull/7510) 
This removes Fretboard. The goal is to reduce cold startup costs associated with loading the experiments on the main thread. We currently have two experiments frameworks in use and should only require one.
 2020-01-13 12:38:32 -06:00
Aaron Train
397dddaf0a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7611: Add UI tests for content context menus (https://github.com/mozilla-mobile/fenix/pull/7631) 
Closes https://github.com/mozilla-mobile/fenix/issues/7611: Add UI tests for content context menus
 2020-01-13 12:24:23 -05:00
Sebastian Kaspari
e36fd53543 [fenix] Open "migration FAQ" when selecting "What's new" in a Fennec build. 2020-01-13 17:08:48 +01:00
Mozilla L10n Automation Bot
cebfd743ba [fenix] Import l10n. 2020-01-13 12:14:20 +02:00
Tiger Oakes
2cf4af1c39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7431: Remove extra share button 2020-01-11 11:48:51 -08:00
ekager
a97bd82a3f [fenix] Remove unused labels from nav_graph 2020-01-10 16:45:21 -08:00
mcarare
8b6c78847f [fenix] For https://github.com/mozilla-mobile/fenix/issues/7593 Set AboutFragment title just in onCreate 2020-01-10 16:45:21 -08:00
mcarare
0180880b3e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7583 Align text in language title and subtitle to viewStart 2020-01-10 15:36:31 -08:00
Sebastian Kaspari
2af018af37 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7203: Use app name 'Firefox Nightly' for fennecNightly build. 2020-01-10 13:59:31 -08:00
ekager
29da7724cc [fenix] Move experiments initialization and fix ktlint errors 2020-01-10 13:57:12 -08:00
Kris Taeleman
70c8589744 [fenix] Bug 1605454 - Fixing typo 2020-01-10 13:57:12 -08:00
Kris Taeleman
b83c08032b [fenix] Bug 1605454 - Kotlin linting improvement 2020-01-10 13:57:12 -08:00
Kris Taeleman
a80f985761 [fenix] Bug 1605454 - Change experiment name and take branch into account 2020-01-10 13:57:12 -08:00
Kris Taeleman
e84bd29218 [fenix] Bug 1605454 - Adding experiment code for disabling webrender. 2020-01-10 13:57:12 -08:00
Sebastian Kaspari
630f7ba824 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7587: Add shortcuts.xml for fennecNightly variant. 2020-01-10 13:50:47 -08:00
Sebastian Kaspari
9f5568a60a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6898: Allow empty adjust token for fennecNightly builds. 2020-01-10 13:48:20 -08:00
ekager
769492ada1 [fenix] No issue: Fix dynamic theming to accommodate lazily inflated readerview 2020-01-10 13:23:46 -08:00
mcarare
3af16e3185 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7522 Catch IllegalArgumentException when validating search string 2020-01-10 11:26:11 -08:00
Sawyer Blatz
72604bb955 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6304 & https://github.com/mozilla-mobile/fenix/issues/7577: Persist private mode between app launches 2020-01-09 17:03:36 -08:00
Mihai Adrian
b035f6c04e [fenix] For https://github.com/mozilla-mobile/fenix/issues/6992 Always hide toolbar when showing find in page bar (https://github.com/mozilla-mobile/fenix/pull/7567) 2020-01-09 13:26:33 -08:00
Mihai Adrian
354ea9b6ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/7343: Handle sharing to multiple devices (https://github.com/mozilla-mobile/fenix/pull/7409) 
* For https://github.com/mozilla-mobile/fenix/issues/7343 Do not allow multiple share to same device

* For https://github.com/mozilla-mobile/fenix/issues/7343 Check current destination before dismissing share
 2020-01-09 10:40:14 -08:00
Sawyer Blatz
3a91c6aa33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1718: Sets accessibility users to top toolbar by default (https://github.com/mozilla-mobile/fenix/pull/7486) 2020-01-09 09:15:02 -08:00
Severin Rudie
49cb8c2620 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7556: fix intermittent failure in BookmarkNodeTest 2020-01-09 16:54:50 +02:00
Mugurell
44cef3a931 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6836 - Limit Leanplum depending on current locale. 2020-01-09 13:02:21 +02:00
Josh Vocal
e4c26f7592 [fenix] Replace fixed dp with defined dp dimension 2020-01-08 20:17:22 -08:00
Josh Vocal
c888e71c40 [fenix] Fix truncated tracking protection info text 
* Allow tracking protection titles to wrap instead of being cut off
* Refactor view ids to match the layout
 2020-01-08 20:17:22 -08:00
Sebastian Kaspari
39b1040830 [fenix] Update Mozilla Android Components to 28.0.0-SNAPSHOT. 2020-01-08 18:57:31 -05:00
Kaaira Gupta
3bc4d7564a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7414 : changed AboutHeaderContentText color to primarytext color and removed futile code of aboutText color 2020-01-08 16:46:18 -07:00
Mihai Adrian
813593987e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5722 Set adjustViewBounds to true to maintain original icon aspect (https://github.com/mozilla-mobile/fenix/pull/7518) 2020-01-08 14:03:48 -08:00
Rushab Kumar
7b07f5cbb5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7154 - Fix crash when tapping on "Blocked" in the site info panel (https://github.com/mozilla-mobile/fenix/pull/7404) 2020-01-08 13:51:45 -08:00
Mozilla L10n Automation Bot
6d5a6e4644 [fenix] Import l10n. 2020-01-08 14:43:07 -07:00
mcarare
30962ed381 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7522 Ensure correct protocol is used in search string 2020-01-08 11:13:49 -08:00
mcarare
4fcaac3933 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7313 Set actionBar background color according to mocks. 2020-01-08 12:12:30 -07:00
Severin Rudie
7dc3a94acd [fenix] For 6832: update implementation/comment to align w existing AC code 2020-01-08 12:04:14 -07:00
Severin Rudie
1b2c0bd799 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6832: fix unattached context crash in HomeFragment 2020-01-08 12:04:14 -07:00
mcarare
fd06352b8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7155 Align custom tabs overflow menu to original mocks 
Reverse menu items order when toolbar position is top
 2020-01-08 11:50:17 -07:00
mcarare
cea6d9d394 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7519 Navigate up from search fragment to handle all entry points 2020-01-08 11:49:17 -07:00
mawen7
bd95c96dc8 [fenix] Only close tab on back press if it has a parent tab 2020-01-08 11:33:49 -07:00
kglazko
99d08c5677 [fenix] Issue 5736 Improve pop behavior after deleting tabs in settings (https://github.com/mozilla-mobile/fenix/pull/7478) 2020-01-08 10:27:14 -08:00
Emily Kager
54176609f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7181 - Adjust ETP onboarding for toolbar positions 2020-01-08 11:06:38 -07:00
Josh Vocal
81a1efb92d [fenix] For https://github.com/mozilla-mobile/fenix/issues/7282 - Add more visibility to Turn On Sync card (https://github.com/mozilla-mobile/fenix/pull/7284) 
* Change background of card to make elevation more visible
* Change icon white fill to become transparent
 2020-01-08 10:26:48 -05:00
Will Hawkins
0b7436f2c0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7425 (et al): Cache the list of installed browsers 
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
 2020-01-07 18:40:07 -08:00
Mugurell
e470001a48 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4977: Migrate fennec shortcuts (https://github.com/mozilla-mobile/fenix/pull/7251) 
* For https://github.com/mozilla-mobile/fenix/issues/4977 - Support opening Fennec pinned website shortcuts in Fenix

Fennec's pinned website shortcuts are set to open the BrowserApp activity.
So we need a new activity alias to actually catch such Intents. Otherwise they
would open "org.mozilla.firefox/.App" without any way to inform that this is
the result of the user clicking on a pinned shortcut.
For actually checking if the newly received Intent is of a Fennec pinned
shortcut we introduce a new FennecBookmarkShortcutsIntentProcessor which will
prepare the Intent to open the shortcut's URL in a new tab.

* For https://github.com/mozilla-mobile/fenix/issues/4977 - Don't keep IntentReceiverActivity on the back stack

For successive Fennec pinned shortcuts to create a new IntentReceiverActivity
and be processed as normal we need to not keep this as our task root.

* For https://github.com/mozilla-mobile/fenix/issues/4977 - Test the FennecBookmarkShortcutsIntentProcessor
 2020-01-07 09:07:51 -08:00
Jeff Boek
0d2b57ed16 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5552 - Reverts temporary fix for https://github.com/mozilla-mobile/fenix/issues/5552 2020-01-07 12:24:20 +02:00
Tiger Oakes
e23d8662b2 [fenix] Change type for OnboardingAutomaticSignIn (https://github.com/mozilla-mobile/fenix/pull/7474) 2020-01-06 14:25:52 -08:00
Michael Comella
9f1195a762 [fenix] No issue: remove useless @MenuRes annotation in History Fragment. 
This annotation was not applied correctly and lint was unable to ensure
it was used properly: it declared an error in lint saying so but that
error was ignored. I did not know how to apply the annotation - and I
felt it had limited utility - so I removed it entirely in order to
permit the lint baseline file to be removed (it was the only error).
 2020-01-06 18:27:51 +02:00
Michael Comella
070d098012 [fenix] No issue: remove lint baseline file. 
This will enable folks to see the existing warnings.
 2020-01-06 18:27:51 +02:00
mcarare
d2d42c51ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/6851 Update text copy of option to add custom search engine 2020-01-06 14:32:02 +02:00
Mihai Branescu
bbd73acf60 [fenix] Feature/https://github.com/mozilla-mobile/fenix/issues/220 language menu (https://github.com/mozilla-mobile/fenix/pull/7070) 
* For https://github.com/mozilla-mobile/fenix/issues/220
- Added advanced header + locale settings item in the settings fragment

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added locale selection page with lib state + handling of locale changes

* For https://github.com/mozilla-mobile/fenix/issues/220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added unit tests for locale settings page

* For https://github.com/mozilla-mobile/fenix/issues/220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2020-01-03 18:15:35 -08:00
Severin Rudie
8b746007fd [fenix] 7410 remove rxjava (https://github.com/mozilla-mobile/fenix/pull/7426) 
* For https://github.com/mozilla-mobile/fenix/issues/7410: rewrite updateBookmarkFromObservableInput with coroutines

* For 7410: remove RxJava from project. :(

* For 7410: converted updateBookmarkFromTextChanges to Flow per review
 2020-01-03 14:37:12 -08:00
mozilla-l10n-automation-bot
8b1915c55c [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/7476) 2020-01-03 14:59:08 -05:00
Jonathan Almeida
e816fa6a00 [fenix] No issue: Use SendTabFeature and FxaPushSupportFeature 2020-01-03 10:20:53 -05:00
Sawyer Blatz
b86face3d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6413: Adds more snackbar positioning logic (https://github.com/mozilla-mobile/fenix/pull/7444) 
* For https://github.com/mozilla-mobile/fenix/issues/6413: Adds more snackbar positioning logic

* Refactor
 2020-01-02 14:31:52 -08:00
Roger Yang
c3f1811b5d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7346: Enable dynamic app links in Fenix (https://github.com/mozilla-mobile/fenix/pull/7361) 2020-01-02 13:08:11 -05:00
Michael Comella
42ec15c095 [fenix] No issue: remove unused Anko dependencies. 2019-12-31 10:46:39 -05:00
Sawyer Blatz
904a5c02d5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6413: Fixes snackbar positionining for bottom toolbar (https://github.com/mozilla-mobile/fenix/pull/7415) 
* For https://github.com/mozilla-mobile/fenix/issues/6413: Fixes snackbar positionining for bottom toolbar

* For https://github.com/mozilla-mobile/fenix/issues/6413: Cleans up snackbar usage
 2019-12-30 14:43:15 -08:00
Emma Malysz
eb02fcfcd7 [fenix] For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (https://github.com/mozilla-mobile/fenix/pull/7246) 
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
 2019-12-30 14:42:13 -08:00
Michael Comella
efbff24ba4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6464: Replace use of BuildConfig.DEBUG with ReleaseChannel.channel.isDebug. 
This fixes performance issues where StrictMode would greatly slow down
startup in the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
aba20bd5cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/6464: Set "forPerformanceTest" to ReleaseChannel.FenixProduction. 
This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
a60e4e9d1f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6464: Add ReleaseChannel test to document assumptions. 2019-12-30 10:31:33 -08:00
Michael Comella
1336ec98b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6464: Add ReleaseChannel.isDebug. 2019-12-30 10:31:33 -08:00
Severin Rudie
484d552c60 [fenix] For 5334: test NotificationSessionObserver 2019-12-30 11:40:07 +02:00
Severin Rudie
5d33e79c59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5334: disable notification for private custom tabs 2019-12-30 11:40:07 +02:00
Richard Pappalardo
429ad5d0d6 [fenix] Temp disable UI test verifyAboutFirefoxPreview (https://github.com/mozilla-mobile/fenix/pull/7390) 2019-12-27 15:46:55 -08:00
Sawyer Blatz
3edfeb2731 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7000: Fix inverted media telemetry (https://github.com/mozilla-mobile/fenix/pull/7368) 2019-12-27 13:46:47 -08:00
Severin Rudie
691676a27b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7352: integrate highlightable browser menu changes (https://github.com/mozilla-mobile/fenix/pull/7353) 
* For https://github.com/mozilla-mobile/fenix/issues/7352: integrate highlightable browser menu changes

* For 7352: invalidate menu when reader mode availability changes

* For 7352: removed highlight from reader mode appearance per UX
 2019-12-27 12:15:21 -08:00
Kadeem M
78a599b06e [fenix] Added UI tests for the About Settings page (https://github.com/mozilla-mobile/fenix/pull/6161) 2019-12-27 07:55:35 -08:00
isabelrios
7aa2fd8263 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Add UI tests for logins and passwords setting menu (https://github.com/mozilla-mobile/fenix/pull/7291) 
* For https://github.com/mozilla-mobile/fenix/issues/5074 - Add UI tests for logins and passwords setting menu

* fix detekt failure

* remove old file

* fix scroll small screens

* fix reviewer comments
 2019-12-26 14:22:40 -08:00
Sawyer Blatz
70a7a685f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7347: Fixes background of search field 2019-12-23 10:07:54 -08:00
Sawyer Blatz
a5f8a5b415 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6666: Adds back button to search screen 2019-12-23 10:07:02 -08:00
Mihai Adrian
b783691de8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7122 Fix icons for saved logins screen (https://github.com/mozilla-mobile/fenix/pull/7268) 2019-12-23 12:46:52 -05:00
Suraj Shah
320b5a0d05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7041 - Respect current mode when opening library items (https://github.com/mozilla-mobile/fenix/pull/7311) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/7041
Consumes `browserMode` from home activity for tap method of bookmark

* Fixes spaces

* Cleaning tests

* Cleaning tests
 2019-12-23 12:26:47 -05:00
mozilla-l10n-automation-bot
225ed1f615 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/7009) 2019-12-20 14:01:18 -05:00
Roger Yang
5ae8bc6f0a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7156: Update app links feature usage to include app links interceptor (https://github.com/mozilla-mobile/fenix/pull/7275) 2019-12-20 08:27:19 -05:00
Richard Pappalardo
57679f7d4d [fenix] Temp disable flaky UI testDownloadPrompt (https://github.com/mozilla-mobile/fenix/pull/7304) 2019-12-20 10:31:43 +02:00
Josh
c1606de6d7 [fenix] Fix parameterized message in search engine (https://github.com/mozilla-mobile/fenix/pull/7302) 2019-12-20 10:27:05 +02:00
Jeff Boek
16d3a71d3d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 - Override custom tab styling in private mode (https://github.com/mozilla-mobile/fenix/pull/7305) 2019-12-19 18:17:52 -08:00
Josh
1249b4a5ca [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7254 - Replace Anko applyConstraintSet (https://github.com/mozilla-mobile/fenix/pull/7286) 
* For https://github.com/mozilla-mobile/fenix/issues/7254: Replace anko applyConstraintSet

* Anko has been deprecated and will not be continued

* Refactor ConstraintSet changes

* Replace applyConstraintSet in SearchLayouts

* Refactor HomeFragment ConstraintSet

* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
 2019-12-19 18:16:50 -08:00
Mihai Adrian
a16ebd937e [fenix] For https://github.com/mozilla-mobile/fenix/issues/6992, for https://github.com/mozilla-mobile/fenix/issues/6897, for https://github.com/mozilla-mobile/fenix/issues/6889: Disable multitouch in app (https://github.com/mozilla-mobile/fenix/pull/6999) 2019-12-19 19:32:47 -05:00
Tiger Oakes
3c0ff1b69c [fenix] Clean up settings fragments 2019-12-19 14:29:28 -08:00
Josh Vocal
934cb1f4ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/7253 - Replace anko setters 2019-12-19 13:42:50 -08:00
Jeffrey Starke
1bdda56989 [fenix] Consolidate duplicate mock initialization in intent processor tests. (https://github.com/mozilla-mobile/fenix/pull/6374) 
* Consolidate duplicate code in intent processor tests

* Resolve ktlint errors
 2019-12-19 12:33:59 -05:00
Mihai Adrian
76e063ad48 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3574 Allow all screen readers to read onboarding items one-by one (https://github.com/mozilla-mobile/fenix/pull/7292) 2019-12-19 09:53:53 -05:00
Tiger Oakes
8b2eb8fd5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/7085 - Remove anko px2dip (https://github.com/mozilla-mobile/fenix/pull/7252) 2019-12-19 00:05:51 -08:00
Tiger Oakes
999e8d222f [fenix] For https://github.com/mozilla-mobile/fenix/issues/768 - Add PWA install option to menu (https://github.com/mozilla-mobile/fenix/pull/6882) 2019-12-18 23:59:30 -08:00
mcarare
1ad17245f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6709, for https://github.com/mozilla-mobile/fenix/issues/6849 Handle default engine deletion and undo operation 
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
 2019-12-18 23:00:42 -08:00
Tiger Oakes
59345e3bee [fenix] For https://github.com/mozilla-mobile/fenix/issues/7183 - Fix bottom margin in PWAs 2019-12-18 22:57:54 -08:00
Rushab Kumar
d679cf7378 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7250 - Replace anko.dimen 2019-12-18 15:39:14 -08:00
Sebastian Kaspari
4c5e3996dc [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4978: Reuse widget package name of Fennec. 2019-12-18 15:23:43 -08:00
Emily Kager
5b332811da [fenix] For https://github.com/mozilla-mobile/fenix/issues/7219 - Polish Download Notification Dialog. (https://github.com/mozilla-mobile/fenix/pull/7224) 
* For https://github.com/mozilla-mobile/fenix/issues/7219 - Use accent color for downloads dialog positive button

* For https://github.com/mozilla-mobile/fenix/issues/7219 - Fixes gap beneath download notification dialog

* switch to setimageresource
 2019-12-18 12:26:41 -05:00
Roger Yang
c0588dcd90 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7260: Pass in GeckoView version information to MozillaSocorroservice 2019-12-18 10:45:57 +01:00
Grisha Kruglov
47f40dbf7e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6937: Disable runStorageMaintenance during startup 
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
 2019-12-17 14:24:30 -08:00
Tiger Oakes
a752ecd79b [fenix] Split out CustomTabToolbarIntegration (https://github.com/mozilla-mobile/fenix/pull/7107) 2019-12-17 12:26:46 -08:00
David Walsh
6f39a70d04 [fenix] Use localized strings in the quick settings panel (https://github.com/mozilla-mobile/fenix/pull/7249) 2019-12-17 10:47:21 -08:00
Colin Lee
fbe4ebc5d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Update R8/ProGuard config for new Kotlin coroutines library (https://github.com/mozilla-mobile/fenix/pull/7218) 2019-12-17 10:41:54 -06:00
Sebastian Kaspari
e91ad0086c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976: Use dynamic launcher entry in manifest. 2019-12-17 16:00:15 +01:00
Suraj Shah
c634d89cd4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7048: Network info migration (https://github.com/mozilla-mobile/fenix/pull/7091) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/7048.
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests

* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt

* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance

* Creates ConnectivityManager extension component

* Fixes https://github.com/mozilla-mobile/fenix/issues/7180
Refactors test cases to fix static mocks
 2019-12-16 22:03:11 -08:00
David Walsh
4fada3f5be [fenix] Fix 5366 - Use VectorDrawableCompat for all imagery (https://github.com/mozilla-mobile/fenix/pull/7221) 
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
 2019-12-16 20:35:36 -08:00
Severin Rudie
863dcf72ab [fenix] For 6795: expands toolbar whenever a new session is selected 
This ensures that the bar is expanded when opening a link in a new tab
 2019-12-16 14:09:29 -08:00
Jeff Boek
8d4a944920 [fenix] No Issue - Removes some search engines 2019-12-16 14:09:14 -08:00
mcarare
1531cfd558 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7194 Set snackbar anchor depending on browser toolbar position 2019-12-16 12:21:54 -08:00
Aaron Train
9b77b65e69 [fenix] No issue: Fixes breakage with unused import in 71e8063 (https://github.com/mozilla-mobile/fenix/pull/7205) 2019-12-16 11:55:44 -05:00
Aaron Train
f9e3b21578 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6697: Add Tracking Protection UI Tests (https://github.com/mozilla-mobile/fenix/pull/6825) 
Add tests for verifying basic UI functionality of Enhanced Tracking Protection
 2019-12-16 10:12:43 -05:00
Patrick Martin
4eb5d64307 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5711 - Onboarding colours have contrast issues 2019-12-13 17:52:55 -08:00
Afzal Najam
9474fe12af [fenix] Hide add folder option when in Desktop Bookmarks folder 2019-12-13 17:51:15 -08:00
Ryan Kelly
b806b4c5fa [fenix] Use feature-accounts-push, which replaces feature-sendtab. 2019-12-13 16:42:28 -08:00
mcarare
b9d221b9d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6968 Close response stream to allow use of caching 2019-12-13 12:35:25 -08:00
mcarare
d77be2b506 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7075 Update passwords preference visibility and string 
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
 2019-12-13 12:19:14 -08:00
mcarare
51e35d827d [fenix] Reverts https://github.com/mozilla-mobile/fenix/pull/6925: Make home screen full screen 2019-12-13 11:29:53 -08:00
Colin Lee
a9a3fdc1fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Replace prerelease R8 with improved Kotlin coroutines library (https://github.com/mozilla-mobile/fenix/pull/7153) 2019-12-13 13:29:27 -06:00
Will Hawkins
f92865d320 [fenix] No Issue: Create a method to "finish onboarding" in CI 
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
 2019-12-13 11:28:57 -08:00
Emily Kager
c324abaa7b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6946 - Get engine margins without assuming top/bottom toolbar 2019-12-13 11:09:30 -08:00
Emily Kager
ffce59a7d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7124 - Match toolbar location for ETP/security panel gravity 2019-12-13 11:09:30 -08:00
Vlad Filippov
3091418bd7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5913: Add new sessionToken scope (https://github.com/mozilla-mobile/fenix/pull/6155) 2019-12-12 12:00:20 -08:00
Emily Kager
6e8cdfd720 [fenix] No issue: Scroll to remote debugging text in UI Tests (https://github.com/mozilla-mobile/fenix/pull/7117) 2019-12-12 12:00:02 -08:00
Tiger Oakes
cd4f41aa6a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6830 - Fix "Open in" text size for custom tab (https://github.com/mozilla-mobile/fenix/pull/7010) 2019-12-12 11:49:54 +02:00
ValentinTimisica
3987045df8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4776: Refactored UI tests. 
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
 2019-12-12 11:34:10 +02:00
ValentinTimisica
f88065117a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4776: Added Unit tests for About Page. 2019-12-12 11:34:10 +02:00
ValentinTimisica
abb0295559 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4776: Redesign and refactor the About Page 
Added new items to be displayed.
 2019-12-12 11:34:10 +02:00
Grisha Kruglov
d467ebf6b3 [fenix] Enable Fennec settings (telemetry) migration 2019-12-11 19:16:55 -08:00
mcarare
a330ab5bda [fenix] For https://github.com/mozilla-mobile/fenix/issues/7066 Increase space below checkbox preference 2019-12-11 11:23:14 -08:00
Mihai Adrian
b28abb5dce [fenix] For https://github.com/mozilla-mobile/fenix/issues/6710 Update custom search engine images with better resolution (https://github.com/mozilla-mobile/fenix/pull/7084) 2019-12-11 16:09:32 +02:00
Sawyer Blatz
35ee6640d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7073: Makes logo on about page not important for accessibi… (https://github.com/mozilla-mobile/fenix/pull/7074) 2019-12-10 12:15:11 -08:00
Mihai Branescu
6e2deeaadb [fenix] For https://github.com/mozilla-mobile/fenix/issues/6330 Collections Numbering (https://github.com/mozilla-mobile/fenix/pull/6453) 
* For https://github.com/mozilla-mobile/fenix/issues/6330 - Added logic for getting the recommended default collection name

* For https://github.com/mozilla-mobile/fenix/issues/6330 - Added unit test for default collection number method
 2019-12-10 12:10:01 -08:00
Tiger Oakes
daf77820a4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5783 - Web Share with Fenix share sheet (https://github.com/mozilla-mobile/fenix/pull/6883) 2019-12-10 10:57:06 -08:00
Mihai Adrian
018f97df45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7031 - Hide progress bar when leaving DeleteBrowsingDataFragment (https://github.com/mozilla-mobile/fenix/pull/7056) 2019-12-10 11:17:45 -05:00
isabelrios
4a62f38670 [fenix] Re-enable Screenshots tests (https://github.com/mozilla-mobile/fenix/pull/6617) 
disabling setting test options due to different screen sizes

name screenshots according to robots

fix kotlin style

update settings tests with new Toolbar option

screenshots tests in different package than ui tests
 2019-12-10 13:05:47 +02:00
Sebastian Kaspari
662000d038 [fenix] Run migration in background service. 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
https://github.com/mozilla-mobile/android-components/issues/4879
 2019-12-10 11:31:32 +01:00
Tiger Oakes
19b362d4fd [fenix] Extract IntentProcessorType to its own file and add tests (https://github.com/mozilla-mobile/fenix/pull/7012) 2019-12-10 00:02:23 -08:00
Severin Rudie
bb5685cc4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4844: fix file prefix url shortening 2019-12-10 05:07:53 +01:00
Severin Rudie
9a0b3f6557 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5334: fix ETP shield coloring on custom private tabs 2019-12-10 03:22:55 +01:00
Mihai Adrian
ab0bc61cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6997 Avoid overwriting empty_search_string error (https://github.com/mozilla-mobile/fenix/pull/6998) 
Setting error twice also clips error message
 2019-12-09 18:10:24 -08:00
Emily Kager
69f92da9cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/6922 - Check current destination is logins fragment before navigation (https://github.com/mozilla-mobile/fenix/pull/6924) 2019-12-09 15:42:40 -08:00
Michael Comella
ed87207990 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Clarify VERBOSE logging motivation. 2019-12-09 15:11:52 -08:00
Michael Comella
3b36ea34c8 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Add HotStartPerformanceMonitorTest. 
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
 2019-12-09 15:11:52 -08:00
Michael Comella
bde17a6a4e [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Add HotStartPerformanceMonitor. 
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
 2019-12-09 15:11:52 -08:00
ekager
7f5cac63f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5771 - Don't force landscape mode on fullscreen 2019-12-09 23:47:57 +01:00
mcarare
35eeb98cac [fenix] For https://github.com/mozilla-mobile/fenix/issues/4107 Make home screen fullscreen. 
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
 2019-12-09 23:45:02 +01:00
mcarare
d49503e58e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7026 Dispatch ModeChange on hideOnboarding 2019-12-09 23:44:33 +01:00
ekager
058da9bf17 [fenix] No issue: Remove unnecessary back slashes from curly apostrophe strings 2019-12-09 23:16:00 +01:00
Grisha Kruglov
46bf7f45f9 [fenix] Fennec migration: enable logins migration 2019-12-09 13:35:22 -08:00
Jeff Boek
e0b335ed68 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1607 - Passes "custom" as the search engine identifier for custom engines 2019-12-09 11:47:05 -08:00
Severin Rudie
f838367e84 [fenix] No issue: small installedSearchEngineIdentifiers readability refactor 2019-12-09 10:58:19 -08:00
Severin Rudie
013aac2604 [fenix] No issue: tests installedSearchEngineIdentifiers 2019-12-09 10:58:19 -08:00
Severin Rudie
a6bb6ad9ca [fenix] No issue: begin moving FenixSearchEngineProvider into a testing harness 2019-12-09 10:58:19 -08:00
Oana Horvath
4e1bb19dc0 [fenix] Fixed flaky History UI tests by adding an extra verification step that (https://github.com/mozilla-mobile/fenix/pull/6894) 
the page is loaded.

Enabled all tests
 2019-12-09 11:52:55 +02:00
Aaron Train
4cf0c56803 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6873: Support many more Content-Type in MockWebServer (UI tests) (https://github.com/mozilla-mobile/fenix/pull/7001) 
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
 2019-12-06 14:53:18 -05:00
Severin Rudie
53b4d6714e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5334: added private custom tab processor (https://github.com/mozilla-mobile/fenix/pull/6845) 
* For https://github.com/mozilla-mobile/fenix/issues/5334: added private custom tab processor

* For https://github.com/mozilla-mobile/fenix/issues/5334 - Fixes up IntentReceiverActivity for handling intents

* For 5334: update styling for private custom tabbs

* For 5334: update tests to account for new processors

Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.

* For 5334: fixes bug introduced by changes to IntentReceiverActivity

RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.

* For 5334: add tests for custom tabs processing
 2019-12-06 10:57:54 -08:00
Jeff Boek
fa903dd097 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4664 - Updates search_with string. (https://github.com/mozilla-mobile/fenix/pull/6909) 2019-12-06 10:36:19 -08:00
Mozilla L10n Automation Bot
8671faa0f6 [fenix] Import l10n. 2019-12-06 08:53:22 -08:00
kglazko
50b8f92201 [fenix] Issue 5366 Vector Drawable Compat (https://github.com/mozilla-mobile/fenix/pull/6904) 2019-12-05 19:54:32 -08:00
Richard Pappalardo
101f6a1770 [fenix] Disable flaky testDownloadNotification - API28 (https://github.com/mozilla-mobile/fenix/pull/6982) 2019-12-05 18:00:21 -08:00
Mihai Adrian
208d0c684b [fenix] Temporarily fix lint issues with bad translation of string (https://github.com/mozilla-mobile/fenix/pull/6963) 2019-12-05 13:57:57 -08:00
mcarare
4a29b6b06b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current 2019-12-05 11:10:14 -08:00
Mihai Adrian
b36189b3b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6910 Align shortcuts in private onboarding panel style to… (https://github.com/mozilla-mobile/fenix/pull/6950) 
Divider only shows when both panel and "Search with" are visible
 2019-12-05 09:37:20 -08:00
Mihai Adrian
a4be691ea0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate (https://github.com/mozilla-mobile/fenix/pull/6978) 2019-12-05 09:36:39 -08:00
Mozilla L10n Automation Bot
4d9a90f293 [fenix] Import l10n. 2019-12-04 19:59:25 -08:00
Gabriel
9ed4f7f119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState (https://github.com/mozilla-mobile/fenix/pull/6651) 
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651)

In https://github.com/mozilla-mobile/fenix/issues/2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- Removes TabAction

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651)

- Renames SessionControlUIView to SessionControlView

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
 2019-12-04 22:06:05 -05:00
Jeff Boek
58bdd912e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6855 - Filter out duplicated bundled search engines 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 17:10:02 -08:00
mcarare
7a289d1eb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private 2019-12-04 16:44:01 -08:00
Jeff Boek
e6709a82d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
4e988fce7b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
e51c588fd7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Emily Kager
4ce302d29f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar (https://github.com/mozilla-mobile/fenix/pull/6911) 2019-12-04 15:01:04 -08:00
Jeff Boek
7f7685689f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL (https://github.com/mozilla-mobile/fenix/pull/6955) 
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
 2019-12-04 15:00:51 -08:00
Sebastian Kaspari
ad503a83c1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976: Reuse Fennec launcher entry in manifest. 
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.

A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
 2019-12-04 12:51:48 -08:00
Oana Horvath
0cb634facc [fenix] Added multi-selection tests for bookmarks (https://github.com/mozilla-mobile/fenix/pull/6475) 
Updated bookmarking method

Fixed flaky tests

Added wait to create bookmark
 2019-12-03 12:44:54 +02:00
mawen7
bbfa8aadd4 [fenix] Run lint for app module and set baseline 2019-12-02 14:45:34 -08:00
Aaron Train
0e77c47f42 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests (https://github.com/mozilla-mobile/fenix/pull/6574) 
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
 2019-12-02 17:15:00 -05:00
ekager
333ff28126 [fenix] No issue: Fix search suggestions strings 2019-12-02 21:39:10 +00:00
ekager
c09e977ff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6791 - Inflate SavedLoginsListItemViewHolder layout explicitly 2019-12-02 10:40:58 -08:00
ekager
4f0bcac5b8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6889 - Check current destination before navigating from settings 2019-12-02 10:40:21 -08:00
ekager
41af91db69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6890 - Don't crash with no connection when adding custom search engine 2019-12-02 10:37:31 -08:00
Severin Rudie
312a66c20e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5540: updates error page copy when no internet is available (https://github.com/mozilla-mobile/fenix/pull/6803) 2019-12-02 10:26:06 -08:00
cesar
8a51b43fbc [fenix] test fixed 2019-12-02 16:18:48 +00:00
cesar
9b868c1e0b [fenix] nested loop removed 2019-12-02 16:18:48 +00:00
cesar
51fe91d723 [fenix] klint clean up and previous nit fixed 2019-12-02 16:18:48 +00:00
cesar
cc1bfd730b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6731 - fixed BookmarkNode minus operator and deleteOperation 2019-12-02 16:18:48 +00:00
cesar
85a1b85158 [fenix] Test for 6731 2019-12-02 16:18:48 +00:00
mcarare
2ca9178898 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6835 Align Home and Browser toolbar elements to perfectly overlap 2019-12-02 16:17:07 +00:00
mcarare
10831c25ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/6401 Set false as default value for Open links in a private tab 2019-12-02 16:16:26 +00:00
mcarare
75330ca583 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6516 On browsing mode change empty tab list before displaying new list 2019-12-02 16:15:54 +00:00
Tiger Oakes
4426480f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6827, https://github.com/mozilla-mobile/fenix/issues/6811 - Cast layoutParams to MarginLayoutParams 2019-12-02 14:52:31 +00:00
mcarare
b49fd6c3b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6881 Choose visible view when multiple views have same label text 2019-12-02 14:02:51 +00:00
Oana Horvath
d7bc4a96ce [fenix] Disable UI history tests again for more investigation (https://github.com/mozilla-mobile/fenix/pull/6837) 2019-12-01 19:53:55 -05:00
Tiger Oakes
5bdd21e04e [fenix] Suppress upcoming deprecation (https://github.com/mozilla-mobile/fenix/pull/6765) 2019-11-28 16:17:56 -08:00
Gabriel Luong
30a1862f30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest 2019-11-28 15:58:07 -05:00
Jeff Boek
5c7ec54a11 [fenix] No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
mcarare
68ba4480cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/6629 Align Private Browsing mode to UX specs 2019-11-27 11:13:20 -08:00
ekager
4b720e646f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Track all login copy events 2019-11-27 10:59:36 -08:00
Mozilla L10n Automation Bot
a01d3cc798 [fenix] Import l10n. 2019-11-27 10:52:38 -08:00
Will Hawkins
dc526b557e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5183: Initialize megazord asynchronously 
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
 2019-11-27 10:51:57 -08:00
cesar
5cd156bba2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6769 - EditText moved to be above the gradient view 2019-11-27 10:48:38 -08:00
Sebastian Kaspari
a126b92f9c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622, https://github.com/mozilla-mobile/fenix/issues/6688: Create a "fennecBeta" and "fennecNightly" build types. 2019-11-27 10:28:22 -08:00
mcarare
a6b0fda280 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4219 Set url view not important for accessibility 
Talkback rectangle for url view selection will include parent view
 2019-11-27 10:11:16 -08:00
mcarare
bd55aaeb46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Change notification icon 
Used private browsing icon with compulsory white color for notifications
 2019-11-27 10:08:00 -08:00
mcarare
2711348828 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Remove actions from notification, keep just close private tabs 
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
 2019-11-27 10:08:00 -08:00
Mihai Branescu
6d8117f1ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 - Added metrics for tracking history/bookmarks account sync toggles (https://github.com/mozilla-mobile/fenix/pull/6601) 2019-11-27 11:16:23 +02:00
Mihai Adrian
61b23c7a32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6748 Move Add search engine to search engine preference category. (https://github.com/mozilla-mobile/fenix/pull/6749) 2019-11-27 10:45:05 +02:00
Mihai Adrian
132c68b597 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode. (https://github.com/mozilla-mobile/fenix/pull/6736) 
notifyDataSetChanged to avoid not displayed but created items not being redrawn
 2019-11-27 10:40:38 +02:00
Mihai Adrian
d4557d5a67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Align text to viewStart to keep consistency in RTL (https://github.com/mozilla-mobile/fenix/pull/6778) 2019-11-27 10:35:49 +02:00
Jeff Boek
11b8410367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5972 - Fixes bugs when launching in private mode on Android 5 (https://github.com/mozilla-mobile/fenix/pull/6702) 2019-11-26 14:53:03 -08:00
Sawyer Blatz
58a007659f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6821: Fixes issues with custom tabs and dynamic toolbar (https://github.com/mozilla-mobile/fenix/pull/6822) 2019-11-26 13:02:52 -08:00
Mihai Adrian
8734472571 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6430 Private browsing hint width should not exceed screen dimensions (https://github.com/mozilla-mobile/fenix/pull/6786) 
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
 2019-11-26 10:07:31 -08:00
Sawyer Blatz
723d99864f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054: Allows users to change toolbar position (https://github.com/mozilla-mobile/fenix/pull/6608) 
* For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054: Adds preference screen for toolbar

* For https://github.com/mozilla-mobile/fenix/issues/5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For https://github.com/mozilla-mobile/fenix/issues/6054: Adds toolbar position to core ping
 2019-11-25 16:43:32 -08:00
Tiger Oakes
42d5ef61f9 [fenix] Add toolbar helpers (https://github.com/mozilla-mobile/fenix/pull/6531) 2019-11-25 15:36:47 -05:00
Tiger Oakes
35bf8dfc58 [fenix] Use ShareData with ShareFragment (https://github.com/mozilla-mobile/fenix/pull/6698) 2019-11-25 11:07:21 -08:00
Christian Sadilek
9176a21ab0 [fenix] Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped 2019-11-23 20:25:21 -05:00
Tiger Oakes
21ef894d5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6763 - Fix early view access 2019-11-23 10:55:29 -05:00
Daphne Liu
7be9a0aba7 [fenix] Switched to AC string extensions (https://github.com/mozilla-mobile/fenix/pull/6258) 
* Switched to AC string extensions

* Clean up imports
 2019-11-22 23:15:51 -08:00
ekager
e201d5bf68 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6628 - Remove required for biometric manifest 2019-11-22 14:17:26 -08:00
ekager
8c02806625 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6573 - Fixes anchor view for tab switching snackbar 2019-11-22 14:15:17 -08:00
Sawyer Blatz
a00e212e4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6436: Adds snackbar for failed download (https://github.com/mozilla-mobile/fenix/pull/6648) 2019-11-22 12:46:57 -08:00
Mozilla L10n Automation Bot
666cdd937f [fenix] Import l10n. 2019-11-22 11:14:22 -08:00
David Walsh
33d54e5f98 [fenix] Fix 6048 - Improve alignment in Edit Bookmark screen 2019-11-22 10:14:00 -08:00
Tiger Oakes
aacb184521 [fenix] Clean up tracking protection fragment (https://github.com/mozilla-mobile/fenix/pull/6532) 
* Clean up exceptions fragment

* Clean up tracking protection fragment

* Move saved logins to list adapter
 2019-11-22 10:38:13 -05:00
Sebastian Kaspari
38e97e4f16 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4982: Migrate Gecko files before initializing engine. (https://github.com/mozilla-mobile/fenix/pull/6738) 2019-11-22 08:18:50 -05:00
Mozilla L10n Automation Bot
3635ac49a7 [fenix] Import l10n. 2019-11-22 14:00:39 +01:00
Stephen Tsimicalis
13e71e46e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4824 - Fixes onboarding telemetry events from being sent a… (https://github.com/mozilla-mobile/fenix/pull/6659) 2019-11-21 17:51:55 -08:00
Mozilla L10n Automation Bot
b4251d143e [fenix] Import l10n. 2019-11-21 16:45:05 -08:00
Pawel Obarzanek
57a08d269e [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/5458 Tests for IntentReceiverActivity to verify outcoming intent (https://github.com/mozilla-mobile/fenix/pull/6130) 2019-11-21 16:44:08 -08:00
Pawel Obarzanek
6957b089ef [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 Initial tests for FragmentPreDrawMan… (https://github.com/mozilla-mobile/fenix/pull/6134) 
* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 Initial tests for FragmentPreDrawManager

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 verify if addOnPreDrawListener was called
 2019-11-21 16:23:59 -08:00
Mihai Adrian
da3ecd3ca5 [fenix] Update app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt 
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
 2019-11-21 15:34:01 -08:00
mcarare
5285283d76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3523 Add Firefox Sync error states also to Settings in Home menu 2019-11-21 15:34:01 -08:00
isabelrios
e75264272f [fenix] fix reviewer comments 2019-11-21 15:32:26 -08:00
isabelrios
ee8015ef6c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6322 - UI tests for Account Settings View 
removing sleeps

fix ktlint errors
 2019-11-21 15:32:26 -08:00
Matt McKenna
04552dca30 [fenix] Add Mozilla licensing header to gradient 2019-11-21 15:27:50 -08:00
Matt McKenna
ecfb4c3373 [fenix] Add a simple gradient to collection creation 2019-11-21 15:27:50 -08:00
matthewcmckenna
b0116ebdee [fenix] Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
Tiger Oakes
6605d2388d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6523 - Remove close button in library 2019-11-21 15:27:18 -08:00
Patrick Martin
ccb1057a38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font set (https://github.com/mozilla-mobile/fenix/pull/6724) 
* For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font se

* Update HistoryRobot.kt
 2019-11-21 15:05:59 -08:00
mcarare
3f883d62b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Update unit tests and UI tests 2019-11-21 14:36:14 -08:00
mcarare
1c543b06bf [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Add onboarding search suggestion hint panel 2019-11-21 14:36:14 -08:00
mcarare
f9a51fa99f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Add option to enable search suggestions in private mode 2019-11-21 14:36:14 -08:00
mcarare
b8537c205e [fenix] For https://github.com/mozilla-mobile/fenix/issues/6625 Fix back navigation in search mode from browser 2019-11-21 14:35:12 -08:00
Tiger Oakes
f0969797aa [fenix] Extract TP onboarding popup (https://github.com/mozilla-mobile/fenix/pull/6700) 2019-11-21 17:23:35 -05:00
Arturo Mejia
02b66be3d7 [fenix] No issue: Remove download file provider. (https://github.com/mozilla-mobile/fenix/pull/6699) 2019-11-21 14:31:03 -05:00
Johan Lorenzo
8eef026200 [fenix] Split UI test 2019-11-21 11:59:51 +01:00
Grisha Kruglov
2265e8ee61 [fenix] Enable encryption of persisted FxA account state 2019-11-20 15:32:56 -08:00
Jeff Boek
4d33b453ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Removes the feature flag for Force Enable Zoom (https://github.com/mozilla-mobile/fenix/pull/6646) 
* For https://github.com/mozilla-mobile/fenix/issues/2477 - Removes the feature flag for Force Enable Zoom

* For https://github.com/mozilla-mobile/fenix/issues/2477 - Fixes bug where zoom preference doesnt persist between launches
 2019-11-20 10:32:38 -08:00
ekager
115b18d3a7 [fenix] Add scroll to item 2019-11-20 10:23:48 -08:00
ekager
6477f73c31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6707 https://github.com/mozilla-mobile/fenix/issues/6708 - Fix UI Tests for new Search Engine Behavior 2019-11-20 10:23:48 -08:00
Jeff Boek
daaaeef741 [fenix] Adds custom search engines (https://github.com/mozilla-mobile/fenix/pull/6551) 
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds button to add a new search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds custom engine store

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Creates a custom SearchEngineProvider

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Gives the ability to delete search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the UI to add a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds form to create a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to add a custom search engine

*  For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to delete custom search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Selects the first element on the add custom search engine screen

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Prevents adding a search engine that already exists

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Styles the add search engine preference

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Makes the name check case-insensitive

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fix bug where home screen doesnt see new search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves Search URL validation to its own type

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes linting errors

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to edit a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds an undo snackbar when deleting a search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves all of the strings to be translated

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes bug when deleting your default search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Puts adding search engines behind a feature flag

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Navigate to custom search engine SUMO article when tapping learn more

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes nits

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Uses concept-fetch to validate search string

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds string resources for the cannot reach error state
 2019-11-19 16:30:56 -08:00
Patrick Martin
fe51c6bd42 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font se 2019-11-19 10:50:17 -08:00
Oana Horvath
ac4939cb9f [fenix] Fixed History flaky tests (https://github.com/mozilla-mobile/fenix/pull/6592) 
Ignoring some tests for now and left some to run
 2019-11-19 11:29:35 +02:00
Mozilla L10n Automation Bot
3af4199c46 [fenix] Import l10n. 2019-11-18 23:08:32 -08:00
mawen7
f99cc9e5c4 [fenix] Jump to tab overview if closed tab has no parent session 2019-11-18 22:56:42 -08:00
cesar
e2610eec54 [fenix] ktlint clean up 2019-11-18 20:07:22 -08:00
cesar
3402ab6636 [fenix] Fixed Typo 2019-11-18 20:07:22 -08:00
cesar
9bc3f93df4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6594 - Trigger keyboard automatically when creating a bookmark folder 2019-11-18 20:07:22 -08:00
cesar
1f32a65e4e [fenix] Test for 6594 2019-11-18 20:07:22 -08:00
cesar
7aea6f6d1a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6593 - Hide keyboard when quitting add bookmark folder flow 2019-11-18 20:07:22 -08:00
cesar
0fd8d98d12 [fenix] Test for 6593 2019-11-18 20:07:22 -08:00
ekager
a616b2aafa [fenix] For https://github.com/mozilla-mobile/fenix/issues/6621 - Add Secure Flag to Window in Logins Fragments 2019-11-18 14:32:10 -08:00
Jeff Boek
47a2a82e33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2271 - Fixes colors on dark theme 2019-11-18 14:23:54 -08:00
David Walsh
ab3dc16a21 [fenix] Provide top padding to URL 2019-11-18 14:01:40 -08:00
David Walsh
9f6b192e93 [fenix] Implement a more dynamic layout height 2019-11-18 14:01:40 -08:00
David Walsh
bfb9982e11 [fenix] Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Mozilla L10n Automation Bot
7e50ca8f44 [fenix] Import l10n. 2019-11-18 13:30:59 -08:00
Sawyer Blatz
213c3ef3e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6434: Fixes downloadCompleted for paused downloads 2019-11-18 11:49:01 -08:00
Jeff Boek
458dee5101 [fenix] No Issue - Fixes NPE in tests (https://github.com/mozilla-mobile/fenix/pull/6673) 2019-11-18 11:29:49 -08:00
Roger Yang
f8b8249b3f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6440 Integrate Web Notifications Feature 2019-11-18 13:44:39 -05:00
Jeff Boek
59fbfbf59b [fenix] No Issue - Adds proguard rules for Lifecycle component (https://github.com/mozilla-mobile/fenix/pull/6632) 
This is a potential fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1596302
 2019-11-15 17:10:38 -08:00
Mihai Adrian
a03829e931 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode. (https://github.com/mozilla-mobile/fenix/pull/6321) 
Used notifyItemRangeChanged to redraw already drawn items.
 2019-11-15 15:48:48 -08:00
Severin Rudie
1199424753 [fenix] 4844 fix url elision (https://github.com/mozilla-mobile/fenix/pull/6588) 
* For https://github.com/mozilla-mobile/fenix/issues/4844: add test cases for url elision

* For 4844: implement toShortUrl to pass test cases

* For 4844: update plumbing to use toShortUrl

* For 4844: adds/handles suggested url elision test case
 2019-11-15 14:25:50 -08:00
Gabriel Luong
23069b57af [fenix] For https://github.com/mozilla-mobile/fenix/issues/5583 - Adds telemetry for download notification (https://github.com/mozilla-mobile/fenix/pull/6554) 2019-11-15 16:50:11 -05:00
Patrick Martin
0ddba7a2f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1695 - Detect HTML mime type for clipboard URL (https://github.com/mozilla-mobile/fenix/pull/6612) 
* For https://github.com/mozilla-mobile/fenix/issues/1695 - Detect HTML mime type for clipboard URL
 2019-11-15 12:23:52 -08:00
MozLando
8d28cdef96 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6513 
6513: For https://github.com/mozilla-mobile/fenix/issues/5295 [A11y] Unable to tap snackbar r=kglazko a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-11-15 18:43:54 +00:00
Will Hawkins
45ed971342 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6196: Make initialization of Glean metrics faster 
setStartupMetrics is very expensive and does not need to be
done synchronously at the time the Glean Metrics Service is
initialized.
 2019-11-15 10:38:08 -05:00
Emily Kager
634ef111d0 [fenix] No issue: Check destination before popping logins fragments 2019-11-14 18:20:44 -08:00
Tiger Oakes
037d35abd1 [fenix] Use ViewModel for share fragment 2019-11-14 16:25:50 -08:00
Tiger Oakes
47200b1308 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4528 - Prevent share menu from jumping 
Plus a bunch of docs and refactoring
 2019-11-14 16:25:50 -08:00
Mozilla L10n Automation Bot
55915910e7 [fenix] Import l10n. 2019-11-14 16:19:30 -08:00
Emily Kager
a4a5315838 [fenix] Add logins to UI test 2019-11-14 16:05:20 -08:00
ekager
8f1e6a7ad0 [fenix] Add override for Core val in test 2019-11-14 16:05:20 -08:00
ekager
fba098576f [fenix] Update BackgroundServicesTest 2019-11-14 16:05:20 -08:00
Emily Kager
f279306478 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 2019-11-14 16:05:20 -08:00
Kate Glazko
75f2cdef22 [fenix] 2019-11-14 13:54:08 -08:00
Tiger Oakes
dde616b728 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5085 - Use CustomTabWindowFeature (https://github.com/mozilla-mobile/fenix/pull/6603) 
Opens _blank links in new custom tab
 2019-11-14 12:02:27 -08:00
mozilla-l10n-automation-bot
f0a242f3a8 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/6530) 2019-11-14 09:58:15 -08:00
Oana Horvath
9f4e9dcc69 [fenix] Added a method to detect the UI Theme (https://github.com/mozilla-mobile/fenix/pull/6542) 2019-11-13 08:52:41 -08:00
Gabriel
6314944213 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5705 - Adds telemetry for media state (https://github.com/mozilla-mobile/fenix/pull/6463) 2019-11-12 17:24:30 -08:00
David Walsh
adfd7798e5 [fenix] Use consistent verbiage with regard to opened tabs (https://github.com/mozilla-mobile/fenix/pull/6550) 2019-11-12 16:06:37 -08:00
Emily Kager
65fb429f90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry (https://github.com/mozilla-mobile/fenix/pull/6352) 
* For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry

* Adds Logins Sync Telemetry to PreferenceToggled event
 2019-11-12 15:55:36 -08:00
mcarare
9bc6269a02 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4487 Set activity title only once in Bookmark fragment 
Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
 2019-11-12 08:21:53 -08:00
Arturo Mejia
2be3cb8bac [fenix] No issue: Do not prevent trackers duplication in the tracking 
protection panel.
 2019-11-12 08:15:30 -08:00
mcarare
04a9c50757 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6543 Hide keyboard when saving a new bookmarks folder 2019-11-12 08:09:55 -08:00
Severin Rudie
153923588f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4281: fixed metrics.yaml for QAB removal (https://github.com/mozilla-mobile/fenix/pull/6555) 2019-11-11 18:01:22 -08:00
Severin Rudie
2e76d82c9a [fenix] 4281 remove qab (https://github.com/mozilla-mobile/fenix/pull/6310) 
* For https://github.com/mozilla-mobile/fenix/issues/4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
 2019-11-11 17:10:14 -08:00
mcarare
bb6977c18c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6323 Creating 1st collection from tab shows Name collection screen 
Added a check for existence of at least a collection to select from.
 2019-11-11 14:36:55 -08:00
Sawyer Blatz
65e2c1d4b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5958: Adds in app download notifications (https://github.com/mozilla-mobile/fenix/pull/6506) 2019-11-11 14:08:51 -08:00
Mozilla L10n Automation Bot
1ed735bbd2 [fenix] Import l10n. 2019-11-08 14:44:57 -08:00
Mihai Adrian
d1e9968b33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1211 Hide the keyboard when scrolling through engine suggestions (https://github.com/mozilla-mobile/fenix/pull/6474) 2019-11-08 14:36:39 -08:00
Tiger Oakes
31d960669a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6255 - Fix beta icon filenames (https://github.com/mozilla-mobile/fenix/pull/6407) 2019-11-08 14:11:32 -08:00
RAJESH KUMAR ARUMUGAM
7a847cdf41 [fenix] Added Vibration Effect On Scanning QR Code (https://github.com/mozilla-mobile/fenix/pull/6129) 
* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing https://github.com/mozilla-mobile/fenix/issues/2928

* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing https://github.com/mozilla-mobile/fenix/issues/2928

* Update PairFragment.kt

Removed unwanted blank lines

* Update PairFragment.kt

Removed the Casting with !!
 2019-11-08 13:37:36 -08:00
Emily Kager
afa25a6978 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
mcarare
15121f02bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709 Do not animate switch for ETP panel 2019-11-08 08:36:30 -08:00
ValentinTimisica
c7dc1bad43 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6408: Pop stack to homeFragment when opening bookmarks from homeFragment 
When bookmark fragment is opened from homeFragment, libraryFragment does not
exists so the popBackStack(R.id.libraryFragment, true) would have failed. So
the solution for this was to pop back stack to homeFragment when the
bookmarks/history fragments are opened from homeFragment.
 2019-11-07 16:00:48 -08:00
Grisha Kruglov
0ab4fb0e25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Emily Kager
517d32cca2 [fenix] Fix components, core tests 2019-11-07 14:50:24 -08:00
Emily Kager
d00e038afb [fenix] Adds webAppShortcutManager argument 2019-11-07 14:50:24 -08:00
Tiger Oakes
cfddef3077 [fenix] Use ManifestUpdateFeature 2019-11-07 14:50:24 -08:00
Sawyer Blatz
a7fdfe5cd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547: Reuse biometricPrompt when authenticating 
This fixes an issue with Samsung devices where an invisible DeviceCredentialHandler because the executor was "null" (it wasn't actually)

You *must* reuse the biometric object instead of creating a new one.
 2019-11-07 13:45:41 -08:00
Emily Kager
fc7084a555 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
Shangeeth Sivan
36274d1a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4556: Removed redundant code in few tests. (https://github.com/mozilla-mobile/fenix/pull/6367) 
* Moved some values as member variables as having them declared separately in methods seemed redundant.

* Added @Before method in logtest to avoid code duplication Fixes https://github.com/mozilla-mobile/fenix/issues/4556

* Added @Before method to FragmentTest class Fixes https://github.com/mozilla-mobile/fenix/issues/4556

* variable renamed and added private access specifier; removed set from member variable as it is used only once and we can convert the list to set when needed

* Fixes linter errors
 2019-11-07 13:20:51 -08:00
Sawyer Blatz
c6e952238d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Updates total_uri_count upload (https://github.com/mozilla-mobile/fenix/pull/6482) 2019-11-06 19:10:56 -08:00
Grisha Kruglov
969398d46a [fenix] Migrate FxA state 2019-11-06 14:29:24 -08:00
Mihai Branescu
3ee547b729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6269 Rtl-wrong-search-positioning (https://github.com/mozilla-mobile/fenix/pull/6400) 
* For https://github.com/mozilla-mobile/fenix/issues/6269
- Added start/end margin for rtl support in shortcuts label

* For https://github.com/mozilla-mobile/fenix/issues/6269
- Refactored search fragment xml, extracted dimens + added styles
 2019-11-06 11:54:43 -08:00
Sawyer Blatz
1bf15d71e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6390: Fixes textColor on download prompt (https://github.com/mozilla-mobile/fenix/pull/6468) 2019-11-06 11:10:17 -08:00
Sawyer Blatz
b898b45c8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6284: Fixes SearchShortcut button functionality when in a session 
This makes it so searchShortcuts button works when going from browser -> search
 2019-11-06 11:08:41 -08:00
Mihai Branescu
48a06e4e1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6087 
- added engine hashmap so that we create each type of search provider once
(previously the providers to be added were checked by id, but since the id
is a UUID, it was always unique -> bug with multiple providers with same engine
but different id
- refactored update() flow so that it's more understandable + remove complex
method warning
 2019-11-06 11:08:41 -08:00
Mozilla L10n Automation Bot
3787c40b4d [fenix] Import l10n. 2019-11-06 09:34:26 -08:00
ekager
e709201056 [fenix] Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
Emily Kager
bb2d4aa38f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6441: Fix variant build type matching (https://github.com/mozilla-mobile/fenix/pull/6462) 2019-11-05 12:28:14 -08:00
mozilla-l10n-automation-bot
616f0210c6 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/6414) 2019-11-05 09:44:23 -08:00
Emily Kager
1b228ac62a [fenix] No issue: Ignore rest of HistoryTest tests (https://github.com/mozilla-mobile/fenix/pull/6450) 2019-11-05 08:53:07 -08:00
Emily Kager
f2839a9943 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6441 - Only enable experiments for Beta/Prod 2019-11-04 16:45:35 -08:00
Richard Pappalardo
a17bb1d8dd [fenix] Temp disable all History UI tests (https://github.com/mozilla-mobile/fenix/pull/6443) 2019-11-04 15:25:29 -08:00
Emily Kager
a3f417eb98 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6369 - Use padding set from style for protection settings 2019-11-04 10:25:15 -08:00
Jeffrey Starke
2896a79805 [fenix] Use vector compat in TrackingProtectionPanelView (https://github.com/mozilla-mobile/fenix/pull/6376) 2019-11-04 10:04:02 -08:00
Richard Pappalardo
cdfba9536a [fenix] Temp disable flaky deleteMultipleSelectionTest (https://github.com/mozilla-mobile/fenix/pull/6405) 
* Temp disable flaky deleteMultipleSelectionTest

* Fix indentation
 2019-11-04 09:44:44 -08:00
liuche
0eb5656020 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6097 - Bump activation ping expiry date. (https://github.com/mozilla-mobile/fenix/pull/6309) 2019-11-01 14:06:44 -07:00
Christian Sadilek
49b95d6e1f [fenix] Use new WindowFeature API after browser-state migration 2019-11-01 15:52:37 -04:00
Mugurell
c3936f8fc8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Add tests for the new classes resulting from refactoring 
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
 2019-10-31 17:08:40 -07:00
Mugurell
35de878eae [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Document the newly introduced public APIs 
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
 2019-10-31 17:08:40 -07:00
Mugurell
9b1c705ca2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Handle all business logic with Interactors and a Controller 
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
 2019-10-31 17:08:40 -07:00
Mugurell
8f07c6fbf0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Refactor Views and layouts 
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
 2019-10-31 17:08:40 -07:00
mozilla-l10n-automation-bot
b3d6bc6f7b [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/6359) 2019-10-31 17:02:17 -07:00
ValentinTimisica
48489766a0 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5917: Show snackbar when URL is copied (https://github.com/mozilla-mobile/fenix/pull/6210) 
Show a snackbar to the user for him to know that the URL was copied to
clipboard.
 2019-10-31 16:53:00 -07:00
Tiger Oakes
41e1c322a6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6153 - Add powered by notification 2019-10-31 16:39:58 -07:00
Jeffrey Starke
a1e82286b6 [fenix] * Move repeated NavControllerTest logic to @Before set up method 
* Use property access syntax where applicable in NavControllerTest
 2019-10-31 16:28:02 -07:00
ValentinTimisica
6ec011b789 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6341: Initialize 'selectedTabs' based on opened/selected tabs. 
The problem was that the parameter 'selectedTabIds' was not taken into account
when initializing the variable 'selectedTabs'. So I made the initialization
based on both the selected tab and the number of open tabs.
 2019-10-31 16:22:14 -07:00
ValentinTimisica
5048bbad85 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6268: Change drawableTint from style to appcompat version. 
The property android:drawableTint doesn't work on older Android devices,
so I switched to the appcompat version (app:drawableTint).
 2019-10-31 16:09:49 -07:00
mcarare
f23d222bb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6342 Clicking add tab button from home screen finishes onboarding 2019-10-31 16:04:02 -07:00
Sawyer Blatz
65fa1e255d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5959 & https://github.com/mozilla-mobile/fenix/issues/5958: Integrates download feature into Fenix (https://github.com/mozilla-mobile/fenix/pull/6368) 2019-10-31 14:37:05 -07:00
mcarare
6f2df90bc2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1487 Add "my library" menu category and items to home 3-dot menu. 
Changed UI tests according to new menu items.
 2019-10-31 11:29:49 -07:00
mcarare
a79c7d3bb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1487 Add "my library" menu category and items to home 3-dot menu 2019-10-31 11:29:49 -07:00
Artur Dryomov
aa2d47a591 [fenix] No issue: Refactor errors to risk level conversion. (https://github.com/mozilla-mobile/fenix/pull/5710) 2019-10-30 11:08:45 -07:00
Sawyer Blatz
506fdc79a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Adds total_uri_count to metrics core ping (https://github.com/mozilla-mobile/fenix/pull/6003) 2019-10-30 11:02:33 -07:00
Sawyer Blatz
3aa5901ddf [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6344: Adds null check for adjust campaign (https://github.com/mozilla-mobile/fenix/pull/6348) 2019-10-30 10:13:03 -07:00
Chenxia Liu
5d32b6880c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6294 - When only one tab is being saved to collection, add it to selected tabs. 2019-10-29 11:27:51 -07:00
Sawyer Blatz
ed0d2c0c0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Fixes issue with Adjust campaign not sending through Glean (https://github.com/mozilla-mobile/fenix/pull/5896) 2019-10-29 10:09:07 -07:00
Oana Horvath
956b506474 [fenix] History menu UI tests (https://github.com/mozilla-mobile/fenix/pull/6272) 
Removed failing verifyOverflowMenuButton method

Added new Robot for MultipleSelectionTooolbar

Renamed MultipleSelectionToolbarRobot to LibrarySubMenusMultipleSelectionToolbarRobot
 2019-10-29 11:36:19 +02:00
Mozilla L10n Automation Bot
9a69ac4a44 [fenix] Import l10n. 2019-10-28 17:26:28 -07:00
No-Jun Park
e40b258890 [fenix] Collection UI Test added, but set to disabled until Collection is refactored (https://github.com/mozilla-mobile/fenix/pull/6160) 2019-10-28 15:10:19 -04:00
Mozilla L10n Automation Bot
24268de707 [fenix] Import l10n. 2019-10-28 10:04:12 -07:00
ValentinTimisica
b02410b154 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5128: Changed history_empty_view to match constraints. 
The bug occurred because the activity/fragment is not recreated on
orientation change. A simple fix was to just set width and height to 0dp
to let it match constraints.
 2019-10-28 09:44:03 -07:00
Christian Sadilek
b5ef6dbcfe [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5678: Selected session may render in ExternalAppBrowserActivity 2019-10-28 09:43:33 -07:00
isabelrios
4eb8ad16d0 [fenix] Fix sync test after changes in the syntaxt to check the elements (https://github.com/mozilla-mobile/fenix/pull/6249) 2019-10-28 11:31:32 -04:00
Mihai Branescu
9ffde8da1c [fenix] For https://github.com/mozilla-mobile/fenix/issues/5848 Wrong toolbar colour - edit bookmark fragment (https://github.com/mozilla-mobile/fenix/pull/6047) 
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
 2019-10-25 21:41:48 -07:00
Mihai Branescu
aa66b3e66e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5733 - Private mode notification - wrong home screen (https://github.com/mozilla-mobile/fenix/pull/6188) 
- added PRIVATE MODE intent extra to the notification action
 (could use also the OPEN_FROM_NOTIFICATION, but I considered this one to
 be more explicit. Kept the old one in case other checks will be done
 filtering for it)
- added intent? param to the getPrivateModeFromIntent method, because
onNewIntent() method does not set the activities intent, and it was needed
to be used both in onCreate() and onNewIntent()
 2019-10-25 21:41:31 -07:00
ValentinTimisica
799f009731 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5104: Cleanup - Use match_constraint instead of match_parent. 
Google officially recommends using match_constraint (equivalent to 0dp)
instead of match_parent when the view is contained in a ConstraintLayout.
https://developer.android.com/reference/android/support/constraint/ConstraintLayout#widgets-dimension-constraints
 2019-10-25 13:28:38 -07:00
ValentinTimisica
a33229584b [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5104: Changed empty_exception_container to match constraints. 
This bug occurs because the activity/fragment is not recreated on
orientation change. A simple fix was to just set width and height to 0dp
to let it match constraints.
 2019-10-25 13:28:38 -07:00
ekager
6f4fd33912 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6229 - Remove all tab options from custom tab context menu 2019-10-25 13:25:31 -07:00
Emily Kager
0a59e87224 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6219 - Reset default setting if user opts out of experiments 2019-10-25 12:50:16 -07:00
Mozilla L10n Automation Bot
9bd7b46ddb [fenix] Import l10n. 2019-10-25 10:19:49 -07:00
Mihai Branescu
2597e6134d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6179 - Changed positioning of private mode icons in tab he… (https://github.com/mozilla-mobile/fenix/pull/6189) 2019-10-25 08:09:38 -07:00
Jonathan Almeida
e5f9064701 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm" 
This reverts commit b1ce8ffcb7710fd98b692358309db42690593e11.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See https://github.com/mozilla-mobile/fenix/issues/6250 and https://github.com/mozilla-mobile/fenix/issues/6251 for related info.
 2019-10-25 10:24:40 -04:00
Mozilla L10n Automation Bot
be2d12beec [fenix] Import l10n. 2019-10-24 22:02:26 -07:00
Daphne Liu
916b172a77 [fenix] Add intent-filter to support nfc tags (https://github.com/mozilla-mobile/fenix/pull/6257) 2019-10-24 20:04:57 -07:00
Daphne Liu
ca0136985e [fenix] Replaced beta square icon with round icons (https://github.com/mozilla-mobile/fenix/pull/6261) 2019-10-24 20:04:49 -07:00
Sawyer Blatz
8314b378d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5737: Adds telemetry for open links in a private tab (https://github.com/mozilla-mobile/fenix/pull/5975) 2019-10-24 17:16:49 -07:00
Denys M
f69e53c92d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2441. Update LeakCanary to 2.0-beta-3 version. 2019-10-24 11:19:09 -07:00
wpanas
4447c7f9f0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6236: Fix padding lint issues (https://github.com/mozilla-mobile/fenix/pull/6240) 2019-10-24 10:52:30 -07:00
mcarare
438fbeb2cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Improve sync title/summary settings to support RTL 2019-10-24 10:32:59 -07:00
ekager
0c97d8780d [fenix] No issue: Sign in button style should be ThemeIndependentMaterialGreyButton 2019-10-24 10:32:29 -07:00
ekager
36de82bdc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
Mozilla L10n Automation Bot
c92b7dc1c0 [fenix] Import l10n. 2019-10-24 10:27:53 -07:00
RaviGarbuja
1edaa81b9b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6237: Change android:text to tools:text (https://github.com/mozilla-mobile/fenix/pull/6246) 2019-10-24 10:24:39 -07:00
Tiger Oakes
1562bce123 [fenix] Use tools:listitem with collection creation (https://github.com/mozilla-mobile/fenix/pull/6140) 2019-10-24 10:24:08 -07:00
psy0ch
7cc240bcd2 [fenix] Add explanation to @Ignore in CollectionTest (https://github.com/mozilla-mobile/fenix/pull/6238) 
https://github.com/mozilla-mobile/fenix/issues/6235
 2019-10-24 10:23:03 -07:00
obarzpaw
2a846964ca [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4558 Change height of bookmark linearlayout 2019-10-24 09:46:09 -07:00
Ardlan Khalili
0e1f235a20 [fenix] Closes 6168: Globe icon for exceptions 2019-10-24 09:44:49 -07:00
ValentinTimisica
2e3d0e1347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6145: Switch drawableTint to app compat version. (https://github.com/mozilla-mobile/fenix/pull/6151) 
The property android:drawableTint doesn't work on older Android devices,
so I switched to the appcompat version (app:drawableTint).
 2019-10-24 09:38:58 -07:00
Jeff Boek
e6af25acca [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adjust padding to be visually consistent with the separator 2019-10-24 09:35:21 -07:00
Jeff Boek
212d63ec39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adds accessibility setting to force enable zoom 2019-10-24 09:35:21 -07:00
Alessio Placitelli
9d544a27e8 [fenix] Pick up forUnitTest library for the Glean SDK test 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
a81a60183d [fenix] Update to Mozilla Android Components 19.0.0-SNAPSHOT. 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
e9d21e9799 [fenix] Use new toolbar API of AC 18.0.0. 2019-10-24 08:57:30 -07:00
Sawyer Blatz
893c08050f [fenix] No issue: Fixes string issues for l10n (https://github.com/mozilla-mobile/fenix/pull/6158) 
Issues found here: https://github.com/mozilla-l10n/android-l10n/pull/89
 2019-10-24 08:24:19 -07:00
Aaron Train
aa400955a6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6172 - Convert waitNotNull into extension function for UI tests (https://github.com/mozilla-mobile/fenix/pull/6220) 2019-10-23 17:40:28 -04:00
MozLando
961254df94 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5332 
5332: For https://github.com/mozilla-mobile/fenix/issues/2483 https://github.com/mozilla-mobile/fenix/issues/2629: Close tab with no history on back press and return to parent if available r=ekager a=mawen7



Co-authored-by: mawen7 <mawen7@users.noreply.github.com>
 2019-10-23 18:20:36 +00:00
Severin Rudie
69406b4230 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3676: fix duplicate uri events on first load (https://github.com/mozilla-mobile/fenix/pull/6128) 2019-10-23 10:21:46 -07:00
Aaron Train
16eebc77c9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6031 - Wrap waits with assert check; adjust timer check (https://github.com/mozilla-mobile/fenix/pull/6084) 
See https://github.com/mozilla-mobile/fenix/issues/6031

- Adjust waits with assert check
- Adjusts timer to speed things up
- Test fix and cleanup

fix: review comments

- fixed proper resource name selectors
- re-added waits for slow devices

fix: ktlint
 2019-10-23 10:55:19 -04:00
mawen7
73f5f00aeb [fenix] Close tab with no history on back press and return to parent if available 2019-10-23 12:54:28 +02:00
liuche
b2419592ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/4947 - Add Fenix Beta icons. (https://github.com/mozilla-mobile/fenix/pull/6173) 2019-10-22 18:10:39 -07:00
Severin Rudie
1c34781659 [fenix] https://github.com/mozilla-mobile/fenix/issues/4596 migrate collections (https://github.com/mozilla-mobile/fenix/pull/5911) 
* For https://github.com/mozilla-mobile/fenix/issues/4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
 2019-10-22 17:33:54 -07:00
Pawel Obarzanek
1949400621 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the book… (https://github.com/mozilla-mobile/fenix/pull/6137) 
* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the bookmark toolbar

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Changed raw string to string resources

* Pass bookmark arguments to share fragment

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 add orEmpty
 2019-10-22 14:34:05 -07:00
Tiger Oakes
8f91658907 [fenix] Refactor asCamelCase to use string builder (https://github.com/mozilla-mobile/fenix/pull/6141) 2019-10-22 14:33:44 -07:00
Sebastian Kaspari
e4c7bb08d4 [fenix] Issue #36170: BaseBrowserFragment: Use new feature-prompts API. 2019-10-22 16:04:33 -04:00
Grisha Kruglov
3e5c5d9514 [fenix] Perform Fennec data migration within fennecProduction 2019-10-22 16:04:08 -04:00
Tiger Oakes
0af2e9d821 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3366 - Use one layout for edit/add bookmark (https://github.com/mozilla-mobile/fenix/pull/5900) 2019-10-21 10:06:08 -07:00
Mitchell Hentges
cf0265e3b1 [fenix] Removes versionName check from gradle (https://github.com/mozilla-mobile/fenix/pull/5934) 2019-10-21 10:03:21 -07:00
Sören Hentzschel
3bc81481c5 [fenix] for https://github.com/mozilla-mobile/fenix/issues/6008 - fix address bar layout on home fragment for RTL (https://github.com/mozilla-mobile/fenix/pull/6016) 2019-10-21 10:02:13 -07:00
Sören Hentzschel
fe2879ff45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6011 - fixed truncated clipboard icon in RTL (https://github.com/mozilla-mobile/fenix/pull/6017) 2019-10-21 10:01:51 -07:00
isabelrios
e6e5ab6ffb [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks (https://github.com/mozilla-mobile/fenix/pull/6019) 
* Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks

* fix two typos
 2019-10-21 10:01:17 -07:00
Mihai Adrian
bb0d3150c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1383: Fix updating description of close button on title change. (https://github.com/mozilla-mobile/fenix/pull/6020) 2019-10-21 10:00:26 -07:00
ValentinTimisica
8790a8a68e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5030: Modified Dialog to match the others. (https://github.com/mozilla-mobile/fenix/pull/6022) 
I changed the Dialog from permissions exceptions and used AlertDialog
instead of Context.alert extension function.
 2019-10-21 09:59:04 -07:00
Mihai Branescu
4dda232d0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6063 - changed ETP blocking info title strings (https://github.com/mozilla-mobile/fenix/pull/6082) 2019-10-21 09:58:47 -07:00
Shangeeth Sivan
f274b65859 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5465: Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled (https://github.com/mozilla-mobile/fenix/pull/6098) 2019-10-21 09:57:29 -07:00
ValentinTimisica
8532908d51 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5323: Show a snackbar while browsing data is deleting. (https://github.com/mozilla-mobile/fenix/pull/6105) 2019-10-21 09:57:06 -07:00
Jeffrey Starke
55ed9cbe2c [fenix] Don't show fingerprinters section of the standard tracking policy UI (https://github.com/mozilla-mobile/fenix/pull/6125) 2019-10-21 09:56:46 -07:00
Sören Hentzschel
4ca4f775fb [fenix] fixed alignment of open tabs header for RTL languages (https://github.com/mozilla-mobile/fenix/pull/6138) 2019-10-21 09:53:21 -07:00
Sören Hentzschel
4c2c5c5e21 [fenix] no issue - removed unused feature flags (https://github.com/mozilla-mobile/fenix/pull/6143) 2019-10-21 09:52:01 -07:00
Richard Pappalardo
1839ce12f1 [fenix] Add verify items tests for settings menus 2019-10-21 08:24:47 -07:00
Mozilla L10n Automation Bot
8c048ac40f [fenix] Import l10n. 2019-10-19 17:40:27 +00:00
MozLando
06da598c96 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6102 https://github.com/mozilla-mobile/fenix/pull/6106 
6102: For https://github.com/mozilla-mobile/fenix/issues/6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai



6106: For https://github.com/mozilla-mobile/fenix/issues/5872 & https://github.com/mozilla-mobile/fenix/issues/6075: Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare

At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-18 18:59:20 +00:00
MozLando
eefbdfc912 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6107 
6107: Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment r=boek a=Mugurell

Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.



Co-authored-by: Mugurell <mugurell@users.noreply.github.com>
 2019-10-18 18:34:49 +00:00
Tiger Oakes
1eac564f52 [fenix] Cleanup shortcut code 2019-10-18 10:57:51 -07:00
Tiger Oakes
d5c8f813d3 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5225 - Hide AuthCustomTabActivity 2019-10-18 10:56:06 -07:00
MozLando
cecf51baab [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6046 
6046: Update to Mozilla Android Components 18.0.0-SNAPSHOT. r=Baron-Severin a=pocmo

We haven't updated in a while and therefore some fixes didn't make it into Fenix (Nightly) yet.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
 2019-10-18 16:36:33 +00:00
Sebastian Kaspari
82d20a0c40 [fenix] Update to Mozilla Android Components 18.0.0-SNAPSHOT. 2019-10-18 17:54:05 +02:00
mcarare
18779c6f31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5872 & https://github.com/mozilla-mobile/fenix/issues/6075: Set TabHeader buttons to invisible instead of gone. 
At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.
 2019-10-18 17:00:26 +03:00
Mihai Branescu
e5aa6fed30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6018 - Added unit tests for interactor and controller 2019-10-18 15:43:39 +03:00
mcarare
5cc2013926 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6100: Mirror ETP graphic in RTL 2019-10-18 15:24:49 +03:00
Mihai Branescu
b984591154 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6018 - Added back shortcuts button in awesomebar 
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
 2019-10-18 14:48:58 +03:00
Mugurell
11acd9849c [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment 
Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.
 2019-10-18 08:11:56 +03:00
MozLando
93bf73cbcd [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6038 
6038: ExtTest for BookmarkNode r=mcomella a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-10-17 20:39:35 +00:00
Kate Glazko
d94c0a22f9 [fenix] ExtTest for BookmarkNode 2019-10-17 12:54:03 -07:00
MozLando
a591094ca2 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6026 
6026: For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-16 17:49:16 +00:00
MozLando
1cc1b164c0 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6024 
6024: For https://github.com/mozilla-mobile/fenix/issues/5749 - Update string for ETP onboarding popup r=ekager a=BranescuMihai



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
 2019-10-16 00:12:52 +00:00
MozLando
a459011003 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6025 https://github.com/mozilla-mobile/fenix/pull/6032 
6025: For https://github.com/mozilla-mobile/fenix/issues/5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica

Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.



6032: For https://github.com/mozilla-mobile/fenix/issues/5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk

Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed.

For https://github.com/mozilla-mobile/fenix/issues/5990.



Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2019-10-15 21:31:38 +00:00
MozLando
a7c9ccbedc [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5974 
5974: Ext Test For ImageButton r=mcomella a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-10-15 19:31:47 +00:00
Grisha Kruglov
2f19a82c91 [fenix] Revert sessionScopeToken to fix broken QR pairing flow 2019-10-15 11:19:40 -07:00
mcarare
c1dc44370a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP onboarding popup implementation with original mocks 2019-10-15 17:07:47 +03:00
ValentinTimisica
c01d3dc000 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5063: Added parameter customTabSessionId into ContextMenuFeature 
Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.
 2019-10-15 16:28:42 +03:00
Mihai Branescu
71803d9859 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5749 - Update string for ETP onboarding popup 2019-10-15 15:56:59 +03:00
MozLando
d953218319 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5949 
5949: Import strings from android-l10n r=liuche a=mozilla-l10n-automation-bot

n/t

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
 2019-10-15 03:53:27 +00:00
MozLando
e70293217c [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5775 
5775: Closes https://github.com/mozilla-mobile/fenix/issues/5233, don't display private-browsing-shortcut creation items if shortcut already exists r=NotWoods a=bswe

Closes issue https://github.com/mozilla-mobile/fenix/issues/5233:

Added doesPrivateBrowsingPinnedShortcutExist() method to the PrivateShortcutCreateManager class to check for the existence of the shortcut.  Code only works on devices with API 25 or higher, so a check for that condition was also included in the new method.

Calls to the new method were added to the SettingsFragment and HomeFragment classes to determine whether the settings menu item and the recommendation dialog should be displayed.

**Quality**: The pre-push test failed to start on my windows 10 OS, but this code has been thoroughly tested manually on simulators and physical devices.

**Tests**: This code only effects UI appearance so not sure how to test for that and no tests were written.

**Screenshots**: This code does not add anything new to the UI, it only controls whether to display existing items.

Co-authored-by: bswe <bbollenbacher@mindspring.com>
 2019-10-14 22:23:45 +00:00
Kate Glazko
9a2bb97270 [fenix] Ext Test For ImageButton 2019-10-14 13:30:39 -07:00
MozLando
48a00a9472 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5976 https://github.com/mozilla-mobile/fenix/pull/5999 
5976: No issue: Update androidx fragment Oct 11 r=boek a=ekager



5999: For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP Settings Screen implementation with original mocks r=NotWoods a=mcarare



Co-authored-by: ekager <emilykager@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-14 19:28:43 +00:00
ekager
3978c2d797 [fenix] No issue: Remove black flash workaround 2019-10-14 11:51:01 -07:00
bswe
af12dedbf8 [fenix] Reformatting to simplify use of .any construct as suggested in review 2019-10-14 11:20:19 -07:00
bswe
92e2b65f5e [fenix] Reformatting to use .any construct as suggested in review 2019-10-14 11:20:19 -07:00
bswe
35eabc4579 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Minor modifications suggested in code review. 2019-10-14 11:20:18 -07:00
bswe
aea1af9c82 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed. 2019-10-14 11:20:17 -07:00
bswe
d9bbb0a486 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu. 2019-10-14 11:20:17 -07:00
bswe
ba7b54708b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233: Added doesPrivateBrowsingPinnedShortcutExist function to determine whether a shortcut already exists (only available in API >=25). 2019-10-14 11:07:34 -07:00
MozLando
01fb7c04c6 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5908 
5908: Closes https://github.com/mozilla-mobile/fenix/issues/5876: Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: shldhll <iam.shldhll@gmail.com>
 2019-10-14 16:52:22 +00:00
MozLando
8573e2e13e [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5973 
5973: For https://github.com/mozilla-mobile/fenix/issues/5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2019-10-14 16:16:47 +00:00
mcarare
3bb7e5b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709: Align ETP Settings Screen implementation with original mocks 2019-10-14 15:59:43 +03:00
Mozilla L10n Automation Bot
4d9d1b6585 [fenix] Import l10n. 2019-10-13 20:01:13 +00:00
Sawyer Blatz
43b51ff997 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5898: Launch SUMO article properly for default browser 2019-10-11 14:40:08 -07:00
MozLando
a05afed1dc [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5956 
5956: For https://github.com/mozilla-mobile/fenix/issues/5947 - Fix engineView NullPointerException r=csadilek a=ekager



Co-authored-by: ekager <emilykager@gmail.com>
 2019-10-11 21:08:09 +00:00
MozLando
cd489f765a [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5933 
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges



Co-authored-by: Mitchell Hentges <mhentges@mozilla.com>
 2019-10-11 18:28:31 +00:00
MozLando
df858f2f3b [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5507 https://github.com/mozilla-mobile/fenix/pull/5846 
5507: For https://github.com/mozilla-mobile/fenix/issues/1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-11 16:28:36 +00:00
ekager
43b16718af [fenix] For https://github.com/mozilla-mobile/fenix/issues/5947 - Fix engineView NullPointerException 2019-10-11 09:03:24 -07:00
MozLando
66e7638fb7 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5633 
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
 2019-10-11 14:43:39 +00:00
MozLando
ffa56e994f [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5882 
5882: For https://github.com/mozilla-mobile/fenix/issues/5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-11 13:22:33 +00:00
Mihai Adrian
6875fa017a [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode (https://github.com/mozilla-mobile/fenix/pull/5699) 
Removed items from RecyclerView cache to allow setting the new visibility
Disabled hidden buttons, otherwise they could still be clicked
 2019-10-10 23:02:22 -07:00
Mozilla L10n Automation Bot
5e6b47c19b [fenix] Import l10n. 2019-10-10 22:54:54 -07:00
Sawyer Blatz
3cd8b5cf30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5094: Adds telemetry for show search shortcuts 2019-10-10 22:52:41 -07:00
shldhll
9e04abdaee [fenix] Added required coroutines in tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-11 00:01:07 +05:30
Sawyer Blatz
2bafd3ea24 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5898: Default browser toggle sends user to SUMO on Android 5&6 (https://github.com/mozilla-mobile/fenix/pull/5918) 2019-10-10 11:16:21 -07:00
Mitchell Hentges
4bd3882edb [fenix] Removes legacy nightly automation 2019-10-10 11:13:23 -07:00
Mugurell
68a70eaa77 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3584 - Check if menu is open before showing a new one (https://github.com/mozilla-mobile/fenix/pull/5674) 
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
 2019-10-10 06:37:47 -07:00
shldhll
1b36368c82 [fenix] Removed ObsoleteCoroutinesApi from share tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 06:40:20 +05:30
shldhll
d3ddb95701 [fenix] Fixed imports. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 06:27:14 +05:30
Grisha Kruglov
4361ea23c7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5913: Add new sessionToken scope 2019-10-09 17:44:41 -07:00
shldhll
57a6bf6c7b [fenix] Optimized imports. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 04:17:43 +05:30
shldhll
4e37ba2bcf [fenix] Removed ObsoleteCoroutinesApi in tests. Closes https://github.com/mozilla-mobile/fenix/issues/5876 2019-10-10 04:04:51 +05:30
Jeff Boek
d09494613a [fenix] For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm 2019-10-09 14:43:48 -07:00
Christian Sadilek
c853454896 [fenix] For https://github.com/mozilla-mobile/fenix/issues/778: Follow-up to fix find in page 2019-10-09 17:14:14 -04:00
Emily Kager
b36c9c67dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/1901 - Get rid of black flash when leaving GV Engine 2019-10-09 11:02:21 -07:00
Tiger Oakes
90d9e14b9c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/394 - Trusted Web Activities (https://github.com/mozilla-mobile/fenix/pull/5391) 2019-10-09 09:17:49 -07:00
Ahmed I. Khalil
b3ada93697 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5852 - Use createAddedTestFragments in tests. 2019-10-09 08:51:52 -07:00
mcarare
02d018ad89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5873 Added on/off indicator for delete browsing data on exit pref 2019-10-09 11:55:37 +03:00
Michael Droettboom
eefa0e927f [fenix] Add glinter overrides 2019-10-08 21:40:20 -07:00
Mozilla L10n Automation Bot
fd73db11e4 [fenix] Import l10n. 2019-10-08 21:38:24 -07:00
Roger Yang
03534c00c2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5847: Use IO thread when submitting crash report 2019-10-08 18:46:14 -07:00
Tiger Oakes
590eff81c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/778 - Progressive Web Apps! (https://github.com/mozilla-mobile/fenix/pull/4914) 2019-10-08 16:50:15 -07:00
Sawyer Blatz
129951e3a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5534: Temporarily disables find in page test 2019-10-08 16:17:38 -07:00
Tiger Oakes
30af9d17cd [fenix] Remove @ObsoleteCoroutinesApi from TestCore 2019-10-08 15:49:40 -07:00
Severin Rudie
1acb0b6ddc [fenix] For 4780: add DefaultBrowsingModeManager tests 2019-10-08 15:13:17 -07:00
Severin Rudie
1d9b41c167 [fenix] For 4780: remove Settings#usePrivateMode and tests 2019-10-08 15:13:17 -07:00
Severin Rudie
691c47d576 [fenix] For 4780: ThemeManager now sends an intent before recreating 
Updating themes recreates the activity, so if we aren't persisting 'usePrivateMode', we need to pass it to the new instance
 2019-10-08 15:13:17 -07:00
Severin Rudie
17e9a4e5c9 [fenix] For 4780: rename 'setPrivateModeIfNecessary' 2019-10-08 15:13:17 -07:00
Severin Rudie
3128209d65 [fenix] For 4780: update HomeActivity to maintain private mode in memory 
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit.  They previously would have broken if called in reverse order, now it will fail to compile.
 2019-10-08 15:13:17 -07:00
Severin Rudie
15cd1c5d9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4780: remove previous fix for leaking private mode status 
This didn't function when 'open links in a private tab' was set.  Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
 2019-10-08 15:13:17 -07:00
Aaron Train
c5195c9a46 [fenix] No issue: fixes refreshTest (https://github.com/mozilla-mobile/fenix/pull/5792) 2019-10-08 12:20:04 -04:00
Sawyer Blatz
f0751362f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4190: Removes waterfall animation from awesomebar 2019-10-08 09:14:23 -07:00
Sawyer Blatz
5c43aa6a06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5787: Fixes shortcuts asking to launch private alias (https://github.com/mozilla-mobile/fenix/pull/5825) 2019-10-08 08:40:28 -07:00
mcarare
57169406de [fenix] For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted 2019-10-08 17:06:02 +03:00
Mihai Adrian
909467184c [fenix] For https://github.com/mozilla-mobile/fenix/issues/5798: Fix info icon pixelation (https://github.com/mozilla-mobile/fenix/pull/5841) 2019-10-08 09:30:32 -04:00
isabelrios
785c89743a [fenix] fixing more reviewers comments 2019-10-08 09:56:29 +02:00
isabelrios
67661747f3 [fenix] fixing reviewers comments 
improve writing email and password in file
 2019-10-08 09:56:29 +02:00
isabelrios
a161afd41e [fenix] Fix TC error and run only ui tests 2019-10-08 09:56:29 +02:00
Isabel Rios
339524226a [fenix] Add fxa/sync integration tests 
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
 2019-10-08 09:56:29 +02:00
Grisha Kruglov
6e6d2ec9c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1022: Auto-publication workflow for android-component 
This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
 2019-10-07 14:13:33 -07:00
Vipul Asri
a02d73ad4b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5573: fix radio-button spacing in settings 2019-10-07 13:07:53 -07:00
Tiger Oakes
c563798ffe [fenix] Use the new fragment constructor 2019-10-07 11:07:48 -07:00
sv-ohorvath
92ac8a2042 [fenix] Boomkarks UI tests 
Added a comment to the clear all bookmarks method
 2019-10-07 10:45:04 -07:00
Michael Droettboom
1687b09ba0 [fenix] Update bug numbers to URLs 2019-10-07 10:44:11 -07:00
Denys M
55f265945f [fenix] For https://github.com/mozilla-mobile/fenix/issues/3563. Use ListAdapter for App Share list. 2019-10-07 10:41:48 -07:00
Denys M
a179403303 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3563. Use ListAdapter for Bookmark folder selection list. 2019-10-07 10:40:55 -07:00
Madalin Valceleanu
5b82099137 [fenix] Fix the incognito icon looks out of place/misaligned 2019-10-07 10:15:11 -07:00
ekager
d82d16c98c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3846 - Pass in updated session icon to tabs 2019-10-07 09:38:43 -07:00
Tiger Oakes
5987f316a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5213 - Use support library attributes 2019-10-06 16:17:00 -07:00
Prat T
d5487d6510 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5351 - listen to onIconChanged in HomeFragment 2019-10-06 10:41:34 -07:00
Prat T
30848fa66c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5351 - use session icon in tab view on home 2019-10-06 10:41:34 -07:00
Emily Kager
ba3359053a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5651 - Set up Standard vs Strict Tracking Protection Experiment 2019-10-05 10:14:09 -07:00
Sawyer Blatz
c95cc76dee [fenix] For https://github.com/mozilla-mobile/fenix/issues/1620: Hide search results when they match URL 2019-10-04 14:05:55 -07:00
mcarare
113af874ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/5784: Fix hiding default browser preference in sdk<=23 2019-10-04 12:41:12 -07:00
Colin Lee
a925cc246d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection (https://github.com/mozilla-mobile/fenix/pull/5716) 
* For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection

* For https://github.com/mozilla-mobile/fenix/issues/5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
 2019-10-04 12:28:23 -05:00
Emily Kager
d008018d31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5442 - Show Delete Browsing Data on Quit option in home menu 2019-10-04 09:26:59 -07:00
Sawyer Blatz
5581b61e60 [fenix] No issue: fixes master (https://github.com/mozilla-mobile/fenix/pull/5777) 2019-10-03 14:42:56 -07:00
Sawyer Blatz
dee2e653dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/514 & https://github.com/mozilla-mobile/fenix/issues/5742: Updates "launch links in private tab" functionality (https://github.com/mozilla-mobile/fenix/pull/5721) 
* For https://github.com/mozilla-mobile/fenix/issues/514 & https://github.com/mozilla-mobile/fenix/issues/5742: Updates "launch links in private tab" functionality

* Fixes comments
 2019-10-03 12:43:33 -07:00
Madalin Valceleanu
320bfabca6 [fenix] Fix too much space under the address bar 2019-10-03 11:30:03 -07:00
Christian Sadilek
edd9e49e01 [fenix] Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT 2019-10-03 11:07:26 -07:00
Severin Rudie
e8aecbb458 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4780 switch off private mode (https://github.com/mozilla-mobile/fenix/pull/5614) 
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue https://github.com/mozilla-mobile/fenix/issues/4780: add comments to use private mode

* For https://github.com/mozilla-mobile/fenix/issues/4780: write tests for clear private mode on create app

* For https://github.com/mozilla-mobile/fenix/issues/4780: clear private mode when privacy notification is removed
 2019-10-03 10:23:13 -07:00
Sawyer Blatz
d9881d8211 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5094: Adds telemetry for suggestion toggles (https://github.com/mozilla-mobile/fenix/pull/5704) 2019-10-03 10:03:14 -07:00
Sawyer Blatz
f4d0b1043b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5742: Adds strings (https://github.com/mozilla-mobile/fenix/pull/5743) 2019-10-03 09:32:50 -07:00
Sawyer Blatz
e3d58b1676 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5567: Removes search shortcuts button (https://github.com/mozilla-mobile/fenix/pull/5739) 
* For https://github.com/mozilla-mobile/fenix/issues/5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
 2019-10-03 08:53:16 -07:00
Richard Pappalardo
ad8e2d1d2f [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5758 - Increase UI test wait time (https://github.com/mozilla-mobile/fenix/pull/5759) 2019-10-03 07:54:10 -07:00
Sawyer Blatz
37254bd908 [fenix] No issue: Updates naming of launch links privately var (https://github.com/mozilla-mobile/fenix/pull/5701) 
The previous name was pretty confusing
 2019-10-02 12:11:21 -07:00
Sawyer Blatz
1b6eb35082 [fenix] No issue: Removes feature flags for delete data (https://github.com/mozilla-mobile/fenix/pull/5738) 2019-10-02 10:43:37 -07:00
Sawyer Blatz
ced9d7f9f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5712: Updates text color for fill link from clipboard 2019-10-01 16:29:39 -07:00
Emily Kager
b87e6d8267 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3487 - Add back open image in new tab 2019-10-01 12:45:09 -07:00
Michael Droettboom
4cd834ef2a [fenix] 1585250: Initialize metrics off of the main thread 2019-10-01 10:29:54 -07:00
Sawyer Blatz
08ab9e8d47 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5672: Fixes broken send tab link 2019-09-30 16:13:40 -07:00
Axel Hecht
71b89245d7 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@10559d774c
 2019-09-30 16:10:08 -07:00
Sawyer Blatz
bc4e241dc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5681: Sets OPEN_TO_BROWSER false when using new tab shortcut 2019-09-30 14:56:16 -07:00
ekager
4d5fdffdb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5534 - Make FIP Robot Wait for Text Changes 2019-09-30 13:17:29 -07:00
Emily Kager
1aa1291d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/2078 - Filter Out Self in Share Sheet (https://github.com/mozilla-mobile/fenix/pull/5641) 2019-09-30 12:43:47 -07:00
Sawyer Blatz
17e0c7a2f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5679: Hides autoplay behind feature flag (https://github.com/mozilla-mobile/fenix/pull/5685) 2019-09-30 12:01:04 -07:00
ekager
1196a64989 [fenix] Update BackgroundServicesTest, Suppress Complex Method 2019-09-30 10:33:56 -07:00
Grisha Kruglov
8970474e62 [fenix] FxA WebChannels integration 
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2019-09-30 10:33:56 -07:00
Chenxia Liu
774bf91112 [fenix] For https://github.com/mozilla-mobile/fenix/issues/235 - Add Glean crash count + docs. 2019-09-30 08:32:33 -07:00
Sawyer Blatz
f8e50b6fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
Sawyer Blatz
04db9191f2 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5653: Removes crash with null campaign 2019-09-27 15:01:00 -07:00
mcarare
d182550fbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
Sawyer Blatz
a578ad534b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4474: Adds tests and fixes issues 2019-09-27 08:59:05 -07:00
Tiger Oakes
e3d7c77c2f [fenix] No issue: Move signedIn tracking to BookmarksSharedViewModel (https://github.com/mozilla-mobile/fenix/pull/4755) 2019-09-27 08:57:38 -07:00
Sawyer Blatz
a95d6d58d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Adds adjustCampaignId to core ping (https://github.com/mozilla-mobile/fenix/pull/5579) 2019-09-27 08:56:33 -07:00
Sawyer Blatz
1519dbf668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5197: Adds telemetry for media notification (https://github.com/mozilla-mobile/fenix/pull/5520) 2019-09-27 08:02:29 -07:00
Tiger Oakes
5a5913265f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4711 - Extract VoiceSearchActivity (https://github.com/mozilla-mobile/fenix/pull/5502) 2019-09-27 07:54:29 -07:00
Emily Kager
bb48b2d28f [fenix] No issue: Update navigation library 2019-09-26 17:01:13 -07:00
Sawyer Blatz
ad743e6028 [fenix] No issue: Updates fact mapping to use enums 2019-09-26 17:00:51 -07:00
Emily Kager
3f59746bdd [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5624 - Fix crash on preference change listener 2019-09-26 16:56:54 -07:00
Mihai Adrian
04b58326e9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks (https://github.com/mozilla-mobile/fenix/pull/5559) 
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
 2019-09-26 16:52:59 -07:00
Severin Rudie
fe159a657e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: fixes bookmark tests broken by loading change 
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
 2019-09-26 16:29:14 -07:00
Severin Rudie
319ebf93e4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: adds tests for bookmark loading state 2019-09-26 16:29:14 -07:00
Severin Rudie
b3c31751f5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4513: show progress bar when loading bookmarks 2019-09-26 16:29:14 -07:00
Severin Rudie
e7ad50b4fe [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: added isLoading to bookmark state 
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.

For now, we set isLoading to false whenever we receive any bookmarks
 2019-09-26 16:29:14 -07:00
Severin Rudie
a2f8c14f03 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: add ProgressBar to bookmark component layout 2019-09-26 16:29:14 -07:00
Severin Rudie
e2b3b1bb6f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4513: fix mismatched bookmark listener lifecycles 
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
 2019-09-26 16:29:14 -07:00
Colin Lee
28d64cdd9e [fenix] For https://github.com/mozilla-mobile/fenix/issues/2754 Add tab cards to share sheet (https://github.com/mozilla-mobile/fenix/pull/5493) 
* For https://github.com/mozilla-mobile/fenix/issues/2754 Add tab cards to share sheet

* For https://github.com/mozilla-mobile/fenix/issues/2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
 2019-09-26 14:25:34 -07:00
Christian Sadilek
462e4c6201 [fenix] Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (https://github.com/mozilla-mobile/fenix/pull/5578) 
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
 2019-09-26 12:50:50 -07:00
Mugurell
a87ab2275c [fenix] For 5092 - Show a Snackbar with retry option if sharing to devices fails (https://github.com/mozilla-mobile/fenix/pull/5158) 
* For https://github.com/mozilla-mobile/fenix/issues/5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For https://github.com/mozilla-mobile/fenix/issues/5092 - Refactor ShareControllerTest

* For https://github.com/mozilla-mobile/fenix/issues/5092: Adds color theming of snackbars
 2019-09-26 12:30:28 -07:00
Yeon Taek Jeong
59c6b7725e [fenix] No issue: Update long-press shortcut strings (https://github.com/mozilla-mobile/fenix/pull/5284) 
* No issue: Update long-press shortcut strings

* Updates identifiers
 2019-09-26 11:57:37 -07:00
ekager
3783f94347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2874, https://github.com/mozilla-mobile/fenix/issues/5375, https://github.com/mozilla-mobile/fenix/issues/5131 - submitList workaround for Android 5 + 6 2019-09-25 19:59:07 -07:00
Agi Sferro
4d975044c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5529: Enable about:config in geckoNightly. 2019-09-25 16:17:09 -07:00
ekager
2a99e9c69e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5312 - Send ETP Strict/Standard event 2019-09-25 15:23:30 -07:00