mirror of
https://github.com/fork-maintainers/iceraven-browser
synced 2024-11-03 23:15:31 +00:00
e70293217c
5775: Closes https://github.com/mozilla-mobile/fenix/issues/5233, don't display private-browsing-shortcut creation items if shortcut already exists r=NotWoods a=bswe Closes issue https://github.com/mozilla-mobile/fenix/issues/5233: Added doesPrivateBrowsingPinnedShortcutExist() method to the PrivateShortcutCreateManager class to check for the existence of the shortcut. Code only works on devices with API 25 or higher, so a check for that condition was also included in the new method. Calls to the new method were added to the SettingsFragment and HomeFragment classes to determine whether the settings menu item and the recommendation dialog should be displayed. **Quality**: The pre-push test failed to start on my windows 10 OS, but this code has been thoroughly tested manually on simulators and physical devices. **Tests**: This code only effects UI appearance so not sure how to test for that and no tests were written. **Screenshots**: This code does not add anything new to the UI, it only controls whether to display existing items. Co-authored-by: bswe <bbollenbacher@mindspring.com> |
||
|---|---|---|
| .. | ||
| src | ||
| .gitignore | ||
| build.gradle | ||
| lint.xml | ||
| metrics.yaml | ||
| pings.yaml | ||
| proguard-rules.pro | ||