Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity
6,690 Commits 67 Branches 113 Tags 1.2 GiB
84a2627f91
Commit Graph

5624 Commits

Author SHA1 Message Date
Roger Yang
cf70cb61b3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18946: Add undo toast for tabstray 2021-04-17 02:30:39 +04:00
Michael Comella
5d92d409e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: address onCreate method length detekt issue. 2021-04-16 15:30:26 -07:00
Michael Comella
e83004d81b [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add & integrate StartupTypeTelemetry. 2021-04-16 15:30:26 -07:00
Michael Comella
c7f94915cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add metric perf.startup.startup_type. 2021-04-16 15:30:26 -07:00
Michael Comella
1035ad0fd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupPathProvider + tests. 2021-04-16 15:30:26 -07:00
Michael Comella
bdca7337ce [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: address lint errors for StartupStateProvider*. 2021-04-16 15:30:26 -07:00
Michael Comella
825e035db6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add getStartupStateForStartedActivity method. 2021-04-16 15:30:26 -07:00
Michael Comella
4adb237b88 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add isHotStartForStartedActivity and tests. 2021-04-16 15:30:26 -07:00
Michael Comella
b7e04b6590 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add isWarmStartForStartedActivity, tests. 2021-04-16 15:30:26 -07:00
Michael Comella
d7ad0bb813 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: shorten isColdStart... and rm questionable test. 
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
 2021-04-16 15:30:26 -07:00
Michael Comella
895f8efe13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add VIEW to warm and hot entries. 2021-04-16 15:30:26 -07:00
Michael Comella
f5943d894c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor tests to forEachHotStartEntries. 2021-04-16 15:30:26 -07:00
Michael Comella
ca1364f3b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor test into forEachWarmStartEntries. 2021-04-16 15:30:26 -07:00
Michael Comella
e7d166052c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: refactor tests into forEachColdStartEntries. 2021-04-16 15:30:26 -07:00
codrut.topliceanu
2b69fd5b2a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19023 - Expands tabsTray when tabs over certain number 
TabsTray should be collapsed when there are only a few tabs on screen, otherwise it should go straight to STATE_EXPANDED.
 2021-04-16 23:35:14 +04:00
Julien Cristau
b2a420f624 [fenix] Update A-C to 75.0.20210415213638 2021-04-16 12:01:51 -04:00
Mugurell
c2a4f16fe8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18439 - Open link from QR code only if activity is not null 2021-04-16 13:08:01 +03:00
Kate Glazko
68b17ba7e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18520: Add Empty Tab State To Browser Tray List 2021-04-16 05:22:44 +04:00
Mozilla L10n Automation Bot
d57bcda8ef [fenix] Import l10n. 2021-04-16 00:29:09 +00:00
Jonathan Almeida
2ce93ef3a4 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19024: Fix intermittent test failure in NavigationInteractor 2021-04-16 02:34:23 +04:00
Jonathan Almeida
da6cd0c128 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19030: Allow homescreen to be scrollable with extra content 2021-04-16 02:33:53 +04:00
Jonathan Almeida
4f95404df6 [fenix] No issue: Set tray dismissal from background tap 2021-04-16 02:31:13 +04:00
Jonathan Almeida
c6b9bf80d5 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19045: Dismiss tabstray when last tab in a page is closed 2021-04-16 02:31:13 +04:00
Elise Richards
395853235f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18867: remove "signed in as" string in three-dot menu (https://github.com/mozilla-mobile/fenix/pull/19035) 
* Remove signed in as string from sync menu item

* Nav to sync account settings on click

For https://github.com/mozilla-mobile/fenix/issues/18806: navigate to settings account page or sign in on clicking menu item.

* Confirm account exists and retrieve item title

* Remove string
 2021-04-15 12:49:19 -05:00
Christian Sadilek
f134595809 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18819: Hide Credit Card pref by default (for settings w/o icons) (https://github.com/mozilla-mobile/fenix/pull/19058) 2021-04-15 13:29:22 -04:00
Gabriel Luong
fd0b41c798 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information (https://github.com/mozilla-mobile/fenix/pull/19032) 2021-04-15 12:40:48 -04:00
Gabriel Luong
baea2cdf4d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card (https://github.com/mozilla-mobile/fenix/pull/19029) 2021-04-15 11:18:29 -04:00
Codrut Topliceanu
1c24731b4f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab (https://github.com/mozilla-mobile/fenix/pull/19021) 
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab

* For https://github.com/mozilla-mobile/fenix/issues/18521 - Addressed comments
 2021-04-15 18:09:22 +03:00
Arturo Mejia
2119cfadae [fenix] Telemetry for https://github.com/mozilla-mobile/fenix/issues/18855, https://github.com/mozilla-mobile/fenix/issues/18851 and https://github.com/mozilla-mobile/fenix/issues/18857 
For https://github.com/mozilla-mobile/fenix/issues/18857 [Telemetry] Send a Glean event when users change their default browser

For https://github.com/mozilla-mobile/fenix/issues/18855 [Telemetry] Send an event when users open the toolbar menu

For https://github.com/mozilla-mobile/fenix/issues/18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
 2021-04-15 11:29:13 +03:00
Roger Yang
d72289a43d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19003: Add account setting to tabstray synced tab menu (https://github.com/mozilla-mobile/fenix/pull/19034) 2021-04-15 00:46:26 -04:00
Mozilla L10n Automation Bot
1484a591c6 [fenix] Import l10n. 2021-04-15 00:36:37 +00:00
Roger Yang
4f9a341746 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948: Update tabstray telemetry (https://github.com/mozilla-mobile/fenix/pull/19004) 2021-04-14 15:32:45 -04:00
mcarare
8e8a872127 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18854: Add metrics for home screen being displayed. 2021-04-14 21:21:28 +03:00
mcarare
c4609f6e35 [fenix] No issue: Fix indenting in onViewCreated. 2021-04-14 21:21:28 +03:00
mcarare
8f34c26bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/18376: Add experiment for set default browser settings card. 2021-04-14 19:28:38 +03:00
mcarare
9dede18ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18853: Add metrics for default browser new tab experiment. 2021-04-14 19:22:27 +03:00
mcarare
4ff47f6c1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18856: Add metrics for opening settings screen from home menu. 2021-04-14 18:50:15 +03:00
mcarare
62f839d75a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18815: Expand app bar on onboarding dismissal and browsing start. 2021-04-14 18:09:51 +03:00
Jonathan Almeida
d10792a96e [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19011: Always have a click listener in TabTrayViewHolder 2021-04-14 19:08:39 +04:00
Jonathan Almeida
bc628f6770 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18934: Do not nullify adapter on window detached 
Previously, to fix a memory leak, we were removing the adapter reference
entirely in order to have the `onDetachedFromRecyclerView` callback
invoked. This causes a side-effect where we can no longer reference the
adapter any more when we re-attach.

The simpler solution is to just invoke the needed callback directly
instead.
 2021-04-14 19:00:51 +04:00
Gabriel Luong
ac29b50dfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen (https://github.com/mozilla-mobile/fenix/pull/18884) 2021-04-14 10:56:23 -04:00
Oana Horvath
0ad9590e60 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18986 & https://github.com/mozilla-mobile/fenix/issues/19016: disabled failing tests changeThemeSetting & changeAccessibiltySettings 2021-04-14 13:34:58 +03:00
MarcLeclair
4c45f615bb [fenix] 16900 make navgraph inflation asynchronous (https://github.com/mozilla-mobile/fenix/pull/18889) 
* For https://github.com/mozilla-mobile/fenix/issues/16900: implement async navgraph inflation

For https://github.com/mozilla-mobile/fenix/issues/16900: removed nav graph from xml

For https://github.com/mozilla-mobile/fenix/issues/16900: inflate navGraph programatically

For https://github.com/mozilla-mobile/fenix/issues/16900: Made NavGraph inflation asynchronous

For https://github.com/mozilla-mobile/fenix/issues/16900: Changed to block with runBlocking

For https://github.com/mozilla-mobile/fenix/issues/16900: Refactored blocking call into a function

For 16900: NavGraph inflation is now async

We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)

For 16900: rebased upstream master

For 16900: Rebase on master

For https://github.com/mozilla-mobile/fenix/issues/16900: Fixed Async Navgraph navigation per review comments.

1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()

For https://github.com/mozilla-mobile/fenix/issues/16900: inflateNavGraphAsync now takes navController

For https://github.com/mozilla-mobile/fenix/issues/16900: Pass lifecycleScope to NavGraphProvider

For https://github.com/mozilla-mobile/fenix/issues/16900: removed unused mock

For https://github.com/mozilla-mobile/fenix/issues/16900: Added linter rules for navigate calls

We need linting rules to make sure no one calls the NavController.navigate() methods

For https://github.com/mozilla-mobile/fenix/issues/16900: Added TestRule to help abstract the mocks in the code

For 16900: Fix linting problems

For https://github.com/mozilla-mobile/fenix/issues/16900: Cleaned duplicated code in tests

For https://github.com/mozilla-mobile/fenix/issues/16900: cleaned up NavGraphTestRule for finished test

For https://github.com/mozilla-mobile/fenix/issues/16900: had to revert an accidentally edited file

For https://github.com/mozilla-mobile/fenix/issues/16900: rebased master

* For https://github.com/mozilla-mobile/fenix/issues/16900: Review nits for async navgraph

This is composed of squash commits, the original messages can be found below:

-> DisableNavGraphProviderAssertionRule + kdoc.

Use test rule in RobolectricApplication.

Fix failing CrashReporterControllerTest

Fix blame by -> navigate in tests.

This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```

Fix various blame

This is expected to be squashed into the first commit so, if so, it'd
fix the blame.

Move test rule to helpers pkg.

add missing license header

Add import change I missed

fix unused imports

Replace robolectricTestrunner with test rule.

Improve navGraphProvider docs

Remove unnecessary rule as defined by robolectric.

add clarifying comment to robolectric

remove unnecessary space

* For https://github.com/mozilla-mobile/fenix/issues/16900: nit fixes for MozillaNavigateCheck and lint fixes

3 squash commits:
 *Changed violation message and fixed the lint rule for MozillaNavigateCheck
 *Added suppression to NavController.kt
 *Fixed detekt violations

* For 16900: Fixed failing tests

Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
 2021-04-13 20:48:45 -04:00
Mozilla L10n Automation Bot
9d3edcecea [fenix] Import l10n. 2021-04-14 00:32:38 +00:00
Michael Comella
e7a15807a4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: rename CreatedActivityLogEntry -> LogEntry.ActivityCreated and similar. 
It's too much work to squash "correctly".
 2021-04-13 15:10:36 -07:00
Michael Comella
073a4dc221 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: note refactor in metrics docs. 2021-04-13 15:10:36 -07:00
Michael Comella
c04e4f392d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: replace StartupActivityStateProvider with StartupStateProvider. 
The StartupActivityStateProvider uses an imperative implementation,
driven by callbacks, to set the state of the application. This is hard
to follow as you need to understand which callbacks will be called in
which order. For example, to make sense of an implementation like this,
COLD, WARM, AND HOT would likely need to be implemented in separate
ActivityLifecycleCallbacks.

I feel the StartupStateProvider is an improvement because it leverages
the StartupActivityLog to query a linear state for a more understandable
implementation. Furthermore, it seems accessible to write COLD, WARM,
and HOT in the same class because they can all be approached the same
way.
 2021-04-13 15:10:36 -07:00
Michael Comella
4411a9c84a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupStateProvider. 2021-04-13 15:10:36 -07:00
Michael Comella
7d0024ab93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: prevent StartupActivityLog from growing infinitely. 
We do this is as a separate commit over the original implementation
because it's simpler to implement the class without this optimization.
 2021-04-13 15:10:36 -07:00
Michael Comella
7286daabe9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add StartupActivityLog, tests. 2021-04-13 15:10:36 -07:00
Jonathan Almeida
5000e54aaf [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18931: Implement add to collections in interactor 
We moved the collection dialog code out from the old fragment, because it
had nothing to do with tabs tray, and into the collections package to be
re-usable in other parts of the app.

In addition, we also make use of it in the new tabs tray's
NavigationInteractor.
 2021-04-14 01:48:35 +04:00
Jonathan Almeida
e50350db14 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931: Move dialog adapter to collections package 2021-04-14 01:48:35 +04:00
Jonathan Almeida
35947762b7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931: Rename class to CollectionsListAdapter 2021-04-14 01:48:35 +04:00
Christian Sadilek
858320fe6b [fenix] Upgrade to Android Components 75.0.20210413143139 2021-04-13 12:10:36 -04:00
Jonathan Almeida
167d925c12 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18934: Remove adapter when deataching from window 2021-04-13 19:00:01 +04:00
Jonathan Almeida
4ba99372f2 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18885: Dismiss FAB icon when tabs tray is closed 2021-04-13 18:59:16 +04:00
mcarare
ed8d36520e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18375: Add experiment for set default browser New Tab card. 2021-04-13 17:25:51 +03:00
Elise Richards
a5d8e40932 [fenix] Add ignores for intermittent toolbar tests 2021-04-13 13:21:29 +03:00
Mozilla L10n Automation Bot
aae8d26393 [fenix] Import l10n. 2021-04-13 00:55:06 +00:00
Jonathan Almeida
df807cf612 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18973: Fix references to info banner 2021-04-13 04:15:43 +04:00
Roger Yang
425c9d857b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18522: Re-add call to action in tabs tray 2021-04-13 02:01:42 +04:00
Elise Richards
856e133f4d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18806: Show sync tabs or sync account sign in based on feature flag (https://github.com/mozilla-mobile/fenix/pull/18859) 
* Show sync tabs or sync account sign in based on feature flag. Sign in navigates to account settings on click.

* lint and nits
 2021-04-12 16:01:33 -05:00
Roger Yang
820f3f1521 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18899: Update content description string for synced tabs icon (https://github.com/mozilla-mobile/fenix/pull/18963) 2021-04-12 15:16:38 -04:00
Jonathan Almeida
5819a7c0a4 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18862: Add multi-select banner to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18932) 
* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add new addBookmark BookmarksUseCase

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add class for state binding features

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add delete multiple tabs to tray interactor

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add new actions to navigation interactor

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Enable select mode from main tray menu

* Issue https://github.com/mozilla-mobile/fenix/issues/18862: Add menu when in select mode

* Close https://github.com/mozilla-mobile/fenix/issues/18862: Add multi-select banner to tabs tray

* Close https://github.com/mozilla-mobile/fenix/issues/18862: Add select support for handle UI

We apply various layout changes to the "handle" UI in the tabs tray when
switching modes. It isn't quite clear to my, why we do this, if it's
really needed to meet the end result, and if there is a better way.

For now, we're simplying moving over that logic that we can re-evaluate
at a later time.
 2021-04-12 14:57:01 -04:00
Elise Richards
298c4c2814 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18960: Remove nav in homescreen three dot menu (https://github.com/mozilla-mobile/fenix/pull/18962) 
* Remove nav in homescreen three dot menu

* Remove back and forward items
 2021-04-12 13:05:58 -05:00
Arturo Mejia
22176de02c [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 only show the experiment for set default browser MenuItem when Nightly, Beta, Release are not the default browser 2021-04-12 13:26:52 -04:00
Sören Hentzschel
0344ebb250 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18898 - implement quit button in page menu (https://github.com/mozilla-mobile/fenix/pull/18942) 2021-04-12 12:02:14 -05:00
Gabriel Luong
fd09f532a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18940 - Remove reserved icon spacing for "Nimbus Experiments" setting preference (https://github.com/mozilla-mobile/fenix/pull/18949) 
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
 2021-04-12 12:32:55 -04:00
Oana Horvath
8a20fdec59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17979 & https://github.com/mozilla-mobile/fenix/issues/17840: fix and re-enable UI tests affected by main menu changes 2021-04-12 19:16:17 +03:00
Oana Horvath
7d7f64f839 [fenix] Fix screenshots tests: showDefaultHomeScreen, bookmarksManagementTest 2021-04-12 16:21:35 +03:00
Mozilla L10n Automation Bot
62c179feee [fenix] Import l10n. 2021-04-12 00:38:10 +00:00
Mozilla L10n Automation Bot
b9678e5dea [fenix] Import l10n. 2021-04-11 00:25:07 +00:00
Mozilla L10n Automation Bot
ef233b706a [fenix] Import l10n. 2021-04-10 00:31:18 +00:00
Jonathan Almeida
b543a2bd4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 - Correct one more instance of the onboarding string (https://github.com/mozilla-mobile/fenix/pull/18906) 2021-04-09 15:21:26 -04:00
Gabriel Luong
e6912113d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18742 - Resize the top site item sizes (https://github.com/mozilla-mobile/fenix/pull/18751) 2021-04-09 11:47:35 -04:00
Mugurell
87b9259885 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18122 - Update browser layout for find in page bar with bottom toolbar 
With a dynamic bottom toolbar the  browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.

To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
 2021-04-09 14:48:51 +03:00
Mugurell
a7deb00521 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18616 - Update browser and toolbar layout when toolbar is at top 
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
 2021-04-09 14:48:51 +03:00
Sebastian Kaspari
a23da507c5 [fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background. 2021-04-09 12:36:27 +02:00
Sebastian Kaspari
0d5d585dd1 [fenix] Move TelemetryMiddleware to telemetry sub package. 2021-04-09 12:36:27 +02:00
mcarare
44d32189cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/18829: Adjust bookmark item color to UX specs. 2021-04-09 10:32:33 +03:00
Jonathan Almeida
6acd9c7925 [fenix] Update kdocs of navigation interactor 2021-04-09 06:50:05 +04:00
Jonathan Almeida
ab00590d17 [fenix] Call stop in deattach for feature binding 2021-04-09 06:50:05 +04:00
Jonathan Almeida
d2ca8da836 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18845: Adds swipe-to-delete to tabs tray refactor 
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.

We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
 2021-04-09 06:50:05 +04:00
Mozilla L10n Automation Bot
a02ea9b6ab [fenix] Import l10n. 2021-04-09 00:27:10 +00:00
Arturo Mejia
09b4cf71ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 Add experiment for set default browser MenuItem. 2021-04-08 15:58:43 -04:00
MarcLeclair
7ab0ea8c7f [fenix] For https://github.com/mozilla-mobile/fenix/issues/17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1 (https://github.com/mozilla-mobile/fenix/pull/18832) 
* For https://github.com/mozilla-mobile/fenix/issues/17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1

* For https://github.com/mozilla-mobile/fenix/issues/17759: fixed Android code from INT to actual version name
 2021-04-08 15:20:18 -04:00
Elise Richards
854bfa20f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17870 - Enable new three-dot menu redesign on nightly builds (https://github.com/mozilla-mobile/fenix/pull/18883) 2021-04-08 15:19:05 -04:00
Elise Richards
f674d42d7a [fenix] Settings menu item should be tinted if there is an account issue (https://github.com/mozilla-mobile/fenix/pull/18849) 2021-04-08 13:10:55 -05:00
Elise Richards
d2ad816af9 [fenix] PWA install to homescreen is available in main menu (https://github.com/mozilla-mobile/fenix/pull/18850) 2021-04-08 12:14:28 -05:00
Gabriel Luong
ee594f885e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18268, https://github.com/mozilla-mobile/fenix/issues/18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage (https://github.com/mozilla-mobile/fenix/pull/18808) 2021-04-08 12:09:57 -04:00
Gabriel Luong
71321acb0e [fenix] Update app/src/main/java/org/mozilla/fenix/ext/Activity.kt 2021-04-08 14:23:06 +03:00
Arturo Mejia
c057684ecd [fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 made set a default browser functionality publicly available. 2021-04-08 14:23:06 +03:00
rxu
91a05f1dd1 [fenix] Add domestic China FxA service for Mozilla Online builds 
China fxa related string

Add switch preference in settings to use local/global fxa server

inherit fennec FxA settings

Present or hide fxa switch according to isMozillaonline

Allow China fxa server auto login during migration
 2021-04-07 23:40:59 -07:00
Mozilla L10n Automation Bot
585fc80689 [fenix] Import l10n. 2021-04-08 00:39:56 +00:00
Jonathan Almeida
94e39ff584 [fenix] No issue - Enable the tabs tray refactor in nightly (https://github.com/mozilla-mobile/fenix/pull/18858) 2021-04-07 19:02:15 -04:00
codrut.topliceanu
dc1f62eb6e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Added Icon and sync functionality 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-04-08 02:45:16 +04:00
codrut.topliceanu
695c777306 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Adds FAB to TabsTray rewrite 2021-04-08 02:45:16 +04:00
Gabriel Luong
33c1d58580 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18743 - Change the top sites label colour and size (https://github.com/mozilla-mobile/fenix/pull/18752) 2021-04-07 17:39:11 -04:00
Roger Yang
eccdb6bf8d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068: Track custom fill link from clipboard clicked (https://github.com/mozilla-mobile/fenix/pull/18827) 2021-04-07 16:31:41 -04:00
Jonathan Almeida
1adcbf6b0d [fenix] No issue: Move UseCase wrappers to the interactor; it's only usage 2021-04-07 21:23:09 +04:00
Jonathan Almeida
a890d0210e [fenix] No issue: Move menu to separate integrations class 2021-04-07 21:23:09 +04:00
Jonathan Almeida
d18854c54c [fenix] No issue: Add test for share tab in navigation interactor 
Co-authored-by: Roger Yang <royang@mozilla.com>
 2021-04-07 21:23:09 +04:00
Jonathan Almeida
3c3bf65d93 [fenix] No issue: Observe only normal tabs when updating counter 2021-04-07 21:23:09 +04:00
Jonathan Almeida
398b5823a4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Fix long parameter warnings in detekt 2021-04-07 19:14:54 +04:00
Jonathan Almeida
16f87e47e3 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774: Migrate mutli-selection to store 
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).
 2021-04-07 19:14:54 +04:00
Jonathan Almeida
0b1336868c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Move SelectionInteractor to new package 
The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.
 2021-04-07 19:14:54 +04:00
Arturo Mejia
d024b9bc93 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16557 set autoplay block audio only 
by default
 2021-04-07 07:04:59 -04:00
Mozilla L10n Automation Bot
922110c303 [fenix] Import l10n. 2021-04-07 00:26:52 +00:00
Elise Richards
16c4823bef [fenix] For https://github.com/mozilla-mobile/fenix/issues/18770 - Correct addons position in three dot menu based on toolbar position (https://github.com/mozilla-mobile/fenix/pull/18828) 2021-04-06 15:40:32 -04:00
Grisha Kruglov
242ea763de [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17361: Extend perf.awesomebar.* metrics 2021-04-06 11:50:08 -07:00
Gabriel Luong
77a540b659 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18819 - Hide the Credit Card preference by default (https://github.com/mozilla-mobile/fenix/pull/18820) 2021-04-06 13:43:51 -04:00
Mozilla L10n Automation Bot
cb30e7fde7 [fenix] Import l10n. 2021-04-06 17:28:45 +00:00
Roger Yang
7b72b9e85b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18513: Re-add menu to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18756) 2021-04-06 10:26:41 -04:00
Jonathan Almeida
3ec3c16c70 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Set the span count for grid view 2021-04-06 09:57:33 +04:00
Jonathan Almeida
8fa60a67af [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Do not animate first scroll to position 
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
 2021-04-06 09:57:33 +04:00
Jonathan Almeida
9e3bd75692 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535: Move list/grid viewholders to browser package 2021-04-06 09:57:33 +04:00
Kate Glazko
a5ea92912f [fenix] For 17798: Sync Menu Item 2021-04-05 14:34:34 -07:00
Jonathan Almeida
94688bf59b [fenix] Close https://github.com/mozilla-mobile/fenix/issues/17821: Add TabsTrayStore with actions and reducer (https://github.com/mozilla-mobile/fenix/pull/18773) 2021-04-05 15:12:07 -04:00
Jonathan Almeida
5beadfdb15 [fenix] No issue - Make TabLayoutMediator lifecycle aware (https://github.com/mozilla-mobile/fenix/pull/18779) 2021-04-05 15:10:29 -04:00
Travis Long
5b26effc9a [fenix] [SDK-246] Change Nimbus channel input to use the same method as Glean (https://github.com/mozilla-mobile/fenix/pull/18766) 
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean

* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-04-05 12:30:25 -04:00
VaishnaviShri
4536a2a35e [fenix] For https://github.com/mozilla-mobile/fenix/issues/8545: Fix unnecessary scroll in home screen 
Changed the height of the recycler view inside the home fragment
to ‘wrap_content’ to avoid scrolling if the viewport is not filled
with elements.

Closes https://github.com/mozilla-mobile/fenix/issues/8545
 2021-04-05 09:15:06 +03:00
Mozilla L10n Automation Bot
ddb145b3cb [fenix] Import l10n. 2021-04-05 00:28:16 +00:00
Mozilla L10n Automation Bot
dba715e17a [fenix] Import l10n. 2021-04-04 00:29:06 +00:00
Gabriel Luong
d45e4c4e42 [fenix] Use photon colors from ui-color (https://github.com/mozilla-mobile/fenix/pull/18760) 2021-04-03 10:26:53 -04:00
Gabriel Luong
46e6ea9e85 [fenix] No issue - Remove generic strings for more specificity (https://github.com/mozilla-mobile/fenix/pull/18769) 2021-04-02 15:24:28 -04:00
Mugurell
91cc54d75b [fenix] For https://github.com/mozilla-mobile/fenix/issues/17772 - Collapse browser menu to "Add to Home screen" 
The menu will start as collapsed.
Users can then swipe up to expand it.
 2021-04-02 18:45:27 +03:00
Gabriel Luong
a13c6f3f2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18265 - [Add card] Integrate the credit card storage and handle adding a new credit card (https://github.com/mozilla-mobile/fenix/pull/18719) 2021-04-02 10:40:44 -04:00
Michael Comella
028cfd0597 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18731: remove anonymous classes from StrictModeManager. 
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
 2021-04-01 13:19:49 -07:00
Gabriel Luong
5224c11879 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18729 - Use consistent string naming for generic strings (https://github.com/mozilla-mobile/fenix/pull/18730) 2021-03-31 18:20:04 -04:00
Elise Richards
990fe44056 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17770: New tab three-dot menu reorder (https://github.com/mozilla-mobile/fenix/pull/18427) 
* Create new menu order for new tab

* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.

* Lint

Lint and refactoring tests

* Tests for default toolbar menu

* Feature flag for request desktop site

Add todos for UI test issue 17979

Add todos for UI tests
 2021-03-31 16:05:44 -05:00
mcarare
bcbd67bb07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18717: Use normal theme color for tab tray synced tabs. 2021-03-31 18:30:05 +04:00
Mugurell
433b0f0bdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/18617 - Use the new EngineView#getInputResultDetail() 
All functionality should remain the same.
 2021-03-31 15:36:38 +03:00
AndiAJ
5f52f0140f [fenix] Disable failing UI Tests 2021-03-31 13:06:18 +03:00
mcarare
df747ca855 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17797: Add bookmarks menu item. 2021-03-31 11:12:58 +03:00
Roger Yang
c164b2308b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18706 - Remove unneeded add-on telemetry calls (https://github.com/mozilla-mobile/fenix/pull/18707) 2021-03-30 16:19:00 -04:00
rxumoz
305bb7f48a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18386 - Change language display name to traditional/simplified Chinese for Chinese locale (https://github.com/mozilla-mobile/fenix/pull/18387) 2021-03-30 16:18:31 -04:00
Mihai Adrian Carare
4da13e56c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. (https://github.com/mozilla-mobile/fenix/pull/18653) 2021-03-30 16:12:46 -04:00
Roger Yang
56fcf0e457 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18514: Re-add tab counter in tabs tray (https://github.com/mozilla-mobile/fenix/pull/18659) 2021-03-30 15:43:07 -04:00
Michael Comella
b26d782c2f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add data review links. 2021-03-30 10:38:44 -07:00
Michael Comella
9c3ad5608a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: warn about flaw in app_opened_all_startup probe. 2021-03-30 10:38:44 -07:00
Michael Comella
c5bfc690d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: record cold start duration telemetry. 2021-03-30 10:38:44 -07:00
Michael Comella
f5accce70f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add StartupActivityStateProvider. 
This will be used to filter conditions for the start up telemetry we're
adding.
 2021-03-30 10:38:44 -07:00
Michael Comella
ee31fe29c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add ApplicationStartReasonProvider. 
We need to know this state to add a correct COLD MAIN probe.
 2021-03-30 10:38:44 -07:00
Michael Comella
04af130922 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add DefaultActivityLifecycleCallbacks. 
We'll extend this in subsequent commits.
 2021-03-30 10:38:44 -07:00
Oana Horvath
6dff34ee33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18644: fix metod to verify system notifications 2021-03-30 18:19:02 +03:00
Jonathan Almeida
9feca460c1 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14117: Add Synced Tabs as a page in the tabs tray 2021-03-30 19:09:50 +04:00
Oana Horvath
e4614fd8a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18421: Ignore the ContextMenusTest class because of test failures 2021-03-30 17:12:49 +03:00
Gabriel Luong
4cab53bb65 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18247 - [Add card] Populate the Credit card expiry year drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
57c0eb196a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18246 - [Add card] Populate the Credit card expiry month drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
5f5d03ee19 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18243 - Add a credit card editor screen 2021-03-29 21:37:03 -04:00
Jonathan Almeida
e6d88f4669 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18521: Focus on page corresponding to selected tab 
This first part of https://github.com/mozilla-mobile/fenix/issues/18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
 2021-03-30 03:08:01 +04:00
Jonathan Almeida
11b1e0a461 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668: Add stable ID cache for TabAdapter.getItemId 2021-03-30 02:58:54 +04:00
yichiehc
1006a699c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16830: Increase the Show in private sessions option in Search Preferences Settings (https://github.com/mozilla-mobile/fenix/pull/18689) 
* For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605)

* For https://github.com/mozilla-mobile/fenix/issues/16830: Increase the Show in private sessions option in Search Preferences Settings

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-03-29 17:06:29 -05:00
Aaron Klotz
6c8838adb7 [fenix] Explicitly set android:extractNativeLibs to true in ApplicationManifest.xml 
The Android Gradle Plugin's default for android:extractNativeLibs changed from
true to false beginning with version 3.6.0. Based on GeckoView's needs, we
should ensure that this attribute is explicitly set to true.
 2021-03-29 12:52:34 -07:00
Michael Droettboom
2fb552617a [fenix] Bug 1689162: Update Glean metrics.yaml schema (https://github.com/mozilla-mobile/fenix/pull/18683) 2021-03-29 11:53:45 -04:00
Kershan
bd7ca49b17 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18453 - Show SUMO for default browser deeplink on Android <N 
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
 2021-03-29 18:14:15 +03:00
Arturo Mejia
d23cc020cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Improve Onboarding strings 2021-03-27 08:48:13 -04:00
Jonathan Almeida
debb6bbc7b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443: Move viewholders to separate files and package 2021-03-27 03:42:34 +04:00
Jonathan Almeida
5f2ac9fbc0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443: Fix changes between grid/list viewholders 2021-03-27 03:42:34 +04:00
Jonathan Almeida
0e3def9e83 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/18443: Use recyclerview-selection for multi-select mode in tray 
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
 2021-03-27 03:42:34 +04:00
Gabriel Luong
83e350ed4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/17291 - Display a list of all active Nimbus experiments (https://github.com/mozilla-mobile/fenix/pull/17515) 2021-03-26 13:58:30 -04:00
yichiehc
6dd598c8db [fenix] For https://github.com/mozilla-mobile/fenix/issues/18594: Highlight the "Default browser" system setting on Android >= N 
Although not public APIs we can use specific extras in the Intent used to open
system settings such that the "Default browser" setting is highlighted to
provide a better UX for users looking to set Fenix as default.
 2021-03-26 18:25:56 +02:00
rxumoz
c22c6c1b3d [fenix] Update top sites to add PDD for MozillaOnline builds (https://github.com/mozilla-mobile/fenix/pull/18615) 2021-03-26 12:18:46 -04:00
Mihai Adrian Carare
89321fbec1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18260 - Add pin to default sites. (https://github.com/mozilla-mobile/fenix/pull/18618) 2021-03-26 11:36:27 -04:00
Roger Yang
d4fa548812 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18535: Re-add grid layout to tabs tray (https://github.com/mozilla-mobile/fenix/pull/18638) 2021-03-26 10:33:46 -04:00
Oana Horvath
b9aa2166ca [fenix] Disable customTrackingProtectionSettingsTest 2021-03-26 16:25:14 +02:00
Oana Horvath
8950cb0b73 [fenix] Re-enable working UI tests from https://github.com/mozilla-mobile/fenix/issues/18644 2021-03-26 16:25:14 +02:00
Mozilla L10n Automation Bot
0875ac09ed [fenix] Import l10n. 2021-03-26 11:39:00 +00:00
Mugurell
baab77eb92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 - Temporarily disabling UI tests that fail on Firebase. 
This is a quick solution to resume PR merges.
Investigations and a proper fix is to follow on this same ticket.
 2021-03-26 13:06:05 +02:00
Arturo Mejia
c9f822d0d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Optimize the order and messages of onboarding cards 2021-03-24 22:16:00 -04:00
Aaron Train
5a89e3da5d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18623: Fix Gradle task name in gradlewbuild.py (https://github.com/mozilla-mobile/fenix/pull/18624) 2021-03-24 15:33:17 -04:00
Roger Yang
e1404fab67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17644: Record when user taps on a add-on's setting (https://github.com/mozilla-mobile/fenix/pull/18504) 2021-03-24 14:31:39 -04:00
Mozilla L10n Automation Bot
a1b234a67b [fenix] Import l10n. 2021-03-24 00:25:33 +00:00
Jonathan Almeida
101061cae3 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18538: Add BrowserTabsAdapter for tabs tray 2021-03-24 02:37:06 +04:00
Gabriel Luong
b3421edcf8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605) 2021-03-23 16:00:41 -04:00
mcarare
f5c72efb38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17790: Remove app from recents screen on quit. 2021-03-23 23:02:01 +04:00
Elise Richards
25d14c9a8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/17190: notifications are updated when locale is changed (https://github.com/mozilla-mobile/fenix/pull/18179) 
* Add intent processor for locale changes

* Recreate notification and notify in the service

* Use locale use cases to update notification

* Use notification id instead of tag

* Add locale use cases and restore locale in application

* Send locale to service instead of string

* Controller tests for locale

* Update Android Components version to 74.0.20210323143308

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-03-23 14:16:30 -04:00
Gabriel Luong
9272994178 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18240 - Add a Credit Card preference screen (https://github.com/mozilla-mobile/fenix/pull/18410) 
- Removes an unused preference key "pref_key_credit_cards_addresses"
 2021-03-23 11:59:32 -04:00
Roger Yang
baa22e0645 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17791: Use updated URL with custom tabs when copying to clipboard (https://github.com/mozilla-mobile/fenix/pull/18590) 2021-03-23 10:31:53 -04:00
Mugurell
ea39380daa [fenix] For https://github.com/mozilla-mobile/fenix/issues/18585 - Don't use hardcoded String values in Onboarding unit test (https://github.com/mozilla-mobile/fenix/pull/18597) 
Test if the welcome message has the expected structure and uses the expected
String values, not what the string values are.
 2021-03-23 15:54:24 +02:00
Vitaly V. Pinchuk
49c057097e [fenix] For https://github.com/mozilla-mobile/fenix/issues/18395: Dismiss contextual menu when entering/exiting Reader Mode 2021-03-23 11:46:10 +02:00
mcarare
b0f07eea23 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17799: Add extensions submenu item. 2021-03-23 09:52:45 +02:00
Arturo Mejia
597b246961 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation (https://github.com/mozilla-mobile/fenix/pull/18252)" 
This reverts commit 72754a50
 2021-03-22 16:32:20 -04:00
Mozilla L10n Automation Bot
95ced8e2ec [fenix] Import l10n. 2021-03-22 00:31:33 +00:00
Mozilla L10n Automation Bot
0621af82ac [fenix] Import l10n. 2021-03-21 00:30:53 +00:00
Michael Comella
3b2bda7c81 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add measurement probes for long-running lifecycle methods. 
In addition to the existing probes for onCreate, this should cover all
lifecycle methods that take a long time in our profiles.
 2021-03-19 17:41:03 -07:00
Mozilla L10n Automation Bot
4bbb624c57 [fenix] Import l10n. 2021-03-20 00:30:36 +00:00
Stefan Arentz
340ebf7b0b [fenix] [SDK-218] Nimbus updates to provide app_name and channel (https://github.com/mozilla-mobile/fenix/pull/18559) 
* [SDK-218] Nimbus updates to provide app_name and channel

Provides the `app_name` and `channel` info to Nimbus.

* Update to A-C Nightly 74.0.20210319190549

Co-authored-by: Travis Long <tlong@mozilla.com>
 2021-03-19 16:39:24 -04:00
Michael Comella
1f67254b10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add telemetry for app.onCreate subsections. 
Hopefully this will help us understand behavior of the
`application_on_create` probe, specifically that it seems to take longer
in telemetry than in does locally compared to `home_activity_on_create`
(comparing the medians to local runs)..
 2021-03-19 11:52:29 -07:00
Michael Comella
8182032564 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add TimingDistributionMetricType.measureNoInline. 
This addresses an issue I found in my follow-up PR.
 2021-03-19 11:52:29 -07:00
Roger Yang
4abb852190 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17531: Use shared preference to store top sites count for telemetry (https://github.com/mozilla-mobile/fenix/pull/18557) 2021-03-19 14:13:24 -04:00
Roger Yang
7e59b192b6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17956: Add top site telemetry to available search engines (https://github.com/mozilla-mobile/fenix/pull/18129) 2021-03-19 10:53:36 -04:00
Mihai Adrian Carare
02cabca0c5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12565: Clean up use of Context within ReviewPromptController. (https://github.com/mozilla-mobile/fenix/pull/18537) 2021-03-18 21:49:09 -04:00
mcarare
7150b3870e [fenix] No issue: Update Android Components version to 74.0.20210318143143 
Replaces deprecated method setToolbarColor(Int) in CustomTabsIntent.Builder.
 2021-03-18 21:06:36 -04:00
Mozilla L10n Automation Bot
c204581e87 [fenix] Import l10n. 2021-03-19 00:31:23 +00:00
Stefan Arentz
471e2245d2 [fenix] Enable the Nimbus experiments library on all channels (https://github.com/mozilla-mobile/fenix/pull/18526) 2021-03-18 13:33:33 -04:00
Roger Yang
1569a8ce76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17644: Always update add-on's telemetry values before sending metric ping (https://github.com/mozilla-mobile/fenix/pull/18529) 2021-03-18 13:18:14 -04:00
Jonathan Almeida
c6f95e1f5c [fenix] Enable new tabs tray only for debug builds 2021-03-18 17:21:09 +04:00
Codrut Topliceanu
4fb1bbf431 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation (https://github.com/mozilla-mobile/fenix/pull/18252) 
* For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation

To handle the deprecation of `adjustResize` I've moved it from `styles.xml` and `AndroidManifest.xml` to `Activity.kt` as a fallback for devices with Android < 11. For Android 11 and up `setDecorFitsSystemWindows(false)` and `OnApplyWindowInsetsListener` will be used to handle app insets. Normal use activities should call `enableSystemInsetsHandling` in `onCreate` as to properly display system bars and for proper keyboard handling.
 2021-03-18 10:05:54 +02:00
Mozilla L10n Automation Bot
6f6f491106 [fenix] Import l10n. 2021-03-18 00:54:20 +00:00
Mozilla L10n Automation Bot
01cbaae87a [fenix] Import l10n. 2021-03-17 00:34:04 +00:00
Jonathan Almeida
122597ce56 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17822: Create a tabs tray layout and fragment 
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
 2021-03-17 03:16:10 +04:00
Gabriel Luong
f1b86e17ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/18408 - Add a lazy getter for AutofillCreditCardsAddressStorage 2021-03-16 13:30:43 -07:00
Grisha Kruglov
1c4f366083 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18501: Enable Nimbus on Beta channel 2021-03-16 11:06:47 -07:00
Oana Horvath
be560986e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18481: waits for url to be visible in TestHelper.verifyUrl() (https://github.com/mozilla-mobile/fenix/pull/18498) 2021-03-16 13:35:36 -04:00
Oana Horvath
a862baeda2 [fenix] Add first set of UI tests to Nightly 2021-03-16 11:12:53 +02:00
Mozilla L10n Automation Bot
ed823030dd [fenix] Import l10n. 2021-03-16 00:26:32 +00:00
Mugurell
78b7d0e95c [fenix] For https://github.com/mozilla-mobile/fenix/issues/17869 - New AndroidKeystoreExperiment telemetry 2021-03-15 13:35:49 -07:00
Mugurell
3812cffed0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17869 - Start the Android Keystore experiment 
Only on API 23+ (minimum Android version needed for SecureAbove22Preferences)
and only if enabled by a Nimbus experiment.

The Nimbus experiment will have the key `fenix-android-keystore` and use the
default branches - "control" and "treatment".
 2021-03-15 13:35:49 -07:00
mcarare
1c8387fdb9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17768: Renew telemetry expiring in March. 2021-03-15 19:59:38 +02:00
mcarare
ebde904cfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/18076: Renew telemetry expiring in April. 2021-03-15 19:59:24 +02:00
Gabriel Luong
42cc036ba5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18036 - Add TrackKeyInfo to Ad Click Metrics (https://github.com/mozilla-mobile/fenix/pull/18159) 2021-03-15 12:57:53 -04:00
Oana Horvath
8f9a3dc767 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14005: fix strict TP tests loading timeout 2021-03-15 17:09:50 +02:00
Arturo Mejia
d296d0c9c2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18367 run SupportedAddonsChecker only for users with unsupported extensions 2021-03-15 10:40:10 -04:00
Arturo Mejia
6fff411a12 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18132 remove icons from Settings screen 2021-03-15 09:53:08 -04:00
Arturo Mejia
a32ee95cf9 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18132 create feature flag for refreshing icons 2021-03-15 09:53:08 -04:00
Jan-Erik Rediger
d274db2376 [fenix] Set distributionId right after initializing Glean 
Previously setting it might have been arbitrarily delayed, resulting in
this metrics missing from pings that get submitted earlier.
Setting it early should prevent that.
The performance impact is negligible, Glean dispatches recording that
data off-main-thread anyway.
 2021-03-15 13:38:11 +01:00
Sebastian Kaspari
d0152f7e79 [fenix] Integrate Android Autofill support into Nightly and debug builds. 2021-03-15 10:28:38 +01:00
mcarare
325e5619ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/12528: Provide fallback values for locale display name. 2021-03-15 08:54:20 +02:00
Mozilla L10n Automation Bot
d7cf76a67f [fenix] Import l10n. 2021-03-15 00:37:52 +00:00
Mozilla L10n Automation Bot
6ab6bdaf21 [fenix] Import l10n. 2021-03-14 00:32:08 +00:00
Mozilla L10n Automation Bot
255f7f2c57 [fenix] Import l10n. 2021-03-13 00:29:42 +00:00
Elise Richards
9c40bb475e [fenix] Add open in app to main three dot menu (https://github.com/mozilla-mobile/fenix/pull/18462) 2021-03-12 12:13:53 -06:00
Elise Richards
eb3643f179 [fenix] Remove sync sign in and keep it as synced tabs 2021-03-12 12:43:16 -05:00
Elise Richards
c94d4bf7a4 [fenix] Add report site issue to new three dot menu 2021-03-12 12:43:16 -05:00
Elise Richards
08a0ef2fbb [fenix] Remove disabled color for icons 2021-03-12 12:43:16 -05:00
Mozilla L10n Automation Bot
c681504aed [fenix] Import l10n. 2021-03-12 00:55:35 +00:00
Mozilla L10n Automation Bot
d0dc24b663 [fenix] Import l10n. 2021-03-11 00:38:54 +00:00
Gabriel Luong
f0ad7abee1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18241 - Refactor SyncLoginsPreferenceView to SyncPreferenceView for reusability (https://github.com/mozilla-mobile/fenix/pull/18383) 
This refactors SyncLoginsPreferenceView to SyncPreferenceView so that it be can be used in the
Credit cards preference for the equivalent "Sync cards across devices" preference.
 2021-03-10 16:16:37 -05:00
Mozilla L10n Automation Bot
23b818d715 [fenix] Import l10n. 2021-03-10 00:26:33 +00:00
Jonathan Almeida
ef4264b464 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17804: Use enterToImmersiveMode from support-ktx component 2021-03-09 15:41:21 -05:00
dependabot[bot]
23bc904f09 [fenix] Bump cryptography 
Bumps [cryptography](https://github.com/pyca/cryptography) from 2.8 to 3.2.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/2.8...3.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-03-09 17:20:08 +01:00
Mozilla L10n Automation Bot
f7a90b2030 [fenix] Import l10n. 2021-03-09 01:00:19 +00:00
Roger Yang
1ca7dc61ab [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18178: Rework History Telemetry (https://github.com/mozilla-mobile/fenix/pull/18261) 2021-03-08 19:15:29 -05:00
Roger Yang
f0dcb64716 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18173: Add Telemetry When User Opens a Bookmark (https://github.com/mozilla-mobile/fenix/pull/18174) 2021-03-08 17:11:59 -05:00
Roger Yang
b8342ac6f0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068: Use AwesomeBarFacts for AwesomeBar Telemetry (https://github.com/mozilla-mobile/fenix/pull/18090) 2021-03-08 16:34:52 -05:00
Roger Yang
70329154e5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18163: Use SyncedTabsFacts for Synced Tab Telemetry (https://github.com/mozilla-mobile/fenix/pull/18172) 2021-03-08 15:21:00 -05:00
Mozilla L10n Automation Bot
a64c43db8e [fenix] Import l10n. 2021-03-08 18:52:52 +00:00
Mihai Adrian Carare
bcad665bf5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17971: Add Reader view appearance controls in three-dot main menu. (https://github.com/mozilla-mobile/fenix/pull/18340) 2021-03-08 11:24:27 -06:00
mcarare
97a1241006 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18312: Do not update secure flag on pausing logins fragments. 
The flags are already properly set for activity and thus for other fragments.
 2021-03-08 16:57:12 +02:00
Oana Horvath
8fa1f6c8ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/18325: dismiss GooglePlay ToS dialog after UI test 2021-03-08 10:35:22 +02:00
Mozilla L10n Automation Bot
4d06f81c35 [fenix] Import l10n. 2021-03-08 00:28:18 +00:00
Mozilla L10n Automation Bot
e47b46e89a [fenix] Import l10n. 2021-03-07 00:27:43 +00:00
Mozilla L10n Automation Bot
4a11cb4782 [fenix] Import l10n. 2021-03-06 00:27:55 +00:00
Mugurell
bf1759d01b [fenix] For https://github.com/mozilla-mobile/fenix/issues/17963 - Present Fenix as a browser app to the system 
Fenix will now be able to be started from a call to
Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER)

For more info:
https://developer.android.com/reference/android/content/Intent#CATEGORY_APP_BROWSER
 2021-03-05 09:01:48 +02:00
Elise Richards
098691a8c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17802: Match the design for three-dot menu navigation (https://github.com/mozilla-mobile/fenix/pull/17875) 
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.

* Handle toolbar items in menu controller

* Remove bookmark from toolbar nav

* Respect toolbar position

* Inline toolbar orientation checks

* Add Todos for bookmark UI tests

* Make variable names consistent
 2021-03-04 17:22:13 -06:00
Jan-Erik Rediger
8abe5818ba [fenix] Pass auto-generated build info (version code and name) to Glean (https://github.com/mozilla-mobile/fenix/pull/18230) 
This also re-generated the Glean docs due to an update of the bundled
glean-parser.
 2021-03-04 10:22:56 -06:00
Mugurell
b51c0089b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18034 - Don't animate the toolbar while the tab is loading 
Use the new controller offered by AC to resolve some browser layout issues and
also offer an experience consistent with that of other browsers.
 2021-03-04 14:41:34 +02:00
Mozilla L10n Automation Bot
783e2db261 [fenix] Import l10n. 2021-03-04 08:50:50 +00:00
mcarare
95a660a203 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18009: Correctly report items in adapter for a11y services. 2021-03-03 18:19:42 +02:00
Oana Horvath
c37145d49d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18040: no network access startup test 2021-03-03 17:45:17 +02:00
mcarare
0bd90ffb7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18195: Fix speech recognition for voice search in widget. 2021-03-03 09:26:58 -05:00
mcarare
f258306c0d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18228: Populate menu options in onResume along with toolbar init. 2021-03-03 15:01:54 +02:00
Vitaly V. Pinchuk
dda03dbf69 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18150: select tabs button not displayed (https://github.com/mozilla-mobile/fenix/pull/18216) 
For https://github.com/mozilla-mobile/fenix/issues/18150: Improve showing/hiding of "Select tabs" button in tabs tray

Payload argument is unavailable after first call of notifyItemChanged() as the
whole View need to be updated.
Inject a "isPrivate" lambda in the adapter so it will always know what tabs are
currently showing and so always ensure the expected behavior.
 2021-03-03 14:34:48 +02:00
Sebastian Kaspari
aca64b6eae [fenix] metrics.yaml: Update data review link of engine_tab.kill_foreground_age metric. 2021-03-03 09:23:32 +02:00
Mozilla L10n Automation Bot
c8a98bfd2b [fenix] Import l10n. 2021-03-03 00:29:56 +00:00
AndiAJ
9e6f2b7c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18053 Change and fix Intermittent UI test verifyReaderViewToggle 2021-03-02 14:35:12 +02:00
mcarare
9dbe4620d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18227: Also update icon on search engine edit. 2021-03-02 10:22:31 +02:00
Mozilla L10n Automation Bot
fad5a1e757 [fenix] Import l10n. 2021-03-02 00:29:44 +00:00
Sebastian Kaspari
1368a9bd19 [fenix] Fix metric types of engine telemetry. 2021-03-01 13:10:05 +01:00
Mozilla L10n Automation Bot
da8d402282 [fenix] Import l10n. 2021-02-28 00:26:38 +00:00
Gabriel Luong
1be5240b7f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18202 - Refactor BiometricPromptFeature out of logins into settings 2021-02-27 12:56:07 +04:00
Mozilla L10n Automation Bot
3dfe632931 [fenix] Import l10n. 2021-02-27 01:05:23 +00:00
Michael Comella
a0f46da9ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/18157: convert clock_ticks_per_second to quantity type. 
While we could easily move this into the metrics ping, it's better to
leave it in the other ping because it's less work and because (I think)
we'll be better able to match `framework_secondary` values to the clock
ticks if we combine them in the same ping.
 2021-02-26 16:12:59 -08:00
Gabriel Luong
2b405b20eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/18198 - Add a feature flag for Credit Cards and Addresses autofill feature (https://github.com/mozilla-mobile/fenix/pull/18200) 2021-02-26 17:12:47 -05:00
Jonathan Almeida
fdcf799ec5 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/17928: Add feature flag for tabs tray refactor 2021-02-27 01:10:14 +04:00
Mozilla L10n Automation Bot
0bc1466b74 [fenix] Import l10n. 2021-02-26 00:39:00 +00:00
Gabriel Luong
af3656dc19 [fenix] Replace TopSitesUseCases.renameTopSites with TopSitesUseCases.updateTopSites 2021-02-25 17:46:23 -05:00
Christian Sadilek
96393f85e9 [fenix] Remove Session[Manager] references from Fennec intent processors 2021-02-25 11:54:21 -05:00
Mozilla L10n Automation Bot
83b3b7e702 [fenix] Import l10n. 2021-02-25 00:41:07 +00:00
Arturo Mejia
59b50be098 [fenix] Target Android 11 2021-02-24 14:26:08 -05:00
mcarare
507b4aaf8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/16044: Suggest search engines based on typed text. 2021-02-24 17:32:04 +02:00
Arturo Mejia
25b2805f87 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/10428 Improve download dialog error message. 2021-02-24 09:35:30 -05:00
Mozilla L10n Automation Bot
1619473888 [fenix] Import l10n. 2021-02-24 08:04:35 +00:00
mcarare
e70f40f0d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18102: Temporary ignore failing test. 2021-02-23 17:58:02 +01:00
Mozilla L10n Automation Bot
4378f2fb7d [fenix] Import l10n. 2021-02-23 14:26:58 +00:00
Mugurell
abcbf2bc4f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18027 - Document shouldUseFixedTopToolbar 2021-02-23 13:13:44 +02:00
Mugurell
f5be19d9fe [fenix] For https://github.com/mozilla-mobile/fenix/issues/18027 - Also fix the bottom toolbar in place when a11y is enabled 
We previously only set the top toolbar as fixed if an a11y service was running.
 2021-02-23 13:13:44 +02:00
rxu
6f2c9fd4ed [fenix] Add MOZILLA_ONLINE_ADDON_EXCLUSIONS for Mozilla Online builds 2021-02-22 10:00:57 -05:00
mcarare
5d8ebf61d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18075: Add SaveVideoAudioCandidate for custom tabs context menu. 2021-02-22 10:05:46 +02:00
Mozilla L10n Automation Bot
01bc150556 [fenix] Import l10n. 2021-02-21 00:28:51 +00:00
Jonathan Almeida
1fd32cdfda [fenix] Close https://github.com/mozilla-mobile/fenix/issues/13892: Remove Synced Tabs appended to tabs tray 2021-02-20 23:02:18 +04:00
Mozilla L10n Automation Bot
dcc876c68d [fenix] Import l10n. 2021-02-20 00:35:38 +00:00
Michael Comella
188fe713ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/17972: split frameworkStart into two metrics. 
We do this in order to make it easier to analyze in GLAM: see the metric
descriptions for more details.

Additionally, we change the time unit to milliseconds to make it easier
to analyze in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
edaed932c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17972: add client id to startup-timeline ping, update docs. 
This addresses the root problem we're experiencing for this issue - data
not showing up in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
3ae7379a5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/17969: add duration probes for App.onCreate and HomeActivity.onCreate. 2021-02-19 13:20:34 -08:00
Mugurell
d975ede9d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17899 - Expand toolbar when returning from fullscreen video 
This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.

When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
 2021-02-19 17:46:49 +02:00
Roger Yang
998a10cdc9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17089: Add metric to track both normal and private URI opened (https://github.com/mozilla-mobile/fenix/pull/17935) 2021-02-19 10:37:07 -05:00
Sebastian Kaspari
5fec5b8d61 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731: Collect telemetry about the content process of tabs getting killed. 2021-02-19 11:32:56 +01:00
Sebastian Kaspari
4bb02ee709 [fenix] Update Kotlin to 1.4.30 and Coroutines to 1.4.2. 2021-02-19 11:31:15 +01:00
Mozilla L10n Automation Bot
b3b485d046 [fenix] Import l10n. 2021-02-19 00:31:43 +00:00
Arturo Mejia
25f193cf50 [fenix] Update toolbar autoplay strings 2021-02-18 16:40:43 -05:00
Christian Sadilek
e2d45f84e9 [fenix] Deprecate SessionManager component 2021-02-18 14:28:28 -05:00
Christian Sadilek
33b8a527ff [fenix] Remove remaining usages of Session[Manager] in BrowserFragment 2021-02-18 14:28:28 -05:00
Christian Sadilek
70046cf635 [fenix] Refactor BrowserToolbarMenuController to use browser store 2021-02-18 14:28:28 -05:00
Arturo Mejia
99393c2d84 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18049 Download complete dialog is not showing in custom tab. 2021-02-18 12:43:52 -05:00
Victor
dfab17947d [fenix] Solves Leaks on SavedLoginFragment 
disables options menu to avoid leak
 removes on click listener to avoid leak
 2021-02-18 19:00:44 +02:00
Sebastian Kaspari
997b066b00 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18006: DefaultSessionControlControllerTest: Correctly unmock SearchStateKt class. 
The test class left SearchStateKt mocked and caused other tests to fail intermittently when
running after it.
 2021-02-18 15:49:31 +01:00
mcarare
af0dfaa3dc [fenix] For https://github.com/mozilla-mobile/fenix/issues/17807: Fix systemWindowInset deprecation. 2021-02-18 09:14:53 -05:00
Oana Horvath
8427eddc28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16317 UI tests: save longTap preference to restore it 2021-02-18 13:46:09 +02:00
Mozilla L10n Automation Bot
08a0a1c3b6 [fenix] Import l10n. 2021-02-18 00:36:55 +00:00
Ryan Kelly
23154791ab [fenix] Reset experiment telemetry identifiers on data prefs change. 
When the user opts out of telemetry, we need to reset the user identifiers
used by the experiment system, so that there's no risk of tracking the
user across the reset event if they later decide to re-enable telemetry.
 2021-02-17 16:07:57 -05:00
Oana Horvath
9caaa08732 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16317: resets long press delay at the end of UI tests 2021-02-17 16:39:44 +02:00
Mozilla L10n Automation Bot
ca84828a66 [fenix] Import l10n. 2021-02-17 00:39:54 +00:00
Jan-Erik Rediger
ba94d2e39e [fenix] Glean: Check for renamed reason 2021-02-16 16:32:14 -05:00
Mugurell
22ec6af4a3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17195 - Don't try setting an idle resource if the View is already off screen 
Speculative fix based on the Firebase logs which shows that on a second check
of R.id.tab_wrapper it is not found the screen.
It may be because after `advanceToHalfExpandedState` and before getting a
reference to it in `waitForTabTrayBehaviorToIdle` it was already animated off
the screen.
With this in mind I've added a null check for the view reference before trying
to register an idling resource on it's Behavior.

Also added and used a way to click at a specific location in a View, not just
in the default middle in the View.
It was observed from the Firebase videos that a "click" on the topBar actually
selected the private tabs section. This would leave us to believe that the
"click" was caught by that other View which was placed above the x,y middle of
the topBar.
 2021-02-16 16:26:17 +02:00
Mugurell
e16ef0b3c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17195 - Test a potential fix for the test 2021-02-16 16:26:17 +02:00
Oana Horvath
a2cc89acb6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17484, https://github.com/mozilla-mobile/fenix/issues/18003 UI tests: retry closing tab if it fails 2021-02-16 14:28:26 +02:00
Mozilla L10n Automation Bot
c7c7ce8e86 [fenix] Import l10n. 2021-02-16 00:29:18 +00:00
Christian Sadilek
d8024b9169 [fenix] Refactor BrowserToolbarController to use browser store 2021-02-15 15:01:29 +01:00
Codrut Topliceanu
cf939f2a26 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17352 - Fixes deleted downloads reappearing (https://github.com/mozilla-mobile/fenix/pull/17930) 
* For https://github.com/mozilla-mobile/fenix/issues/17352 - Fixes deleted downloads reappearing

The `getDeleteDownloadItemsOperation` job would check fragment context not null after the fragment was stopped. Removing that check and only passing the downloadUseCase as a parameter fixes the problem.
 2021-02-15 11:22:09 +02:00
Mozilla L10n Automation Bot
7fcdf3e489 [fenix] Import l10n. 2021-02-15 00:40:59 +00:00
Mozilla L10n Automation Bot
5662eb3042 [fenix] Import l10n. 2021-02-14 00:36:56 +00:00
Mozilla L10n Automation Bot
fccf88fe26 [fenix] Import l10n. 2021-02-13 01:55:06 +00:00
Elise Richards
1708e2c424 [fenix] Remove unneeded temporary UI test ignores (https://github.com/mozilla-mobile/fenix/pull/17980) 2021-02-12 17:01:38 -06:00
Mugurell
7e3969c01d [fenix] For https://github.com/mozilla-mobile/fenix/issues/17686 - Use a custom behavior to scroll InfoBanner with the top toolbar 
Previously when the toolbar was on top the banner was inflated in the toolbar's parent - an AppBarLayout.
After migrating to use a custom behavior for scrolling the toolbar and not use
anymore the AppbarLayout for this we needed a new solution.
Using a new behavior to keep this banner in sync with the y translation of the
toolbar gives us most of the old behavior back.
 2021-02-12 16:05:19 +02:00
Elise Richards
9c5bc17da9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17771: three-dot menu reorder (https://github.com/mozilla-mobile/fenix/pull/17838) 
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.

* Handle toolbar items in menu controller

* Menu controller tests

* Make icons invisible

* Lint

* UI tests reflect design change

* Refactor test names

* Lint fixes

* UI tests
 2021-02-11 18:55:12 -06:00
Mozilla L10n Automation Bot
20e0f884d2 [fenix] Import l10n. 2021-02-12 00:24:31 +00:00
Michael Comella
4496ae2ae5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17920: move manufacturer StrictMode exception to ignores function. 
I think this is more consistent and centralizes the violation ignores.
 2021-02-11 15:22:50 -08:00
Michael Comella
1b8ac55003 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17920: use StrictMode penaltyDeathWithIgnores. 2021-02-11 15:22:50 -08:00
Michael Comella
2bc1605cbd [fenix] For 17920: add ThreadPenaltyDeathWithIgnoresListener, tests, helpers. 2021-02-11 15:22:50 -08:00
Michael Comella
5836fe6f65 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17920: add ManufacturerCodes. 2021-02-11 15:22:50 -08:00
Michael Comella
50b0c72261 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17816: add ProfilerFactProcessor and register it, tests. 2021-02-11 14:52:36 -08:00
Mugurell
3e9bd41397 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17803 - Use the main looper for Handler()s 
This was already the one inferred.
Targeting Android 11 means we need to pass it explicitly.
 2021-02-11 19:42:33 +02:00
Codrut Topliceanu
942195bfae [fenix] For https://github.com/mozilla-mobile/fenix/issues/17418 - Added telemetry for Google Default Top Site (https://github.com/mozilla-mobile/fenix/pull/17637) 
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds TopSite PerformedSearch back in

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Check now looks for equality with GOOGLE_URL

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds test for topSite changes
 2021-02-11 11:31:01 -05:00
Mozilla L10n Automation Bot
93c88fb1ae [fenix] Import l10n. 2021-02-11 09:45:42 +00:00
Sebastian Kaspari
0e4e2623bb [fenix] ToolbarIntegration: Use global public suffix list instance. 2021-02-11 09:33:40 +02:00
Roger Yang
f3009d5a2b [fenix] Fix OpenSpecificTabIntentProcessorTest to remove AbstractMediaService (https://github.com/mozilla-mobile/fenix/pull/17955) 2021-02-10 13:33:39 -05:00
Sebastian Kaspari
ac67fc9de6 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17174: Remove usage of old media APIs. 2021-02-10 16:42:58 +01:00
Christian Sadilek
8deddb6dcb [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17889: Wrong tab selected/reloaded when restored from collection 2021-02-10 10:46:13 +01:00
Mozilla L10n Automation Bot
5ffa622713 [fenix] Import l10n. 2021-02-10 00:29:59 +00:00
ekager
62ab7505e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17906 - Allow screenshots for private home screenshot test 2021-02-09 12:52:46 -07:00
Oana Horvath
488e18bfa6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15259 UI test: waits for home screen to be visible 2021-02-09 17:22:24 +02:00
AndiAJ
5e626c49c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17195 Fix Intermittent UI test verifyTabTrayNotShowingStateHalfExpanded 2021-02-09 16:46:31 +02:00
AndiAJ
1d0384c1f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17852 Change and Fix Intermittent UI test openNewTabTest 2021-02-09 16:43:56 +02:00
Michael Comella
b62dfc086b [fenix] For https://github.com/mozilla-mobile/fenix/issues/17816: add profiler marker for onPreDraw via HomeActivity.onStart. 
This may be useful for MAIN start up to determine when the user begins
seeing content.
 2021-02-08 17:46:32 -08:00
Michael Comella
6895920bde [fenix] For https://github.com/mozilla-mobile/fenix/issues/17816: add profiler marker for 2x Activity.onCreate. 
The IntentReceiverActivity one is particularly useful to quickly determine
when we can begin executing code in the WARM VIEW case (i.e. "Set selection
begin here").

The HomeActivity one is useful for COLD start up analysis in similar
ways and to see the Activity transitions in WARM VIEW.
 2021-02-08 17:46:32 -08:00
Mozilla L10n Automation Bot
fe3151fd0b [fenix] Import l10n. 2021-02-09 00:42:20 +00:00
ekager
cb641900d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17915 - Do not launch system settings on Role Request Intent cancel 2021-02-08 09:56:38 -07:00
AndiAJ
aca5681026 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14523 Fix Intermittent tests verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab 2021-02-08 18:15:14 +02:00
Oana Horvath
dca92aed10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17847: Removes editCustomSearchEngineTest UI test 2021-02-08 17:47:05 +02:00
Mozilla L10n Automation Bot
066ed1c8fa [fenix] Import l10n. 2021-02-08 00:34:20 +00:00
Arturo Mejia
31035fdca1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17817 Change the feature prompt references from fragment to activity. 2021-02-07 08:10:57 -05:00
Mozilla L10n Automation Bot
8d9222725c [fenix] Import l10n. 2021-02-07 00:39:01 +00:00
Abhinav Gupta
ec673f6d4c [fenix] Hiding the usernameview if the data item.username is blank. 2021-02-06 13:20:22 -07:00
ekager
a0ed1a4a1d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17871 - use viewLifecycleOwner for TopSitesFeature owner on HomeFragment (https://github.com/mozilla-mobile/fenix/pull/17873) 2021-02-05 19:47:25 -05:00
Mozilla L10n Automation Bot
21b0b9c2b0 [fenix] Import l10n. 2021-02-06 00:25:11 +00:00
Roger Yang
aa6190bce4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17174: Remove the New Media Session API Feature Flag (https://github.com/mozilla-mobile/fenix/pull/17863) 2021-02-05 18:54:37 -05:00
ekager
1e9ba2a87c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13089 - Adds correct animations for account settings 2021-02-05 14:03:18 -07:00
ekager
466a163f05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17785 - Use screenshots setting when adding secure flag 2021-02-05 13:17:47 -07:00