Commit Graph

6034 Commits (08a71a5366908f3ba3f63895202094e2a78686de)

Author SHA1 Message Date
Arturo Mejia 33ac87cbd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 use block color on disabled permissions 3 years ago
Mozilla L10n Automation Bot 841b304f0d [fenix] Import l10n. 3 years ago
Jonathan Almeida 591d6744df [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796: Additional fixes for intermittent failing test
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
3 years ago
Arturo Mejia 93f23aa750 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding. 3 years ago
Arturo Mejia 2e60b8d80a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 fix ui tests 3 years ago
Gabriel Luong 2d6dcb814c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog 3 years ago
Arturo Mejia 39dc0701a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation 3 years ago
Gabriel Luong c9575d0d62 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR 3 years ago
Gabriel Luong 609acda69c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Use the new "Details" text for navigating to ETP details 3 years ago
Arturo Mejia ab1e4228c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu. 3 years ago
Gabriel Luong 7d8ca1ec98 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong 66192cc136 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add right arrowheader to tracking protection navigators 3 years ago
Gabriel Luong 9bb39fe7b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings 3 years ago
Gabriel Luong 23d57b151f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add navigation from quick settings to tracking protection panel 3 years ago
Gabriel Luong 70d55f4746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator 3 years ago
Mozilla L10n Automation Bot 0196a85e19 [fenix] Import l10n. 3 years ago
Jonathan Almeida 8c5bccf445 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853: Fix intermittent failing test in HomeFragmentStoreTest 3 years ago
Jonathan Almeida b9c243c0ec [fenix] Update TabSessionState.createdAt for inactive tabs debugging 3 years ago
Arturo Mejia d735df1dd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string 3 years ago
Sebastian Kaspari 7e548348e3 [fenix] Android Autofill: Use AppCompat theme for UnlockActivity. 3 years ago
Arturo Mejia 3dc3db856c [fenix] Remove duplicated line in TabsSettingsFragment 3 years ago
Sebastian Kaspari eb35f06802 [fenix] Use theming in debug screen. 3 years ago
Jonathan Almeida 632311b1ea [fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168: Remove intermittent failing test in ToolbarViewTest
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.

This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.

It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.

So therefore.. 🔥
3 years ago
Jonathan Almeida d32727eff9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796: Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest 3 years ago
Jonathan Almeida 14735a61ae [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795: Speculative fix for intermittent test failures in HomeFragmentTest
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
Jonathan Almeida a590fd2b74 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797: Fix intermittent test failures in ShortcutsSuggestionProviderTest 3 years ago
Jonathan Almeida 9b20f9c1c0 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792: Fix intermittent test failures in QuickSettingsFragmentReducerTest 3 years ago
Aaron Train f2fe9ae61d [fenix] Filter out test target packages in Flank-x86 (https://github.com/mozilla-mobile/fenix/pull/20841)
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
3 years ago
Michael Comella fce543516e [fenix] No issue: move kotlin-allopen outside appVariants loop.
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
3 years ago
Elise Richards cc2f37b040 [fenix] Use header20 style on collections to match other home items. Add margin above collections. (https://github.com/mozilla-mobile/fenix/pull/20633) 3 years ago
Jonathan Almeida 00cb0c74f3 [fenix] Update the description for an inactive tabs string 3 years ago
Steven Knipe 982dc4410f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets 3 years ago
codrut.topliceanu 4082b5eb90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20098: Allow PB PiP video screenshots
...when `Allow screenshots in private browsing` is enabled
3 years ago
Rohan Maity 620d034134 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes 3 years ago
Arturo Mejia d4a2d1ac83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments 3 years ago
Arturo Mejia be0f7d9dcc [fenix] Disable intermittent tests. 3 years ago
Arturo Mejia 8ff9adb54e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account 3 years ago
codrut.topliceanu f4f6b18cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in history screens 3 years ago
codrut.topliceanu c441adb0d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in collections 3 years ago
Vitaly V. Pinchuk 21fedbf45f [fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes. 3 years ago
Michael Comella b8f673380f [fenix] No issue: remove unnecessary robolectric annotations.
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
Elise Richards 7273536742 [fenix] For FNXV2-17067: always show home in background behind search dialog (https://github.com/mozilla-mobile/fenix/pull/20573)
* Navigate to home on toolbar click. Handle back press from search dialog

Update tests to show home behind search dialog. Remove unused test.

Jump back in show all button is clickable behind search dialog

Recently saved bookmarks show all button is clickable behind search dialog

* Add feature flag

* Past explorations show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests.

Allow collections to be visible behind search dialog

Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard

Verify navigateUp in tests

Adding ignore for flaky UI test

Only resize home behind search dialog

Add ignore for collection intermittent test

Cleanup
3 years ago
codrut.topliceanu 33b08b6b83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in downloads screen 3 years ago
mcarare dcbd978c73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Re-add tests for class BookmarksUseCaseTest. 3 years ago
AndiAJ 8f3313ad02 [fenix] Start on home UI tests 3 years ago
Mozilla L10n Automation Bot 2120e07768 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 8c1a00b21c [fenix] Import l10n. 3 years ago
Jonathan Almeida feb8f5e363 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726: Fix intermittent failure in AddonsManagementViewTest 3 years ago
Jonathan Almeida 0a0af212f0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20718: Show url if title is missing for inactive tabs 3 years ago
Elise Richards 3bfd5d1827 [fenix] Correct search_count telemetry after revert 3 years ago
Roger Yang 1612db86c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20723: Fix credit card management fragment binding 3 years ago
Michael Comella b4ce5abf0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697: replace mockked lambda in DownloadControllerTest.
This is expected to fix the intermittent failure in this test.
3 years ago
Michael Comella 13249f7080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679: revert allowaccessmodification proguard disabling.
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.

This commit reverts the following commits:

Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.

Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
3 years ago
Jonathan Almeida 3c66fa4833 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19956: Add telemetry for tab view setting changes
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in https://github.com/mozilla-mobile/fenix/issues/19809).
3 years ago
Christian Sadilek 18a51be61c [fenix] Update Android Components version to 92.0.20210806164329 (https://github.com/mozilla-mobile/fenix/pull/20722)
Addresses breaking change in ShortcutsSuggestionProvider
3 years ago
codrut.topliceanu 6c15482c9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in bookmarks screen 3 years ago
Jonathan Almeida d4ab4f3572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663: Make inactive card collapsible
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.

In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
3 years ago
Mugurell 75aeb961e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
3 years ago
codrut.topliceanu 2971cd309d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray 3 years ago
Grisha Kruglov 39561f3644 [fenix] External source support
Adds handling of information about external referrer (package, category)
when dealing with external intents.
3 years ago
Roger Yang 333840f02e [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill (https://github.com/mozilla-mobile/fenix/pull/19548)"
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
3 years ago
Roger Yang cffad4f424 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping (https://github.com/mozilla-mobile/fenix/pull/19733)"
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
3 years ago
Mozilla L10n Automation Bot 60da5771b7 [fenix] Import l10n. 3 years ago
Mugurell b583864643 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
3 years ago
Mugurell 19767246f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Use CombinedHistorySuggestionProvider for history suggestions
This should ensure user is always presented with history results for his
searches.
3 years ago
Mozilla L10n Automation Bot 317bf219d0 [fenix] Import l10n. 3 years ago
Jonathan Almeida cdade5b44a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664: Do not consider newly created tabs as inactive 3 years ago
Jonathan Almeida cb4a24d6a6 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20674: Remove elevation from inactive tabs card 3 years ago
Sebastian Kaspari 5949766c5d [fenix] Enable Android Autofill in Beta builds. 3 years ago
mcarare a710775406 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Use View binding in quick settings. 3 years ago
Mozilla L10n Automation Bot bd036901ae [fenix] Import l10n. 3 years ago
Arturo Mejia 39ea051a14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19970 [Crash] IllegalStateException when navigating to TP panel 3 years ago
Christian Sadilek 24b4a03d32 [fenix] Fix intermittent test failures in ToolbarViewTest 3 years ago
Roger Yang b901490a1b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650: Revert to manually close tab as default setting 3 years ago
Arturo Mejia 724fb8b60f [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Undo Use View binding in quick Settings. 3 years ago
Michael Comella 68bef957b5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20461: remove app_received_intent probe. 3 years ago
Sebastian Kaspari 6109d61cd7 [fenix] Fix UI tests: SettingsPrivacyTest, DeepLinkTest. 3 years ago
Sebastian Kaspari 6e4060fa5a [fenix] Add preference for enabling/disabling Android Autofill from within the app. 3 years ago
Sebastian Kaspari 7f6cdd491b [fenix] Add dialog-like theme for AutofillSearchActivity 3 years ago
Michael Comella d0ca64a9a4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631: remove @Ignore on StorageStats tests.
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
3 years ago
Sebastian Kaspari 4a3576d299 [fenix] Fix intermittent test failures in TabsTouchHelperTest 3 years ago
Mozilla L10n Automation Bot 46a11a3f56 [fenix] Import l10n. 3 years ago
Sebastian Kaspari 7d59c1f786 [fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest 3 years ago
Sebastian Kaspari 5272c60934 [fenix] Fix intermittent test failures in DefaultSessionControlControllerTest. 3 years ago
Michael Comella 85309f1d25 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627: replace mocked lambda in HistoryItemMenuTest.
This will prevent intermittent failures with Java 11.
3 years ago
Michael Comella e0e46cda2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: disable metrics we don't want to renew. 3 years ago
Michael Comella f3f4526124 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: link to data renewal request. 3 years ago
Michael Comella d23a7639ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: renew perf telemetry probes (August expiry).
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
3 years ago
Elise Richards 1bad9ad91c [fenix] No issue: fix glean metrics tests for expired metrics (https://github.com/mozilla-mobile/fenix/pull/20621)
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
3 years ago
fevziomurtekin a84d30689d [fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16396 Fix text contrast ratio on "recently closed tabs" 3 years ago
Jonathan Almeida 3fcd0878d4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20349: Add inactive tab grouping to tabs tray 3 years ago
Jonathan Almeida 0ae2f837b6 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20590: 'Jump back in' should obey feature flags 3 years ago
Christian Sadilek bb3071457a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of DefaultCollectionCreationControllerTest 3 years ago
Rohan Maity eafb11112d [fenix] https://github.com/mozilla-mobile/fenix/issues/7346 update lint-baseline.xml and remove activity_addons.xml as unused resource 3 years ago
Gabriel Luong b0c410ce60 [fenix] Add history metadata feature to the settings menu 3 years ago
Christian Sadilek fb66b53852 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultSessionControlControllerTest 3 years ago
Gabriel Luong f3027746bf [fenix] Add more context for the Past Exploration localization comment 3 years ago
Christian Sadilek 0d7aa7a57a [fenix] Keep history metadata for 14 days 3 years ago
Sebastian Kaspari fa26d61a8f [fenix] Fix intermittent test failures of ModeTest 3 years ago
Sebastian Kaspari 6ea19d4b17 [fenix] Run ktlintFormat to adapt to latest formatting rules. 3 years ago
Sebastian Kaspari bc41dd0b52 [fenix] Add telemetry for Android Autofill feature. 3 years ago
Christian Sadilek acc5dc1220 [fenix] Fix intermittent test failures of LoginExceptionFragmentStoreTest 3 years ago
Christian Sadilek 2a67850677 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of ExceptionsListItemViewHolderTest 3 years ago
Christian Sadilek 9ed161ff27 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures in SearchDialogControllerTest 3 years ago
Christian Sadilek a5716396be [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultTabsTrayControllerTest 3 years ago
mcarare e3b9c8b633 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in settings screens. 3 years ago
Mozilla L10n Automation Bot a1ac269c73 [fenix] Import l10n. 3 years ago
Elise Richards 2fdd3cc5e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20516: Renew product telemetry probes expiring in August (https://github.com/mozilla-mobile/fenix/pull/20517)
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
mcarare cc18008cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/19955 https://github.com/mozilla-mobile/fenix/issues/20393: Add telemetry for home screen recent tabs. 3 years ago
Christian Sadilek b36321a8ed [fenix] Fix intermittent test failures in WebPushEngineIntegrationTest 3 years ago
Christian Sadilek 2c38047d32 [fenix] Fix intermittent test failures in FenixSnackbarKtTest 3 years ago
mcarare dfb5ee8746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in lists. 3 years ago
Christian Sadilek 9e42de220f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent test failures in DefaultQuickSettingsControllerTest 3 years ago
Jonathan Almeida c49e052da2 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19785: Let WebAuthnFeature ride the trains 3 years ago
Arturo Mejia cef6144944 [fenix] Put the Start On home setting behind a feature flag. 3 years ago
Christian Sadilek ad8312ea31 [fenix] Fix intermittent test failures in NavigationInteractorTest 3 years ago
Christian Sadilek 696561599e [fenix] Fix intermittent test failures in PagedHistoryProviderTest 3 years ago
Christian Sadilek bcf051b559 [fenix] Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest 3 years ago
Christian Sadilek ddd3964fb7 [fenix] Fix intermittent test failures in BookmarkControllerTest 3 years ago
Christian Sadilek a29d89ef7a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of HistoryControllerTest 3 years ago
Sebastian Kaspari d9faf84790 [fenix] RemoveTabUseCaseWrapperTest: Do not mock lambdas. 3 years ago
Sebastian Kaspari 0400ede268 [fenix] DefaultRecentlyClosedControllerTest: Do not mock functions 3 years ago
Sebastian Kaspari 3fde165e1c [fenix] Do not mock lambdas in TrackingProtectionPanelInteractorTest. 3 years ago
Christian Sadilek b612a76e07 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent failures of DefaultBrowserToolbarMenuControllerTest 3 years ago
Michael Comella f6404a2008 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20540: always swipe twice to openSettings in ThreeDotMenuMainRobot. 3 years ago
Mozilla L10n Automation Bot 0e280db7ac [fenix] Import l10n. 3 years ago
codrut.topliceanu 8593bfd0fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20440 - Forces TopSitePager bind if no. of pages changed 3 years ago
Sebastian Kaspari cb0f5facd9 [fenix] Render debug info screen with Jetpack Compose. 3 years ago
Christian Sadilek 3bc9ed6cba [fenix] Fix init order in TrackingProtectionExceptionsViewTest 3 years ago
Christian Sadilek 0f8e4450a2 [fenix] Fix race condition in ShareViewModelTest 3 years ago
Christian Sadilek 2a6d83146a [fenix] Remove unused imports in PwaOnboardingObserverTest.kt 3 years ago
Christian Sadilek a56fdc175c [fenix] Use MainCoroutineRule in PwaOnboardingObserverTest 3 years ago
Sebastian Kaspari 2e02e54516 [fenix] Update Robolectric and mockk. 3 years ago
Sebastian Kaspari ccd84ee8e5 [fenix] Remove over-eager protobuf stripping. 3 years ago
Sebastian Kaspari 70ae207572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19662: Use Java 11. 3 years ago
Oana Horvath 1e55287003 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20297: close tab to avoid saving the same tab to collection 3 years ago
Mozilla L10n Automation Bot 5e82503179 [fenix] Import l10n. 3 years ago
codrut.topliceanu ac4779de6d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20449 - Fixes `Show most visited sites` crash on disable 3 years ago
mcarare 9348be6526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Update AC version 3 years ago
mcarare bb27316944 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Do not show recent bookmarks older than 10 days. 3 years ago
Mozilla L10n Automation Bot ff3191f966 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot b87268288e [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 4a13b27102 [fenix] Import l10n. 3 years ago
Mugurell 2f57358d6a [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Re-enable shortcutButtonTest
The issue affecting this was resolved in AC.
3 years ago
Mugurell df0b2e0d59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20402 - Re-enable "in progress media tab"
The crash for when media starts playing in a custom tab is now resolved in AC.
3 years ago
Gabriel Luong 1341b1e7cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 3 years ago
Gabriel Luong 229aab88f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20438 - Display a list of history metadata groups 3 years ago
Mozilla L10n Automation Bot 5daa184477 [fenix] Import l10n. 3 years ago
Michael Comella f6e71d4e40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: correct spacing in comment on how to run
Co-authored-by: Jonathan Almeida <git@jonalmeida.com>
3 years ago
Michael Comella 40fed783ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: integrate Jetback Benchmark (microbenchmark). 3 years ago
Christian Sadilek 35538a209f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16330: Remove remaining usages of Sentry.capture 3 years ago
Mozilla L10n Automation Bot 64571cf4c7 [fenix] Import l10n. 3 years ago
codrut.topliceanu 8541d3f449 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20367 - Fixes removeAllTabs adding to recently closed
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
3 years ago
Arturo Mejia 24e2991759 [fenix] Fix search_add_custom_engine_search_string_example lint warning. 3 years ago
jhugman cc44b33f9d [fenix] Allow branch enrollment and unenrollment in Nimbus secret menu (https://github.com/mozilla-mobile/fenix/pull/20050)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
codrut.topliceanu 8e35c61327 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15499 - Smoothly updates topSites list on remove
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
3 years ago
Mozilla L10n Automation Bot b8836b3eec [fenix] Import l10n. 3 years ago
Mugurell 603bbdd520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Temporarily disable SearchTest#shortcutButtonTest 3 years ago
Sebastian Kaspari b637a576f2 [fenix] Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1. 3 years ago
Sebastian Kaspari d9ca412bec [fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 3 years ago
Jonathan Almeida 0522cbe007 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20402: Disable LastMediaAccessMiddleware temporarily
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.

The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.

For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
3 years ago
Mozilla L10n Automation Bot cccfc982f5 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot ed598f1183 [fenix] Import l10n. 3 years ago
Roger Yang 9df7c99ed2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19847: Add telemetry for the default browser notification 3 years ago
Oana Horvath 276cd60ed4 [fenix] No issue: adds warning comment to beta & release running tests 3 years ago
Roger Yang 674dbafd94 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20307: Clear sharedViewModel selectedFolder when backing out of bookmark fragment 3 years ago
Roger Yang 213df0b403 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19989: Add rounded corners to recently tabs' icon 3 years ago
Mugurell e469026805 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19933 - Show a media tab item on homescreen for the last tab with media 3 years ago
Roger Yang e671e5314e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19846: Make sure default browser notification only happens once 3 years ago
Mozilla L10n Automation Bot 814f0ef0c9 [fenix] Import l10n. 3 years ago
Mugurell 1c733e918e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20229 - Use the AC common implementation for ads/search telemetry
Everything should work exactly as before.
3 years ago
mcarare ef09a9c0e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20292: Use tint for home button icon. 3 years ago
mcarare e44cc8ee69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17808: Remove deprecated systemUiVisibility and flags. 3 years ago
Mozilla L10n Automation Bot abfbbbae16 [fenix] Import l10n. 3 years ago
Oana Horvath 972c83ea36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10915: fix tests by removing existing session 3 years ago
Rohan Maity a92ae5b9b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1268 Add Unit test for PrivateShortcutCreateManager 3 years ago
Mozilla L10n Automation Bot 44ddf895ce [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot fc9aa22b9a [fenix] Import l10n. 3 years ago
Jonathan Almeida c12a5b98ba [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20320: Use scope from testDispatcher in RecentBookmarksFeatureTest 3 years ago
Jonathan Almeida c695a5c533 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20267: Filter out network errors from Nimbus 3 years ago
Marc Leclair 4cbc383520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Restore logic to original behavior 3 years ago
Marc Leclair e4d8d3e9a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: checkDefaultBrowser moved to helper function 3 years ago
Marc Leclair 6c2115cf4a [fenix] For 19804:Fixed call order in the 3 years ago
Marc Leclair 6e811abdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Changed `var isDefaultBrowser` to a function
The change to the function makes it so when the Settings.kt class is initialized, the isDefaultBrowser, which calls the
BrowserCache, won't get called right away. `isDefaultBrowser()` is known to take quite a while on start up on the G5+ (approx
30-40ms).
3 years ago
Michael Comella aac9149bb5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20127: fix app_received_intent extras.
Apparently, it had been using the wrong mapping this whole time. I can't
wrap my head around fenix's glean wrapper so I'm not sure if this
resulted in bugs or if my change changes the behavior. However, I don't
think anyone is using this probe so I'm requesting to remove it. If we
don't end up removing it, then we can check for bugs/changes in
behavior. This isn't ideal but I'd rather not spend the time on it if we
don't have to.
3 years ago
Michael Comella 154defa3b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup from metrics.yaml. 3 years ago
Michael Comella f59df714f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup integration. 3 years ago
Mozilla L10n Automation Bot f183e9a9ef [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 44e9c55c64 [fenix] Import l10n. 3 years ago
Roger Yang 37758f8934 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20285: Remove unused GeckoProvider 3 years ago
Elise Richards 611774676d [fenix] For FNX-22339: Recently saved bookmarks (https://github.com/mozilla-mobile/fenix/pull/19835)
* Title and button for home screen recently saved bookmarks section

Create bookmark item view with favicon and title

* View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

Make a use case for retrieving and updating the list of recently saved bookmarks

Add adapter items and define header viewholder binding

Use session interactor for header button clicks. Bind in the adapter

* Retrieve list of bookmarks asynchronously on home

Interactor and controller tests

Address review comments

Split up tests for recent bookmarks

Update to new interactors

Dark mode and light mode styles

Refactor bookmarks home stuff

* Add RecentBookmarksFeature to home

Move interactor to SessionControlInteractor

Clean up lint, styles, and dimens.

* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.

* View holder tests

* Match ux to designs for colors, margins, and scrolling

* Clean up clean up

* Tests for the view bound feature

* Controller test

* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Mozilla L10n Automation Bot b76fe64eb3 [fenix] Import l10n. 3 years ago
Roger Yang 38cce79e1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Update default browser notification strings 3 years ago
Roger Yang 9fdd99943e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Only add default browser notification work if work is not pending 3 years ago
Roger Yang 048abd7f4c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Show Default Browser Notification if browser is not default 3 years ago
codrut.topliceanu 02d170a5b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20257 - Sets min no. of grid columns to 2 in TabsTray 3 years ago
codrut.topliceanu ae19555d25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20250 - Adds FLAG_SECURE to TabsTray dialog 3 years ago
codrut.topliceanu c805dd3320 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17855 - Stops SecureWindowFeature from removing FLAG_SECURE 3 years ago
Mozilla L10n Automation Bot da25ab1b8e [fenix] Import l10n. 3 years ago
Grisha Kruglov 21dda6b6ab [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20276: Fall-back to URL parsing for tabs with parents to obtain search terms 3 years ago
Oana Horvath 1fa807ca1f [fenix] No issue: New UI smoke test for the Language menu 3 years ago
mcarare 42bfec3846 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20029: Remove animations when recreating activity on locale change. 3 years ago
codrut.topliceanu 55c0be886f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Adds kdoc to TopSitePagerPayload 3 years ago
codrut.topliceanu 58657ebdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Fixes top sites refresh and interactability 3 years ago
Mozilla L10n Automation Bot a2c509b9af [fenix] Import l10n. 3 years ago
Roger Yang d6150b8310 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20274: Limit about:config to Nightly and Beta 3 years ago
Roger Yang 50101046c3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090: Show snackbar on adding to bookmarks from tabs tray 3 years ago
mcarare 613671c9c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in onboarding cards. 3 years ago
Christian Sadilek c3ebf3d738 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20123: PlacesException when recording history metadata 3 years ago
Jonathan Almeida 34199d5b72 [fenix] Move Nimbus strings to static_strings
Goes with 6bb89f346e01edd431056bfcd7472bc3082a39a5
3 years ago
mcarare 84a2627f91 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20219: Fix constraints in sign-in onboarding card. 3 years ago
mcarare 83c15a1331 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20154: Override AC fill colors for icons. 3 years ago
Mozilla L10n Automation Bot 0abec99757 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 8a554e5c76 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 00a1478e5d [fenix] Import l10n. 3 years ago
codrut.topliceanu 98ac6d30c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19558 - Adds proper tint to "Report Site Issue" 3 years ago
Oana Horvath 1953a9cafe [fenix] For https://github.com/mozilla-mobile/fenix/issues/20000: Re-try swipe on collection items 3 years ago
Mozilla L10n Automation Bot a0bb1ae5d3 [fenix] Import l10n. 3 years ago
Codrut Topliceanu b1d830e323 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check (https://github.com/mozilla-mobile/fenix/pull/20203)
* For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check
3 years ago
mcarare 1880077575 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20190: Mirror back button in RTL. 3 years ago
mcarare 3564817bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/20154: Override AC fill colors for icons. 3 years ago
Mozilla L10n Automation Bot 0b60001784 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot a6aff234b1 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot a5090ad038 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 274d3cb6d4 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 21c459705f [fenix] Import l10n. 3 years ago
Oana Horvath 546cd82033 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20123: Disable historyMetadataFeature flag 3 years ago
Mozilla L10n Automation Bot 1913986dcf [fenix] Import l10n. 3 years ago
Travis Long ea8738967d [fenix] [SDK-279] Adds a way to switch to the "preview" collection in Nimbus
This adds a toggle/switch to the debug settings menu that causes Nimbus to use the "preview" collection rather than the "main" collection when it initializes.  Since it is only applied during init, it does require a restart in order to take effect.
3 years ago
Gabriel Luong 69f2e22a04 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19951 - Use Proton icon for new home button 3 years ago
Arturo Mejia ca851a38be [fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Fix the default autoplay setting to be block audio only 3 years ago
Mozilla L10n Automation Bot 16b1b94fbe [fenix] Import l10n. 3 years ago
Mugurell f9c1338826 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20046 - Show the last accessed tab in Jump back in 3 years ago
jhugman fad92d06fa [fenix] Add error reporting via sentry to Nimbus caught exceptions (https://github.com/mozilla-mobile/fenix/pull/20049) 3 years ago
Roger Yang 2ef093a35e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19182: Close Tabs Tray when sharing completes 3 years ago
Roger Yang 63775af142 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19921: Update appcompat and fragment dependencies to 1.3.x 3 years ago
Mozilla L10n Automation Bot ee875b2474 [fenix] Import l10n. 3 years ago
Arturo Mejia 51f0ba6668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Update the default autoplay setting to be block audio only 3 years ago
Jonathan Almeida 3e2f501795 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20054: Update recent tab on title or icon changes 3 years ago
Arturo Mejia 10e4bf1d7f [fenix] Improvements to site permissions 3 years ago
codrut.topliceanu b511e4a8b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19739 - Adds start tabsTray with multiSelect support 3 years ago
codrut.topliceanu 33eaa6f12d [fenix] For https://github.com/mozilla-mobile/fenix/issues/16330 - Replaces Sentry.capture with submitCaughtException 3 years ago
Mozilla L10n Automation Bot a75b7c0202 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 5e75d4852a [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 67f595df8c [fenix] Import l10n. 3 years ago
Mugurell 08222b299a [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Remove FenixAccountManager#authenticatedAccount
This api had a bug stemming from the property name - authenticatedAccount which
may return even an unauthenticated account.
After the recent refactorings it was left unused so best to remove it to
prevent from future misuses.
3 years ago
Mugurell c2b11553f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Use the FXA email only if the account is authenticated
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
3 years ago
Mugurell 60725fc1f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Remove FenixAccountManager#signedInToFxa
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
3 years ago
Mugurell 00e54ff915 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Home menu: go to problems page if account exists but not signed in 3 years ago
Mugurell 4873b79123 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Browser menu: go to problems page if account exists but not signed in 3 years ago