smatz
0c10daa243
(svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index)
2009-05-17 01:00:56 +00:00
smatz
d495dc5dbc
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
yexo
d489f93473
(svn r16315) -Codechange: move the autorenew settings to a new CompanySettings struct
2009-05-15 23:55:06 +00:00
frosch
65b47ddc52
(svn r15692) -Fix [FS#2721]: Just sell the old engines after autorenew/replace. Don't bother about trains exceeding the trainlimit, which will be sold anyway.
2009-03-12 19:40:16 +00:00
smatz
c622a81fee
(svn r15680) -Cleanup: remove redundant comment
2009-03-12 10:42:02 +00:00
rubidium
5c8cf85613
(svn r15434) -Codechange: bit of type safety for the DC_xxx flags.
2009-02-09 21:20:05 +00:00
smatz
9021c20b5e
(svn r15299) -Cleanup: remove many redundant includes
2009-01-31 20:16:06 +00:00
rubidium
e83cca7d13
(svn r14754) -Codechange: get rid of _cmd_text and just pass it as (optional) parameter.
2008-12-28 14:37:19 +00:00
frosch
e9347b39e5
(svn r14442) -Fix (r14406): Typo causing problems in rare cases.
2008-10-05 18:42:59 +00:00
rubidium
e589c7e580
(svn r14422) -Codechange: also reflect the changes of r14421 in the filenames.
2008-09-30 20:51:04 +00:00
rubidium
f56e630e5c
(svn r14421) -Codechange: rename all player variables/types to company *or* client so it is immediatelly clear which one you are working with.
2008-09-30 20:39:50 +00:00
frosch
60e5d69ec4
(svn r14411) -Fix (r14406): IsFrontEngine() is only valid for trains.
2008-09-28 15:07:03 +00:00
frosch
e8038cbf58
(svn r14407) -Cleanup (r14406): Remove a redundant test. (thanks SmatZ)
2008-09-27 17:08:03 +00:00
frosch
32289ebd63
(svn r14406) -Fix [FS#Eddi]: Autoreplace did not work for vehicles in free wagon chains.
2008-09-27 14:58:46 +00:00
smatz
aef674d858
(svn r14337) -Codechange: use CmdRename* and CMD_RENAME_* for vehicle, president and company renaming commands, too
2008-09-15 22:58:41 +00:00
rubidium
4ea5308d49
(svn r14306) -Codechange: unify the code to draw the vehicle list.
...
-Fix [FS#2292]: inconsistency between drawn vehicle lists in the vehicle list and group windows.
2008-09-13 10:04:36 +00:00
smatz
1294253d68
(svn r14174) -Fix: since now, we are 'losing' things, not 'loosing'
2008-08-25 20:10:45 +00:00
frosch
7ef5905b8c
(svn r14126) -Codechange (r14125): Add some tabs.
2008-08-21 20:45:52 +00:00
frosch
ec30cfeff3
(svn r14125) -Fix [FS#2237]: Segfault when autoreplace failed very early.
...
Note: Proper indenting in next commit.
2008-08-21 20:42:45 +00:00
frosch
99ac60e5e1
(svn r14091) -Cleanup (r14083): Remove superfluous '#include's.
2008-08-17 11:49:35 +00:00
frosch
fc8997bcc3
(svn r14085) -Cleanup (r14083): Remove no longer used functions.
2008-08-16 14:15:32 +00:00
frosch
92f3c368b8
(svn r14083) -Fix [FS#1264, FS#2037, FS#2038, FS#2110]: Rewrite the autoreplace kernel.
2008-08-16 14:02:20 +00:00
frosch
110a9f8fc0
(svn r14037) -Fix (r8610): The autoreplace gui showed vehicle types for replacement which CmdSetAutoReplace() did not accept.
2008-08-10 15:02:21 +00:00
frosch
5bcf7de45a
(svn r14031) -Fix (r13850): Determining the refit cargo did not work, when the old vehicle did not carry anything but the new one did.
2008-08-09 16:42:55 +00:00
frosch
a3662216ee
(svn r13850) -Fix [FS#2146]: Fix resp. implement refitting of articulated vehicles during autoreplace.
2008-07-27 15:17:16 +00:00
smatz
f1c0555d2e
(svn r13816) -Fix [FS#2150]: check for vehicle length changes outside a depot (callback 0x11) and give a warning about that
2008-07-24 15:19:26 +00:00
smatz
a47b118a80
(svn r13691) -Codechange: make it easier to determine whether a command is ran in the context of autoreplace or not
2008-07-09 20:55:47 +00:00
rubidium
8ff56af53d
(svn r13146) -Codechange: vehicle_base.h doesn't need to be included in vehicle_gui.h.
2008-05-17 20:54:18 +00:00
rubidium
373343cef6
(svn r13100) -Codechange: reduce the amount of parameters passed via AddNewsMessage as there is (for each news message type) a tuple of 4 parameters that is the same for all calls.
2008-05-15 13:39:36 +00:00
bjarni
5a7fcf9aa3
(svn r13002) -Fix (r13001): [autoreplace] previous fix broke updating of a pointer to the front vehicle in certain cases
...
Now it's updated when it's the front vehicle and it's every time it's the front vehicle and only if it's the front vehicle (nomatter if the replacement works or not)
2008-05-07 23:00:11 +00:00
bjarni
addcd2bb2e
(svn r13001) -Fix [FS#1994](r12913): [autoreplace] we should stop working on vehicles right away if we fail to replace them and certainly not presume their data is valid
2008-05-07 22:08:20 +00:00
bjarni
63fea0790b
(svn r12940) -Fix [FS#1974](r12913): [autoreplace] a vehicle backup should include the cargo packets in the vehicle as well
2008-05-04 10:05:35 +00:00
bjarni
783e20a263
(svn r12913) -Add: ability to backup and restore a player's economic data and data for a vehicle (or chain of vehicles)
...
Autoreplace uses this with the following benefits:
-Mass autoreplace (the button in the depot window) will now estimate costs correctly
-Autoreplace now either replaces correctly or manages to keep the original vehicle (no more broken trains)
Thanks to Ammler for testing this
2008-04-27 20:09:29 +00:00
bjarni
fa4967d845
(svn r12797) -Codechange: [autoreplace] moved wagon removal to a function of it's own
2008-04-19 22:51:52 +00:00
bjarni
fa549be09e
(svn r12794) -Doc: added missing doxygen comment in autoreplace_cmd.cpp
2008-04-19 19:01:57 +00:00
bjarni
db403cbe92
(svn r12792) -Codechange: [autoreplace] added a function to figure out if a replacement is needed and if so, to which EngineID
...
It's designed to save a bit of CPU time, specially if the replacement isn't buildable (think autorenew of old vehicle)
2008-04-19 17:47:56 +00:00
bjarni
44145548ea
(svn r12791) -Codechange: [autoreplace] Added a flag parameter (listens for DC_EXEC and DC_QUERY_COST) and included more info when returning CommandCost
...
This allowed cleaning up the code in MaybeReplaceVehicle()
2008-04-19 15:14:20 +00:00
rubidium
6d063c3ad6
(svn r12754) -Codechange: split depot.h into depot_map.h, depot_func.h and depot_base.h and remove quite a lot of unneeded (before this) includes of depot.h.
2008-04-17 19:10:30 +00:00
rubidium
3edb967ecf
(svn r12586) -Codechange: do not access an order's refit variables directly.
2008-04-06 07:07:21 +00:00
rubidium
df1d9bd880
(svn r12490) -Codechange: rename engine.h to engine_func.h and remove unneeded inclusions of engine.h and/or replace them with engine_type.h.
2008-03-31 00:17:39 +00:00
rubidium
b84b16cfcd
(svn r12488) -Codechange: split order.h into order_base.h and order_func.h.
2008-03-30 23:24:18 +00:00
rubidium
2426f5342f
(svn r12459) -Codechange: split news.h into news_type.h and news_func.h.
2008-03-28 08:53:36 +00:00
bjarni
b05919cc5a
(svn r12421) -Feature: [autoreplace] the autoreplace button in train depots will now also replace wagons even if they aren't connected to a locomotive
...
fixed estimated cost in CmdDepotMassAutoReplace() (will still not estimate wagon removal profits)
Made it possible to command CmdDepotMassAutoReplace() to either replace everything or nothing (the button will still happily replace just some of the vehicles if cash premits)
2008-03-25 21:58:13 +00:00
frosch
0689524481
(svn r12346) -Fix [FS#1748, FS#1825](r9874, r11872): Remove duplicated and inconsistent code wrt. autoreplace with rules in both vehicles' group and ALL_GROUP.
2008-03-06 10:39:26 +00:00
bjarni
801bd045fe
(svn r12231) -Cleanup (r12230): [autoreplace] moved Vehicle::NeedsAutorenewing() and added comments
2008-02-23 22:23:06 +00:00
bjarni
973d1fd6ad
(svn r12230) -Codechange: [autoreplace] made a function to detect if a vehicle needs autorenewing
...
This will remove duplicated code and ensure that the check is consistent
2008-02-23 22:01:55 +00:00
belugas
33e63a3adc
(svn r12040) -Codechange: Change IsOrderListShared from a simple function to a class member(MagicBuzz).
2008-02-02 02:45:09 +00:00
bjarni
9fdf784b7c
(svn r11929) -Fix (r9981)[FS#1624]: [autoreplace] fixed a case where a single headed locomotive caused an assert when being replaced to a dualheaded one
...
This triggered if the player had enough money to replace and refit one of them but not enough to refit the last one as well
2008-01-19 23:34:52 +00:00
bjarni
52e5f50158
(svn r11928) -Fix (r6393): [autoreplace] autoreplace could refit train engines to the wrong cargo type if the old engine had no cargo capacity and the new one had
...
Now autoreplace will always look at the wagons to figure out what to replace to (as originally intended)
2008-01-19 22:47:07 +00:00
rubidium
90acd52f22
(svn r11828) -Codechange: include table/* as the last includes and remove an unneeded include from openttd.h.
2008-01-13 01:21:35 +00:00
peter1138
0f7392bd61
(svn r11822) -Codechange: Replaced fixed size custom name array. Names are now attached to their object directly and there is
...
no limit to the amount of names.
-Fix: NewGRF engines could not be renamed.
2008-01-12 19:58:06 +00:00
rubidium
2fc62eab05
(svn r11818) -Codechange: split player.h into smaller pieces.
2008-01-12 14:10:35 +00:00
rubidium
0365c1f33b
(svn r11793) -Codechange: pass the expense type via the CommandCost instead of a global variable. Patch by Noldo (FS#1114).
2008-01-09 16:55:48 +00:00
rubidium
e2f7ec1d3e
(svn r11775) -Codechange: move all autoreplace/autorenew functions to a single location.
2008-01-07 09:19:53 +00:00
rubidium
444e77d8bc
(svn r11774) -Change: do not include variables.h in a header when it is not needed.
2008-01-07 00:57:19 +00:00
rubidium
722613f7f3
(svn r11706) -Codechange: split vehicle.h and remove another bunch of useless includes.
2007-12-27 13:35:39 +00:00
rubidium
81bf9f8503
(svn r11692) -Codechange: move some functions from 'functions.h' to a more logical place and remove about 50% of the includes of 'functions.h'
2007-12-25 11:26:07 +00:00
rubidium
766551b0bc
(svn r11677) -Codechange: move price and command related types/functions to their respective places.
2007-12-21 21:50:46 +00:00
rubidium
8427b8bad2
(svn r11675) -Codechange: split the string types from the string functions.
2007-12-21 19:49:27 +00:00
smatz
3b59b68a15
(svn r11625) -Codechange: add CO_* enum at some places, add includes of order.h too
2007-12-12 14:37:35 +00:00
skidd13
3ae50673a3
(svn r11484) -Codechange: Remove the doubled function SetBitT and rename the remaining to fit with the naming style
2007-11-20 13:35:54 +00:00
skidd13
c0a2c0c23e
(svn r11481) -Codechange: Rename the HASBIT function to fit with the naming style
2007-11-19 21:02:30 +00:00
bjarni
128e71cde9
(svn r11046) -Codechange: added function to get the next movable (non-articulated, non-read end of dualheaded engine) vehicle in a train
2007-09-05 10:33:42 +00:00
bjarni
7cd2aeb1c9
(svn r11045) -Codechange: added a function to tell if a vehicle is the rear part of a dualheaded train engine
2007-09-05 10:15:23 +00:00
bjarni
9e5376fefe
(svn r11044) -Fix (r11043): [autoreplace] a proper fix should cover all cases, not just the one mentioned in the bug report
...
Certain dualheaded/articulated consists could still trigger this issue
2007-09-05 09:31:15 +00:00
bjarni
b50a3d7522
(svn r11043) -Fix (r10039) [FS#1185]: Autorenew/autoreplace fails silently with multiple multi-headed engines
2007-09-04 19:58:18 +00:00
rubidium
732845440a
(svn r11011) -Fix [FS#1129]: GetFirstVehicleInChain did change the game state while being marked const.
...
-Codechange: do not brute force determine the first vehicle in the chain or previous vehicle, but do it by properly accounting the previous and first pointers when updating the next pointer. This gives a performance increase of about 15% when there are a lot of vehicles in the game.
2007-08-30 21:11:12 +00:00
rubidium
235ad4ab6b
(svn r11003) -Codechange: replace Vehicle->next to Vehicle->Next() and Vehicle->SetNext() so we can trap instances that change a next pointer and (in the future) update the first/previous pointers based on that.
2007-08-30 13:03:56 +00:00
rubidium
13692798e6
(svn r10567) -Add [FS#915]: a "group" with ungrouped vehicles. Patch by Matthias Wolf.
2007-07-14 23:10:27 +00:00
peter1138
3878c55f34
(svn r10314) -Codechange: Refer to vehicle names by index
2007-06-24 22:42:11 +00:00
rubidium
fc201d4ad8
(svn r10266) -Codechange: keep track of the origin, time of travel and accumulated feeder share (transfers) of individual pieces of cargo. This means that cargo isn't thrown on a big pile when it's put in a station or unloaded at a station, however the GUI does not reflect these changes yet so you will not actually see it.
2007-06-22 11:58:59 +00:00
rubidium
0d8e82b7d7
(svn r10246) -Fix (r10297): some forgotten money conversions and truncation issues. Thanks to benc for providing the patch.
2007-06-21 14:32:27 +00:00
rubidium
7dda2d93da
(svn r10207) -Codechange: remove the redundant player_money in favour of the money64, which is now renamed to player_money.
2007-06-18 21:00:14 +00:00
rubidium
773a7c9cb6
(svn r10205) -Codechange: refactor returning of cost, so it can be more easily modified.
2007-06-18 19:53:50 +00:00
rubidium
3ccc83e640
(svn r10197) -Codechange: replace int32 with CommandCost where appropriate.
2007-06-18 10:48:15 +00:00
bjarni
1026c865fd
(svn r10039) -Fix: [autoreplace] when trying to replace an engine that can't carry the wagons the old one carries (GRF restrictoin), then don't try to replace at all
2007-06-04 20:46:01 +00:00
bjarni
eecf582cc4
(svn r9982) -Fix (r9874): autoreplacing vehicles from a group could sometimes add the new vehicle twice to the engine (EngineID, not total count) count in the group
2007-05-29 20:52:35 +00:00
bjarni
6ce4211ad5
(svn r9981) -Fix: fixed a rare event that could cause autoreplace to run out of money and generate an error (spotted by elmex and UndernotBuilder)
...
This happened if the new engine was a dualheaded engine and there was money to replace and refit the front, but not the rear
It also adds the cost of refitting the rear end of dualheaded engines to the cost animations (display only)
2007-05-29 20:06:06 +00:00
bjarni
bcb668c2ff
(svn r9967) -Fix (r9938): autoreplace would in certain conditions move dualheaded engines in a train (usually to the rear)
...
-Change: moving an engine in between the two ends of a dualheaded engine will now move the rear dualheaded engine to the front of the newly added engine (instead of moving the new engine to the rear of the rear dualheaded engine)
This can make a difference if there are wagons in the train
2007-05-28 21:40:40 +00:00
bjarni
3963b48f17
(svn r9938) -Fix [FS#799]: 100 wagons train + replace engine
...
Replacing a unit in a train will now remove the old unit before adding the new one. This will solve issues when max train length has been reached
2007-05-26 17:00:44 +00:00
rubidium
6ef7915e6e
(svn r9881) -Fix (FS#782, r9874): accidentally removed one condition too many causing asserts.
2007-05-19 20:15:50 +00:00
rubidium
86bb5cc2a6
(svn r9878) -Fix (9874): some vehicle count's were not properly updated on delete or autoreplace of vehicles.
2007-05-19 12:29:09 +00:00
rubidium
8f0f090c51
(svn r9874) -Feature: advanced vehicle lists a.k.a. group interface. Now you can make groups of vehicles and perform all kinds of tasks on that given group. Original code by nycom and graphics by skidd13.
2007-05-19 09:40:18 +00:00
bjarni
5eb076402f
(svn r9753) -Fix [FS#732]: trains are lost after autorenewal/autoreplace
...
v->dest_tile is now copied when replacing the front engine
2007-04-29 20:16:58 +00:00
bjarni
809888fa21
(svn r9688) -Codechange: Created a function to get default cargo type for a cargo type
2007-04-20 16:56:55 +00:00
rubidium
7577954ced
(svn r9672) -Cleanup: lots of coding style fixes around operands.
2007-04-18 22:10:36 +00:00
bjarni
b6efe5482d
(svn r9073) -Codechange: moved autoreplace to a file of it's own (now autoreplace has a cmd and a gui file)
2007-03-08 23:05:05 +00:00
