Archives/OpenTTD-patches
2
0
Fork 0
mirror of https://github.com/JGRennison/OpenTTD-patches.git synced 2024-11-19 15:25:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
28,320 Commits 12 Branches 180 Tags 451 MiB
0bc22dd310
Commit Graph

21450 Commits

Author SHA1 Message Date
Peter Nelson
09d01bd015
Fix: Restore original cargo legend 'blob' dimensions. (#11480) 
An off-by-one in a previous life made the 'blob' too narrow.
 2023-11-21 19:51:24 +00:00
Peter Nelson
c2f19fed24
Fix: Widget without tooltip should use STR_NULL not STR_EMPTY. (#11482) 2023-11-21 19:35:47 +00:00
Peter Nelson
c18a1494b7
Codechange: Remove FONT_HEIGHT_... macros. (#11481) 
These make it look like we're dealing with a constant, but actually each is a call to `GetCharacterHeight(...)`.
 2023-11-21 19:04:24 +00:00
translators
96ec9c1b47 Update: Translations from eints 
indonesian: 67 changes by ekaknl22
 2023-11-21 18:40:02 +00:00
Peter Nelson
0d60dc0353 Fix 96d98d08: Crash in text layouter due to trying to find height of string with zero-width. 
96d98d08 removed the hardcoded minimum width in favour of all-calculated widths, however this does not work when determining multiline text sizes.
 2023-11-20 23:09:20 +00:00
Peter Nelson
62d4fd0572 Codechange: Add method to guess the width/height required for a multiline string. 
This is necessary for widget layouts where a minimum width is not yet known during UpdateWidgetSize().
 2023-11-20 23:09:20 +00:00
Peter Nelson
f281525492 Codechange: Add method to resize both width and height of a widget. 2023-11-20 23:09:20 +00:00
Peter Nelson
d04fd4602d Codechange: Assert that max width passed to GetStringHeight is non-zero. 
Max width of zero will cause text layouters to crash, potentially after exhausting memory first.
 2023-11-20 23:09:20 +00:00
Peter Nelson
0578b8eaa9
Change: Use picker-spacing for scenario found town window. (#11478) 2023-11-20 23:06:15 +00:00
Peter Nelson
a58a043402
Fix 6065122: Missing SetFill on worldgen spacer. (#11477) 2023-11-20 19:31:26 +00:00
Jonathan G Rennison
9822fa6584
Fix: Trivial autoreplace of mixed cargo articulated engines (#11253) 
Do not fail autoreplace/autorenew of mixed cargo articulated engines
due to an inability to refit to mixed cargoes, when no refit is
required because the target engine already has a suitable set of cargoes.
Notably, this allows autorenew (autoreplace to same engine type)
to succeed.
 2023-11-20 14:16:28 +01:00
Peter Nelson
96d98d08c8
Change: Use sparse padding for main intro menu. (#11475) 2023-11-20 01:12:25 +00:00
Peter Nelson
c80fa7d752
Codechange: Simplify setting minimum width for game options dropdown lists. (#11474) 
Height isn't necessary as drop down controls already have sufficient height, so we can use GetDropDownListDimension() to get the width.
 2023-11-20 00:44:06 +00:00
Peter Nelson
f58a7ef673
Codechange: Remove now-unnecessary containers in picker layouts. (#11473) 
These are no longer necessary as the issue they work around was resolved by #11471
 2023-11-20 00:14:06 +00:00
Peter Nelson
293a26f248
Change: Use sparse padding and SETTING_BUTTON sizes for custom currency window. (#11472) 2023-11-19 21:12:55 +00:00
Peter Nelson
05b55c4d43
Fix: Extra space allocated to container-within-container may not get allocated to children. (#11471) 
Always derive additional length from contained widgets instead of from the container, as the container's minimal length may have been adjusted by an NC_EQUALSIZE parent container.
 2023-11-19 00:36:53 +00:00
translators
29102ce42c Update: Translations from eints 
dutch: 1 change by Afoklala
 2023-11-17 18:38:21 +00:00
Peter Nelson
08778094f4
Fix: extmidi did not move on to next song after playing ends. (#11469) 
`song` is no longer a C-style string so cannot be cleared by writing a NUL char.
Use `.clear()` to properly clear a std::string.
 2023-11-17 17:42:19 +00:00
Peter Nelson
b2d4d90502 Change: Apply interface scaling to NewGRF settings min/max sizes. 2023-11-16 20:54:51 +00:00
Peter Nelson
42ae61a4fe Change: Use sparse padding for NewGRF settings window. 2023-11-16 20:54:51 +00:00
Peter Nelson
cdb4e98a15
Change: Use sparse padding for AI/GS settings windows. (#11466) 2023-11-16 20:02:07 +00:00
Peter Nelson
f93711838f
Fix 6317967: Missing exception for SetPipRatio(). (#11465) 2023-11-16 19:22:02 +00:00
Peter Nelson
60651227a0
Change: Simplify world gen widgets and use sparse padding. (#11464) 2023-11-16 18:58:59 +00:00
translators
bca321443a Update: Translations from eints 
french: 1 change by Lishouuu
 2023-11-16 18:39:24 +00:00
Peter Nelson
7d48a3f073
Codechange: Move RectPadding::zero definition to header. (#11461) 
This potentially allows better inlining/optimization.
 2023-11-16 17:07:29 +00:00
Peter Nelson
e2e0753916
Codechange: Use GetCurrentRect() where feasible. (#11460) 2023-11-16 17:06:57 +00:00
Peter Nelson
17ceed0241
Change: Use sparse padding for Game Options window. (#11463) 2023-11-16 17:06:38 +00:00
Peter Nelson
306e75223a Change: Adjust layouts and standardize spacing for company-related windows. 2023-11-15 12:43:44 +00:00
Peter Nelson
58c037fba0 Change: Increase finance window lines (and underlines) with interface scale. 2023-11-15 12:43:44 +00:00
translators
1dff1e34f6 Update: Translations from eints 
tamil: 3 changes by Jeyanthinath
 2023-11-14 18:36:57 +00:00
Peter Nelson
7cfcf65f95 Codechange: Simplify cargo filter lists, building only when required. 
Some cargo filter lists were built in advance, and used as lookups to test which cargo type to filter.

Instead, use the Cargo ID directly as the filter parameter, and build the lists only when the drop down list is used.
 2023-11-13 21:30:46 +00:00
Peter Nelson
08dfe35442 Codechange: Move DropDownList height and width calculation to helper. 2023-11-13 21:30:46 +00:00
translators
1242b355e5 Update: Translations from eints 
danish: 1 change by bscargo
polish: 1 change by pAter-exe
 2023-11-13 18:38:10 +00:00
Peter Nelson
c877494f7a
Codechange: Simplify autoreplace rail/road types by using separate widget. (#11457) 
This avoids needing to determine which type of list to deal with by additionally checking the window number for VEH_TRAIN/VEH_ROAD.
 2023-11-13 12:32:34 +00:00
Tyler Trahan
7a6d102c4b
Codechange: Clean up timetable start checks (#11456) 2023-11-13 07:19:39 -05:00
translators
5446ece100 Update: Translations from eints 
vietnamese: 7 changes by KhoiCanDev
korean: 1 change by telk5093
catalan: 7 changes by J0anJosep
 2023-11-12 18:38:05 +00:00
translators
1432511fe5 Update: Translations from eints 
english (au): 1 change by krysclarke
italian: 7 changes by Rivarossi
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
 2023-11-11 18:36:44 +00:00
Tyler Trahan
235ac0bceb
Codechange: Reword rail/road type label constants (#11451) 2023-11-10 17:37:22 -05:00
translators
ef1abbcd1f Update: Translations from eints 2023-11-10 18:38:29 +00:00
Peter Nelson
bd2ddb07ca
Change: Move baseset missing/corrupted files label to list item. (#11455) 
This allows any baseset error to be displayed in the drop down list so it is more easily visible, and avoids wasted space in the layout.
 2023-11-10 12:25:56 +00:00
Peter Nelson
1071acb483
Codechange: Redundant use of char * and c_str(). (#11454) 2023-11-10 00:17:36 +00:00
Peter Nelson
938c8339d2 Codechange: Ensure space between for/if and (. 2023-11-09 20:15:38 +00:00
Peter Nelson
d4008850e3 Codechange: Ensure function opening { is on new line. 2023-11-09 20:15:38 +00:00
Jonathan G Rennison
1de1af08b9
Codechange: Replace AllocatedStringParameters with ArrayStringParameters (#11452) 
All uses of AllocatedStringParameters are with a compile-time fixed
constant.
Use of a dynamically allocated buffer on the heap is unnecessary and
increases overhead, particularly due to frequent use as a temporary.
 2023-11-09 19:43:47 +00:00
translators
92816ac96b Update: Translations from eints 
german: 3 changes by SecretIdetity
romanian: 6 changes by bnegrut
 2023-11-09 18:37:36 +00:00
Peter Nelson
9f90ab7b04
Codechange: Use rail/road type label constants instead of literals. (#11450) 2023-11-08 23:45:08 +00:00
translators
382d7a9076 Update: Translations from eints 
hungarian: 54 changes by titanicbobo
 2023-11-08 18:39:05 +00:00
Peter Nelson
90bd8e64d8 Change: Simplify help window widgets and use sparse padding. 2023-11-07 23:09:05 +00:00
Peter Nelson
55adbe10b7 Add: WidgetDimensions for 'sparse' widget windows. 
These are for windows that have space between widgets instead of being clumped together.
 2023-11-07 23:09:05 +00:00
translators
56657eeaae Update: Translations from eints 
chinese (simplified): 1 change by WenSimEHRP
danish: 1 change by bscargo
hindi: 111 changes by NisheshTyagi
 2023-11-07 18:37:45 +00:00
Peter Nelson
842cf87765 Change: Bring airport picker inline with other pickers. 2023-11-07 18:27:51 +00:00
Peter Nelson
b216dc493f Change: Bring dock picker inline with other pickers. 2023-11-07 18:27:51 +00:00
Peter Nelson
27b5979056 Change: Improve layout of object picker. 2023-11-07 18:27:51 +00:00
Peter Nelson
db18f60beb Change: Improve layout of road/tram stop pickers. 2023-11-07 18:27:51 +00:00
Peter Nelson
61deab08fc Change: Improve layout of station picker. 2023-11-07 18:27:51 +00:00
Peter Nelson
136551408c
Change: Show empty string drop down entries as divider. (#11447) 2023-11-06 22:35:01 +00:00
Peter Nelson
ab535c0a86
Codechange: Add base() method to StrongType to allow access to the base type without casting. (#11445) 
This removes the ability to explicitly cast to the base type, but the requirement
to use .base() means the conversion is still explicit.
 2023-11-06 20:29:35 +00:00
translators
737775f834 Update: Translations from eints 
korean: 14 changes by telk5093
polish: 1 change by pAter-exe
 2023-11-06 18:38:37 +00:00
Peter Nelson
badce415ea Change: Add horizontal scrollbar to Industry Directory window. 
This list could be very wide depending on industries and language.
 2023-11-05 22:22:32 +00:00
Peter Nelson
8ff6562b2f Codechange: Reduce variable scope. 2023-11-05 22:22:32 +00:00
Peter Nelson
6b9dc8cfcf Codechange: Don't filter industry list by cargo type every 3-sec refresh. 
The 3-sec refresh is to update the list sorting. The filter only needs to
be applied once rebuilding the list.
 2023-11-05 22:22:32 +00:00
Peter Nelson
4033750968 Codechange: Remove redundant NWID_VERTICAL in Industry Directory layout. 2023-11-05 22:22:32 +00:00
Peter Nelson
d380f2f3a2 Codechange: Simplify layout of depot pickers. 2023-11-05 20:09:45 +00:00
Peter Nelson
665902f5ba Codechange: Add widget dimensions to standardise picker winodws. 2023-11-05 20:09:45 +00:00
Peter Nelson
3cab980b30 Codechange: Skip invisible (zero-size) widgets in PIP Containers. 
This gets rid of doubled-up spacing where an invisible child widget would be.
 2023-11-05 20:09:45 +00:00
Peter Nelson
6317967dba Codechange: Add ability to allocate PIP-space dynamically by ratio. 
This can be used to space out, centre, start-align, or end-align widgets without additional spacers.
 2023-11-05 20:09:45 +00:00
Peter Nelson
ac54bd7e58 Codechange: Apply PIP during AssignSizePosition() instead of SetupSmallestSize(). 2023-11-05 20:09:45 +00:00
Peter Nelson
43aa91a7f5
Fix #11437: Flipped shorter rail vehicles disappear in windows. (#11446) 
Mixed signed/unsigned strikes again, causing an incorrect sprite offset for shortened vehicles.
 2023-11-05 20:09:11 +00:00
Peter Nelson
a9aaa2a183 Codechange: Don't be lenient with invalid NWidgetPart lists. 
Some NWidgetPart combinations were ignored but it was not clear that they do nothing. Instead, assert if NWidgetPart is incorrectly applied.
 2023-11-05 19:24:59 +00:00
Peter Nelson
b1eb5533eb Add: WindowDesc unit test to validate NWidgetPart lists. 2023-11-05 19:24:59 +00:00
Peter Nelson
1c94fb0389 Add: Mock sprite cache intialization. 
This fills up the sprite cache with SPR_OPENTTD_BASE + OPENTTD_SPRITE_COUNT zero-size sprites, to
allow GetSpriteSize() calls to continue from unit-tests.
 2023-11-05 19:24:59 +00:00
Peter Nelson
05436d9c2f Add: Expose minimal parts of SpriteCache internals. 
These parts are needed to be able to mock the SpriteCache for unit-tests.
 2023-11-05 19:24:59 +00:00
Peter Nelson
46f63074da Add: MockFontCache for testing GUI code that only needs to know font sizes. 2023-11-05 19:24:59 +00:00
translators
af4c7799fe Update: Translations from eints 
korean: 1 change by telk5093
finnish: 1 change by hpiirai
portuguese (brazilian): 1 change by pasantoro
 2023-11-05 18:37:09 +00:00
Peter Nelson
b5861fd8f3
Fix: Using MIN_YEAR for a date is probably wrong, Use MIN_DATE instead. (#11444) 
Even with strong types ...
 2023-11-05 15:43:56 +00:00
Peter Nelson
ef385499c7
Codechange: Remove ineffective NWidgetParts. (#11443) 2023-11-05 14:09:47 +00:00
translators
01728177e7 Update: Translations from eints 
english (us): 3 changes by 2TallTyler
french: 2 changes by Lishouuu
 2023-11-04 18:37:37 +00:00
Michael Lutz
071fdab236 Codechange: Replicate cursor screen backup to chat message display, removing explicit memory management. 
Incidentally, this makes Blitter::GetBytesPerPixel unneeed.
 2023-11-04 16:08:34 +01:00
Peter Nelson
bbd64bbe2b
Fix #9545: Crash when all cargo types are disabled. (#11432) 
This is not a very useful state, but it's nice to not crash.

Some parts of the game don't (yet) check for cargo types being redefined, that is out-of-scope here.
 2023-11-04 14:42:47 +00:00
Patric Stout
c059ce0c97
Fix cda6f24f: don't ignore binary-dir if it happens to be working-dir (#11431) 
Some of our code ignores the SP_WORKING_DIR for some actions, which
means that if, for example, your SP_BINARY_DIR is the same as your
SP_WORKING_DIR, neither is scanned.

Instead, only add SP_WORKING_DIR if it is unique.
 2023-11-04 10:39:18 +00:00
Peter Nelson
db6b32e421
Codechange: Avoid pointers and lengthof in ExpensesList. (#11427) 
Use std::initializer_list which allows iteration.
 2023-11-03 23:15:37 +00:00
Michael Lutz
86e28e79fb Fix #11402: Make string filter locale-aware. 2023-11-03 22:34:01 +01:00
Michael Lutz
c294eaacc1 Fix: char_traits::find needs to return nullptr if nothing was found. 2023-11-03 22:34:01 +01:00
Peter Nelson
7d4a91ef9e
Cleanup: Remove some unused functions. (#11429) 
These were picked up with cppcheck.
 2023-11-03 21:21:00 +00:00
translators
4c58df75fd Update: Translations from eints 
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
dutch: 3 changes by Afoklala
portuguese: 1 change by azulcosta
 2023-11-03 18:38:51 +00:00
Peter Nelson
ce6e739491 Codechange: Add unit-test to check if nested widget parts of properly closed. 
Properly closed means exactly one EndContainer for every Container widget.
 2023-11-03 09:38:41 +00:00
Peter Nelson
e8db137135 Codechange: Move test for Container WidgetType to helper function. 2023-11-03 09:38:41 +00:00
Peter Nelson
d4a77411a5
Fix: Some NWidget lists were not properly closed. (#11425) 2023-11-03 08:17:26 +00:00
Peter Nelson
e563057478 Add: WindowDesc unit test to validate ini-key value. 
ini-key must be present if WWT_DEFSIZEBOX or WWT_STICKYBOX is present.
This was previously enforced by a workflow, however that parsed the source
code with regex which turned out to be error-prone.
 2023-11-02 22:25:01 +00:00
Peter Nelson
18fb8e153f Codechange: Add __FILE__/__LINE__ of WindowDesc to WindowDesc. 
This is to allow unit-tests to produce more useful output.
 2023-11-02 22:25:01 +00:00
Peter Nelson
873f93cab1
Fix: AI config window should not have an ini_key. (#11423) 
This was missed by the workflow script that enforces this constraint.
 2023-11-02 21:28:24 +00:00
translators
82ebc9860b Update: Translations from eints 
finnish: 2 changes by hpiirai
danish: 1 change by bscargo
 2023-11-02 18:38:58 +00:00
Rubidium
a849b4e175 Fix: allow same length server password in the UI 2023-11-02 17:19:38 +01:00
Rubidium
c6411168d8 Cleanup: missing spaces before continuation * in some comments 2023-11-01 22:56:11 +01:00
Peter Nelson
c687b59efc Codechange: Use unique_ptr for SmallMapWindow's overlay. 2023-11-01 21:49:06 +00:00
Peter Nelson
53845bc024 Codechange: Move includes to correct place. 
Some other source file inadvertently included things via smallmap_gui.h
 2023-11-01 21:49:06 +00:00
Peter Nelson
ed8df72c49 Revert 6b68956: Move declaration of SmallMapWindow out of header file. 
This split needlessly complicates `SmallMapWindow` for the sake of one method (no longer) used by `LinkGraphOverlay`.
 2023-11-01 21:49:06 +00:00
Peter Nelson
f91462f54b Codechange: Don't access SmallMapWindow method directly from LinkGraphOverlay. 2023-11-01 21:49:06 +00:00
Peter Nelson
ff5e8bb9a3 Fix #11413: Incorrect sorting by industry production. 
Error caused by single character mistake. However this algorithm was inefficent if a filter was specified, and clearly the flow was error-prone.

Now using separately-scoped loops to avoid similar.
 2023-11-01 21:37:53 +00:00
Peter Nelson
278b42d078 Codechange: Document Industry::GetCargoProduced/Accepted and add const-variant. 2023-11-01 21:37:53 +00:00
Peter Nelson
4f3adc038a Cleanup: Use standard comment codestyle. 2023-11-01 21:37:53 +00:00
Tyler Trahan
49d53c41ab
Doc: Don't use other names for road vehicle bay stops (#11418) 2023-11-01 21:19:31 +00:00
Peter Nelson
d3cb6e1e67
Codechange: Call Widget::SetDirty/SetLowered directly. (#11417) 
In these instances we already have the widget to hand, so don't need to look it up by index again.
 2023-11-01 20:12:08 +00:00
Tyler Trahan
89480f3531
Change: Don't set vehicle on time if timetable not started (#11359) 2023-11-01 15:26:39 -04:00
Peter Nelson
bb50cbb772
Codechange: Assign/StoreSizePosition x/y can be negative. (#11416) 
AssignSizePosition is used with negative values when an NWidgetMatrix is
scrolled, but they were passed as unsigned and then stored as signed.

Widget pos_x/pos_y were already made signed.
 2023-11-01 18:44:23 +00:00
translators
c97120f003 Update: Translations from eints 
english (au): 1 change by krysclarke
chinese (simplified): 5 changes by WenSimEHRP
korean: 2 changes by telk5093
russian: 1 change by Ln-Wolf
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe
 2023-11-01 18:38:53 +00:00
Peter Nelson
35a7770fde
Fix 233aac5: Set newline default comment for new groups. (#11411) 
The newline space between ini groups is actually recorded as a comment of the group. This got inadvertantly dropped in #11364.
 2023-10-31 01:19:04 +00:00
frosch
e81313e93e Feature: Base graphics can offer parameters for additional settings. 2023-10-31 01:41:50 +01:00
frosch
de3f29d7b2 Add: store base graphics parameters in openttd.cfg. 2023-10-31 01:41:50 +01:00
frosch
f09fda1ff0 Codechange: store the GRFConfig of the base graphics, once loaded. 2023-10-31 01:41:50 +01:00
frosch
0b7ecf6102 Codechange: use the shortname as unique id to identify the base graphics in openttd.cfg. 2023-10-31 01:41:50 +01:00
frosch
97df27e41f Codechange: Store base graphics settings in a separate section in openttd.cfg. 2023-10-31 01:41:50 +01:00
Peter Nelson
2d3fef3113 Fix: Incorrect padding for smallmap legend 'icon'. 
The size of this icon is based off FONT_HEIGHT_SMALL - 1, so it makes sense to use a scaled 1 here.
 2023-10-30 22:11:31 +00:00
Peter Nelson
a8aba06a07 Fix: Insufficient space for labels on smallmap legend. 2023-10-30 22:11:31 +00:00
translators
186829b99f Update: Translations from eints 
english (au): 1 change by krysclarke
dutch: 1 change by TrueBrain
portuguese: 1 change by azulcosta
polish: 4 changes by pAter-exe
 2023-10-30 18:38:55 +00:00
translators
40f52afac2 Update: Translations from eints 
indonesian: 1 change by liimee
russian: 2 changes by Ln-Wolf
finnish: 1 change by hpiirai
danish: 1 change by bscargo
french: 1 change by ottdfevr
portuguese (brazilian): 1 change by pasantoro
 2023-10-29 18:37:50 +00:00
translators
9e6ea16ca7 Update: Translations from eints 2023-10-28 18:37:45 +00:00
Peter Nelson
c0aa9a5f87
Add: Debug tool to draw widget outlines. (#11401) 
This is considered a developer tool and is controlled from the help menu (or default hotkey Ctrl-O).

This draws a white dashed outline around widgets. NWidgetSpacer and (unused) WWT_EMPTY widgets are also filled with check pattern to highlight them, as they usually indicate a design issue.
 2023-10-28 19:07:50 +01:00
Peter Nelson
129e98fbab
Fix d42a78f: Some raw drop down list strings may need token processing. (#11400) 
Storing the raw string without processing though GetString() caused token
processing to be skipped.
 2023-10-28 16:08:44 +01:00
Peter Nelson
062c19830b
Fix: OpenTTD can fail to exit on an error due to mutex locks in threads. (#11398) 2023-10-28 16:08:08 +01:00
translators
7b376493a2 Update: Translations from eints 
dutch: 3 changes by Afoklala
french: 1 change by ottdfevr
 2023-10-27 18:38:08 +00:00
translators
7b4ecb5241 Update: Translations from eints 
korean: 3 changes by telk5093
slovak: 1 change by legitalk
polish: 4 changes by pAter-exe
 2023-10-26 18:38:26 +00:00
Peter Nelson
5ae5c35f38 Codechange: Remove redundant WWT_PANEL from bootstrap error windows. 2023-10-26 12:43:20 +01:00
Peter Nelson
a601a1f406 Change: Use modalpopup spacing for goal question windows. 2023-10-26 12:43:20 +01:00
Peter Nelson
616fb48e25 Change: Use modalpopup spacing for engine preview window. 2023-10-26 12:43:20 +01:00
Peter Nelson
19c314ea1f Change: Use modalpopup spacing for buy company window. 2023-10-26 12:43:20 +01:00
Peter Nelson
8a49c0eb2c Change: Use modalpopup spacing for network relay and survey windows. 2023-10-26 12:43:20 +01:00
Peter Nelson
f78c2c9810 Fix: Incorrect title on framerate windows for AIs. 2023-10-25 19:35:42 +01:00
Peter Nelson
d19832569e
Cleanup: No need to cast const Font * to itself. (#11395) 2023-10-25 13:08:07 +00:00
translators
3d7f54472d Update: Translations from eints 
english (us): 3 changes by 2TallTyler
danish: 3 changes by bscargo
polish: 1 change by pAter-exe
 2023-10-24 18:38:34 +00:00
translators
9cdf66d3a1 Update: Translations from eints 
czech: 18 changes by vladoschreiner
german: 27 changes by Wuzzy2
 2023-10-23 18:38:04 +00:00
translators
d1351fa0d2 Update: Translations from eints 
english (au): 3 changes by krysclarke
russian: 3 changes by Ln-Wolf
finnish: 3 changes by hpiirai
turkish: 4 changes by BeratSJ
french: 3 changes by ottdfevr
portuguese: 3 changes by azulcosta
portuguese (brazilian): 3 changes by pasantoro
 2023-10-22 18:37:20 +00:00
Tyler Trahan
92ab114e13
Fix f49ffaa: Use DateAtStartOfYear() to calculate max timetable start date (#11388) 2023-10-22 10:51:06 -04:00
translators
f32058e4e5 Update: Translations from eints 2023-10-21 18:37:29 +00:00
Bernhard Reutner-Fischer
ac42dea7b2 Codechange: Remove unused parameter for Height() 
DropDownListItem::Height does not need to take an argument so remove it

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
 2023-10-21 18:53:35 +02:00
Peter Nelson
59a2abd298 Codechange: Use unified NWidgetContainer methods instead of duplicating. 
Most NWidgetContainer derivatives implemented Draw() and GetWidgetFromPos()
the same way. Move this these to NWidgetContainer itself to avoid repeating.
 2023-10-21 14:26:36 +01:00
Peter Nelson
af41c5cb4e Codechange: Hide toolbar buttons by setting width to zero. 
Zero-width is how widgets are hidden elsewhere.
This removes the need for an extra array to lookup if a button is hidden.
 2023-10-21 14:26:36 +01:00
Peter Nelson
81ecbaaa33 Codechange: Hide multiplayer headers by setting width to zero. 
Zero-width is how widgets are hidden elsewhere.
This removes the need for an extra array to lookup if a header is hidden.
 2023-10-21 14:26:36 +01:00
Tyler Trahan
2dd2910ab3
Feature: Cheat to fix station ratings at 100% (#11346) 2023-10-21 08:35:52 -04:00
Rubidium
37f84b7372 Codechange: replace x.size() != 0 with !x.empty() 2023-10-20 23:05:43 +02:00
Rubidium
f16399f4c9 Codechange: replace x.size() > 0 with !x.empty() 2023-10-20 23:05:43 +02:00
Rubidium
c9276c2959 Codechange: replace x.size() == 0 with x.empty() 2023-10-20 23:05:43 +02:00
Peter Nelson
f06b3e9846
Change: Use CARGO_LIST to show station cargo acceptance changes. (#11379) 
This simplifies construction of the news message and allows for more than
two changes to be show in one line.
 2023-10-20 20:14:46 +01:00
translators
4c24334fda Update: Translations from eints 2023-10-20 18:38:26 +00:00
Peter Nelson
fd6f1e844a
Codechange: Avoid emplace_back(new()) into a unique_ptr. (#11384) 
This could theoretically leave an unmanaged pointer in certain circumstances, and directly using
make_unique shows intent.
 2023-10-20 18:40:48 +01:00
Peter Nelson
429a6f58e7
Codechange: Use max_element to find best cargo (sub-)type in NewGRF var 42. (#11370) 
This replaces two manual loops to find the best cargo (sub-)type.
 2023-10-20 18:40:26 +01:00
Peter Nelson
90351578a6 Codechange: Use std::map instead of fixed array to store refit options. 
This simplifies handling of available refit options.
 2023-10-20 18:39:32 +01:00
Peter Nelson
e4f94747f3 Codechange: Use comparator struct to sort cargo ID by predefined sort order. 
This allows reuse of the comparator where a typename is used instead.
 2023-10-20 18:39:32 +01:00
Peter Nelson
bc8e26f4e7
Codechange: Simplify usage of GRFFile cargo_map. (#11349) 2023-10-20 18:38:54 +01:00
Peter Nelson
69e20e79ab Codechange: Add const versions of GetItem/GetGroup, and sprinkle liberally. 
Non-const version of GetItem is not needed.
 2023-10-20 18:37:27 +01:00
Peter Nelson
17ba9d8c96 Codechange: Use range-for instead of nullptr-terminated list in settingsgen. 
This simplifies iteration and avoids use of pointers.
 2023-10-20 18:37:27 +01:00
Peter Nelson
233aac567b Codechange: Use std::list instead of C-linked list for ini files. 
This removes self-management of memory with new/delete and allows simpler iteration.
 2023-10-20 18:37:27 +01:00
Peter Nelson
ec1cf96b62 Codechange: Move initialization of group-type to CreateGroup function. 2023-10-20 18:37:27 +01:00
Peter Nelson
8bd06807e4 Codechange: Pass initializer list instead of null-terminated list of group types. 2023-10-20 18:37:27 +01:00
Peter Nelson
1fecbeff76 Codechange: Remove create parameter from IniLoadFile::GetGroup. 
GetGroup now only returns nullptr if the group does not exist.
Use GetOrCreateGroup to create a group.

This avoids creating groups while reading ini files.
 2023-10-20 18:37:27 +01:00
Peter Nelson
c47a0e1578 Codechange: Correct scope of IniItem for for-loop. 2023-10-20 18:37:27 +01:00
Peter Nelson
6ce7195ef1 Codechange: Split GetGroup into GetGroup/GetOrCreateGroup. 
This follows the pattern used for GetItem/GetOrCreateItem, and allows use
of references where we know the group must exist.
 2023-10-20 18:37:27 +01:00
Peter Nelson
54b1a067eb Codechange: Test for nullptr instead of treating pointer as boolean. 2023-10-20 18:37:27 +01:00
Peter Nelson
d3c5ae2648 Codechange: Add CreateGroup/CreateItem methods for ini files. 
This abstracts the internals a bit.
 2023-10-20 18:37:27 +01:00
Peter Nelson
0c85ce29ea Codechange: Pass ini file by reference and prefer automatic storage. 
This avoids new/delete operations, and (not) checking for nullptr.
 2023-10-20 18:37:27 +01:00
Peter Nelson
3961318974 Codechange: Accept std::string in RemoveGroup(). 2023-10-20 18:37:27 +01:00
Peter Nelson
bb6fa9bf3b
Change: Display cargo lists in sorted cargo order. (#11383) 2023-10-20 17:32:17 +01:00
Tyler Trahan
088db62dba
Change: Always allow expanding towns in Scenario Editor to build new roads (#11377) 2023-10-19 17:01:45 -04:00
Jonathan G Rennison
4df2640f87 Fix: Tile slope missing from road stops varact2 variable 0x42 2023-10-19 20:05:36 +02:00
Peter Nelson
e1c83869ed
Fix: Scale minimum width for server name by interface scale. (#11381) 2023-10-19 17:06:47 +00:00
Peter Nelson
9602de474d Codechange: Use iterators and/or range-for on cargo related loops. 2023-10-19 17:03:25 +01:00
Peter Nelson
2a88e0fab3 Codechange: Use bitmask instead of array for cargo consistency check. 
We only need to know if a cargo type is accepted, not how much.
 2023-10-19 17:03:25 +01:00
Jonathan G Rennison
a1c6923c63
Fix: Assertion in sprite aligner window (#11371) 
When clicking sprite number after re-opening window having previously used sprite picker tool
 2023-10-17 16:25:48 -04:00
Loïc Guilloux
ab805c4e9e
Fix #11375, 7c37dcb: Use STRING2 when the passed string can have 2 parameters (#11376) 2023-10-16 17:49:44 +00:00
Tyler Trahan
f49ffaaaea
Fix e4fd99a, Fix #11270: Vehicle max age is not subject to leap years (#11372) 2023-10-15 22:34:03 +00:00
Peter Nelson
356a5d5773
Codechange: Use std::vector in fallback layouter, and shorten accessors. (#11355) 
This avoids use of malloc/free (and custom move constructors), and follows how the exist layouters are written.
 2023-10-15 21:59:10 +01:00
translators
2be1b72a5b Update: Translations from eints 
hungarian: 50 changes by Norodix
 2023-10-15 18:36:51 +00:00
translators
a73ef95a2b Update: Translations from eints 
chinese (simplified): 5 changes by WenSimEHRP
 2023-10-14 18:37:25 +00:00
Rubidium
adad078b55 Fix #11367, 7c37dcb: use STRING1 when the passed string can have a parameter 2023-10-14 12:15:25 +02:00
Peter Nelson
bdcf6b6acd Fix: Treat closing network relay window as a choice of "No". 
Issue ConnectFailure when closing the window if the relay request is
considered unhandled.
 2023-10-13 20:47:28 +01:00
Peter Nelson
f379b31e28 Add: data parameter in Window::Close method. 
This allows passing data when closing a window, e.g. to indicate how it was closed.
 2023-10-13 20:47:28 +01:00
Peter Nelson
cda6f24fe8
Change: Filter duplicate paths from valid search path list. (#11363) 2023-10-09 21:38:13 +00:00
Loïc Guilloux
0458c15060
Cleanup: [MacOS] Remove unneeded WITH_SDL checks (#11360) 2023-10-09 19:35:15 +02:00
Peter Nelson
ac9db3f5aa
Codechange: Don't use bit-field in Yapf rail node. (#11362) 
Compacting 3 booleans into 3 bits could save memory allocation, however this data is inside a union which also contains a 4-byte integer. As such this gives the cost penalty of a bit-field without any benefit.
 2023-10-09 12:11:55 +00:00
translators
84201a8520 Update: Translations from eints 
chinese (traditional): 80 changes by wpi3
chinese (simplified): 1 change by WenSimEHRP
 2023-10-07 18:37:44 +00:00
Peter Nelson
2fd3d943aa
Fix 94167dfd: Don't shade the currently selected engine in autoreplace window. (#11354) 
This breaks #7729 which specifically allows autoreplace of same engine types, and also did not work properly if the engine had been built during the current game session.
 2023-10-06 21:09:24 +01:00
translators
89acfc7ff9 Update: Translations from eints 
chinese (simplified): 1 change by WenSimEHRP
indonesian: 12 changes by liimee
 2023-10-04 18:39:06 +00:00
Peter Nelson
d1a94d75e1
Fix: Incorrect include path for timers. (#11351) 2023-10-04 17:02:16 +01:00
translators
7145b7060a Update: Translations from eints 
romanian: 3 changes by bnegrut
 2023-10-03 18:39:41 +00:00
merni-ns
c794676928
Fix #10763, Fix #11168: Display variant groups that consist only of unavailable sub-groups (#11342) 2023-10-03 12:43:15 +00:00
Peter Nelson
5869f790d8
Fix: Check for engine variant loops during NewGRF initialization. (#11343) 
Invalid NewGRFs could set up an engine variant loop that never ends. This
was checked for in some places that evaluated variants, but not all. In
most cases this would result in the engines not appearing, but could
potentially cause an infinite loop and crash.

Instead, during NewGRF initialization detect loops and remove invalid
variants before setting display flags.
 2023-10-03 12:14:32 +01:00
merni-ns
077b08bbfa
Fix #11261: Set number of items correctly when choosing available airport set (#11344) 2023-10-03 12:58:44 +02:00
frosch
82c8720814 Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. Otherwise reset to defaults. 2023-10-02 22:32:30 +02:00
frosch
d75a5e1a9a Fix: Upgrading NewGRF presets could result in incomplete display of NewGRF parameters until restart. 2023-10-02 22:32:30 +02:00
translators
c84219a42e Update: Translations from eints 
english (us): 1 change by 2TallTyler
vietnamese: 21 changes by KhoiCanDev
 2023-09-30 18:37:10 +00:00
Peter Nelson
b5dc9328f2
Change: Store station blocked/wires/pylons flags in map. (#11337) 
This stores three flags in unused map bits, and avoids having to look up
station graphics and custom station specs to determine blocked/wires/pylons
status.

This potentially affects rail pathfinding performance.

Savegame version is not bumped, as the flags can just be updated every
time.
 2023-09-30 12:30:25 +01:00
translators
fd79d34ba9 Update: Translations from eints 
korean: 1 change by telk5093
 2023-09-27 18:39:05 +00:00
translators
beafdadde4 Update: Translations from eints 
italian: 25 changes by Rivarossi
 2023-09-26 18:39:04 +00:00
Peter Nelson
015fbafe34 Codechange: Add missing override specifiers to squirrel. 2023-09-25 21:27:45 +01:00
Peter Nelson
49dae08a3b Codechange: Add missing override specifiers. 2023-09-25 21:27:45 +01:00
translators
a650194227 Update: Translations from eints 
finnish: 1 change by hpiirai
 2023-09-25 18:38:49 +00:00
translators
976f8c474f Update: Translations from eints 
chinese (simplified): 139 changes by BYXxiaonanhui
catalan: 23 changes by J0anJosep
portuguese (brazilian): 1 change by pasantoro
 2023-09-24 18:36:59 +00:00
translators
f8303b0397 Update: Translations from eints 
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
danish: 1 change by bscargo
dutch: 1 change by Afoklala
french: 1 change by ottdfevr
portuguese: 1 change by azulcosta
polish: 68 changes by pAter-exe
 2023-09-22 18:37:34 +00:00
Peter Nelson
398c7e5f9d Codechange: Use new function to get a bitmask of empty cargo types. 2023-09-21 18:29:02 +01:00
Peter Nelson
69ee38bd43 Codechange: Use GetAcceptanceMask() instead of duplicating it. 2023-09-21 18:29:02 +01:00