Jonathan Almeida
3225b7ae30
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809 : Change default tab tray view to grid layout
3 years ago
Jonathan Almeida
da9d218700
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809 : Remove Grid layout info banner in tabs tray
3 years ago
codrut.topliceanu
7da6976770
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19191 - Fixes missing multi-select checkmarks
3 years ago
Oana Horvath
3fc5d43336
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18647 : Fixed and re-enabled customTrackingProtectionSettingsTest UI test
3 years ago
Jonathan Almeida
57df4f3fcc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old Synced Tabs code
3 years ago
Jonathan Almeida
aa8d5795b2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old tab tray code
3 years ago
Neha Binwal
322c7b4613
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19307 : Increased contrast ratio of chevron symbol in Collections (For Dark theme) ( https://github.com/mozilla-mobile/fenix/pull/19377 )
...
* For https://github.com/mozilla-mobile/fenix/issues/19307 : Increased contrast ratio of chevron symbol in Collections (Dark Theme)
- Made a code change in collection_home_list_row.xml which fixes the colour of the chevron symbol in Dark theme
* Replaced android:src with app:srcCompat to pass Lint check
3 years ago
Neha Binwal
10aaee9965
[fenix] Increased text contrast ratio of TextViews in 'Share tab' ( https://github.com/mozilla-mobile/fenix/pull/18880 )
...
- Changed share_tab_url color to @color/photonLightGrey60
- Changed appName and recent_apps_link_header color to @color/photonDarkGrey10
3 years ago
Mugurell
a1d0f1b171
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18877 - Support updated PromptRequest AC APIs ( https://github.com/mozilla-mobile/fenix/pull/19767 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18877 - Support updated PromptRequest AC APIs
This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.
* Update Android Components version to 91.0.20210603145049
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
e24a4cdb42
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19746 - Remove FeatureFlags.nimbusExperiments ( https://github.com/mozilla-mobile/fenix/pull/19771 )
3 years ago
ZianeA
c745b83740
[fenix] For #[15083]: Add multi select to recently closed tabs
3 years ago
Mozilla L10n Automation Bot
65f64d1929
[fenix] Import l10n.
3 years ago
Elise Richards
bcd257172b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19746 - Remove feature flag for the three-dot menu redesign ( https://github.com/mozilla-mobile/fenix/pull/19750 )
...
* Remove feature flag for the three-dot menu redesign
* Remove menu feature flag from unit tests
3 years ago
codrut.topliceanu
2ec93a964b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19571 - Adds gdprForgetMe when stopping Adjust
3 years ago
Mihai Adrian Carare
22a47beab1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19419 - Label edit boxes for a11y services. ( https://github.com/mozilla-mobile/fenix/pull/19762 )
3 years ago
Oana Horvath
60b8cfa916
[fenix] No issue: Add more smoke tests coverage
3 years ago
Oana Horvath
ddf02bbac2
[fenix] No issue: Change hardcoded package and app name in tests
3 years ago
Mozilla L10n Automation Bot
8e3c6deabb
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
13f05d9676
[fenix] Import l10n.
3 years ago
Gabriel Luong
7bdf0474b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19734 - Enable Credit cards autofill for Release ( https://github.com/mozilla-mobile/fenix/pull/19735 )
3 years ago
Gabriel Luong
5ab6b35346
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping ( https://github.com/mozilla-mobile/fenix/pull/19733 )
3 years ago
Jonathan Almeida
da6ac8459b
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19731 : Track metrics before we dismiss the tabs tray
3 years ago
Mihai Adrian Carare
fc5f56c9ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19564 : Explicitly update switch state for a11y event announcements. ( https://github.com/mozilla-mobile/fenix/pull/19589 )
3 years ago
Mozilla L10n Automation Bot
c43d29c07c
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
a4d0d5f378
[fenix] Import l10n.
3 years ago
Gabriel Luong
c0ce74f75e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19693 - Display a biometric prompt when a credit card is selected to autofill ( https://github.com/mozilla-mobile/fenix/pull/19697 )
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
67f91bff90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19693 - Add new string for the prompt to authenticate to use a stored credit card ( https://github.com/mozilla-mobile/fenix/pull/19708 )
3 years ago
Grisha Kruglov
1608dbc495
[fenix] Enable addresses sync for nightly/debug builds
3 years ago
Grisha Kruglov
9647ae5fad
[fenix] Minor cleanup of the account settings
3 years ago
Elise Richards
0bedcba4e5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill ( https://github.com/mozilla-mobile/fenix/pull/19548 )
3 years ago
Mozilla L10n Automation Bot
05611f5826
[fenix] Import l10n.
3 years ago
Jonathan Almeida
369ef222fd
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19459 : Use Store.waitUntilIdle in intermittent failing test ( https://github.com/mozilla-mobile/fenix/pull/19683 )
3 years ago
Gabriel Luong
d67678c9c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card ( https://github.com/mozilla-mobile/fenix/pull/19692 )
...
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
3 years ago
Christian Sadilek
451d286705
[fenix] Migrate test code to no longer use Nimbus FeatureConfig
3 years ago
Christian Sadilek
9026e1d20a
[fenix] Fix breaking change in MetricController
3 years ago
Christian Sadilek
2adaed1d2f
[fenix] Fix lint/detekt issues
3 years ago
James Hugman
9e84d12281
[fenix] Add an experiment to demontrate the Feature API
...
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
3 years ago
Oana Horvath
ba1ebb1413
[fenix] No issue: cleanup of unused tabs related code in HomeScreenRobot.kt
...
Deleted SmokeTest#selectTabsButtonVisibilityTest, feature removed
3 years ago
Oana Horvath
4219f12c67
[fenix] No issue: added smoke tests from MediaNotificationTest.kt
3 years ago
Elise Richards
c334a5ae30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18264 - Add biometric prompt to credit card settings ( https://github.com/mozilla-mobile/fenix/pull/19505 )
3 years ago
Oana Horvath
65105f2854
[fenix] No issue: Added custom tab UI smoke test
3 years ago
Jonathan Almeida
5dd7d94432
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19647 : Navigate to browser from home via Synced Tabs page
3 years ago
Mozilla L10n Automation Bot
26fcdb5f63
[fenix] Import l10n.
3 years ago
Gabriel Luong
d46ed809a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19680 - Show the card number when editing a credit card ( https://github.com/mozilla-mobile/fenix/pull/19681 )
3 years ago
Gabriel Luong
a61586886b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18271 - [Saved cards] Display the credit card provider icon and report the correct card type ( https://github.com/mozilla-mobile/fenix/pull/19652 )
3 years ago
Mugurell
e077d268ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18263 - Allow dynamically toggling credit cards autofill
3 years ago
Ionut Cristian Bedregeanu
dc4c14400a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19653 - Address 19643 PR comments
...
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
3 years ago
Mugurell
6cc2dfd41f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19638 - Don't show extracted text UI for name when editing cards ( https://github.com/mozilla-mobile/fenix/pull/19673 )
...
This comes to ensure consistency with the behavior for when editing the card
number.
3 years ago
Bedregeanu Ionut
126b678693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19654 - Add RTL support for the "Add credit card" button from "Saved cards" ( https://github.com/mozilla-mobile/fenix/pull/19666 )
...
Co-authored-by: Ionut Cristian Bedregeanu <ionut.bedregeanu@softvision.ro>
3 years ago
Codrut Topliceanu
3a74d32302
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19569 - Decrease the credit card expiry year width to ensure the month is fully visible ( https://github.com/mozilla-mobile/fenix/pull/19582 )
3 years ago
Mugurell
693a65646c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Introduce a DefaultTabsTrayInteractor
...
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
3 years ago
Mugurell
2825595c5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Cleanup - respect naming scheme in TabsTrayController
...
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
3 years ago
isabelrios
abff667349
[fenix] Stop depending on JCenter - Screengrab and Falcon
3 years ago
Mozilla L10n Automation Bot
945799c1bf
[fenix] Import l10n.
3 years ago
Sebastian Kaspari
21b40d89d8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Update detekt to 1.17.1
3 years ago
Ionut Cristian Bedregeanu
b0caa66de7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18881 - Create a new layout for 'Add credit card' button
...
Add functionality for 'Add credit card' button
Add unit tests for 'Add credit card' functionality
3 years ago
Mugurell
4c3dd87916
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19620 - Have MenuScreenShotTest screenshot DefaultBrowser setting again
...
As a regression from https://github.com/mozilla-mobile/fenix/issues/19590 which added a new setting above the existing
"Set as default browser" setting the settingsTest() needed to be updated to
allow clicking and screenshot of what happens after clicking on the
"Set as default browser" setting which can now be pushed offscreen.
3 years ago
Codrut Topliceanu
6c5d98e939
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display ( https://github.com/mozilla-mobile/fenix/pull/19420 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display
3 years ago
Oana Horvath
7ca40a2fcf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19415 : fixed private browsing button visibility issue
3 years ago
mcarare
c555252e0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19554 : Add SyncEngine.CreditCards to sync supportedEngines.
3 years ago
Mozilla L10n Automation Bot
67989b37d4
[fenix] Import l10n.
3 years ago
mcarare
ec95ba0822
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17538 : Perform autofill storage warm-up after visual completeness.
3 years ago
Oana Horvath
44e9a9099f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18603 : Fix and re-enable startBrowsingButtonTest
3 years ago
AndiAJ
ccc2e62961
[fenix] Fix settingsPrivacyItemsTest
3 years ago
mcarare
daef124cd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19600 : Set manage cards preference visible by default.
3 years ago
mcarare
c1a90b6e3c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19600 : Change manage cards preference UI dynamically.
3 years ago
mcarare
4c2c1b4473
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19600 : Change manage cards preference UI dynamically.
3 years ago
Oana Horvath
570c497a7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15754 : Get playback state using MediaSession in MediaNotificationTests
3 years ago
Mozilla L10n Automation Bot
8aeb3fa030
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
2d0615f86d
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
fd1d6123e9
[fenix] Import l10n.
3 years ago
Mugurell
3ad7bff786
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19590 - Enable credit card autofill in Debug and Nightly ( https://github.com/mozilla-mobile/fenix/pull/19601 )
3 years ago
Mozilla L10n Automation Bot
c084a95612
[fenix] Import l10n.
3 years ago
Codrut Topliceanu
d0bd0eb8a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19570 - Set appropriate theme color for delete card button ( https://github.com/mozilla-mobile/fenix/pull/19581 )
3 years ago
Sebastian Kaspari
ea2b2316f9
[fenix] AutofillConfiguration: Correctly specify autofill confirm activity.
3 years ago
Mozilla L10n Automation Bot
2e9ed281fc
[fenix] Import l10n.
3 years ago
Mihai Adrian Carare
ac35cf37da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19054 - Navigate to the Credit card screen when deleting last card. ( https://github.com/mozilla-mobile/fenix/pull/19451 )
3 years ago
Tim D. Smith
43956c9687
[fenix] Fix case of item extras in browser_menu_action event ( https://github.com/mozilla-mobile/fenix/pull/19487 )
...
* Fix case of item extras in browser_menu_action event
Update the event description to match the values observed in telemetry.
* Line length
3 years ago
Mihai Adrian Carare
43965a3255
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18507 - Prevent screenshots on credit card screens. ( https://github.com/mozilla-mobile/fenix/pull/19560 )
3 years ago
mcarare
3061600148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8370 : Remove extra characters from name mapping.
3 years ago
Mozilla L10n Automation Bot
a23de0165f
[fenix] Import l10n.
3 years ago
Arturo Mejia
07b4f64970
[fenix] Remove feature flag for proton icons re-design https://github.com/mozilla-mobile/fenix/issues/18132
3 years ago
Mozilla L10n Automation Bot
54433dee2a
[fenix] Import l10n.
3 years ago
mcarare
ed3cf07f11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19418 : Allow multiple lines title for sync cards preference.
3 years ago
Mozilla L10n Automation Bot
d80f218034
[fenix] Import l10n.
3 years ago
Gabriel Luong
13d977b0d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18287 - Display a credit card autofill prompt ( https://github.com/mozilla-mobile/fenix/pull/19477 )
3 years ago
Arturo Mejia
d6912dd0f9
[fenix] For issue AC https://github.com/mozilla-mobile/fenix/issues/10231 update proton icons third batch
3 years ago
Priyanka
27756aa4f6
[fenix] created string resource for close ( https://github.com/mozilla-mobile/fenix/pull/19500 )
...
Co-authored-by: priyanka0906 <priyanka02amb@reddiffmail.com>
3 years ago
Elise Richards
2803f54537
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17537 : Add preferences for syncing credit cards and addresses ( https://github.com/mozilla-mobile/fenix/pull/19471 )
...
* Add preferences for enable/disable sync for cc and addresses
* Set pref visibility based on feature flags
* Helper function for pin warning preferences and set default values for cc and addresses to false.
* Kdocs for relevant sync functions in account settings
* Default visibility to false for credit cards and addresses in account settings
3 years ago
Jonathan Almeida
f10aebe8e8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19176 : Exit select mode when removing tab ( https://github.com/mozilla-mobile/fenix/pull/19486 )
3 years ago
Mozilla L10n Automation Bot
e3b90eae64
[fenix] Import l10n.
3 years ago
mcarare
42d3d1edb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19258 : Replace default Android back button with a custom icon.
3 years ago
AndiAJ
1a8155edfd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19468 and https://github.com/mozilla-mobile/fenix/issues/19478 fix intermittent UI tests
3 years ago
Mozilla L10n Automation Bot
8e16b102f6
[fenix] Import l10n.
3 years ago
Codrut Topliceanu
099b301288
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19091 - Fix Undo of close multiple tabs ( https://github.com/mozilla-mobile/fenix/pull/19466 )
...
Fixes the issue where closing multiple selected tabs and then pressing Undo would only restore one of the tabs.
3 years ago
Roger Yang
b7ecc05811
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19147 : Move set startup metrics off main thread
3 years ago
Jonathan Almeida
8cc83017b2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Correct naming of pager viewholders
3 years ago
Jonathan Almeida
cf9a9dd6dc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Use a single BrowserTrayList for normal/private list
...
We now have a BrowserTrayList.
- Renamed from `BaseBrowserTrayList`.
- Removed the abstract `configuration` and used a `lateinit var`
instead.
- Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
3 years ago
Jonathan Almeida
9ace0c8551
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Correct browser viewholder naming
3 years ago
Jonathan Almeida
31a0602b9b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Move TabsTrayViewHolder to browser package
3 years ago
Jonathan Almeida
44973342da
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Remove unused TrayItem interface
3 years ago
Jonathan Almeida
8b8b96d7d4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Use AbstractBinding from lib-state
3 years ago
Mugurell
ecaf009a61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18672 - Renaming a TopSite changes just the title
...
Previously renaming a TopSite would bind that as a new item and in such update
the entire list. This could potentially leading changes in the list and then
it's ViewPager parent's layout.
This patch switches the code to use the existing TopSitePayload and so do a
partial update of an on-screen TopSite instead of rebind it as a new item.
If a layout is requested while showing <=4 TopSites on the second page, by
having "offscreenPageLimit = 1" the biggest height of ViewPager pages is used
preventing an edgecase where the ViewPager would hide half of the items from
the first page.
3 years ago
kanish671
9190ef1c11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18672 - Rename TopSites even on the second page
...
Index calculation for notifying changes while renaming a top site in the second
page was being wrongly calculated. Since it is page 2, we would need to take a
mod with the number of top sites per page to get the actual index of the top
site that was being renamed.
3 years ago
Mozilla L10n Automation Bot
1822be6c64
[fenix] Import l10n.
3 years ago
Neha Binwal
57f0fb0f6d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19401 - Replace hard-coded hex color values with their respective photon color variable ( https://github.com/mozilla-mobile/fenix/pull/19406 )
...
* Replaced https://github.com/mozilla-mobile/fenix/issues/20123A with @color/photonInk80 in values\colors.xml
* Replaced #F9F9FB with @color/photonLightGrey10 in values\colors.xml
* Replaced #E0E0E6 with @color/photonLightGrey30 in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/pull/592ACB with @color/photonViolet70 in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/pull/312A65 with @color/photonInk20 in values\colors.xml
* Replaced #FBFBFE with @color/photonLightGrey05 in values\colors.xml
* Replaced #52525E with @color/photonDarkGrey10 in values\colors.xml
* Replaced #ffffff with @color/photonWhite in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/pull/5B5B66 with @color/photonDarkGrey05 in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/issues/1C1B22 with @color/photonDarkGrey80 in values\colors.xml
* Replaced #737373 with @color/photonGrey50 in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/issues/9059FF with @color/photonViolet50 in values\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/pull/5B5B66 with @color/photonDarkGrey05 in values-night\colors.xml
* Replaced https://github.com/mozilla-mobile/fenix/pull/3A3944 with @color/photonDarkGrey40 in values-night\colors.xml
3 years ago
Jonathan Almeida
a9254b79b9
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19175 : Fix SyncTabs list not updating on changes
...
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
3 years ago
mcarare
3f404375d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19357 : Remove bookmarks experiment and keep star-with-line icon.
3 years ago
Mozilla L10n Automation Bot
88a894ed3a
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
0acc879521
[fenix] Import l10n.
3 years ago
William Lachance
adb10fab4e
[fenix] No issue - Stop generating `metrics.md` and direct to Glean Dictionary instead ( https://github.com/mozilla-mobile/fenix/pull/19411 )
...
Now that the Glean Dictionary (https://dictionary.telemetry.mozilla.org )
has hit production, our guidance is to move away from generating
metrics.md files. The Glean Dictionary is a better solution for this task
for a couple of reasons:
1. The Glean Dictionary contains a complete reference of all metrics
and pings sent by an application (not just those defined in the
application itself, as is the case with the markdown documentation)
2. The Glean Dictionary provides additional context and links beyond
what is provided by the documentation (for example, information on
how to access metric information via BigQuery or GLAM) as well as
annotations provided by data scientists in the course of analyzing data
(see, for example, the commentary section for:
https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/metrics_search_count ).
This should also reduce some of the churn/burden on people when
they submit PRs, as there is no longer any need to update metrics.md
as a part of them.
3 years ago
Mozilla L10n Automation Bot
dc73ae411d
[fenix] Import l10n.
3 years ago
Neha Binwal
8e0c0c905c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8984 : Added color for "Share" menu's "Recently Used" in Dark theme ( https://github.com/mozilla-mobile/fenix/pull/18839 )
...
* Added color for "Share" menu's "Recently Used" in Dark theme
- Changed HEX code for inset_dark_theme in values/colors.xml
* Replaced #52525E in values/colors.xml with @color/photonDarkGrey10
* Added color for "Share" menu's "Recently Used" in Dark theme
- Created a separate attribute recentlyUsedSharedMenu to be used by 'recently used' panel of tab share menu
- It specifies colors to be used for Light and Dark theme
3 years ago
Neha Binwal
a235c00112
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18226 : Fixed display of tabs for when text size is set to largest ( https://github.com/mozilla-mobile/fenix/pull/19046 )
...
- Made website titles clearly visible in Grid view of tab tray
- Made website URLs clearly visible in List view of tab tray
3 years ago
Elise Richards
50e5ebebd2
[fenix] Move locale restoration on startup to the visual completeness queue to prevent perf impact ( https://github.com/mozilla-mobile/fenix/pull/19315 )
3 years ago
Dharan Aditya
9b8e77e372
[fenix] Fixed mozilla-mobile https://github.com/mozilla-mobile/fenix/issues/18641 : [Bug] Fill link from clipboard overlaps search engines ( https://github.com/mozilla-mobile/fenix/pull/18657 )
3 years ago
Gabriel Luong
744e447c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18993 - Nimbus: Allow internal tooling to opt into specific branches of an experiment ( https://github.com/mozilla-mobile/fenix/pull/19333 )
3 years ago
AndiAJ
9855b1d05a
[fenix] Fix flaky UI Tests https://github.com/mozilla-mobile/fenix/issues/19306 https://github.com/mozilla-mobile/fenix/issues/19160 https://github.com/mozilla-mobile/fenix/issues/19404 https://github.com/mozilla-mobile/fenix/issues/19373
3 years ago
Roger Yang
f9477db816
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3728 : Add secret menu switch for allowing third party root certificates ( https://github.com/mozilla-mobile/fenix/pull/19398 )
3 years ago
Arturo Mejia
99d5305709
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/19290 update to proton icons second batch
3 years ago
mcarare
3681f15501
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18266 : Validate credit card entry info.
3 years ago
mcarare
8155ca4c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18266 : Refactor fragment and view to remove duplicate code.
3 years ago
Codrut Topliceanu
744357e211
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18262 - [Credit cards] Turn the "Sync cards across devices" button into a "Sync cards" toggle ( https://github.com/mozilla-mobile/fenix/pull/19207 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18262 - Turns "Sync cards/logins" into toggle
3 years ago
mcarare
52d3f0813b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19281 : Add border radius for top sites favicons.
3 years ago
kglazko
646a12f318
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19055 - Add a ScrollView to the Credit Card Editor Fragment ( https://github.com/mozilla-mobile/fenix/pull/19117 )
3 years ago
Mozilla L10n Automation Bot
9b1c91315e
[fenix] Import l10n.
3 years ago
Roger Yang
2d709b67a7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19147 : Move startup metrics to right after Glean initialization ( https://github.com/mozilla-mobile/fenix/pull/19252 )
3 years ago
codrut.topliceanu
47327e0100
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19132 - Fix navigation on disconnect started from tabsTray
...
- Added checks to popBackStack from the Disconnect Logged-in User Dialog, either back to settings, browserFragment or homeFragment.
3 years ago
Jonathan Almeida
964b03a65f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19259 : Pass CoroutineContext to nav interactor constructor
3 years ago
Mozilla L10n Automation Bot
0425ceb59f
[fenix] Import l10n.
3 years ago
Roger Yang
0884711ab1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253 : Bookmark and History open new tabs in the background ( https://github.com/mozilla-mobile/fenix/pull/19275 )
3 years ago
Mozilla L10n Automation Bot
f1899ec400
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
0eab51db90
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
29211178e8
[fenix] Import l10n.
3 years ago
Sebastian Kaspari
cf11703649
[fenix] Unit tests: Bump max heap size to 3072m.
3 years ago
Mozilla L10n Automation Bot
bd5c0d95cf
[fenix] Import l10n.
3 years ago
Priyanka
97f25e8f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19273 - Ensure a new line at the EOF is available in all xml files ( https://github.com/mozilla-mobile/fenix/pull/19295 )
3 years ago
Elise Richards
4565b0f1ea
[fenix] Turn on feature flag for three-dot menu redesign for beta. ( https://github.com/mozilla-mobile/fenix/pull/19111 )
3 years ago
Sebastian Kaspari
3da6fe471e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 - Fix UI test: settingsPrivacyItemsTest
3 years ago
Sebastian Kaspari
1d8ff55891
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 - Update marketing data setting description
3 years ago
Sebastian Kaspari
c1e6f6c9e6
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/10941 : Align Nightly version with Gecko/A-C version.
...
Instead of using a timestamp this will synchronize the Nightly version with the version
of Gecko / A-C. So when using 90.0.20210426143115 then the Nightly version will be
90.0a1 - similar to what Firefox desktop uses.
3 years ago
Mozilla L10n Automation Bot
ff7194591e
[fenix] Import l10n.
3 years ago
Roger Yang
9f608d6b0a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253 : Remove spaces from Addons telemetry comma-separated list ( https://github.com/mozilla-mobile/fenix/pull/19292 )
3 years ago
Codrut Topliceanu
676a1298a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19113 - Change top site corner radius to 8dp ( https://github.com/mozilla-mobile/fenix/pull/19262 )
3 years ago
Arturo Mejia
cb4c6b2132
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18132 update to proton icons first batch
3 years ago
mcarare
ee2e653ebb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19213 : Adjust synced tabs to properly show in RTL.
3 years ago
Mugurell
6acdc32aad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11819 - Show the mic in widget only if setting is enabled
...
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
3 years ago
Mozilla L10n Automation Bot
a210538479
[fenix] Import l10n.
3 years ago
Arturo Mejia
00e4051b15
[fenix] Fix openFile breaking changes
3 years ago
William Lachance
283bae5ff1
[fenix] No issue - Properly quote description for ad metric ( https://github.com/mozilla-mobile/fenix/pull/19243 )
...
This is pedantic, but strictly something called <provider-name> is considered an HTML tag
unless it's in a code block (backticks).
See mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/549 and mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/497 . I'm going to fix this upstream
but figured I might as well file a PR here to fix the underlying issue.
3 years ago
Sebastian Kaspari
7c11a19369
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 : Remove Leanplum (Nightly)
3 years ago
Grisha Kruglov
632ba92ad5
[fenix] Fix breaking changes introduced by credit card encryption APIs
3 years ago
Sebastian Kaspari
3425689113
[fenix] Use new SearchSuggestionProvider flag.
3 years ago
Mozilla L10n Automation Bot
253e2e4485
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
9125fa9659
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
a51bd7dbf4
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
298846bdee
[fenix] Import l10n.
3 years ago
Mihai Adrian Carare
7dea66e1e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19065 - Add extension functions to be used with credit cards. ( https://github.com/mozilla-mobile/fenix/pull/19187 )
3 years ago
Mugurell
d2faf47d3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18591 - Update tests
...
Some tests trying to "Add to top sites" may fail because of the sticky navbar
now covering that menu item -> scroll the menu up a little.
Some tests that previously were trying to scroll to the bottom of the menu to
interact with navbar options now don't have to. Them trying to interact with
navbar option with the menu opened as collapsed is a good test for the navbar
stickyness.
3 years ago
Mugurell
b04c52d115
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18591 - Make the navbar sticky in the new menu
3 years ago
Roger Yang
fffa196da9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18816 : Disable TabsTray FAB on accessibility enabled ( https://github.com/mozilla-mobile/fenix/pull/19170 )
3 years ago
mcarare
d94dcd6bd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19125 : Move top site pin net to title.
3 years ago
Gabriel Luong
33a81d217a
[fenix] No issue - Replace local photon colors with ui-colors ( https://github.com/mozilla-mobile/fenix/pull/19167 )
3 years ago
mcarare
748c70d3e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19180 : Fix tab counter not entirely visible on RTL layout.
3 years ago
Sebastian Kaspari
692611fa13
[fenix] Remove browser-search references.
3 years ago
mcarare
f28b815561
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18267 : Updates preferences visibility depending on creditCardsStore
3 years ago
Mozilla L10n Automation Bot
09c32a05b7
[fenix] Import l10n.
3 years ago
Elise Richards
e009e920fa
[fenix] Remove strings marked as deprecated that are no longer being used. ( https://github.com/mozilla-mobile/fenix/pull/19060 )
3 years ago
Elise Richards
3eff41bd2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19114 : check state of sync account when navigating from sync sign in menu item ( https://github.com/mozilla-mobile/fenix/pull/19118 )
3 years ago
mcarare
a579e7b1af
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 : Also add default browser item in new menu.
3 years ago
Arturo Mejia
e2af9f8372
[fenix] Address WebExtensionBrowserMenuBuilder breaking change
3 years ago
Sebastian Kaspari
41f7cc9d24
[fenix] Update to Mozilla Android Components 90.0
3 years ago
Roger Yang
73b0bcf3c1
[fenix] No issue: Suppress deprecation for LoginStorageDelegate ( https://github.com/mozilla-mobile/fenix/pull/19145 )
3 years ago
mcarare
04c0e062af
[fenix] No issue: Rename Event for naming consistency.
3 years ago
mcarare
6774f41d26
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18852 : Add metrics for default browser settings experiment.
3 years ago
Elise Richards
c56f3835be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19005 : new tab three-dot menu sync sign in ( https://github.com/mozilla-mobile/fenix/pull/19037 )
...
* Show synced tabs or sync account in new tab menu
* Sync sign in item navigates to account settings
* Check account auth and get sync item title
* Look for sync sign in item on home menu for UI test
* Sync sign in menu item UI test
3 years ago
mcarare
7543d25b80
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18240 : Adjust preference screen to fit UX specs.
3 years ago
Christian Hernandez
5c7de09133
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18830 - Remove card nickname from credit card editor ( https://github.com/mozilla-mobile/fenix/pull/18891 )
...
* Removed all views with regards to credit card nickname. Removed the TextInputLayout and TextInputEditText where information would be typed in. Also removed the credit card nickname title text view. I added a margin of 16 dp to the bottom ConstraintLayout that houses the delete, cancel, and save buttons as requested.
* https://github.com/mozilla-mobile/fenix/issues/18830 - Removed all views with regards to credit card nickname. Removed the TextInputLayout and TextInputEditText where information would be typed in. Also removed the credit card nickname title text view. I added a margin of 16 dp to the bottom ConstraintLayout that houses the delete, cancel, and save buttons as requested.
3 years ago
Jonathan Almeida
c6fe6bd93e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19094 : Open sign-in flow if no account is created for tabs tray
3 years ago
Kate Glazko
3818b88fef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18745 : Add Shadow To Shortcut Tiles
3 years ago
Jonathan Almeida
ed14d32d97
[fenix] No issue: Allow tabstray rewrite to ride the trains
3 years ago
Jonathan Almeida
be8873f8d4
[fenix] Disabling tabstray collection tests until https://github.com/mozilla-mobile/fenix/issues/19090 is fixed
3 years ago
Jonathan Almeida
bc86a34797
[fenix] No issue: Fix regression in last tab deleted
...
When we allow the homescreen to handle undo for the last tab, we no
longer need to handle this ourselves with our own binding.
In the future, we should re-think this logic to be more robust and less
spread out across multiple screens.
3 years ago
Jonathan Almeida
b0d0e1b8c9
[fenix] No issue: Use same open tabs tray everywhere
3 years ago
Jonathan Almeida
b0764f9042
[fenix] No issue: Fix the initial select mode check
3 years ago
Jonathan Almeida
8ce71d589f
[fenix] No issue: Do not create a new instance of TabsTrayStore
...
We only need one. :)
3 years ago
Jonathan Almeida
2c4d36392f
[fenix] Attempt at fixing openAllTabsInCollectionTest test
3 years ago
Jonathan Almeida
a63d26f673
[fenix] Disable/fix tests that rely on Select Tabs button
3 years ago
Jonathan Almeida
7a372f13f9
[fenix] No issue: Enable tabs tray re-write by default in nightly
3 years ago
mcarare
7caceac997
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18496 : Set activity theme in onCreate before call to super.
3 years ago
Mozilla L10n Automation Bot
21cfdbb62f
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
c021fdf786
[fenix] Import l10n.
3 years ago
Jonathan Almeida
4c69372287
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19064 : Focus on tab page with the BrowsingModeManager
3 years ago
Roger Yang
cf70cb61b3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18946 : Add undo toast for tabstray
3 years ago
Michael Comella
5d92d409e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : address onCreate method length detekt issue.
3 years ago
Michael Comella
e83004d81b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add & integrate StartupTypeTelemetry.
3 years ago
Michael Comella
c7f94915cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add metric perf.startup.startup_type.
3 years ago
Michael Comella
1035ad0fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupPathProvider + tests.
3 years ago
Michael Comella
bdca7337ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : address lint errors for StartupStateProvider*.
3 years ago
Michael Comella
825e035db6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add getStartupStateForStartedActivity method.
3 years ago
Michael Comella
4adb237b88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isHotStartForStartedActivity and tests.
3 years ago
Michael Comella
b7e04b6590
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isWarmStartForStartedActivity, tests.
3 years ago
Michael Comella
d7ad0bb813
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : shorten isColdStart... and rm questionable test.
...
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
3 years ago
Michael Comella
895f8efe13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add VIEW to warm and hot entries.
3 years ago
Michael Comella
f5943d894c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests to forEachHotStartEntries.
3 years ago
Michael Comella
ca1364f3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor test into forEachWarmStartEntries.
3 years ago
Michael Comella
e7d166052c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests into forEachColdStartEntries.
3 years ago
codrut.topliceanu
2b69fd5b2a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19023 - Expands tabsTray when tabs over certain number
...
TabsTray should be collapsed when there are only a few tabs on screen, otherwise it should go straight to STATE_EXPANDED.
3 years ago
Julien Cristau
b2a420f624
[fenix] Update A-C to 75.0.20210415213638
3 years ago
Mugurell
c2a4f16fe8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18439 - Open link from QR code only if activity is not null
3 years ago
Kate Glazko
68b17ba7e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18520 : Add Empty Tab State To Browser Tray List
3 years ago
Mozilla L10n Automation Bot
d57bcda8ef
[fenix] Import l10n.
3 years ago
Jonathan Almeida
2ce93ef3a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19024 : Fix intermittent test failure in NavigationInteractor
3 years ago
Jonathan Almeida
da6cd0c128
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19030 : Allow homescreen to be scrollable with extra content
3 years ago
Jonathan Almeida
4f95404df6
[fenix] No issue: Set tray dismissal from background tap
3 years ago
Jonathan Almeida
c6b9bf80d5
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19045 : Dismiss tabstray when last tab in a page is closed
3 years ago
Elise Richards
395853235f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18867 : remove "signed in as" string in three-dot menu ( https://github.com/mozilla-mobile/fenix/pull/19035 )
...
* Remove signed in as string from sync menu item
* Nav to sync account settings on click
For https://github.com/mozilla-mobile/fenix/issues/18806 : navigate to settings account page or sign in on clicking menu item.
* Confirm account exists and retrieve item title
* Remove string
3 years ago
Christian Sadilek
f134595809
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18819 : Hide Credit Card pref by default (for settings w/o icons) ( https://github.com/mozilla-mobile/fenix/pull/19058 )
3 years ago
Gabriel Luong
fd0b41c798
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information ( https://github.com/mozilla-mobile/fenix/pull/19032 )
3 years ago
Gabriel Luong
baea2cdf4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card ( https://github.com/mozilla-mobile/fenix/pull/19029 )
3 years ago
Codrut Topliceanu
1c24731b4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab ( https://github.com/mozilla-mobile/fenix/pull/19021 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Added scroll to current tab
* For https://github.com/mozilla-mobile/fenix/issues/18521 - Addressed comments
3 years ago
Arturo Mejia
2119cfadae
[fenix] Telemetry for https://github.com/mozilla-mobile/fenix/issues/18855 , https://github.com/mozilla-mobile/fenix/issues/18851 and https://github.com/mozilla-mobile/fenix/issues/18857
...
For https://github.com/mozilla-mobile/fenix/issues/18857 [Telemetry] Send a Glean event when users change their default browser
For https://github.com/mozilla-mobile/fenix/issues/18855 [Telemetry] Send an event when users open the toolbar menu
For https://github.com/mozilla-mobile/fenix/issues/18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
3 years ago
Roger Yang
d72289a43d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19003 : Add account setting to tabstray synced tab menu ( https://github.com/mozilla-mobile/fenix/pull/19034 )
3 years ago
Mozilla L10n Automation Bot
1484a591c6
[fenix] Import l10n.
3 years ago
Roger Yang
4f9a341746
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948 : Update tabstray telemetry ( https://github.com/mozilla-mobile/fenix/pull/19004 )
3 years ago
mcarare
8e8a872127
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18854 : Add metrics for home screen being displayed.
3 years ago
mcarare
c4609f6e35
[fenix] No issue: Fix indenting in onViewCreated.
3 years ago
mcarare
8f34c26bfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18376 : Add experiment for set default browser settings card.
3 years ago
mcarare
9dede18ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18853 : Add metrics for default browser new tab experiment.
3 years ago
mcarare
4ff47f6c1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18856 : Add metrics for opening settings screen from home menu.
3 years ago
mcarare
62f839d75a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18815 : Expand app bar on onboarding dismissal and browsing start.
3 years ago
Jonathan Almeida
d10792a96e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19011 : Always have a click listener in TabTrayViewHolder
3 years ago
Jonathan Almeida
bc628f6770
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18934 : Do not nullify adapter on window detached
...
Previously, to fix a memory leak, we were removing the adapter reference
entirely in order to have the `onDetachedFromRecyclerView` callback
invoked. This causes a side-effect where we can no longer reference the
adapter any more when we re-attach.
The simpler solution is to just invoke the needed callback directly
instead.
3 years ago
Gabriel Luong
ac29b50dfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen ( https://github.com/mozilla-mobile/fenix/pull/18884 )
3 years ago
Oana Horvath
0ad9590e60
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18986 & https://github.com/mozilla-mobile/fenix/issues/19016 : disabled failing tests changeThemeSetting & changeAccessibiltySettings
3 years ago
MarcLeclair
4c45f615bb
[fenix] 16900 make navgraph inflation asynchronous ( https://github.com/mozilla-mobile/fenix/pull/18889 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16900 : implement async navgraph inflation
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed nav graph from xml
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflate navGraph programatically
For https://github.com/mozilla-mobile/fenix/issues/16900 : Made NavGraph inflation asynchronous
For https://github.com/mozilla-mobile/fenix/issues/16900 : Changed to block with runBlocking
For https://github.com/mozilla-mobile/fenix/issues/16900 : Refactored blocking call into a function
For 16900: NavGraph inflation is now async
We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)
For 16900: rebased upstream master
For 16900: Rebase on master
For https://github.com/mozilla-mobile/fenix/issues/16900 : Fixed Async Navgraph navigation per review comments.
1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflateNavGraphAsync now takes navController
For https://github.com/mozilla-mobile/fenix/issues/16900 : Pass lifecycleScope to NavGraphProvider
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed unused mock
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added linter rules for navigate calls
We need linting rules to make sure no one calls the NavController.navigate() methods
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added TestRule to help abstract the mocks in the code
For 16900: Fix linting problems
For https://github.com/mozilla-mobile/fenix/issues/16900 : Cleaned duplicated code in tests
For https://github.com/mozilla-mobile/fenix/issues/16900 : cleaned up NavGraphTestRule for finished test
For https://github.com/mozilla-mobile/fenix/issues/16900 : had to revert an accidentally edited file
For https://github.com/mozilla-mobile/fenix/issues/16900 : rebased master
* For https://github.com/mozilla-mobile/fenix/issues/16900 : Review nits for async navgraph
This is composed of squash commits, the original messages can be found below:
-> DisableNavGraphProviderAssertionRule + kdoc.
Use test rule in RobolectricApplication.
Fix failing CrashReporterControllerTest
Fix blame by -> navigate in tests.
This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```
Fix various blame
This is expected to be squashed into the first commit so, if so, it'd
fix the blame.
Move test rule to helpers pkg.
add missing license header
Add import change I missed
fix unused imports
Replace robolectricTestrunner with test rule.
Improve navGraphProvider docs
Remove unnecessary rule as defined by robolectric.
add clarifying comment to robolectric
remove unnecessary space
* For https://github.com/mozilla-mobile/fenix/issues/16900 : nit fixes for MozillaNavigateCheck and lint fixes
3 squash commits:
*Changed violation message and fixed the lint rule for MozillaNavigateCheck
*Added suppression to NavController.kt
*Fixed detekt violations
* For 16900: Fixed failing tests
Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
3 years ago
Mozilla L10n Automation Bot
9d3edcecea
[fenix] Import l10n.
3 years ago
Michael Comella
e7a15807a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : rename CreatedActivityLogEntry -> LogEntry.ActivityCreated and similar.
...
It's too much work to squash "correctly".
3 years ago
Michael Comella
073a4dc221
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : note refactor in metrics docs.
3 years ago
Michael Comella
c04e4f392d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : replace StartupActivityStateProvider with StartupStateProvider.
...
The StartupActivityStateProvider uses an imperative implementation,
driven by callbacks, to set the state of the application. This is hard
to follow as you need to understand which callbacks will be called in
which order. For example, to make sense of an implementation like this,
COLD, WARM, AND HOT would likely need to be implemented in separate
ActivityLifecycleCallbacks.
I feel the StartupStateProvider is an improvement because it leverages
the StartupActivityLog to query a linear state for a more understandable
implementation. Furthermore, it seems accessible to write COLD, WARM,
and HOT in the same class because they can all be approached the same
way.
3 years ago
Michael Comella
4411a9c84a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupStateProvider.
3 years ago
Michael Comella
7d0024ab93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : prevent StartupActivityLog from growing infinitely.
...
We do this is as a separate commit over the original implementation
because it's simpler to implement the class without this optimization.
3 years ago
Michael Comella
7286daabe9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupActivityLog, tests.
3 years ago
Jonathan Almeida
5000e54aaf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18931 : Implement add to collections in interactor
...
We moved the collection dialog code out from the old fragment, because it
had nothing to do with tabs tray, and into the collections package to be
re-usable in other parts of the app.
In addition, we also make use of it in the new tabs tray's
NavigationInteractor.
3 years ago
Jonathan Almeida
e50350db14
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Move dialog adapter to collections package
3 years ago
Jonathan Almeida
35947762b7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Rename class to CollectionsListAdapter
3 years ago
Christian Sadilek
858320fe6b
[fenix] Upgrade to Android Components 75.0.20210413143139
3 years ago
Jonathan Almeida
167d925c12
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18934 : Remove adapter when deataching from window
3 years ago
Jonathan Almeida
4ba99372f2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18885 : Dismiss FAB icon when tabs tray is closed
3 years ago
mcarare
ed8d36520e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18375 : Add experiment for set default browser New Tab card.
3 years ago
Elise Richards
a5d8e40932
[fenix] Add ignores for intermittent toolbar tests
3 years ago
Mozilla L10n Automation Bot
aae8d26393
[fenix] Import l10n.
3 years ago
Jonathan Almeida
df807cf612
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18973 : Fix references to info banner
3 years ago
Roger Yang
425c9d857b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18522 : Re-add call to action in tabs tray
3 years ago
Elise Richards
856e133f4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18806 : Show sync tabs or sync account sign in based on feature flag ( https://github.com/mozilla-mobile/fenix/pull/18859 )
...
* Show sync tabs or sync account sign in based on feature flag. Sign in navigates to account settings on click.
* lint and nits
3 years ago
Roger Yang
820f3f1521
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18899 : Update content description string for synced tabs icon ( https://github.com/mozilla-mobile/fenix/pull/18963 )
3 years ago
Jonathan Almeida
5819a7c0a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18932 )
...
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new addBookmark BookmarksUseCase
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add class for state binding features
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add delete multiple tabs to tray interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new actions to navigation interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Enable select mode from main tray menu
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add menu when in select mode
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add select support for handle UI
We apply various layout changes to the "handle" UI in the tabs tray when
switching modes. It isn't quite clear to my, why we do this, if it's
really needed to meet the end result, and if there is a better way.
For now, we're simplying moving over that logic that we can re-evaluate
at a later time.
3 years ago
Elise Richards
298c4c2814
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18960 : Remove nav in homescreen three dot menu ( https://github.com/mozilla-mobile/fenix/pull/18962 )
...
* Remove nav in homescreen three dot menu
* Remove back and forward items
3 years ago
Arturo Mejia
22176de02c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 only show the experiment for set default browser MenuItem when Nightly, Beta, Release are not the default browser
3 years ago
Sören Hentzschel
0344ebb250
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18898 - implement quit button in page menu ( https://github.com/mozilla-mobile/fenix/pull/18942 )
3 years ago
Gabriel Luong
fd09f532a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18940 - Remove reserved icon spacing for "Nimbus Experiments" setting preference ( https://github.com/mozilla-mobile/fenix/pull/18949 )
...
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
3 years ago
Oana Horvath
8a20fdec59
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17979 & https://github.com/mozilla-mobile/fenix/issues/17840 : fix and re-enable UI tests affected by main menu changes
3 years ago
Oana Horvath
7d7f64f839
[fenix] Fix screenshots tests: showDefaultHomeScreen, bookmarksManagementTest
3 years ago
Mozilla L10n Automation Bot
62c179feee
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
b9678e5dea
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
ef233b706a
[fenix] Import l10n.
3 years ago
Jonathan Almeida
b543a2bd4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 - Correct one more instance of the onboarding string ( https://github.com/mozilla-mobile/fenix/pull/18906 )
3 years ago
Gabriel Luong
e6912113d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18742 - Resize the top site item sizes ( https://github.com/mozilla-mobile/fenix/pull/18751 )
3 years ago
Mugurell
87b9259885
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18122 - Update browser layout for find in page bar with bottom toolbar
...
With a dynamic bottom toolbar the browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.
To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
3 years ago
Mugurell
a7deb00521
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18616 - Update browser and toolbar layout when toolbar is at top
...
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
3 years ago
Sebastian Kaspari
a23da507c5
[fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background.
3 years ago
Sebastian Kaspari
0d5d585dd1
[fenix] Move TelemetryMiddleware to telemetry sub package.
3 years ago
mcarare
44d32189cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18829 : Adjust bookmark item color to UX specs.
3 years ago
Jonathan Almeida
6acd9c7925
[fenix] Update kdocs of navigation interactor
3 years ago
Jonathan Almeida
ab00590d17
[fenix] Call stop in deattach for feature binding
3 years ago
Jonathan Almeida
d2ca8da836
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18845 : Adds swipe-to-delete to tabs tray refactor
...
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.
We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
3 years ago
Mozilla L10n Automation Bot
a02ea9b6ab
[fenix] Import l10n.
3 years ago
Arturo Mejia
09b4cf71ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 Add experiment for set default browser MenuItem.
3 years ago
MarcLeclair
7ab0ea8c7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17759 : Added min SDK 23 to avoid crashes on android 5.0 and 5.1 ( https://github.com/mozilla-mobile/fenix/pull/18832 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17759 : Added min SDK 23 to avoid crashes on android 5.0 and 5.1
* For https://github.com/mozilla-mobile/fenix/issues/17759 : fixed Android code from INT to actual version name
3 years ago
Elise Richards
854bfa20f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17870 - Enable new three-dot menu redesign on nightly builds ( https://github.com/mozilla-mobile/fenix/pull/18883 )
3 years ago
Elise Richards
f674d42d7a
[fenix] Settings menu item should be tinted if there is an account issue ( https://github.com/mozilla-mobile/fenix/pull/18849 )
3 years ago
Elise Richards
d2ad816af9
[fenix] PWA install to homescreen is available in main menu ( https://github.com/mozilla-mobile/fenix/pull/18850 )
3 years ago
Gabriel Luong
ee594f885e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18268 , https://github.com/mozilla-mobile/fenix/issues/18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage ( https://github.com/mozilla-mobile/fenix/pull/18808 )
3 years ago
Gabriel Luong
71321acb0e
[fenix] Update app/src/main/java/org/mozilla/fenix/ext/Activity.kt
3 years ago
Arturo Mejia
c057684ecd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18608 made set a default browser functionality publicly available.
3 years ago
rxu
91a05f1dd1
[fenix] Add domestic China FxA service for Mozilla Online builds
...
China fxa related string
Add switch preference in settings to use local/global fxa server
inherit fennec FxA settings
Present or hide fxa switch according to isMozillaonline
Allow China fxa server auto login during migration
3 years ago
Mozilla L10n Automation Bot
585fc80689
[fenix] Import l10n.
3 years ago
Jonathan Almeida
94e39ff584
[fenix] No issue - Enable the tabs tray refactor in nightly ( https://github.com/mozilla-mobile/fenix/pull/18858 )
3 years ago
codrut.topliceanu
dc1f62eb6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Added Icon and sync functionality
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
codrut.topliceanu
695c777306
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Adds FAB to TabsTray rewrite
3 years ago
Gabriel Luong
33c1d58580
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18743 - Change the top sites label colour and size ( https://github.com/mozilla-mobile/fenix/pull/18752 )
3 years ago
Roger Yang
eccdb6bf8d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068 : Track custom fill link from clipboard clicked ( https://github.com/mozilla-mobile/fenix/pull/18827 )
3 years ago
Jonathan Almeida
1adcbf6b0d
[fenix] No issue: Move UseCase wrappers to the interactor; it's only usage
3 years ago
Jonathan Almeida
a890d0210e
[fenix] No issue: Move menu to separate integrations class
3 years ago
Jonathan Almeida
d18854c54c
[fenix] No issue: Add test for share tab in navigation interactor
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Jonathan Almeida
3c3bf65d93
[fenix] No issue: Observe only normal tabs when updating counter
3 years ago
Jonathan Almeida
398b5823a4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774 : Fix long parameter warnings in detekt
3 years ago
Jonathan Almeida
16f87e47e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774 : Migrate mutli-selection to store
...
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.
This is an implementation that's similar to what we have in other UI
lists (library).
3 years ago
Jonathan Almeida
0b1336868c
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774 : Move SelectionInteractor to new package
...
The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.
3 years ago
Arturo Mejia
d024b9bc93
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16557 set autoplay block audio only
...
by default
3 years ago
Mozilla L10n Automation Bot
922110c303
[fenix] Import l10n.
3 years ago
Elise Richards
16c4823bef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18770 - Correct addons position in three dot menu based on toolbar position ( https://github.com/mozilla-mobile/fenix/pull/18828 )
3 years ago
Grisha Kruglov
242ea763de
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17361 : Extend perf.awesomebar.* metrics
3 years ago
Gabriel Luong
77a540b659
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18819 - Hide the Credit Card preference by default ( https://github.com/mozilla-mobile/fenix/pull/18820 )
3 years ago
Mozilla L10n Automation Bot
cb30e7fde7
[fenix] Import l10n.
3 years ago
Roger Yang
7b72b9e85b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18513 : Re-add menu to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18756 )
3 years ago
Jonathan Almeida
3ec3c16c70
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Set the span count for grid view
3 years ago
Jonathan Almeida
8fa60a67af
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Do not animate first scroll to position
...
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
3 years ago
Jonathan Almeida
9e3bd75692
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Move list/grid viewholders to browser package
3 years ago
Kate Glazko
a5ea92912f
[fenix] For 17798: Sync Menu Item
3 years ago
Jonathan Almeida
94688bf59b
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/17821 : Add TabsTrayStore with actions and reducer ( https://github.com/mozilla-mobile/fenix/pull/18773 )
3 years ago
Jonathan Almeida
5beadfdb15
[fenix] No issue - Make TabLayoutMediator lifecycle aware ( https://github.com/mozilla-mobile/fenix/pull/18779 )
3 years ago
Travis Long
5b26effc9a
[fenix] [SDK-246] Change Nimbus `channel` input to use the same method as Glean ( https://github.com/mozilla-mobile/fenix/pull/18766 )
...
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean
* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
VaishnaviShri
4536a2a35e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8545 : Fix unnecessary scroll in home screen
...
Changed the height of the recycler view inside the home fragment
to ‘wrap_content’ to avoid scrolling if the viewport is not filled
with elements.
Closes https://github.com/mozilla-mobile/fenix/issues/8545
3 years ago
Mozilla L10n Automation Bot
ddb145b3cb
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
dba715e17a
[fenix] Import l10n.
3 years ago
Gabriel Luong
d45e4c4e42
[fenix] Use photon colors from ui-color ( https://github.com/mozilla-mobile/fenix/pull/18760 )
3 years ago
Gabriel Luong
46e6ea9e85
[fenix] No issue - Remove generic strings for more specificity ( https://github.com/mozilla-mobile/fenix/pull/18769 )
3 years ago
Mugurell
91cc54d75b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17772 - Collapse browser menu to "Add to Home screen"
...
The menu will start as collapsed.
Users can then swipe up to expand it.
3 years ago
Gabriel Luong
a13c6f3f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18265 - [Add card] Integrate the credit card storage and handle adding a new credit card ( https://github.com/mozilla-mobile/fenix/pull/18719 )
3 years ago
Michael Comella
028cfd0597
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18731 : remove anonymous classes from StrictModeManager.
...
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
3 years ago
Gabriel Luong
5224c11879
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18729 - Use consistent string naming for generic strings ( https://github.com/mozilla-mobile/fenix/pull/18730 )
3 years ago
Elise Richards
990fe44056
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17770 : New tab three-dot menu reorder ( https://github.com/mozilla-mobile/fenix/pull/18427 )
...
* Create new menu order for new tab
* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.
* Lint
Lint and refactoring tests
* Tests for default toolbar menu
* Feature flag for request desktop site
Add todos for UI test issue 17979
Add todos for UI tests
3 years ago
mcarare
bcbd67bb07
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18717 : Use normal theme color for tab tray synced tabs.
3 years ago
Mugurell
433b0f0bdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18617 - Use the new EngineView#getInputResultDetail()
...
All functionality should remain the same.
3 years ago
AndiAJ
5f52f0140f
[fenix] Disable failing UI Tests
3 years ago
mcarare
df747ca855
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17797 : Add bookmarks menu item.
3 years ago
Roger Yang
c164b2308b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18706 - Remove unneeded add-on telemetry calls ( https://github.com/mozilla-mobile/fenix/pull/18707 )
3 years ago
rxumoz
305bb7f48a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18386 - Change language display name to traditional/simplified Chinese for Chinese locale ( https://github.com/mozilla-mobile/fenix/pull/18387 )
3 years ago
Mihai Adrian Carare
4da13e56c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. ( https://github.com/mozilla-mobile/fenix/pull/18653 )
3 years ago
Roger Yang
56fcf0e457
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18514 : Re-add tab counter in tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18659 )
3 years ago
Michael Comella
b26d782c2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add data review links.
3 years ago
Michael Comella
9c3ad5608a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : warn about flaw in `app_opened_all_startup` probe.
3 years ago
Michael Comella
c5bfc690d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : record cold start duration telemetry.
3 years ago
Michael Comella
f5accce70f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add StartupActivityStateProvider.
...
This will be used to filter conditions for the start up telemetry we're
adding.
3 years ago
Michael Comella
ee31fe29c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add ApplicationStartReasonProvider.
...
We need to know this state to add a correct COLD MAIN probe.
3 years ago
Michael Comella
04af130922
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add DefaultActivityLifecycleCallbacks.
...
We'll extend this in subsequent commits.
3 years ago
Oana Horvath
6dff34ee33
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 : fix metod to verify system notifications
3 years ago
Jonathan Almeida
9feca460c1
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14117 : Add Synced Tabs as a page in the tabs tray
3 years ago
Oana Horvath
e4614fd8a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 : Ignore the ContextMenusTest class because of test failures
3 years ago
Gabriel Luong
4cab53bb65
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18247 - [Add card] Populate the Credit card expiry year drop down
3 years ago
Gabriel Luong
57c0eb196a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18246 - [Add card] Populate the Credit card expiry month drop down
3 years ago
Gabriel Luong
5f5d03ee19
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18243 - Add a credit card editor screen
3 years ago
Jonathan Almeida
e6d88f4669
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18521 : Focus on page corresponding to selected tab
...
This first part of https://github.com/mozilla-mobile/fenix/issues/18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
3 years ago
Jonathan Almeida
11b1e0a461
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668 : Add stable ID cache for TabAdapter.getItemId
3 years ago
yichiehc
1006a699c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16830 : Increase the Show in private sessions option in Search Preferences Settings ( https://github.com/mozilla-mobile/fenix/pull/18689 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (https://github.com/mozilla-mobile/fenix/pull/18605 )
* For https://github.com/mozilla-mobile/fenix/issues/16830 : Increase the Show in private sessions option in Search Preferences Settings
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Aaron Klotz
6c8838adb7
[fenix] Explicitly set android:extractNativeLibs to true in ApplicationManifest.xml
...
The Android Gradle Plugin's default for android:extractNativeLibs changed from
true to false beginning with version 3.6.0. Based on GeckoView's needs, we
should ensure that this attribute is explicitly set to true.
3 years ago
Michael Droettboom
2fb552617a
[fenix] Bug 1689162: Update Glean metrics.yaml schema ( https://github.com/mozilla-mobile/fenix/pull/18683 )
3 years ago
Kershan
bd7ca49b17
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18453 - Show SUMO for default browser deeplink on Android <N
...
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
3 years ago
Arturo Mejia
d23cc020cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Improve Onboarding strings
3 years ago
Jonathan Almeida
debb6bbc7b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443 : Move viewholders to separate files and package
3 years ago
Jonathan Almeida
5f2ac9fbc0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18443 : Fix changes between grid/list viewholders
3 years ago
Jonathan Almeida
0e3def9e83
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18443 : Use recyclerview-selection for multi-select mode in tray
...
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
- Enable multi-select mode on long-press.
- Enable multi-select mode when changed by an external function.
- Only works for normal tabs (as we currently have it).
Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
3 years ago
Gabriel Luong
83e350ed4c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17291 - Display a list of all active Nimbus experiments ( https://github.com/mozilla-mobile/fenix/pull/17515 )
3 years ago
yichiehc
6dd598c8db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18594 : Highlight the "Default browser" system setting on Android >= N
...
Although not public APIs we can use specific extras in the Intent used to open
system settings such that the "Default browser" setting is highlighted to
provide a better UX for users looking to set Fenix as default.
3 years ago
rxumoz
c22c6c1b3d
[fenix] Update top sites to add PDD for MozillaOnline builds ( https://github.com/mozilla-mobile/fenix/pull/18615 )
3 years ago
Mihai Adrian Carare
89321fbec1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18260 - Add pin to default sites. ( https://github.com/mozilla-mobile/fenix/pull/18618 )
3 years ago
Roger Yang
d4fa548812
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18535 : Re-add grid layout to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18638 )
3 years ago
Oana Horvath
b9aa2166ca
[fenix] Disable customTrackingProtectionSettingsTest
3 years ago
Oana Horvath
8950cb0b73
[fenix] Re-enable working UI tests from https://github.com/mozilla-mobile/fenix/issues/18644
3 years ago
Mozilla L10n Automation Bot
0875ac09ed
[fenix] Import l10n.
3 years ago
Mugurell
baab77eb92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 - Temporarily disabling UI tests that fail on Firebase.
...
This is a quick solution to resume PR merges.
Investigations and a proper fix is to follow on this same ticket.
3 years ago
Arturo Mejia
c9f822d0d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Optimize the order and messages of onboarding cards
3 years ago
Aaron Train
5a89e3da5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18623 : Fix Gradle task name in gradlewbuild.py ( https://github.com/mozilla-mobile/fenix/pull/18624 )
3 years ago
Roger Yang
e1404fab67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17644 : Record when user taps on a add-on's setting ( https://github.com/mozilla-mobile/fenix/pull/18504 )
3 years ago
Mozilla L10n Automation Bot
a1b234a67b
[fenix] Import l10n.
3 years ago
Jonathan Almeida
101061cae3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18538 : Add BrowserTabsAdapter for tabs tray
3 years ago
Gabriel Luong
b3421edcf8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView ( https://github.com/mozilla-mobile/fenix/pull/18605 )
3 years ago
mcarare
f5c72efb38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17790 : Remove app from recents screen on quit.
3 years ago
Elise Richards
25d14c9a8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17190 : notifications are updated when locale is changed ( https://github.com/mozilla-mobile/fenix/pull/18179 )
...
* Add intent processor for locale changes
* Recreate notification and notify in the service
* Use locale use cases to update notification
* Use notification id instead of tag
* Add locale use cases and restore locale in application
* Send locale to service instead of string
* Controller tests for locale
* Update Android Components version to 74.0.20210323143308
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
9272994178
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18240 - Add a Credit Card preference screen ( https://github.com/mozilla-mobile/fenix/pull/18410 )
...
- Removes an unused preference key "pref_key_credit_cards_addresses"
3 years ago
Roger Yang
baa22e0645
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17791 : Use updated URL with custom tabs when copying to clipboard ( https://github.com/mozilla-mobile/fenix/pull/18590 )
3 years ago
Mugurell
ea39380daa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18585 - Don't use hardcoded String values in Onboarding unit test ( https://github.com/mozilla-mobile/fenix/pull/18597 )
...
Test if the welcome message has the expected structure and uses the expected
String values, not what the string values are.
3 years ago
Vitaly V. Pinchuk
49c057097e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18395 : Dismiss contextual menu when entering/exiting Reader Mode
3 years ago
mcarare
b0f07eea23
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17799 : Add extensions submenu item.
3 years ago
Arturo Mejia
597b246961
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation ( https://github.com/mozilla-mobile/fenix/pull/18252 )"
...
This reverts commit 72754a50
3 years ago
Mozilla L10n Automation Bot
95ced8e2ec
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
0621af82ac
[fenix] Import l10n.
3 years ago
Michael Comella
3b2bda7c81
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add measurement probes for long-running lifecycle methods.
...
In addition to the existing probes for onCreate, this should cover all
lifecycle methods that take a long time in our profiles.
3 years ago
Mozilla L10n Automation Bot
4bbb624c57
[fenix] Import l10n.
3 years ago
Stefan Arentz
340ebf7b0b
[fenix] [SDK-218] Nimbus updates to provide app_name and channel ( https://github.com/mozilla-mobile/fenix/pull/18559 )
...
* [SDK-218] Nimbus updates to provide app_name and channel
Provides the `app_name` and `channel` info to Nimbus.
* Update to A-C Nightly 74.0.20210319190549
Co-authored-by: Travis Long <tlong@mozilla.com>
3 years ago
Michael Comella
1f67254b10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add telemetry for app.onCreate subsections.
...
Hopefully this will help us understand behavior of the
`application_on_create` probe, specifically that it seems to take longer
in telemetry than in does locally compared to `home_activity_on_create`
(comparing the medians to local runs)..
3 years ago
Michael Comella
8182032564
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add TimingDistributionMetricType.measureNoInline.
...
This addresses an issue I found in my follow-up PR.
3 years ago
Roger Yang
4abb852190
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17531 : Use shared preference to store top sites count for telemetry ( https://github.com/mozilla-mobile/fenix/pull/18557 )
3 years ago
Roger Yang
7e59b192b6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17956 : Add top site telemetry to available search engines ( https://github.com/mozilla-mobile/fenix/pull/18129 )
3 years ago
Mihai Adrian Carare
02cabca0c5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12565 : Clean up use of Context within ReviewPromptController. ( https://github.com/mozilla-mobile/fenix/pull/18537 )
3 years ago
mcarare
7150b3870e
[fenix] No issue: Update Android Components version to 74.0.20210318143143
...
Replaces deprecated method setToolbarColor(Int) in CustomTabsIntent.Builder.
3 years ago
Mozilla L10n Automation Bot
c204581e87
[fenix] Import l10n.
3 years ago
Stefan Arentz
471e2245d2
[fenix] Enable the Nimbus experiments library on all channels ( https://github.com/mozilla-mobile/fenix/pull/18526 )
3 years ago
Roger Yang
1569a8ce76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17644 : Always update add-on's telemetry values before sending metric ping ( https://github.com/mozilla-mobile/fenix/pull/18529 )
3 years ago
Jonathan Almeida
c6f95e1f5c
[fenix] Enable new tabs tray only for debug builds
3 years ago
Codrut Topliceanu
4fb1bbf431
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation ( https://github.com/mozilla-mobile/fenix/pull/18252 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17805 - Fix adjustResize deprecation
To handle the deprecation of `adjustResize` I've moved it from `styles.xml` and `AndroidManifest.xml` to `Activity.kt` as a fallback for devices with Android < 11. For Android 11 and up `setDecorFitsSystemWindows(false)` and `OnApplyWindowInsetsListener` will be used to handle app insets. Normal use activities should call `enableSystemInsetsHandling` in `onCreate` as to properly display system bars and for proper keyboard handling.
3 years ago
Mozilla L10n Automation Bot
6f6f491106
[fenix] Import l10n.
3 years ago
Mozilla L10n Automation Bot
01cbaae87a
[fenix] Import l10n.
4 years ago
Jonathan Almeida
122597ce56
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17822 : Create a tabs tray layout and fragment
...
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
4 years ago
Gabriel Luong
f1b86e17ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18408 - Add a lazy getter for AutofillCreditCardsAddressStorage
4 years ago
Grisha Kruglov
1c4f366083
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18501 : Enable Nimbus on Beta channel
4 years ago
Oana Horvath
be560986e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18481 : waits for url to be visible in TestHelper.verifyUrl() ( https://github.com/mozilla-mobile/fenix/pull/18498 )
4 years ago
Oana Horvath
a862baeda2
[fenix] Add first set of UI tests to Nightly
4 years ago
Mozilla L10n Automation Bot
ed823030dd
[fenix] Import l10n.
4 years ago