Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Code Issues Releases Wiki Activity
4,511 Commits 67 Branches 116 Tags 1.2 GiB
c143f95819
Commit Graph

3865 Commits

Author SHA1 Message Date
Jeff Boek
3946ec11de
Polish homescreen (#11065) 
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
 2020-05-29 17:09:12 -05:00
ekager
20e358228e For #11015 - Switch Default ETP Setting to Standard 2020-05-29 16:39:47 -04:00
Tiger Oakes
749c95e0f0
Add tests for ReaderModeController (#11049) 2020-05-29 11:46:31 -07:00
Jan-Erik Rediger
98bf27fdd4 Proguard/r8: Do not allow access modification. 
This optimization pass changes internals to become public and thus JNA trying to read their "native size".
This is a bug in R8 (the optimizer in use).

Upstream bug report: https://issuetracker.google.com/issues/157535162,
which is a duplicate of
https://issuetracker.google.com/issues/131130038.

Bug fix: https://r8-review.googlesource.com/c/r8/+/51323/
This fix will be available in r8 v2.1.28, probably getting released next week or so.
 2020-05-29 10:25:27 -07:00
Jan-Erik Rediger
88fe3fbf82 Dump proguard-android-optimize.txt into local configuration for later modification 
This was achived by:

* Adding `-printconfiguration r8.txt` to `proguard-rules.pro`
* Copying the part from start of `r8.txt` to before the `-printconfiguration` line into its own file.

This gets us exactly what was used in the bundled version.
 2020-05-29 10:25:27 -07:00
Mihai Eduard Badea
11df3aaca1 For issue#10727 - Logins auth redirect 
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.

Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
 2020-05-29 12:57:28 -04:00
Jeff Boek
58a42828a1 For #10496 - Fully expand bottom sheet when loaded 2020-05-29 08:31:32 -07:00
Jeff Boek
0566790257 For #10496 - Automatically scroll to the selected tab when you open the tab tray 2020-05-29 08:31:32 -07:00
Aaron Train
507ccaec7e
Closes 10927: Improve wait on session loaded for UI tests (#10928) 2020-05-29 10:13:57 -04:00
ValentinTimisica
29be9e4b9f Fixes #10064: Updates UI tests for About Page 2020-05-29 09:26:46 +03:00
ValentinTimisica
9f265fd62f Fixes #10064: Open help articles in normal tab instead of custom tab 2020-05-29 09:26:46 +03:00
mcarare
906d72c894 For #9594: Increase touch target for snackbar action button button. 2020-05-28 19:41:28 -07:00
David Walsh
267cf35edb For 11001 - Show close all tabs above tab tray 2020-05-28 19:39:56 -07:00
David Walsh
a70ba76cc9 Provided unique no tabs message per mode 2020-05-28 19:38:41 -07:00
Mozilla L10n Automation Bot
c9722c65a2 Import l10n. 2020-05-28 18:18:20 -07:00
apoorv9990
3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 2020-05-28 16:08:07 -07:00
apoorv9990
97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding 
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
 2020-05-28 16:08:07 -07:00
Sawyer Blatz
b06be1fcde For #9488 Add telemetry for search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz
94d741864e For #9488: Add search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz
27a85d86dc
For #10803: Hide voice icon in search if not available (#11005) 2020-05-28 14:34:44 -07:00
Christian Sadilek
7b5661ed10 Update Android Components version to 44.0.20200528190114 
Pass store to download manager and service to address API changes.
 2020-05-28 17:26:38 -04:00
Jonathan Almeida
63b4fcd4c4 For #11004: Fix invisible text on migration UI 
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
 2020-05-28 15:48:42 -04:00
David Walsh
c0c895af33
For 10665 - Show the most recent tabs at the top of the tab tray (#10687) 2020-05-28 11:17:52 -05:00
ValentinTimisica
03284e2da0 Fixes #10674: Add SignInView only once 2020-05-28 08:38:24 -07:00
David Walsh
4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751) 
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
 2020-05-28 10:22:12 -05:00
David Walsh
ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open (#10960) 2020-05-28 10:17:55 -05:00
Oana Horvath
43a78c4fd6
For #10761: Updates UI test tracking test page asset (#10945) 2020-05-28 10:57:10 -04:00
Roger Yang
6cef0edd5e
Closes #10980: Stop sending native crashes to Sentry (#10982) 2020-05-28 10:42:05 -04:00
ValentinTimisica
7974a5c77c Fixes #10815: Sort login items on initial load 2020-05-28 13:42:50 +03:00
Mihai Eduard Badea
610409862b For issue #10725 - Truncated account details 
- Set the textview's height to "wrap_content" and added top/bottom padding to account for the size difference and maintain the original height
 2020-05-28 13:41:29 +03:00
mcarare
9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 2020-05-28 13:18:25 +03:00
Mozilla L10n Automation Bot
aa487bf4c3 Import l10n. 2020-05-28 08:31:41 +03:00
David Walsh
424598946a For #10962 - Remove tab tray tab text labels 2020-05-27 16:40:49 -07:00
David Walsh
58a7e63105 For 10965 - Implement content description and fix border for add button 2020-05-27 16:40:26 -07:00
David Walsh
248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 2020-05-27 13:07:03 -05:00
David Walsh
54cb8f0194 Remove unused import 2020-05-27 08:45:15 -07:00
David Walsh
5e4fd460f8 Remove onTabClosed from interactor 2020-05-27 08:45:15 -07:00
David Walsh
8b843ac9e5 Fix elevation for snackbar and fab 2020-05-27 08:45:15 -07:00
David Walsh
e9bcc9bb1e Move snackbar to TabTrayDialogFragment 2020-05-27 08:45:15 -07:00
David Walsh
f653964ee1 For #10864 - Display snack bar to undo closing tabs 2020-05-27 08:45:15 -07:00
mcarare
a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate. 
Also remove text margin to maintain visual appearance.
 2020-05-27 08:43:43 -07:00
mcarare
d706b085a9 For #9626: Delay cloning ConstraintSet to only when needed for updating. 2020-05-27 08:43:43 -07:00
Mugurell
d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen 
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
 2020-05-27 08:42:56 -07:00
Sebastian Kaspari
21bd379438 Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER. 2020-05-27 10:55:44 +02:00
Mozilla L10n Automation Bot
d54dbce7ba Import l10n. 2020-05-26 18:32:04 -07:00
Roger Yang
538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 2020-05-26 14:37:53 -04:00
Tiger Oakes
2397695fe5
For #10596 - Redirect moz://a URL (#10688) 2020-05-26 11:06:01 -07:00
Simon Chae
422cf74731 For #8319: Integrate nest WebExtensionBrowserMenu support 2020-05-26 14:02:22 -04:00
Mozilla L10n Automation Bot
a50aa839f3 Import l10n. 2020-05-26 08:47:03 +03:00
Grisha Kruglov
e3f0df0118 Update Settings About test to account for debug builds 2020-05-25 22:13:05 -07:00
Grisha Kruglov
0e47f55c24 Only set real BUILD_DATE for non-debug builds 
This avoids BuildConfig modifications between local dev builds,
and speeds up the builds by avoiding running tasks that depend on BuildConfig.

Locally, depending on exact build circumstances, this saves about 5% of build runtime
for simple code changes, and about 90% of build runtime for no-op builds.
 2020-05-25 22:13:05 -07:00
Jonathan Almeida
aa0b8f65b1 For #10915: Disabled failing UI tests in SettingsPrivacyTest 2020-05-25 23:05:45 -04:00
mcarare
6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
mcarare
44d9dc9237 For #10705: Update copy of auto font sizing preference. 2020-05-25 17:50:35 -04:00
mcarare
a62f4b2caa For #10851: Add end constraint for text view. 2020-05-25 17:49:39 -04:00
mcarare
ce46a96742 For #10706: Update copy of deleting open tabs preference. 2020-05-25 17:37:29 -04:00
Sebastian Kaspari
b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 2020-05-25 16:13:54 +03:00
Mugurell
2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs 
This comes to resolve a small regression in which they were opened in new
custom tab.
 2020-05-25 14:37:00 +03:00
Oana Horvath
d3672880a3
for #10690: disable editBookmarkTest (#10891) 2020-05-25 12:37:21 +03:00
Mozilla L10n Automation Bot
7c7d860293 Import l10n. 2020-05-25 09:51:40 +03:00
Jonathan Almeida
8d7c911202 For #10885: Don't add migration activity to history stack 2020-05-25 09:48:52 +03:00
Sawyer Blatz
0a3727e1e6
No issue: Update installation docs timestamp for clarity (#10866) 2020-05-22 14:17:47 -07:00
Grisha Kruglov
b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread 
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
 2020-05-22 13:50:57 -07:00
David Walsh
ebb562a789 For #10859 - Use dark or light mode colors for tab tray in private mode 2020-05-22 13:34:30 -07:00
Sawyer Blatz
7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
Justin Wood
4bf04142ba Bug 1638073 - Update conftest for 'tps' to use current (firefoxci) api urls 2020-05-22 11:16:33 -07:00
Oana Horvath
b2673bc654
for #10753: improves the clickAddBookmarkButton method in flaky tests (#10842) 2020-05-22 21:06:24 +03:00
Mozilla L10n Automation Bot
e21352144b Import l10n. 2020-05-22 16:48:52 +03:00
sraturi
29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll. 
touch listener was blocking the scroll
 2020-05-21 18:54:50 -07:00
sraturi
4ee65755dc for #7032 fixed issue where pressing back button exited the application 2020-05-21 18:54:50 -07:00
sraturi
2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 2020-05-21 18:54:50 -07:00
sraturi
c8ec25fde9 fixed lint issues 2020-05-21 18:54:50 -07:00
sraturi
703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek
601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek
c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 2020-05-21 15:17:20 -07:00
Jeff Boek
a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek
4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
cc6a380d45 For #10504 - Show tab dialog on browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek
0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 2020-05-21 15:17:20 -07:00
Jeff Boek
dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek
34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
Jeff Boek
97d66cce56 For #10504 - Creates the TabTrayDialogFragment 2020-05-21 15:17:20 -07:00
ekager
516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 2020-05-21 10:11:50 -07:00
ekager
83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 2020-05-21 10:11:39 -07:00
Christian Sadilek
4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
Oana Horvath
fed3f2fe91
for #10759: close notification shade if still open (#10819) 2020-05-21 18:41:00 +03:00
codrut.topliceanu
7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
 2020-05-21 10:02:51 -04:00
David Walsh
346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Sawyer Blatz
477493e197
For #10465: Add telemetry for voice search (#10785) 2020-05-20 14:35:57 -07:00
Mozilla L10n Automation Bot
3b866d4da4 Import l10n. 2020-05-20 10:14:19 -07:00
isabelrios
1b8a990edb
For #10756 - UI intermittent media playback failures (#10775) 2020-05-20 10:41:31 -04:00
David Walsh
2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 2020-05-19 13:30:18 -07:00
Sawyer Blatz
535e020683 For #1216: Put voice search behind a nightly & debug flag 2020-05-19 13:04:11 -07:00
Sawyer Blatz
d33edd8841 No issue: Clean up SearchFragment a bit 2020-05-19 13:04:11 -07:00
Sawyer Blatz
011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
Aaron Train
c0e4056c16
No issue: Disable validateBaselinePing UI test (#10772) 2020-05-19 10:59:55 -04:00
Mozilla L10n Automation Bot
fe3a67ac68 Import l10n. 2020-05-18 20:22:37 -07:00
Michael Comella
b0b2f87ab4 For #10757: remove no-op Experiments code and dependency. 
We were supposed to have removed Experiments for performance purposes.
However, I find some code dangling in the tree.

Experiments.initialize is no longer called so I suspect
Experiments.withExperiment is a no-op. I verified that the lambda
function provided to it never ran in my local geckoBetaDebug on startup.
Assuming experiments behavior doesn't change in other build types, this
change appears safe.
 2020-05-18 15:38:38 -07:00
ekager
d46369696f For #10718 - Finish activity after removing external session 2020-05-18 15:32:29 -07:00
ekager
28a6b1f9d5 For #10691 - Turn on LeakCanary by default for debug builds 2020-05-18 15:08:09 -07:00
Mozilla L10n Automation Bot
dc92ddb0e5 Import l10n. 2020-05-18 14:04:23 -07:00
Tiger Oakes
cd64647a4d For #9286 - Add isDefault to topsites 2020-05-18 14:04:10 -07:00
Juan Goncalves
ee62297b4c For #7854 - Update the views only if the bookmark node has changed 
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
 2020-05-18 13:05:12 -07:00
Emily Kager
32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint" 
This reverts commit d66762910f.
 2020-05-18 10:33:11 -07:00
Emily Kager
9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment" 
This reverts commit 536921bcea.
 2020-05-15 21:14:55 -07:00
ekager
d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 2020-05-15 10:55:38 -07:00
partha2000
124b21d209 For #10632 - Update Content Description for X icon in collection 2020-05-15 10:31:05 -07:00
Sachin
536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment 
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
 2020-05-15 10:30:00 -07:00
mcarare
b244fd53ac For #10656: Adjust etp checkbox dimensions for a11y. 2020-05-15 17:39:51 +03:00
Mozilla L10n Automation Bot
a3c6492d5f Import l10n. 2020-05-14 22:11:38 -07:00
Grisha Kruglov
d37529e416 Perf telemetry for awesomebar suggestion provider durations 
See mozilla-mobile/android-components#6802 for details; requires that PR.
 2020-05-14 14:13:53 -07:00
Simon Chae
cb307061ab Update Android Components version to 42.0.20200514130134 2020-05-14 10:44:33 -07:00
Oana Horvath
19dd057cd5
MediaNotificationTest: close media notification shade after each test (#10649) 2020-05-14 17:01:09 +03:00
Oana Horvath
84a6cc4d92
for #10587: Disable all flaky collections tests (#10643) 2020-05-14 14:48:42 +03:00
Mihai Branescu
750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes 
Useful for links from other apps + adding a page to multiple collections
 2020-05-14 10:14:06 +03:00
Mozilla L10n Automation Bot
62e68c579a Import l10n. 2020-05-13 18:54:28 -07:00
Mihai Branescu
d6b448eeaa For #10599 - Removed baseline pings form metrics.yaml 
As per documentation, this ping is intended to provide metrics that are managed by the library itself, and not explicitly set by the application or included in the application's metrics.yaml file.
 2020-05-13 14:34:03 -07:00
Christian Sadilek
7993f1017d Migrate feature-accounts to browser-state 2020-05-13 14:24:56 -04:00
sraturi
372bb421cc created kotlin doc for FenixApplication 2020-05-13 11:01:12 -07:00
Vishwa Patel
06aada251d
Issue 7266 fenix remove line (#10630) 2020-05-13 10:36:58 -07:00
Simon Chae
7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 2020-05-13 12:25:34 -04:00
Oana Horvath
3a94d64d61
Disable failing tests from #10587 and #10586 (#10620) 2020-05-13 15:02:18 +03:00
Mozilla L10n Automation Bot
7fc006a5a8 Import l10n. 2020-05-13 10:58:48 +03:00
Elise Richards
edc75c3ad0
Fixes #9504: Edit logins (#9693) 
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
 2020-05-12 17:32:01 -05:00
Tiger Oakes
f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
Simon Chae
9a30d57db9
Update Android Components version to 41.0.20200512130104 🎲🎲 (#10600) 
* Update GLEAN metrics and ping formatting

* Update Android Components version to 41.0.20200512130104.
 2020-05-12 14:52:58 -04:00
David Walsh
86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 2020-05-12 10:02:29 -05:00
mcarare
58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 2020-05-12 17:21:26 +03:00
Oana Horvath
56e0dd8d6d
for #9407: fixed and added collection tests (#10566) 2020-05-12 10:51:44 +03:00
Sebastian Kaspari
d58c022619 Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
mcarare
a7ff8cafc7 For #7887: Increase touch target height for learn more link. 2020-05-11 22:50:41 -07:00
mcarare
ff6447b755 No issue: Fix xml indentations. 2020-05-11 22:50:41 -07:00
Mozilla L10n Automation Bot
65f30c75e8 Import l10n. 2020-05-11 17:34:32 -07:00
Jeff Boek
a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 2020-05-11 17:18:09 -05:00
Simon Chae
5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 2020-05-11 16:31:31 -04:00
ValentinTimisica
1e83f54a94 For #10343: Updates UI tests accordingly to 'Library' removal 2020-05-11 10:22:19 -07:00
ValentinTimisica
15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 2020-05-11 10:22:19 -07:00
ValentinTimisica
b2e5820364 For #10343: Remove 'Library' functionality from the app 
Also adds Bookmarks and History items to browser menu.
 2020-05-11 10:22:19 -07:00
Simon Chae
ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
Mihai Branescu
dd843b4989 For #10501 - use theme instead of tint to support older APIs 2020-05-11 19:22:00 +03:00
Mozilla L10n Automation Bot
55a8bf7ff9 Import l10n. 2020-05-10 19:42:20 -07:00
Sawyer Blatz
17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 2020-05-09 10:35:57 -07:00
Simon Chae
d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
Sawyer Blatz
b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 2020-05-08 12:04:15 -07:00
codrut.topliceanu
d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Mozilla L10n Automation Bot
824022c28d Import l10n. 2020-05-08 08:44:39 -07:00
Arturo Mejia
ca01965f90 Fix PictureInPictureFeature breaking change 2020-05-08 11:42:06 -04:00
ekager
7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 2020-05-08 14:00:09 +03:00
Oana Horvath
edff0d8e2c
fix #10468: wait for main menu to disappear after creating bookmark (#10478) 2020-05-08 12:58:32 +03:00
ValentinTimisica
f63cb4e09f For #10244: Creates drawable for add-ons private browsing label. 
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
 2020-05-07 17:27:46 -07:00
Sawyer Blatz
a01881067f For #8643: Updates colors of onboarding accents 2020-05-07 17:24:54 -07:00
Sawyer Blatz
5f11c5e648 For #9857: Updates onboarding button styles 2020-05-07 17:24:54 -07:00
Jeff Boek
58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu
eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ekager
138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 2020-05-07 10:17:42 -07:00
Sawyer Blatz
02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 2020-05-07 08:57:20 -07:00
Jonathan Almeida
57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 2020-05-07 11:44:19 -04:00
ValentinTimisica
77705d1a27 For #9505: Adds tests for sort saved logins 2020-05-07 08:43:59 -07:00
ValentinTimisica
24ba9f2fc8 For #9505: Adds possibility to sort saved logins 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
 2020-05-07 08:43:59 -07:00
TejaswiKarasani
2e45244b6c
no issue: Added settings_privacy_items_test (#10474) 2020-05-07 07:45:48 -07:00
mcarare
9177871edc For #10408: Check current destination before navigating. 2020-05-07 09:35:10 +03:00
ekager
9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 2020-05-06 23:24:46 -07:00
ekager
9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 2020-05-07 09:20:49 +03:00
Mozilla L10n Automation Bot
c8d8a700fe Import l10n. 2020-05-06 18:14:28 -07:00
Michael Comella
4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 2020-05-06 17:27:58 -07:00
David Walsh
8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Simon Chae
609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 2020-05-06 13:58:42 -04:00
Simon Chae
a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 2020-05-06 13:17:17 -04:00
Mihai Branescu
6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu
cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Mihai Branescu
03726384de For #8643 and #7606 - Changed styles for most onboarding cards 2020-05-06 09:18:27 +03:00
Mihai Branescu
048d22dbcf For #8643 and #7606 - added styles and new colors 2020-05-06 09:18:27 +03:00
Mihai Branescu
18b6c29b4a For #8643 and #7606 - added new svgs for onboarding illustrations 
RTL for toolbar are still missing
 2020-05-06 09:18:27 +03:00
Mihai Branescu
fab52c9702 For #8643 - removed all onboarding-related PNGs 2020-05-06 09:18:27 +03:00
Mihai Branescu
77912b29fb For #8643 - Replaced onboarding theme/toolbar assets 2020-05-06 09:18:27 +03:00
Mozilla L10n Automation Bot
0b82f8e996 Import l10n. 2020-05-05 17:34:05 -07:00
Arturo Mejia
398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek
fee09c3092 No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek
d72e455c0d No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
kglazko
c0c41dfd74
No Issue Reenable testDownloadPrompt (#10407) 
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
 2020-05-05 11:24:16 -07:00
Mihai Adrian
43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
David Walsh
5087bcf9f6
For #10395 - Improve alignment of close buttons with menu in tab tray (#10405) 2020-05-05 11:16:47 -07:00
David Walsh
249e0cd4e8
For #10159 - Tab tray bottom toolbar colors (#10326) 2020-05-05 11:16:09 -07:00
Mihai Adrian
5106134786
For #10408: Dismiss menu when navigating away. (#10415) 
The menu is dismissed when toolbar view is detached from window.
 2020-05-05 11:15:30 -07:00
Mozilla L10n Automation Bot
d2a3613b73 Import l10n. 2020-05-05 09:11:03 +03:00
David Walsh
542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 2020-05-04 22:51:07 -04:00
Michael Comella
2773a9e0a9 No issue: losslessly compress image assets. 
Using ImageOptim. Results: 110 KB out of 1.9 MB (5.7%).
 2020-05-04 14:54:46 -07:00
Jeff Boek
81d0db76e9
For #10395 - Fixes tab tray bar dimensions to better align with the browser toolbar (#10400) 2020-05-04 12:44:37 -05:00
Alessio Placitelli
14e58c9353 Fixup the BaselinePingTest 2020-05-04 10:37:44 +03:00
Mozilla L10n Automation Bot
34f2350ada Import l10n. 2020-05-04 10:31:35 +03:00
Mugurell
c6c5777090 For #10322 - Update Glean - total_uri_count documentation 
total_uri_count continues to accurately track the URLs visited by the user in
the current session.
Websites can though programmatically redirect users to a new URL using simple
javascript even without user interaction.
This needs to be documented for future references.
 2020-05-01 18:34:39 -07:00
Mozilla L10n Automation Bot
5abe3ac877 Import l10n. 2020-05-01 18:34:10 -07:00
Sören Hentzschel
10d07912da no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek
94cd195dc7
Adds swipe to delete tab (#10355) 
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
 2020-05-01 15:45:51 -05:00
Simon Chae
3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek
5c7e9b98cd
Fix home navigation (#10350) 2020-05-01 12:46:02 -05:00
Mozilla L10n Automation Bot
95b29f2f60 Import l10n. 2020-04-30 17:38:35 -07:00
Jeff Boek
a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313) 
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
 2020-04-30 15:53:10 -05:00
Sawyer Blatz
f7dcb9f7b3 For #9208: Make slight modifications to tip layout 2020-04-30 11:57:43 -07:00
David Walsh
7ec4bc9d76 For #10159 - Implement new tab tray colors 2020-04-30 08:56:40 -07:00
Michael Droettboom
c6086103b4 Update generated docs 2020-04-30 08:37:22 -07:00
Michael Droettboom
c373af5d46 Fix glinter errors 2020-04-30 08:37:22 -07:00
Chenxia Liu
390c5a0189 Issue #7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti
4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen 
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
 2020-04-30 13:38:52 +03:00
David Walsh
688c377197 For 10296 - Implement tab tray dimension changes 2020-04-29 21:28:36 -07:00
Arturo Mejia
56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager
2e27bbd15d No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Mozilla L10n Automation Bot
6d1a2ca797 Import l10n. 2020-04-29 17:55:53 -07:00
Sawyer Blatz
38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 2020-04-29 14:03:59 -07:00
mcarare
4006501d41 For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
mcarare
80f74ac611 For #9728: Change SearchView hint color inside app. 2020-04-29 11:20:18 -07:00
ekager
52d09930a6 No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea
02bd0cc203 For issue #8648 2020-04-29 09:48:42 -07:00
Mozilla L10n Automation Bot
cdbaa52cab Import l10n. 2020-04-28 17:33:33 -07:00
Jonathan Almeida
76002c5987 Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Oana Horvath
2c18c255da
For #9783: bring app in focus with sendSingleTapToScreen for UI test (#10136) 2020-04-28 10:46:42 -04:00
Sören Hentzschel
f0e659bfdb For #9880 - fixed sync settings style 2020-04-28 09:06:36 +03:00
Falaye Iyanuoluwa
c86209ff98 Closes #9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
Mozilla L10n Automation Bot
b7ea583250 Import l10n. 2020-04-28 08:35:44 +03:00
mcarare
7409dc2bae For #10083: Do not cut off thumb when it is in pressed state 2020-04-27 21:19:44 -07:00
mcarare
3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh
6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Christian Sadilek
87c95a64d3 Configure M2 AMO collection for all builds 2020-04-27 18:33:31 -04:00
Mozilla L10n Automation Bot
88f4e5f217 Import l10n. 2020-04-28 00:28:46 +03:00
Arturo Mejia
a8843def6c Fix CrashReporterService breaking changes 2020-04-27 16:43:05 -04:00
Arturo Mejia
e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
Oana Horvath
21894a3cea
Added new bookmarks tests (#9878) 
Fix for #7417: Fix and re-enable disabled tests
 2020-04-27 18:15:27 +03:00
ekager
a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
Mihai Branescu
f10e202a1e For #6557 - added web-extension for cookies 2020-04-24 15:47:48 -07:00
mcarare
996dabae8b For #10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
mcarare
0f3d4e4cbe For #10188: Fix xml indentations and properties order. 2020-04-24 13:28:53 -07:00
mcarare
e830da59b7 For #10180: Remove touch delegate when button is disabled. 
Also refactored multiple if's into a when.
 2020-04-24 13:28:29 -07:00
mcarare
3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
ekager
59484208d6 No issue: Update Private Browsing placeholder string 2020-04-24 11:39:14 -07:00
Mihai Branescu
8a80fbe14c For #6558 - change from modifying event to event listener 
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
 2020-04-24 09:28:40 -07:00
Mihai Branescu
8e66e19dbb For #6558 - remove baidu and yahoo from monitored pages 
These two do not contain ad servers, so we don't need to unnecessarily monitor them
 2020-04-24 09:28:40 -07:00
Mihai Branescu
c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Mihai Branescu
c4f7972f2b For #6558 - added web extension for extracting document urls 2020-04-24 09:28:40 -07:00
Simon Chae
f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
Oana Horvath
e4764592fd
fix private notification text (#10192) 2020-04-24 17:55:46 +03:00
mcarare
2edd4b39a4 For #9913, For #9914: Remove button when disabling it. 
Setting visibility to GONE allows clicks to parent view in that space.
 2020-04-24 16:42:47 +03:00
Arturo Mejia
956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event 
Fixes #9834
 2020-04-23 10:33:36 -07:00
Simon Chae
b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
932fd44823 For #7387: Change ETP onboarding from popup to a dialog. 
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
 2020-04-23 08:17:42 -07:00
mcarare
72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
JLRoberts
26e8d9bcca For #9550 - Don't overlap search with shortcuts text 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
 2020-04-23 11:21:53 +03:00
mcarare
e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Sawyer Blatz
95f26f1fdc
For #9946: Update FennecBeta branding (#10066) 2020-04-22 15:19:24 -07:00
Roger Yang
0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
Mozilla L10n Automation Bot
c702de05f9 Import l10n. 2020-04-21 09:04:12 +03:00
ekager
a1554834f9 Adds destructive colors for private theme 2020-04-20 23:00:41 -07:00
codrut.topliceanu
d80005235f For #8546 - Overrides for new TextInputLayout colors 2020-04-20 23:00:41 -07:00
ekager
66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
isabelrios
587bdfbd7b
For #8081 - UI screenshots tests update (#10023) 2020-04-20 10:39:56 -04:00
Ryan Kelly
8ebb891bf8 Some cleanups for running the sync integration tests 2020-04-18 02:30:44 -07:00
Grisha Kruglov
853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder 
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
 2020-04-17 23:57:43 -07:00
Jonathan Almeida
c16283a923 For #9932: Fix navigation icon theme missing from migration UI 
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
 2020-04-17 22:45:30 -07:00
Sawyer Blatz
89cfa3ea9a For #9808: Fix scrolling cutoff on homescreen 2020-04-17 19:58:22 -07:00
Sawyer Blatz
a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang
40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
ec1d4e8fca For #8399: Hide keyboard to prevent content resizes 
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
 2020-04-17 12:07:44 -07:00
Emily Kager
d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment (#10009) 
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
 2020-04-17 11:50:56 -07:00
Jonathan Almeida
cab0bfc073 For #8422: Add more misc migration UI fixes 2020-04-17 14:22:25 -04:00
Michael Comella
909ee734bf For #8803 - post: update metrics & pings data review URL. 2020-04-17 09:11:58 -07:00
Michael Comella
f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
2888d66ce0 For #8803 - review: move forward metric expiration date. 
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
 2020-04-17 09:11:58 -07:00
Michael Comella
f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
dbf733d70a For #8803: add StartupFrameworkStartMeasurement. 
This class controls the central logic around the metrics we want to
record.
 2020-04-17 09:11:58 -07:00
Michael Comella
7f618a6a7c For #8803: add Stat and test. 
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
 2020-04-17 09:11:58 -07:00
Michael Comella
a0c4b33b0f For #8803: add StartupTimeline ping type and framework_start metrics. 2020-04-17 09:11:58 -07:00
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016) 
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
 2020-04-17 08:57:36 -07:00
ekager
6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry 
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
 2020-04-16 21:00:27 -07:00
Mihai Adrian
72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998) 
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
 2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot
dbbd048b6c
Import l10n. (#10011) 2020-04-16 20:32:21 -07:00
Emily Kager
1df9c53b9f
Fix: Set correct height for EditText (#10014) 
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
 2020-04-16 20:31:25 -07:00
Mihai Eduard Badea
725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
5a2a779ef5 For #9565: Adjust padding and height to allow longer text 2020-04-16 20:10:45 -07:00
mcarare
e87ea301ab For #9536: Update tests to check opened tab is in same browsing mode 2020-04-16 19:50:25 -07:00
mcarare
83d2208c6b For #9536: Open report issue tab depending on current browsing mode. 
Checking if session is private uses the new browser state API.
 2020-04-16 19:50:25 -07:00
mcarare
8440f1867a For #9989: Add start & end margin to button. 2020-04-16 19:43:34 -07:00
Sawyer Blatz
1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
ekager
6df11619fd No issue: Uses NeutralButton for Migration Activity 2020-04-16 13:14:34 -07:00
Jonathan Almeida
2bb1b6edad For #8422: Add misc migration UI fixes 2020-04-16 12:02:02 -07:00
Jonathan Almeida
25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot
3e8836f71a Import l10n. 2020-04-16 10:13:30 +03:00
ekager
688a33522b For #9516 - Adds selectable background to dialog and snackbar buttons 2020-04-16 10:13:08 +03:00
Sawyer Blatz
8185ba793e
For #9857: Create button style (#9858) 
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
 2020-04-15 15:49:02 -07:00
Jonathan Almeida
997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
e97904662c Remove duplicate FirebasePushService 
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
 2020-04-15 17:55:12 -04:00
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules (#9967) 
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
 2020-04-15 13:20:06 -07:00
Michael Comella
f0464b9e72
For #9644: restrict deps to specific repositories (#9649) 
* For #9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For #9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For #9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For #9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
 2020-04-15 10:54:36 -07:00
ValentinTimisica
c7b123cfea
Fixes #9710: Vertically aligns users_count with rating (#9950) 2020-04-15 10:51:55 -07:00
ekager
aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Jeff Boek
06f1b6c992
No Issue - Fixes nav_graph issues (#9926) 2020-04-15 08:34:45 -07:00
Arturo Mejia
37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot
9a298ea6ba Import l10n. 2020-04-15 03:50:48 +03:00
ekager
2056b6f2ff Update UI test to match Support Page title 2020-04-14 11:34:55 -07:00
ekager
55b04b9885 Update Server.dev to Server.stage to fix A-S upgrade breaking change 2020-04-14 11:34:55 -07:00
Arturo Mejia
8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot
69c7196e77 Import l10n. 2020-04-14 09:54:30 +03:00
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml (#9829) 
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
 2020-04-13 21:43:45 -07:00
Arturo Mejia
eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager
8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
5039546dc5 For #7208 For #7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
Christian Sadilek
152642d98d Configure M2 AMO collection for Nightly/Debug 2020-04-13 10:42:39 -04:00
Oana Horvath
52857b09d7
fix #9670 intermittent tests (#9767) 
also disabled intermittent closePrivateTabsNotification
 2020-04-13 13:17:35 +03:00
mcarare
8cdc523de9 For #9698: Add unit tests for Context extension getStringWithArgSafe 2020-04-13 09:40:00 +03:00
mcarare
a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
e1bc8dc190 Import l10n. 2020-04-13 09:38:41 +03:00
Mugurell
b72c223244
For #7157 - Set BrowserMenu width to be max 314 dp (#9731) 
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
 2020-04-10 10:17:07 -07:00
mcarare
1881975a31 For #9793: Adjust relative positions to provide correct a11y traversal 2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
c31c198d54 Import l10n. 2020-04-09 17:38:37 -07:00
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing. 
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
 2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
ed466d34f7 Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg. 
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
 2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
12d486bf02
Issue #9682: Reduces size of branding (#9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode 
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
 2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
a12cb5b0c3 Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
9305331a56 For #9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
376740cd2c For #9631: replace assertk assertions with junit. 
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
 2020-04-06 16:56:40 -07:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191) 
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
 2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743) 
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
 2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly 
enabling/disabling add-on
 2020-04-06 13:47:21 -04:00
Michael Droettboom
3789f50423 Fix errors in top_sites_count metric 
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
 2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
2d55b07935 Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
cac8115e55 For #9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
9e470c93ca Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
b35704beed Closes #9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
b2da0bd922
For #9670: Disabled intermittent tabMediaControlButton test (#9679) 
and removed file created by mistake -e

added reason for disabled tests
 2020-04-03 20:39:33 +03:00
Mugurell
904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
51a76651d6 For #9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
b60a21c08d For #9605: Add LintUnitTestRunner gradle task. 
This will prevent us from regressing on adding older versions of the
unit test runner.
 2020-04-03 09:27:49 -07:00
Michael Comella
efef8eaba0 For #9605: TestApplication -> FenixRobolectricTestApplication. 
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
 2020-04-03 09:27:49 -07:00
Michael Comella
8df49473c0 For #9605: move TestApplication to the helpers package. 
The helpers/ package is created to separate the test support code from
the code under test.
 2020-04-03 09:27:49 -07:00
Michael Comella
6e0d851da3 For #9605: replace unit test runners with FenixRobolectricTestRunner. 
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
 2020-04-03 09:27:49 -07:00
Michael Comella
b0cfa3ee5c For #9605: add FenixRobolectricTestRunner. 
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
 2020-04-03 09:27:49 -07:00
Michael Comella
392dda5eda For #9605: remove unnecessary @RunWith(Robolectric in unit tests. 
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
 2020-04-03 09:27:49 -07:00
Michael Comella
f2acef66b5 For #9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests. 
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
 2020-04-03 09:27:49 -07:00
Aaron Train
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest (#9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
8413b8133d Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
4a8dc5b54f No issue: add kdoc to HomeActivity. 
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
 2020-04-02 16:27:00 -07:00
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
8c43935ba3
For #7978 - Put views above button in scrollView (#8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
7043f9ee4e
For #9604: Swap and adjust margin with padding to avoid text being cut (#9617) 2020-04-02 09:40:29 -07:00
Michael Comella
c15a005ca8 No issue: remove unused FirefoxTestRunner. 
It would be used for on device tests but it doesn't seem to hooked up
currently.
 2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
202172cd04 Import l10n. 2020-04-02 13:42:58 +03:00
mcarare
fac61fbb41 For #9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare
4d0b37a3b8 For #9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager
327009efc4
For #768: Add first time PWA dialog (#9308) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-04-01 22:56:12 -04:00
Sebastian Kaspari
045b4a5715 Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
David Walsh
26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
8cd6d7460c
For #9336 Check current destination before navigating (#9353) 
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
 2020-04-01 15:36:56 -07:00
Mihai Adrian
90787cf630
For #9423: Align preference title and summary to viewStart (#9426) 
* For #9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
 2020-04-01 15:36:01 -07:00
ekager
fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
96c6401457 For #8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare
b119700820 For #9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Kate Glazko
cca3dae290 NoIssueFixMetropolisAccountPref 2020-04-01 15:13:03 -07:00
Sawyer Blatz
208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu
3d1d146c94 For #9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
mcarare
a2ea53d8f2 For #9574: Remove category layout from LeakCanary SwitchPreference 2020-04-01 10:17:21 -07:00
ekager
4159cd3da7 Closes #9564 : Fixes cut off strings in ETP panel 2020-04-01 10:16:51 -07:00
Mihai Branescu
24596fd3cd For #9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Kate Glazko
d9d5de98c9 For 3687 Use Metropolis Font for Header 2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot
9043120dd7 Import l10n. 2020-03-31 17:52:51 -07:00
Grisha Kruglov
54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems 
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
 2020-03-31 16:07:35 -07:00
Grisha Kruglov
60943df6d9 Closes #9561: Fix initialization order in HomeMenu 
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
 2020-03-31 16:07:35 -07:00
Arturo Mejia
804eb0f5ba For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz
1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
Oana Horvath
5f68d6cb29
Updated the method to verify system notifications and added new tests for media notifications (#9330) 2020-03-31 21:11:41 +03:00
ValentinTimisica
cee34893ed
For #8412: Passes error handling function to 'CustomTabWindowFeature' (#8903) 
* For #8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2020-03-31 10:17:29 -07:00
Grisha Kruglov
f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot
fd263d8329 Import l10n. 2020-03-30 22:00:19 -07:00
Grisha Kruglov
6c38b77315 Part 6: Kick-off account manager initialization after visual completeness 
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
057e28d4e4 Part 5: Refactor HomeMenu<->HomeFragment interaction 
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
029fae4559 Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov
eb98df4edd Part 3: Mark accountManager as 'lazy' in Mode.kt 
This is enough to cause it to be initialized only if we're going through onboarding.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
3efaa516ca Part 2: Do not eagerly initilize account manager within HomeActivity 
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
0677fc35de Part 1: Add 'accountManagerReady' queue to BackgroundServices 
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
be1fa8df7d Pre: introduce a RunWhenReadyQueue 
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
 2020-03-30 21:43:38 -07:00
Aaron Train
4d139d52c4
Closes #9189: Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests (#9439) 
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
 2020-03-30 18:01:58 -04:00
David Walsh
9679b91e82 For #9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
Sawyer Blatz
4ac29530cd
Issue #9132: Update to search animation for top toolbar (#9524) 
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
 2020-03-30 12:07:00 -07:00
ekager
3d55578242 Use existing strings for announcement 2020-03-30 11:10:40 -07:00
asavill
c383d4225e Closes #7720: 
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
 2020-03-30 11:10:40 -07:00
David Walsh
e1187ebf31 For #7059 - Allow search engines to scroll 2020-03-30 10:31:39 -07:00
David Walsh
d989616f62 Add top sites heading to home screen 2020-03-30 10:29:40 -07:00
mcarare
76f15a1f7f For #9498: Update unit tests with new constructor argument 2020-03-30 09:56:51 -07:00
mcarare
f52fa44207 For #9498: Replace navargs with viewModel to remember if scroll to tab 2020-03-30 09:56:51 -07:00
mcarare
ab78951146 For #9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
Simon Chae
e820a35f56 Update NotYetSupported add-ons copy 2020-03-30 10:36:49 -04:00
codrut.topliceanu
1e63d6ce76 For #9500 - Revert patch for 8568 
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
 2020-03-30 07:20:13 -07:00
Sebastian Kaspari
02aabea14a Update to new feature-media API. 2020-03-29 23:13:13 -07:00
Mozilla L10n Automation Bot
cd7c2c4bd5 Import l10n. 2020-03-29 12:32:40 -07:00
Edouard Oger
394f386ac3 Add secret debug menu to override FxA servers 2020-03-27 22:59:14 -07:00
mcarare
18533d3434 For #8764: Use list component for items in collections 2020-03-27 22:14:59 -07:00
mcarare
62bbbd9e37 For #8764: Update collection design, including list elements 2020-03-27 22:14:59 -07:00
mcarare
38a97cd1e0 For #9252: Add progress bar to saved logins view 2020-03-27 22:13:58 -07:00
mcarare
f3bbcc4e17 For #9252: Update views visibility ony when list has finished loading 2020-03-27 22:13:58 -07:00
Arturo Mejia
f9cc2ccfe2 For issue #8017 enable SitePermissionsWifiIntegration 2020-03-27 20:44:16 -04:00
Mozilla L10n Automation Bot
75aba7a2b4 Import l10n. 2020-03-27 17:33:26 -07:00
codrut.topliceanu
ba39a46b88 For #8568 - Refocus URL editText in SearchFragment onResume 2020-03-27 17:24:14 -07:00
Amaan Marfatia
3dcfed3761 AboutPageAdapter doesn't use notifyDataSetChanged() 
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
 2020-03-27 17:23:27 -07:00
David Walsh
180652deab No issue - Make fill link from clipboard divider stretch full screen 2020-03-28 02:10:18 +02:00
mcarare
677a9da5ec For #8485 Update UI tests after settings reorg 2020-03-27 17:05:49 -07:00
mcarare
edabf9c865 For #8485 Move Remote debugging and LeakCanary to Advanced section 2020-03-27 17:05:49 -07:00
mcarare
012e318724 For #8968: Hide keyboard when navigating away from browser 2020-03-27 16:44:11 -07:00
ValentinTimisica
3647606aae Fixes #9280: Remove tabs fade in animation when pressing on Add new collection 2020-03-27 15:54:24 -07:00
Mugurell
9f3bbf1fb7 For #8651 - Add HistoryInteractor/Controller unit/ui tests 2020-03-27 15:53:31 -07:00
Mugurell
fc0260d6ee For #8651 - Ensure FenixSnackbar has a proper root for inflating into 
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
 2020-03-27 15:53:31 -07:00
Mugurell
a1cdd31f0c Fix #8651 - Add new menu actions for a history item 
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
 2020-03-27 15:53:31 -07:00
mcarare
b77f92f9d1 For #9435: Adjust margins and paddings to mirror correctly in RTL 2020-03-27 14:45:47 -07:00
Mihai Branescu
3f12c1cdb9 Closes #9352 - changed capitalisation of 'Open in app' 2020-03-27 14:43:32 -07:00
David Walsh
28406eaf3d No issue - Add content descriptions when missing 2020-03-27 14:41:51 -07:00
mcarare
e8ad2389ac For #7356: Scroll to selected tab when pressing tab overview 2020-03-27 14:13:26 -07:00
ekager
414e905b76 Closes #8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00
Sawyer Blatz
06e5efd03e
No issue: Removes settings entrance animation for now (#9443) 2020-03-27 09:55:24 -07:00
Mihai Eduard Badea
91690d7b48 Replaced name field with search string field 2020-03-27 16:38:59 +02:00
ValentinTimisica
69e8a2f357 Fixes #4987: Remove close tabs functionality when they are added to a collection 2020-03-27 15:42:17 +02:00
ValentinTimisica
a72d50d78f Fixes #7734: Remove animation for back button 2020-03-27 15:37:33 +02:00
Mozilla L10n Automation Bot
5894999f28 Import l10n. 2020-03-27 09:43:08 +02:00
Sawyer Blatz
6065ff85a1
No issue: Fixes indentations on several settings fragments (#9442) 2020-03-26 14:52:08 -07:00
Christian Sadilek
5e9d5dd545 Closes #9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Grisha Kruglov
9e324fa02a Perform storage warm-up after visual completeness 2020-03-26 14:12:35 -07:00
Grisha Kruglov
20f8b97dcb Pass lazy references to FennecMigrator 2020-03-26 11:57:45 -07:00
Sebastian Kaspari
0f0d56e60a Issue #5208: Use new tab/collection restore API. 2020-03-26 10:55:12 -07:00
Mihai Branescu
73a7330b2b For #9395 - Trimmed name for custom search engines 2020-03-26 09:35:23 +02:00
Mozilla L10n Automation Bot
5a9be5e053 Import l10n. 2020-03-26 08:54:04 +02:00
Jonathan Almeida
40ba43311e For #7661: Add deeplink schemas for fennec variants 2020-03-25 15:39:44 -04:00
Arturo Mejia
f785a07ef9 No issue: Add add-on updater information dialog 2020-03-25 13:57:51 -04:00
ValentinTimisica
eb5303fa48 Fixes #8288: Adds content description for ETP back button 2020-03-25 13:18:41 +02:00
Mozilla L10n Automation Bot
d2c23f21cc Import l10n. 2020-03-25 13:12:34 +02:00
Christian Sadilek
d184b99649 Closes #9333: Prevent compression of omni.ja to improve startup time 
Co-authored-by: Markus Stange <mstange@themasta.com>
Co-authored-by: Agi Sferro <agi@sferro.dev>
 2020-03-24 16:10:11 -07:00
Mihai Branescu
a23bcebb5d For #8972 Replaced purple colors to match the rest of the app 2020-03-25 00:13:59 +02:00
Mihai Branescu
494db56ea5 For #9207 - changed status bar color in home fragment to match gradient background 2020-03-24 23:44:46 +02:00
Arturo Mejia
fa9dae0d72 For issue #9364 Crash when blocking app permissions and returning to 
the app
 2020-03-24 13:44:54 -07:00
ekager
eea6eb0c4c Add toolbar padding for bookmark snackbar 2020-03-24 13:33:50 -07:00
ekager
16b40992d2 For #9351 - Show snackbars with toolbar padding to work with dynamic toolbar 2020-03-24 13:33:50 -07:00
Arturo Mejia
5e75140b3d For issue #8809 Notification permissions can't be disabled/re-enabled 
unless you restart the browser
 2020-03-24 15:25:33 -04:00
Arturo Mejia
b484ad38cc No issue: Remove feature flag for removing one TP exception 2020-03-24 11:14:07 -04:00
mcarare
55ea92be5b For #8759 Update Unit tests with activityName instead of packageName 2020-03-24 17:10:19 +02:00
mcarare
7fbb1640b6 For #8759 Use activityName instead of packageName as app identification 2020-03-24 17:10:19 +02:00
Aaron Train
f23b9fcb89
Closes #9346: Add ViewIdlingResource for Reader View UI tests (#9347) 2020-03-24 10:47:11 -04:00
ValentinTimisica
79dc133c9c For #9359: Revert 8491. 
In the UX review of 8491 it was discovered that the proposed solution is not
optimal and we should actually better stick with the old implementation.

This ticket comes to help with that and revert the already merged patch for
8491 and so will add same gradient to the top toolbar as the bottom toolbar.
 2020-03-24 15:12:56 +02:00
Mozilla L10n Automation Bot
8be6c77695 Import l10n. 2020-03-24 09:44:22 +02:00
Arturo Mejia
301f56d144 For issue #9334 Fix Remove of one exception is deleting all 2020-03-23 20:04:04 -04:00
exobyte101
dee1d92293 Remove extra transparent space from widget preview image 2020-03-23 16:54:35 -07:00
exobyte101
746a11c30f Closes #4766: Adjust search widget min height and width according to guildelines 2020-03-23 16:54:35 -07:00
Sawyer Blatz
9feb44852b
For #9256: Attempts to fix installation ping not being sent (#9331) 2020-03-23 14:27:28 -07:00
Kate Glazko
47b2f6a070 For 7077 Simplify Display Url 2020-03-23 12:36:48 -07:00
codrut.topliceanu
9059a6b465 For #6317 - Applies 3dot menuItem look to quickSettings and tracking panel 2020-03-23 12:26:52 -07:00
Aaron Train
f8048462b5
Closes 9291: Fix shortcutSearchEngineSettingsTest (#9292) 2020-03-23 11:04:10 -04:00
Mozilla L10n Automation Bot
db1a093661 Import l10n. 2020-03-23 10:15:56 +02:00
Amaan Marfatia
7236913d94 Closes #7761: Makes the Parent Folder Selector height 48dp for touch accessibility 2020-03-22 00:10:09 +02:00
Mihai Branescu
ab04155222 For #8653 - changed menu strings 2020-03-22 00:03:26 +02:00
mcarare
14338a3b13 For #8899: Set viable anchor for snackbars in both custom and normal tab 2020-03-20 22:46:59 -07:00
ValentinTimisica
8871c05c9d Fixes #9243: Remove tabs fade in animation when pressing on Save to Collection 2020-03-20 22:44:31 -07:00
David Walsh
681d6cf8a1 For #8652 - Allow sharing multiple bookmarks 2020-03-20 20:28:36 -07:00
David Walsh
27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 2020-03-20 19:40:51 -07:00
Mozilla L10n Automation Bot
930c74a42a Import l10n. 2020-03-20 19:40:15 -07:00
Severin Rudie
35a132d7ff
8017 advanced autoplay controls. (#8978) 
* For #8017: add advanced autoplay controls
 2020-03-20 12:10:42 -07:00
Elise Richards
5d8a9bb4be
For #8592: Relocate device name in account preferences. Deactivate device name field while syncing. (#9255) 2020-03-20 12:32:04 -05:00
Sawyer Blatz
a356b4b2c4
For #9136: Send all adjust properties to glean (#9253) 2020-03-20 10:06:55 -07:00
Mugurell
21606bf94f For #8693 - Add rtl onboarding toolbar position picker images 2020-03-20 09:48:04 -07:00
Mugurell
1dca146e4f For #8693 - Add rtl onboarding theme picker images 2020-03-20 09:48:04 -07:00
Aaron Train
8f37977e79
Closes #9262: Add additional waits to LibraryMenuTest (#9263) 2020-03-20 12:16:50 -04:00
ValentinTimisica
fbeff33ef5 Fixes #8491: Changed toolbar background for PBM when is set to top 
This change was required so that the background of the toolbar match the
homeFragment gradient
 2020-03-20 17:13:19 +02:00
Mozilla L10n Automation Bot
e97387257b Import l10n. 2020-03-20 10:51:47 +02:00
Mozilla L10n Automation Bot
310b3caf70 Import l10n. 2020-03-19 16:25:18 -07:00
Sawyer Blatz
b9059c8208
For #9256: Attempts to fix installation ping not being sent (#9254) 2020-03-19 16:22:28 -07:00
Sebastian Kaspari
0198305bfb MigrationPushRenewer: Remove ExperimentalCoroutinesApi. 2020-03-19 16:11:53 -07:00
Grisha Kruglov
e541e10427 Initialize storage after visual completeness 
In order to eat the perceived performance costs, we initialize storage
once we're visually complete. This way, we're reducing chances of user performing
a UI action which will trigger storage init and delay said action.
 2020-03-19 15:46:50 -07:00
Grisha Kruglov
eb14532c3c Closes #7450: Lazy storage initialization 
Make sure that we actually lazily initialize our storage layers.

With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
to initialize (which needs to access the costly securePrefStorage).
Similarly, BackgroundServices init will no longer require initialized instances of the storage
components - references to their "lazy wrappers" will suffice.

In practice, this change changes when our storage layers are initialized in the following ways.
Currently, we will initialize everything on startup. This includes loading our megazord, as well.

With this change, init path depends on if the user is signed-into FxA or not.

If user is not an FxA user:
- on startup, none of the storage layers are initialized
- history storage will be initialized once, whenever:
  - first non-customTab page is loaded (access to the HistoryDelegate)
  - first interaction with the awesomebar
  - history UI is accessed
- bookmarks storage will be initialized once, whenever:
  - something is bookmarked, or we need to figure out if something's bookmarked
  - bookmarks UI is accessed
- logins storage will be initialized once, whenever:
  - first page is loaded with a login/password fields that can be autofilled
  - (or some other interaction by GV with the autofill/loginStorage delegates)
  - logins UI is accessed
- all of these storages will be initialized if the user logs into FxA and starts syncing data
  - except, if a storage is not chosen to be synced, it will not be initialized

If user is an FxA user:
- on startup, none of the storage layers are initialized
- sometime shortly after startup is complete, when a sync worker runs in the background, all storage
layers that are enabled to sync will be initialized.

This change also means that we delay loading the megazord until first access (as described above).
 2020-03-19 15:46:50 -07:00
mcarare
e4acabb329 For #8600:Increase space below left checkbox preference 2020-03-19 15:41:05 +02:00
mcarare
a098b66d26 For #8591: Allow items in quick_action_sheet to be read by a11y services 2020-03-19 15:18:40 +02:00
mcarare
756b1fbadd For #9140: Remove drawable from title in empty state panes 2020-03-19 14:32:40 +02:00
Ryan Kelly
a0f8be25b6 Add support for application-services autoPublish local dev workflow. 2020-03-19 10:51:08 +02:00
Arturo Mejia
7dff584b82 Remove @ObsoleteCoroutinesApi from tests 2020-03-18 17:25:51 -07:00
Arturo Mejia
823eea44ed No issue: Add serverConfig param to FxaWebChannelFeature 2020-03-18 17:25:51 -07:00
Arturo Mejia
e977486809 Remove @UseExperimental for usages of the flow api 2020-03-18 17:25:51 -07:00
mcarare
4425e7139e For #9200: Remove star icon from empty state icon in toolbar 2020-03-18 10:23:50 -07:00
mcarare
772c7062fd For #8814: Change icon asset for top sites menu option 2020-03-18 08:30:33 -07:00
Mozilla L10n Automation Bot
937e1cd2e6 Import l10n. 2020-03-18 15:02:07 +01:00
Jonathan Almeida
ffd4cdd970 For #7661: Add variant-specific schemas for deep links 
In order to target specific variants of Fenix, we're adding schemas that
are specific that app in order to avoid collisions with the other
variants and with other forks of fenix that may have the same schemas.

The current schema for variants:
 - Fenix Nightly: `fenix-nightly://`
 - Fenix Beta: `fenix-beta://`
 - Everything else: `fenix://`
 2020-03-17 17:21:09 -04:00
Sawyer Blatz
b4e1360f59
For #3086: Adds settings animations (#9187) 2020-03-17 12:35:00 -07:00
Christian Sadilek
0d974fe262 For #8808 #9139: Add-on should be able to configure how to open options page 2020-03-17 12:34:07 -04:00
Edouard Oger
a1ea94fe76 Prepare for a-c a-s upgrade 2020-03-17 11:49:54 -04:00
Sebastian Kaspari
34144fd254 Use pinned Android Components Nightly version instead of snapshots. 2020-03-17 12:09:36 +01:00
Severin Rudie
3e38b002dd
No issue: fixes test broken by snapshot (#9176) 
* No issue: fixes test broken by snapshot

* No issue: ignore flaky tests
 2020-03-16 16:44:39 -07:00
Christian Sadilek
63517a52e4 No issue: Remove unneeded logic to adjust TP 2020-03-13 14:08:49 -04:00
isabelrios
74433ba27a
ui-tests-homescreen-fix-to-enable (#9050) 2020-03-13 11:16:47 -04:00
Mozilla L10n Automation Bot
dd38f1df0a Import l10n. 2020-03-13 07:45:13 -07:00
Jonathan Almeida
3d387e2dde Add nightly-only feature flag for WebPush integration 2020-03-12 18:39:32 -07:00
codrut.topliceanu
030bd38631 For #8561 - Scroll to topSites on app cold start 2020-03-12 10:54:58 -07:00
Sawyer Blatz
cc8f34b68b
For #8773: Fixes issue with snackbar placement on ContextMenu (#8942) 2020-03-12 09:54:13 -07:00
Roger Yang
9a582a6983
Closes #9104: Pass release channel information to Socorro service (#9130) 2020-03-12 12:00:14 -04:00
isabelrios
97b5754562
For #9076 - Upddate pipenv to run without error. (#9077) 
* For #9076 - Upddate pipenv to run without error

* pipenv fixed the issue after update
 2020-03-12 11:36:51 -04:00
Jeff Boek
c862ca93ba No issue - Fixes shadow on top layout 2020-03-11 22:59:42 -07:00
Jeff Boek
74ce62b5c3 For #8949 - Removes old motionlayout code, fixes how shadow is drawn 2020-03-11 17:10:40 -07:00
David Walsh
fc67747409 Show the collections header when there are no collections 2020-03-11 16:26:39 -07:00