Gabriel Luong
77a5f7fbd4
For #23251 - Consolidate select credit card and login prompt header styles
3 years ago
Gabriel Luong
ea68cfdf50
For #23245 - Replace @color/inset_private_theme with @color/fx_mobile_private_layer_color_1
3 years ago
Gabriel Luong
52a642233d
For #23245 - Replace @color/above_private_theme with @color/fx_mobile_private_layer_color_1
3 years ago
Gabriel Luong
0c80b196ae
For #23240 - Replace @color/contrast_text_private_theme with @color/fx_mobile_private_text_color_primary
...
@color/contrast_text_private_theme and @color/fx_mobile_private_text_color_primary are the same color
3 years ago
Mozilla L10n Automation Bot
0c34bd93b8
Import l10n.
3 years ago
Matt Tighe
dd4cf9164d
closes #23220 : show snackbar on wallpaper selection
3 years ago
Jonathan Almeida
d99898824b
Update lifecycle dependencies to the commons library
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Matt Tighe
0b99c2e67d
fixes #22943 : update androidx.lifecycle to 2.4.0
3 years ago
Gabriel Luong
7d0fae8450
For #23193 - Remove @color/default_launcher_background redirection
3 years ago
Gabriel Luong
2baa4efa8d
For #23193 - Remove @color/toolbar_[start|center|end]-gradient_normal_theme redirection
3 years ago
Gabriel Luong
608e9ddb81
For #23193 - Remove @color/accent_on_dark_background_private_theme redirection
3 years ago
Gabriel Luong
929697b6e2
For #23193 - Remove @color/fill_link_from_clipboard_private_theme redirection
3 years ago
Gabriel Luong
38c7e53454
For #23193 - Remove @color/onboarding_illustration_selected_private_theme redirection
3 years ago
Gabriel Luong
d18115bbff
For #23193 - Remove @color/accent_high_contrast_dark_theme redirection
3 years ago
Gabriel Luong
ff91a35f1b
For #23193 - Remove @color/accent_bright_dark_theme redirection
3 years ago
Gabriel Luong
fd055ec97e
For #23193 - Remove @color/accent_bright_light_theme redirection
3 years ago
Gabriel Luong
a164a2a5ae
For #23193 - Remove @color/accent_light_theme redirection
3 years ago
Gabriel Luong
f4f2f4d645
For #23203 - Replace @color/snackbar_normal_theme with @color/fx_mobile_action_color_primary
3 years ago
Gabriel Luong
88ed50888d
For #23187 - Replace @color/notification_accent_color_normal_theme with @color/fx_mobile_text_color_accent
3 years ago
Gabriel Luong
1e16d60ddf
For #23191 - Replace @color/preference_section_header_normal_theme with @color/fx_mobile_text_color_accent
3 years ago
Gabriel Luong
f0b37b001f
For #23207 - Update the tabs tray FAB color to @color/fx_mobile_layer_color_accent
3 years ago
Gabriel Luong
5864d49f6b
For #23209 - Replace @color/above_normal_theme with @color/fx_mobile_layer_color_2
3 years ago
Gabriel Luong
56c1d4472c
For #23205 - Replace #66FBFBFE with its photon color @color/photonLightGrey05A40
3 years ago
Alexandru2909
a34711c444
For #20524 - Remove redundant coroutine dispatchers from tests
3 years ago
Alexandru2909
cf83b3050b
For #8108 - Add BrowserToolbar option to remove url from TopSites
3 years ago
Mozilla L10n Automation Bot
16d9866024
Import l10n.
3 years ago
Matthew Tighe
ce1c4093fa
closes #22831 : add wallpaper settings screen ( #23145 )
...
* closes #22831 : add wallpaper settings screen
* address PR and UX feedback
* rebase upstream and adjust settings correctly
3 years ago
Arturo Mejia
d1ace92e64
Revert "For #22851 : Add logo animation for wallpapers."
...
This reverts commit d089f007
3 years ago
Arturo Mejia
d089f00793
For #22851 : Add logo animation for wallpapers.
3 years ago
Arturo Mejia
2bba66fb58
For #23144 Address regression in COLD start
3 years ago
Gabriel Luong
29127f9690
For #16152 - Add a dark theme for the tabs tray grid view
3 years ago
mcarare
afd13fec85
For #21744 : Replace InputMethodManager's deprecated toggleSoftInput.
3 years ago
mcarare
58a6fafabc
For #22383 : Propagate ViewTreeLifecycleOwner to composable view holders.
3 years ago
Roger Yang
047ec890b2
Closes #22550 : Refactor search term tab grouping logic to rely on middleware
3 years ago
Grigory Kruglov
d161e46383
Adjust logins diffing logic for recyclerview
3 years ago
Grigory Kruglov
e67753fb4b
Scroll to top of logins screen after list changes
3 years ago
Grigory Kruglov
1b305c1398
For #22795 : Stop trimming login origins on sorting
...
Due to the async nature (??) of the trimming code, this is causing severe performance issues
during search.
Looking back through commits, doesn't seem like there's a particularly good reason we were trimming here. All I could find is #9986 (comment) which is lacking explanation of why this is actually useful.
And currently, we're dealing with an origin (not a full url when this was initially written, I think), i.e. https://accounts.firefox.com vs https://accounts.firefox.com/signin . So, the suffix stripping isn't even doing much beyond removing com in vast majority of cases.
So, seems like all of this trimming stuff can be cleaned up.
3 years ago
Mozilla L10n Automation Bot
375837c977
Import l10n.
3 years ago
mcarare
2577e07aff
For #22559 : Update leak canary version to 2.8.1
3 years ago
Gabriel Luong
e668c5afc1
For #23128 - Remove @color/mozac_widget_favicon_border_dark_theme redirection
3 years ago
Gabriel Luong
6fbca6de91
For #23128 - Remove @color/mozac_widget_favicon_background_dark_theme redirection
3 years ago
Gabriel Luong
4fcdc46d2a
For #23128 - Remove @color/mozac_widget_favicon_border_light_theme redirection
3 years ago
Gabriel Luong
52edfeed8a
For #23128 - Remove @color/mozac_widget_favicon_background_light_theme redirection
3 years ago
Gabriel Luong
9d0307cad6
For #23128 - Remove @color/mozac_widget_favicon_[background|border]_private_theme redirection
3 years ago
Gabriel Luong
df2e8c885e
For #23156 - Remove all unused strings marked moz:removedIn <= 95
3 years ago
Brais Gabín
7ec31a25c4
For #23142 - Fix license formatting in tests
3 years ago
Mozilla L10n Automation Bot
622a4f57d0
Import l10n.
3 years ago
Elise Richards
703e8c6558
For #22869 : Data review for renewing january metrics
3 years ago
Elise Richards
08087abaf1
For #22869 : Renew metrics expiring in January
3 years ago
Mozilla L10n Automation Bot
39a211c1cd
Import l10n.
3 years ago
Arturo Mejia
28928e4bdd
For #23104 : Don't adjust the theme for the default wallpaper.
3 years ago
Mozilla L10n Automation Bot
0563bf38b2
Import l10n.
3 years ago
Gabriel Luong
9fea89ca19
For #22675 - Replace collection color icon variables with the icon design color tokens
3 years ago
Alexandru2909
7b04eba324
For #19567 - Change SavedLogins and LoginDetail fragments to extend SecureFragment
3 years ago
Gabriel Luong
873d8257d1
For #23086 - Add Border Inverted design token
3 years ago
Gabriel Luong
a39224e44b
For #23086 - Change design token name from Border Selected to Border Accent
3 years ago
Gabriel Luong
2ad2691724
For #23086 - Update Border Divider to Border Default
3 years ago
Gabriel Luong
fc9310dc83
For #23086 - Rename design token name from Border Default to Border Form Default
3 years ago
Gabriel Luong
11e0df20df
For #23086 - Update the dark theme colors of Action Primary to Violet60
...
- Updates the description of Action Primary to include "Chip selected"
3 years ago
Gabriel Luong
65b84c10bc
For #23086 - Update the dark theme Action Secondary color to DarkGrey10
3 years ago
Gabriel Luong
1b7918f6d0
For #23086 - Change the light theme color for Form Selected, Form On, Icon Button, Layer Accent, Border Selected to Ink20
3 years ago
mcarare
5d1e2f0099
For #22577 : Update work manager version to 2.7.1
3 years ago
Mozilla L10n Automation Bot
d727206255
Import l10n.
3 years ago
Gabriel Luong
27336c2368
For #22975 - Replace aboutLink attribute with Text Accent color token
3 years ago
Gabriel Luong
76fb147ed8
For #23076 - Clean up unneeded FeatureFlags
3 years ago
Mozilla L10n Automation Bot
c335adcfb6
Import l10n.
3 years ago
Gabriel Luong
44e1cb4b60
For #23071 - Replace @color/tab_tray_selected_mask_normal_theme with @color/fx_mobile_layer_color_accent_nonopaque
3 years ago
MickeyMoz
96b96fbfdb
Update Android Components version to 97.0.20220104190053.
3 years ago
Arturo Mejia
09fdee6510
For #22851 : Adjust theme based on the selected wallpaper.
3 years ago
Mozilla L10n Automation Bot
32bf020b7c
Import l10n.
3 years ago
Gabriel Luong
ddc806e8bc
For #22978 - Replace @color/foundation_normal_theme with @color/fx_mobile_layer_color_1
3 years ago
Gabriel Luong
7c12e9c970
For #23049 - Update the color for @color/fx_mobile_layer_color_accent_nonopaque
3 years ago
Gabriel Luong
f863864c50
For #23049 - Update the colors of @color/fx_mobile_action_color_primary
3 years ago
Gabriel Luong
986a57d40b
For #23049 - Consolidate @color/fx_mobile_text_color_accent with @color/fx_mobile_text_color_action
...
- Removes @color/fx_mobile_text_color_action
- Use the colors from @color/fx_mobile_text_color_action in @color/fx_mobile_text_color_accent
3 years ago
Arturo Mejia
277e94881b
For #22995 : Address crash when switching languages.
3 years ago
Aaron Train
8edd3f9fa1
No issue: Try out RetryTestRule in SmokeTest UI test class ( #22868 )
...
* Add RetryTestRule to SmokeTest UI tests
* fix: newline in RetryTestRule.kt
fix: switch off generic Throwable
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
mcarare
cdbe7983f5
For #22879 : Filter default engines when sending telemetry.
...
Filter out custom engines that are not well known search domains.
3 years ago
Gabriel Luong
8a5020123f
For #23017 - Ignore ExtraTranslation in our lint-baseline
3 years ago
Mozilla L10n Automation Bot
d9711497dc
Import l10n.
3 years ago
Mozilla L10n Automation Bot
9c10f7abb6
Import l10n.
3 years ago
Mozilla L10n Automation Bot
c91be63240
Import l10n.
3 years ago
Mozilla L10n Automation Bot
4d0203c60c
Import l10n.
3 years ago
Mozilla L10n Automation Bot
e7d64d886e
Import l10n.
3 years ago
mike a
46b5dd2706
Closes #10737 : Searching a language/saved password displays a misplaced "x".
...
Setting max width for the search view in language settings and saved logins screens. Removed SyncAuthClosed event from LocaleSettingsFragment, an apparent copy-paste.
3 years ago
Mozilla L10n Automation Bot
acc21f9f7f
Import l10n.
3 years ago
Gabriel Luong
c8e2fd3847
For #22973 - Remove @color/contrast_text_light_theme redirection
3 years ago
Gabriel Luong
794823c5ec
For #22983 - Remove @color/destructive_button_text_color redirection
3 years ago
TasosB
05e6ba40b4
For #21483 - Remove light theme tinting of folder icon in the Bookmark view
3 years ago
TasosB
54ffe7db03
For #21483 - Use primaryText attribute for download icons fill color
3 years ago
Gabriel Luong
4078bf7863
For #22971 - Remove @color/above_dark_theme redirection
3 years ago
Mozilla L10n Automation Bot
716e1194a0
Import l10n.
3 years ago
Mozilla L10n Automation Bot
fa377bf0d6
Import l10n.
3 years ago
Mozilla L10n Automation Bot
ec9cf0338e
Import l10n.
3 years ago
rxu
2203ebf923
Pass distribution_id to Socorro crash report
3 years ago
Mozilla L10n Automation Bot
00d18125b2
Import l10n.
3 years ago
Gabriel Luong
c50073f7e4
For #22965 - Add Form On, Form Off, Indicator Active, Indicator Inactive color tokens
3 years ago
Gabriel Luong
3ffece2b87
For #22965 - Remove Control Active color token
3 years ago
Gabriel Luong
38c55dbbc0
For #22965 - Update description of Layer Accent color token
3 years ago
Gabriel Luong
a7e78a19d0
For #22965 - Update description of Text Inverted color token
3 years ago
Gabriel Luong
c9cb55cf3f
For #22965 - Remove Control Dark design color token
3 years ago
Gabriel Luong
945dde72e3
For #22965 - Rename Action Disabled to Form Disabled for the design color tokens
3 years ago
Gabriel Luong
97c42ca84e
For #22965 - Update Control to Form Surface design colors
3 years ago
Gabriel Luong
5bea4554ad
For #22965 - Add Form Selected design color token
3 years ago
Gabriel Luong
c9bc38d67c
For #22965 - Update Action Teritary to Form Default design colors
3 years ago
Gabriel Luong
1cf91a2ef4
For #22965 - Change Pill button to Chip for Action Secondary design color token description
3 years ago
Gabriel Luong
16bf150fb9
For #22965 - Remove Toolbar background from the description of Layer 3 design color token
3 years ago
Roger Yang
0b0f69ab4e
Closes #22754 : Customize home button should work on fresh install
3 years ago
Arturo Mejia
27def6fd0c
For #22851 : Optimize wallpaper testing images.
3 years ago
Roger Yang
b9b2bc3c7d
Issue #22561 : Fix tab group titles colour when in private mode
3 years ago
mcarare
03f1aa3d8b
For #22415 : Remove element type from content descriptions.
...
Adding the type to content description is not advised according to a11y guidelines.
3 years ago
Gabriel Luong
dc576a2ad7
Revert "For #22777 - Replace about_link_normal_theme with fx_mobile_text_color_action"
...
This reverts commit 986a48b1db
.
3 years ago
mavduevskiy
89f5e96d73
For #18160 : Show a prompt when trying to leave private browsing with active downloads ( #22912 )
...
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
Mozilla L10n Automation Bot
105a2e5fc6
Import l10n.
3 years ago
Grisha Kruglov
5bbfd49e1d
Refactor History types to eliminate nullability
...
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.
With this refactor, we entirely eliminate nullability from these types.
3 years ago
Grisha Kruglov
836ff1151b
Closes #22764 : Convert History.id to an Int position
...
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.
This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
Mugurell
34c0a17b4d
For #22852 - Add a new "Storage access" permission
3 years ago
Arturo Mejia
cf31bc408a
For #22931 Only enable wallpapers on normal mode
3 years ago
mcarare
00280d3b65
For #20513 : Use UrlMetricType for search engine submission url.
3 years ago
Roger Yang
22bcdeafe0
Closes #22736 : Do not remove focus from toolbar when scrolling
3 years ago
Arturo Mejia
7a44412619
For #22851 toggle wallpapers when tap on the Firefox logo
3 years ago
rxu
073fd89390
Add default topsite MeiTuan for MozillaOnline builds
3 years ago
Mozilla L10n Automation Bot
ee34b07ecc
Import l10n.
3 years ago
Mozilla L10n Automation Bot
606f2eb100
Import l10n.
3 years ago
Mozilla L10n Automation Bot
dd64d92b12
Import l10n.
3 years ago
Matt Tighe
db71d8dfe7
fixes #22889 : add bottom spacer to onboarding adapter
3 years ago
Mugurell
eb2ec677ca
For #22508 - Increase menu height to avoid it become scrollable
...
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
3 years ago
Roger Yang
26198330e9
Closes #22671 : Show correct time groups header in history
3 years ago
mcarare
bbf0ccca54
For #22450 : Replace quit icon with AC one.
3 years ago
Mozilla L10n Automation Bot
1c34db22f4
Import l10n.
3 years ago
Grisha Kruglov
33af7d8729
Fix breaking change in KeyProvider
...
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
3 years ago
Grisha Kruglov
8de4c0b4db
For #22569 : Remove allopen plugin and Mockable annotations
3 years ago
rxu
b41542dc5e
Modify strings for Privacy notice for MozillaOnline builds
3 years ago
Mozilla L10n Automation Bot
b96dda5c89
Import l10n.
3 years ago
Gabriel Luong
9e647fd821
For #22858 - Set all @color/tab_tray_item_media_stroke usages to @color/photonWhite
3 years ago
Matt Tighe
edcccc2f4c
fixes #20833 : move home recycler bottom margin into standalone item
3 years ago
Gabriel Luong
59a17894f2
For #22842 - Use gradient color tokens for Reader mode gradient
3 years ago
Gabriel Luong
2c22622edb
For #22836 - Replace primary_text_private_theme with fx_mobile_private_text_color_primary color token
3 years ago
Noah Bond
8ca1a7e271
For #22832 - Added parameters to base Text composables
3 years ago
Arturo Mejia
0ac2899570
For #22851 add wallpapers feature flag
3 years ago
Gabriel Luong
cd83cfdda7
For #22839 - Remove unused tabTrayHeadingIcon and tabTrayHeadingIconInactive attributes
3 years ago
Gabriel Luong
07828aa979
For #22839 - Remove @color/tab_tray_heading_icon_inactive_dark_theme redirection
3 years ago
Gabriel Luong
d45c092f11
For #22839 - Remove @color/tab_tray_heading_icon_dark_theme redirection
3 years ago
Mozilla L10n Automation Bot
6669363ed9
Import l10n.
3 years ago
Gabriel Luong
b8bc14c0ff
For #22808 - Add private theme design tokens
3 years ago
Gabriel Luong
da0cb197ac
For #22809 - Use the design tokens for the Scrim Start/End colors
3 years ago
Gabriel Luong
d457050da2
For #22812 - Remove unused shadow attribute
3 years ago
Gabriel Luong
9dd3f58241
For #22800 - Remove unused tabTrayToolbarBackground attribute
3 years ago
Gabriel Luong
8fee873d40
For #22800 - Remove unused tabTrayItemSelectedBackground attribute
3 years ago
Gabriel Luong
0a9590cb23
For #22800 - Remove unused tabTrayItemBackground attribute
3 years ago
Mozilla L10n Automation Bot
f7d0c2831a
Import l10n.
3 years ago
Mozilla L10n Automation Bot
6cfe332e18
Import l10n.
3 years ago
Gabriel Luong
41fd47fc06
For #22793 - Update the colors for Scrim Start/End design tokens
3 years ago
Gabriel Luong
35454ec674
For #22793 - Swap the colors for Gradient Start/End design tokens
3 years ago
Gabriel Luong
29fc9c4ea5
For #22793 - Add Icon Gradient Start/End color tokens
3 years ago
Gabriel Luong
543f2000af
For #22793 - Rename fx_mobile_icon_color_notice color token to fx_mobile_icon_color_information
3 years ago
Matt Tighe
fee26e62a8
Fixes #22688 : remove inactive_tabs_recently_closed probe
3 years ago
Gabriel Luong
986a48b1db
For #22777 - Replace about_link_normal_theme with fx_mobile_text_color_action
3 years ago
Gabriel Luong
d6091c9ea4
For #22779 - Remove @color/inset_light_theme redirection
3 years ago
mcarare
b4bf7abfb3
For #22784 : Show collection snackbar only if fragment is still attached.
3 years ago
mcarare
0cb4059b12
For #17130 : Replace hardcoded strings with string resources.
3 years ago
Mozilla L10n Automation Bot
3058f52578
Import l10n.
3 years ago
aime Soriano Pastor
9bfc94b793
For #9294 : Add option to clear current site data in quick settings dialog.
3 years ago
Gabriel Luong
e150f6118b
For #22694 - Remove primary_text_dark_theme usage
3 years ago
MickeyMoz
07d43971c0
Update Android Components version to 97.0.20211208143435.
3 years ago
Mozilla L10n Automation Bot
c3cf4ae9e0
Import l10n.
3 years ago
Jonathan Almeida
01ba8959ce
Issue #22757 : Check the parent cast to AbstractBrowserTrayList first
...
We re-use the same ViewHolders in search term groups, so when we need to
cast to a AbstractBrowserTrayList for tab reordering, we need to check
our parent correctly first.
3 years ago
Christian Sadilek
6637f61088
Support tab movement/reordering ( #22751 )
...
* Adds basic support for tab reordering via drag-and-drop selected tabs
* ktlint/detekt formatting
* Use defaultTabsFilter (now not private) instead of getter
* Convert from position+filter API to target+placeAfter
Unfortunately I still need the filter passed around a bit
* Handle inactive tabs' holder being children of the RecyclerView of the normal tabs
Don't go through LayoutManager needlessly
* Non-working use tabID the whole way. Does not compile.
* Fix to do direct tab ID and use grid setting directly
* Remove non-null assertion. Now fully works for "other" tabs.
* Prevent grouped tabs from being dragged
* Remove unused import
* Add/fix comments
* Do API version check and use deprecated startDrag if too old.
* Build process fails: both outdated and too new, so reverting to just too new
* Use deprecated function and suppress warning
* fix space
* Suppress "TooManyFunctions" on DefaultTabsTrayController
* Repeatedly update tab movement during drag
* Remove multi-tab movement, only allow dragging if tab groups disabled, fix tab positioning during movement
I'm forced to suppress LongParameterList to get the settings information where it needs to go though
* Remove settings argument and corresponding long args suppression: instead get settings from parent AbstractBrowserTrayList's context
* New UI: Select a tab and then, while holding down, start dragging
* Revert to using before/after boolean to accomodate delays
Move drag transparency to start of drag
* Use new BlankDragShadowBuilder and DraggableItemAnimator to handle tab movement
* Replace Pair<>s with data classes
* Only drag if exactly 1 tab selected, don't consume drag event if not used
* Auto-scroll tab tray while dragging near top/bottom edge
* Remove unexpected scrolling on tab bind (triggered when tab is selected)
* Fix broken scroll behavior during dragging
* Cleanup for ktlint/detekt
* Constantly set elevation during drag in case of update
Clean code at drag start
* Add custom drag start behavior
* Add drag distance constant, do all touch-drag behavior in OnTouchListener
* Disable parent vertical scrolling on drag start, fix detekt ComplexCondition
* Minor cleanup/comments
* Revert removal of scroll on bind, this was related to something different
* Correction to prepareForDrop to match documentation- doesn't seem to have any effect
* Simplify via unchecked typecast, use ViewCompat
* Use ViewConfiguration.scaledTouchSlop instead of arbitrary 30px
* Added tabReorderingFeature flag, split drag interactor to separate function to satisfy complexity requirement
Co-authored-by: Steven Knipe <ssk97@case.edu>
Co-authored-by: ssk97 <knipesteven@gmail.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
Christian Sadilek
f919e97445
Closes #21759 : Do not render home fragment when launching to tab
...
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
Mozilla L10n Automation Bot
910a425cc3
Import l10n.
3 years ago
Gabriel Luong
378f19eb59
For #22741 - Remove all unused strings marked moz:removedIn <= 94
3 years ago
Christian Sadilek
229c410437
Introduce timeout for capturing thumbnail in BrowserAnimator
3 years ago
Christian Sadilek
ae0dba29b1
Prevent flash when navigating to home
3 years ago
Christian Sadilek
28222df29c
Fix BrowserRobot.goToHomescreen to wait for home screen to be rendered
...
It was previously just waiting for the application to be idle, which
is not a reliable check in case the navigation to home is triggered
on completion of an async operation i.e., the app / main thread may
be idle, but the navigation to home hasn't completed yet.
goToHomeScreen further needs to wait for the browser fragment's
home button to exist before clicking it.
3 years ago
Mugurell
604f188970
For #22445 - Improve the scrolling behavior for Recently visited
...
One important issue was that the items are smaller that the width of the
screen and so a bit of the next column would be showing also and user could
interact with this only peaking items and a long press would open a dropdown
menu with no place to anchor it.
To mitigate this:
- the items will now snap to the next position when scrolling so that we'll
always show at least one column in it's entirety.
- menus are enabled only if more than half of the item is visible effectively
disabling clicks on that peaking area of neighbour columns.
This patch also updates the divider for history groups which previously wasn't
showing.
3 years ago
Gabriel Luong
67fb033f1b
For #22729 - Tag unused strings for removal
3 years ago
Andrei Joltan
ee9eab0d8c
[UI Smoke Tests] New undoDeleteBookmarkFolderTest UI test and Improve coverage for deleteNonEmptyBookmarkFolderTest UI test ( #22587 )
...
* New undoDeleteBookmarkFolderTest smoke UI test
* Improve coverage for deleteNonEmptyBookmarkFolderTest UI smoke test
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot
e6d1c9a564
Import l10n.
3 years ago
Gabriel Luong
6a28296be7
For #22702 - Replace home_show_all_button_text with fx_mobile_text_color_action color token
3 years ago
Gabriel Luong
bf96e2ae60
For #22725 - Regenerate lint-baselint.xml
3 years ago
Gabriel Luong
596072729d
For #22701 - Replace whats_new_notification_color with fx_mobile_icon_color_notice color token
3 years ago
Gabriel Luong
a4894256f9
For #22712 - Remove unused menuCategoryText attribute
3 years ago
Gabriel Luong
81c42ca7ee
For #22696 - Remove unused tab_header.xml resource
3 years ago
Gabriel Luong
83fdf78da1
For #22708 - Remove unused syncedTabsSeparator attribute
3 years ago
Sarah Khan
e18cf36117
For #22495 - Disable inactive tabs survey
3 years ago
Gabriel Luong
2c5cfb2447
For #22698 - Remove unused mozac_browser_menu_item_switch.xml resource
3 years ago
Mozilla L10n Automation Bot
c27714a314
Import l10n.
3 years ago
Mozilla L10n Automation Bot
2a5a2d7b6e
Import l10n.
3 years ago
Mozilla L10n Automation Bot
1d5f7db7c7
Import l10n.
3 years ago
Noah Bond
73cfd0b145
For #22691 - Add Composables for Primary and Secondary text
3 years ago
Gabriel Luong
0078d7fe01
For #22676 - Replace top_site_title_text with fx_mobile_text_color_primary color token
3 years ago
Oana Horvath
b1dab8170c
For #21002 : Add testETPOffGlobally UI smoke test
3 years ago
Gabriel Luong
4fe3d6db02
For #22654 - Add new color tokens provided by the design systems to colors.xml
3 years ago
Gabriel Luong
e20ef25bd1
For #22637 - Add new color tokens provided by the mobile styles to FirefoxTheme
3 years ago
Mozilla L10n Automation Bot
caea82864d
Import l10n.
3 years ago
Noah Bond
31e86842dd
For #22516 - Fixed alignment of "Show all" buttons on the homescreen ( #22650 )
...
* For #22516 - Fixed show all button alignment with section headers on the Homepage
* For #22516 - Added correct content description back in for recently visited show all button
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek
26713a58c8
Refactor: Move historymetadata classes in separate package
3 years ago
AndiAJ
cb48ff7882
Refactor recently closed tabs UI smoke tests
3 years ago
AndiAJ
f6caf507fd
Move verifyRecentlyClosedTabsListTest UI test from SmokeTest class
3 years ago
AndiAJ
0ac7bc80ab
Disable failing verifyUndoSnackBarTest UI test
3 years ago
Sebastian Kaspari
b04eeccf14
Android Autofill: Enable keyboard inline autofill suggestions
3 years ago
Roger Yang
3d33a9422c
Close #20701 : Dismiss keyboard when scrolling home screen
3 years ago
Mozilla L10n Automation Bot
9fa9ae3375
Import l10n.
3 years ago
rxu
4d9a58c156
Add distribution_id into first session ping
3 years ago
Mozilla L10n Automation Bot
514f41fe67
Import l10n.
3 years ago
Gabriel Luong
3c82a34aa1
For #22592 - Refactor hideOnboardingIfNeeded() calls when the home menu items are tapped
3 years ago
Mugurell
5c3fedd707
For #22534 - Show history highlights and groups in "Recently visited" ( #22535 )
...
* For #22534 - Update homescreen section name to "Recently visited"
* For #22534 - Show both history highlights and groups in Recently visited
For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.
Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.
A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.
* For #22534 - Rename and refactor historymetadata to recentvisits
The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home
* For #22534 - Update UI tests to account for the new items space on the screen
Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.
Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond
de1c6b0dae
Tab group count telemetry ( #22479 )
...
* For #22410 - Refactored tab sorter metrics into a middleware
* For #22410 - Created distribution metric for tab group sizes
* For #22410 - Created tests for tabs tray middleware
* For #22410 - Merge fixes
* For #22410 - Added PR number to metric
* For #22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.
* For #22410 - Added missing line to middleware to have the Store process actions
* For #22410 - Updated metric expiration to December
* For #22410 - PR Feedback
* For #22410 - Removed else from middleware when
3 years ago
Mozilla L10n Automation Bot
6003e16076
Import l10n.
3 years ago
Mozilla L10n Automation Bot
cfac710754
Import l10n.
3 years ago
Gabriel Luong
7c2d9bd8a8
For #22595 - Remove unused OnboardingAutomaticSignInViewHolder
3 years ago
Sebastian Kaspari
1bcf37ba7c
Closes #22552 : Optimize PNGs with ImageOptim
3 years ago
Gabriel Luong
91da5318e3
For #22211 - Use Hero images for Recent Bookmarks
3 years ago
Arturo Mejia
a49f80d5e8
Update Android Components version to 96.0.20211125162700.
3 years ago
Arturo Mejia
3f86a5d6f9
Improve loading URLs
3 years ago
Sebastian Kaspari
a6d5d21e0b
Issue #22580 : Track APK size in perfherder
3 years ago
Sebastian Kaspari
e341109ced
Issue #12731 : Disable suspending of engine sessions under memory pressure in Nightly
3 years ago
Mugurell
548efefcbb
For #22442 - Don't display individual tab if part of the Jump back in tabs group
...
We'll show as a recent tab the next most recent tab not part of the last active
search group.
3 years ago
Mugurell
685da115c9
For #22442 - Don't display history group if already in Jump back in
3 years ago
AndiAJ
45f1666c6f
New text search UI smoke tests
3 years ago
Mugurell
779f4fc704
For #22502 - Keep the previous string resource until safe to remove
...
See https://github.com/mozilla-mobile/fenix/issues/20871
3 years ago
Matt Tighe
5003c14e7e
Closes #22321 : Add temporary protoc version workaround for M1 Macbooks
3 years ago
Gabriel Luong
dc15ee2415
For #22488 - Fix intermittent test failure with InactiveTabsControllerTest
3 years ago
Gabriel Luong
749da13516
For #22250 - Convert Recent Bookmarks to Jetpack Compose
3 years ago
AndiAJ
c9303f44b4
Improve expand/collapse collection UI test coverage
3 years ago
AndiAJ
5934c7d6b2
Improve collection deletion UI coverage
3 years ago
Grisha Kruglov
413ff7cd85
Closes #22499 : Emit search group disband action on history group removal
...
This is needed to prevent removed search groups from coming back after
user interacts with the tab. E.g. if we don't fire this action, upon
interaction with the tab after a corresponding search group was removed
we will end up creating metadat with the deleted 'searchTerms' (they'll
be read from the 'historyMetadata' state on the tab).
At this point we probably want to start encapsulating all of this in a
use case - let's do that separately in
https://github.com/mozilla-mobile/android-components/issues/11309 , and
just fix the bug for now.
3 years ago
Oana Horvath
aff3e4b9dd
For #21002 : improves the share tabs smoke tests coverage
3 years ago
Mozilla L10n Automation Bot
de30610aa6
Import l10n.
3 years ago
Arturo Mejia
7b7ef2e661
For issue #22537 crash: BookmarkFragment is attached to a context
3 years ago
Arturo Mejia
74406bef59
For issue #5298 the same page appears in the History section multiple times
3 years ago
Mugurell
888bbc770e
For #22502 - Update "Jump back in" group's subtitle format
3 years ago
Mozilla L10n Automation Bot
396c51d569
Import l10n.
3 years ago
Mozilla L10n Automation Bot
708b78d3a0
Import l10n.
3 years ago
AndiAJ
378ac03e30
Improve privateTabsTrayWithOpenedTabTest UI test coverage
3 years ago
AndiAJ
ec31faef7a
Improve verifyOpenTabDetails UI test coverage
3 years ago
AndiAJ
4261ca7ea6
Refactor and improve coverage for empty tabs tray UI tests
3 years ago
Mozilla L10n Automation Bot
f0a3653d7b
Import l10n.
3 years ago
Grisha Kruglov
63154a18f9
Closes #22484 - Track direct loads per tab; fix search term lookup
...
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
uniformally to all tabs, even though it's actually an event which
happens for a specific tab. This lead to background tabs (pages opened as new tab)
setting the direct load flag, and then a simultaneously loading
parent tab would incorrectly interpret that flag for itself.
The patch switches this tracking from a simple boolean (are we direct
loading?) to a set of tab IDs that are currently direct loading.
2) In a case when a background tab was loading with a parent who's
search terms were cleared by a direct load, we were not trying to
lookup search terms on the background tab's historyMetadata key,
which exists to capture search terms for this exact scenario.
The patch adds an additional fallback lookup for that path.
3 years ago
Oana Horvath
4892f0ddbe
For #21002 : add missing steps to selectSearchEnginesShortcutTest, addPredefinedSearchEngineTest
3 years ago
Grisha Kruglov
77672dfa15
Post: move group removal logic into PagedHistoryProvider
...
This moves the group removal logic to the place where the groups are
actually formed. This helps clean-up the fragment code a bit, and
removes the awkward 'allow mutate some random internal state' API from
the provider.
3 years ago
Grisha Kruglov
45d4807bfe
Closes #22472 : Filter out redirects from History search groups
3 years ago
AndiAJ
2c9efac286
Improve mainMenuAddToHomeScreenTest UI test coverage
3 years ago
AndiAJ
e265da0cb4
startOnLastTab UI smoke test
3 years ago
AndiAJ
4ff64ad7ca
recentBookmarksOption UI smoke test
3 years ago
AndiAJ
eee83c9cbd
jumpBackInOption UI smoke test
3 years ago
AndiAJ
7460461e16
startOnHomepageTest refactoring work
3 years ago
Mozilla L10n Automation Bot
364fecf9d4
Import l10n.
3 years ago
Christian Sadilek
8c88561d4b
Update lastAccess timestamp of selected tab when launching to home
3 years ago
Roger Yang
24e4452cb5
Close #22402 : Add top placeholder for home
3 years ago
Noah Bond
dde916038d
MR2 Telemetry: Homescreen view count ( #22377 )
...
* For #22146 - Added counter for home screen views
* For #22146 - Added PR number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell
d4a6facd81
For #22155 - Store inactive tabs count telemetry when user opens tabs tray
...
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
Mugurell
17865bdf66
For #22147 - New search term groups telemetry
3 years ago
AndiAJ
f91285881d
Improve homeThreeDotMenuItemsTest UI test coverage
3 years ago
Mozilla L10n Automation Bot
f466d65256
Import l10n.
3 years ago
Arturo Mejia
94a543a403
For #22271 Improve URL accessing from the clipboard for Android 12 and above.
3 years ago
Mugurell
c42ccb4966
For #22388 - Update content description of the delete button
3 years ago
Mozilla L10n Automation Bot
abcafa55f0
Import l10n.
3 years ago
Mozilla L10n Automation Bot
d29fd55c8b
Import l10n.
3 years ago
Oana Horvath
ba91180e85
No issue: creates new SmokeTest annotation.
...
Updates smoke tests list according to the ones in TestRail.
3 years ago
Mozilla L10n Automation Bot
b0ad98a204
Import l10n.
3 years ago
Noah Bond
811f255b71
MR2 Telemetry: Opening screen preference ( #22333 )
...
* For #22145 - Added telemetry to the opening screen preference.
* For #22145 - Added PR number to metric
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond
2e5555d034
MR2 telemetry - Inactive tabs CFR ( #22301 )
...
* For #22298 - Added telemetry to inactive tabs CFR
* For #22298 - added PR issue number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Jonathan Almeida
e3b6e00331
Close #22223 : Move to the selected page when switching modes
3 years ago
Mozilla L10n Automation Bot
210587b735
Import l10n.
3 years ago
Grisha Kruglov
9a4a4713ac
No issue: clean up code duplication in PagedHistoryProvider
3 years ago
AndiAJ
1ade096145
For #22256 re-enable editCustomSearchEngineTest UI test
3 years ago
Ben Dean-Kawamura
df953b0021
Make findDuplicate() suspend
...
findLoginToUpdate() should be suspend, but I didn't get mark it that way
on the initial logins work. Let's make this one suspend, then I can
update findLoginToUpdate() in a-c.
3 years ago
Mozilla L10n Automation Bot
e52000bb20
Import l10n.
3 years ago
Jonathan Almeida
8ced675817
No issue: Correct TabsTrayAction naming
3 years ago
Jonathan Almeida
08b15689b1
Close #22305 : Use TabsTrayStore for populating adapters
3 years ago
Jonathan Almeida
f16300392d
Close #22305 : Add tab state into the TabsTrayStore
3 years ago
Michael Comella
c026d8b28a
For #21084 : put git hash on About screen in release builds.
3 years ago
AndiAJ
f4e7547190
Improve verifyEmptyTabTray Ui test coverage
3 years ago
Mugurell
953f6feb17
For #22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
Mugurell
f9b67091c6
For #22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
Mozilla L10n Automation Bot
2089c29fea
Import l10n.
3 years ago
Grisha Kruglov
81b70122d4
No issue: rename test resource file that was causing issues on Windows
3 years ago
Mozilla L10n Automation Bot
8c2cdaa3ff
Import l10n.
3 years ago
Mozilla L10n Automation Bot
06f57fdcfe
Import l10n.
3 years ago
mike a
d69b5ed456
For #21816 : Filename in "Open" PDF dialog overflows screen
...
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
3 years ago
Grisha Kruglov
5b889fdb96
For #22342 : Make layout constraint for 'recent bookmarks' the same as other sections
3 years ago
Sebastian Kaspari
8c9f0c835a
Closes #21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
Mozilla L10n Automation Bot
7e66c02363
Import l10n.
3 years ago
Roger Yang
04618983aa
Close #22299 : Add history search term group telemetry
3 years ago
Grisha Kruglov
294997e559
No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
Oana Horvath
4d88c521ac
For #22304 & #22256 : Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests
3 years ago
Mozilla L10n Automation Bot
ed0389abe3
Import l10n.
3 years ago
Michael Comella
7d67b84a92
For #22177 : add SearchDialogFragmentConstraintLayout; has markers.
...
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
3 years ago
Michael Comella
bc6d8be9c1
For #22177 : change onMeasure/onLayout markers into a single track + draw.
...
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
3 years ago
Michael Comella
ed8f2c0bc3
For #22177 : rename RootLinearLayout -> HomeActivityRoot...
...
This is so we can be more specific with the detail text in our markers.
3 years ago
Elise Richards
6296ed939f
For #21313 : Renew product telemetry expiring in December ( #21316 )
...
* For #21313 : Product telemetry renewals for December
* For #21313 : Data review for december product telemetry renewals
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Elise Richards
4f55f16bd7
For #21313 : Remove expiring/unused metrics for December ( #21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek
76bb0c3b37
Closes #21659 : Add SERPs to history search groups
3 years ago
Noah Bond
8caefbe2d5
Recent bookmark count telemetry ( #22293 )
...
* For #22075 - Added event to track the count of recent bookmarks
* For #22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
cff78afe27
For #22078 Selecting search group in Jump back in switches active tab
3 years ago
Matt Boris
1809bea49d
For #22281 Fix studies opt out learn more link
3 years ago
Gabriel Luong
6747e9d554
For #21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection
3 years ago
Gabriel Luong
baa8c6582a
For #21973 - Remove @color/accent_dark_theme redirection
3 years ago
Gabriel Luong
6770a70bdd
For #21973 - Remove @color/foundation_dark_theme redirection
3 years ago
Gabriel Luong
f7f942f2d9
For #21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection
3 years ago
Gabriel Luong
d6002f3307
For #21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection
3 years ago
Gabriel Luong
b7c3d0ec5a
For #21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection
3 years ago
Gabriel Luong
e304885581
For #21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection
3 years ago
Gabriel Luong
8d9550a6a7
For #21973 - Remove @color/tab_tray_item_media_background_dark_them redirection
3 years ago
Gabriel Luong
2b996a607c
For #21973 - Remove @color/tab_tray_item_divider_dark_theme redirection
3 years ago
Gabriel Luong
19a947240b
For #21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection
3 years ago
Gabriel Luong
3fd6f4c420
For #21973 - Remove @color/tab_tray_item_background_dark_theme redirection
3 years ago
Gabriel Luong
ee59848064
For #21973 - Remove @color/tab_tray_item_url_dark_theme redirection
3 years ago
Gabriel Luong
498d8ccc19
For #21973 - Remove @color/tab_tray_item_text_dark_theme redirection
3 years ago
Michael Comella
0c079fde91
Closes #22213 : add marker for LayoutInflater.inflate.
...
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
3 years ago
Arturo Mejia
5a11985d22
No issue: Address tracking protection exceptions breaking changes
3 years ago
AndiAJ
1066acbe1e
Improve deleteBookmarkInEditModeTest UI test coverage
3 years ago
Mozilla L10n Automation Bot
3f7cd1be8c
Import l10n.
3 years ago
Arturo Mejia
2061779938
For #22170 record auto-close prompt telemetry events
3 years ago
Roger Yang
930599407c
No issue: Show snackbar when opening non-http URL
3 years ago
Noah Bond
a06b04ec6d
MR2 Telemetry: Recent tabs section probe ( #22166 )
...
* For #22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For #22107 - Fixed lint errors
* For #22107 - added data review number to metric
* For #22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong
9a53a12c57
For #21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection
3 years ago
Gabriel Luong
e586d27983
For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection
3 years ago
Gabriel Luong
5c32efa9a3
For #21973 - Remove @color/preference_section_header_dark_theme redirection
3 years ago
Gabriel Luong
0cb91151b1
For #21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection
3 years ago
Gabriel Luong
f436d3ef02
For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection
3 years ago
Gabriel Luong
90fd1ea363
For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection
3 years ago
Gabriel Luong
830ade29f9
For #21973 - Remove @color/sync_disconnected_background_dark_theme redirection
3 years ago
Gabriel Luong
eb6de2b21c
For #21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection
3 years ago
Gabriel Luong
c9afe46dd6
For #21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection
3 years ago
Gabriel Luong
6923a27be7
For #21973 - Remove @color/toolbar_divider_color_dark_theme redirection
3 years ago
Gabriel Luong
37058f596e
For #21973 - Remove @color/swipe_delete_background_dark_theme redirection
3 years ago
Gabriel Luong
3cf985d09c
For #21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection
3 years ago
Gabriel Luong
d71447a691
For #21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection
3 years ago
Gabriel Luong
075f3a3dd9
For #21973 - Remove @color/disabled_dark_theme redirection
3 years ago
Gabriel Luong
25592dc25c
For #21973 - Remove @color/shadow_dark_theme redirection
3 years ago
Gabriel Luong
35a235c598
For #21973 - Remove @color/neutral_faded_dark_theme redirection
3 years ago
Gabriel Luong
2f4e0e14ba
For #21973 - Remove @color/neutral_dark_theme redirection
3 years ago
Gabriel Luong
b682f2d5c5
For #21973 - Remove @color/tab_ring_dark_theme redirection
3 years ago
Gabriel Luong
7019e32f40
For #21973 - Remove @color/scrimEnd_dark_theme redirection
3 years ago
Gabriel Luong
ee96021f19
For #21973 - Remove @color/scrimStart_dark_theme redirection
3 years ago
Gabriel Luong
d516eefb1d
For #21973 - Remove @color/recently_used_share_menu_dark_theme redirection
3 years ago
Gabriel Luong
ec259fbfd7
For #21973 - Remove @color/tab_history_item_selected_background_light_theme redirection
3 years ago
Gabriel Luong
dff26e0ce1
For #21973 - Remove @color/menu_item_button_light_theme redirection
3 years ago
Gabriel Luong
e50a2b3cb3
For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection
3 years ago
Gabriel Luong
f5f96d8766
For #21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection
3 years ago
Gabriel Luong
679d7e5161
For #21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection
3 years ago
Jonathan Almeida
9bb49585ea
No issue: Merge our inactive tab interactor/controllers
3 years ago
Jonathan Almeida
f363b145f2
No issue: Remove unused InactiveTabState code
3 years ago
Mugurell
207e85e59d
For #22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
Roger Yang
a46905b5e7
Issue #22057 : Add search term groups telemetry
3 years ago
Christian Sadilek
687209fee8
Introduce test rule to work around intermittent mockk failures
3 years ago
AndiAJ
ff0befdd1d
Improve coverage for cancelCreateBookmarkFolderTest UI test
3 years ago
AndiAJ
979d8a79cd
For #18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests
3 years ago
Mugurell
018fe15072
For #22138 - Install source metrics probe
3 years ago
Mugurell
9cce30b824
For #22226 - Open grouped history entries the same as individual ones
3 years ago
Roger Yang
4e5c9a3440
Close #22172 : Add Recent searches telemetry
3 years ago
Roger Yang
9c970a5276
Close #22103 : Add recent bookmarks telemetry
3 years ago
Mozilla L10n Automation Bot
b698d6ac77
Import l10n.
3 years ago
Elise Richards
7480e806c7
For #22175 : Add data review link
3 years ago
Elise Richards
e4cc22fb71
For #22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
Jonathan Almeida
8c43ccc0f6
Issue #20704 : Use AppStore for inactive expanded state
3 years ago
Jonathan Almeida
9cef9357b1
Close #20704 : Add AppStore to Components
3 years ago
Oana Horvath
cee72a965b
For #21397 : disabled homescreen features to improve collections visibility
3 years ago
Arturo Mejia
940af156eb
For #22192 add telemetry for studies
3 years ago
Mozilla L10n Automation Bot
f3bf56ac60
Import l10n.
3 years ago
Mozilla L10n Automation Bot
ef43107e67
Import l10n.
3 years ago
Mozilla L10n Automation Bot
57c375cea2
Import l10n.
3 years ago
Gabriel Luong
e3e0b9c207
For #21973 - Reduce redirection of colors variables between dark and light theme - Part 3 ( #22220 )
...
* For #21973 - Remove @color/disabled_light_theme redirection
* For #21973 - Remove @color/scrimStart_light_theme redirection
* For #21973 - Remove @color/scrimEnd_light_theme reddirection
* For #21973 - Remove @color/synced_tabs_separator_light_theme redirection
* For #21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection
* For #21973 - Remove @color/toolbar_divider_color_light_theme redirection
* For #21973 - Remove @color/fill_link_from_clipboard_light_theme redirection
* For #21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection
* For #21973 - Remove @color/sync_disconnected_background_light_theme redirection
* For #21973 - Remove @color/swipe_delete_background_light_theme redirection
* For #21973 - Remove @color/onboarding_illustration_selected_light_theme redirection
* For #21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection
* For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection
* For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot
c2f0b574fd
Import l10n.
3 years ago
Oana Horvath
f6b83e37b1
For #15624 & #17484 : improves tab drawer locator & avoids homescreen refreshing
3 years ago
Gabriel Luong
a99b7d3f71
For #21973 - Remove @color/destructive_light_theme redirection
3 years ago
Gabriel Luong
1eb41ff558
For #21973 - Remove @color/shadow_light_theme redirection
3 years ago
Gabriel Luong
9331b971f8
For #21973 - Remove @color/neutral_faded_light_theme redirection
3 years ago
Gabriel Luong
58e9d3dd08
For #21973 - Remove @color/neutral_light_theme redirection
3 years ago
Gabriel Luong
7c9ae669aa
For #21973 - Remove @color/tab_ring_light_theme redirection
3 years ago
Gabriel Luong
00b4688fd5
For #21973 - Remove @color/accent_high_contrast_light_theme redirection
3 years ago
Gabriel Luong
cb92e48c0d
For #21973 - Remove @color/about_link_dark_theme redirection
3 years ago
Gabriel Luong
fe0affa167
For #21973 - Remove @color/above_light_theme redirection
3 years ago
Gabriel Luong
2336f9d9d6
For #21973 - Remove @color/caption_text_light_theme redirection
3 years ago
Gabriel Luong
b510a6d0ca
For #21973 - Remove @color/secondary_text_light_theme redirection
3 years ago
Christian Sadilek
3e6cd7d821
Closes #21355 : Fix intermittent test failures in BookmarkItemMenuTest
3 years ago
Christian Sadilek
75c70ff814
Closes #21952 : Ignore intermittently failing FenixSnackbarKtTest
3 years ago
Christian Sadilek
f4be38dafc
Closes #21438 : Ignore intermittently failing ExceptionsListItemViewHolderTest
3 years ago
Christian Sadilek
5d7bb70f55
Closes #22081 : Ignore intermittently failing DefaultBrowsingModeManagerTest
3 years ago
Christian Sadilek
99f0aaa834
Closes #21332 : Ignore intermittently failing WebPushEngineIntegrationTest
3 years ago
Christian Sadilek
3ffb11fd3b
Closes #21952 : Ignore intermittently failing FenixSnackbarDelegateTest
3 years ago
Gabriel Luong
09bd9e7ba2
For #21888 - Use Hero images for Jump back in
3 years ago
Arturo Mejia
d0d87a6d6d
No issue update strings ids
3 years ago
AndiAJ
71d151ef18
For #18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests
3 years ago
Gabriel Luong
8f85ef2d5b
For #21973 - Remove @color/top_site_title_text_light_theme redirection
3 years ago
Gabriel Luong
28883384a7
For #21973 - Remove @color/inset_dark_theme redirection
3 years ago
Gabriel Luong
9a85545da5
For #21973 - Remove @color/top_site_title_text_dark_theme redirection
3 years ago
Gabriel Luong
59f725d2fb
For #21973 - Remove @color/synced_tabs_separator_dark_theme redirection
3 years ago
Gabriel Luong
35c7ef6bb6
For #21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection
3 years ago
Gabriel Luong
e2093f2054
For #21973 - Remove redirection of color variables for the collection color variables
3 years ago
Gabriel Luong
4001f4ee6f
For #21973 - Remove redirection of color variables for the tabs tray color variables
3 years ago
Gabriel Luong
1a472c3507
For #21973 - Remove @color/caption_text_dark_theme redirection
3 years ago
Gabriel Luong
78e90d5f0e
For #21973 - Remove @color/contrast_text_dark_theme redirection
3 years ago
Gabriel Luong
2456e9b5f5
For #21973 - Remove @color/secondary_text_dark_theme redirection
3 years ago
Gabriel Luong
959a142c92
For #21973 - Use destructive_normal_theme in place of R.color.design_color
3 years ago
Mozilla L10n Automation Bot
b7bdd94e71
Import l10n.
3 years ago
Michael Comella
9721723af5
For android-components#11161: pass profiler into AwesomeBar.
...
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update
This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
AndiAJ
4fe8921a82
For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests
3 years ago
Arturo Mejia
a2c7dfb26e
For #22170 : Add telemetry for the auto-close prompt
3 years ago
Arturo Mejia
9154371ba5
For #21906 ⁃ Update strings removal version
3 years ago
Mozilla L10n Automation Bot
59a069882d
Import l10n.
3 years ago
Grisha Kruglov
04a35c81b8
Closes #22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards
347f82f2f5
For #21313 : Renew metrics for December - never expire updates ( #21788 )
...
* For #21313 : Renew metrics for December - never expire updates
* For #21313 : data review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
d943be0e53
For #22034 : Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
MickeyMoz
a4bcecf8c5
Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong
44666ca2ca
For #21776 - Call chain on collection type may be simplified
3 years ago
Gabriel Luong
100547130e
For #21776 - Add package path to TabGroupViewHolder
3 years ago
Gabriel Luong
b04bf99b7d
For #21776 - Remove unused symbols
3 years ago
Gabriel Luong
b54698a3f2
For #21776 - Class member can have 'private' visibility
3 years ago
Gabriel Luong
3115f1343f
For #21776 - Replace Java static method with Kotlin analog
3 years ago
Gabriel Luong
660300f770
For #21776 - Replace 'isEmpty' with 'ifEmpty'
3 years ago
Gabriel Luong
603ba63962
For #21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
Gabriel Luong
da395d1038
For #21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
Gabriel Luong
5afe393b8f
For #21776 - Remove unused imports
3 years ago
Gabriel Luong
76c746b982
For #21776 - Remove unnecessary type argument
3 years ago
Gabriel Luong
272d31b2b4
For #21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
Gabriel Luong
6d1d4bea93
For #21776 - Remove redundant qualifier name
3 years ago
Gabriel Luong
1039a92281
For #21776 - Remove reductant SAM constructor
3 years ago
Gabriel Luong
ed48dc934a
For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry
3 years ago
Gabriel Luong
d854c282da
For #21776 - Remove val from constructor parameter that are never used as a property
3 years ago
codrut.topliceanu
bba787e87e
For #21732 - Adds inactive tabs survey on disable + telemetry
3 years ago
Mugurell
6d62aed35f
For #21933 - Refresh history items everytime the fragment is opened
3 years ago
Mozilla L10n Automation Bot
c9e769544f
Import l10n.
3 years ago
Jonathan Almeida
7666f0e4c2
No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida
b2a7877c83
No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
Michael Droettboom
c1780cf332
For #21025 : Set long term business-critical metrics as non-expiring ( #21038 )
...
* Set long term business-critical metrics as non-expiring.
* Remove quotes around "never"
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
AndiAJ
6149f9faf8
Use identifiers instead of hard coded strings
3 years ago
AndiAJ
d3651eb0fc
For #21747 re-enable start on homepage UI test and refactoring work
3 years ago
AndiAJ
b10835992d
For #21754 re-enable general settings UI test and refactoring work
3 years ago
AndiAJ
4c343b8b3a
For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
Roger Yang
367c5f42d8
No issue: Add external load flag
3 years ago
Sebastian Kaspari
170fa9705e
Update Kotlin and Jetpack Compose versions.
3 years ago
Oana Horvath
52facc9723
For #21628 : catch ComposeNotIdleException
3 years ago
Arturo Mejia
ee8c4de62d
For #21986 Confirmation when people set tabs to auto-close
...
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
Mayank Agarwal
1a7b486808
Issue #21714 : Login button visibility fix on saved logins page
3 years ago
Mugurell
e0bf4f31fa
For #21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
Mozilla L10n Automation Bot
df2652f9b5
Import l10n.
3 years ago
Mozilla L10n Automation Bot
a8f42cd363
Import l10n.
3 years ago
Mozilla L10n Automation Bot
9e1f596c1e
Import l10n.
3 years ago
Michael Comella
ec1a25dfcf
For #21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
Michael Comella
788eb2c5de
For #21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
Michael Comella
3a3c39406a
For #21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
Michael Comella
f65ea1e972
For #21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
Michael Comella
99533626f1
For #21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
Michael Comella
623914bd89
For #22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Oana Horvath
1234d8f518
For #22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
Mugurell
acdde511d3
For #22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang
70fc6fc20f
Close #22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
Mozilla L10n Automation Bot
2d8492d33f
Import l10n.
3 years ago