Closes #10737: Searching a language/saved password displays a misplaced "x".

Setting max width for the search view in language settings and saved logins screens. Removed SyncAuthClosed event from LocaleSettingsFragment, an apparent copy-paste.
upstream-sync
mike a 2 years ago committed by mergify[bot]
parent acc21f9f7f
commit 46b5dd2706

@ -18,10 +18,8 @@ import mozilla.components.support.ktx.android.view.hideKeyboard
import mozilla.components.support.locale.LocaleUseCases
import org.mozilla.fenix.R
import org.mozilla.fenix.components.StoreProvider
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.databinding.FragmentLocaleSettingsBinding
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.requireComponents
import org.mozilla.fenix.ext.showToolbar
class LocaleSettingsFragment : Fragment() {
@ -71,6 +69,7 @@ class LocaleSettingsFragment : Fragment() {
val searchView: SearchView = searchItem.actionView as SearchView
searchView.imeOptions = EditorInfo.IME_ACTION_DONE
searchView.queryHint = getString(R.string.locale_search_hint)
searchView.maxWidth = Int.MAX_VALUE
searchView.setOnQueryTextListener(object : SearchView.OnQueryTextListener {
override fun onQueryTextSubmit(query: String): Boolean {
@ -107,9 +106,4 @@ class LocaleSettingsFragment : Fragment() {
_binding = null
}
override fun onDestroy() {
super.onDestroy()
requireComponents.analytics.metrics.track(Event.SyncAuthClosed)
}
}

@ -120,6 +120,7 @@ class SavedLoginsFragment : Fragment() {
val searchView: SearchView = searchItem.actionView as SearchView
searchView.imeOptions = EditorInfo.IME_ACTION_DONE
searchView.queryHint = getString(R.string.preferences_passwords_saved_logins_search)
searchView.maxWidth = Int.MAX_VALUE
searchView.setOnQueryTextListener(object : SearchView.OnQueryTextListener {
override fun onQueryTextSubmit(query: String?): Boolean {

Loading…
Cancel
Save