Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
4,005 Commits 67 Branches 115 Tags 1.2 GiB
a6dc24bd4e
Commit Graph

3436 Commits

Author SHA1 Message Date
Arturo Mejia
27ebaa4851 [fenix] No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek
a2077558a4 [fenix] No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek
c20dbf04b7 [fenix] No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
kglazko
70b21d2e6c [fenix] No Issue Reenable testDownloadPrompt (https://github.com/mozilla-mobile/fenix/pull/10407) 
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
 2020-05-05 11:24:16 -07:00
Mihai Adrian
404e6baa72 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9794: Announce installing state for screen readers (https://github.com/mozilla-mobile/fenix/pull/10111) 2020-05-05 11:22:15 -07:00
David Walsh
168ce3b74e [fenix] For https://github.com/mozilla-mobile/fenix/issues/10395 - Improve alignment of close buttons with menu in tab tray (https://github.com/mozilla-mobile/fenix/pull/10405) 2020-05-05 11:16:47 -07:00
David Walsh
28d166b8ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/10159 - Tab tray bottom toolbar colors (https://github.com/mozilla-mobile/fenix/pull/10326) 2020-05-05 11:16:09 -07:00
Mihai Adrian
1ca5625edd [fenix] For https://github.com/mozilla-mobile/fenix/issues/10408: Dismiss menu when navigating away. (https://github.com/mozilla-mobile/fenix/pull/10415) 
The menu is dismissed when toolbar view is detached from window.
 2020-05-05 11:15:30 -07:00
Mozilla L10n Automation Bot
3a123090dd [fenix] Import l10n. 2020-05-05 09:11:03 +03:00
David Walsh
15c347c4e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (https://github.com/mozilla-mobile/fenix/pull/10399) 2020-05-04 22:51:07 -04:00
Michael Comella
54cd10af4d [fenix] No issue: losslessly compress image assets. 
Using ImageOptim. Results: 110 KB out of 1.9 MB (5.7%).
 2020-05-04 14:54:46 -07:00
Jeff Boek
de3cd203e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10395 - Fixes tab tray bar dimensions to better align with the browser toolbar (https://github.com/mozilla-mobile/fenix/pull/10400) 2020-05-04 12:44:37 -05:00
Alessio Placitelli
6e36269af0 [fenix] Fixup the BaselinePingTest 2020-05-04 10:37:44 +03:00
Mozilla L10n Automation Bot
9d9bdb625c [fenix] Import l10n. 2020-05-04 10:31:35 +03:00
Mugurell
b3f769b407 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10322 - Update Glean - total_uri_count documentation 
total_uri_count continues to accurately track the URLs visited by the user in
the current session.
Websites can though programmatically redirect users to a new URL using simple
javascript even without user interaction.
This needs to be documented for future references.
 2020-05-01 18:34:39 -07:00
Mozilla L10n Automation Bot
87509365ea [fenix] Import l10n. 2020-05-01 18:34:10 -07:00
Sören Hentzschel
def78b74e6 [fenix] no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek
b5707b6c55 [fenix] Adds swipe to delete tab (https://github.com/mozilla-mobile/fenix/pull/10355) 
* No Issue - Increases tap area of close button

* For https://github.com/mozilla-mobile/fenix/issues/10331 - Adds swipe to delete to the tab tray
 2020-05-01 15:45:51 -05:00
Simon Chae
6fbf233d88 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10195, https://github.com/mozilla-mobile/fenix/issues/10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek
66a7cfb692 [fenix] Fix home navigation (https://github.com/mozilla-mobile/fenix/pull/10350) 2020-05-01 12:46:02 -05:00
Mozilla L10n Automation Bot
600a465a82 [fenix] Import l10n. 2020-04-30 17:38:35 -07:00
Jeff Boek
4f3f47d30d [fenix] For https://github.com/mozilla-mobile/fenix/issues/1063: Put tab tray behind a feature flag and hidden pref (https://github.com/mozilla-mobile/fenix/pull/10313) 
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Adds feature flag and pref for new tab tray

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Creates hidden preference to use new tab tray

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Hides tabs on home screen when setting is enabled

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Navigate to new tab tray from browser with setting enabled

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For https://github.com/mozilla-mobile/fenix/issues/1063 - Fixes crash when toggling to private mode on the home screen

* For https://github.com/mozilla-mobile/fenix/issues/1063 - combines both settings. Cleans up lint errors
 2020-04-30 15:53:10 -05:00
Sawyer Blatz
a3f2721585 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9208: Make slight modifications to tip layout 2020-04-30 11:57:43 -07:00
David Walsh
fdfd550e71 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10159 - Implement new tab tray colors 2020-04-30 08:56:40 -07:00
Michael Droettboom
bf0ecbc19d [fenix] Update generated docs 2020-04-30 08:37:22 -07:00
Michael Droettboom
20d019f42a [fenix] Fix glinter errors 2020-04-30 08:37:22 -07:00
Chenxia Liu
4ed111259a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti
d53213338e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7996: Private mode doesn't play nicely with sites added to home screen 
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
 2020-04-30 13:38:52 +03:00
David Walsh
2b1bbd146c [fenix] For 10296 - Implement tab tray dimension changes 2020-04-29 21:28:36 -07:00
Arturo Mejia
bf8b0df4cb [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager
6ac92c0839 [fenix] No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Mozilla L10n Automation Bot
2069cc29d3 [fenix] Import l10n. 2020-04-29 17:55:53 -07:00
Sawyer Blatz
c3ed72e7a1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10071: Fixes PWA showing toolbar onPause (https://github.com/mozilla-mobile/fenix/pull/10306) 2020-04-29 14:03:59 -07:00
mcarare
2d9813040a [fenix] For https://github.com/mozilla-mobile/fenix/issues/9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
mcarare
fa2a5f9a78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9728: Change SearchView hint color inside app. 2020-04-29 11:20:18 -07:00
ekager
6b97e0f5e3 [fenix] No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea
fa9a791c81 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8648 2020-04-29 09:48:42 -07:00
Mozilla L10n Automation Bot
c80e709bd8 [fenix] Import l10n. 2020-04-28 17:33:33 -07:00
Jonathan Almeida
11a2cece68 [fenix] Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Oana Horvath
4f5ebf1ebc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9783: bring app in focus with sendSingleTapToScreen for UI test (https://github.com/mozilla-mobile/fenix/pull/10136) 2020-04-28 10:46:42 -04:00
Sören Hentzschel
7cfc281d66 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9880 - fixed sync settings style 2020-04-28 09:06:36 +03:00
Falaye Iyanuoluwa
c38d5c6546 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
Mozilla L10n Automation Bot
beac69b4b1 [fenix] Import l10n. 2020-04-28 08:35:44 +03:00
mcarare
ac4b7a55f3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10083: Do not cut off thumb when it is in pressed state 2020-04-27 21:19:44 -07:00
mcarare
b12708c642 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh
a4b9d4378f [fenix] For https://github.com/mozilla-mobile/fenix/issues/10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Christian Sadilek
5f7d514788 [fenix] Configure M2 AMO collection for all builds 2020-04-27 18:33:31 -04:00
Mozilla L10n Automation Bot
0f1d9cf36e [fenix] Import l10n. 2020-04-28 00:28:46 +03:00
Arturo Mejia
0f71b0ced4 [fenix] Fix CrashReporterService breaking changes 2020-04-27 16:43:05 -04:00
Arturo Mejia
0812822771 [fenix] No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1b45aa0a8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/9913, For https://github.com/mozilla-mobile/fenix/issues/9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
Oana Horvath
134909fed3 [fenix] Added new bookmarks tests (https://github.com/mozilla-mobile/fenix/pull/9878) 
Fix for https://github.com/mozilla-mobile/fenix/issues/7417: Fix and re-enable disabled tests
 2020-04-27 18:15:27 +03:00
ekager
5529f77183 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
37475de143 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
e18ce8d6d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
42018cddf2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
c1e736fdb2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
Mihai Branescu
4f10baa9d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added web-extension for cookies 2020-04-24 15:47:48 -07:00
mcarare
72f5556b32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
mcarare
1067782015 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10188: Fix xml indentations and properties order. 2020-04-24 13:28:53 -07:00
mcarare
ae730cec59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10180: Remove touch delegate when button is disabled. 
Also refactored multiple if's into a when.
 2020-04-24 13:28:29 -07:00
mcarare
bad90f3408 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
ekager
4a59ed0eed [fenix] No issue: Update Private Browsing placeholder string 2020-04-24 11:39:14 -07:00
Mihai Branescu
5ed60d32d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - change from modifying event to event listener 
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
 2020-04-24 09:28:40 -07:00
Mihai Branescu
431f3f989f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - remove baidu and yahoo from monitored pages 
These two do not contain ad servers, so we don't need to unnecessarily monitor them
 2020-04-24 09:28:40 -07:00
Mihai Branescu
30273fe6de [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
95f3bf9daf [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
09fae4d74f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Mihai Branescu
15552a39c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added web extension for extracting document urls 2020-04-24 09:28:40 -07:00
Simon Chae
f765736b27 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10162: Set switch back to prev state when failed to enable/disable addon (https://github.com/mozilla-mobile/fenix/pull/10164) 2020-04-24 11:54:16 -04:00
Oana Horvath
a2d169be5f [fenix] fix private notification text (https://github.com/mozilla-mobile/fenix/pull/10192) 2020-04-24 17:55:46 +03:00
mcarare
0ecb2893f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9913, For https://github.com/mozilla-mobile/fenix/issues/9914: Remove button when disabling it. 
Setting visibility to GONE allows clicks to parent view in that space.
 2020-04-24 16:42:47 +03:00
Arturo Mejia
7be16b503d [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
b2cad42ba9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10148 - Add basic tab tray implementation without exposing to rest of app (https://github.com/mozilla-mobile/fenix/pull/9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
81122da15a [fenix] Add 'useEmail' and 'useEmailProblem' metrics event 
Fixes https://github.com/mozilla-mobile/fenix/issues/9834
 2020-04-23 10:33:36 -07:00
Simon Chae
c4dda61fe8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
eb26d39bf0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
194aa1aec3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
8310691f2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/7387: Change ETP onboarding from popup to a dialog. 
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
 2020-04-23 08:17:42 -07:00
mcarare
5aa32ad79a [fenix] For https://github.com/mozilla-mobile/fenix/issues/9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
2aaeb8c3e4 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
JLRoberts
9b0f6ef1d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9550 - Don't overlap search with shortcuts text 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
 2020-04-23 11:21:53 +03:00
mcarare
4c2cfe29b5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
b5f847467f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
0e078d3f20 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Sawyer Blatz
ea02ba60c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9946: Update FennecBeta branding (https://github.com/mozilla-mobile/fenix/pull/10066) 2020-04-22 15:19:24 -07:00
Roger Yang
e85a7bd2ff [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
8ed532ebdf [fenix] For https://github.com/mozilla-mobile/fenix/issues/9208: Adds in-product prompt to homescreen (https://github.com/mozilla-mobile/fenix/pull/9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
239a890d0e [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
07fcd5106a [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
76b250e035 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
e42739298c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
1ba6fea116 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
fafd0b6667 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
fbbc270ddf [fenix] For https://github.com/mozilla-mobile/fenix/issues/8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
Mozilla L10n Automation Bot
fc7b0606c7 [fenix] Import l10n. 2020-04-21 09:04:12 +03:00
ekager
e78408ffb9 [fenix] Adds destructive colors for private theme 2020-04-20 23:00:41 -07:00
codrut.topliceanu
0b0aea27e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8546 - Overrides for new TextInputLayout colors 2020-04-20 23:00:41 -07:00
ekager
479c41236f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5c0d300938 [fenix] Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
e27e45bc75 [fenix] No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
b28a0e8ce9 [fenix] No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
isabelrios
1c1274bb17 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8081 - UI screenshots tests update (https://github.com/mozilla-mobile/fenix/pull/10023) 2020-04-20 10:39:56 -04:00
Ryan Kelly
219c8349d6 [fenix] Some cleanups for running the sync integration tests 2020-04-18 02:30:44 -07:00
Grisha Kruglov
567d0ba9b9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4046: Always display 'Desktop' bookmarks folder 
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
 2020-04-17 23:57:43 -07:00
Jonathan Almeida
048aba1ff9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9932: Fix navigation icon theme missing from migration UI 
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
 2020-04-17 22:45:30 -07:00
Sawyer Blatz
e738f1f8b0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9808: Fix scrolling cutoff on homescreen 2020-04-17 19:58:22 -07:00
Sawyer Blatz
c81052bd6d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6940: Fixes top dynamic toolbar behavior (https://github.com/mozilla-mobile/fenix/pull/9900) 2020-04-17 13:32:20 -07:00
Roger Yang
d08756b53a [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9960: Launch URI in Fenix if failed to launch in custom tab (https://github.com/mozilla-mobile/fenix/pull/9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
737e647c83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8399: Hide keyboard to prevent content resizes 
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
 2020-04-17 12:07:44 -07:00
Emily Kager
94e26476c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8428 - move about text from static_strings.xml to strings.xml and fix comment (https://github.com/mozilla-mobile/fenix/pull/10009) 
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
 2020-04-17 11:50:56 -07:00
Jonathan Almeida
68a2583e53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8422: Add more misc migration UI fixes 2020-04-17 14:22:25 -04:00
Michael Comella
91ce22f753 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - post: update metrics & pings data review URL. 2020-04-17 09:11:58 -07:00
Michael Comella
a4d569db34 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
12e7ad43c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: move forward metric expiration date. 
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
 2020-04-17 09:11:58 -07:00
Michael Comella
a3be78d7e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
deafedeada [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803: add StartupFrameworkStartMeasurement. 
This class controls the central logic around the metrics we want to
record.
 2020-04-17 09:11:58 -07:00
Michael Comella
162a93a190 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803: add Stat and test. 
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
 2020-04-17 09:11:58 -07:00
Michael Comella
3556b5a10f [fenix] For https://github.com/mozilla-mobile/fenix/issues/8803: add StartupTimeline ping type and framework_start metrics. 2020-04-17 09:11:58 -07:00
Emily Kager
04af2a59e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit fullscreen in onPause and onSessionSelected (https://github.com/mozilla-mobile/fenix/pull/10016) 
* For https://github.com/mozilla-mobile/fenix/issues/9703 - Call fullScreenChanged in onPause

* For https://github.com/mozilla-mobile/fenix/issues/10015 - Exit full screen if new session selected
 2020-04-17 08:57:36 -07:00
ekager
94515941cf [fenix] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
2a4ad0e4eb [fenix] Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry 
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
 2020-04-16 21:00:27 -07:00
Mihai Adrian
b510210dce [fenix] For https://github.com/mozilla-mobile/fenix/issues/9987: Set FLAG_SECURE to dialog when flag set in activity. (https://github.com/mozilla-mobile/fenix/pull/9998) 
* For https://github.com/mozilla-mobile/fenix/issues/9987: Add extension to secures dialog if parent activity is secured

* For https://github.com/mozilla-mobile/fenix/issues/9987: Set FLAG_SECURE to dialog when flag set in activity
 2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot
a384ea16d0 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/10011) 2020-04-16 20:32:21 -07:00
Emily Kager
e68491d737 [fenix] Fix: Set correct height for EditText (https://github.com/mozilla-mobile/fenix/pull/10014) 
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
 2020-04-16 20:31:25 -07:00
Mihai Eduard Badea
590a65a894 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
4010e9b64e [fenix] For https://github.com/mozilla-mobile/fenix/issues/9565: Adjust padding and height to allow longer text 2020-04-16 20:10:45 -07:00
mcarare
a697247aae [fenix] For https://github.com/mozilla-mobile/fenix/issues/9536: Update tests to check opened tab is in same browsing mode 2020-04-16 19:50:25 -07:00
mcarare
b5255177fb [fenix] For https://github.com/mozilla-mobile/fenix/issues/9536: Open report issue tab depending on current browsing mode. 
Checking if session is private uses the new browser state API.
 2020-04-16 19:50:25 -07:00
mcarare
86677b3bf3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9989: Add start & end margin to button. 2020-04-16 19:43:34 -07:00
Sawyer Blatz
fba1e732ef [fenix] For https://github.com/mozilla-mobile/fenix/issues/7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
ekager
053f2017e6 [fenix] No issue: Uses NeutralButton for Migration Activity 2020-04-16 13:14:34 -07:00
Jonathan Almeida
1ce8e8383c [fenix] For https://github.com/mozilla-mobile/fenix/issues/8422: Add misc migration UI fixes 2020-04-16 12:02:02 -07:00
Jonathan Almeida
154ade7d64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
7f3ca10103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
880722de99 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot
e3712155f9 [fenix] Import l10n. 2020-04-16 10:13:30 +03:00
ekager
e4136c64d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9516 - Adds selectable background to dialog and snackbar buttons 2020-04-16 10:13:08 +03:00
Sawyer Blatz
e33e84bcbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9857: Create button style (https://github.com/mozilla-mobile/fenix/pull/9858) 
* For https://github.com/mozilla-mobile/fenix/issues/9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
 2020-04-15 15:49:02 -07:00
Jonathan Almeida
9a162480c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
8ea49eb36a [fenix] Remove duplicate FirebasePushService 
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
 2020-04-15 17:55:12 -04:00
Mihai Branescu
d2b9f203b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9420 - relaxed custom engine rules (https://github.com/mozilla-mobile/fenix/pull/9967) 
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
 2020-04-15 13:20:06 -07:00
Michael Comella
de6bbb791a [fenix] For https://github.com/mozilla-mobile/fenix/issues/9644: restrict deps to specific repositories (https://github.com/mozilla-mobile/fenix/pull/9649) 
* For https://github.com/mozilla-mobile/fenix/issues/9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For https://github.com/mozilla-mobile/fenix/issues/9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For https://github.com/mozilla-mobile/fenix/issues/9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For https://github.com/mozilla-mobile/fenix/issues/9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
 2020-04-15 10:54:36 -07:00
ValentinTimisica
5504208fcd [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9710: Vertically aligns users_count with rating (https://github.com/mozilla-mobile/fenix/pull/9950) 2020-04-15 10:51:55 -07:00
ekager
6b4334b699 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Jeff Boek
f35e5f3526 [fenix] No Issue - Fixes nav_graph issues (https://github.com/mozilla-mobile/fenix/pull/9926) 2020-04-15 08:34:45 -07:00
Arturo Mejia
bda6aa50f3 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot
d96a6b206c [fenix] Import l10n. 2020-04-15 03:50:48 +03:00
ekager
4b5c454de7 [fenix] Update UI test to match Support Page title 2020-04-14 11:34:55 -07:00
ekager
e0a4a63d52 [fenix] Update Server.dev to Server.stage to fix A-S upgrade breaking change 2020-04-14 11:34:55 -07:00
Arturo Mejia
e5041e2fd8 [fenix] Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
f38165ad6d [fenix] No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
3b980dadad [fenix] For https://github.com/mozilla-mobile/fenix/issues/3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
c33ac4edc0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot
21dde5fe0b [fenix] Import l10n. 2020-04-14 09:54:30 +03:00
Jeff Boek
6308049167 [fenix] Cleans up nav_graph.xml (https://github.com/mozilla-mobile/fenix/pull/9829) 
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up homeFragment directions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Uses global actions for fragments not owned by homeFragment

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up SearchFragment directions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes settings action from DeleteBrowsingDataFragment

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes browser action from SettingsFragment

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds ManagePhoneFeature global action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Clean up unused deletebrowsingfragment actions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans Up HistoryFragment actions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes Home -> Search action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes the Bookmark -> Browser action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up bookmark fragment actions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions from ShareController

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes defaultBrowserFragment to browserFragment action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes about -> browser action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds global action to TrackingProtectionFragment

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes exception -> browser action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes login -> browser action

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes LoginFragment directions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes ExternalAppBrowser directions

* for https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes unit tests

* For https://github.com/mozilla-mobile/fenix/issues/9751 - Addresses nits in PR
 2020-04-13 21:43:45 -07:00
Arturo Mejia
fa157d252b [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
101d815231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
cf3f14b795 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
92ea1cc5b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (https://github.com/mozilla-mobile/fenix/pull/9893) 2020-04-13 13:08:08 -07:00
ekager
27adb232c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
089e2db827 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
Christian Sadilek
7ca7557c17 [fenix] Configure M2 AMO collection for Nightly/Debug 2020-04-13 10:42:39 -04:00
Oana Horvath
acc46c960b [fenix] fix https://github.com/mozilla-mobile/fenix/issues/9670 intermittent tests (https://github.com/mozilla-mobile/fenix/pull/9767) 
also disabled intermittent closePrivateTabsNotification
 2020-04-13 13:17:35 +03:00
mcarare
682b6db6a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Add unit tests for Context extension getStringWithArgSafe 2020-04-13 09:40:00 +03:00
mcarare
fca63c72d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
79e3a1c328 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
b1aebe96de [fenix] Import l10n. 2020-04-13 09:38:41 +03:00
Mugurell
83063d66f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7157 - Set BrowserMenu width to be max 314 dp (https://github.com/mozilla-mobile/fenix/pull/9731) 
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
 2020-04-10 10:17:07 -07:00
mcarare
c3a5be128f [fenix] For https://github.com/mozilla-mobile/fenix/issues/9793: Adjust relative positions to provide correct a11y traversal 2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
9baa18640c [fenix] Import l10n. 2020-04-09 17:38:37 -07:00
mcarare
290141865c [fenix] For https://github.com/mozilla-mobile/fenix/issues/9798: Disable buttons on hiding and enable on showing. 
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
 2020-04-09 16:06:11 -07:00
Simon Chae
fdd629b61f [fenix] Update not yet unavailable add-on string (https://github.com/mozilla-mobile/fenix/pull/9677) 2020-04-09 15:25:08 -04:00
Roger Yang
cc81201934 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
07b1f84ec6 [fenix] No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
b57314cc8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
a1cf9f7780 [fenix] Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
b9fe826cef [fenix] No issue: Move Do and OpenClass to utils pkg. 
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
 2020-04-08 12:39:22 -07:00
mcarare
c579e388d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
bcd9f52607 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
7001260885 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682: Reduces size of branding (https://github.com/mozilla-mobile/fenix/pull/9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
7df242c354 [fenix] No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
42a823fe24 [fenix] No issue: Add more settings animations (https://github.com/mozilla-mobile/fenix/pull/9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
68a5b44663 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode 
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
 2020-04-07 17:23:06 +03:00
Mugurell
8fd1b5ef87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
8f65dd9856 [fenix] Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
18a639a64d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
f2dbaf24d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: replace assertk assertions with junit. 
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
 2020-04-06 16:56:40 -07:00
Jeff Boek
4371996382 [fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker (https://github.com/mozilla-mobile/fenix/pull/9191) 
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker

* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
 2020-04-06 14:29:52 -07:00
Mihai Adrian
8f1876407b [fenix] For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture (https://github.com/mozilla-mobile/fenix/pull/9743) 
* For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture

* For https://github.com/mozilla-mobile/fenix/issues/9687: Update unit test to new controller parameters
 2020-04-06 11:00:47 -07:00
Arturo Mejia
174af614f4 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly 
enabling/disabling add-on
 2020-04-06 13:47:21 -04:00
Michael Droettboom
461853e252 [fenix] Fix errors in top_sites_count metric 
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
 2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
ff708e4ff1 [fenix] Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
3647494de3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
50bb5be4db [fenix] Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
4d216e26ea [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
47366000e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9670: Disabled intermittent tabMediaControlButton test (https://github.com/mozilla-mobile/fenix/pull/9679) 
and removed file created by mistake -e

added reason for disabled tests
 2020-04-03 20:39:33 +03:00
Mugurell
dca4c74a30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
09253e7566 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
74fbc518db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: Add LintUnitTestRunner gradle task. 
This will prevent us from regressing on adding older versions of the
unit test runner.
 2020-04-03 09:27:49 -07:00
Michael Comella
5d2c577c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: TestApplication -> FenixRobolectricTestApplication. 
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
 2020-04-03 09:27:49 -07:00
Michael Comella
dff3a69dc3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: move TestApplication to the helpers package. 
The helpers/ package is created to separate the test support code from
the code under test.
 2020-04-03 09:27:49 -07:00
Michael Comella
f11bb37121 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: replace unit test runners with FenixRobolectricTestRunner. 
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
 2020-04-03 09:27:49 -07:00
Michael Comella
b401d400b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: add FenixRobolectricTestRunner. 
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
 2020-04-03 09:27:49 -07:00
Michael Comella
774a07d5f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(Robolectric in unit tests. 
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
 2020-04-03 09:27:49 -07:00
Michael Comella
b9ffb3ddcc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests. 
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
 2020-04-03 09:27:49 -07:00
Aaron Train
3489fe1e22 [fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest (https://github.com/mozilla-mobile/fenix/pull/9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
0487e0ad62 [fenix] Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
caded80288 [fenix] Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
cb29b33e21 [fenix] No issue: add kdoc to HomeActivity. 
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
 2020-04-02 16:27:00 -07:00
Sawyer Blatz
9e5e780a9a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499: Refactors snackbar creation and fixes placement (https://github.com/mozilla-mobile/fenix/pull/9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
b2d81076f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView (https://github.com/mozilla-mobile/fenix/pull/8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
e754578cef [fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions (https://github.com/mozilla-mobile/fenix/pull/8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
2f02eeb972 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9604: Swap and adjust margin with padding to avoid text being cut (https://github.com/mozilla-mobile/fenix/pull/9617) 2020-04-02 09:40:29 -07:00
Michael Comella
006e32c454 [fenix] No issue: remove unused FirefoxTestRunner. 
It would be used for on device tests but it doesn't seem to hooked up
currently.
 2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
f7f452367d [fenix] Import l10n. 2020-04-02 13:42:58 +03:00
mcarare
7e54f731db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare
34394af021 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager
2ec2ee395b [fenix] For https://github.com/mozilla-mobile/fenix/issues/768: Add first time PWA dialog (https://github.com/mozilla-mobile/fenix/pull/9308) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-04-01 22:56:12 -04:00
Sebastian Kaspari
548a18ba32 [fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
David Walsh
a96fa3b790 [fenix] Prevent favicons from flashing when items are selected in History (https://github.com/mozilla-mobile/fenix/pull/9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
66d28a700c [fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating (https://github.com/mozilla-mobile/fenix/pull/9353) 
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating

* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
 2020-04-01 15:36:56 -07:00
Mihai Adrian
d6fe360148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9423: Align preference title and summary to viewStart (https://github.com/mozilla-mobile/fenix/pull/9426) 
* For https://github.com/mozilla-mobile/fenix/issues/9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
 2020-04-01 15:36:01 -07:00
ekager
8224f61cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
4b91238222 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
ea9add8d2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
ef2d26efee [fenix] For https://github.com/mozilla-mobile/fenix/issues/9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare
011b4f7fbd [fenix] For https://github.com/mozilla-mobile/fenix/issues/9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Kate Glazko
67bf4073ad [fenix] NoIssueFixMetropolisAccountPref 2020-04-01 15:13:03 -07:00
Sawyer Blatz
eb99ae1fef [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697: Fixes force expand crash (https://github.com/mozilla-mobile/fenix/pull/9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu
7b333febc0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
mcarare
c0b09436d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9574: Remove category layout from LeakCanary SwitchPreference 2020-04-01 10:17:21 -07:00
ekager
d1d0a09f21 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9564 : Fixes cut off strings in ETP panel 2020-04-01 10:16:51 -07:00
Mihai Branescu
d80763ee11 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Kate Glazko
1ccd93d99a [fenix] For 3687 Use Metropolis Font for Header 2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot
9cb58154bb [fenix] Import l10n. 2020-03-31 17:52:51 -07:00
Grisha Kruglov
12e3619a2e [fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems 
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
 2020-03-31 16:07:35 -07:00
Grisha Kruglov
8d1befd34c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561: Fix initialization order in HomeMenu 
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
 2020-03-31 16:07:35 -07:00
Arturo Mejia
12237fdca1 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz
72e91ad94a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472: ForceExpand browser toolbar when navigating (https://github.com/mozilla-mobile/fenix/pull/9552) 2020-03-31 11:16:40 -07:00
Oana Horvath
8dbcd4ed35 [fenix] Updated the method to verify system notifications and added new tests for media notifications (https://github.com/mozilla-mobile/fenix/pull/9330) 2020-03-31 21:11:41 +03:00
ValentinTimisica
7d57c791f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8412: Passes error handling function to 'CustomTabWindowFeature' (https://github.com/mozilla-mobile/fenix/pull/8903) 
* For https://github.com/mozilla-mobile/fenix/issues/8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2020-03-31 10:17:29 -07:00
Grisha Kruglov
3d7f7cbe5d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot
59910e8d82 [fenix] Import l10n. 2020-03-30 22:00:19 -07:00
Grisha Kruglov
423d7cfdda [fenix] Part 6: Kick-off account manager initialization after visual completeness 
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
1a25bc758e [fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction 
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
13deec03a1 [fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov
71564af97d [fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt 
This is enough to cause it to be initialized only if we're going through onboarding.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
1a6e1c0b7f [fenix] Part 2: Do not eagerly initilize account manager within HomeActivity 
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
4e308faf35 [fenix] Part 1: Add 'accountManagerReady' queue to BackgroundServices 
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
ccb08070a7 [fenix] Pre: introduce a RunWhenReadyQueue 
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
 2020-03-30 21:43:38 -07:00
Aaron Train
e8cfeeb0a1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9189: Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests (https://github.com/mozilla-mobile/fenix/pull/9439) 
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
 2020-03-30 18:01:58 -04:00
David Walsh
207fa5752a [fenix] For https://github.com/mozilla-mobile/fenix/issues/9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
Sawyer Blatz
e488ed1773 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132: Update to search animation for top toolbar (https://github.com/mozilla-mobile/fenix/pull/9524) 
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
 2020-03-30 12:07:00 -07:00
ekager
23656b2f53 [fenix] Use existing strings for announcement 2020-03-30 11:10:40 -07:00
asavill
e3427ab39f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7720: 
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
 2020-03-30 11:10:40 -07:00
David Walsh
af892ba291 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7059 - Allow search engines to scroll 2020-03-30 10:31:39 -07:00
David Walsh
8b88382e82 [fenix] Add top sites heading to home screen 2020-03-30 10:29:40 -07:00
mcarare
3fa441bedb [fenix] For https://github.com/mozilla-mobile/fenix/issues/9498: Update unit tests with new constructor argument 2020-03-30 09:56:51 -07:00
mcarare
ceec72715d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9498: Replace navargs with viewModel to remember if scroll to tab 2020-03-30 09:56:51 -07:00
mcarare
f75a0e4347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
Simon Chae
f3e86f841d [fenix] Update NotYetSupported add-ons copy 2020-03-30 10:36:49 -04:00
codrut.topliceanu
df49c9dd94 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9500 - Revert patch for 8568 
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
 2020-03-30 07:20:13 -07:00
Sebastian Kaspari
de3dda8af1 [fenix] Update to new feature-media API. 2020-03-29 23:13:13 -07:00
Mozilla L10n Automation Bot
1030317365 [fenix] Import l10n. 2020-03-29 12:32:40 -07:00
Edouard Oger
24b2efdc89 [fenix] Add secret debug menu to override FxA servers 2020-03-27 22:59:14 -07:00
mcarare
d2c048aa23 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8764: Use list component for items in collections 2020-03-27 22:14:59 -07:00
mcarare
003fb31dfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/8764: Update collection design, including list elements 2020-03-27 22:14:59 -07:00
mcarare
8a92e18ff8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9252: Add progress bar to saved logins view 2020-03-27 22:13:58 -07:00
mcarare
d27f0cf313 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9252: Update views visibility ony when list has finished loading 2020-03-27 22:13:58 -07:00
Arturo Mejia
23c3c286de [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8017 enable SitePermissionsWifiIntegration 2020-03-27 20:44:16 -04:00
Mozilla L10n Automation Bot
14de8badde [fenix] Import l10n. 2020-03-27 17:33:26 -07:00
codrut.topliceanu
7ea1b1ec35 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8568 - Refocus URL editText in SearchFragment onResume 2020-03-27 17:24:14 -07:00
Amaan Marfatia
15a8de6f27 [fenix] AboutPageAdapter doesn't use notifyDataSetChanged() 
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
 2020-03-27 17:23:27 -07:00
David Walsh
608a6531a5 [fenix] No issue - Make fill link from clipboard divider stretch full screen 2020-03-28 02:10:18 +02:00
mcarare
b52f5a3829 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8485 Update UI tests after settings reorg 2020-03-27 17:05:49 -07:00
mcarare
e7d435420f [fenix] For https://github.com/mozilla-mobile/fenix/issues/8485 Move Remote debugging and LeakCanary to Advanced section 2020-03-27 17:05:49 -07:00
mcarare
46e353fd73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8968: Hide keyboard when navigating away from browser 2020-03-27 16:44:11 -07:00
ValentinTimisica
47fd3e26fc [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9280: Remove tabs fade in animation when pressing on Add new collection 2020-03-27 15:54:24 -07:00
Mugurell
a09fad7f74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8651 - Add HistoryInteractor/Controller unit/ui tests 2020-03-27 15:53:31 -07:00
Mugurell
76642b79ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/8651 - Ensure FenixSnackbar has a proper root for inflating into 
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
 2020-03-27 15:53:31 -07:00
Mugurell
2bd3a7d137 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/8651 - Add new menu actions for a history item 
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
 2020-03-27 15:53:31 -07:00
mcarare
15d82b8535 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9435: Adjust margins and paddings to mirror correctly in RTL 2020-03-27 14:45:47 -07:00
Mihai Branescu
7c4db6a8af [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9352 - changed capitalisation of 'Open in app' 2020-03-27 14:43:32 -07:00
David Walsh
d6928f84f6 [fenix] No issue - Add content descriptions when missing 2020-03-27 14:41:51 -07:00
mcarare
b65982aba1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7356: Scroll to selected tab when pressing tab overview 2020-03-27 14:13:26 -07:00
ekager
ccee01a230 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00
Sawyer Blatz
058e6b3e9f [fenix] No issue: Removes settings entrance animation for now (https://github.com/mozilla-mobile/fenix/pull/9443) 2020-03-27 09:55:24 -07:00
Mihai Eduard Badea
2b725c6345 [fenix] Replaced name field with search string field 2020-03-27 16:38:59 +02:00
ValentinTimisica
0dd3a735f1 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4987: Remove close tabs functionality when they are added to a collection 2020-03-27 15:42:17 +02:00
ValentinTimisica
0e678b153f [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/7734: Remove animation for back button 2020-03-27 15:37:33 +02:00
Mozilla L10n Automation Bot
7233d650bb [fenix] Import l10n. 2020-03-27 09:43:08 +02:00
Sawyer Blatz
6138eb18e3 [fenix] No issue: Fixes indentations on several settings fragments (https://github.com/mozilla-mobile/fenix/pull/9442) 2020-03-26 14:52:08 -07:00
Christian Sadilek
0c9b5ec2a9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Grisha Kruglov
31143e7a88 [fenix] Perform storage warm-up after visual completeness 2020-03-26 14:12:35 -07:00
Grisha Kruglov
439608e308 [fenix] Pass lazy references to FennecMigrator 2020-03-26 11:57:45 -07:00
Sebastian Kaspari
adb8f436d3 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5208: Use new tab/collection restore API. 2020-03-26 10:55:12 -07:00
Mihai Branescu
0dac3dd329 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9395 - Trimmed name for custom search engines 2020-03-26 09:35:23 +02:00
Mozilla L10n Automation Bot
ecb941c22b [fenix] Import l10n. 2020-03-26 08:54:04 +02:00
Jonathan Almeida
ffe0b68182 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7661: Add deeplink schemas for fennec variants 2020-03-25 15:39:44 -04:00