A past refactoring resulted in the functionality still working as intended - no
more than 8 topics being selectable at a time but when a topic would be
automatically deselected this would not show - that topic would still be
displayed as selected.
Moving the implementation to a new `FilterChip` Compose api fixes the UI issue
and also allows for more idiomatic code and fixes a previously disabled UI test
Change IntentReceiverActivity so that if the incoming intent has the private_browsing_mode extra set to true, it overrides the openLinksInAPrivateTab setting. This allows external apps to set this flag for sites they want opened in a private app explicitly.
External apps cannot force the link to open in a non-private tab if openLinksInAPrivateTab is enabled, in that case the extra will be ignored.
This is similar to an old fennec feature ( https://bugzilla.mozilla.org/show_bug.cgi?id=1347583 ), however I used the "private_browsing_mode" extra name since it already appears in the code, instead of the "private_tab" extra that fennec used.
Bugzilla bug is 1807531, GitHub bug is #26158
Restore showing a different description of the Tracking Protection feature in
application's onboarding if the Total Cookie Protection feature is not yet
public.
The new description mentioning Total Cookie Protection will only be shown if
the Total Cookie Protection CFR is to also be shown.
While debugging a UI test, we found that the messaging feature was being
queried during the storage initialization and acting on the cached value
alone. This could lead us to no longer receiving new messages during the
app lifetime.
For the unit tests, we switched from mocking the entire feature to
mocking just the `FeaturesInterface` as the test was providing
false-positive results. It's better to create a real feature in any case
for the other testing needs.
Co-authored-by: Benjamin Forehand Jr <bennyjr169@gmail.com>
* Bug 1812193 - Increase the height of the 'x' button of the login and password fields on the 'Add New Login' screen.
Also increase the height of the login and password fields to comply with the accessibility guidelines
* Improve the layout of the AddLogin Fragment
---------
Co-authored-by: Titouan Thibaud <tthibaud@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
We truncate the URL as well if we use that, but unlike the url TextView,
we do not need to shorten it first.
Co-authored-by: Matt Tighe <mtighe@mozilla.com>
Co-authored-by: Noah Bond <nbond@mozilla.com>
* For 1811851: Change MessageNotificationWorker.kt to handle when a user clicks or dismisses a Notification.
* For 1811851: Re-work based on review
---------
Co-authored-by: t-p-white <t-p-white>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This comes to solve the issue seen in the error logs by adding the anchor
change done for the snackbar to the operation queue on thread Main thread.
Should allow to avoid chaning the snackbar's anchor in between onMeasure and
onLayout.
* For https://github.com/mozilla-mobile/fenix/issues/25588, hide password in android 13 clipboard preview
This patch hide passwords copied from "Saved logins" in android 13 clipboard preview
Closes https://github.com/mozilla-mobile/fenix/issues/25588
* fix: show a toast for android 12 and lower
* For mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/25588, hide password in android 13 clipboard preview
* fix: move metrics to new listeners
* fix: actually move metrics to new listeners
---------
Co-authored-by: cschanaj <cschanaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Everywhere the toolbar which needs to show autocomplete suggestions is used we
show a `ToolbarView`. So instead of having this configurable in 2 or more
places as it happened before the autocomplete functionality is configured only
from the `ToolbarView` class.
It will contain a `ToolbarAutocompleteFeature` that will be immediately updated
with the appropriate autocomplete providers or remove all such providers to
immediately update the current autocomplete or remove it entirely depending on
the new search engine selected.
Depending on the selected search engine:
- if it is a topic specific one show bookmarks and tabs from just the it's host
domain
- if it is a general one then don't show bookmarks and tabs at all
- if it is the default search engine then show all bookmarks and tabs.
Previously the check for the "Search -> Show search suggestions" user setting
was only used in the default SearchFragmentState but not again if users change
the current search engine as part of the unified search feature.
This comes to ensure that that check is always made when needing to configure
new search engine results.
For all search engines minus the application added ones we will also show past
search terms used for previous searches with the currently selected search
engine.
If the current search engine is not one added by the application and not the
default one then:
- if it is a topic specific one show history from just the it's host domain
- if it is a general one then don't show history at all
- if it is the default search engine then show all history.
This uses the same direction as the before patch - inflating a new View that
can then serve as an anchor for the Snackbar.
Here we could use directly the AC layout as it needed no special customization.
Tried to mimic the UX of a modal dialog while using Android Views.
This meant including a scrim that would consume all touches and theming the
navigation bar and status bar.
Avoiding a dialog and a separate window will allow the snackbar to see the
new "dialog" as a sibling in a CoordinatorLayout parent and so be able to
position itself based on the new "dialog".
This patch also added "start_download_dialog_layout" from A-C as it leads to
simpler and less code needed to style the layout - colors / shapes with
everything happening in XML versus calculating the values then setting them
programatically.
Previously Android-Components - BrowserToolbarBehavior would be responsible
for positioning the snackbar above the toolbar.
With that responsibility removed we can handle in Fenix positioning the
snackbar depending on the toolbar and many more cases - like positioning it
depending on the download dialogs.
* For 1809444: Added a MessageNotificationWorker to poll Nimbus for new messages and create a notification configured using the highest priority new message (if available).
* For 1809444: Changes from PR review
Co-authored-by: t-p-white <t-p-white>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
github-actions
Alexandru2909
MatthewTighe
Mugurell
Roger Yang
gitstart
mike a
James Hugman
Noah Bond
rahulsainani
Jonas Konrad
DreVla
JohanLorenzo
Jonathan Almeida
t-p-white
Arturo Mejia
Gabriel Luong
mozilla-l10n-automation-bot
iorgamgabriel
Zac McKenney
Vladislav Rashkov
Ben Dean-Kawamura
Titouan
mergify
mcarare
jhugman
rahulsainani
Titouan Thibaud
t-p-white
Jeff Boek
Cathy Lu
kycn
gitstart
sarah541
Harrison Oglesby
Tarik Eshaq
jeddai
t-p-white
Jan-Erik Rediger