Sebastian Kaspari
a3b556aa35
ToolbarIntegration: Use global public suffix list instance.
4 years ago
Roger Yang
8dfa4525ca
Fix OpenSpecificTabIntentProcessorTest to remove AbstractMediaService ( #17955 )
4 years ago
Sebastian Kaspari
f4f5e4b663
Issue #17174 : Remove usage of old media APIs.
4 years ago
Christian Sadilek
88facc4608
Closes #17889 : Wrong tab selected/reloaded when restored from collection
4 years ago
Mozilla L10n Automation Bot
ca57a132c7
Import l10n.
4 years ago
ekager
08a1e0f728
For #17906 - Allow screenshots for private home screenshot test
4 years ago
Oana Horvath
a98b40896d
For #15259 UI test: waits for home screen to be visible
4 years ago
AndiAJ
e31b4f49e9
For #17195 Fix Intermittent UI test verifyTabTrayNotShowingStateHalfExpanded
4 years ago
AndiAJ
e0c70582b8
For #17852 Change and Fix Intermittent UI test openNewTabTest
4 years ago
Michael Comella
b3ef8a11e8
For #17816 : add profiler marker for onPreDraw via HomeActivity.onStart.
...
This may be useful for MAIN start up to determine when the user begins
seeing content.
4 years ago
Michael Comella
4de49c7585
For #17816 : add profiler marker for 2x Activity.onCreate.
...
The IntentReceiverActivity one is particularly useful to quickly determine
when we can begin executing code in the WARM VIEW case (i.e. "Set selection
begin here").
The HomeActivity one is useful for COLD start up analysis in similar
ways and to see the Activity transitions in WARM VIEW.
4 years ago
Mozilla L10n Automation Bot
4084664d30
Import l10n.
4 years ago
ekager
5e9fb855f5
For #17915 - Do not launch system settings on Role Request Intent cancel
4 years ago
AndiAJ
46888cc70f
For #14523 Fix Intermittent tests verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab
4 years ago
Oana Horvath
c6bf949a03
For #17847 : Removes editCustomSearchEngineTest UI test
4 years ago
Mozilla L10n Automation Bot
e24580f0b7
Import l10n.
4 years ago
Arturo Mejia
3a1d56d7c8
For #17817 Change the feature prompt references from fragment to activity.
4 years ago
Mozilla L10n Automation Bot
b057dead45
Import l10n.
4 years ago
Abhinav Gupta
13f5df33a1
Hiding the usernameview if the data item.username is blank.
4 years ago
ekager
f6455b0148
Closes #17871 - use viewLifecycleOwner for TopSitesFeature owner on HomeFragment ( #17873 )
4 years ago
Mozilla L10n Automation Bot
dc8c88fa50
Import l10n.
4 years ago
Roger Yang
993cf74e72
Closes #17174 : Remove the New Media Session API Feature Flag ( #17863 )
4 years ago
ekager
0defc54449
Closes #13089 - Adds correct animations for account settings
4 years ago
ekager
f5b068a453
For #17785 - Use screenshots setting when adding secure flag
4 years ago
jhugman
1ef4102e13
Fixes #17738 - Early initialization of Nimbus ( #17834 ) r=christian
4 years ago
Mugurell
8bf1cae2ca
For #10686 - Use the AC custom behavior for both the top and bottom toolbars
...
This comes to unify the experience (with improvements but also specific issues)
for the url toolbar irrespective of it being placed at the bottom or at the top
Going further this will ease development and ensure the best UX for users.
4 years ago
Gabriel Luong
a3d401a3b7
For #17418 - Add event ping telemetry for the Google Top Site click ( #17862 )
...
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
jhugman
0b764fd3e4
Fixes #17833 - increment A/A experiment id ( #17835 ) r=christian
4 years ago
Christian Sadilek
50e66b469d
Remove SessionManager reference from FenixApplication
4 years ago
Oana Horvath
f0b7b3b987
For #17847 : disables editCustomSearchEngineTest
4 years ago
MickeyMoz
378e68f3a6
Update Android Components version to 73.0.20210204143136.
4 years ago
Andrei Joltan
936966596a
For #16020 Fix Intermittent tests caused by the Menu Button ( #17829 )
4 years ago
Oana Horvath
9783930ac5
For #16615 : UI smoke test customTrackingProtectionSettingsTest
4 years ago
AndiAJ
a4a2a59b7d
For #12895 Fix Intermittent test navigateBookmarksFoldersTest
4 years ago
hwinnemo
c488bb0e11
For #17724 : Wait for tab to be fully created before showing ETP Onboarding if ETP is active
4 years ago
Sebastian Kaspari
f4a7b4c066
Remove TabsUseCases methods that take a Session object.
4 years ago
Grisha Kruglov
3ce9bf93bc
Exclude separators from the bookmarks UI
4 years ago
Grisha Kruglov
ebca575e26
Reuse helper functions in bookmark tests
4 years ago
Mugurell
40fc9c1085
For #12414 - Support sharing images through ShareDownloadFeature
...
Register a ViewBoundFeatureWrapper<ShareDownloadFeature> that will respond to
"Share image" from the browser contextual menu
4 years ago
mcarare
994ec4d55a
For #17364 : Make hint scrollable and do not overlap other elements.
4 years ago
mcarare
d7ad203544
For #17364 : Do not show search suggestion hint before starting to type.
4 years ago
rxu
542071a344
Add mozcn safebrowsing for release variant
4 years ago
Christian Sadilek
e76445b299
Refactor WebAppSiteControlsBuilder to use browser store
4 years ago
Mozilla L10n Automation Bot
dca0cb8c10
Import l10n.
4 years ago
Christian Sadilek
3dc638700f
Refactor tryReloadTabBy to use browser store
4 years ago
Sebastian Kaspari
28c105dcb3
Remove SessionManager dependency from CustomTabsIntegration.
4 years ago
Arturo Mejia
e3b6f060ae
For #12822 - Opt-in of scoped storage
4 years ago
Jonathan Almeida
824f3fd821
Issue #1340 : Forward Activity results to the fragment
4 years ago
Oana Horvath
f180d932c8
For #16959 : verify page url not content in swipeToSwitchTabTest
4 years ago
AndiAJ
c8c0131d00
Go Forward Test Fix
4 years ago
AndiAJ
5eb1a3d210
For #17641 Fix Intermittent test addPredefinedSearchEngineTest
4 years ago
AndiAJ
23e6f7aa91
For #16615 : UI Smoke Tests for Tab Crash Reporter
4 years ago
Mozilla L10n Automation Bot
4c2a4f4d2e
Import l10n.
4 years ago
jhugman
72f977771d
Re-enable Nimbus with Off the main thread I/O and non-blocking networking ( #17684 )
...
* Moved Nimbus setup from Analytics to its own file
* Change experiment identifiers to fit new run of the experiment
* Re-enable nimbus for debug and nightly builds
* ./gradlew ktlint && detekt
4 years ago
Christian Sadilek
d8085480ad
Increase AMO collection cache timeout to 2 days
4 years ago
Christian Sadilek
89ad370eb2
Remove SessionManager references from UI tests
4 years ago
mawen7
1df656cd0e
Include selected session in session suggestions if opened from home fragment ( #17127 )
4 years ago
MickeyMoz
4bc6b85237
Update Android Components version to 73.0.20210129195412.
4 years ago
Mozilla L10n Automation Bot
4507560325
Import l10n.
4 years ago
Mozilla L10n Automation Bot
9afb78de3f
Import l10n.
4 years ago
Michael Comella
d48bb2a4cc
Revert "For #17447 : add intentional delay to cold start up in debug and nightly."
...
This reverts commit 093470a8b3
. This
intentional regression was only intended to be temporary so now we're
removing it.
4 years ago
Roger Yang
d434ff13a5
For #17092 : Dismiss toolbar menu when configuration change occurs ( #17682 )
4 years ago
Jonathan Almeida
66b94ced14
Close #1340 : Add support for WebAuthnFeature
4 years ago
rxu
be0382fca7
Pop out privacy notice in first launch in MozillaOnline builds
...
Add privacy notice related strings
Pop out privacy notice with onboarding
Using embeded geckoview to display details about privacy
Present or hide privacy pop window according to isMozillaOnline
Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
4 years ago
Codrut Topliceanu
e188185b15
For #16828 - Adds telemetry for open in app banner ( #17049 )
...
* For #16828 - Adds telemetry for open in app banner
Specifically: Banner displayed, Dismiss action, Go to Settings action.
4 years ago
Mozilla L10n Automation Bot
41e6c7247e
Import l10n.
4 years ago
Elise Richards
43b0b27819
Update metrics when an addon is installed or enabled ( #17669 )
4 years ago
Oana Horvath
d7b8af78c9
For #9188 : wait for page content to appear in Reader mode tests
4 years ago
Mozilla L10n Automation Bot
f3d332dd8b
Import l10n.
4 years ago
Mihai Adrian Carare
8993a0acb2
For #17655 : Do not pass threshold if showTopFrecentSites is false. ( #17657 )
...
* For #17655 : Do not pass threshold if showTopFrecentSites is false.
* For #17655 : Add unit tests for getTopSitesConfig.
4 years ago
Christian Sadilek
45c0ac85ec
Remove SessionManager from BrowserFragment/ToolbarGestureHandler
4 years ago
Roger Yang
124c2baf30
Closes #17531 : Use top sites count fact for top sites telemetry ( #17664 )
4 years ago
Oana Horvath
67ff4d460a
For #9188 : wait for page load in Reader mode
4 years ago
Roger Yang
eaef276345
Closes #17530 : Update has open tabs metrics when tabs are opened or closed ( #17557 )
4 years ago
mcarare
780e3362a5
For #17464 : Handle selected item background programmatically.
4 years ago
Mozilla L10n Automation Bot
4877b77073
Import l10n.
4 years ago
Christian Sadilek
ef8d07fadf
Fix breaking API change in FennecMigrator
4 years ago
Gabriel Luong
171c466ada
For #14302 - Skip one time pages visit from frecent top sites
4 years ago
mcarare
278ed658b6
For #17635 : Check if id corresponds to a custom tab before removing it.
4 years ago
Christian Sadilek
87d6f32374
Refactor HomeFragment to use browser store
4 years ago
Mozilla L10n Automation Bot
009bb89003
Import l10n.
4 years ago
Elise Richards
39f79778a2
For #17084 : Use in-app browser switching dialog ( #17628 )
...
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
4 years ago
Elise Richards
f7b7b25213
For #16485 : Tabs tray grid view telemetry ( #17442 )
...
* Tabs tray CFR telemetry interactions
* Create CFR events and implementation
* Tests for tab tray controller
4 years ago
Sebastian Kaspari
023ddcc131
Refactor ExternalAppBrowserActivity and ExternalAppBrowserFragment to not use Session(Manager).
4 years ago
Arturo Mejia
b419ff82af
Remove external download manager FeatureFlags
4 years ago
Arturo Mejia
f99c175ceb
Remove autoplay indicator FeatureFlags
4 years ago
Oana Horvath
46487105d5
For #16615 & #11191 : re-enabled ReaderViewTest and added a UI smoke test
4 years ago
Mozilla L10n Automation Bot
c21b41c1b2
Import l10n.
4 years ago
Mozilla L10n Automation Bot
48419633be
Import l10n.
4 years ago
Mozilla L10n Automation Bot
ea7e8e4581
Import l10n.
4 years ago
Jonathan Almeida
65c69c6b9f
Fix breaking APIs in ActivityResultHandler
4 years ago
Christian Sadilek
7001fa1735
Closes #17473 : Intermittent failues of PwaOnboardingObserver
4 years ago
Gabriel Luong
70dc975299
For #17304 - Implement top site search engine attribution ( #17580 )
4 years ago
Sebastian Kaspari
0c41316c31
Revert "For #17044 : Explicitly set a new default engine when default is deleted."
...
This reverts commit 633bf384e2
.
4 years ago
Oana Horvath
d202daf47e
For #16615 : UI smoke test mainMenuInstallPWATest
4 years ago
Mozilla L10n Automation Bot
5f1b177bd7
Import l10n.
4 years ago
ekager
083fe26f57
For #17542 - Removes flash on renaming top site and fixes title not being updated
4 years ago
William Durand
0537594810
Add new BuildConfig variables to support AMO non-production envs
4 years ago
fevziomurtekin
ddd49170d6
For issue: #16394 Fix UI for consider increasing some elements from ETP-Exceptions page
4 years ago
Jonathan Almeida
d32b3015c4
Use a smaller request code for WebAuthnFeature
...
We can't see the private API that we interact with on the OS, but after
some internal investigation it appears that there might be an upper
limit to the request code we can use.
For now, let's try a value similar to that use in the GVE code to see
our requests are failing because of that.
4 years ago
Christian Sadilek
c34d68d915
Closes #17548 : Remove SessionManager reference from TabTrayDialogFragment
4 years ago
Christian Sadilek
0de948e8ae
Issue #17548 : Remove SessionManager reference from TabHistoryDialog
4 years ago
Christian Sadilek
7358a313bf
Issue #17548 : Remove SessionManager reference from FenixTabsAdapter
4 years ago
Oana Horvath
7c56df41df
For #17309 , #13447 , #14534 UI tests: changed the way page Url is verified
4 years ago
Codrut Topliceanu
928ad21c51
For #17481 - Remove unused long_press_tapped metric ( #17544 )
4 years ago
Mozilla L10n Automation Bot
9f5838ecda
Import l10n.
4 years ago
AndiAJ
c8c19077ed
For #16615 : UI Smoke Tests for No history in PB and Add to home screen
4 years ago
mcarare
633bf384e2
For #17044 : Explicitly set a new default engine when default is deleted.
4 years ago
Codrut Topliceanu
20f2135578
For #17377 - Fix for empty awesomeBar on searchFragment open ( #17435 )
...
The awesomeBar was set to stay hidden for the first consumeFrom(store) if the SearchDialogFragment.kt. However, recent changes send an additional store update when the view is created. To work around it we can take a look at AwesomeBarView.update(), we see that the awesomeBar suggestions get provided only if the query != url. So we can use the same method to keep the awesomeBar hidden until the user changes anything in the url.
4 years ago
Mozilla L10n Automation Bot
959dcd2854
Import l10n.
4 years ago
Kate Glazko
ae528e5ab2
For #15181 : Remove All Downloads From Settings
4 years ago
Christian Sadilek
54da078bd3
Refactor QuickSettingsDialog to use browser store
4 years ago
Arturo Mejia
570383a54d
Add dot notification for autoplay blocked content
4 years ago
mcarare
af1af358a3
For #14011 : Remove new line character and spaces from string.
4 years ago
Jonathan Almeida
6dfd7ef757
Add experimental WebAuthn support for Nightly only
...
When testing out WebAuthn support with the privileged API,
we need our app to be signed by an allowed signing key.
We're seeing our tests fail with this error when testing locally:
```
[FidoApiImpl] updateTransaction is called for stop
[FidoApiImpl] finishSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.
```
Our theory is that if we try this code on our signed APK, we should see
it work.
4 years ago
AndiAJ
f8ea4c5ca1
For #16615 : UI Smoke Tests for Tabs Tray
4 years ago
Christian Sadilek
d8c5f8887a
Refactor OpenSpecificTabIntentProcessor to use browser store
4 years ago
Christian Sadilek
be9b478906
Remove SessionManager from TrackingProtectionPanelDialogFragment
4 years ago
Christian Sadilek
f96fdc34eb
Refactor CrashReporterFragment to use browser store
4 years ago
Christian Sadilek
810200f2ab
Switch to use case when selecting tab for extensions
4 years ago
Christian Sadilek
c03e6377ae
Remove unused NotificationsIntentProcessor
4 years ago
Christian Sadilek
eb4beb252f
Remove unused SessionManager reference from RecentlyClosedController
4 years ago
Jonathan Almeida
d3dcf69064
A-C 71.0.20210118134928: Fix breaking API in TabCounterToolbarButton
4 years ago
Sebastian Kaspari
fb64c7c076
SearchDialogController: Pass tab ID instead of Session instance.
4 years ago
MickeyMoz
d945cdc4c8
Update Android Components version to 71.0.20210117143132.
4 years ago
AndiAJ
eb910ff5e8
For #16615 : UI Smoke Tests for Bookmarks
...
For #16615 : UI Smoke Tests for Bookmarks
4 years ago
Oana Horvath
58cefbbb94
For #16615 : Collections UI smoke tests
4 years ago
Michael Comella
093470a8b3
For #17447 : add intentional delay to cold start up in debug and nightly.
...
I validated:
- that the log statement appeared in Nightly but not in Beta.
- that the local runtimes of our perftest increased (the median diff is 124ms)
4 years ago
Arturo Mejia
b9bdc288cb
For issue: #16846 Add ui for controlling exceptions for auto play
4 years ago
Sebastian Kaspari
0035417616
Add unit tests for FennecWebAppIntentProcessor.
4 years ago
Mugurell
d8dc1c4803
For #16519 : Add space above Delete History button ( #17492 )
...
add space above Delete History button
Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
4 years ago
Sebastian Kaspari
051988ecff
Migrate some "selected tab" reads from SessionManager to BrowserStore.
4 years ago
Arturo Mejia
a6495347fd
For issue #17457 : Prevent page refresh when tapping the security icon
4 years ago
codrut.topliceanu
90575e6dd7
For #16238 - Back button now dismisses Suggested Logins
...
By using PromptFeature's onBackPressed the user can now press back to dismiss the Suggested Logins prompt without inadvertently navigating back
4 years ago
Mozilla L10n Automation Bot
2a19967a32
Import l10n.
4 years ago
mcarare
8fa83a7bab
For #10417 : Improve reload collection tab testing.
4 years ago
mcarare
edcee71287
For #17400 : Select tab opened from collection.
4 years ago
mcarare
e110bb322f
For #16393 : Don't show divider above general category when not signed in
4 years ago
Christian Sadilek
978b555387
Closes #17443 : IllegalStateException in startPostponedEnterTransition on HomeFragment
4 years ago
isabelrios
d8584ed632
Changes to run tests on beta builds ( #16786 )
...
* Changes to run tests on beta builds
* remove dontoptime and fix bookmarks tests
* fix ktlint and smokeTest
* add variable for package name
* rebase and fix conflicts
* add yml files and modify script to run tests
* fix yml file indentation
* changes in kind file and add try_task
* fix error kind file
* fix error kind file 2
* fix error kind file 3
* fix reviewer comments
* remove mockwebserver implementation as per reviewer comment
* run beta tests only on releases branches
* reg exp for master branch
* reg exp for master branch2
* modify try_task with release branch
* remove try file
* let's start by running only one test
* address latest reviewers comments
* double check correct tasks for release branch
* remove try file after confirming beta build run
Co-authored-by: isabel rios <isabelrios@MBP-de-isabel-2.home>
4 years ago
Christian Sadilek
53f77e422b
Closes #17441 : NPE when invalidating toolbar in response to reader changes
4 years ago
jhugman
7a3524fae5
SDK-158 Use disabled/no-op version of Nimbus object to eliminate unnecessary Rust call ( #17372 ) r=christian
4 years ago
Arturo Mejia
00d971e9d3
For #16847 : Allow autoplay to controlled via the toolbar.
4 years ago
Sebastian Kaspari
0761f391fc
Update to latest feature-intent and feature-recentlyclosed APIs (and update Android Components).
4 years ago
Oana Horvath
7983a7fc89
For #16615 : UI smoke test editCustomSearchEngineTest
4 years ago
hakkikaancaliskan
542bc89284
For #12732 : Match notification accent color with app theme
4 years ago
Mihai Adrian Carare
3bb074b133
For #13522 : Also remove history entries from tab history. ( #17392 )
...
* For #13522 : Also remove history entries from tab history.
* For #13522 : Test that deleting history also removes it from tab history.
4 years ago
AndiAJ
fc964862e0
For #16615 : UI Smoke Tests for Recently Closed Tabs
4 years ago
Mozilla L10n Automation Bot
837eaa3282
Import l10n.
4 years ago
Oana Horvath
7ac4af46bc
For #10798 & #14526 : Apply auto-download test file fix for download UI tests
4 years ago
Oana Horvath
23789c86c4
For #16615 : UI smoke test manageDownloadsInDownloadsMenuTest
4 years ago
mcarare
4e736625bd
For #8716 : Authentication custom tab now considers browsing mode.
4 years ago
Mozilla L10n Automation Bot
6a84eed552
Import l10n.
4 years ago
Mozilla L10n Automation Bot
7fc0ef5379
Import l10n.
4 years ago
Christian Sadilek
cef56bef17
Update Android Components version to 71.0.20210108190105
4 years ago
Suraj Shah
15f3743ca0
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar ( #16741 )
4 years ago
Mugurell
484f167714
For #16249 - ClipboardHandler cleans up returned text
4 years ago
mcarare
d110464a91
For #17117 : Use proper custom tab session for custom tab toolbar menu.
4 years ago
Mozilla L10n Automation Bot
1fbf227a61
Import l10n.
4 years ago
Arturo Mejia
0aa44c93cd
Closes issue #16945 Refactor TrackingProtectionOverlay to observe session via store.
4 years ago
Christian Sadilek
9a53054b28
Use new RestoreUseCase in A-C to handle tab timeouts
4 years ago
Mozilla L10n Automation Bot
9966a85bd5
Import l10n.
4 years ago
Arturo Mejia
743ba6918f
Closes issue #16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store.
4 years ago
mcarare
156dee29d8
For #15464 : Always dismiss search dialog on url committed.
4 years ago
Hakkı Kaan Çalışkan
e41cc5a414
For #17303 : Move ext fun runIfFragmentIsAttached to utils
...
move to ext
4 years ago
Gabriel Luong
d0fc086fc4
For #16790 - Allow top sites to have an empty name when renamed ( #17290 )
4 years ago
Roger Yang
afa0454f2b
Closes #16603 : Disable pull down when in fullscreen ( #17314 )
4 years ago
Marcello Galhardo
381f22449b
Closes #17118 : Fix font spacing when long pressing a URL ( #17164 )
4 years ago
Sebastian Kaspari
1b6cebf4d4
Switch to new SessionStorage / session restore API.
4 years ago
Oana Horvath
d7a35ed6bd
For #16966 : Remove unnecessary step from mainMenuAddToHomeScreenTest
4 years ago
ekager
d5f625c945
For #17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing
4 years ago
Mozilla L10n Automation Bot
f95547c271
Import l10n.
4 years ago
Roger Yang
7527851cf0
Closes #17298 : Turn on new MediaSession feature for all builds ( #17302 )
4 years ago
Marcello Galhardo
e3a77cb750
Closes #14009 : Fix onboarding 'Sign in to Firefox' ripple effect ( #17169 )
...
* Closes #14009 : Fix onboarding 'Sign in to Firefox' ripple effect
* For #14009 : Add 'onboarding_padded_background_color' instead of rely on OS theme/color
Both previous solution, '?android:attr/colorControlHighlight' and '@color/ripple_material_light' were using a OS theme attr or color, which caused problems. To fix it, we introduced a 'onboarding_padded_background_color' which manually define the ripple effect color of the onboarding manual sign in button.
4 years ago
MarcLeclair
24bce64e0b
16373 Count the # of inflations done on startup ( #16778 )
...
* For #16373 : Added performance Inflater to counter # of inflations
This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)
* For #16373 : Added test for PerformanceInflater
This test got quite awkward / complicated fast. I wanted to test the to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.
* For #16373 : Overrode getSystemService to return PerformanceInflater
This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.
* For #16373 : Added UI test for # of inflations
* For #16373 : Lint fix
* For #167373 : Changed the LayoutInflater cloneInContext to take this instead of inflater
The inflater parameter is set on the first call from the OS from the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.
* For #16373 : Fixed code issues for PR. No behavior change
* For #16373 : fixed some code nits
4 years ago
mcarare
251d652833
For #16027 : Allow elements to be selected separately by a11y services.
4 years ago
Gabriel Luong
487ba32441
For #17292 - Remove unused static_strings ( #17293 )
4 years ago
mcarare
2d1df018ff
For #15061 : Fix error text color in SyncedTabsFragment.
4 years ago
Codrut Topliceanu
c0f0c401f3
For #11580 - Tracks text selection context menu usage ( #16968 )
...
* For #11580 - Tracks text selection context menu usage
Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
Marcello Galhardo
b34cc24f88
For #9778 - Site permission settings item height set to 48dp ( #17134 )
4 years ago
Mozilla L10n Automation Bot
9c776f1d7f
Import l10n.
4 years ago
Mozilla L10n Automation Bot
bad65b5017
Import l10n.
4 years ago
Mozilla L10n Automation Bot
f8f677ce7f
Import l10n.
4 years ago
Mozilla L10n Automation Bot
96be55067d
Import l10n.
4 years ago
Mozilla L10n Automation Bot
16ab8bf1ab
Import l10n.
4 years ago
Mozilla L10n Automation Bot
33272d5447
Import l10n.
4 years ago
Mozilla L10n Automation Bot
96b63485cc
Import l10n.
4 years ago
Mozilla L10n Automation Bot
57d453dc7f
Import l10n.
4 years ago
Christian Sadilek
801ce85898
For #17073 : Stop observers after test run
4 years ago
Mozilla L10n Automation Bot
5445e61b6a
Import l10n.
4 years ago
Arturo Mejia
81f208bda1
For issue #13981 Use DEEP_LINK_SCHEME instead of hard-coded fenix
4 years ago
Mozilla L10n Automation Bot
7bf0f7595c
Import l10n.
4 years ago
Elise Richards
6dadecacc2
For #15703 and #17133 : allow ETP redirect trackers setting to be customized ( #17137 )
...
* Remove ETP redirect trackers feature flag. Add category to ETP panel view.
* Add redirect tracker category to ETP custom settings
4 years ago
ekager
d3e1045ab9
For #17165 - Use application context to get notification localized strings
4 years ago
Christian Sadilek
7a01fcbfa9
Closes #17073 : Fix intermittent failures in PwaOnboardingObserverTest
4 years ago
Oana Horvath
095d07598a
Code cleanup in BookmarksRobot and BookmarksTest
4 years ago
Christian Sadilek
36a6d364a7
For #17086 #17143 : Temporarily turn off Nimbus
4 years ago
jhugman
4565d7381b
No bug- protect nimbus init from StrictMode ( #17033 ) r=christian
4 years ago
Christian Sadilek
0b99669753
Closes #16949 : Refactor OpenInAppOnboardingObserver to use browser store
4 years ago
Oana Horvath
0a0dbeb132
Added a description to each smoke test
4 years ago
Oana Horvath
b0277c3f39
For #16615 : UI smoke test noCrashWithAddonInstalledTest
4 years ago
Sebastian Kaspari
d2b8decaeb
Switch to new feature-tab-collections API.
4 years ago
ekager
30df43d057
For #13321 - Do not hide toolbar when opening multiple bookmarks ( #17038 )
4 years ago
mcarare
04bd9c61a6
For #16483 : Rotate edit arrow when toolbar position is set to bottom.
4 years ago
mcarare
e24ec1c941
For #16068 : Update SUMO links.
4 years ago
mcarare
e0c3193162
For #17061 : Prevent appBarLayout from leaking.
4 years ago
Oana Horvath
f24c6e1316
For #16615 : UI smoke test redirectToAppPermissionsSystemSettingsTest
4 years ago
Kate Glazko
233018df84
For #298 : Fenix Quarantine For Delete Downloads UX
4 years ago
Christian Sadilek
5157a3f50e
Closes #17045 : Crash caused by calling consumeFlow on wrong thread
4 years ago
ekager
419f895364
For #16973 - Use controller handled action instead of toolbar focus
4 years ago
Gabriel Luong
846d618c06
For #16941 - [Telemetry] Bookmark Counts ( #16942 )
4 years ago
Christian Sadilek
d8f3127e08
Closes #16946 : Refactor PwaOnboardingObserver to use browser store
4 years ago
Sebastian Kaspari
46813dd89c
Add search current/home region to debug screen. ( #17015 )
4 years ago
Codrut Topliceanu
d0b09b7d69
For #15368 - Adds telemetry for fullscreen, pip ( #16833 )
4 years ago
mcarare
01db5160ee
For #16827 : Add copy url from long press metrics.
4 years ago
mcarare
93b13ac977
For #15369 : Add synced tabs usage metrics.
4 years ago
mcarare
d233229ce4
For #15366 : Add recently closed tabs metrics from history fragment.
4 years ago
mcarare
2f360eb474
For #15366 : Add recently closed tabs metrics.
4 years ago
mcarare
a59195e2ee
For #16422 : Handle theme for tab history bottom sheet.
4 years ago
Mugurell
574eac4636
For #15367 - DownloadsFragment telemetry ( #16728 )
...
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
4 years ago
Mugurell
d5b33aec43
For #11578 - Add telemetry for how many times we download something ( #16730 )
4 years ago
mcarare
4b2dc28d57
For #16992 : Align clipboard link and text with scan button.
4 years ago
Michael Debertol
95860eba49
For #4333 : Open the keyboard when a search engine is selected ( #14353 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
Arturo Mejia
f263b7333a
For issue #16847 Show the autoplay icon in the toolbar
4 years ago
ekager
3b0e70a856
For #16937 - Ensure FIP is removed on navigation
4 years ago
ekager
2796a7ff18
For #16675 For #16398 - Fix button styling
4 years ago
Jeff Boek
cf61c10c39
For #15403 - Adds a secret debug info screen in settings ( #15540 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
ekager
1ca34a2bc9
For #16807 - Make sure there's only one instance of search dialog
4 years ago
Elise Richards
813693f1d3
Remove hidden fab in tabs tray ( #16972 )
4 years ago
Codrut Topliceanu
556fea5591
For #15636 - Focus a11y collection on snackbar view tap ( #16853 )
...
With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
4 years ago
jhugman
9a984f10f1
Add withExperiment extension method to Nimbus ( #16926 ) r=christian, sebastian
...
* Fixes #16925 Add withExperiment extension method to Nimbus
* Don't call Nimbus at all if not enabled by FeatureFlag
4 years ago
Oana Horvath
9d5ec47ec3
Fix #16960 & #16959 : updateSavedLoginTest, swipeToSwitchTabTest UI smoke tests
4 years ago
Roger Yang
ca605d8a95
Closes #16075 : Add distribution_id in telemetry startup metrics ( #16821 )
4 years ago
Christian Sadilek
f0078097f8
Prepare for A-C Session[Manager] observable deprecation
4 years ago
Mozilla L10n Automation Bot
cecb8385e7
Import l10n.
4 years ago
ekager
dd2615b554
For #16442 - Check if fragment is still attached before updating site permissions rules ( #16954 )
4 years ago
jhugman
459f1e970f
Fixes #16948 : call nimbus.updateExperiments on startup ( #16950 ) r=gl
4 years ago
mcarare
a2ad9f7a27
For #16894 : Handle adding voice search button depending on state.
4 years ago
mcarare
0a77f4bccf
For #16775 : Fallback to light mode drawable when ui mode is not resolved
4 years ago
mcarare
b4a81c2219
For #15640 : Remove private resources from RadioButtonPreference.
4 years ago
mcarare
fa08afbc03
For #15640 : Remove private resources from TextPercentageSeekBarPref.
4 years ago
Mozilla L10n Automation Bot
0ed5ba68c6
Import l10n.
4 years ago
ekager
2bb7bea258
For #16668 - Fix keyboard show/hide from search dialog fragment
4 years ago
Kate Glazko
ef01cdcefe
For #16541 : Download UX Updates
4 years ago
Christian Sadilek
faf765a57d
Update IntentProcessors after breaking API change
4 years ago
Emilio Cobos Álvarez
9d5afd501e
Add support for EME permission.
...
This accompanies the changes in mozilla-mobile/android-components#9121.
Closes #1175
4 years ago
Mugurell
f2191bdbb5
For #13427 - Disable the "selected tab" decoration when in Multiselect
...
Selecting a tab while in Multiselect would add a different decoration to the one
already set for the last tab opened and this would confuse users.
Let's avoid this.
4 years ago
Christian Sadilek
d1345e8f93
Closes #11290 : Refactor ToolbarMenu to use browser store
4 years ago
Roger Yang
2ff7ba75c7
Closes #16896 : Integrate new MediaSession API to nightly or debug builds ( #16909 )
4 years ago
Oana Horvath
80ad6dea32
For #16615 : UI smoke test updateSavedLoginTest
4 years ago
Oana Horvath
5e046c8f04
For #16615 : UI smoke test startBrowsingButtonTest
4 years ago
Mozilla L10n Automation Bot
5cc66f532f
Import l10n.
4 years ago
Elise Richards
948db6f77b
Reload restored tabs from collection ( #16865 )
4 years ago
Sebastian Kaspari
2cada405d8
Update Android Components to 69.0.20201207103252.
4 years ago
Mozilla L10n Automation Bot
507445a400
Import l10n.
4 years ago
Mozilla L10n Automation Bot
68ae35027f
Import l10n.
4 years ago
ekager
e428694a51
For #16397 - Fixes SignOutFragment crash and invisible button
4 years ago
Oana Horvath
7a08175568
For #16615 : Smoke UI test swipeToSwitchTabTest
4 years ago
Mugurell
c89a7193f5
For #16248 - Cleanup error pages of inlined code ( #16834 )
...
Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
4 years ago
Roger Yang
3c3ddb4f44
For #16133 : Simplify OpenInAppOnboardingObserver condition ( #16851 )
4 years ago
Philipp Klein
2be3fd05f2
For #15362 : Remove swipe to delete for bookmarks ( #16646 )
...
Removed now obsolete feature flag and tests.
Removed obsolete swipe refresh state from BookmarkFragmentState
Also adapted tests and remove obsolete ones.
4 years ago
Mozilla L10n Automation Bot
c63a14af14
Import l10n.
4 years ago
Elise Richards
77f061c362
Closes #8791 : Use A-C tab counter and upgrades to A-C 69.0.20201203202830
...
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
4 years ago
Codrut Topliceanu
79d1c08402
For #16629 - Fix for collection snackbar View button ( #16679 )
4 years ago
Oana Horvath
8a579ee62b
For #16838 : deleted mainMenuOpenInAppTest
4 years ago
Jonathan Almeida
c99b2157fb
Fix breaking changes from FCM SDK update
4 years ago
jhugman
ea9f692007
Nimbus-SDK-119 Get Nimbus server endpoint at build time. ( #16682 )
...
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2].
For production use, this requires a secret named `nimbus_url` to be put into CI.
Note: Nimbus is currently behind a feature flag.
If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.:
```
nimbus.remote-settings.url=https://settings.stage.moz4ws.net
```
Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment.
[1]: https://github.com/mozilla-mobile/android-components/pull/9024
[2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
4 years ago
jhugman
3cd4ff9ac8
Adding menu configuration for A/A experiment and A/B experiment ( #16692 )
4 years ago
Mozilla L10n Automation Bot
eab87555dc
Import l10n.
4 years ago
Christian Sadilek
3722033a5c
For #16032 : Support installing recommended add-ons from AMO
4 years ago
Roger Yang
26051f7c0e
Closes #16603 : Disable pull down refresh when activity is in immersive mode ( #16793 )
4 years ago
Oana Horvath
5867d2830a
Split UI smoke tests into smaller tests
4 years ago
Mozilla L10n Automation Bot
a2b6ddf457
Import l10n.
4 years ago
Mozilla L10n Automation Bot
e587f814c7
Import l10n.
4 years ago
Sebastian Kaspari
57ebc0cb99
ExternalAppBrowserActivity: Add additional test cases.
4 years ago
Sebastian Kaspari
788a8309c2
Issue #16435 : Open custom tab in Fenix: Force launch outside of and remove current task.
4 years ago
Sebastian Kaspari
776b64f959
Issue #16435 : Finish ExternalAppBrowserActivity and remove task if linked tab doesn't exist anymore.
...
This doesn't fix the underlying issue of #16435 , but a symptom we have seen quite often in different
situations: When the ExternalAppBrowserActivity is not linked to a tab anymore then it falls back
to displaying a (partially broken) browser UI. With multiple browser activities at the same time
sooner or later we crash with a "display already acquired" error because both activities try to
render the same tab.
4 years ago
mcarare
0bd3654bc7
For #16759 : Prevent crash on showing info banner.
4 years ago
Sebastian Kaspari
055c76b7ba
FenixApplication: Remove unused kinto endpoint.
4 years ago
Sebastian Kaspari
d84b8ebdc6
Issue #12731 : Log and record breadcrumb when onTrimMemory() gets invoked.
4 years ago
Mozilla L10n Automation Bot
e8fa1a66f0
Import l10n.
4 years ago
Mozilla L10n Automation Bot
7e56b0cd53
Import l10n.
4 years ago
Mozilla L10n Automation Bot
806ed78b7f
Import l10n.
4 years ago
Oana Horvath
c8f8e2e665
Updates to UI tests using the modified recyclerViewIdlingResources minItemCount
4 years ago
Oana Horvath
894b25855e
For #16615 : UI smoke test toggleSearchSuggestions
4 years ago
Mozilla L10n Automation Bot
2e676a047d
Import l10n.
4 years ago
Mihai Adrian Carare
b2b558fe39
For #16745 - Allow preference layout to increase height if needed. ( #16752 )
4 years ago
Mihai Adrian Carare
34b4dad614
For #16735 - Do not show grid view CFR if grid view is already selected. ( #16740 )
4 years ago
ekager
d49d710343
For #16676 - Do not switch mode on last private tab via tab context menu
4 years ago
Mozilla L10n Automation Bot
94c59cb3ca
Import l10n.
4 years ago
Oana Horvath
2d652acbf2
For #16615 : UI smoke test addPredefinedSearchEngineTest
4 years ago
Mozilla L10n Automation Bot
23460fac51
Import l10n.
4 years ago
Codrut Topliceanu
4b56aeb12f
For #16592 - Fix missing collection snackbar for a11y ( #16593 )
...
Set null anchor for snackbar when using a11y services
4 years ago
Mozilla L10n Automation Bot
f89f6fd2a2
Import l10n.
4 years ago
mcarare
f823a5d246
For #16353 : Avoid strict mode death on reading onboarding preference.
4 years ago
mcarare
de1fa74ac1
For #16353 : Add unit tests for onboarding finishing conditions.
4 years ago
mcarare
089c79f868
For #16353 : Finish onboarding on loading a web page, with exceptions.
4 years ago
mcarare
451f60b095
For #16353 : Do not finish onboarding on search dialog opening.
4 years ago
Mozilla L10n Automation Bot
c5b9491619
Import l10n.
4 years ago
Mozilla L10n Automation Bot
7166cf2b48
Import l10n.
4 years ago
Mozilla L10n Automation Bot
9cd2757502
Import l10n.
4 years ago
ekager
b9737bde95
For #16351 - Add divider lines for search dialog
4 years ago
Sebastian Kaspari
2b759e9d6f
Integrate new search code from Android Components into Fenix.
4 years ago
MickeyMoz
2904ca8ac0
Update Android Components version to 68.0.20201120125142.
4 years ago
Mozilla L10n Automation Bot
4e598d16fc
Import l10n.
4 years ago
jhugman
9cdfb6db4a
Nimbus Global Opt Out ( #16543 ) r=gl
4 years ago
Mozilla L10n Automation Bot
359759753c
Import l10n.
4 years ago
ekager
b7fe809ae4
For #16351 - Make homescreen interactive when search dialog is up
4 years ago
mcarare
519885da43
For #15788 : Remove nested constraint layout in tabs tray.
4 years ago
mcarare
cf162c69d1
For #15788 : Remove nested layouts in search dialog layout.
4 years ago
Oana Horvath
2d6d49324e
For #16615 : UI smoke test firstRunScreenTest
4 years ago
mozilla-l10n-automation-bot
01ec558811
Import l10n. ( #16625 )
4 years ago
Jonathan Almeida
cebab81e07
Update Android Components to 67.0.20201117165227 ( #16619 )
4 years ago
ekager
f520586dcd
For #12062 - Remove feature flag for return to browser ( #16622 )
4 years ago
Mugurell
ef5846dc3e
For #16614 - Ensure a stable order for the items in tabs tray. ( #16618 )
...
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items
This order should also be kept after returning from Multiselect mode.
4 years ago
Bryan Kok
5f9de1e261
Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu
4 years ago
ekager
614471495d
For #15091 - Fixes RecentlyClosedAdapter DiffCallback ( #16608 )
4 years ago
Mozilla L10n Automation Bot
edfb85b021
Import l10n.
4 years ago
Christian Sadilek
1d5f74d865
Closes #16153 : Intermittent failures of ShareControllerTest.handleShareToApp
4 years ago
mcarare
0d37c8f268
For #16420 : Make search bar first view focused by a11y services on open.
4 years ago
Christian Sadilek
88f3f3564e
Issue #16587 : Make sure tab counter correctly reflects private/normal tab counts
4 years ago
Christian Sadilek
fbbc25b54e
Closes #16053 : Fix crash when closing private tabs via notification
4 years ago
MickeyMoz
2c4f0624fd
Update Android Components version to 67.0.20201115143123.
4 years ago
Mozilla L10n Automation Bot
4895cf4e91
Import l10n.
4 years ago
Jonathan Almeida
78715c3020
For #13477 - Move BiometricPrompt to a separate feature ( #16498 )
...
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
4 years ago
Mihai Adrian Carare
85dd2f8313
For #16511 - Change a11y parent of button without breaking the tab list. ( #16555 )
4 years ago
Mozilla L10n Automation Bot
af666d8c57
Import l10n.
4 years ago
Michael Comella
94bbf90f3c
No issue: move TestStrictModeManager to perf sub package.
4 years ago
Michael Comella
e8bf955893
No issue: move StrictModeManager to perf package.
...
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
4 years ago
Michael Comella
72ab058551
For #16376 : move Startup*Test to perf pkg under code owners.
...
Instead of listing many different files here, we should just put them in
/perf/ packages and code owner them.
4 years ago
Michael Comella
54c7dc70e7
For #16376 : assert num ConstraintLayout direct descend RecyclerView.
...
I'm not convinced this is a useful test because the performance
characteristics seem unfortunately nuanced: if the test fails, it implies
you shouldn't add more but that isn't necessarily true (for example, if
your RV child has a large depth). Furthermore, we haven't measured in a
variety of circumstances that layouts like LinearLayout perform better
as RecyclerView children so maybe it only held for the one small case we
used it in.
4 years ago
Michael Comella
b0a1e0884e
For #16376 : test view hierarchy depth in StartupExcessive*Test.
4 years ago
Jocelyne Abi Haidar
88233ef42d
For #15725 : Set up preferences in onCreatePreferences instead of onResume
...
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
4 years ago
Oana Horvath
10dadb838e
Closes #12899 : fixed UI test for ETP off
4 years ago
mcarare
d45bdfb0f4
For #16477 : Switch to using an extension to update a11y collection info.
4 years ago
mcarare
e2322a18f9
For #16477 : Migrate updateAccessibilityCollectionItemInfo to extension.
4 years ago
mcarare
b52f069573
For #16477 : Update a11y info to collection item for both grid and list.
4 years ago
Bryan Kok
92b93081e5
Replace lingering occurence of ic_hollow_share with ic_share_filled ( #16548 )
4 years ago
Mugurell
c6de8632de
For #16461 - Ensure the proper items order after exiting Multiselect ( #16482 )
4 years ago
LeoMaldonado
a06b30a73d
Fixes Comment on #16563 : DefaultToolbarMenu registering for bookmark changes
...
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
4 years ago
LeoMaldonado
2d8fe7a9ad
Closes #16345 : Update share icon shape
...
updating share icon to a filled shape, like default toolbar menu across all app
4 years ago
LeoMaldonado
84eda3d38f
For #16345 : use same share icon across all app
...
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
4 years ago
Gabriel Luong
27ee2ba4f6
For #15761 - [Grid View] Enable the grid view and remove its feature flag ( #16546 )
...
* For #15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag
* For #15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
4 years ago
mozilla-l10n-automation-bot
6ebc90deae
Import l10n. ( #16486 )
4 years ago
Gabriel Luong
e9d335cb24
Revert "For #15761 - [Grid View] Enable the grid view and remove its feature flag ( #16535 )" ( #16544 )
...
This reverts commit 7499d33b32
.
4 years ago
rxumoz
409041ae3b
For #16451 - Change default top sites to Baidu & JD in China build ( #16515 )
...
* Add top sites related strings
* Change default top sites to Baidu & JD in China build
4 years ago
Gabriel Luong
7499d33b32
For #15761 - [Grid View] Enable the grid view and remove its feature flag ( #16535 )
4 years ago
ekager
1ed9ebf622
For #16132 - Rename normal mode menu item, remove telemetry
4 years ago
Gabriel Luong
ebadbdb352
For #14920 - Show a Tabs Tray CFR Banner for grid view tip ( #16466 )
4 years ago
Codrut Topliceanu
f3edce5f16
For #11376 - Reverse tabs list order ( #16245 )
4 years ago
Oana Horvath
ae407a7367
Closes #13217 : fixed UI test for main menu items
4 years ago
Johan Lorenzo
4570f5a14f
Revert "Update Android Components version to 66.0.20201111143206."
...
This reverts commit dbdb68ac72
.
4 years ago
Kate Glazko
6c68e79a22
For #14772 : Crash in Downloads
4 years ago
Mugurell
a097b135b3
For #16076 - Add new "share_image" telemetry event
4 years ago
MickeyMoz
dbdb68ac72
Update Android Components version to 66.0.20201111143206.
4 years ago
Mugurell
c3179512de
For #16500 - Ensure CardView clips ImageView on lower APIs ( #16507 )
...
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
4 years ago
mcarare
c427ebf8d5
For #16416 : Remove save to collection button from tab a11y list.
4 years ago
ekager
a8db85fc22
For #16132 - Revise multiselect mode UI
4 years ago
mozilla-l10n-automation-bot
c8aee39db1
Import l10n. ( #16468 )
4 years ago
Mugurell
5e58377948
For #16424 - Focus the right item in tabs tray when using Talkback ( #16472 )
...
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
Codrut Topliceanu
6e4393a199
For #15720 - Remove unused telemetry ( #15887 )
4 years ago
Gabriel Luong
b5c25ccf3b
For #15960 - Enable Grid View in Nightly only ( #16462 )
4 years ago
mcarare
928d320836
For #16426 : Allow multiselect title to be selected by a11y services.
4 years ago
mozilla-l10n-automation-bot
517ff91753
Import l10n. ( #16447 )
4 years ago
Christian Sadilek
0fbc8410a4
Closes #16430 : ExternalAppBrowserActivity should not handle incoming intents
4 years ago
mozilla-l10n-automation-bot
2fb7383684
Import l10n. ( #16441 )
4 years ago
Mihai Adrian Carare
c641ed72dc
For #15764 - Update Tabs summary description. ( #16428 )
4 years ago
Christian Sadilek
96e2123f86
Update Android Components version to 66.0.20201106143126 ( #16439 )
4 years ago
Oana Horvath
5e745d0bc3
For #15847 : use Espresso's RecyclerView scrollTo action
4 years ago
Mozilla L10n Automation Bot
1ad5ea58a2
Import l10n.
4 years ago
Christian Sadilek
4abd399002
Closes #16327 : Refactor MenuPresenter to use browser store
4 years ago
Arturo Mejia
50d7792330
For issue #15934 fix ConcurrentModificationException
...
on WifiConnectionMonitor
4 years ago
Sebastian Kaspari
1dca411515
Fix GeckoProvider for beta and release variant.
4 years ago
rxu
686f7bd7c6
Add mozcn safebrowsing
4 years ago
Michael Comella
afa080c956
For #15279 - review: set LazyMonitored to private.
4 years ago
Michael Comella
c96e16112f
For #15279 : add component init count to StartupExcessiveResourceUseTest.
4 years ago
Michael Comella
090650485f
For #15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
Michael Comella
89541a17f7
For #15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
Michael Comella
901c78684c
For #15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
Michael Comella
f37ace0630
For #15279 : add LazyMonitored and tests.
4 years ago
mozilla-l10n-automation-bot
de3c4bc635
Import l10n. ( #16380 )
4 years ago
Kate Glazko
0ae268914b
For #352 : Delete a download
4 years ago
ekager
c0e01373e1
No issue: Update stable androidx and material versions
4 years ago
Mugurell
88bfaaabe7
For #6521 - Remove auto sigin onboarding card ( #16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when #15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
Mugurell
1358e09d7e
For #16323 - Use 10dp corner radius for the selected outer border of a grid item ( #16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
Mugurell
172977f698
For #14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( #16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
Mihai Adrian Carare
db58022fbb
For #13172 - Tab swipe order follows text direction from oldest to newest ( #16178 )
4 years ago
Rafał Opiłowski
96fb9f4676
For #12971 - Show collection saved snackbar above FAB ( #16311 )
4 years ago
Oana Horvath
c3204b7644
For #15847 - Disables verifyAboutFirefoxPreview UI test ( #16346 )
4 years ago
Mugurell
34f0c84d46
For #16339 - Initialize FxaAccountManager with also a CrashReporter ( #16340 )
4 years ago
Sebastian Kaspari
baaa85db80
Closes #16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
Oana Horvath
4ff2635423
For #13446 UI tests: wait for historyList to exist
4 years ago
Mozilla L10n Automation Bot
e61e5b80dd
Import l10n.
4 years ago
Gabriel Luong
2bd2a5651d
For #14636 - Update preference section headers to use correct color, spacing and rulers ( #16332 )
4 years ago
Michael Comella
2b621fcb1b
No issue - review: clarify thread safety of suppressionCount.
4 years ago
Michael Comella
bff8a0d6a7
No issue: make StrictMode suppression count thread safe.
4 years ago
Christian Sadilek
d7688c8427
For #12062 : Switch to consumeFlow and add tests
4 years ago
ekager
bd2c407943
For #4652 - Remove activityViewModels workarounds
4 years ago
MarcLeclair
7b1af41b40
15278 detekt rule runblocking ( #15942 )
...
* For #15278 : added CoroutineManager to count runBlocking calls
* For #15278 : Added actual detekt rule for runblocking and its config to the yaml
* For #15278 : Added unit test for RunblockingCounter
* For #15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For #15278 : made runblocking a Long to prevent overflow
* For #15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For #15278 : Added setup for unit test, since it failed without restting counter
* For #15278 : Fixed naming for RunBlocking lint check
* For #15278 : removed changes made to test to use runBlockingIncrement
* For #15728 : added test exclusion for runBlocking check
* For #15278 : changed null check and added Synchronized to count setter
* For #15278 : fix for nits
* For #15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For #15278 : fixed for nits
* For #15278 : Moved increment function to extension function and fixed indentation
* For #15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
ekager
d46fc7b142
For #6313 - Remove unneeded delay in BrowserAnimator
4 years ago
Roger Yang
b65c798450
For #16268 - Allowing multiple task while sharing ( #16275 )
4 years ago
Jocelyne Abi Haidar
1b204158e5
For #15931 : Sort Downloads from newest to oldest ( #15939 )
4 years ago
mcarare
142d7a418c
For #15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
mcarare
5b0bdda974
For #15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
mcarare
adbb262787
For #14552 : Do not display back button when there is no tab history.
4 years ago
Mozilla L10n Automation Bot
bf69519dc9
Import l10n.
4 years ago
Mugurell
a6092c34cc
For #15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
Mugurell
83bd80c873
For #15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Mugurell
0324baef03
For #15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
Mugurell
482739ba8c
For #15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
Gabriel Luong
66210469c0
For #9548 - Ability to rename top sites ( #16285 )
...
* Ability to rename top sites, closes #9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
ekager
9bb3440fce
No issue: Make sure we are cleaning up test coroutines
4 years ago
mozilla-l10n-automation-bot
d1ec6cac86
Import l10n. ( #16274 )
4 years ago
ekager
4246293a93
For #16161 - Fixes Saved Login toolbar layout
4 years ago
Codrut Topliceanu
975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump ( #16229 )
...
* For #14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
mozilla-l10n-automation-bot
e21c81a0dd
Import l10n. ( #16240 )
4 years ago
mcarare
3cb2c83980
For #16250 : Disable remote USB debugging for SDK <23.
4 years ago
Mihai Adrian Carare
0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. ( #16081 )
...
* For #15929 : Remove SearchWidgetCFR telemetry.
* For #15929 : Remove SearchWidgetCFR and search widget experiment.
* For #15929 : Remove unit tests references to search widget experiment.
4 years ago
mcarare
9748c65c71
For #15413 : Use proper url when bookmarking a page.
4 years ago
Oana Horvath
e36e61b2c3
For #10690 : re-enable editBookmarkTest
4 years ago
Mozilla L10n Automation Bot
5739140ff3
Import l10n.
4 years ago
Arturo Mejia
bb7d821804
Fix AddonsManagementFragment detekt error
4 years ago
Christian Sadilek
c330426bb7
No issue: Fix onConfigurationChange crashes in Debug build
4 years ago
Christian Sadilek
601aa19176
Closes #11285 : Replace Session[Manager] observers in BaseBrowserFragment
4 years ago
Grisha Kruglov
655a5cbf54
Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context
4 years ago
mcarare
21a67de947
For #15379 : Use proper url when sharing.
4 years ago
ekager
9b2162fca2
For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent
4 years ago
Arturo Mejia
0ae0b89d65
Fix add-on translation braking changes
4 years ago
Aaron Train
b8fff8cef1
For #8169 - Upgrade Mockwebserver ( #16186 )
...
Upgrades Mockwebserver to 4.9.0
4 years ago
mozilla-l10n-automation-bot
b8d6dbd426
Import l10n. ( #16198 )
4 years ago
Lorenzo Stanco
90220678cf
For #16122 - Add a dark theme color for the top sites pin icon ( #16180 )
4 years ago
mozilla-l10n-automation-bot
7d59a58134
Import l10n. ( #16163 )
4 years ago
mozilla-l10n-automation-bot
6353e9979e
Import l10n. ( #16154 )
4 years ago
ekager
e15f50712a
For #6313 - Set session ClearColor through Engine DefaultSettings
4 years ago
mozilla-l10n-automation-bot
4acf3c601d
Import l10n. ( #16138 )
4 years ago
Jocelyne Abi Haidar
f514f6099a
For #15508 : Show error when trying to save empty or invalid bookmark URL ( #15674 )
4 years ago
mozilla-l10n-automation-bot
c40b93715f
Import l10n. ( #16108 )
4 years ago
Mugurell
358ca2c87f
For #15543 - Adjust the height of the tabs tray depending on the number of tabs ( #15749 )
4 years ago
ekager
aae43b84eb
For #12062 - Feature Flag return to browser ( #16099 )
4 years ago
ekager
6b8f2001df
For #16084 - Match elevation of Tab in Collection to header ( #16100 )
4 years ago
ekager
d5cb9c599c
For #15910 - Adds back automatic toggle, disables slider when enabled ( #16070 )
4 years ago
Arturo Mejia
dbe6dbb18c
For #16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest ( #16056 )
4 years ago
mcarare
1a10215caf
For #14619 : Show half a tab top offset when scrolling to selected tab.
4 years ago
mozilla-l10n-automation-bot
20df97ad57
Import l10n. ( #16074 )
4 years ago
Mugurell
57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug ( #16060 )
4 years ago
Elise Richards
7e3c26914c
For #15080 : Handle default search engine when editing or removing ( #15768 )
4 years ago
Juan C. Goncalves
eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat ( #16011 )
4 years ago
Sebastian Kaspari
0d97862824
FennecWebAppIntentProcessor: Catch JSONException.
4 years ago
Mihai Adrian Carare
b1bc024ff5
For #11631 : Move report site issue extension to main menu. ( #15884 )
...
* For #11631 : Move report site issue extension to main menu.
* For #11631 : Update UI test for installing add-on.
4 years ago
Tom Klein
57ba92080f
For #15480 - Update the UI when a collection is renamed
4 years ago
mcarare
edd613ace2
For #15688 : Update UI tests.
4 years ago
mcarare
5f01583f25
For #15688 : Update unit tests.
4 years ago
mcarare
9274558e2f
For #15688 : Navigate to home screen with arguments on new tab action.
4 years ago
Mozilla L10n Automation Bot
ae74edecdb
Import l10n.
4 years ago
Sebastian Kaspari
2da24cd91d
Update Android Components, Kotlin, Gradle plugin ( #16021 )
...
* Closes #13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Mihai Adrian Carare
3ed49d8802
For #14744 : Also show Fill link from clipboard with search shortcuts. ( #15885 )
4 years ago
mozilla-l10n-automation-bot
46ff7a182a
Import l10n. ( #16014 )
4 years ago
mozilla-l10n-automation-bot
c941bd99b0
Import l10n. ( #16001 )
4 years ago
mozilla-l10n-automation-bot
1d91f1f087
Import l10n. ( #15986 )
4 years ago
Gabriel Luong
d33bd76e40
For #15796 - Use the device locale for the system locale subtitle ( #15975 )
4 years ago
Gabriel Luong
87ec7a77ae
For #15937 - Remove topFrecentSite feature flag ( #15967 )
...
* For #15937 - Remove the topFrecentSite feature flag
* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager
d208ffe002
For #7345 - Update new shield icons, remove lottie ( #15909 )
4 years ago
Christian Sadilek
c852301c93
Closes #11286 : Add TelemetryMiddleware to remove Session[Manager] observers
4 years ago
Gabriel Luong
412b412d5f
For #15796 - show device language under follow device language ( #15966 )
4 years ago
amkcpu
7ba5e130ba
For #10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
4 years ago
mozilla-l10n-automation-bot
a2a4284a1a
Import l10n. ( #15945 )
4 years ago
Jeff Boek
55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds ( #15643 )
4 years ago
Gabriel Luong
b79df0ba8f
For #14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
4 years ago
mcarare
9f14007a98
For #14922 : Adjust margins for add search engine preference.
4 years ago
mcarare
ba0c005ae9
For #14922 : Add divider above address bar preferences.
4 years ago
mcarare
7510b1609f
For #15898 : Add dividers above subheadings in tabs screen.
4 years ago
mcarare
e50cb21fd0
For #15898 : Add dividers above subheadings in customise screen.
4 years ago
Michael Comella
439dfc5cb1
For #15644 : add comment for why we set the app theme in test.
4 years ago
Michael Comella
4a000ab4f9
For #15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella
690554b5c6
For #15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager
2c7789b1a8
Sets theme in FenixRobolectricTestApplication onCreate
4 years ago
ekager
4d348dd26a
Fixes existing lint errors
4 years ago
Gabriel Luong
665a71cbb0
For #15907 - Remove the usage of the TabTrayGridItemDecorator
4 years ago
ekager
508ec8b8ff
For #15347 - Adds telemetry for tabs settings
4 years ago
ekager
b6587455f8
fix detekt errors
4 years ago
Sebastian Kaspari
430282c8ec
Use new SearchEngineProvider interface.
4 years ago
Mozilla L10n Automation Bot
ce99cc9ccf
Import l10n.
4 years ago
Michael Comella
c6b83b10e0
For #15280 : suppress new lint rule in migration code.
4 years ago
ekager
e56043c485
For #15265 - Save cached top sites for metrics ping
4 years ago
ekager
cbe293d3e4
For #12062 - Launch back to browser if we previoulsy had tabs
4 years ago
Mozilla L10n Automation Bot
399c9c57fb
Import l10n.
4 years ago
ekager
7931d66c8e
For #15853 - Always set fontSizeFactor setting with new text scale
4 years ago
Mihai Adrian Carare
0e2657e262
For #14735 : Remove debug logs from release build. ( #15747 )
4 years ago
Mozilla L10n Automation Bot
2751da0372
Import l10n.
4 years ago
Gabriel Luong
ee5f678442
For #15777 - [Grid View] Set the height of the title to 30dp
4 years ago
Gabriel Luong
463f83a79a
For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
4 years ago
Mozilla L10n Automation Bot
83b5bae65e
Import l10n.
4 years ago
Mozilla L10n Automation Bot
25c9706cfd
Import l10n.
4 years ago
Grisha Kruglov
2030580fc8
Closes #15812 : Check for a null context during onScanResult
4 years ago
Mozilla L10n Automation Bot
d5bef99834
Import l10n.
4 years ago
Shen
45e3f7805b
For #13168 - Removed the close button from history navigation bar
4 years ago
Michael Comella
4179ab05bb
For #10069 - review: clarify init time for External...Activity.
4 years ago
Michael Comella
a1bbd2589e
For #10069 - review: change extra name to firstFramePreDrawNanos.
4 years ago
sraturi
8f16f9cb37
for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
4 years ago
mcarare
6516eff5c8
For #13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
4 years ago