Jonathan G Rennison
66289bbda4
Log packet size parse failures in NetworkTCPSocketHandler
3 years ago
Jonathan G Rennison
6d58115458
Net: Log sent and received game packets with type and status names
3 years ago
Jonathan G Rennison
7677d2d01a
Fix mishandling of PACKET_SERVER_MAP_BEGIN queuing at server
...
This could result in broken packet framing in the TCP stream
3 years ago
Jonathan G Rennison
7c706923f8
Fix a15e26f3: Leftover debugging statement
3 years ago
Jonathan G Rennison
31aec93cca
Fix leftover strings in Frisian language
3 years ago
Jonathan G Rennison
3ecda2b735
Fix handling of SlError when called from game thread
3 years ago
Jonathan G Rennison
a8157770df
Add fast path to vehicle var 0x42 if only upper byte is required
3 years ago
Jonathan G Rennison
aa0c1ba2e0
Only update vehicle image when in the vicinity of a viewport
...
This reduces the performance impact of expensive NewGRF
graphics chains.
3 years ago
Jonathan G Rennison
3e8ee4f49f
Remove "Disable vehicle image update" setting
3 years ago
Milek7
7ab6ab7400
Fix: missing <limits> include in network/core/packet.h ( #9123 )
...
(cherry picked from commit a341852cd5
)
3 years ago
Jonathan G Rennison
55915d8d55
Elide vehicle random trigger callbacks
3 years ago
Jonathan G Rennison
6ea97d6068
Viewport: Cache viewport areas for use in MarkAllViewportsDirty
3 years ago
Jonathan G Rennison
a15e26f369
NewGRF: Elide unmasked vehicle callbacks where possible
...
This includes:
* CBID_VEHICLE_32DAY_CALLBACK
* CBID_VEHICLE_REFIT_COST
* CBID_VEHICLE_MODIFY_PROPERTY
This is on a per-property basis
The main benefit of this is to avoid callbacks not handled by the
vehicle's current sprite group from using the full graphics chain as
the "default" branch in the callback switch.
In the case where the graphics chain is long/expensive, a lot of work
had to be done before a callback failure result was eventually returned.
3 years ago
Rubidium
7274432987
Fix #9267 , 47a99bb: [Squirrel] Heap use after free
...
Due to 47a99bb
the order of elements in the garbage collection chain has
changed causing the class to be finalised before the instances of that class.
Since the instance's array of member values depends on the size of the values
in the class, the class finalisation resetting that size to 0 causes not all
finalisations to run, which subsequently causes a heap use after free. So,
just set the SQObjectPtrs to 'null' during the finalisation of the SQClass
so the SQInstance can release all instance variables during its finalisation.
(cherry picked from commit 5c01f9ea52
)
See: #256
3 years ago
Jonathan G Rennison
8eb34b2f10
Do not attach temporary wagons to free wagon chains when autoreplacing
...
See: https://github.com/OpenTTD/OpenTTD/issues/9264
3 years ago
Jonathan G Rennison
f3e0507c54
Network: Include extra info in PACKET_CLIENT_ERROR packets
...
Log more details in server when PACKET_CLIENT_ERROR received
3 years ago
Jonathan G Rennison
e04218b528
Network: Log received packets at log level net=3
3 years ago
PeterN
66cac92028
Fix #9202 : Invalid test for unset NewGRF override mapping. ( #9226 )
...
(cherry picked from commit 3d9436bd75
)
3 years ago
Patric Stout
457b4f80b6
Fix 91b8ce07: dedicated servers could no longer create screenshots ( #9232 )
...
Although most commands are not useful on a dedicated server,
screenshot commands should be dequeued.
(cherry picked from commit 56050fc96f
)
3 years ago
PeterN
f52da3de3a
Codechange: Don't save unused NewGRF override mappings. ( #9202 )
...
(cherry picked from commit 69e5da0b54
)
3 years ago
William Davis
879de9781b
Change: Use gender-neutral pronouns in console command messages (and comments) ( #9203 )
...
(cherry picked from commit 881e1da51d
)
3 years ago
Jonathan G Rennison
088922b120
Fix poor performance of recursive iteration of group hierarchies
3 years ago
Jonathan G Rennison
2e28bc8e6a
Tracerestrict: Add engine class conditional
3 years ago
Jonathan G Rennison
892feb1665
Define __STDC_FORMAT_MACROS in stdafx.h
3 years ago
Jonathan G Rennison
19b99ee687
Fix 1ac0f186: Remove remaining use of CMAKE_PROJECT_VERSION_XXX
3 years ago
Jonathan G Rennison
59572fa415
Print message instead of asserting when route step sprite do not match
...
See: #255
3 years ago
Jonathan G Rennison
6c3ce55a0b
Version: Committing version data for tag: jgrpp-0.41.1
3 years ago
PeterN
1db19dd88c
Fix #9209 : Excessive time resizing highscore/news window when screen is too small. ( #9210 )
...
If the highscore/news window panel size, which is now scaled by GUI zoom, is larger than the screen size, a loop will be entered where the window is repeatedly resized.
This is resolved by removing the minimal size from the panel, as the window is always resized to cover the screen anyway. This means the screen size can never be too small.
(cherry picked from commit 8c3fa2a3bf
)
3 years ago
Peter Nelson
2b34256e51
Codechange: Slider widget used different range for drawing vs setting.
...
Using the same range for setting means that no workaround for setting the extremes is necessary.
(cherry picked from commit dd41de8931
)
3 years ago
Peter Nelson
b414060f7c
Codechange: Make GetCurrentRect() conform to usual Rect bounds, and reuse it.
...
Similar code is already repeated in other locations.
(cherry picked from commit d8e06e590a
)
3 years ago
Peter Nelson
065ae3964a
Codechange: Don't update window contents if scrollbar position has not moved.
...
(cherry picked from commit 52b16237ad
)
3 years ago
Peter Nelson
ad554d913f
Codechange: Set specific widgets dirty instead of window.
...
(cherry picked from commit 8321ef0061
)
3 years ago
embeddedt
0676c1f470
Fix: [Emscripten] Use non-XDG directories to simplify lolac storage ( #9207 )
...
(cherry picked from commit a879996012
)
3 years ago
Jonathan G Rennison
26992089d6
Fix use of _mm_cvtsi64_si128 which is not available on 32 bit x86
...
See: #254
3 years ago
Jonathan G Rennison
011b3b8b8d
Avoid data race on map size when clearing link graph jobs in InitializeGame
3 years ago
Jonathan G Rennison
9900adae70
Fix #254 : AdjustBrightnessOfTwoPixels used in 32bpp-sse2 but requires SSE3
3 years ago
rubidium42
9bfcea0397
Cleanup: [Fluidsynth] Comply better with the coding style
...
(cherry picked from commit a432009f06
)
3 years ago
Tyler Trahan
54deb7516c
Change: Use gender-neutral pronouns in english.txt ( #9189 )
...
(cherry picked from commit 176d65b472
)
3 years ago
glx22
8333323090
Codechange: Replace FOR_ALL_ROADTRAMTYPES with range-based for loops
...
(cherry picked from commit 2feb801e56
)
3 years ago
glx22
72cfb991e5
Codechange: Replace FOR_ALL_SEARCHPATHS with range-based for loops
...
(cherry picked from commit 983c7ade60
)
3 years ago
glx22
ffd30cf91b
Codechange: Replace FOR_ALL_TARS with range-based for loops
...
(cherry picked from commit 34215f7faa
)
3 years ago
rubidium42
e71798381b
Fix #9117 , 04ce1f07: [Fluidsynth] Infinite wait when stopping song ( #9181 )
...
In FluidSynth 2.2.0 an extra state was added to denote stopping. To transition
from this state to a stopped state the rendering needs to be running. Since
04ce1f07
locking was added that skipped the rendering when something else held
a lock, so the state would never get to stopped and join would never return.
(cherry picked from commit 6bd7f8816d
)
3 years ago
PeterN
0d1c848f78
Fix: Query windows may be partially drawn initially. ( #9184 )
...
Query window was not marked dirty after being moved on init. It was then marked dirty once the white border flash completed.
(cherry picked from commit 08781d96ed
)
3 years ago
PeterN
b36bfc7ab0
Fix #9174 : Don't update text effect if it has been reset. ( #9183 )
...
(cherry picked from commit 0bc6f32346
)
3 years ago
Milek7
deb2ad8997
Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour ( #9140 )
...
(cherry picked from commit 20762f9117
)
3 years ago
Peter Nelson
01d40812fa
Codechange: Validate custom station platform layout tiles are permitted values only.
...
(cherry picked from commit 756034fa27
)
3 years ago
Peter Nelson
da571d6481
Codechange: Use std::vector for NewGRF station tile sprite layouts.
...
(cherry picked from commit a3e49178d1
)
3 years ago
Peter Nelson
72bc8c7595
Codechange: Use std::vector for NewGRF station platform layouts.
...
This avoids the need to custom memory management and additional members.
This also resolves use-after-free if modifying copied layouts, so presumably nobody has ever done that.
(cherry picked from commit bd1a20f6ee
)
3 years ago
Michael Lutz
2e6cadb005
Fix #9147 : Delay making screenshots until the next draw tick as we may not access the video buffer from the game thread.
...
(cherry picked from commit 1f159f79de
)
3 years ago
Michael Lutz
1b46ef756e
Codechange: Generalise the delayed blitter change to a generic video driver command queue.
...
(cherry picked from commit 91b8ce073f
)
3 years ago