rubidium
e1eab15b84
(svn r9076) -Fix [FS#529]: the intercontinental airport used 'T-junction' runway sprites when there is no exit in the middle of the runway as in the city airport (skidd13).
2007-03-09 10:12:08 +00:00
truelight
ca375d573a
(svn r9070) -Fix [FS#404]: if bribe failed and you didn't pick up cargo yet, you wouldn't ever be able to do so for a given station
2007-03-08 20:50:27 +00:00
rubidium
36cea84b11
(svn r9068) -Codechange: capitalize the VEH_Train etc. enums to match the coding style (and rest of the code).
2007-03-08 16:27:54 +00:00
rubidium
979ccd45ba
(svn r9051) -Codechange: typedef [enum|struct] Y {} X; -> [enum|struct] X {};
2007-03-07 12:11:48 +00:00
rubidium
4169bfba06
(svn r9050) -Codechange: Foo(void) -> Foo()
2007-03-07 11:47:46 +00:00
belugas
5792aa85c7
(svn r8987) -Cleanup: doxygen changes. Again. Mostly (still) @files missing tags and (more than just) a few comments style.
2007-03-03 04:04:22 +00:00
richk
cd7b71092b
(svn r8978) -Feature: Rewrite of transfer system.
...
This major feature-fix keeps track of the value of transfers offloaded at a station, and hands on to a loading vehicle a credit note proportionate to the cargo loaded. The transferring vehicle is paid only for the distance it has travelled. eg. B-C in a transfer chain A-B-C-D.
When the final cargo is delivered, these credit notes are cashed, and the final vehicle is paid for A-D minus any credit notes it is carrying. The company bank balance increases by the value of the A-D route.
You still need to set up a profitable route; it is still easy to make a loss on transfers by bad planning. :)
2007-03-02 18:49:11 +00:00
tron
47b677abfe
(svn r8876) -Fix
...
Replace tests with magic numbers by a simple extraction template for command parameters
2007-02-24 09:42:39 +00:00
tron
ac75cf0ae1
(svn r8875) -Fix
...
Remove unnecessary EnsureNoVehicle() checks because they are
- pointless per se (f.e. there are no vehicles on house tiles)
- done again (f.e. using CMD_LANDSCAPE_CLEAR just a few lines later)
2007-02-24 06:46:20 +00:00
belugas
b1b5aecae9
(svn r8853) -Cleanup: doxygen changes. Correct forgotten c files to cpp files with the @file tag as well as a few general comments style
2007-02-23 01:48:53 +00:00
rubidium
a5697946d1
(svn r8852) -Fix (r8735): make the dynamite tool for drive through road stops as if it were removing a normal road tile (consider the local authority and such).
...
-Fix (r8735): remove drive through road stops on town owned roads when going bankrupt/being removed.
2007-02-23 00:17:46 +00:00
rubidium
3717774e0a
(svn r8851) -Fix [FS#643] (r8735): crash on removing town owned roads outside of the local authority.
2007-02-23 00:10:16 +00:00
tron
053e2ddda5
(svn r8841) -Fix
...
Remove {,u}intswap() and replace them by Swap()
2007-02-22 08:43:02 +00:00
tron
74fea81167
(svn r8833) -Fix
...
-Codechange: Split MakeRoadStop() into MakeRoadStop() and MakeDriveThroughRoadStop() for more clarity and less possibilities to use it incorrect
2007-02-21 19:46:37 +00:00
tron
7917738b54
(svn r8828) -Fix
...
-Regression (r7585): On load calculate the station rectangle for all savegames, not just savegames with at least version 27
2007-02-21 07:37:31 +00:00
peter1138
3d581f4f89
(svn r8826) -Codechange: Replace _cargoc's separate arrays with a regular struct array (with accessor) and implement new initialization method using cargo labels.
2007-02-20 22:09:21 +00:00
tron
27f48c5dda
(svn r8822) -Fix
...
Variable scope, const
2007-02-20 06:39:09 +00:00
rubidium
1d95385a97
(svn r8809) -Fix (r8715): accidentally removed a part of an expression.
2007-02-19 13:45:13 +00:00
tron
8db5c84f67
(svn r8800) -Fix
...
Simplify MoveGoodsToSation() under the assumption that 0 is less or equal than 0
2007-02-18 11:45:56 +00:00
tron
6c5b59b6ec
(svn r8799) -Fix
...
Reduce variable scope
2007-02-18 11:27:09 +00:00
rubidium
66ad0c7d0c
(svn r8797) -Fix (8741): the 'drive through station built on town owned road' bit was not set.
2007-02-18 11:14:55 +00:00
tron
38fedf20ce
(svn r8796) -Fix
...
Remove the unused function AllocateStation() which was left over from r8125
2007-02-18 09:00:34 +00:00
tron
25a3485e71
(svn r8794) -Fix
...
Remove the possiblity to take over stations with OWNER_NONE by building a station next to it
-Fix: It was possible to take over buoys by building a station next to them
Also remove the now unnecessary special case which prevented taking over oilrigs
NOTE: 0.5 candidate
2007-02-18 08:37:39 +00:00
tron
69bacedab9
(svn r8782) -Fix
...
Adapt GetClosestStationFromTile() more to the way it is used:
- All but deleted stations get filtered later, so do not include non-deleted station in the first place
- Remove the two parameters, which are the same for all callers
2007-02-17 15:59:33 +00:00
tron
97acc0ff25
(svn r8781) -Fix
...
A spectator cannot build stations, so do not include a special case for him
2007-02-17 15:34:05 +00:00
tron
e175a85e10
(svn r8779) -Fix
...
-Codechange: Use a more generic test, which tests the allowed aircraft instead of hardcoding the airport type numbers, to generate station names
2007-02-17 15:03:30 +00:00
tron
72857162dd
(svn r8767) -Fix
...
-Codechange: Do not hardcode the catchment radius of airports, but hold the information in AirportFTAClass
-Fix (r979): The default AI tested possible airport locations with a fixed catchment radius instead of the radius of the to be built airport
2007-02-17 07:45:18 +00:00
rubidium
c96f7c91e5
(svn r8765) -Codechange: remove logic redundancy by moving it from the gui into the cmd code.
2007-02-16 22:44:56 +00:00
tron
128caa5050
(svn r8755) -Fix
...
Abbreviate GetAirport(st->airport_type) to st->Airport()
2007-02-16 09:38:43 +00:00
rubidium
dcc7dd936e
(svn r8741) -Fix (r8735): make the saveguards of CmdBuildRoadStop more robust and add roadstops.grf to the list of required grfs.
2007-02-14 20:58:19 +00:00
rubidium
a2999dadc9
(svn r8735) -Feature: drive-through road stops made possible by the hard work of mart3p.
2007-02-14 16:37:16 +00:00
rubidium
b5dade8098
(svn r8715) -Codechange/cleanup: replace magic numbers related to state of road vehicles with enums. Original patch by mart3p.
2007-02-13 22:27:27 +00:00
celestar
72e74c29d4
(svn r8709) -Fix/Codechange: Rename the function GetStationPlatforms into GetPlatformLength because that is what it really does. Overload it because there is already a GetPlatformLength (one gives the length of the whole platform, the other gives the remaining length in a given direction). Turned both functions into methods of Station. While messing around with it, fix a problem where loading times for overhanging trains are miscomputed.
2007-02-13 16:36:38 +00:00
celestar
a89f2fd610
(svn r8707) -Codechange: Turn IsValidStation into a method of Station
2007-02-13 15:42:52 +00:00
celestar
82c696688c
(svn r8705) -Codechange: Increased the number of airport blocks to 64. This involves changing the enum of airport blocks to a static const uint64 as SOME platforms do not support 64-bit enums
2007-02-13 12:34:54 +00:00
rubidium
eb5648f382
(svn r8698) -Codechange: enumify the returns of VehicleEnterTile
2007-02-13 10:26:53 +00:00
rubidium
3f74dbe5c0
(svn r8694) -Codechange: make RoadStop's status accessible via accessor functions.
2007-02-13 00:25:42 +00:00
rubidium
39454ab61a
(svn r8635) -Fix: draw canal edges under buoys that are in a canal.
2007-02-08 14:04:02 +00:00
rubidium
61c796b825
(svn r8619) -Fix: store the ownership of a water tile in the buoy tile and set the ownership of the water tile when the buoy is removed. This solves the issue of removing ownership from canal tiles thus making is possible for other players to remove the canal tile.
2007-02-07 17:52:21 +00:00
KUDr
5198acfe22
(svn r8540) -Fix[YAPF]: Assert when buoy is placed on NE or NW map edge (Dan)
2007-02-02 20:20:56 +00:00
tron
dede093639
(svn r8539) -Fix
...
static
2007-02-02 19:09:54 +00:00
tron
097b12f998
(svn r8531) -Fix
...
Remove unnecessary pointer mumbo-jumbo from FindRoadStopSpot()
2007-02-02 08:23:48 +00:00
celestar
c95736046b
(svn r8528) -Codechange: Rename IsBuoy_() to IsBuoy() now that the naming conflict no longer exists.
2007-02-02 07:48:06 +00:00
celestar
4d0d6864ee
(svn r8514) -Codechange: Turn IsBuoy into a method of stations
2007-02-01 16:48:38 +00:00
Darkvater
a5228fd33c
(svn r8507) -Codechange/Feature: Don't remove player-owned property on-load in the scenario editor. Add a button to the landscape window to do this.
2007-02-01 12:51:10 +00:00
tron
fc9e84b04e
(svn r8499) -Fix
...
-Fix (?): When removing an oil rig replace the station tile by water, not bare land
2007-01-31 21:42:58 +00:00
tron
cb859f4a6a
(svn r8477) -Fix
...
-Codechange: Remove the unnecessary attributes Station::{bus,lorry}_tile_obsolete by replacing them with a scan of the map for existing road stops when loading old savegames
2007-01-31 06:25:46 +00:00
tron
1266624e88
(svn r8476) -Fix
...
Remove the unused remnants of {bus,truck}_stop_status_obsolete
(though I wonder a bit why this information doesn't get converted on load *shrug*)
2007-01-31 05:08:07 +00:00
tron
49fabae7a1
(svn r8475) -Fix
...
Remove the unused remnants of blocked_months_obsolete
2007-01-31 05:01:29 +00:00
tron
36d965a697
(svn r8474) -Fix
...
Turn GetPrimaryRoadStop() into a method of struct Station
2007-01-31 04:34:56 +00:00
tron
5a9873c3bd
(svn r8449) -Fix
...
-Codechange: Remove the superfluous attribute RoadStop::prev
2007-01-28 21:54:40 +00:00
KUDr
55ac8f843a
(svn r8414) -Codechange: Use own AutoPtrT instead of std::auto_ptr.
...
-Simplifies assignment from raw pointers
-Should be harder to crash the program by incorrect assignment into it.
-Should help with MorphOS compilation errors
2007-01-26 11:38:07 +00:00
celestar
2745180a50
(svn r8403) -Fix (r8402): Forgot to remove an enum
2007-01-25 11:11:43 +00:00
celestar
dfb5556376
(svn r8402) -Codechange: Move RoadStop-specific enums to the RoadStop class, and changed a one-member enum into a static const. Simplify their naming and add some doxygen-comments to RoadStop
2007-01-25 10:06:58 +00:00
tron
1da6c719fd
(svn r8400) -Fix
...
Simplify r8399
2007-01-25 07:11:06 +00:00
glx
1b48fd232f
(svn r8399) -Fix (r8185): a new road stop was always created in CmdBuildRoadStop(), but it was not deleted if DC_EXEC flag was not set or if the station creation failed
2007-01-25 01:29:24 +00:00
KUDr
f0e463ecca
(svn r8231) -Fix (r8125): MP desync caused by calling Random() from station constructor. This was wrong because station constructor is called also when loading savegame and when player tries to build station when it is not sure that it will succeed (thanks Rubidium)
2007-01-18 09:34:44 +00:00
tron
d80009c611
(svn r8212) -Fix
...
Remove the unnecessary attribute RoadStop::used. The same information can be derived from RoadStop::xy
2007-01-17 22:32:34 +00:00
tron
4ff9b8a2a7
(svn r8207) -Fix
...
Remove the write-only attribute RoadStop::station
2007-01-17 21:14:17 +00:00
peter1138
c6aeab5cb8
(svn r8186) -Fix (FS#557): Apply railtype offset to station graphics if no custom station is in use.
2007-01-17 12:57:35 +00:00
celestar
bdb9543f7c
(svn r8185) -Codechange: Equipped Roadstops with new/delete operators and gave them proper constructors/destructors (Thanks to KUDr for a nice interactive C++ lesson)
2007-01-17 11:15:51 +00:00
rubidium
f9c6f7d0a7
(svn r8161) -Fix (FS#555, r8144): enroute_from_xy was not set properly for old savegames.
2007-01-16 18:31:58 +00:00
peter1138
0e86608bf6
(svn r8153) -Codechange: Change UpdateStationAcceptance() and ShowRejectOrAcceptNews() to work with cargo IDs instead of cargo names, and explicitly list the different strings to use.
2007-01-16 11:13:00 +00:00
celestar
f69794b8c1
(svn r8144) -Fix: [FS#163] When a station is removed, vehicles do not get excessive payment any longer, as the origin TILE is now stored as long as the origin STATION for the transported cargos. Basically this is only a temporary fix until cargopackets are implemented, but it fixes one of the oldest known bugs (Special Thanks to Darkvater for lots of testing)
2007-01-15 14:42:24 +00:00
KUDr
97ee8287ab
(svn r8139) -Cleanup: simplify auto_ptr initialization (Tron)
2007-01-14 23:43:59 +00:00
rubidium
2352e76a8f
(svn r8137) -Fix (FS#551, r4259, r4320): roadstop->num_vehicles was wrong for savegames with version 24 or lower and do not calculate roadstop->num_vehicles when reading the roadstops as the vehicles might not be loaded at that moment.
2007-01-14 23:09:25 +00:00
KUDr
48c99c8174
(svn r8136) -Codechange: Station spread rectangle manipulators turned into StationRect::methods.
2007-01-14 23:02:12 +00:00
peter1138
ca9843424b
(svn r8128) -Codechange: Split sprite and palette remap into separate 32 bit values.
...
This lets us increase the sprite width from 14 to up to 29 bits,
effectively nulling the old sprite limit. Table changes in next commit.
2007-01-14 19:57:49 +00:00
KUDr
c04c2b2824
(svn r8127) -Fix (r8125): removed redundant free() call which is also in Station destructor (Tron)
2007-01-14 19:44:27 +00:00
KUDr
97993d279e
(svn r8126) -Fix (r8125): missing #include fixes compilation error on g++ (still some warnings, working on it)
2007-01-14 19:29:21 +00:00
KUDr
3ad14cc7a8
(svn r8125) -Codechange: Station is now constructed/destroyed using new/delete operators (don't worry, they still use the same memory pool). Few station related functions turned into Station::methods (just first step). All this new stuff moved from station_cmd.cpp to the new file (station.cpp).
2007-01-14 19:18:50 +00:00
peter1138
b4dbfe5e59
(svn r8120) -Fix (r8055): Station cargo waiting value clamp should be signed not unsigned. This resulted in cargo magically appearing...
2007-01-14 18:38:40 +00:00
KUDr
28e969924b
(svn r8066) - Codechange: MallocT(), CallocT(), ReallocT() now return the pointer to allocated memory instead of modifying the pointer given as parameter
2007-01-11 17:29:39 +00:00
celestar
08de6b082a
(svn r8055) -Codechange: Replace the different max, dmax, maxu whatever macros by a simple template function max(), that requires two arguments of the same type. While I'm at it change a variable called "max" to "maxval" in a function that calls max().
2007-01-11 11:05:01 +00:00
rubidium
a7d0cdf95f
(svn r8038) -Merge: the cpp branch. Effort of KUDr, Celestar, glx, Smoovius, stillunknown and pv2b.
2007-01-10 18:56:51 +00:00
KUDr
07c30785ab
(svn r8033) [cpp] - Prepare for merge from branches/cpp (all .c files renamed to .cpp)
2007-01-10 18:12:09 +00:00