Commit Graph

56815 Commits (00a0853550274b158c40ff8945aad758a70363fa)
 

Author SHA1 Message Date
Jonathan G Rennison b10a22218f Window crash log: Reduce sensitivity of stack infinite loop detection
Only trigger if 8 previous frames are the same, not only 1
7 months ago
Jonathan G Rennison a38c2a19a1 Uniscribe: Add defensive checks to UniscribeParagraphLayout::NextLine 7 months ago
Peter Nelson 6f35f3274f
Fix ab1a4c6c: Crash if the "No Music" set is loaded because there is no current set_index. (#11511)
Add a helper function to get the current set_index which which checks it is in range.
7 months ago
rubidium42 27082f9efa Codechange: pass std::string references to OpenBrowser 7 months ago
Jonathan G Rennison 8437b20fed Fix: Deleting towns did not check for waypoints referencing the town 7 months ago
Peter Nelson 7b0afec11f Codechange: Use max_element to find highest cargo amount. 7 months ago
Peter Nelson 3f853d8003 Codechange: Use range-for to simplify getting first non-zero value.
This reduces indexed array access.
7 months ago
Jonathan G Rennison 944b2901dd Disallow deleting towns which are referenced by a waypoint
See: #614
7 months ago
Tyler Trahan 4181d3c1ff Codechange: Don't use a magic number for the number of DiagDirections 7 months ago
Tyler Trahan 2dad9263d7 Doc: Add, fix, and clean up documentation inside town_cmd.cpp 7 months ago
Tyler Trahan 745945c4d3 Codechange: Be consistent with how we name common parameters
TileIndex is always tile and Town is always *t. Don't use t and *town.
7 months ago
Tyler Trahan 1b14eca9d9 Codechange: Rename TryClearTile() for clarity
The function does not execute the clearing action.
7 months ago
Tyler Trahan a98fe9f317 Codechange: Rename MakeTownHouseBigger() for clarity 7 months ago
Tyler Trahan 060672428d Codechange: Merge confusingly-named helper functions into their timer 7 months ago
Tyler Trahan 1f41e773d6 Codechange: Use consistent name for bay road stops
As of #10494, this is how we describe original dead-end road stops.
7 months ago
translators 5f442c9127 Update: Translations from eints
english (us): 1 change by 2TallTyler
7 months ago
Peter Nelson 519fe33175
Fix ab1a4c6c: Changing baseset/playlist while shuffle is on does not change song. (#11510)
The change-playlist function relied on toggling shuffle to restart playing which is no longer the case, so always handle it when changing playlist instead.
7 months ago
Peter Nelson e3924f3231
Fix #10811: Allow dragging vehicle in depot to any free row. (#11508) 7 months ago
Peter Nelson e6d132d24b
Fix #10926: New free wagons no longer split by type. (#11507)
NormalizeTrainVehInDepot() should only be called if an engine was built, not for wagons.
7 months ago
Peter Nelson 3df7d1aff9
Codechange: Template input buffer type in audio mixer. (#11505)
This reduces code duplication.
7 months ago
Peter Nelson e5aed24395
Codechange: Use std::array for industry tile cargo acceptance. (#11498)
This avoids use of memcpy/memset to copy or fill.
7 months ago
Peter Nelson f268c90bd3
Change: Use sparse padding for content download window. (#11501) 7 months ago
Peter Nelson ab1a4c6c80 Change: Don't restart playback when toggling playlist shuffle.
Instead update the selected playlist entry for the current song.
7 months ago
Peter Nelson 6c91c4b99d Fix: Invalidate playlist window when (un)shuffling playlist. 7 months ago
Peter Nelson 4c6ccb5248
Change: Try stopping extmidi player with SIGINT first. (#11404)
This may give the player a chance to issue MIDI note-off commands.

The kill/waitpid cycle is also less aggressive, waiting 50ms each time.
7 months ago
Richard Wheeler a856fbeca9
Fix: Incorrect mask files for NE river slopes (#11503) 7 months ago
Peter Nelson e3622da408
Fix #11500: Rename Textfile GUI's LinkType to HyperlinkType. (#11502)
This disambiguates it with LinkType in league tables.
7 months ago
Richard Wheeler 2b92577f5c Fix: Add shading to river slopes
Adds a 32bpp shading to the river rapids/slopes to make them more visible. Requires a bump of original graphics grfs to use container version 2. Fixes #9031
7 months ago
Peter Nelson 46098449b6
Fix 7cfcf65: cargo_filter_criteria is now a CargoID instead of a index. (#11497) 7 months ago
Jonathan G Rennison 977758b9ca Version: Committing version data for tag: jgrpp-0.56.0 7 months ago
Peter Nelson 7bee955a4b
Change: Set height of larger heightmap/scenario worldgen buttons by text height. (#11496)
This allows the button height to scale properly by font size.
7 months ago
Jonathan G Rennison ca23e31986 Add railtype variable for adjacent crossing information 7 months ago
Peter Nelson 872fdcbbab
Change: When building NewGRFs, use grfid (from grfcodec) to calculate NewGRF MD5 hash. (#11492)
This allows for v2 container NewGRFs to be created. Hashes are needed for building the baseset metadata, so the .hash files are stored the source tree so they can be built if grfcodec and grfid are not present.

The hash of openttd.grf is not actually needed, but it is simpler to leave it in than handle only orig_extra.grf.
7 months ago
Jonathan G Rennison a3371fccc6 Remove Cheats/ExtraCheats distinction
It is not necessary as there is no longer a need to preserve
the size/order of struct Cheats
7 months ago
Jonathan G Rennison c5a292c0df
Fix #11493: Incorrect flow values in LinkGraphJob::EdgeAnnotation (#11494) 7 months ago
translators c6b9227dbb Update: Translations from eints 7 months ago
Tyler Trahan 3902acb13d Codechange: Define a TickCounter variable type for TimerGameTick::counter 7 months ago
Tyler Trahan d28caa3ced Codechange: Use ticks for timetable start date 7 months ago
Peter Nelson bc1d49ebf4 Codechange: Add missing `ar` from `Toolb`. 7 months ago
Peter Nelson 5489b9fc0c Codechange: Undo #11447, drop down list divider lines are now explicit. 7 months ago
Peter Nelson 667be98ce8 Codechange: List toolbar menu items and dividers explicitly.
This makes it clearer what items will be shown in the list, allows for non-consecutive
string IDs, and means unused enum values are not necessary.
7 months ago
Jonathan G Rennison 7d65fbd6e8 Link graph: Fix incorrect job start/join dates when loading upstream saves 7 months ago
Jonathan G Rennison acc54fabfe Link graph: Fix last_compression adjustments for link graph jobs 7 months ago
Jonathan G Rennison 4874381943 Link graph: Fix date shifting after max year 7 months ago
Jonathan G Rennison b03064e55b Fix IniLoadSettings 7 months ago
Jonathan G Rennison 21b49a213e Merge branch 'master' into jgrpp
# Conflicts:
#	src/cheat_gui.cpp
#	src/main_gui.cpp
#	src/network/network_gui.cpp
#	src/saveload/saveload.h
#	src/smallmap_gui.cpp
#	src/station_cmd.cpp
#	src/timetable_cmd.cpp
#	src/toolbar_gui.cpp
#	src/widget.cpp
#	src/widget_type.h
#	src/widgets/dropdown_type.h
7 months ago
Peter Nelson 7fb369c732 Fix: extmidi did not move on to next song after playing ends. (#11469)
`song` is no longer a C-style string so cannot be cleared by writing a NUL char.
Use `.clear()` to properly clear a std::string.

(cherry picked from commit 08778094f4)
7 months ago
Peter Nelson 96d4538055 Fix #11437: Flipped shorter rail vehicles disappear in windows. (#11446)
Mixed signed/unsigned strikes again, causing an incorrect sprite offset for shortened vehicles.

(cherry picked from commit 43aa91a7f5)
7 months ago
Peter Nelson 480e03360b Fix #9545: Crash when all cargo types are disabled. (#11432)
This is not a very useful state, but it's nice to not crash.

Some parts of the game don't (yet) check for cargo types being redefined, that is out-of-scope here.

(cherry picked from commit bbd64bbe2b)
7 months ago
Patric Stout 0b226865d5 Fix cda6f24f: don't ignore binary-dir if it happens to be working-dir (#11431)
Some of our code ignores the SP_WORKING_DIR for some actions, which
means that if, for example, your SP_BINARY_DIR is the same as your
SP_WORKING_DIR, neither is scanned.

Instead, only add SP_WORKING_DIR if it is unique.

(cherry picked from commit c059ce0c97)
7 months ago