8dcd6a7faf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 : Optimize wallpaper testing images.
3 years ago
a9360bb98a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22561 : Fix tab group titles colour when in private mode
3 years ago
afddd6ec32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22415 : Remove element type from content descriptions.
...
Adding the type to content description is not advised according to a11y guidelines.
3 years ago
fb8b281431
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/22777 - Replace about_link_normal_theme with fx_mobile_text_color_action"
...
This reverts commit 18d66ce1e3e246a4c190e03ca07cf85937e1047c.
3 years ago
e88bda15df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18160 : Show a prompt when trying to leave private browsing with active downloads ( https://github.com/mozilla-mobile/fenix/pull/22912 )
...
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
4a8c0d59cc
[fenix] Import l10n.
3 years ago
c367072d11
[fenix] Refactor History types to eliminate nullability
...
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.
With this refactor, we entirely eliminate nullability from these types.
3 years ago
b13e149900
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22764 : Convert History.id to an Int position
...
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.
This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
ae7909671e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22852 - Add a new "Storage access" permission
3 years ago
9e15247269
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22931 Only enable wallpapers on normal mode
3 years ago
4e6406e15e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20513 : Use UrlMetricType for search engine submission url.
3 years ago
1735a245c0
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22736 : Do not remove focus from toolbar when scrolling
3 years ago
5143063813
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 toggle wallpapers when tap on the Firefox logo
3 years ago
de1e52a234
[fenix] Add default topsite MeiTuan for MozillaOnline builds
3 years ago
f110c8eca9
[fenix] Import l10n.
3 years ago
574136432c
[fenix] Import l10n.
3 years ago
dad42ce9a1
[fenix] Import l10n.
3 years ago
1c898c756c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22889 : add bottom spacer to onboarding adapter
3 years ago
0244f2156f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22508 - Increase menu height to avoid it become scrollable
...
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
3 years ago
11417996c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22671 : Show correct time groups header in history
3 years ago
4cd7064540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22450 : Replace quit icon with AC one.
3 years ago
67f56b7031
[fenix] Import l10n.
3 years ago
6b7cdce783
[fenix] Fix breaking change in KeyProvider
...
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
3 years ago
4ad2c1c592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22569 : Remove allopen plugin and Mockable annotations
3 years ago
803549e11f
[fenix] Modify strings for Privacy notice for MozillaOnline builds
3 years ago
6a54899d0c
[fenix] Import l10n.
3 years ago
6f331743d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22858 - Set all @color/tab_tray_item_media_stroke usages to @color/photonWhite
3 years ago
817760d64c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/20833 : move home recycler bottom margin into standalone item
3 years ago
816677db45
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22842 - Use gradient color tokens for Reader mode gradient
3 years ago
a9a26965ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22836 - Replace primary_text_private_theme with fx_mobile_private_text_color_primary color token
3 years ago
d8bee937cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22832 - Added parameters to base Text composables
3 years ago
49444cfdf7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 add wallpapers feature flag
3 years ago
85d4b025a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove unused tabTrayHeadingIcon and tabTrayHeadingIconInactive attributes
3 years ago
f0638c8294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove @color/tab_tray_heading_icon_inactive_dark_theme redirection
3 years ago
e2c76c0ad2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove @color/tab_tray_heading_icon_dark_theme redirection
3 years ago
fc74ae29e8
[fenix] Import l10n.
3 years ago
8ecbffef61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22808 - Add private theme design tokens
3 years ago
8b0a49c9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22809 - Use the design tokens for the Scrim Start/End colors
3 years ago
57b78972f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22812 - Remove unused shadow attribute
3 years ago
949545d88a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayToolbarBackground attribute
3 years ago
bbafc879ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayItemSelectedBackground attribute
3 years ago
0364ad33e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayItemBackground attribute
3 years ago
64157037c5
[fenix] Import l10n.
3 years ago
267118527e
[fenix] Import l10n.
3 years ago
7f1918bd32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Update the colors for Scrim Start/End design tokens
3 years ago
7c9e44b61d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Swap the colors for Gradient Start/End design tokens
3 years ago
eecb775f83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Add Icon Gradient Start/End color tokens
3 years ago
e0d4f0b496
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Rename fx_mobile_icon_color_notice color token to fx_mobile_icon_color_information
3 years ago
4b6a1d2256
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/22688 : remove inactive_tabs_recently_closed probe
3 years ago
861609816d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22777 - Replace about_link_normal_theme with fx_mobile_text_color_action
3 years ago
257c8a0f13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22779 - Remove @color/inset_light_theme redirection
3 years ago
7b2460a2e5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22784 : Show collection snackbar only if fragment is still attached.
3 years ago
01c4bf049a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17130 : Replace hardcoded strings with string resources.
3 years ago
9d53193299
[fenix] Import l10n.
3 years ago
37ec88478e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9294 : Add option to clear current site data in quick settings dialog.
3 years ago
433ae3f6c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22694 - Remove primary_text_dark_theme usage
3 years ago
4b3e25dcf6
[fenix] Update Android Components version to 97.0.20211208143435.
3 years ago
ab220e2995
[fenix] Import l10n.
3 years ago
4d889b852a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22757 : Check the parent cast to AbstractBrowserTrayList first
...
We re-use the same ViewHolders in search term groups, so when we need to
cast to a AbstractBrowserTrayList for tab reordering, we need to check
our parent correctly first.
3 years ago
f32aab496e
[fenix] Support tab movement/reordering ( https://github.com/mozilla-mobile/fenix/pull/22751 )
...
* Adds basic support for tab reordering via drag-and-drop selected tabs
* ktlint/detekt formatting
* Use defaultTabsFilter (now not private) instead of getter
* Convert from position+filter API to target+placeAfter
Unfortunately I still need the filter passed around a bit
* Handle inactive tabs' holder being children of the RecyclerView of the normal tabs
Don't go through LayoutManager needlessly
* Non-working use tabID the whole way. Does not compile.
* Fix to do direct tab ID and use grid setting directly
* Remove non-null assertion. Now fully works for "other" tabs.
* Prevent grouped tabs from being dragged
* Remove unused import
* Add/fix comments
* Do API version check and use deprecated startDrag if too old.
* Build process fails: both outdated and too new, so reverting to just too new
* Use deprecated function and suppress warning
* fix space
* Suppress "TooManyFunctions" on DefaultTabsTrayController
* Repeatedly update tab movement during drag
* Remove multi-tab movement, only allow dragging if tab groups disabled, fix tab positioning during movement
I'm forced to suppress LongParameterList to get the settings information where it needs to go though
* Remove settings argument and corresponding long args suppression: instead get settings from parent AbstractBrowserTrayList's context
* New UI: Select a tab and then, while holding down, start dragging
* Revert to using before/after boolean to accomodate delays
Move drag transparency to start of drag
* Use new BlankDragShadowBuilder and DraggableItemAnimator to handle tab movement
* Replace Pair<>s with data classes
* Only drag if exactly 1 tab selected, don't consume drag event if not used
* Auto-scroll tab tray while dragging near top/bottom edge
* Remove unexpected scrolling on tab bind (triggered when tab is selected)
* Fix broken scroll behavior during dragging
* Cleanup for ktlint/detekt
* Constantly set elevation during drag in case of update
Clean code at drag start
* Add custom drag start behavior
* Add drag distance constant, do all touch-drag behavior in OnTouchListener
* Disable parent vertical scrolling on drag start, fix detekt ComplexCondition
* Minor cleanup/comments
* Revert removal of scroll on bind, this was related to something different
* Correction to prepareForDrop to match documentation- doesn't seem to have any effect
* Simplify via unchecked typecast, use ViewCompat
* Use ViewConfiguration.scaledTouchSlop instead of arbitrary 30px
* Added tabReorderingFeature flag, split drag interactor to separate function to satisfy complexity requirement
Co-authored-by: Steven Knipe <ssk97@case.edu>
Co-authored-by: ssk97 <knipesteven@gmail.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
5daf8934ca
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21759 : Do not render home fragment when launching to tab
...
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
43c3c127aa
[fenix] Import l10n.
3 years ago
4a932557ec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22741 - Remove all unused strings marked moz:removedIn <= 94
3 years ago
6b9dc4c958
[fenix] Introduce timeout for capturing thumbnail in BrowserAnimator
3 years ago
9150d8061b
[fenix] Prevent flash when navigating to home
3 years ago
57f46aa08e
[fenix] Fix BrowserRobot.goToHomescreen to wait for home screen to be rendered
...
It was previously just waiting for the application to be idle, which
is not a reliable check in case the navigation to home is triggered
on completion of an async operation i.e., the app / main thread may
be idle, but the navigation to home hasn't completed yet.
goToHomeScreen further needs to wait for the browser fragment's
home button to exist before clicking it.
3 years ago
bc4f92afd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22445 - Improve the scrolling behavior for Recently visited
...
One important issue was that the items are smaller that the width of the
screen and so a bit of the next column would be showing also and user could
interact with this only peaking items and a long press would open a dropdown
menu with no place to anchor it.
To mitigate this:
- the items will now snap to the next position when scrolling so that we'll
always show at least one column in it's entirety.
- menus are enabled only if more than half of the item is visible effectively
disabling clicks on that peaking area of neighbour columns.
This patch also updates the divider for history groups which previously wasn't
showing.
3 years ago
96b41c0003
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22729 - Tag unused strings for removal
3 years ago
edd33f2685
[fenix] [UI Smoke Tests] New undoDeleteBookmarkFolderTest UI test and Improve coverage for deleteNonEmptyBookmarkFolderTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22587 )
...
* New undoDeleteBookmarkFolderTest smoke UI test
* Improve coverage for deleteNonEmptyBookmarkFolderTest UI smoke test
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
87203e4afb
[fenix] Import l10n.
3 years ago
206074a45e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22702 - Replace home_show_all_button_text with fx_mobile_text_color_action color token
3 years ago
c467be006e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22725 - Regenerate lint-baselint.xml
3 years ago
e7f3dd478a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22701 - Replace whats_new_notification_color with fx_mobile_icon_color_notice color token
3 years ago
2400e44396
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22712 - Remove unused menuCategoryText attribute
3 years ago
2989b4385d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22696 - Remove unused tab_header.xml resource
3 years ago
2c3f13900f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22708 - Remove unused syncedTabsSeparator attribute
3 years ago
202b3bf08f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22495 - Disable inactive tabs survey
3 years ago
7ee3adbe81
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22698 - Remove unused mozac_browser_menu_item_switch.xml resource
3 years ago
519b761344
[fenix] Import l10n.
3 years ago
106b8a60ec
[fenix] Import l10n.
3 years ago
196ccab368
[fenix] Import l10n.
3 years ago
563c1f8610
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22691 - Add Composables for Primary and Secondary text
3 years ago
ab52526074
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22676 - Replace top_site_title_text with fx_mobile_text_color_primary color token
3 years ago
a776cabd2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 : Add testETPOffGlobally UI smoke test
3 years ago
9c7e54ea87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22654 - Add new color tokens provided by the design systems to colors.xml
3 years ago
175a230b50
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22637 - Add new color tokens provided by the mobile styles to FirefoxTheme
3 years ago
a1b0dd184a
[fenix] Import l10n.
3 years ago
a13e904d34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22516 - Fixed alignment of "Show all" buttons on the homescreen ( https://github.com/mozilla-mobile/fenix/pull/22650 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22516 - Fixed show all button alignment with section headers on the Homepage
* For https://github.com/mozilla-mobile/fenix/issues/22516 - Added correct content description back in for recently visited show all button
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
33e5a1ee35
[fenix] Refactor: Move historymetadata classes in separate package
3 years ago
5959b0a309
[fenix] Refactor recently closed tabs UI smoke tests
3 years ago
c9a18b8b03
[fenix] Move verifyRecentlyClosedTabsListTest UI test from SmokeTest class
3 years ago
771d143c12
[fenix] Disable failing verifyUndoSnackBarTest UI test
3 years ago
e76776647c
[fenix] Android Autofill: Enable keyboard inline autofill suggestions
3 years ago
9534fa2356
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20701 : Dismiss keyboard when scrolling home screen
3 years ago
313a3a6504
[fenix] Import l10n.
3 years ago
892989f0dd
[fenix] Add distribution_id into first session ping
3 years ago
3de1b505c2
[fenix] Import l10n.
3 years ago
7b54536a7e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22592 - Refactor hideOnboardingIfNeeded() calls when the home menu items are tapped
3 years ago
f70dfb6ef9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22534 - Show history highlights and groups in "Recently visited" ( https://github.com/mozilla-mobile/fenix/pull/22535 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update homescreen section name to "Recently visited"
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Show both history highlights and groups in Recently visited
For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.
Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.
A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Rename and refactor historymetadata to recentvisits
The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update UI tests to account for the new items space on the screen
Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.
Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
97e59a9717
[fenix] Tab group count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22479 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Refactored tab sorter metrics into a middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created distribution metric for tab group sizes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created tests for tabs tray middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Merge fixes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added PR number to metric
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added missing line to middleware to have the Store process actions
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Updated metric expiration to December
* For https://github.com/mozilla-mobile/fenix/issues/22410 - PR Feedback
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Removed else from middleware when
3 years ago
be8dce555b
[fenix] Import l10n.
3 years ago
6f49599ea3
[fenix] Import l10n.
3 years ago
c7aea80bb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22595 - Remove unused OnboardingAutomaticSignInViewHolder
3 years ago
f1a4296eb6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22552 : Optimize PNGs with ImageOptim
3 years ago
5b069b2ece
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22211 - Use Hero images for Recent Bookmarks
3 years ago
72a0b5703c
[fenix] Update Android Components version to 96.0.20211125162700.
3 years ago
4cc4e1c67d
[fenix] Improve loading URLs
3 years ago
798c9bc294
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22580 : Track APK size in perfherder
3 years ago
a65a9591b8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731 : Disable suspending of engine sessions under memory pressure in Nightly
3 years ago
e665397890
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display individual tab if part of the Jump back in tabs group
...
We'll show as a recent tab the next most recent tab not part of the last active
search group.
3 years ago
3dea07855e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display history group if already in Jump back in
3 years ago
c09104308d
[fenix] New text search UI smoke tests
3 years ago
364119deea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22502 - Keep the previous string resource until safe to remove
...
See https://github.com/mozilla-mobile/fenix/issues/20871
3 years ago
369af67f41
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22321 : Add temporary protoc version workaround for M1 Macbooks
3 years ago
6b5ce4d387
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22488 - Fix intermittent test failure with InactiveTabsControllerTest
3 years ago
100d5372ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose
3 years ago
f2e74f31f8
[fenix] Improve expand/collapse collection UI test coverage
3 years ago
62560b4d5c
[fenix] Improve collection deletion UI coverage
3 years ago
ca22bb6ceb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22499 : Emit search group disband action on history group removal
...
This is needed to prevent removed search groups from coming back after
user interacts with the tab. E.g. if we don't fire this action, upon
interaction with the tab after a corresponding search group was removed
we will end up creating metadat with the deleted 'searchTerms' (they'll
be read from the 'historyMetadata' state on the tab).
At this point we probably want to start encapsulating all of this in a
use case - let's do that separately in
https://github.com/mozilla-mobile/android-components/issues/11309 , and
just fix the bug for now.
3 years ago
bb36ddee12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 : improves the share tabs smoke tests coverage
3 years ago
b764027bc0
[fenix] Import l10n.
3 years ago
1284096722
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/22537 crash: BookmarkFragment is attached to a context
3 years ago
5737a5533c
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/5298 the same page appears in the History section multiple times
3 years ago
86f80f2652
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22502 - Update "Jump back in" group's subtitle format
3 years ago
5183cd3c4d
[fenix] Import l10n.
3 years ago
748f15bc2d
[fenix] Import l10n.
3 years ago
201663cff1
[fenix] Improve privateTabsTrayWithOpenedTabTest UI test coverage
3 years ago
69d2664705
[fenix] Improve verifyOpenTabDetails UI test coverage
3 years ago
b9211621ed
[fenix] Refactor and improve coverage for empty tabs tray UI tests
3 years ago
ccfa34edcf
[fenix] Import l10n.
3 years ago
78e85949cf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22484 - Track direct loads per tab; fix search term lookup
...
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
uniformally to all tabs, even though it's actually an event which
happens for a specific tab. This lead to background tabs (pages opened as new tab)
setting the direct load flag, and then a simultaneously loading
parent tab would incorrectly interpret that flag for itself.
The patch switches this tracking from a simple boolean (are we direct
loading?) to a set of tab IDs that are currently direct loading.
2) In a case when a background tab was loading with a parent who's
search terms were cleared by a direct load, we were not trying to
lookup search terms on the background tab's historyMetadata key,
which exists to capture search terms for this exact scenario.
The patch adds an additional fallback lookup for that path.
3 years ago
6ca9c5a17b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21002 : add missing steps to selectSearchEnginesShortcutTest, addPredefinedSearchEngineTest
3 years ago
77f35fd757
[fenix] Post: move group removal logic into PagedHistoryProvider
...
This moves the group removal logic to the place where the groups are
actually formed. This helps clean-up the fragment code a bit, and
removes the awkward 'allow mutate some random internal state' API from
the provider.
3 years ago
fc7e707538
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22472 : Filter out redirects from History search groups
3 years ago
283f938184
[fenix] Improve mainMenuAddToHomeScreenTest UI test coverage
3 years ago
5d10398f55
[fenix] startOnLastTab UI smoke test
3 years ago
7662078764
[fenix] recentBookmarksOption UI smoke test
3 years ago
a5d2e8ee47
[fenix] jumpBackInOption UI smoke test
3 years ago
daa348bb2d
[fenix] startOnHomepageTest refactoring work
3 years ago
5986c6b7b9
[fenix] Import l10n.
3 years ago
d61fd5de0e
[fenix] Update lastAccess timestamp of selected tab when launching to home
3 years ago
627bc919d1
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22402 : Add top placeholder for home
3 years ago
bfc035e0c2
[fenix] MR2 Telemetry: Homescreen view count ( https://github.com/mozilla-mobile/fenix/pull/22377 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22146 - Added counter for home screen views
* For https://github.com/mozilla-mobile/fenix/issues/22146 - Added PR number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
ba3138ccf9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Store inactive tabs count telemetry when user opens tabs tray
...
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
31f98688a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22147 - New search term groups telemetry
3 years ago
8722950d3b
[fenix] Improve homeThreeDotMenuItemsTest UI test coverage
3 years ago
9062e9dfdb
[fenix] Import l10n.
3 years ago
ad8f060cec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22271 Improve URL accessing from the clipboard for Android 12 and above.
3 years ago
7c1b9b909f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22388 - Update content description of the delete button
3 years ago
b739e6c511
[fenix] Import l10n.
3 years ago
ef1ae5fe11
[fenix] Import l10n.
3 years ago
b215f9c585
[fenix] No issue: creates new SmokeTest annotation.
...
Updates smoke tests list according to the ones in TestRail.
3 years ago
3f7c3ddf6c
[fenix] Import l10n.
3 years ago
1d02011196
[fenix] MR2 Telemetry: Opening screen preference ( https://github.com/mozilla-mobile/fenix/pull/22333 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22145 - Added telemetry to the opening screen preference.
* For https://github.com/mozilla-mobile/fenix/issues/22145 - Added PR number to metric
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
114f1347d9
[fenix] MR2 telemetry - Inactive tabs CFR ( https://github.com/mozilla-mobile/fenix/pull/22301 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22298 - Added telemetry to inactive tabs CFR
* For https://github.com/mozilla-mobile/fenix/issues/22298 - added PR issue number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
a08fcc9a9d
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22223 : Move to the selected page when switching modes
3 years ago
05e56a97a1
[fenix] Import l10n.
3 years ago
6f1ba6ca6b
[fenix] No issue: clean up code duplication in PagedHistoryProvider
3 years ago
ee76b930bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22256 re-enable editCustomSearchEngineTest UI test
3 years ago
a8bce7b4f8
[fenix] Make findDuplicate() suspend
...
findLoginToUpdate() should be suspend, but I didn't get mark it that way
on the initial logins work. Let's make this one suspend, then I can
update findLoginToUpdate() in a-c.
3 years ago
31a6d88939
[fenix] Import l10n.
3 years ago
7222c0220c
[fenix] No issue: Correct TabsTrayAction naming
3 years ago
199547f94f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Use TabsTrayStore for populating adapters
3 years ago
35556e4cc2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Add tab state into the TabsTrayStore
3 years ago
e24a305ba0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21084 : put git hash on About screen in release builds.
3 years ago
d8dab150ad
[fenix] Improve verifyEmptyTabTray Ui test coverage
3 years ago
b95234f9d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
f40c19f406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
3ae30a8446
[fenix] Import l10n.
3 years ago
3fc31d036b
[fenix] No issue: rename test resource file that was causing issues on Windows
3 years ago
03ddd32bb1
[fenix] Import l10n.
3 years ago
4d092c3a82
[fenix] Import l10n.
3 years ago
77892a785c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21816 : Filename in "Open" PDF dialog overflows screen
...
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
3 years ago
07636be02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22342 : Make layout constraint for 'recent bookmarks' the same as other sections
3 years ago
6aa2f0c4fa
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
7d11384733
[fenix] Import l10n.
3 years ago
ad076dd1c2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22299 : Add history search term group telemetry
3 years ago
31c2c7bf12
[fenix] No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
422a8e2a67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22304 & https://github.com/mozilla-mobile/fenix/issues/22256 : Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests
3 years ago
f1814afed2
[fenix] Import l10n.
3 years ago
67665ee689
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : add SearchDialogFragmentConstraintLayout; has markers.
...
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
3 years ago
7936660a8c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : change onMeasure/onLayout markers into a single track + draw.
...
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
3 years ago
a93ac9edc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22177 : rename RootLinearLayout -> HomeActivityRoot...
...
This is so we can be more specific with the detail text in our markers.
3 years ago
3424aac1a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Renew product telemetry expiring in December ( https://github.com/mozilla-mobile/fenix/pull/21316 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Product telemetry renewals for December
* For https://github.com/mozilla-mobile/fenix/issues/21313 : Data review for december product telemetry renewals
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
6ed1cb0c8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Remove expiring/unused metrics for December ( https://github.com/mozilla-mobile/fenix/pull/21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
dbceb279f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21659 : Add SERPs to history search groups
3 years ago
cbfc23f8cc
[fenix] Recent bookmark count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22293 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added event to track the count of recent bookmarks
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b1cb88fff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22078 Selecting search group in Jump back in switches active tab
3 years ago
008e453d6a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22281 Fix studies opt out learn more link
3 years ago
6d8071ccc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection
3 years ago
03cbf9f624
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/accent_dark_theme redirection
3 years ago
e0b7131f5c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/foundation_dark_theme redirection
3 years ago
113a1bc009
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection
3 years ago
621f5a58d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection
3 years ago
a1a3a13acb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection
3 years ago
42a72ab0e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection
3 years ago
788a8f16f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_media_background_dark_them redirection
3 years ago
94852bedb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_divider_dark_theme redirection
3 years ago
bd95bec9c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection
3 years ago
f0a4f3d8d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_background_dark_theme redirection
3 years ago
ab4aeaeb92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_url_dark_theme redirection
3 years ago
111cfabafa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_tray_item_text_dark_theme redirection
3 years ago
8579079774
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22213 : add marker for LayoutInflater.inflate.
...
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
3 years ago
9fb7471f61
[fenix] No issue: Address tracking protection exceptions breaking changes
3 years ago
a599f10dad
[fenix] Improve deleteBookmarkInEditModeTest UI test coverage
3 years ago
6bb861b172
[fenix] Import l10n.
3 years ago
4bcd25b25e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 record auto-close prompt telemetry events
3 years ago
3ffe906bcb
[fenix] No issue: Show snackbar when opening non-http URL
3 years ago
5e2853ea47
[fenix] MR2 Telemetry: Recent tabs section probe ( https://github.com/mozilla-mobile/fenix/pull/22166 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Fixed lint errors
* For https://github.com/mozilla-mobile/fenix/issues/22107 - added data review number to metric
* For https://github.com/mozilla-mobile/fenix/pull/22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
d02a7b9b66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection
3 years ago
3aacbb54ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection
3 years ago
1c03194841
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/preference_section_header_dark_theme redirection
3 years ago
ef1e53ec9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection
3 years ago
fc7a61c934
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection
3 years ago
15f812d211
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection
3 years ago
f6a6eaa4dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_background_dark_theme redirection
3 years ago
976471faa1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection
3 years ago
bb13f9142a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection
3 years ago
6676610267
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/toolbar_divider_color_dark_theme redirection
3 years ago
08070ae3f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/swipe_delete_background_dark_theme redirection
3 years ago
9c8417d62e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection
3 years ago
eed6603fd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection
3 years ago
56a250ceeb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/disabled_dark_theme redirection
3 years ago
93b4422105
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/shadow_dark_theme redirection
3 years ago
6770cea439
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_faded_dark_theme redirection
3 years ago
1037d980e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/neutral_dark_theme redirection
3 years ago
64b8bcbc34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_ring_dark_theme redirection
3 years ago
b5dec0ead6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimEnd_dark_theme redirection
3 years ago
73bb4f4526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/scrimStart_dark_theme redirection
3 years ago
59a75bb57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/recently_used_share_menu_dark_theme redirection
3 years ago
9054bfb2fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/tab_history_item_selected_background_light_theme redirection
3 years ago
e0c90b50e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/menu_item_button_light_theme redirection
3 years ago
39f9471c6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection
3 years ago
1aca9a4fd7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection
3 years ago
cefb9478e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection
3 years ago
8393fac307
[fenix] No issue: Merge our inactive tab interactor/controllers
3 years ago
4bd2cc7d0a
[fenix] No issue: Remove unused InactiveTabState code
3 years ago
3342f4a54a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
ba7d325bb4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22057 : Add search term groups telemetry
3 years ago
517f789958
[fenix] Introduce test rule to work around intermittent mockk failures
3 years ago
867f11e5d9
[fenix] Improve coverage for cancelCreateBookmarkFolderTest UI test
3 years ago
66862fa992
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests
3 years ago
d116c95205
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22138 - Install source metrics probe
3 years ago
33486f8434
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22226 - Open grouped history entries the same as individual ones
3 years ago
c0fde2bebb
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22172 : Add Recent searches telemetry
3 years ago
46f9f1ae2c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22103 : Add recent bookmarks telemetry
3 years ago
03ef78cfa4
[fenix] Import l10n.
3 years ago
55bf6f2839
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Add data review link
3 years ago
015be02422
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
ff1c34b9ee
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20704 : Use AppStore for inactive expanded state
3 years ago
Arturo Mejia
Roger Yang
mcarare
Gabriel Luong
mavduevskiy
Mozilla L10n Automation Bot
Grisha Kruglov
Mugurell
rxu
Matt Tighe
Noah Bond
aime Soriano Pastor
MickeyMoz
Jonathan Almeida
Christian Sadilek
Andrei Joltan
Sarah Khan
Oana Horvath
Noah Bond
AndiAJ
Sebastian Kaspari
Ben Dean-Kawamura
Michael Comella
mike a
Elise Richards
Matt Boris
Jonathan Almeida