0dd114beb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
f90db55a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
c4d7e19da6
[fenix] No issue: Make sure we are cleaning up test coroutines
4 years ago
0a9821fdbb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16274 )
4 years ago
986e28f100
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16161 - Fixes Saved Login toolbar layout
4 years ago
2d083e853a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump ( https://github.com/mozilla-mobile/fenix/pull/16229 )
...
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
f15d1054bb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16240 )
4 years ago
3047ea3601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16250 : Disable remote USB debugging for SDK <23.
4 years ago
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
4 years ago
51018be388
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15413 : Use proper url when bookmarking a page.
4 years ago
0f70a8d4fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10690 : re-enable editBookmarkTest
4 years ago
29e7f50cc3
[fenix] Import l10n.
4 years ago
df0da31c1f
[fenix] Fix AddonsManagementFragment detekt error
4 years ago
79ab29eff2
[fenix] No issue: Fix onConfigurationChange crashes in Debug build
4 years ago
56c98b57b8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11285 : Replace Session[Manager] observers in BaseBrowserFragment
4 years ago
268da65b3f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15816 - Attempt to handle 'allowInPrivate..' pref with detached context
4 years ago
047b712ffe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15379 : Use proper url when sharing.
4 years ago
647e73e851
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16199 - Don't pass BrowserToolbarView in onStart when we just need parent
4 years ago
d3faecd59c
[fenix] Fix add-on translation braking changes
4 years ago
a224f0c546
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8169 - Upgrade Mockwebserver ( https://github.com/mozilla-mobile/fenix/pull/16186 )
...
Upgrades Mockwebserver to 4.9.0
4 years ago
b28b69915e
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16198 )
4 years ago
bd068b288a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16122 - Add a dark theme color for the top sites pin icon ( https://github.com/mozilla-mobile/fenix/pull/16180 )
4 years ago
aba1e64d9a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16163 )
4 years ago
bb2a8acb16
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16154 )
4 years ago
f3d03c5e73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Set session ClearColor through Engine DefaultSettings
4 years ago
18012e4cfc
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16138 )
4 years ago
089fe7a9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15508 : Show error when trying to save empty or invalid bookmark URL ( https://github.com/mozilla-mobile/fenix/pull/15674 )
4 years ago
6cd2d75989
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16108 )
4 years ago
ebcb172781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15543 - Adjust the height of the tabs tray depending on the number of tabs ( https://github.com/mozilla-mobile/fenix/pull/15749 )
4 years ago
6ff5ec846b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser ( https://github.com/mozilla-mobile/fenix/pull/16099 )
4 years ago
f8d0a97210
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16084 - Match elevation of Tab in Collection to header ( https://github.com/mozilla-mobile/fenix/pull/16100 )
4 years ago
29a179e8c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15910 - Adds back automatic toggle, disables slider when enabled ( https://github.com/mozilla-mobile/fenix/pull/16070 )
4 years ago
5070c12a7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest ( https://github.com/mozilla-mobile/fenix/pull/16056 )
4 years ago
7f82d5e052
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14619 : Show half a tab top offset when scrolling to selected tab.
4 years ago
d3cb8d03f0
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16074 )
4 years ago
ebcf7ea907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16054 - Enable pull to refresh webpage in Nightly and Debug ( https://github.com/mozilla-mobile/fenix/pull/16060 )
4 years ago
11e73eebfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15080 : Handle default search engine when editing or removing ( https://github.com/mozilla-mobile/fenix/pull/15768 )
4 years ago
a3fce6b92d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat ( https://github.com/mozilla-mobile/fenix/pull/16011 )
4 years ago
09efe75e27
[fenix] FennecWebAppIntentProcessor: Catch JSONException.
4 years ago
274ab54236
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu. ( https://github.com/mozilla-mobile/fenix/pull/15884 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu.
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Update UI test for installing add-on.
4 years ago
85d7bb0baf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed
4 years ago
d7c63a63c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update UI tests.
4 years ago
0c48e945f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update unit tests.
4 years ago
ff595c7854
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Navigate to home screen with arguments on new tab action.
4 years ago
a9e3cb974b
[fenix] Import l10n.
4 years ago
9c7e0ad770
[fenix] Update Android Components, Kotlin, Gradle plugin ( https://github.com/mozilla-mobile/fenix/pull/16021 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
b931723651
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14744 : Also show Fill link from clipboard with search shortcuts. ( https://github.com/mozilla-mobile/fenix/pull/15885 )
4 years ago
5c9e32efda
[fenix] Configure M5 AMO collection for all builds
4 years ago
b763fd4449
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16014 )
4 years ago
0e83246501
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16001 )
4 years ago
0a5089879a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15986 )
4 years ago
d1e5785dad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle ( https://github.com/mozilla-mobile/fenix/pull/15975 )
4 years ago
36ab249924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag ( https://github.com/mozilla-mobile/fenix/pull/15967 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
b7cb6aa53c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie ( https://github.com/mozilla-mobile/fenix/pull/15909 )
4 years ago
8ec056ffb9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286 : Add TelemetryMiddleware to remove Session[Manager] observers
4 years ago
96e38a14eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language ( https://github.com/mozilla-mobile/fenix/pull/15966 )
4 years ago
37f4575e58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
4 years ago
6d9480ec2d
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15945 )
4 years ago
81556c956a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds ( https://github.com/mozilla-mobile/fenix/pull/15643 )
4 years ago
19b4a4ef5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
4 years ago
5348bed401
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Adjust margins for add search engine preference.
4 years ago
30bd0ed572
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Add divider above address bar preferences.
4 years ago
fcbe467703
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in tabs screen.
4 years ago
ee99347d3d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in customise screen.
4 years ago
0a83eb56f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : add comment for why we set the app theme in test.
4 years ago
aa19f541b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
910b7f19aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
69a126cbb6
[fenix] Sets theme in FenixRobolectricTestApplication onCreate
4 years ago
7cc54078d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate many Performance check severity in lint.xml.
...
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
<android-sdk>/tools/bin/lint --show
4 years ago
106a36bcdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : remove unnecessary lint ignore.
4 years ago
fec7662d8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate InefficientWeight to error.
...
All violations of this type were addressed in the previous commit.
4 years ago
74b4866e3d
[fenix] Fixes existing lint errors
4 years ago
ef60d82caa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator
4 years ago
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
4 years ago
9f67b3df9b
[fenix] fix detekt errors
4 years ago
3368ddce5c
[fenix] Use new SearchEngineProvider interface.
4 years ago
d064b26fc0
[fenix] Import l10n.
4 years ago
2b368b4bff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml.
4 years ago
30208f0345
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add current ConstraintLayout warnings to lint baseline.
4 years ago
88cf7184ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : suppress new lint rule in migration code.
4 years ago
5baed32e13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping
4 years ago
6ee2d5a8dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
4 years ago
5cdb7f3a73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds
...
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
4 years ago
ad43cd47a2
[fenix] Import l10n.
4 years ago
3726b8c98b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale
4 years ago
26854525c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14735 : Remove debug logs from release build. ( https://github.com/mozilla-mobile/fenix/pull/15747 )
4 years ago
f0a7f1bce0
[fenix] Import l10n.
4 years ago
312626f8f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp
4 years ago
f977e5af36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
4 years ago
031b4687c6
[fenix] Import l10n.
4 years ago
f1753eed23
[fenix] Import l10n.
4 years ago
53244870e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812 : Check for a null context during onScanResult
4 years ago
993335b296
[fenix] Import l10n.
4 years ago
c63bc04bd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar
4 years ago
4fedc9d719
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review.
4 years ago
88268c18a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity.
4 years ago
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
4 years ago
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
4 years ago
69db319601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
4 years ago
1ca3aab28a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Add ripple for the copy password button.
4 years ago
bf2e2d545d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle
4 years ago
3aaded4868
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up if the toolbar is not visible ( https://github.com/mozilla-mobile/fenix/pull/15667 )
...
For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
17fc28304a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( https://github.com/mozilla-mobile/fenix/pull/15649 )
...
For https://github.com/mozilla-mobile/fenix/issues/15497 : Remove and disable the three dot menu button
4 years ago
db1ad2ac93
[fenix] Import l10n.
4 years ago
8281e16c83
[fenix] Fix lint warnings and test in site permissions
4 years ago
4f67095c8b
[fenix] Add support for local storage permission
4 years ago
9b8a3401c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 9: Fix ui tests for the tabs settings
4 years ago
d7a4925a5a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting
4 years ago
c95c4de162
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 7: Draw a border around the selected tab
4 years ago
ca8cc56e32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 6: Display the tab's favicon in the grid view
4 years ago
8a4b3d85d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 5: Don't draw any background when swiping to delete a tab
4 years ago
b837358f14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 4: Formatted TabTrayView.kt
4 years ago
d7f46fa9f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
ded4f5cbbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml
4 years ago
88ce83d0d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
d7ea7c3555
[fenix] No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
d23a1b8274
[fenix] No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
9f2237e6f1
[fenix] Import l10n.
4 years ago
f4c1a915f5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15754 : Disable failing notification UI tests
4 years ago
848286b7b1
[fenix] Upgrade to Android Component 62.0.20201006190820 with breaking changes
4 years ago
7ad5f26333
[fenix] Adding link data review request
4 years ago
5ffe145425
[fenix] startup.timeline
4 years ago
86db33910d
[fenix] sync, sync_items, telemetry, theme, toolbar_position,
...
tracking_protection, default_engine
4 years ago
073321049c
[fenix] accesssibility, open_links, remote_debugging, search_suggestions,
...
show_search
4 years ago
7f14d314cb
[fenix] search_count, search_widget, tabs_count, toolbar_position
4 years ago
bba0353993
[fenix] has, count: open_tabs, pwa, top_sites
4 years ago
03b5b9f4e8
[fenix] default*browser, mozilla_products
4 years ago
83d6b8d559
[fenix] browser.search, events.total_uri_count, metrics.adjust*
4 years ago
93a4cab155
[fenix] first_session
4 years ago
bf68ea27c5
[fenix] user_specified_search_engine, voice_search
4 years ago
ade609c3ac
[fenix] top_sites, tracking_protection
4 years ago
bb3332478b
[fenix] tab, tabs_tray, toolbar_settings
4 years ago
278ac8007d
[fenix] syenc_account, sync_auth
4 years ago
ed317ac898
[fenix] search_suggestions, search_shortcuts, search_widget
4 years ago
9e4dfdf37c
[fenix] private_browsing, qr_scanner
4 years ago
71b1684c5b
[fenix] pocket, onboarding
4 years ago
41cb9084bf
[fenix] logins, media_notification, media_state
4 years ago
1838f130d1
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14142 - find_in_page, history, reader_mode, tip
4 years ago
4a56121cc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15711 : Also add custom engines to fallback list.
4 years ago
93b385ba2e
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15738 )
4 years ago
f5ff218d46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8765 : Use shared list widget in collections ( https://github.com/mozilla-mobile/fenix/pull/15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
8b20c2d8c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count.
...
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
0934b7fe93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments.
4 years ago
86a44fb728
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add marker when StrictMode is suppressed.
4 years ago
19904397b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
d253b9060e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add test to prevent increasing StrictMode suppression count.
4 years ago
3e9f93a0ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
4 years ago
b6609a0747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : count StrictMode suppressions on startup.
4 years ago
efc846d57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
1d8006f733
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15712 )
4 years ago
ded58ad2b7
[fenix] Import l10n.
4 years ago
8668f5a0d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
c318e736f9
[fenix] Import l10n.
4 years ago
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
e1ffe1108f
[fenix] No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
482efed8de
[fenix] Import l10n.
4 years ago
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
33e49d471b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
1589942479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
a846743af4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555 : Intermittent failures in SettingsFragmentTest
4 years ago
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
ac1a2a708a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode
4 years ago
87ecdf8bfb
[fenix] Import l10n.
4 years ago
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
53bd004f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
d0fbe70f10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : clean up existing StrictMode test names.
4 years ago
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
5f8943f76c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
76018e2fe0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14034 : Add debug preference to override AMO collection in Nightly
4 years ago
9e86e369b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
394465e33e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
c1aa8d396a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
b2c01e442f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
1ec45f33a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
3b76f2b3fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
788b5bb21e
[fenix] Import l10n.
4 years ago
3ede6cf544
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Add test for ActivityNotFoundException when sharing to app.
4 years ago
9d9d283dc7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
b276e9daca
[fenix] No issue: Update AC to 61.0.20200925190057
4 years ago
cf0af49d3b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home
4 years ago
Mugurell
Gabriel Luong
ekager
mozilla-l10n-automation-bot
Codrut Topliceanu
mcarare
Mihai Adrian Carare
Oana Horvath
Mozilla L10n Automation Bot
Arturo Mejia
Christian Sadilek
Grisha Kruglov
Aaron Train
Lorenzo Stanco
Jocelyne Abi Haidar
Elise Richards
Juan C. Goncalves
Sebastian Kaspari
Tom Klein
amkcpu
Jeff Boek
Michael Comella
Shen
sraturi
Sijan Rijal
Jonathan Almeida
Chenxia Liu
Jocelyne Abi Haidar
Stefan Arentz
Andrew Gaul
TrianguloY
Tiger Oakes
Sören Hentzschel