a87dce7523
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16615 : UI smoke test firstRunScreenTest
4 years ago
6257824745
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16625 )
4 years ago
36d8481c96
[fenix] Update Android Components to 67.0.20201117165227 ( https://github.com/mozilla-mobile/fenix/pull/16619 )
4 years ago
49a98cb413
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Remove feature flag for return to browser ( https://github.com/mozilla-mobile/fenix/pull/16622 )
4 years ago
d23db3c8ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16614 - Ensure a stable order for the items in tabs tray. ( https://github.com/mozilla-mobile/fenix/pull/16618 )
...
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items
This order should also be kept after returning from Multiselect mode.
4 years ago
42de52ac1c
[fenix] Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu
4 years ago
ad95b57c30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15091 - Fixes RecentlyClosedAdapter DiffCallback ( https://github.com/mozilla-mobile/fenix/pull/16608 )
4 years ago
49a94ee0f4
[fenix] Import l10n.
4 years ago
2256f29d23
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16153 : Intermittent failures of ShareControllerTest.handleShareToApp
4 years ago
85aa2f4fc9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16420 : Make search bar first view focused by a11y services on open.
4 years ago
0e37184204
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16587 : Make sure tab counter correctly reflects private/normal tab counts
4 years ago
df087718e1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16053 : Fix crash when closing private tabs via notification
4 years ago
ee11970d27
[fenix] Update Android Components version to 67.0.20201115143123.
4 years ago
46dc099762
[fenix] Import l10n.
4 years ago
8fd55d87f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13477 - Move BiometricPrompt to a separate feature ( https://github.com/mozilla-mobile/fenix/pull/16498 )
...
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
4 years ago
d68aee5549
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16511 - Change a11y parent of button without breaking the tab list. ( https://github.com/mozilla-mobile/fenix/pull/16555 )
4 years ago
8a3749c8bf
[fenix] Import l10n.
4 years ago
159b13bb8f
[fenix] No issue: move TestStrictModeManager to perf sub package.
4 years ago
a6cef89dc2
[fenix] No issue: move StrictModeManager to perf package.
...
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
4 years ago
39384786dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16376 : move Startup*Test to perf pkg under code owners.
...
Instead of listing many different files here, we should just put them in
/perf/ packages and code owner them.
4 years ago
d5f666cbf3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16376 : assert num ConstraintLayout direct descend RecyclerView.
...
I'm not convinced this is a useful test because the performance
characteristics seem unfortunately nuanced: if the test fails, it implies
you shouldn't add more but that isn't necessarily true (for example, if
your RV child has a large depth). Furthermore, we haven't measured in a
variety of circumstances that layouts like LinearLayout perform better
as RecyclerView children so maybe it only held for the one small case we
used it in.
4 years ago
414a046263
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16376 : test view hierarchy depth in StartupExcessive*Test.
4 years ago
4f82163e36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15725 : Set up preferences in onCreatePreferences instead of onResume
...
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
4 years ago
6b4fbca1bb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12899 : fixed UI test for ETP off
4 years ago
1ed7efce41
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Switch to using an extension to update a11y collection info.
4 years ago
2302a589da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Migrate updateAccessibilityCollectionItemInfo to extension.
4 years ago
33e8a2b22b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Update a11y info to collection item for both grid and list.
4 years ago
2b0c11aae1
[fenix] Replace lingering occurence of ic_hollow_share with ic_share_filled ( https://github.com/mozilla-mobile/fenix/pull/16548 )
4 years ago
f73385df4a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16461 - Ensure the proper items order after exiting Multiselect ( https://github.com/mozilla-mobile/fenix/pull/16482 )
4 years ago
957e30453b
[fenix] Fixes Comment on https://github.com/mozilla-mobile/fenix/issues/16563 : DefaultToolbarMenu registering for bookmark changes
...
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
4 years ago
60820051d1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16345 : Update share icon shape
...
updating share icon to a filled shape, like default toolbar menu across all app
4 years ago
c6e4316e75
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16345 : use same share icon across all app
...
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
4 years ago
4a21bcd11c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16546 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
4 years ago
3f3bd2e52c
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16486 )
4 years ago
70fb6a8d7a
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16535 )" ( https://github.com/mozilla-mobile/fenix/pull/16544 )
...
This reverts commit cb340e88f265cc16ba05edaa54c3a99164560438.
4 years ago
c8ce71a622
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16451 - Change default top sites to Baidu & JD in China build ( https://github.com/mozilla-mobile/fenix/pull/16515 )
...
* Add top sites related strings
* Change default top sites to Baidu & JD in China build
4 years ago
350be5af87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16535 )
4 years ago
6486465645
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16076 - Link data review for the share_image telemetry ( https://github.com/mozilla-mobile/fenix/pull/16534 )
4 years ago
c129fa2aba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Rename normal mode menu item, remove telemetry
4 years ago
a1e4f02882
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14920 - Show a Tabs Tray CFR Banner for grid view tip ( https://github.com/mozilla-mobile/fenix/pull/16466 )
4 years ago
ab1e56ef5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16302 - Use larger heap size when running unit tests and fork new process after every 80 test classes. ( https://github.com/mozilla-mobile/fenix/pull/16526 )
4 years ago
63e2bd3f9e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11376 - Reverse tabs list order ( https://github.com/mozilla-mobile/fenix/pull/16245 )
4 years ago
73e14dd776
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13217 : fixed UI test for main menu items
4 years ago
31d379f36d
[fenix] Revert "Update Android Components version to 66.0.20201111143206."
...
This reverts commit 3a07e10eefe64d955de3b71221bb99e7cfc6b039.
4 years ago
f962ee2d08
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14772 : Crash in Downloads
4 years ago
0afd4bdae5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16076 - Add new "share_image" telemetry event
4 years ago
34196ed813
[fenix] Update Android Components version to 66.0.20201111143206.
4 years ago
9abf05e7fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16500 - Ensure CardView clips ImageView on lower APIs ( https://github.com/mozilla-mobile/fenix/pull/16507 )
...
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
4 years ago
f535d467cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16416 : Remove save to collection button from tab a11y list.
4 years ago
a197281092
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Revise multiselect mode UI
4 years ago
9e347d601f
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16468 )
4 years ago
da543114c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16424 - Focus the right item in tabs tray when using Talkback ( https://github.com/mozilla-mobile/fenix/pull/16472 )
...
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
23ff2851e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15720 - Remove unused telemetry ( https://github.com/mozilla-mobile/fenix/pull/15887 )
4 years ago
ebc1ba3b50
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15960 - Enable Grid View in Nightly only ( https://github.com/mozilla-mobile/fenix/pull/16462 )
4 years ago
85d00ac291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16426 : Allow multiselect title to be selected by a11y services.
4 years ago
c32bbcc3e8
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16447 )
4 years ago
70852916d6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16430 : ExternalAppBrowserActivity should not handle incoming intents
4 years ago
3ab61bec1b
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16441 )
4 years ago
489e8cc970
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15764 - Update Tabs summary description. ( https://github.com/mozilla-mobile/fenix/pull/16428 )
4 years ago
0ccff38ebc
[fenix] Update Android Components version to 66.0.20201106143126 ( https://github.com/mozilla-mobile/fenix/pull/16439 )
4 years ago
2748519959
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 : use Espresso's RecyclerView scrollTo action
4 years ago
77cfcd82c3
[fenix] Import l10n.
4 years ago
80e9e1fa8e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16327 : Refactor MenuPresenter to use browser store
4 years ago
8cc09b5785
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/15934 fix ConcurrentModificationException
...
on WifiConnectionMonitor
4 years ago
84770f1f64
[fenix] Fix GeckoProvider for beta and release variant.
4 years ago
3ec2a3d971
[fenix] Add mozcn safebrowsing
4 years ago
c481d0504b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private.
4 years ago
17b32070dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add component init count to StartupExcessiveResourceUseTest.
4 years ago
7ac4b40fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
9e8fd7c6f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
3879697c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
07e69195f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add LazyMonitored and tests.
4 years ago
83cf8baedf
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16380 )
4 years ago
88375a2294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/352 : Delete a download
4 years ago
5344dceead
[fenix] No issue: Update stable androidx and material versions
4 years ago
f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
0a8d8cfbf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item ( https://github.com/mozilla-mobile/fenix/pull/16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
4 years ago
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
4 years ago
24d2b31b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test ( https://github.com/mozilla-mobile/fenix/pull/16346 )
4 years ago
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
4 years ago
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
4fe05cc97c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist
4 years ago
9007d8d33e
[fenix] Import l10n.
4 years ago
ba18f60d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers ( https://github.com/mozilla-mobile/fenix/pull/16332 )
4 years ago
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
4 years ago
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
4 years ago
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
4 years ago
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
4 years ago
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
4 years ago
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
4 years ago
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
87ce122d03
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552 : Do not display back button when there is no tab history.
4 years ago
a94eca1063
[fenix] Import l10n.
4 years ago
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
58a22af103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Oana Horvath
mozilla-l10n-automation-bot
Jonathan Almeida
ekager
Mugurell
Bryan Kok
Mozilla L10n Automation Bot
Christian Sadilek
mcarare
MickeyMoz
Mihai Adrian Carare
Michael Comella
Jocelyne Abi Haidar
Bryan Kok
LeoMaldonado
Gabriel Luong
rxumoz
Sebastian Kaspari
Codrut Topliceanu
Johan Lorenzo
Kate Glazko
Arturo Mejia
Rafał Opiłowski
MarcLeclair
Roger Yang
Jocelyne Abi Haidar