Commit Graph

4722 Commits (6c07bc316f3965e2d6541754686139c7e2138678)

Author SHA1 Message Date
mozilla-l10n-automation-bot 0e83246501 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/16001) 4 years ago
mozilla-l10n-automation-bot 0a5089879a [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15986) 4 years ago
Gabriel Luong d1e5785dad [fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle (https://github.com/mozilla-mobile/fenix/pull/15975) 4 years ago
Gabriel Luong 36ab249924 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag (https://github.com/mozilla-mobile/fenix/pull/15967)
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag

* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager b7cb6aa53c [fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie (https://github.com/mozilla-mobile/fenix/pull/15909) 4 years ago
Christian Sadilek 8ec056ffb9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286: Add TelemetryMiddleware to remove Session[Manager] observers 4 years ago
Gabriel Luong 96e38a14eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language (https://github.com/mozilla-mobile/fenix/pull/15966) 4 years ago
amkcpu 37f4575e58 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10683: Show longer tab titles
Also update tab tray item layout according to specs posted in the issue.
4 years ago
mozilla-l10n-automation-bot 6d9480ec2d [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15945) 4 years ago
Jeff Boek 81556c956a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds (https://github.com/mozilla-mobile/fenix/pull/15643) 4 years ago
Gabriel Luong 19b4a4ef5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Use padding instead of margin to use the full screen width for the "Add search engine" button 4 years ago
mcarare 5348bed401 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Adjust margins for add search engine preference. 4 years ago
mcarare 30bd0ed572 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14922: Add divider above address bar preferences. 4 years ago
mcarare fcbe467703 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15898: Add dividers above subheadings in tabs screen. 4 years ago
mcarare ee99347d3d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15898: Add dividers above subheadings in customise screen. 4 years ago
Michael Comella 0a83eb56f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: add comment for why we set the app theme in test. 4 years ago
Michael Comella aa19f541b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: change apply to with in GleanMetricsService.
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella 910b7f19aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: mock package inspection dependencies in GleanMetricsService.
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager 69a126cbb6 [fenix] Sets theme in FenixRobolectricTestApplication onCreate 4 years ago
Michael Comella 7cc54078d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: escalate many Performance check severity in lint.xml.
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
  <android-sdk>/tools/bin/lint --show
4 years ago
Michael Comella 106a36bcdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: remove unnecessary lint ignore. 4 years ago
Michael Comella fec7662d8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: escalate InefficientWeight to error.
All violations of this type were addressed in the previous commit.
4 years ago
ekager 74b4866e3d [fenix] Fixes existing lint errors 4 years ago
Gabriel Luong ef60d82caa [fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator 4 years ago
ekager 9d876a7076 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings 4 years ago
ekager 9f67b3df9b [fenix] fix detekt errors 4 years ago
Sebastian Kaspari 3368ddce5c [fenix] Use new SearchEngineProvider interface. 4 years ago
Mozilla L10n Automation Bot d064b26fc0 [fenix] Import l10n. 4 years ago
Michael Comella 2b368b4bff [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml. 4 years ago
Michael Comella 30208f0345 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280: add current ConstraintLayout warnings to lint baseline. 4 years ago
Michael Comella 88cf7184ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280: suppress new lint rule in migration code. 4 years ago
ekager 5baed32e13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping 4 years ago
ekager 6ee2d5a8dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs 4 years ago
Mugurell 5cdb7f3a73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
4 years ago
Mozilla L10n Automation Bot ad43cd47a2 [fenix] Import l10n. 4 years ago
ekager 3726b8c98b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale 4 years ago
Mihai Adrian Carare 26854525c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14735: Remove debug logs from release build. (https://github.com/mozilla-mobile/fenix/pull/15747) 4 years ago
Mozilla L10n Automation Bot f0a7f1bce0 [fenix] Import l10n. 4 years ago
Gabriel Luong 312626f8f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp 4 years ago
Gabriel Luong f977e5af36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail 4 years ago
Mozilla L10n Automation Bot 031b4687c6 [fenix] Import l10n. 4 years ago
Mozilla L10n Automation Bot f1753eed23 [fenix] Import l10n. 4 years ago
Grisha Kruglov 53244870e9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812: Check for a null context during onScanResult 4 years ago
Mozilla L10n Automation Bot 993335b296 [fenix] Import l10n. 4 years ago
Shen c63bc04bd2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar 4 years ago
Michael Comella 4fedc9d719 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review. 4 years ago
Michael Comella 88268c18a1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity. 4 years ago
Michael Comella 6c86641cbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos. 4 years ago
sraturi e97a48b48f [fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 4 years ago
mcarare 69db319601 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13831: Adjust buttons dimensions to improve a11y.
Margins were also adjusted to maintain relative placements.
4 years ago
mcarare 1ca3aab28a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13831: Add ripple for the copy password button. 4 years ago
ekager bf2e2d545d [fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle 4 years ago
Sijan Rijal 3aaded4868 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15402: Hide ETP pop-up if the toolbar is not visible (https://github.com/mozilla-mobile/fenix/pull/15667)
For https://github.com/mozilla-mobile/fenix/issues/15402: Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
Sijan Rijal 17fc28304a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (https://github.com/mozilla-mobile/fenix/pull/15649)
For https://github.com/mozilla-mobile/fenix/issues/15497: Remove and disable the three dot menu button
4 years ago
Mozilla L10n Automation Bot db1ad2ac93 [fenix] Import l10n. 4 years ago
Jonathan Almeida 8281e16c83 [fenix] Fix lint warnings and test in site permissions 4 years ago
Arturo Mejia 4f67095c8b [fenix] Add support for local storage permission 4 years ago
Gabriel Luong 9b8a3401c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 9: Fix ui tests for the tabs settings 4 years ago
Gabriel Luong d7a4925a5a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 4 years ago
Gabriel Luong c95c4de162 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 7: Draw a border around the selected tab 4 years ago
Gabriel Luong ca8cc56e32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 6: Display the tab's favicon in the grid view 4 years ago
Gabriel Luong 8a4b3d85d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 5: Don't draw any background when swiping to delete a tab 4 years ago
Gabriel Luong b837358f14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 4: Formatted TabTrayView.kt 4 years ago
Gabriel Luong d7f46fa9f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 3: Implement a grid view layout for the tabs
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong ded4f5cbbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 4 years ago
Gabriel Luong 88ce83d0d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella d7ea7c3555 [fenix] No issue: fix tests related to inline change.
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella d23a1b8274 [fenix] No issue: remove inline from StrictModeManager.resetAfter.
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Mozilla L10n Automation Bot 9f2237e6f1 [fenix] Import l10n. 4 years ago
Jonathan Almeida f4c1a915f5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15754: Disable failing notification UI tests 4 years ago
Jonathan Almeida 848286b7b1 [fenix] Upgrade to Android Component 62.0.20201006190820 with breaking changes 4 years ago
Chenxia Liu 7ad5f26333 [fenix] Adding link data review request 4 years ago
Chenxia Liu 5ffe145425 [fenix] startup.timeline 4 years ago
Chenxia Liu 86db33910d [fenix] sync, sync_items, telemetry, theme, toolbar_position,
tracking_protection, default_engine
4 years ago
Chenxia Liu 073321049c [fenix] accesssibility, open_links, remote_debugging, search_suggestions,
show_search
4 years ago
Chenxia Liu 7f14d314cb [fenix] search_count, search_widget, tabs_count, toolbar_position 4 years ago
Chenxia Liu bba0353993 [fenix] has, count: open_tabs, pwa, top_sites 4 years ago
Chenxia Liu 03b5b9f4e8 [fenix] default*browser, mozilla_products 4 years ago
Chenxia Liu 83d6b8d559 [fenix] browser.search, events.total_uri_count, metrics.adjust* 4 years ago
Chenxia Liu 93a4cab155 [fenix] first_session 4 years ago
Chenxia Liu bf68ea27c5 [fenix] user_specified_search_engine, voice_search 4 years ago
Chenxia Liu ade609c3ac [fenix] top_sites, tracking_protection 4 years ago
Chenxia Liu bb3332478b [fenix] tab, tabs_tray, toolbar_settings 4 years ago
Chenxia Liu 278ac8007d [fenix] syenc_account, sync_auth 4 years ago
Chenxia Liu ed317ac898 [fenix] search_suggestions, search_shortcuts, search_widget 4 years ago
Chenxia Liu 9e4dfdf37c [fenix] private_browsing, qr_scanner 4 years ago
Chenxia Liu 71b1684c5b [fenix] pocket, onboarding 4 years ago
Chenxia Liu 41cb9084bf [fenix] logins, media_notification, media_state 4 years ago
Chenxia Liu 1838f130d1 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14142 - find_in_page, history, reader_mode, tip 4 years ago
mcarare 4a56121cc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15711: Also add custom engines to fallback list. 4 years ago
mozilla-l10n-automation-bot 93b385ba2e [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15738) 4 years ago
Elise Richards f5ff218d46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8765: Use shared list widget in collections (https://github.com/mozilla-mobile/fenix/pull/15733)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella 8b20c2d8c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count.
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
Michael Comella 0934b7fe93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments. 4 years ago
Michael Comella 86a44fb728 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add marker when StrictMode is suppressed. 4 years ago
Michael Comella 19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella d253b9060e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add test to prevent increasing StrictMode suppression count. 4 years ago
Michael Comella 3e9f93a0ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add HomeActivityTestRule.skipOnboarding.
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
4 years ago
Michael Comella b6609a0747 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: count StrictMode suppressions on startup. 4 years ago
Jocelyne Abi Haidar efc846d57a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15675: Disable Save button when editing saved login until something has been changed
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mozilla-l10n-automation-bot 1d8006f733 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15712) 4 years ago
Mozilla L10n Automation Bot ded58ad2b7 [fenix] Import l10n. 4 years ago
mcarare 8668f5a0d6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15632: Improve checking open tabs logic to show collection button.
Check now considers selected tab tray mode.
4 years ago
ekager c5a6e86f9b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration 4 years ago
ekager d9aefd1ce2 [fenix] No issue: Update biometric, core, and recyclerview libraries 4 years ago
mcarare 1add1c7454 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13031: Show size in KB for smaller downloaded files. 4 years ago
Mozilla L10n Automation Bot c318e736f9 [fenix] Import l10n. 4 years ago
Jocelyne cc4d4a14d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10107: Show Today and Yesterday labels in History (https://github.com/mozilla-mobile/fenix/pull/15415) 4 years ago
Michael Comella e1ffe1108f [fenix] No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
4 years ago
Jeff Boek d81eff94bd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching 4 years ago
Jocelyne 635e49092e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15471: Show Delete button in red in multi-select overflow menu (https://github.com/mozilla-mobile/fenix/pull/15576) 4 years ago
Mozilla L10n Automation Bot 482efed8de [fenix] Import l10n. 4 years ago
Grisha Kruglov a41022554b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443: Use fragment's lifecycleScope for AlertDialog actions 4 years ago
Christian Sadilek 33e49d471b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555: Set channel to Nightly explicitly for SettingsFragmentTest 4 years ago
mcarare 1589942479 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15559: Allow tabs to stretch in landscape mode for tablets.
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
Christian Sadilek a846743af4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555: Intermittent failures in SettingsFragmentTest 4 years ago
Stefan Arentz a0c00cb3b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers (https://github.com/mozilla-mobile/fenix/pull/15538) 4 years ago
mcarare 192e5dc063 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15535: hasOpenTabs now considers the selected tab mode in tray tab. 4 years ago
Michael Comella af732f0748 [fenix] No issue: elaborate on Components class doc.
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari 70dbf0d765 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller" for debug test failures.
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
Sebastian Kaspari 9b598b33d8 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller" for debug test failures.
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
Andrew Gaul 43778cf3cb [fenix] Show undo snackbars with padding with static bottom toolbar
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9.  References https://github.com/mozilla-mobile/fenix/issues/14982.
4 years ago
ekager 1429c5ddaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs 4 years ago
ekager 8caf149ab7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10 4 years ago
TrianguloY 98f8f3b2ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture 4 years ago
Tiger Oakes 5a3b5af7d9 [fenix] Extract locale settings initial state 4 years ago
Tiger Oakes be11bfd5b4 [fenix] Add test for initial logins list state 4 years ago
Tiger Oakes e4bdd355d3 [fenix] Add tests for initial collection creation state 4 years ago
Sören Hentzschel ac1a2a708a [fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode 4 years ago
Mozilla L10n Automation Bot 87ecdf8bfb [fenix] Import l10n. 4 years ago
Tiger Oakes b55c4af6fb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller 4 years ago
Tiger Oakes 966e13c9aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller 4 years ago
Michael Comella a50cf27648 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: fix startup crash by using arg Context.
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella 53bd004f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove resetAfter & port tests to StrictModeManager. 4 years ago
Michael Comella d0fbe70f10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: clean up existing StrictMode test names. 4 years ago
Michael Comella 8a9472e540 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: move resetAfter into StrictModeManager.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella 5f8943f76c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: change StrictModeManager to class from object.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek 76018e2fe0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14034: Add debug preference to override AMO collection in Nightly 4 years ago
Michael Comella 9e86e369b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: comment about duplication in logic in StrictMode.
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella 394465e33e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add comment to explain why we only resetAfter in certain build modes. 4 years ago
Michael Comella c1aa8d396a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: use ac StrictMode.resetAfter rather than duplicating functionality. 4 years ago
Michael Comella b2c01e442f [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: rename to attachListenerToDisablePenaltyDeath for clarity. 4 years ago
Michael Comella 1ec45f33a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove unused penaltyDialog parameter.
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
Michael Comella 3b76f2b3fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: always enable detectNonSdkApiUsage.
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
Sebastian Kaspari eca2b8ecf4 [fenix] Use "undo" implementation from Android Components.
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
Mozilla L10n Automation Bot 788b5bb21e [fenix] Import l10n. 4 years ago
mcarare 3ede6cf544 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Add test for ActivityNotFoundException when sharing to app. 4 years ago
mcarare 9d9d283dc7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Also catch ActivityNotFoundException when sharing to app. 4 years ago
ekager b276e9daca [fenix] No issue: Update AC to 61.0.20200925190057 4 years ago
ekager cf0af49d3b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home 4 years ago
Grisha Kruglov c348e03d0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 4 years ago
Grisha Kruglov a0189c8080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432: Invoke UI updates on main thread in response to account events 4 years ago
Grisha Kruglov 5bb231cc70 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436: Auto-close tabs during startup on the main thread 4 years ago
Christian Sadilek 146aa075dd [fenix] Configure M5 AMO collection for Nightly/Debug 4 years ago
mcarare c5c3b6549d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" check in UI test. 4 years ago
mcarare 1d7b1df0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" from onboarding screen. 4 years ago
Mozilla L10n Automation Bot 8774b36f49 [fenix] Import l10n. 4 years ago
Kate Glazko 739a3520e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15320: Ensure Mimetype Other PDF Shows PDF Icon 4 years ago
Elise Richards 609857c5f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14280, https://github.com/mozilla-mobile/fenix/issues/14743: Remove old search fragment (https://github.com/mozilla-mobile/fenix/pull/15169)
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida 2ab099b37b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15349: Fixes SyncedTabs suggestion not clicking 4 years ago
Grisha Kruglov bc90bd2f31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15296: Allow excluding bookmark subtrees when editing parent folder
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
Mozilla L10n Automation Bot fdb3d6c013 [fenix] Import l10n. 4 years ago
Sawyer Blatz 9d49be285c [fenix] For https://github.com/mozilla-mobile/fenix/issues/14243: Pre-land visuals for Close Tabs CFR (https://github.com/mozilla-mobile/fenix/pull/15171) 4 years ago
Grisha Kruglov 661a48a940 [fenix] Update breaking changes in the FxA/Sync integration 4 years ago
Jocelyne 0638e9b3d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11800: Hide reveal and clear password icons if the password is empty when editing a saved login (https://github.com/mozilla-mobile/fenix/pull/15244)
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
Sebastian Kaspari 0663cf8916 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/13270: Do not launch into Fennec's task anymore.
Initially we did this to avoid a duplicated task right after the migration from Fennec. We'd end up
with the original task from Fennec and the new one from Fenix; with the Fennec task still showing
Fennec in the app switcher, but launching Fenix once selected.

Anyhow, now on Android 11 this causes the Fenix task to get duplicated. The simple fix is to not
do any of that anymore. This may re-introduce the problem with the Fennec migration, but:
* We are at 100% rollout for quite some time. There are still users migrating, but the impact
  of the bug is much lower.
* The bug after the migration was only temporary. This bug here is happening every time you
  launch Fenix. So I'd rather fix this than a possible inconvenience right after the migration.
4 years ago
mcarare deafcc7387 [fenix] https://github.com/mozilla-mobile/fenix/pull/274-android-l10n: Update create account string to avoid partial translations. 4 years ago
Christian Sadilek d12fa25350 [fenix] Configure M4 AMO collection for all builds 4 years ago
person808 2ddd7950b9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15219 - Fix tab tray handle size.
Also use dimens for the tab history handle.
4 years ago
aprabhakara 06036292ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/15262: Updated margins 4 years ago
ekager 65db93b8b5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days 4 years ago
mcarare 9b953c0255 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15263: Properly update open links in app preference. 4 years ago
ekager 5536851865 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15272 - Remove bottom margin for toolbar on enter fullscreen 4 years ago
ekager 2f7edfe924 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15121 - Ensure tabs removed while on browser select an available parent session 4 years ago
mcarare f887985405 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15268: Update unit tests for safe navigation to details fragment. 4 years ago
mcarare d6f5f88deb [fenix] For https://github.com/mozilla-mobile/fenix/issues/15268: Use safe navigation to addon details fragments. 4 years ago
Oana Horvath 90ef2c90bf [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14524, https://github.com/mozilla-mobile/fenix/issues/12896, https://github.com/mozilla-mobile/fenix/issues/13830: re-enabled strict ETP tests after code bug fix 4 years ago
Grisha Kruglov 0b56dd58e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15284: Process root titles when creating new folders
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
ekager e2f534e533 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15089 - Disable recently closed in multiselect 4 years ago
ekager 231bfe6323 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15112 - Still show recently closed when history empty 4 years ago
Grisha Kruglov 4e486c0b40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15286: Don't crash when separators are long-touched 4 years ago
Mozilla L10n Automation Bot 3249a5e7f4 [fenix] Import l10n. 4 years ago
ekager 9763d05ef2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13934 - Make TabHistory work on PWA/Custom Tabs 4 years ago
ekager f4406b2265 [fenix] No issue: Fixes strict mode death in debug custom tab 4 years ago
ekager 0fbfbb5516 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14982 - Show snackbars with padding with static bottom toolbar 4 years ago
ekager abe4ccd2ea [fenix] For https://github.com/mozilla-mobile/fenix/issues/14458 - dismiss keyboard on fill link from clipboard 4 years ago
Mozilla L10n Automation Bot a8ce1d6722 [fenix] Import l10n. 4 years ago
ekager 6b66dbd5cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/15245 - Remove margin for toolbar on toolbar-less PWA 4 years ago
Mozilla L10n Automation Bot ddd8d2b7fd [fenix] Import l10n. 4 years ago
Grisha Kruglov 4f6213a2dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/2792: Display bookmark folders at the top of the bookmarks UI 4 years ago
Grisha Kruglov ec18031057 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15211: Make sure bookmarks are moved to the end of folders 4 years ago
Grisha Kruglov ba242fb3b9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15206: Only track 'move' event if bookmark parent was changed 4 years ago
Grisha Kruglov fa8af7dcd2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11502: Make sure to always process root titles for parent folders during edit
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
Grisha Kruglov f79c9733e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13157: Filter out folder being edited from 'select folder' dialog 4 years ago
Grisha Kruglov 412ae60537 [fenix] Rename 'visitedAddBookmark' arg to a less confusing name 4 years ago
Grisha Kruglov 2e646b696a [fenix] Remove unused nav arg from 'select folder' 4 years ago
Mozilla L10n Automation Bot e4bf6224f6 [fenix] Import l10n. 4 years ago
Tiger Oakes da57dc840d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14131: Move constants to dimens.xml (https://github.com/mozilla-mobile/fenix/pull/14135)
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
Tom Klein 86c20fc7c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13300 - Adjust the 'Sharing a Collection' layout to prevent overlapping of the close icon and 'Share' label in RTL
Note that the "Share" title is still constrained to start at the end of the
close button - I don't know why the previous extra constraint was causing the
differing behavior in LTR and RTL, but this seems to fix it.
4 years ago
Elise Richards 79f788e577 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13812: add ETP category for redirect trackers (https://github.com/mozilla-mobile/fenix/pull/15139)
* Feature flag for ETP cookie purging

* Strings for new ETP description

* Remove icons from ETP info screeen and add category for redirect trackers

* ETP policy factory tests

* Remove icons from ETP panel and add cross tracking allowed field.

* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.

* Add margins to tracking protection settings
4 years ago
Jeff Boek f9c9099f5d [fenix] For https://github.com/mozilla-mobile/android-components/issues/8429 - Dont initialize MLS if token is null 4 years ago
Jeff Boek c6f46de882 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12544 - Prevent search engines mixup"
This reverts commit 52f1a904b7039fb69cdd074f63ad059834fb99c1.
4 years ago
Hakkı Kaan Çalışkan 18e1dded25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13922: Add indicator to synced tabs suggestions in awesomebar 4 years ago
Jonathan Almeida 9824d81afa [fenix] For https://github.com/mozilla-mobile/fenix/issues/14230: Stop redrawing all top sites when one is removed 4 years ago
mcarare 23cbede5e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12829: Add create account option on the the sign in screen. 4 years ago
mcarare 3af7750c57 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12829: Update addUnderline extension function to accept parameters. 4 years ago
mcarare a1a9202e1f [fenix] For https://github.com/mozilla-mobile/fenix/issues/15150: Do not show open banner if open in app is ON in settings. 4 years ago
Mozilla L10n Automation Bot a6591cb3fe [fenix] Import l10n. 4 years ago
mcarare b2b5b1a22c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13943: Change strict mode penalty to penaltyDeath.
Also, keep dialogPenalty as replacement option for penaltyDeath.
4 years ago
Oana Horvath 09481688f0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13829: Added idling resources to the addon details view" 4 years ago
mcarare 64f647f006 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14727: Add content description to resync tabs button. 4 years ago
Sören Hentzschel bc6259dc2f [fenix] For https://github.com/mozilla-mobile/fenix/issues/14933 - Fixed private browsing icon color in preferences fragment 4 years ago
Tiger Oakes d29e90717c [fenix] Merge bookmark item and folder view holders 4 years ago
Tiger Oakes a684ab65ca [fenix] Change separator to use its own view holder 4 years ago
Elise Richards a6f71a3581 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15079: handle QR permissions when changed in Android settings (https://github.com/mozilla-mobile/fenix/pull/15097)
* Define intent data for activity

* Search dialog shows permissions for allow and deny camera

* Check camera permissions for fxa pairing

* Check camera permissions for old search

* Tests for pairing sync interactor and controller.

* Cleanup

* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.

* Lint
4 years ago
Sawyer Blatz c21bfef9e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15123: Fix top sites text color 4 years ago
Sawyer Blatz 1a5a88be4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/14565: Add telemetry for top sites 4 years ago
Arturo Mejia 6e5748123f [fenix] Fix add-ons permissions breaking change 4 years ago
mcarare 4a29c49fb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15116: Also do not expand or set bottom toolbar behavior on TWA tabs. 4 years ago
mcarare 2245badc6f [fenix] For https://github.com/mozilla-mobile/fenix/issues/15116: Do not set bottom toolbar behavior on PWA tabs. 4 years ago
mcarare a6a7ce00bc [fenix] For https://github.com/mozilla-mobile/fenix/issues/15116: Do not expand toolbar on PWA tabs. 4 years ago
mcarare 55e2cfe526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15116: Use safe cast for layout params. 4 years ago
Sebastian Kaspari e90ddb1f38 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14225: Remove task when finishing ExternalAppBrowserActivity. 4 years ago
Mozilla L10n Automation Bot 12a0333419 [fenix] Import l10n. 4 years ago
Mozilla L10n Automation Bot 8ea08ff5ba [fenix] Import l10n. 4 years ago
Hakkı Kaan Çalışkan 199cdac801 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11245: Integrate Synced Tabs AwesomeBar suggestions
fix pr
4 years ago
mozilla-l10n-automation-bot ed97bf1db4 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15099) 4 years ago
Jeff Boek 710da8dd63 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15007 - Puts swipe to delete behind a feature flag (https://github.com/mozilla-mobile/fenix/pull/15009) 4 years ago
Mozilla L10n Automation Bot fcf4731ce7 [fenix] Import l10n. 4 years ago
codrut.topliceanu 26583d2e05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14546 - Speculative fix for ANR 4 years ago
Gabriel Luong cc0e0a0375 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14145 - Add pinned badge for pinned sites 4 years ago
Mugurell 492d49af18 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14974 - Ensure website bottom elements stay at bottom
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
4 years ago
codrut.topliceanu f925e12816 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14559 - Persist searchFragment keyboard status 4 years ago
Elise Richards cf23eb072c [fenix] Access shared prefs in fxa pairing (https://github.com/mozilla-mobile/fenix/pull/14997) 4 years ago
Jeff Boek 81afb0b9c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14283 - Fixes overlapping search suggestions and hint 4 years ago
ekager 71abc5c450 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2486 - Adds Recently Closed Tabs 4 years ago
codrut.topliceanu 2edcda4461 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14725 - Resize search engine radio button 4 years ago
ekager 90f9a16f0d [fenix] No issue - Updates AC to 58.0.20200910190642 and fixes imports 4 years ago
Mugurell bea5d9ddce [fenix] For https://github.com/mozilla-mobile/fenix/issues/14902 - Disabling bottom toolbar animation now works (https://github.com/mozilla-mobile/fenix/pull/14927) 4 years ago
Jeff Boek 5d53b9e168 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5745 - Create preference to disable domain autocompletion 4 years ago
Mozilla L10n Automation Bot 0bfaea4f45 [fenix] Import l10n. 4 years ago
Elise Richards 892a22f6f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14239: Notification for QR scan when permissions have been denied (https://github.com/mozilla-mobile/fenix/pull/14553)
* Show dialog when permissions are denied

* Add qr permissions dialog to search dialog fragment

* Add qr permissions dialog to the pairing screen

* Show dialog after permissions have been denied

* Reset focus after denying permissions

* Show dialog after permissions denied in search frag and par frag

* Use shared preferences to store camera permission state

* Move dialog creation into the search controller and add tests

* Dialog controller implementation and test

* Route to intent with correct activity. Set focus when dismissing dialog

* Get preferences in old search
4 years ago
Abhijit Kiran Valluri a03cffe60a [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/14950 - Make the "Add new tab" button visible in private mode on light theme (https://github.com/mozilla-mobile/fenix/pull/14951) 4 years ago
Mugurell ee9bd92708 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14903 - Prevent BrowserFragment's view leak 4 years ago
Oana Horvath 4af151c433 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13829: Disables verifyAddonsCanBeUninstalled UI test 4 years ago
ekager b2a9e73051 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13467 For https://github.com/mozilla-mobile/fenix/issues/14910 - Dismiss dialog on blank URL commit 4 years ago
ekager c3ba6ed946 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14680 - Revert ObserverRegistry changes to WifiConnectionMonitor 4 years ago
Michael Debertol 9b9f049e26 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14212: Pass historyStorage to ToolbarView 4 years ago
Michael Debertol f89a293cd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13423: Pass isPrivate flag to ToolbarView 4 years ago
Mozilla L10n Automation Bot 48f75eef5d [fenix] Import l10n. 4 years ago