Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity
7,206 Commits 67 Branches 116 Tags 1.2 GiB
54549c49ec
Commit Graph

6010 Commits

Author SHA1 Message Date
Jonathan Almeida
0f35700e00 Close #20795: Speculative fix for intermittent test failures in HomeFragmentTest 
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
 2021-08-14 01:52:52 -04:00
Jonathan Almeida
0556e6b1c4 Close #20797: Fix intermittent test failures in ShortcutsSuggestionProviderTest 2021-08-14 01:52:52 -04:00
Jonathan Almeida
545a59ac97 Close #20792: Fix intermittent test failures in QuickSettingsFragmentReducerTest 2021-08-14 01:52:52 -04:00
Aaron Train
5ff2c21849
Filter out test target packages in Flank-x86 (#20841) 
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
 2021-08-13 15:00:10 -04:00
Michael Comella
667ef89220 No issue: move kotlin-allopen outside appVariants loop. 
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
 2021-08-12 20:39:27 +00:00
Elise Richards
ea56dd216b
Use header20 style on collections to match other home items. Add margin above collections. (#20633) 2021-08-12 19:32:38 +00:00
Jonathan Almeida
2426384a2e Update the description for an inactive tabs string 2021-08-12 17:44:56 +00:00
Steven Knipe
1f9b1fa0d5 For #4134 Add Forward Back Reload to Toolbar on Tablets 2021-08-12 13:54:13 +00:00
codrut.topliceanu
f2862eef6a For #20098: Allow PB PiP video screenshots 
...when `Allow screenshots in private browsing` is enabled
 2021-08-12 06:49:55 +00:00
Rohan Maity
c45703db07 For #20596 remove perf.startup probes 2021-08-11 22:31:52 +00:00
Arturo Mejia
463728e007 For #20764 add screen for opting out of experiments 2021-08-11 16:14:13 -04:00
Arturo Mejia
71f1f6b88b Disable intermittent tests. 2021-08-11 19:05:06 +00:00
Arturo Mejia
823c89f4ff For #20672 crash when attempting to disconnect from Mozilla account 2021-08-11 17:39:33 +00:00
codrut.topliceanu
94cf03a1ca For #17917: Use View binding in history screens 2021-08-11 15:29:35 +00:00
codrut.topliceanu
6a1efacf3a For #17917: Use View binding in collections 2021-08-11 08:01:58 +00:00
Vitaly V. Pinchuk
5093e7a5d6 Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes. 2021-08-10 12:01:29 +00:00
Michael Comella
cc380695b8 No issue: remove unnecessary robolectric annotations. 
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
 2021-08-10 00:22:44 +00:00
Elise Richards
7fdad978a3
For FNXV2-17067: always show home in background behind search dialog (#20573) 
* Navigate to home on toolbar click. Handle back press from search dialog

Update tests to show home behind search dialog. Remove unused test.

Jump back in show all button is clickable behind search dialog

Recently saved bookmarks show all button is clickable behind search dialog

* Add feature flag

* Past explorations show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests.

Allow collections to be visible behind search dialog

Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard

Verify navigateUp in tests

Adding ignore for flaky UI test

Only resize home behind search dialog

Add ignore for collection intermittent test

Cleanup
 2021-08-09 15:40:41 +00:00
codrut.topliceanu
003a2ce81a For #17917: Use View binding in downloads screen 2021-08-09 11:06:28 +00:00
mcarare
55ccfda759 For #20425: Re-add tests for class BookmarksUseCaseTest. 2021-08-09 09:46:27 +00:00
AndiAJ
7a02db22c3 Start on home UI tests 2021-08-09 07:34:16 +00:00
Mozilla L10n Automation Bot
1c9af7c24a Import l10n. 2021-08-09 00:41:53 +00:00
Mozilla L10n Automation Bot
642dd517f9 Import l10n. 2021-08-08 00:40:54 +00:00
Jonathan Almeida
8c975c6646 Close #20726: Fix intermittent failure in AddonsManagementViewTest 2021-08-06 22:27:28 +00:00
Jonathan Almeida
5442798b38 Issue #20718: Show url if title is missing for inactive tabs 2021-08-06 22:00:38 +00:00
Elise Richards
70068ee39b Correct search_count telemetry after revert 2021-08-06 21:26:43 +00:00
Roger Yang
3becd30139 Closes #20723: Fix credit card management fragment binding 2021-08-06 20:59:38 +00:00
Michael Comella
4c6566a0d2 Closes #20697: replace mockked lambda in DownloadControllerTest. 
This is expected to fix the intermittent failure in this test.
 2021-08-06 20:32:16 +00:00
Michael Comella
3994747be9 Closes #20679: revert allowaccessmodification proguard disabling. 
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.

This commit reverts the following commits:

Revert "Proguard/r8: Do not allow access modification."
This reverts commit 98bf27fdd4.

Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit 88fe3fbf82.
 2021-08-06 20:07:32 +00:00
Jonathan Almeida
31081073e9 Issue #19956: Add telemetry for tab view setting changes 
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in #19809).
 2021-08-06 19:33:54 +00:00
Christian Sadilek
01555c2bea
Update Android Components version to 92.0.20210806164329 (#20722) 
Addresses breaking change in ShortcutsSuggestionProvider
 2021-08-06 14:19:56 -04:00
codrut.topliceanu
f9d6380ab3 For #17917: Use View binding in bookmarks screen 2021-08-06 15:52:00 +00:00
Jonathan Almeida
d6bc93981d Issue #20663: Make inactive card collapsible 
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.

In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
 2021-08-06 15:23:10 +00:00
Mugurell
0bc64e8ca8 For #17917 - Add a Kotlin synthetics Lint detector 
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
 2021-08-06 14:09:15 +00:00
codrut.topliceanu
4b21f52db4 For #20310 - Adds Recently Closed button to tabsTray 2021-08-06 12:37:44 +00:00
Grisha Kruglov
ec98db4e54 External source support 
Adds handling of information about external referrer (package, category)
when dealing with external intents.
 2021-08-05 17:30:00 -07:00
Roger Yang
2ac5a38120 Revert "For #18711: Telemetry for credit card autofill (#19548)" 
This reverts commit e0b410efdf.
 2021-08-05 18:53:46 +00:00
Roger Yang
2ed4115a6c Revert "For #18711 - Refactor credit card telemetry under the Metrics ping (#19733)" 
This reverts commit 172a118a51.
 2021-08-05 18:53:46 +00:00
Mozilla L10n Automation Bot
691c751db8 Import l10n. 2021-08-05 16:53:04 +00:00
Mugurell
3a33f65bc0 For #20584 - Speculative fix for ToolbarViewTest failing in CI 
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
 2021-08-05 15:52:06 +00:00
Mugurell
27d3a3f0dd For #20584 - Use CombinedHistorySuggestionProvider for history suggestions 
This should ensure user is always presented with history results for his
searches.
 2021-08-05 15:52:06 +00:00
Mozilla L10n Automation Bot
356fd2e029 Import l10n. 2021-08-05 14:48:56 +00:00
Jonathan Almeida
ca51ac6168 Issue #20664: Do not consider newly created tabs as inactive 2021-08-05 01:37:43 +00:00
Jonathan Almeida
dcd7deffc4 Close #20674: Remove elevation from inactive tabs card 2021-08-05 01:37:43 +00:00
Sebastian Kaspari
145f1898f1 Enable Android Autofill in Beta builds. 2021-08-04 21:07:42 +00:00
mcarare
066f9d7f5d For #20601: Use View binding in quick settings. 2021-08-04 09:32:08 -04:00
Mozilla L10n Automation Bot
fb7af3cdb6 Import l10n. 2021-08-04 01:09:21 +00:00
Arturo Mejia
0b43eb879e For #19970 [Crash] IllegalStateException when navigating to TP panel 2021-08-04 00:17:13 +00:00
Christian Sadilek
56d4e7a72d Fix intermittent test failures in ToolbarViewTest 2021-08-03 23:34:02 +00:00
Roger Yang
c55c252f9a Closes #20650: Revert to manually close tab as default setting 2021-08-03 22:44:14 +00:00
Arturo Mejia
525e5e7c25 For #20601: Undo Use View binding in quick Settings. 2021-08-03 15:34:38 -04:00
Michael Comella
1963d502c7 Closes #20461: remove app_received_intent probe. 2021-08-03 18:19:12 +00:00
Sebastian Kaspari
1cc4ae9ab2 Fix UI tests: SettingsPrivacyTest, DeepLinkTest. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
7fed8b4ab5 Add preference for enabling/disabling Android Autofill from within the app. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
4774f8396b Add dialog-like theme for AutofillSearchActivity 2021-08-03 11:10:21 +00:00
Michael Comella
9889f478ef Closes #20631: remove @Ignore on StorageStats tests. 
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
 2021-08-03 08:53:44 +00:00
Sebastian Kaspari
8857a79ca8 Fix intermittent test failures in TabsTouchHelperTest 2021-08-03 01:10:38 +00:00
Mozilla L10n Automation Bot
bc220ec85f Import l10n. 2021-08-03 00:36:57 +00:00
Sebastian Kaspari
d0a63754c2 Fix intermittent test failures in DefaultBrowserToolbarControllerTest 2021-08-02 23:20:46 +00:00
Sebastian Kaspari
ef3ef87ce2 Fix intermittent test failures in DefaultSessionControlControllerTest. 2021-08-02 22:54:05 +00:00
Michael Comella
c6a4d0afed Closes #20627: replace mocked lambda in HistoryItemMenuTest. 
This will prevent intermittent failures with Java 11.
 2021-08-02 22:21:54 +00:00
Michael Comella
700033ee76 For #20518: disable metrics we don't want to renew. 2021-08-02 19:12:25 +00:00
Michael Comella
296dc9c116 For #20518: link to data renewal request. 2021-08-02 19:12:25 +00:00
Michael Comella
bbd80b98ea For #20518: renew perf telemetry probes (August expiry). 
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
 2021-08-02 19:12:25 +00:00
Elise Richards
7fdade49ec
No issue: fix glean metrics tests for expired metrics (#20621) 
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
 2021-08-02 18:14:17 +00:00
fevziomurtekin
a80b7fa329 For issue: #16396 Fix text contrast ratio on "recently closed tabs" 2021-08-02 11:48:11 +02:00
Jonathan Almeida
69d630f46c Issue #20349: Add inactive tab grouping to tabs tray 2021-08-02 11:44:13 +02:00
Jonathan Almeida
f8945b3720 Issue #20590: 'Jump back in' should obey feature flags 2021-08-02 10:46:38 +02:00
Christian Sadilek
6f3d21b48d Issue #20533: Fix intermittent test failures of DefaultCollectionCreationControllerTest 2021-08-02 10:45:17 +02:00
Rohan Maity
150a5a739e #7346 update lint-baseline.xml and remove activity_addons.xml as unused resource 2021-08-02 10:22:34 +02:00
Gabriel Luong
0f861236c1 Add history metadata feature to the settings menu 2021-07-30 19:31:03 +00:00
Christian Sadilek
1de7e22080 Issue #20533: Fix intermittent failures of DefaultSessionControlControllerTest 2021-07-30 16:56:44 +00:00
Gabriel Luong
cbe79d78cc Add more context for the Past Exploration localization comment 2021-07-30 15:20:33 +00:00
Christian Sadilek
27a7396a42 Keep history metadata for 14 days 2021-07-30 14:50:33 +00:00
Sebastian Kaspari
51cec928b2 Fix intermittent test failures of ModeTest 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
971b419d77 Run ktlintFormat to adapt to latest formatting rules. 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
24e9f64cff Add telemetry for Android Autofill feature. 2021-07-30 09:37:43 +00:00
Christian Sadilek
8fd409b721 Fix intermittent test failures of LoginExceptionFragmentStoreTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
0cd08dc9b1 Issue #20533: Fix intermittent test failures of ExceptionsListItemViewHolderTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
9d92e61ff4 Issue #20533: Fix intermittent test failures in SearchDialogControllerTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
58e8cdfedb Issue #20533: Fix intermittent failures of DefaultTabsTrayControllerTest 2021-07-30 09:12:00 +00:00
mcarare
cca7892e91 For #17917: Use View binding in settings screens. 2021-07-30 08:20:58 +00:00
Mozilla L10n Automation Bot
84d9f272af Import l10n. 2021-07-30 00:28:28 +00:00
Elise Richards
a901341259
For #20516: Renew product telemetry probes expiring in August (#20517) 
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-29 19:14:31 +00:00
mcarare
26e41be02e For #19955 #20393: Add telemetry for home screen recent tabs. 2021-07-29 15:46:02 +00:00
Christian Sadilek
fbd9221c0c Fix intermittent test failures in WebPushEngineIntegrationTest 2021-07-29 14:46:17 +00:00
Christian Sadilek
b3f5c87585 Fix intermittent test failures in FenixSnackbarKtTest 2021-07-29 14:46:17 +00:00
mcarare
8b13e382fd For #17917: Use View binding in lists. 2021-07-29 14:10:36 +00:00
Christian Sadilek
30c890c457 Issue #20531: Fix intermittent test failures in DefaultQuickSettingsControllerTest 2021-07-29 08:07:49 +00:00
Jonathan Almeida
e81c20bc26 Close #19785: Let WebAuthnFeature ride the trains 2021-07-29 06:52:07 +00:00
Arturo Mejia
7e5644036b Put the Start On home setting behind a feature flag. 2021-07-28 16:53:03 -04:00
Christian Sadilek
2dde8c2388 Fix intermittent test failures in NavigationInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
458e8b3cd7 Fix intermittent test failures in PagedHistoryProviderTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
b3895e5fde Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
d0c75740b7 Fix intermittent test failures in BookmarkControllerTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
f03f7c6071 Closes #20533: Fix intermittent failures of HistoryControllerTest 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
41f21fc0f8 RemoveTabUseCaseWrapperTest: Do not mock lambdas. 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
7859d4d681 DefaultRecentlyClosedControllerTest: Do not mock functions 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
9ffd53ee04 Do not mock lambdas in TrackingProtectionPanelInteractorTest. 2021-07-28 17:52:53 +00:00
Christian Sadilek
2f27797530 Closes #20531: Fix intermittent failures of DefaultBrowserToolbarMenuControllerTest 2021-07-28 17:52:53 +00:00
Michael Comella
f7b85a6e95 Closes #20540: always swipe twice to openSettings in ThreeDotMenuMainRobot. 2021-07-28 15:29:03 +00:00
Mozilla L10n Automation Bot
a07775f187 Import l10n. 2021-07-28 14:26:32 +00:00
codrut.topliceanu
e2af42a497 For #20440 - Forces TopSitePager bind if no. of pages changed 2021-07-27 16:19:31 +00:00
Sebastian Kaspari
1cd04cd05e Render debug info screen with Jetpack Compose. 2021-07-27 09:54:24 +00:00
Christian Sadilek
84fdf62240 Fix init order in TrackingProtectionExceptionsViewTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
00d0ed53e0 Fix race condition in ShareViewModelTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
9320700fd7 Remove unused imports in PwaOnboardingObserverTest.kt 2021-07-27 10:08:32 +02:00
Christian Sadilek
4d8d1b4ea2 Use MainCoroutineRule in PwaOnboardingObserverTest 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
7840aac3ba Update Robolectric and mockk. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
781813ab50 Remove over-eager protobuf stripping. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
8d8b6e6d36 Issue #19662: Use Java 11. 2021-07-27 10:08:32 +02:00
Oana Horvath
f37abbe4ae For #20297: close tab to avoid saving the same tab to collection 2021-07-27 07:12:37 +00:00
Mozilla L10n Automation Bot
95f0c48dbf Import l10n. 2021-07-27 00:30:24 +00:00
codrut.topliceanu
302ad8ae85 For #20449 - Fixes Show most visited sites crash on disable 2021-07-26 21:23:56 +00:00
mcarare
a5a4a7f6d9 For #20425: Update AC version 2021-07-26 13:59:46 +00:00
mcarare
c094e1a457 For #20425: Do not show recent bookmarks older than 10 days. 2021-07-26 13:59:46 +00:00
Mozilla L10n Automation Bot
e60de9df5b Import l10n. 2021-07-26 00:30:01 +00:00
Mozilla L10n Automation Bot
4f7424ce4b Import l10n. 2021-07-25 00:35:01 +00:00
Mozilla L10n Automation Bot
67c9d74432 Import l10n. 2021-07-24 00:37:36 +00:00
Mugurell
52e152300d For #20420 - Re-enable shortcutButtonTest 
The issue affecting this was resolved in AC.
 2021-07-23 10:47:33 +00:00
Mugurell
2c8c6d29ea For #20402 - Re-enable "in progress media tab" 
The crash for when media starts playing in a custom tab is now resolved in AC.
 2021-07-22 22:28:54 +00:00
Gabriel Luong
973070ab50 For #20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 2021-07-22 22:28:54 +00:00
Gabriel Luong
9b22b2baa4 For #20438 - Display a list of history metadata groups 2021-07-22 19:19:50 +00:00
Mozilla L10n Automation Bot
ac0f3cc3ad Import l10n. 2021-07-22 16:24:18 +00:00
Michael Comella
30a6e29b25 For #19901: correct spacing in comment on how to run 
Co-authored-by: Jonathan Almeida <git@jonalmeida.com>
 2021-07-22 15:24:35 +00:00
Michael Comella
6d609bc651 For #19901: integrate Jetback Benchmark (microbenchmark). 2021-07-22 15:24:35 +00:00
Christian Sadilek
589f166b29 Issue #16330: Remove remaining usages of Sentry.capture 2021-07-21 20:07:30 +00:00
Mozilla L10n Automation Bot
43aff29816 Import l10n. 2021-07-21 14:36:56 +00:00
codrut.topliceanu
2040af6a5d For #20367 - Fixes removeAllTabs adding to recently closed 
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
 2021-07-20 22:00:04 +00:00
Arturo Mejia
87f73c0109 Fix search_add_custom_engine_search_string_example lint warning. 2021-07-20 22:00:04 +00:00
jhugman
097fa68964
Allow branch enrollment and unenrollment in Nimbus secret menu (#20050) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-20 15:45:37 +00:00
codrut.topliceanu
bc723e0a9b For #15499 - Smoothly updates topSites list on remove 
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
 2021-07-20 15:07:16 +00:00
Mozilla L10n Automation Bot
55fc014071 Import l10n. 2021-07-20 00:40:11 +00:00
Mugurell
094413578c For #20420 - Temporarily disable SearchTest#shortcutButtonTest 2021-07-19 10:12:41 +00:00
Sebastian Kaspari
140274c192 Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1. 2021-07-19 09:20:50 +00:00
Sebastian Kaspari
8b5aef7def Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 2021-07-19 09:20:50 +00:00
Jonathan Almeida
41ba94b951 Issue #20402: Disable LastMediaAccessMiddleware temporarily 
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.

The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.

For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
 2021-07-17 01:21:13 +00:00
Mozilla L10n Automation Bot
9ef8515528 Import l10n. 2021-07-17 00:27:34 +00:00
Mozilla L10n Automation Bot
fb15f1774c Import l10n. 2021-07-16 00:34:42 +00:00
Roger Yang
c4347a9492 Closes #19847: Add telemetry for the default browser notification 2021-07-15 19:35:45 +00:00
Oana Horvath
81849ec6d0 No issue: adds warning comment to beta & release running tests 2021-07-15 19:03:13 +00:00
Roger Yang
049811fabb Issue #20307: Clear sharedViewModel selectedFolder when backing out of bookmark fragment 2021-07-15 15:28:29 +00:00
Roger Yang
80721e2d73 Issue #19989: Add rounded corners to recently tabs' icon 2021-07-15 14:20:11 +00:00
Mugurell
1251894933 For #19933 - Show a media tab item on homescreen for the last tab with media 2021-07-15 10:05:20 +03:00
Roger Yang
68b56ff240 Issue #19846: Make sure default browser notification only happens once 2021-07-15 02:17:24 +00:00
Mozilla L10n Automation Bot
317cbe9c7b Import l10n. 2021-07-15 00:29:47 +00:00
Mugurell
f95567912f For #20229 - Use the AC common implementation for ads/search telemetry 
Everything should work exactly as before.
 2021-07-14 17:55:24 +03:00
mcarare
b2a5723bad For #20292: Use tint for home button icon. 2021-07-14 07:48:13 +00:00
mcarare
b25f807eea For #17808: Remove deprecated systemUiVisibility and flags. 2021-07-14 07:19:25 +00:00
Mozilla L10n Automation Bot
9b3f312301 Import l10n. 2021-07-14 00:59:46 +00:00
Oana Horvath
df960c4187 For #10915: fix tests by removing existing session 2021-07-13 08:18:50 +00:00
Rohan Maity
f8599860dd For #1268 Add Unit test for PrivateShortcutCreateManager 2021-07-13 10:48:52 +03:00
Mozilla L10n Automation Bot
7975309952 Import l10n. 2021-07-13 00:39:50 +00:00
Mozilla L10n Automation Bot
41a6234765 Import l10n. 2021-07-12 23:27:16 +00:00
Jonathan Almeida
4b4c86551d Close #20320: Use scope from testDispatcher in RecentBookmarksFeatureTest 2021-07-12 23:05:03 +00:00
Jonathan Almeida
b877430bad Close #20267: Filter out network errors from Nimbus 2021-07-12 22:42:05 +00:00
Marc Leclair
298ec5cce1 For #19804: Restore logic to original behavior 2021-07-12 22:20:03 +00:00
Marc Leclair
871cde764e For #19804: checkDefaultBrowser moved to helper function 2021-07-12 22:20:03 +00:00
Marc Leclair
db01fab8a9 For 19804:Fixed call order in the 2021-07-12 22:20:03 +00:00
Marc Leclair
b8bbdb45bc For #19804: Changed var isDefaultBrowser to a function 
The change to the function makes it so when the Settings.kt class is initialized, the isDefaultBrowser, which calls the
BrowserCache, won't get called right away. `isDefaultBrowser()` is known to take quite a while on start up on the G5+ (approx
30-40ms).
 2021-07-12 22:20:03 +00:00
Michael Comella
79fcbcba83 Closes #20127: fix app_received_intent extras. 
Apparently, it had been using the wrong mapping this whole time. I can't
wrap my head around fenix's glean wrapper so I'm not sure if this
resulted in bugs or if my change changes the behavior. However, I don't
think anyone is using this probe so I'm requesting to remove it. If we
don't end up removing it, then we can check for bugs/changes in
behavior. This isn't ideal but I'd rather not spend the time on it if we
don't have to.
 2021-07-12 21:53:54 +00:00
Michael Comella
7f4ac14f66 For #20127: remove app_opened_all_startup from metrics.yaml. 2021-07-12 21:53:54 +00:00
Michael Comella
be64ee4159 For #20127: remove app_opened_all_startup integration. 2021-07-12 21:53:54 +00:00
Mozilla L10n Automation Bot
273d7ce947 Import l10n. 2021-07-11 00:30:23 +00:00
Mozilla L10n Automation Bot
64038252e6 Import l10n. 2021-07-10 00:33:37 +00:00
Roger Yang
142730faaa Closes #20285: Remove unused GeckoProvider 2021-07-09 22:40:26 +00:00
Elise Richards
9bfe9b0787
For FNX-22339: Recently saved bookmarks (#19835) 
* Title and button for home screen recently saved bookmarks section

Create bookmark item view with favicon and title

* View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

Make a use case for retrieving and updating the list of recently saved bookmarks

Add adapter items and define header viewholder binding

Use session interactor for header button clicks. Bind in the adapter

* Retrieve list of bookmarks asynchronously on home

Interactor and controller tests

Address review comments

Split up tests for recent bookmarks

Update to new interactors

Dark mode and light mode styles

Refactor bookmarks home stuff

* Add RecentBookmarksFeature to home

Move interactor to SessionControlInteractor

Clean up lint, styles, and dimens.

* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.

* View holder tests

* Match ux to designs for colors, margins, and scrolling

* Clean up clean up

* Tests for the view bound feature

* Controller test

* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-07-09 19:36:20 +00:00
Mozilla L10n Automation Bot
ff9aa36885 Import l10n. 2021-07-09 00:35:12 +00:00
Roger Yang
d4af9401d1 Closes #19846: Update default browser notification strings 2021-07-08 22:04:13 +00:00
Roger Yang
6d1a44e259 Closes #19846: Only add default browser notification work if work is not pending 2021-07-08 18:36:14 +00:00
Roger Yang
0133f42a15 Closes #19846: Show Default Browser Notification if browser is not default 2021-07-08 17:52:08 +00:00
codrut.topliceanu
3ae6472e16 For #20257 - Sets min no. of grid columns to 2 in TabsTray 2021-07-08 14:54:43 +00:00
codrut.topliceanu
083d50aafd For #20250 - Adds FLAG_SECURE to TabsTray dialog 2021-07-08 08:49:06 +00:00
codrut.topliceanu
d530f5b773 For #17855 - Stops SecureWindowFeature from removing FLAG_SECURE 2021-07-08 08:02:35 +00:00
Mozilla L10n Automation Bot
5e7b422433 Import l10n. 2021-07-08 00:38:02 +00:00
Grisha Kruglov
946fda55aa Closes #20276: Fall-back to URL parsing for tabs with parents to obtain search terms 2021-07-07 15:01:26 +00:00
Oana Horvath
ea3e4c9956 No issue: New UI smoke test for the Language menu 2021-07-07 12:18:16 +00:00
mcarare
b43db5f2b6 For #20029: Remove animations when recreating activity on locale change. 2021-07-07 10:12:51 +00:00
codrut.topliceanu
9693507ffb For #19131 - Adds kdoc to TopSitePagerPayload 2021-07-07 07:22:45 +00:00
codrut.topliceanu
a7f3d34538 For #19131 - Fixes top sites refresh and interactability 2021-07-07 07:22:45 +00:00
Mozilla L10n Automation Bot
4a0cd8a25a Import l10n. 2021-07-07 00:36:50 +00:00
Roger Yang
702e3e6886 Closes #20274: Limit about:config to Nightly and Beta 2021-07-06 23:32:16 +00:00
Roger Yang
e69f3dfbbb Closes #19090: Show snackbar on adding to bookmarks from tabs tray 2021-07-06 22:13:38 +00:00
mcarare
36b50ea8d9 For #17917: Use View binding in onboarding cards. 2021-07-06 16:29:09 +00:00
Christian Sadilek
7c57898c76 Closes #20123: PlacesException when recording history metadata 2021-07-05 17:12:54 -04:00
Jonathan Almeida
4bab66bb21 Move Nimbus strings to static_strings 
Goes with 6bb89f346e01edd431056bfcd7472bc3082a39a5
 2021-07-05 19:30:58 +00:00
mcarare
0c720ba500 For #20219: Fix constraints in sign-in onboarding card. 2021-07-05 08:38:30 +00:00
mcarare
a7a45df8fb For #20154: Override AC fill colors for icons. 2021-07-05 08:15:34 +00:00
Mozilla L10n Automation Bot
0a5be636f9 Import l10n. 2021-07-05 00:31:23 +00:00
Mozilla L10n Automation Bot
0e43a42c1e Import l10n. 2021-07-04 00:32:48 +00:00
Mozilla L10n Automation Bot
4bdd54d065 Import l10n. 2021-07-02 00:29:59 +00:00
codrut.topliceanu
ce0773fcdc For #19558 - Adds proper tint to "Report Site Issue" 2021-07-01 14:40:03 +00:00
Oana Horvath
d20bebc2a3 For #20000: Re-try swipe on collection items 2021-07-01 11:45:22 +00:00
Mozilla L10n Automation Bot
852034d77a Import l10n. 2021-07-01 00:35:28 +00:00
Codrut Topliceanu
af1c00a645
For #20195 - Adds tabsTray allowScreenshotsInPrivateMode check (#20203) 
* For #20195 - Adds tabsTray allowScreenshotsInPrivateMode check
 2021-06-30 18:37:16 +03:00
mcarare
4101974415 For #20190: Mirror back button in RTL. 2021-06-30 15:35:11 +03:00
mcarare
023e1b4b30 For #20154: Override AC fill colors for icons. 2021-06-30 15:04:08 +03:00
Mozilla L10n Automation Bot
cb5468cfe4 Import l10n. 2021-06-29 00:32:15 +00:00
Mozilla L10n Automation Bot
384e8f84df Import l10n. 2021-06-28 00:30:01 +00:00
Mozilla L10n Automation Bot
736789bd2a Import l10n. 2021-06-27 00:34:31 +00:00
Mozilla L10n Automation Bot
daa1767317 Import l10n. 2021-06-26 00:30:31 +00:00
Mozilla L10n Automation Bot
5921c631f2 Import l10n. 2021-06-25 13:01:07 +00:00
Oana Horvath
c830ed9986 For #20123: Disable historyMetadataFeature flag 2021-06-25 10:11:03 +00:00
Mozilla L10n Automation Bot
2c99bb8031 Import l10n. 2021-06-24 00:37:38 +00:00
Travis Long
a2984e6863 [SDK-279] Adds a way to switch to the "preview" collection in Nimbus 
This adds a toggle/switch to the debug settings menu that causes Nimbus to use the "preview" collection rather than the "main" collection when it initializes.  Since it is only applied during init, it does require a restart in order to take effect.
 2021-06-23 22:20:31 +00:00
Gabriel Luong
7aea29d57b For #19951 - Use Proton icon for new home button 2021-06-23 17:34:31 +00:00
Arturo Mejia
29f5567869 For #19922 Fix the default autoplay setting to be block audio only 2021-06-23 09:02:04 -04:00
Mozilla L10n Automation Bot
f24072c915 Import l10n. 2021-06-23 00:28:26 +00:00
Mugurell
5d62fe11a6 For #20046 - Show the last accessed tab in Jump back in 2021-06-22 22:03:33 +00:00
jhugman
8b32f7dcda
Add error reporting via sentry to Nimbus caught exceptions (#20049) 2021-06-22 13:27:32 +00:00
Roger Yang
cabd004390 Closes #19182: Close Tabs Tray when sharing completes 2021-06-22 02:53:02 +00:00
Roger Yang
74c1cc82fb Closes #19921: Update appcompat and fragment dependencies to 1.3.x 2021-06-22 01:39:52 +00:00
Mozilla L10n Automation Bot
7dbfca2d2e Import l10n. 2021-06-22 00:29:33 +00:00
Arturo Mejia
1d76bc7ca2 For #19922 Update the default autoplay setting to be block audio only 2021-06-21 16:46:54 -04:00
Jonathan Almeida
15df06b294 Issue #20054: Update recent tab on title or icon changes 2021-06-21 18:27:33 +00:00
Arturo Mejia
251bfc7fe9 Improvements to site permissions 2021-06-21 17:21:16 +00:00
codrut.topliceanu
37e2c6ceeb For #19739 - Adds start tabsTray with multiSelect support 2021-06-21 16:17:09 +00:00
codrut.topliceanu
2c538dbb5d For #16330 - Replaces Sentry.capture with submitCaughtException 2021-06-21 09:05:33 +00:00
Mozilla L10n Automation Bot
841265e39d Import l10n. 2021-06-21 00:59:30 +00:00
Mozilla L10n Automation Bot
cf0fab08f5 Import l10n. 2021-06-20 00:29:50 +00:00
Mozilla L10n Automation Bot
79229ebdbd Import l10n. 2021-06-19 00:31:15 +00:00
Mugurell
b3a6dcccd7 For #19797 - Remove FenixAccountManager#authenticatedAccount 
This api had a bug stemming from the property name - authenticatedAccount which
may return even an unauthenticated account.
After the recent refactorings it was left unused so best to remove it to
prevent from future misuses.
 2021-06-18 17:09:25 +03:00
Mugurell
ce64c2439d For #19797 - Use the FXA email only if the account is authenticated 
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
 2021-06-18 17:09:25 +03:00
Mugurell
19af5e9b15 For #19797 - Remove FenixAccountManager#signedInToFxa 
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
 2021-06-18 17:09:25 +03:00
Mugurell
1fc3bb84ca For #19797 - Home menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
3d071dd049 For #19797 - Browser menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
d663383cf7 For #19797 - New FenixAccountManager#getAccountState() 
This new method allows a single source of truth for getting the up-to-date
account status without clients interesting in this needing to know what to
check for.
 2021-06-18 17:09:25 +03:00
Elise Richards
80de7fd7ba
Define the width/height for homescreen empty collections button (#20082) 2021-06-17 17:57:21 -05:00
Grisha Kruglov
2198298df5 Obtain searchTerms from previous page in tab's history 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-06-17 18:02:36 -04:00
Elise Richards
1a8ae21250
Define the width/height for sync sign in button on tabs tray (#20080) 2021-06-17 16:49:03 -05:00
bharat0to
6de3062738
For #18581 ETP Standard option is truncated (#18586) 2021-06-17 16:42:08 -05:00
Elise Richards
79af077b2f
Update glean notification emails to new email group (#20070) 2021-06-17 14:48:34 -05:00
Arturo Mejia
c2439914fa For #19881 add telemetry for start on Home. 2021-06-17 13:09:28 -04:00
Jonathan Almeida
aee14d8c19 Close #19950: Fix intermittent failure in SearchDialogControllerTest 2021-06-17 11:37:05 -04:00
Mihai Adrian Carare
9c9e26953f
For #19813: Invalidate tab tray adapter structure on screen rotation. (#20044) 2021-06-17 13:57:50 +03:00
Jonathan Almeida
854da1ac9d Issue #20053: Disabling collection smoke tests temporarily 
The changes from #19090 did not fix the issue consistently, and are
causing failures intermittently on-unrelated PRs.

Disabling these tests again until we have another fix for #19090.
 2021-06-17 10:25:08 +03:00
Christian Sadilek
b123b50df7 HistoryMetadataMiddleware: Use state ext. functions from A-C 2021-06-16 19:22:56 -07:00
Mozilla L10n Automation Bot
03b797efb7 Import l10n. 2021-06-17 00:28:28 +00:00
mcarare
df2efcf310 For #20024: Visit FAB after synced tabs in a11y traversal. 
This helps focus on FAB without going through whole tab lists.
 2021-06-16 19:01:24 -04:00
Jonathan Almeida
5be35df969 Revert "For #19739 - Adds start tabsTray with multiSelect support" 
This reverts commit d8288f5e89.
 2021-06-16 16:57:59 -04:00
Jonathan Almeida
aeb186f79c Revert "For #19739 - Moves argument to initial state init" 
This reverts commit f198e110d7.
 2021-06-16 16:57:59 -04:00
codrut.topliceanu
f198e110d7 For #19739 - Moves argument to initial state init 2021-06-16 13:16:18 -04:00
codrut.topliceanu
d8288f5e89 For #19739 - Adds start tabsTray with multiSelect support 2021-06-16 13:16:18 -04:00
Mihai Adrian Carare
83a5aa2838
For #20007: Multiselect title is important for a11y just in select mode. (#20008) 2021-06-16 13:13:42 +03:00
mcarare
77023db091 For #19820: Specify usage of labels for a11y services. 2021-06-16 08:49:12 +03:00
Mozilla L10n Automation Bot
e969afaed7 Import l10n. 2021-06-16 00:43:59 +00:00
Elise Richards
c32ae710dd
For #19923: renew telemetry probes (#19924) 2021-06-15 18:08:01 -05:00
Gabriel Luong
c0329f3c26 For #19988 - Part 2: Load tab icon from BrowserIcons cache if needed for the recent tab 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
Gabriel Luong
ad91f91eb6 For #19988 - Part 1: Move RecentTabsListFeature into recenttabs package 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
AndiAJ
78edf06a7a Text selection tests 2021-06-15 17:07:13 +03:00