Use MainCoroutineRule in PwaOnboardingObserverTest

upstream-sync
Christian Sadilek 3 years ago committed by Sebastian Kaspari
parent 7840aac3ba
commit 4d8d1b4ea2

@ -13,15 +13,18 @@ import io.mockk.mockk
import io.mockk.spyk
import io.mockk.verify
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.TestCoroutineDispatcher
import mozilla.components.browser.state.action.ContentAction
import mozilla.components.browser.state.state.BrowserState
import mozilla.components.browser.state.state.createTab
import mozilla.components.browser.state.store.BrowserStore
import mozilla.components.feature.pwa.WebAppUseCases
import mozilla.components.support.test.ext.joinBlocking
import mozilla.components.support.test.rule.MainCoroutineRule
import org.junit.After
import org.junit.Before
import org.junit.Ignore
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -38,6 +41,11 @@ class PwaOnboardingObserverTest {
private lateinit var settings: Settings
private lateinit var webAppUseCases: WebAppUseCases
private val testDispatcher = TestCoroutineDispatcher()
@get:Rule
val coroutinesTestRule = MainCoroutineRule(testDispatcher)
@Before
fun setUp() {
store = BrowserStore(
@ -53,13 +61,13 @@ class PwaOnboardingObserverTest {
settings = mockk(relaxed = true)
webAppUseCases = mockk(relaxed = true)
pwaOnboardingObserver = spyk(PwaOnboardingObserver(
pwaOnboardingObserver = PwaOnboardingObserver(
store = store,
lifecycleOwner = lifecycleOwner,
navController = navigationController,
settings = settings,
webAppUseCases = webAppUseCases
))
)
every { pwaOnboardingObserver.navigateToPwaOnboarding() } returns Unit
}
@ -69,7 +77,6 @@ class PwaOnboardingObserverTest {
}
@Test
@Ignore("With latest Robolectric/mockk: Settings().incrementVisitedInstallableCount()) was not called")
fun `GIVEN cfr should not yet be shown WHEN installable page is loaded THEN counter is incremented`() {
every { webAppUseCases.isInstallable() } returns true
every { settings.userKnowsAboutPwas } returns false
@ -82,7 +89,6 @@ class PwaOnboardingObserverTest {
}
@Test
@Ignore("With latest Robolectric/mockk: Settings().incrementVisitedInstallableCount()) was not called")
fun `GIVEN cfr should be shown WHEN installable page is loaded THEN we navigate to onboarding fragment`() {
every { webAppUseCases.isInstallable() } returns true
every { settings.userKnowsAboutPwas } returns false

Loading…
Cancel
Save