Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Code Issues Releases Wiki Activity
2,818 Commits 67 Branches 115 Tags 1.2 GiB
533d10e3b1
Commit Graph

2415 Commits

Author SHA1 Message Date
mcarare
7a289d1eb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private 2019-12-04 16:44:01 -08:00
Jeff Boek
e6709a82d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
4e988fce7b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
e51c588fd7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Emily Kager
4ce302d29f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar (https://github.com/mozilla-mobile/fenix/pull/6911) 2019-12-04 15:01:04 -08:00
Jeff Boek
7f7685689f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL (https://github.com/mozilla-mobile/fenix/pull/6955) 
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
 2019-12-04 15:00:51 -08:00
Sebastian Kaspari
ad503a83c1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976: Reuse Fennec launcher entry in manifest. 
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.

A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
 2019-12-04 12:51:48 -08:00
Oana Horvath
0cb634facc [fenix] Added multi-selection tests for bookmarks (https://github.com/mozilla-mobile/fenix/pull/6475) 
Updated bookmarking method

Fixed flaky tests

Added wait to create bookmark
 2019-12-03 12:44:54 +02:00
mawen7
bbfa8aadd4 [fenix] Run lint for app module and set baseline 2019-12-02 14:45:34 -08:00
Aaron Train
0e77c47f42 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests (https://github.com/mozilla-mobile/fenix/pull/6574) 
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
 2019-12-02 17:15:00 -05:00
ekager
333ff28126 [fenix] No issue: Fix search suggestions strings 2019-12-02 21:39:10 +00:00
ekager
c09e977ff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6791 - Inflate SavedLoginsListItemViewHolder layout explicitly 2019-12-02 10:40:58 -08:00
ekager
4f0bcac5b8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6889 - Check current destination before navigating from settings 2019-12-02 10:40:21 -08:00
ekager
41af91db69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6890 - Don't crash with no connection when adding custom search engine 2019-12-02 10:37:31 -08:00
Severin Rudie
312a66c20e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5540: updates error page copy when no internet is available (https://github.com/mozilla-mobile/fenix/pull/6803) 2019-12-02 10:26:06 -08:00
cesar
8a51b43fbc [fenix] test fixed 2019-12-02 16:18:48 +00:00
cesar
9b868c1e0b [fenix] nested loop removed 2019-12-02 16:18:48 +00:00
cesar
51fe91d723 [fenix] klint clean up and previous nit fixed 2019-12-02 16:18:48 +00:00
cesar
cc1bfd730b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6731 - fixed BookmarkNode minus operator and deleteOperation 2019-12-02 16:18:48 +00:00
cesar
85a1b85158 [fenix] Test for 6731 2019-12-02 16:18:48 +00:00
mcarare
2ca9178898 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6835 Align Home and Browser toolbar elements to perfectly overlap 2019-12-02 16:17:07 +00:00
mcarare
10831c25ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/6401 Set false as default value for Open links in a private tab 2019-12-02 16:16:26 +00:00
mcarare
75330ca583 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6516 On browsing mode change empty tab list before displaying new list 2019-12-02 16:15:54 +00:00
Tiger Oakes
4426480f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6827, https://github.com/mozilla-mobile/fenix/issues/6811 - Cast layoutParams to MarginLayoutParams 2019-12-02 14:52:31 +00:00
mcarare
b49fd6c3b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6881 Choose visible view when multiple views have same label text 2019-12-02 14:02:51 +00:00
Oana Horvath
d7bc4a96ce [fenix] Disable UI history tests again for more investigation (https://github.com/mozilla-mobile/fenix/pull/6837) 2019-12-01 19:53:55 -05:00
Tiger Oakes
5bdd21e04e [fenix] Suppress upcoming deprecation (https://github.com/mozilla-mobile/fenix/pull/6765) 2019-11-28 16:17:56 -08:00
Gabriel Luong
30a1862f30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest 2019-11-28 15:58:07 -05:00
Jeff Boek
5c7ec54a11 [fenix] No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
mcarare
68ba4480cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/6629 Align Private Browsing mode to UX specs 2019-11-27 11:13:20 -08:00
ekager
4b720e646f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Track all login copy events 2019-11-27 10:59:36 -08:00
Mozilla L10n Automation Bot
a01d3cc798 [fenix] Import l10n. 2019-11-27 10:52:38 -08:00
Will Hawkins
dc526b557e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5183: Initialize megazord asynchronously 
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
 2019-11-27 10:51:57 -08:00
cesar
5cd156bba2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6769 - EditText moved to be above the gradient view 2019-11-27 10:48:38 -08:00
Sebastian Kaspari
a126b92f9c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622, https://github.com/mozilla-mobile/fenix/issues/6688: Create a "fennecBeta" and "fennecNightly" build types. 2019-11-27 10:28:22 -08:00
mcarare
a6b0fda280 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4219 Set url view not important for accessibility 
Talkback rectangle for url view selection will include parent view
 2019-11-27 10:11:16 -08:00
mcarare
bd55aaeb46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Change notification icon 
Used private browsing icon with compulsory white color for notifications
 2019-11-27 10:08:00 -08:00
mcarare
2711348828 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Remove actions from notification, keep just close private tabs 
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
 2019-11-27 10:08:00 -08:00
Mihai Branescu
6d8117f1ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 - Added metrics for tracking history/bookmarks account sync toggles (https://github.com/mozilla-mobile/fenix/pull/6601) 2019-11-27 11:16:23 +02:00
Mihai Adrian
61b23c7a32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6748 Move Add search engine to search engine preference category. (https://github.com/mozilla-mobile/fenix/pull/6749) 2019-11-27 10:45:05 +02:00
Mihai Adrian
132c68b597 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode. (https://github.com/mozilla-mobile/fenix/pull/6736) 
notifyDataSetChanged to avoid not displayed but created items not being redrawn
 2019-11-27 10:40:38 +02:00
Mihai Adrian
d4557d5a67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Align text to viewStart to keep consistency in RTL (https://github.com/mozilla-mobile/fenix/pull/6778) 2019-11-27 10:35:49 +02:00
Jeff Boek
11b8410367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5972 - Fixes bugs when launching in private mode on Android 5 (https://github.com/mozilla-mobile/fenix/pull/6702) 2019-11-26 14:53:03 -08:00
Sawyer Blatz
58a007659f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6821: Fixes issues with custom tabs and dynamic toolbar (https://github.com/mozilla-mobile/fenix/pull/6822) 2019-11-26 13:02:52 -08:00
Mihai Adrian
8734472571 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6430 Private browsing hint width should not exceed screen dimensions (https://github.com/mozilla-mobile/fenix/pull/6786) 
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
 2019-11-26 10:07:31 -08:00
Sawyer Blatz
723d99864f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054: Allows users to change toolbar position (https://github.com/mozilla-mobile/fenix/pull/6608) 
* For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054: Adds preference screen for toolbar

* For https://github.com/mozilla-mobile/fenix/issues/5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For https://github.com/mozilla-mobile/fenix/issues/6054: Adds toolbar position to core ping
 2019-11-25 16:43:32 -08:00
Tiger Oakes
42d5ef61f9 [fenix] Add toolbar helpers (https://github.com/mozilla-mobile/fenix/pull/6531) 2019-11-25 15:36:47 -05:00
Tiger Oakes
35bf8dfc58 [fenix] Use ShareData with ShareFragment (https://github.com/mozilla-mobile/fenix/pull/6698) 2019-11-25 11:07:21 -08:00
Christian Sadilek
9176a21ab0 [fenix] Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped 2019-11-23 20:25:21 -05:00
Tiger Oakes
21ef894d5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6763 - Fix early view access 2019-11-23 10:55:29 -05:00
Daphne Liu
7be9a0aba7 [fenix] Switched to AC string extensions (https://github.com/mozilla-mobile/fenix/pull/6258) 
* Switched to AC string extensions

* Clean up imports
 2019-11-22 23:15:51 -08:00
ekager
e201d5bf68 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6628 - Remove required for biometric manifest 2019-11-22 14:17:26 -08:00
ekager
8c02806625 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6573 - Fixes anchor view for tab switching snackbar 2019-11-22 14:15:17 -08:00
Sawyer Blatz
a00e212e4c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6436: Adds snackbar for failed download (https://github.com/mozilla-mobile/fenix/pull/6648) 2019-11-22 12:46:57 -08:00
Mozilla L10n Automation Bot
666cdd937f [fenix] Import l10n. 2019-11-22 11:14:22 -08:00
David Walsh
33d54e5f98 [fenix] Fix 6048 - Improve alignment in Edit Bookmark screen 2019-11-22 10:14:00 -08:00
Tiger Oakes
aacb184521 [fenix] Clean up tracking protection fragment (https://github.com/mozilla-mobile/fenix/pull/6532) 
* Clean up exceptions fragment

* Clean up tracking protection fragment

* Move saved logins to list adapter
 2019-11-22 10:38:13 -05:00
Sebastian Kaspari
38e97e4f16 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4982: Migrate Gecko files before initializing engine. (https://github.com/mozilla-mobile/fenix/pull/6738) 2019-11-22 08:18:50 -05:00
Mozilla L10n Automation Bot
3635ac49a7 [fenix] Import l10n. 2019-11-22 14:00:39 +01:00
Stephen Tsimicalis
13e71e46e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4824 - Fixes onboarding telemetry events from being sent a… (https://github.com/mozilla-mobile/fenix/pull/6659) 2019-11-21 17:51:55 -08:00
Mozilla L10n Automation Bot
b4251d143e [fenix] Import l10n. 2019-11-21 16:45:05 -08:00
Pawel Obarzanek
57a08d269e [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/5458 Tests for IntentReceiverActivity to verify outcoming intent (https://github.com/mozilla-mobile/fenix/pull/6130) 2019-11-21 16:44:08 -08:00
Pawel Obarzanek
6957b089ef [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 Initial tests for FragmentPreDrawMan… (https://github.com/mozilla-mobile/fenix/pull/6134) 
* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 Initial tests for FragmentPreDrawManager

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4828 verify if addOnPreDrawListener was called
 2019-11-21 16:23:59 -08:00
Mihai Adrian
da3ecd3ca5 [fenix] Update app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt 
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
 2019-11-21 15:34:01 -08:00
mcarare
5285283d76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3523 Add Firefox Sync error states also to Settings in Home menu 2019-11-21 15:34:01 -08:00
isabelrios
e75264272f [fenix] fix reviewer comments 2019-11-21 15:32:26 -08:00
isabelrios
ee8015ef6c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6322 - UI tests for Account Settings View 
removing sleeps

fix ktlint errors
 2019-11-21 15:32:26 -08:00
Matt McKenna
04552dca30 [fenix] Add Mozilla licensing header to gradient 2019-11-21 15:27:50 -08:00
Matt McKenna
ecfb4c3373 [fenix] Add a simple gradient to collection creation 2019-11-21 15:27:50 -08:00
matthewcmckenna
b0116ebdee [fenix] Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
Tiger Oakes
6605d2388d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6523 - Remove close button in library 2019-11-21 15:27:18 -08:00
Patrick Martin
ccb1057a38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font set (https://github.com/mozilla-mobile/fenix/pull/6724) 
* For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font se

* Update HistoryRobot.kt
 2019-11-21 15:05:59 -08:00
mcarare
3f883d62b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Update unit tests and UI tests 2019-11-21 14:36:14 -08:00
mcarare
1c543b06bf [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Add onboarding search suggestion hint panel 2019-11-21 14:36:14 -08:00
mcarare
f9a51fa99f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1019 Add option to enable search suggestions in private mode 2019-11-21 14:36:14 -08:00
mcarare
b8537c205e [fenix] For https://github.com/mozilla-mobile/fenix/issues/6625 Fix back navigation in search mode from browser 2019-11-21 14:35:12 -08:00
Tiger Oakes
f0969797aa [fenix] Extract TP onboarding popup (https://github.com/mozilla-mobile/fenix/pull/6700) 2019-11-21 17:23:35 -05:00
Arturo Mejia
02b66be3d7 [fenix] No issue: Remove download file provider. (https://github.com/mozilla-mobile/fenix/pull/6699) 2019-11-21 14:31:03 -05:00
Johan Lorenzo
8eef026200 [fenix] Split UI test 2019-11-21 11:59:51 +01:00
Grisha Kruglov
2265e8ee61 [fenix] Enable encryption of persisted FxA account state 2019-11-20 15:32:56 -08:00
Jeff Boek
4d33b453ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Removes the feature flag for Force Enable Zoom (https://github.com/mozilla-mobile/fenix/pull/6646) 
* For https://github.com/mozilla-mobile/fenix/issues/2477 - Removes the feature flag for Force Enable Zoom

* For https://github.com/mozilla-mobile/fenix/issues/2477 - Fixes bug where zoom preference doesnt persist between launches
 2019-11-20 10:32:38 -08:00
ekager
115b18d3a7 [fenix] Add scroll to item 2019-11-20 10:23:48 -08:00
ekager
6477f73c31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6707 https://github.com/mozilla-mobile/fenix/issues/6708 - Fix UI Tests for new Search Engine Behavior 2019-11-20 10:23:48 -08:00
Jeff Boek
daaaeef741 [fenix] Adds custom search engines (https://github.com/mozilla-mobile/fenix/pull/6551) 
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds button to add a new search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds custom engine store

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Creates a custom SearchEngineProvider

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Gives the ability to delete search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the UI to add a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds form to create a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to add a custom search engine

*  For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to delete custom search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Selects the first element on the add custom search engine screen

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Prevents adding a search engine that already exists

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Styles the add search engine preference

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Makes the name check case-insensitive

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fix bug where home screen doesnt see new search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves Search URL validation to its own type

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes linting errors

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to edit a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds an undo snackbar when deleting a search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves all of the strings to be translated

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes bug when deleting your default search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Puts adding search engines behind a feature flag

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Navigate to custom search engine SUMO article when tapping learn more

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes nits

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Uses concept-fetch to validate search string

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds string resources for the cannot reach error state
 2019-11-19 16:30:56 -08:00
Patrick Martin
fe51c6bd42 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2294 - History URL is cut with a large font se 2019-11-19 10:50:17 -08:00
Oana Horvath
ac4939cb9f [fenix] Fixed History flaky tests (https://github.com/mozilla-mobile/fenix/pull/6592) 
Ignoring some tests for now and left some to run
 2019-11-19 11:29:35 +02:00
Mozilla L10n Automation Bot
3af4199c46 [fenix] Import l10n. 2019-11-18 23:08:32 -08:00
mawen7
f99cc9e5c4 [fenix] Jump to tab overview if closed tab has no parent session 2019-11-18 22:56:42 -08:00
cesar
e2610eec54 [fenix] ktlint clean up 2019-11-18 20:07:22 -08:00
cesar
3402ab6636 [fenix] Fixed Typo 2019-11-18 20:07:22 -08:00
cesar
9bc3f93df4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6594 - Trigger keyboard automatically when creating a bookmark folder 2019-11-18 20:07:22 -08:00
cesar
1f32a65e4e [fenix] Test for 6594 2019-11-18 20:07:22 -08:00
cesar
7aea6f6d1a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6593 - Hide keyboard when quitting add bookmark folder flow 2019-11-18 20:07:22 -08:00
cesar
0fd8d98d12 [fenix] Test for 6593 2019-11-18 20:07:22 -08:00
ekager
a616b2aafa [fenix] For https://github.com/mozilla-mobile/fenix/issues/6621 - Add Secure Flag to Window in Logins Fragments 2019-11-18 14:32:10 -08:00
Jeff Boek
47a2a82e33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2271 - Fixes colors on dark theme 2019-11-18 14:23:54 -08:00
David Walsh
ab3dc16a21 [fenix] Provide top padding to URL 2019-11-18 14:01:40 -08:00
David Walsh
9f6b192e93 [fenix] Implement a more dynamic layout height 2019-11-18 14:01:40 -08:00
David Walsh
bfb9982e11 [fenix] Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Mozilla L10n Automation Bot
7e50ca8f44 [fenix] Import l10n. 2019-11-18 13:30:59 -08:00
Sawyer Blatz
213c3ef3e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6434: Fixes downloadCompleted for paused downloads 2019-11-18 11:49:01 -08:00
Jeff Boek
458dee5101 [fenix] No Issue - Fixes NPE in tests (https://github.com/mozilla-mobile/fenix/pull/6673) 2019-11-18 11:29:49 -08:00
Roger Yang
f8b8249b3f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6440 Integrate Web Notifications Feature 2019-11-18 13:44:39 -05:00
Jeff Boek
59fbfbf59b [fenix] No Issue - Adds proguard rules for Lifecycle component (https://github.com/mozilla-mobile/fenix/pull/6632) 
This is a potential fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1596302
 2019-11-15 17:10:38 -08:00
Mihai Adrian
a03829e931 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu for all library items when in select mode. (https://github.com/mozilla-mobile/fenix/pull/6321) 
Used notifyItemRangeChanged to redraw already drawn items.
 2019-11-15 15:48:48 -08:00
Severin Rudie
1199424753 [fenix] 4844 fix url elision (https://github.com/mozilla-mobile/fenix/pull/6588) 
* For https://github.com/mozilla-mobile/fenix/issues/4844: add test cases for url elision

* For 4844: implement toShortUrl to pass test cases

* For 4844: update plumbing to use toShortUrl

* For 4844: adds/handles suggested url elision test case
 2019-11-15 14:25:50 -08:00
Gabriel Luong
23069b57af [fenix] For https://github.com/mozilla-mobile/fenix/issues/5583 - Adds telemetry for download notification (https://github.com/mozilla-mobile/fenix/pull/6554) 2019-11-15 16:50:11 -05:00
Patrick Martin
0ddba7a2f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1695 - Detect HTML mime type for clipboard URL (https://github.com/mozilla-mobile/fenix/pull/6612) 
* For https://github.com/mozilla-mobile/fenix/issues/1695 - Detect HTML mime type for clipboard URL
 2019-11-15 12:23:52 -08:00
MozLando
8d28cdef96 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6513 
6513: For https://github.com/mozilla-mobile/fenix/issues/5295 [A11y] Unable to tap snackbar r=kglazko a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-11-15 18:43:54 +00:00
Will Hawkins
45ed971342 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6196: Make initialization of Glean metrics faster 
setStartupMetrics is very expensive and does not need to be
done synchronously at the time the Glean Metrics Service is
initialized.
 2019-11-15 10:38:08 -05:00
Emily Kager
634ef111d0 [fenix] No issue: Check destination before popping logins fragments 2019-11-14 18:20:44 -08:00
Tiger Oakes
037d35abd1 [fenix] Use ViewModel for share fragment 2019-11-14 16:25:50 -08:00
Tiger Oakes
47200b1308 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4528 - Prevent share menu from jumping 
Plus a bunch of docs and refactoring
 2019-11-14 16:25:50 -08:00
Mozilla L10n Automation Bot
55915910e7 [fenix] Import l10n. 2019-11-14 16:19:30 -08:00
Emily Kager
a4a5315838 [fenix] Add logins to UI test 2019-11-14 16:05:20 -08:00
ekager
8f1e6a7ad0 [fenix] Add override for Core val in test 2019-11-14 16:05:20 -08:00
ekager
fba098576f [fenix] Update BackgroundServicesTest 2019-11-14 16:05:20 -08:00
Emily Kager
f279306478 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 2019-11-14 16:05:20 -08:00
Kate Glazko
75f2cdef22 [fenix] 2019-11-14 13:54:08 -08:00
Tiger Oakes
dde616b728 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5085 - Use CustomTabWindowFeature (https://github.com/mozilla-mobile/fenix/pull/6603) 
Opens _blank links in new custom tab
 2019-11-14 12:02:27 -08:00
mozilla-l10n-automation-bot
f0a242f3a8 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/6530) 2019-11-14 09:58:15 -08:00
Oana Horvath
9f4e9dcc69 [fenix] Added a method to detect the UI Theme (https://github.com/mozilla-mobile/fenix/pull/6542) 2019-11-13 08:52:41 -08:00
Gabriel
6314944213 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5705 - Adds telemetry for media state (https://github.com/mozilla-mobile/fenix/pull/6463) 2019-11-12 17:24:30 -08:00
David Walsh
adfd7798e5 [fenix] Use consistent verbiage with regard to opened tabs (https://github.com/mozilla-mobile/fenix/pull/6550) 2019-11-12 16:06:37 -08:00
Emily Kager
65fb429f90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry (https://github.com/mozilla-mobile/fenix/pull/6352) 
* For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry

* Adds Logins Sync Telemetry to PreferenceToggled event
 2019-11-12 15:55:36 -08:00
mcarare
9bc6269a02 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4487 Set activity title only once in Bookmark fragment 
Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
 2019-11-12 08:21:53 -08:00
Arturo Mejia
2be3cb8bac [fenix] No issue: Do not prevent trackers duplication in the tracking 
protection panel.
 2019-11-12 08:15:30 -08:00
mcarare
04a9c50757 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6543 Hide keyboard when saving a new bookmarks folder 2019-11-12 08:09:55 -08:00
Severin Rudie
153923588f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4281: fixed metrics.yaml for QAB removal (https://github.com/mozilla-mobile/fenix/pull/6555) 2019-11-11 18:01:22 -08:00
Severin Rudie
2e76d82c9a [fenix] 4281 remove qab (https://github.com/mozilla-mobile/fenix/pull/6310) 
* For https://github.com/mozilla-mobile/fenix/issues/4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
 2019-11-11 17:10:14 -08:00
mcarare
bb6977c18c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6323 Creating 1st collection from tab shows Name collection screen 
Added a check for existence of at least a collection to select from.
 2019-11-11 14:36:55 -08:00
Sawyer Blatz
65e2c1d4b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5958: Adds in app download notifications (https://github.com/mozilla-mobile/fenix/pull/6506) 2019-11-11 14:08:51 -08:00
Mozilla L10n Automation Bot
1ed735bbd2 [fenix] Import l10n. 2019-11-08 14:44:57 -08:00
Mihai Adrian
d1e9968b33 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1211 Hide the keyboard when scrolling through engine suggestions (https://github.com/mozilla-mobile/fenix/pull/6474) 2019-11-08 14:36:39 -08:00
Tiger Oakes
31d960669a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6255 - Fix beta icon filenames (https://github.com/mozilla-mobile/fenix/pull/6407) 2019-11-08 14:11:32 -08:00
RAJESH KUMAR ARUMUGAM
7a847cdf41 [fenix] Added Vibration Effect On Scanning QR Code (https://github.com/mozilla-mobile/fenix/pull/6129) 
* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing https://github.com/mozilla-mobile/fenix/issues/2928

* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing https://github.com/mozilla-mobile/fenix/issues/2928

* Update PairFragment.kt

Removed unwanted blank lines

* Update PairFragment.kt

Removed the Casting with !!
 2019-11-08 13:37:36 -08:00
Emily Kager
afa25a6978 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
mcarare
15121f02bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5709 Do not animate switch for ETP panel 2019-11-08 08:36:30 -08:00
ValentinTimisica
c7dc1bad43 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6408: Pop stack to homeFragment when opening bookmarks from homeFragment 
When bookmark fragment is opened from homeFragment, libraryFragment does not
exists so the popBackStack(R.id.libraryFragment, true) would have failed. So
the solution for this was to pop back stack to homeFragment when the
bookmarks/history fragments are opened from homeFragment.
 2019-11-07 16:00:48 -08:00
Grisha Kruglov
0ab4fb0e25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Emily Kager
517d32cca2 [fenix] Fix components, core tests 2019-11-07 14:50:24 -08:00
Emily Kager
d00e038afb [fenix] Adds webAppShortcutManager argument 2019-11-07 14:50:24 -08:00
Tiger Oakes
cfddef3077 [fenix] Use ManifestUpdateFeature 2019-11-07 14:50:24 -08:00
Sawyer Blatz
a7fdfe5cd0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547: Reuse biometricPrompt when authenticating 
This fixes an issue with Samsung devices where an invisible DeviceCredentialHandler because the executor was "null" (it wasn't actually)

You *must* reuse the biometric object instead of creating a new one.
 2019-11-07 13:45:41 -08:00
Emily Kager
fc7084a555 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
Shangeeth Sivan
36274d1a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4556: Removed redundant code in few tests. (https://github.com/mozilla-mobile/fenix/pull/6367) 
* Moved some values as member variables as having them declared separately in methods seemed redundant.

* Added @Before method in logtest to avoid code duplication Fixes https://github.com/mozilla-mobile/fenix/issues/4556

* Added @Before method to FragmentTest class Fixes https://github.com/mozilla-mobile/fenix/issues/4556

* variable renamed and added private access specifier; removed set from member variable as it is used only once and we can convert the list to set when needed

* Fixes linter errors
 2019-11-07 13:20:51 -08:00
Sawyer Blatz
c6e952238d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Updates total_uri_count upload (https://github.com/mozilla-mobile/fenix/pull/6482) 2019-11-06 19:10:56 -08:00
Grisha Kruglov
969398d46a [fenix] Migrate FxA state 2019-11-06 14:29:24 -08:00
Mihai Branescu
3ee547b729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6269 Rtl-wrong-search-positioning (https://github.com/mozilla-mobile/fenix/pull/6400) 
* For https://github.com/mozilla-mobile/fenix/issues/6269
- Added start/end margin for rtl support in shortcuts label

* For https://github.com/mozilla-mobile/fenix/issues/6269
- Refactored search fragment xml, extracted dimens + added styles
 2019-11-06 11:54:43 -08:00
Sawyer Blatz
1bf15d71e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6390: Fixes textColor on download prompt (https://github.com/mozilla-mobile/fenix/pull/6468) 2019-11-06 11:10:17 -08:00
Sawyer Blatz
b898b45c8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6284: Fixes SearchShortcut button functionality when in a session 
This makes it so searchShortcuts button works when going from browser -> search
 2019-11-06 11:08:41 -08:00
Mihai Branescu
48a06e4e1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6087 
- added engine hashmap so that we create each type of search provider once
(previously the providers to be added were checked by id, but since the id
is a UUID, it was always unique -> bug with multiple providers with same engine
but different id
- refactored update() flow so that it's more understandable + remove complex
method warning
 2019-11-06 11:08:41 -08:00
Mozilla L10n Automation Bot
3787c40b4d [fenix] Import l10n. 2019-11-06 09:34:26 -08:00
ekager
e709201056 [fenix] Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
Emily Kager
bb2d4aa38f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6441: Fix variant build type matching (https://github.com/mozilla-mobile/fenix/pull/6462) 2019-11-05 12:28:14 -08:00
mozilla-l10n-automation-bot
616f0210c6 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/6414) 2019-11-05 09:44:23 -08:00
Emily Kager
1b228ac62a [fenix] No issue: Ignore rest of HistoryTest tests (https://github.com/mozilla-mobile/fenix/pull/6450) 2019-11-05 08:53:07 -08:00
Emily Kager
f2839a9943 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6441 - Only enable experiments for Beta/Prod 2019-11-04 16:45:35 -08:00
Richard Pappalardo
a17bb1d8dd [fenix] Temp disable all History UI tests (https://github.com/mozilla-mobile/fenix/pull/6443) 2019-11-04 15:25:29 -08:00
Emily Kager
a3f417eb98 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6369 - Use padding set from style for protection settings 2019-11-04 10:25:15 -08:00
Jeffrey Starke
2896a79805 [fenix] Use vector compat in TrackingProtectionPanelView (https://github.com/mozilla-mobile/fenix/pull/6376) 2019-11-04 10:04:02 -08:00
Richard Pappalardo
cdfba9536a [fenix] Temp disable flaky deleteMultipleSelectionTest (https://github.com/mozilla-mobile/fenix/pull/6405) 
* Temp disable flaky deleteMultipleSelectionTest

* Fix indentation
 2019-11-04 09:44:44 -08:00
liuche
0eb5656020 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6097 - Bump activation ping expiry date. (https://github.com/mozilla-mobile/fenix/pull/6309) 2019-11-01 14:06:44 -07:00
Christian Sadilek
49b95d6e1f [fenix] Use new WindowFeature API after browser-state migration 2019-11-01 15:52:37 -04:00
Mugurell
c3936f8fc8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Add tests for the new classes resulting from refactoring 
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
 2019-10-31 17:08:40 -07:00
Mugurell
35de878eae [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Document the newly introduced public APIs 
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
 2019-10-31 17:08:40 -07:00
Mugurell
9b1c705ca2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Handle all business logic with Interactors and a Controller 
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
 2019-10-31 17:08:40 -07:00
Mugurell
8f07c6fbf0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4126 - Refactor Views and layouts 
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
 2019-10-31 17:08:40 -07:00
mozilla-l10n-automation-bot
b3d6bc6f7b [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/6359) 2019-10-31 17:02:17 -07:00
ValentinTimisica
48489766a0 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5917: Show snackbar when URL is copied (https://github.com/mozilla-mobile/fenix/pull/6210) 
Show a snackbar to the user for him to know that the URL was copied to
clipboard.
 2019-10-31 16:53:00 -07:00
Tiger Oakes
41e1c322a6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6153 - Add powered by notification 2019-10-31 16:39:58 -07:00
Jeffrey Starke
a1e82286b6 [fenix] * Move repeated NavControllerTest logic to @Before set up method 
* Use property access syntax where applicable in NavControllerTest
 2019-10-31 16:28:02 -07:00
ValentinTimisica
6ec011b789 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6341: Initialize 'selectedTabs' based on opened/selected tabs. 
The problem was that the parameter 'selectedTabIds' was not taken into account
when initializing the variable 'selectedTabs'. So I made the initialization
based on both the selected tab and the number of open tabs.
 2019-10-31 16:22:14 -07:00
ValentinTimisica
5048bbad85 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6268: Change drawableTint from style to appcompat version. 
The property android:drawableTint doesn't work on older Android devices,
so I switched to the appcompat version (app:drawableTint).
 2019-10-31 16:09:49 -07:00
mcarare
f23d222bb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6342 Clicking add tab button from home screen finishes onboarding 2019-10-31 16:04:02 -07:00
Sawyer Blatz
65fa1e255d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5959 & https://github.com/mozilla-mobile/fenix/issues/5958: Integrates download feature into Fenix (https://github.com/mozilla-mobile/fenix/pull/6368) 2019-10-31 14:37:05 -07:00
mcarare
6f2df90bc2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1487 Add "my library" menu category and items to home 3-dot menu. 
Changed UI tests according to new menu items.
 2019-10-31 11:29:49 -07:00
mcarare
a79c7d3bb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1487 Add "my library" menu category and items to home 3-dot menu 2019-10-31 11:29:49 -07:00
Artur Dryomov
aa2d47a591 [fenix] No issue: Refactor errors to risk level conversion. (https://github.com/mozilla-mobile/fenix/pull/5710) 2019-10-30 11:08:45 -07:00
Sawyer Blatz
506fdc79a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Adds total_uri_count to metrics core ping (https://github.com/mozilla-mobile/fenix/pull/6003) 2019-10-30 11:02:33 -07:00
Sawyer Blatz
3aa5901ddf [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/6344: Adds null check for adjust campaign (https://github.com/mozilla-mobile/fenix/pull/6348) 2019-10-30 10:13:03 -07:00
Chenxia Liu
5d32b6880c [fenix] For https://github.com/mozilla-mobile/fenix/issues/6294 - When only one tab is being saved to collection, add it to selected tabs. 2019-10-29 11:27:51 -07:00
Sawyer Blatz
ed0d2c0c0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Fixes issue with Adjust campaign not sending through Glean (https://github.com/mozilla-mobile/fenix/pull/5896) 2019-10-29 10:09:07 -07:00
Oana Horvath
956b506474 [fenix] History menu UI tests (https://github.com/mozilla-mobile/fenix/pull/6272) 
Removed failing verifyOverflowMenuButton method

Added new Robot for MultipleSelectionTooolbar

Renamed MultipleSelectionToolbarRobot to LibrarySubMenusMultipleSelectionToolbarRobot
 2019-10-29 11:36:19 +02:00
Mozilla L10n Automation Bot
9a69ac4a44 [fenix] Import l10n. 2019-10-28 17:26:28 -07:00
No-Jun Park
e40b258890 [fenix] Collection UI Test added, but set to disabled until Collection is refactored (https://github.com/mozilla-mobile/fenix/pull/6160) 2019-10-28 15:10:19 -04:00
Mozilla L10n Automation Bot
24268de707 [fenix] Import l10n. 2019-10-28 10:04:12 -07:00
ValentinTimisica
b02410b154 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5128: Changed history_empty_view to match constraints. 
The bug occurred because the activity/fragment is not recreated on
orientation change. A simple fix was to just set width and height to 0dp
to let it match constraints.
 2019-10-28 09:44:03 -07:00
Christian Sadilek
b5ef6dbcfe [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5678: Selected session may render in ExternalAppBrowserActivity 2019-10-28 09:43:33 -07:00
isabelrios
4eb8ad16d0 [fenix] Fix sync test after changes in the syntaxt to check the elements (https://github.com/mozilla-mobile/fenix/pull/6249) 2019-10-28 11:31:32 -04:00
Mihai Branescu
9ffde8da1c [fenix] For https://github.com/mozilla-mobile/fenix/issues/5848 Wrong toolbar colour - edit bookmark fragment (https://github.com/mozilla-mobile/fenix/pull/6047) 
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
 2019-10-25 21:41:48 -07:00
Mihai Branescu
aa66b3e66e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5733 - Private mode notification - wrong home screen (https://github.com/mozilla-mobile/fenix/pull/6188) 
- added PRIVATE MODE intent extra to the notification action
 (could use also the OPEN_FROM_NOTIFICATION, but I considered this one to
 be more explicit. Kept the old one in case other checks will be done
 filtering for it)
- added intent? param to the getPrivateModeFromIntent method, because
onNewIntent() method does not set the activities intent, and it was needed
to be used both in onCreate() and onNewIntent()
 2019-10-25 21:41:31 -07:00
ValentinTimisica
799f009731 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5104: Cleanup - Use match_constraint instead of match_parent. 
Google officially recommends using match_constraint (equivalent to 0dp)
instead of match_parent when the view is contained in a ConstraintLayout.
https://developer.android.com/reference/android/support/constraint/ConstraintLayout#widgets-dimension-constraints
 2019-10-25 13:28:38 -07:00
ValentinTimisica
a33229584b [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5104: Changed empty_exception_container to match constraints. 
This bug occurs because the activity/fragment is not recreated on
orientation change. A simple fix was to just set width and height to 0dp
to let it match constraints.
 2019-10-25 13:28:38 -07:00
ekager
6f4fd33912 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6229 - Remove all tab options from custom tab context menu 2019-10-25 13:25:31 -07:00
Emily Kager
0a59e87224 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6219 - Reset default setting if user opts out of experiments 2019-10-25 12:50:16 -07:00
Mozilla L10n Automation Bot
9bd7b46ddb [fenix] Import l10n. 2019-10-25 10:19:49 -07:00
Mihai Branescu
2597e6134d [fenix] For https://github.com/mozilla-mobile/fenix/issues/6179 - Changed positioning of private mode icons in tab he… (https://github.com/mozilla-mobile/fenix/pull/6189) 2019-10-25 08:09:38 -07:00
Jonathan Almeida
e5f9064701 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm" 
This reverts commit b1ce8ffcb7710fd98b692358309db42690593e11.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See https://github.com/mozilla-mobile/fenix/issues/6250 and https://github.com/mozilla-mobile/fenix/issues/6251 for related info.
 2019-10-25 10:24:40 -04:00
Mozilla L10n Automation Bot
be2d12beec [fenix] Import l10n. 2019-10-24 22:02:26 -07:00
Daphne Liu
916b172a77 [fenix] Add intent-filter to support nfc tags (https://github.com/mozilla-mobile/fenix/pull/6257) 2019-10-24 20:04:57 -07:00
Daphne Liu
ca0136985e [fenix] Replaced beta square icon with round icons (https://github.com/mozilla-mobile/fenix/pull/6261) 2019-10-24 20:04:49 -07:00
Sawyer Blatz
8314b378d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5737: Adds telemetry for open links in a private tab (https://github.com/mozilla-mobile/fenix/pull/5975) 2019-10-24 17:16:49 -07:00
Denys M
f69e53c92d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2441. Update LeakCanary to 2.0-beta-3 version. 2019-10-24 11:19:09 -07:00
wpanas
4447c7f9f0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6236: Fix padding lint issues (https://github.com/mozilla-mobile/fenix/pull/6240) 2019-10-24 10:52:30 -07:00
mcarare
438fbeb2cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Improve sync title/summary settings to support RTL 2019-10-24 10:32:59 -07:00
ekager
0c97d8780d [fenix] No issue: Sign in button style should be ThemeIndependentMaterialGreyButton 2019-10-24 10:32:29 -07:00
ekager
36de82bdc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
Mozilla L10n Automation Bot
c92b7dc1c0 [fenix] Import l10n. 2019-10-24 10:27:53 -07:00
RaviGarbuja
1edaa81b9b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6237: Change android:text to tools:text (https://github.com/mozilla-mobile/fenix/pull/6246) 2019-10-24 10:24:39 -07:00
Tiger Oakes
1562bce123 [fenix] Use tools:listitem with collection creation (https://github.com/mozilla-mobile/fenix/pull/6140) 2019-10-24 10:24:08 -07:00
psy0ch
7cc240bcd2 [fenix] Add explanation to @Ignore in CollectionTest (https://github.com/mozilla-mobile/fenix/pull/6238) 
https://github.com/mozilla-mobile/fenix/issues/6235
 2019-10-24 10:23:03 -07:00
obarzpaw
2a846964ca [fenix] Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/4558 Change height of bookmark linearlayout 2019-10-24 09:46:09 -07:00
Ardlan Khalili
0e1f235a20 [fenix] Closes 6168: Globe icon for exceptions 2019-10-24 09:44:49 -07:00
ValentinTimisica
2e3d0e1347 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6145: Switch drawableTint to app compat version. (https://github.com/mozilla-mobile/fenix/pull/6151) 
The property android:drawableTint doesn't work on older Android devices,
so I switched to the appcompat version (app:drawableTint).
 2019-10-24 09:38:58 -07:00
Jeff Boek
e6af25acca [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adjust padding to be visually consistent with the separator 2019-10-24 09:35:21 -07:00
Jeff Boek
212d63ec39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2477 - Adds accessibility setting to force enable zoom 2019-10-24 09:35:21 -07:00
Alessio Placitelli
9d544a27e8 [fenix] Pick up forUnitTest library for the Glean SDK test 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
a81a60183d [fenix] Update to Mozilla Android Components 19.0.0-SNAPSHOT. 2019-10-24 08:57:30 -07:00
Sebastian Kaspari
e9d21e9799 [fenix] Use new toolbar API of AC 18.0.0. 2019-10-24 08:57:30 -07:00
Sawyer Blatz
893c08050f [fenix] No issue: Fixes string issues for l10n (https://github.com/mozilla-mobile/fenix/pull/6158) 
Issues found here: https://github.com/mozilla-l10n/android-l10n/pull/89
 2019-10-24 08:24:19 -07:00
Aaron Train
aa400955a6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6172 - Convert waitNotNull into extension function for UI tests (https://github.com/mozilla-mobile/fenix/pull/6220) 2019-10-23 17:40:28 -04:00
MozLando
961254df94 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5332 
5332: For https://github.com/mozilla-mobile/fenix/issues/2483 https://github.com/mozilla-mobile/fenix/issues/2629: Close tab with no history on back press and return to parent if available r=ekager a=mawen7



Co-authored-by: mawen7 <mawen7@users.noreply.github.com>
 2019-10-23 18:20:36 +00:00
Severin Rudie
69406b4230 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3676: fix duplicate uri events on first load (https://github.com/mozilla-mobile/fenix/pull/6128) 2019-10-23 10:21:46 -07:00
Aaron Train
16eebc77c9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6031 - Wrap waits with assert check; adjust timer check (https://github.com/mozilla-mobile/fenix/pull/6084) 
See https://github.com/mozilla-mobile/fenix/issues/6031

- Adjust waits with assert check
- Adjusts timer to speed things up
- Test fix and cleanup

fix: review comments

- fixed proper resource name selectors
- re-added waits for slow devices

fix: ktlint
 2019-10-23 10:55:19 -04:00
mawen7
73f5f00aeb [fenix] Close tab with no history on back press and return to parent if available 2019-10-23 12:54:28 +02:00
liuche
b2419592ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/4947 - Add Fenix Beta icons. (https://github.com/mozilla-mobile/fenix/pull/6173) 2019-10-22 18:10:39 -07:00
Severin Rudie
1c34781659 [fenix] https://github.com/mozilla-mobile/fenix/issues/4596 migrate collections (https://github.com/mozilla-mobile/fenix/pull/5911) 
* For https://github.com/mozilla-mobile/fenix/issues/4596: move code from CollectionCreationComponent to CollectionCreationStore

Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreateStore to libstate

* For 4596: copied CollectionCreationUIView into CollectionCreationView

Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.

* For 4596: update CollectionCreationView to LibState

Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.

* For 4596: updated CollectionCreationTabListAdapter to work with the new View

* For 4596: updated SaveCollectionListAdapter to work with the new View

* For 4596: implemented CollectionCreationController

For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer

* For 4596: copied over previous reducer code

No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer

* For 4596: update reducer code param names

Otherwise, no changes at this time

* For 4596: add arguments to CreateCollectionFragment in nav_graph

These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.

* For 4596: pass arguments to collection via transaction instead of VM

The VM will be removed in a later commit

* For 4596: update BrowserToolbarController to share state to collection via its Direction

* For 4596: removed CreateCollectionViewModel

* For 4596: test tab retrieval in CreateCollectionFragment

* For 4596: fix crashing CreateCollectionFragmentTest

* For 4596: removed classes create collection classes used by old architecture

* For 4596: collection interactor rename + kdoc

* For 4596: moved collection interactor interface

* For 4596: renamed CreateCollectionFragment

All related classes followed the pattern of CollectionCreationX

* For 4596: kdoc CollectionCreationController

There's no effective difference between these calls and their interactor equivalent, so I linked to them

* For 4596: fix bug that caused rename to not work

* For 4596: removed unused collection actions

These were unused before the LibState refactor

* For 4596: kdoc StepChanged

* For 4596: removed todos about moving logic to the reducer

saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive

handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here

stepBack: called by handleBackPress. See above

* For 4596: wrote tests for CollectionCreationController#stepback

* For 4596: fixed tests broken by changes to collections

* For 4596: small readability refactor for CollectionController#stepBack

No change to functionality (see tests)

* For 4596: broke apart CollectionView#update

There's probably a lot more that could be done here, but smaller changes were made to reduce scope

* For 4596: remove unnecessary todos

It looks like we don't follow the suggested pattern in this project

* For 4596: test CollectionCreationController#normalSessionSize

* For 4596: updated naming in CollectionCreationController per review
 2019-10-22 17:33:54 -07:00
Pawel Obarzanek
1949400621 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the book… (https://github.com/mozilla-mobile/fenix/pull/6137) 
* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Change edit icon to share icon on the bookmark toolbar

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 Changed raw string to string resources

* Pass bookmark arguments to share fragment

* Closes mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/2435 add orEmpty
 2019-10-22 14:34:05 -07:00
Tiger Oakes
8f91658907 [fenix] Refactor asCamelCase to use string builder (https://github.com/mozilla-mobile/fenix/pull/6141) 2019-10-22 14:33:44 -07:00
Sebastian Kaspari
e4c7bb08d4 [fenix] Issue #36170: BaseBrowserFragment: Use new feature-prompts API. 2019-10-22 16:04:33 -04:00
Grisha Kruglov
3e5c5d9514 [fenix] Perform Fennec data migration within fennecProduction 2019-10-22 16:04:08 -04:00
Tiger Oakes
0af2e9d821 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3366 - Use one layout for edit/add bookmark (https://github.com/mozilla-mobile/fenix/pull/5900) 2019-10-21 10:06:08 -07:00
Mitchell Hentges
cf0265e3b1 [fenix] Removes versionName check from gradle (https://github.com/mozilla-mobile/fenix/pull/5934) 2019-10-21 10:03:21 -07:00
Sören Hentzschel
3bc81481c5 [fenix] for https://github.com/mozilla-mobile/fenix/issues/6008 - fix address bar layout on home fragment for RTL (https://github.com/mozilla-mobile/fenix/pull/6016) 2019-10-21 10:02:13 -07:00
Sören Hentzschel
fe2879ff45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6011 - fixed truncated clipboard icon in RTL (https://github.com/mozilla-mobile/fenix/pull/6017) 2019-10-21 10:01:51 -07:00
isabelrios
e6e5ab6ffb [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks (https://github.com/mozilla-mobile/fenix/pull/6019) 
* Fix https://github.com/mozilla-mobile/fenix/issues/6004: Add UI sync integration test for Bookmarks

* fix two typos
 2019-10-21 10:01:17 -07:00
Mihai Adrian
bb0d3150c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1383: Fix updating description of close button on title change. (https://github.com/mozilla-mobile/fenix/pull/6020) 2019-10-21 10:00:26 -07:00
ValentinTimisica
8790a8a68e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5030: Modified Dialog to match the others. (https://github.com/mozilla-mobile/fenix/pull/6022) 
I changed the Dialog from permissions exceptions and used AlertDialog
instead of Context.alert extension function.
 2019-10-21 09:59:04 -07:00
Mihai Branescu
4dda232d0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6063 - changed ETP blocking info title strings (https://github.com/mozilla-mobile/fenix/pull/6082) 2019-10-21 09:58:47 -07:00
Shangeeth Sivan
f274b65859 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5465: Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled (https://github.com/mozilla-mobile/fenix/pull/6098) 2019-10-21 09:57:29 -07:00
ValentinTimisica
8532908d51 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5323: Show a snackbar while browsing data is deleting. (https://github.com/mozilla-mobile/fenix/pull/6105) 2019-10-21 09:57:06 -07:00
Jeffrey Starke
55ed9cbe2c [fenix] Don't show fingerprinters section of the standard tracking policy UI (https://github.com/mozilla-mobile/fenix/pull/6125) 2019-10-21 09:56:46 -07:00
Sören Hentzschel
4ca4f775fb [fenix] fixed alignment of open tabs header for RTL languages (https://github.com/mozilla-mobile/fenix/pull/6138) 2019-10-21 09:53:21 -07:00
Sören Hentzschel
4c2c5c5e21 [fenix] no issue - removed unused feature flags (https://github.com/mozilla-mobile/fenix/pull/6143) 2019-10-21 09:52:01 -07:00
Richard Pappalardo
1839ce12f1 [fenix] Add verify items tests for settings menus 2019-10-21 08:24:47 -07:00
Mozilla L10n Automation Bot
8c048ac40f [fenix] Import l10n. 2019-10-19 17:40:27 +00:00
MozLando
06da598c96 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6102 https://github.com/mozilla-mobile/fenix/pull/6106 
6102: For https://github.com/mozilla-mobile/fenix/issues/6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai



6106: For https://github.com/mozilla-mobile/fenix/issues/5872 & https://github.com/mozilla-mobile/fenix/issues/6075: Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare

At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-18 18:59:20 +00:00
MozLando
eefbdfc912 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/6107 
6107: Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment r=boek a=Mugurell

Previously the Snackbar was being inflated in the parent of this Fragment so
surviving it being closed.
Tying the Snackbar with the Fragment from which it is shown ensures it will be
effectively hidden whenever the user navigates from the Fragment.



Co-authored-by: Mugurell <mugurell@users.noreply.github.com>
 2019-10-18 18:34:49 +00:00
Tiger Oakes
1eac564f52 [fenix] Cleanup shortcut code 2019-10-18 10:57:51 -07:00