Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity
7,156 Commits 67 Branches 113 Tags 1.2 GiB
3d678da8c3
Commit Graph

5976 Commits

Author SHA1 Message Date
Gabriel Luong
609acda69c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Use the new "Details" text for navigating to ETP details 2021-08-16 16:42:39 -04:00
Arturo Mejia
ab1e4228c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu. 2021-08-16 16:42:39 -04:00
Gabriel Luong
7d8ca1ec98 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-08-16 16:42:39 -04:00
Gabriel Luong
66192cc136 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add right arrowheader to tracking protection navigators 2021-08-16 16:42:39 -04:00
Gabriel Luong
9bb39fe7b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings 2021-08-16 16:42:39 -04:00
Gabriel Luong
23d57b151f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add navigation from quick settings to tracking protection panel 2021-08-16 16:42:39 -04:00
Gabriel Luong
70d55f4746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator 2021-08-16 16:42:39 -04:00
Mozilla L10n Automation Bot
0196a85e19 [fenix] Import l10n. 2021-08-16 16:49:49 +00:00
Jonathan Almeida
8c5bccf445 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853: Fix intermittent failing test in HomeFragmentStoreTest 2021-08-16 16:19:38 +00:00
Jonathan Almeida
b9c243c0ec [fenix] Update TabSessionState.createdAt for inactive tabs debugging 2021-08-16 15:53:25 +00:00
Arturo Mejia
d735df1dd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string 2021-08-16 11:24:42 -04:00
Sebastian Kaspari
7e548348e3 [fenix] Android Autofill: Use AppCompat theme for UnlockActivity. 2021-08-16 08:00:13 +00:00
Arturo Mejia
3dc3db856c [fenix] Remove duplicated line in TabsSettingsFragment 2021-08-16 07:29:52 +00:00
Sebastian Kaspari
eb35f06802 [fenix] Use theming in debug screen. 2021-08-16 07:03:29 +00:00
Jonathan Almeida
632311b1ea [fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168: Remove intermittent failing test in ToolbarViewTest 
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.

This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.

It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.

So therefore.. 🔥
 2021-08-14 01:52:52 -04:00
Jonathan Almeida
d32727eff9 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796: Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest 2021-08-14 01:52:52 -04:00
Jonathan Almeida
14735a61ae [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795: Speculative fix for intermittent test failures in HomeFragmentTest 
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
 2021-08-14 01:52:52 -04:00
Jonathan Almeida
a590fd2b74 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797: Fix intermittent test failures in ShortcutsSuggestionProviderTest 2021-08-14 01:52:52 -04:00
Jonathan Almeida
9b20f9c1c0 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792: Fix intermittent test failures in QuickSettingsFragmentReducerTest 2021-08-14 01:52:52 -04:00
Aaron Train
f2fe9ae61d [fenix] Filter out test target packages in Flank-x86 (https://github.com/mozilla-mobile/fenix/pull/20841) 
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
 2021-08-13 15:00:10 -04:00
Michael Comella
fce543516e [fenix] No issue: move kotlin-allopen outside appVariants loop. 
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
 2021-08-12 20:39:27 +00:00
Elise Richards
cc2f37b040 [fenix] Use header20 style on collections to match other home items. Add margin above collections. (https://github.com/mozilla-mobile/fenix/pull/20633) 2021-08-12 19:32:38 +00:00
Jonathan Almeida
00cb0c74f3 [fenix] Update the description for an inactive tabs string 2021-08-12 17:44:56 +00:00
Steven Knipe
982dc4410f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets 2021-08-12 13:54:13 +00:00
codrut.topliceanu
4082b5eb90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20098: Allow PB PiP video screenshots 
...when `Allow screenshots in private browsing` is enabled
 2021-08-12 06:49:55 +00:00
Rohan Maity
620d034134 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes 2021-08-11 22:31:52 +00:00
Arturo Mejia
d4a2d1ac83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments 2021-08-11 16:14:13 -04:00
Arturo Mejia
be0f7d9dcc [fenix] Disable intermittent tests. 2021-08-11 19:05:06 +00:00
Arturo Mejia
8ff9adb54e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account 2021-08-11 17:39:33 +00:00
codrut.topliceanu
f4f6b18cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in history screens 2021-08-11 15:29:35 +00:00
codrut.topliceanu
c441adb0d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in collections 2021-08-11 08:01:58 +00:00
Vitaly V. Pinchuk
21fedbf45f [fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes. 2021-08-10 12:01:29 +00:00
Michael Comella
b8f673380f [fenix] No issue: remove unnecessary robolectric annotations. 
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
 2021-08-10 00:22:44 +00:00
Elise Richards
7273536742 [fenix] For FNXV2-17067: always show home in background behind search dialog (https://github.com/mozilla-mobile/fenix/pull/20573) 
* Navigate to home on toolbar click. Handle back press from search dialog

Update tests to show home behind search dialog. Remove unused test.

Jump back in show all button is clickable behind search dialog

Recently saved bookmarks show all button is clickable behind search dialog

* Add feature flag

* Past explorations show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests.

Allow collections to be visible behind search dialog

Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard

Verify navigateUp in tests

Adding ignore for flaky UI test

Only resize home behind search dialog

Add ignore for collection intermittent test

Cleanup
 2021-08-09 15:40:41 +00:00
codrut.topliceanu
33b08b6b83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in downloads screen 2021-08-09 11:06:28 +00:00
mcarare
dcbd978c73 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Re-add tests for class BookmarksUseCaseTest. 2021-08-09 09:46:27 +00:00
AndiAJ
8f3313ad02 [fenix] Start on home UI tests 2021-08-09 07:34:16 +00:00
Mozilla L10n Automation Bot
2120e07768 [fenix] Import l10n. 2021-08-09 00:41:53 +00:00
Mozilla L10n Automation Bot
8c1a00b21c [fenix] Import l10n. 2021-08-08 00:40:54 +00:00
Jonathan Almeida
feb8f5e363 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726: Fix intermittent failure in AddonsManagementViewTest 2021-08-06 22:27:28 +00:00
Jonathan Almeida
0a0af212f0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20718: Show url if title is missing for inactive tabs 2021-08-06 22:00:38 +00:00
Elise Richards
3bfd5d1827 [fenix] Correct search_count telemetry after revert 2021-08-06 21:26:43 +00:00
Roger Yang
1612db86c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20723: Fix credit card management fragment binding 2021-08-06 20:59:38 +00:00
Michael Comella
b4ce5abf0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697: replace mockked lambda in DownloadControllerTest. 
This is expected to fix the intermittent failure in this test.
 2021-08-06 20:32:16 +00:00
Michael Comella
13249f7080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679: revert allowaccessmodification proguard disabling. 
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.

This commit reverts the following commits:

Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.

Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
 2021-08-06 20:07:32 +00:00
Jonathan Almeida
3c66fa4833 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19956: Add telemetry for tab view setting changes 
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in https://github.com/mozilla-mobile/fenix/issues/19809).
 2021-08-06 19:33:54 +00:00
Christian Sadilek
18a51be61c [fenix] Update Android Components version to 92.0.20210806164329 (https://github.com/mozilla-mobile/fenix/pull/20722) 
Addresses breaking change in ShortcutsSuggestionProvider
 2021-08-06 14:19:56 -04:00
codrut.topliceanu
6c15482c9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in bookmarks screen 2021-08-06 15:52:00 +00:00
Jonathan Almeida
d4ab4f3572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663: Make inactive card collapsible 
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.

In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
 2021-08-06 15:23:10 +00:00
Mugurell
75aeb961e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector 
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
 2021-08-06 14:09:15 +00:00
codrut.topliceanu
2971cd309d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray 2021-08-06 12:37:44 +00:00
Grisha Kruglov
39561f3644 [fenix] External source support 
Adds handling of information about external referrer (package, category)
when dealing with external intents.
 2021-08-05 17:30:00 -07:00
Roger Yang
333840f02e [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711: Telemetry for credit card autofill (https://github.com/mozilla-mobile/fenix/pull/19548)" 
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
 2021-08-05 18:53:46 +00:00
Roger Yang
cffad4f424 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping (https://github.com/mozilla-mobile/fenix/pull/19733)" 
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
 2021-08-05 18:53:46 +00:00
Mozilla L10n Automation Bot
60da5771b7 [fenix] Import l10n. 2021-08-05 16:53:04 +00:00
Mugurell
b583864643 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI 
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
 2021-08-05 15:52:06 +00:00
Mugurell
19767246f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Use CombinedHistorySuggestionProvider for history suggestions 
This should ensure user is always presented with history results for his
searches.
 2021-08-05 15:52:06 +00:00
Mozilla L10n Automation Bot
317bf219d0 [fenix] Import l10n. 2021-08-05 14:48:56 +00:00
Jonathan Almeida
cdade5b44a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664: Do not consider newly created tabs as inactive 2021-08-05 01:37:43 +00:00
Jonathan Almeida
cb4a24d6a6 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20674: Remove elevation from inactive tabs card 2021-08-05 01:37:43 +00:00
Sebastian Kaspari
5949766c5d [fenix] Enable Android Autofill in Beta builds. 2021-08-04 21:07:42 +00:00
mcarare
a710775406 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Use View binding in quick settings. 2021-08-04 09:32:08 -04:00
Mozilla L10n Automation Bot
bd036901ae [fenix] Import l10n. 2021-08-04 01:09:21 +00:00
Arturo Mejia
39ea051a14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19970 [Crash] IllegalStateException when navigating to TP panel 2021-08-04 00:17:13 +00:00
Christian Sadilek
24b4a03d32 [fenix] Fix intermittent test failures in ToolbarViewTest 2021-08-03 23:34:02 +00:00
Roger Yang
b901490a1b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650: Revert to manually close tab as default setting 2021-08-03 22:44:14 +00:00
Arturo Mejia
724fb8b60f [fenix] For https://github.com/mozilla-mobile/fenix/issues/20601: Undo Use View binding in quick Settings. 2021-08-03 15:34:38 -04:00
Michael Comella
68bef957b5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20461: remove app_received_intent probe. 2021-08-03 18:19:12 +00:00
Sebastian Kaspari
6109d61cd7 [fenix] Fix UI tests: SettingsPrivacyTest, DeepLinkTest. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
6e4060fa5a [fenix] Add preference for enabling/disabling Android Autofill from within the app. 2021-08-03 11:43:25 +00:00
Sebastian Kaspari
7f6cdd491b [fenix] Add dialog-like theme for AutofillSearchActivity 2021-08-03 11:10:21 +00:00
Michael Comella
d0ca64a9a4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631: remove @Ignore on StorageStats tests. 
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
 2021-08-03 08:53:44 +00:00
Sebastian Kaspari
4a3576d299 [fenix] Fix intermittent test failures in TabsTouchHelperTest 2021-08-03 01:10:38 +00:00
Mozilla L10n Automation Bot
46a11a3f56 [fenix] Import l10n. 2021-08-03 00:36:57 +00:00
Sebastian Kaspari
7d59c1f786 [fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest 2021-08-02 23:20:46 +00:00
Sebastian Kaspari
5272c60934 [fenix] Fix intermittent test failures in DefaultSessionControlControllerTest. 2021-08-02 22:54:05 +00:00
Michael Comella
85309f1d25 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627: replace mocked lambda in HistoryItemMenuTest. 
This will prevent intermittent failures with Java 11.
 2021-08-02 22:21:54 +00:00
Michael Comella
e0e46cda2d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: disable metrics we don't want to renew. 2021-08-02 19:12:25 +00:00
Michael Comella
f3f4526124 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: link to data renewal request. 2021-08-02 19:12:25 +00:00
Michael Comella
d23a7639ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/20518: renew perf telemetry probes (August expiry). 
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
 2021-08-02 19:12:25 +00:00
Elise Richards
1bad9ad91c [fenix] No issue: fix glean metrics tests for expired metrics (https://github.com/mozilla-mobile/fenix/pull/20621) 
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
 2021-08-02 18:14:17 +00:00
fevziomurtekin
a84d30689d [fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16396 Fix text contrast ratio on "recently closed tabs" 2021-08-02 11:48:11 +02:00
Jonathan Almeida
3fcd0878d4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20349: Add inactive tab grouping to tabs tray 2021-08-02 11:44:13 +02:00
Jonathan Almeida
0ae2f837b6 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20590: 'Jump back in' should obey feature flags 2021-08-02 10:46:38 +02:00
Christian Sadilek
bb3071457a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of DefaultCollectionCreationControllerTest 2021-08-02 10:45:17 +02:00
Rohan Maity
eafb11112d [fenix] https://github.com/mozilla-mobile/fenix/issues/7346 update lint-baseline.xml and remove activity_addons.xml as unused resource 2021-08-02 10:22:34 +02:00
Gabriel Luong
b0c410ce60 [fenix] Add history metadata feature to the settings menu 2021-07-30 19:31:03 +00:00
Christian Sadilek
fb66b53852 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultSessionControlControllerTest 2021-07-30 16:56:44 +00:00
Gabriel Luong
f3027746bf [fenix] Add more context for the Past Exploration localization comment 2021-07-30 15:20:33 +00:00
Christian Sadilek
0d7aa7a57a [fenix] Keep history metadata for 14 days 2021-07-30 14:50:33 +00:00
Sebastian Kaspari
fa26d61a8f [fenix] Fix intermittent test failures of ModeTest 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
6ea19d4b17 [fenix] Run ktlintFormat to adapt to latest formatting rules. 2021-07-30 11:58:02 +00:00
Sebastian Kaspari
bc41dd0b52 [fenix] Add telemetry for Android Autofill feature. 2021-07-30 09:37:43 +00:00
Christian Sadilek
acc5dc1220 [fenix] Fix intermittent test failures of LoginExceptionFragmentStoreTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
2a67850677 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of ExceptionsListItemViewHolderTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
9ed161ff27 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures in SearchDialogControllerTest 2021-07-30 09:12:00 +00:00
Christian Sadilek
a5716396be [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of DefaultTabsTrayControllerTest 2021-07-30 09:12:00 +00:00
mcarare
e3b9c8b633 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in settings screens. 2021-07-30 08:20:58 +00:00
Mozilla L10n Automation Bot
a1ac269c73 [fenix] Import l10n. 2021-07-30 00:28:28 +00:00
Elise Richards
2fdd3cc5e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20516: Renew product telemetry probes expiring in August (https://github.com/mozilla-mobile/fenix/pull/20517) 
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-29 19:14:31 +00:00
mcarare
cc18008cbe [fenix] For https://github.com/mozilla-mobile/fenix/issues/19955 https://github.com/mozilla-mobile/fenix/issues/20393: Add telemetry for home screen recent tabs. 2021-07-29 15:46:02 +00:00
Christian Sadilek
b36321a8ed [fenix] Fix intermittent test failures in WebPushEngineIntegrationTest 2021-07-29 14:46:17 +00:00
Christian Sadilek
2c38047d32 [fenix] Fix intermittent test failures in FenixSnackbarKtTest 2021-07-29 14:46:17 +00:00
mcarare
dfb5ee8746 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in lists. 2021-07-29 14:10:36 +00:00
Christian Sadilek
9e42de220f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent test failures in DefaultQuickSettingsControllerTest 2021-07-29 08:07:49 +00:00
Jonathan Almeida
c49e052da2 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/19785: Let WebAuthnFeature ride the trains 2021-07-29 06:52:07 +00:00
Arturo Mejia
cef6144944 [fenix] Put the Start On home setting behind a feature flag. 2021-07-28 16:53:03 -04:00
Christian Sadilek
ad8312ea31 [fenix] Fix intermittent test failures in NavigationInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
696561599e [fenix] Fix intermittent test failures in PagedHistoryProviderTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
bcf051b559 [fenix] Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
ddd3964fb7 [fenix] Fix intermittent test failures in BookmarkControllerTest 2021-07-28 17:52:53 +00:00
Christian Sadilek
a29d89ef7a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent failures of HistoryControllerTest 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
d9faf84790 [fenix] RemoveTabUseCaseWrapperTest: Do not mock lambdas. 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
0400ede268 [fenix] DefaultRecentlyClosedControllerTest: Do not mock functions 2021-07-28 17:52:53 +00:00
Sebastian Kaspari
3fde165e1c [fenix] Do not mock lambdas in TrackingProtectionPanelInteractorTest. 2021-07-28 17:52:53 +00:00
Christian Sadilek
b612a76e07 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20531: Fix intermittent failures of DefaultBrowserToolbarMenuControllerTest 2021-07-28 17:52:53 +00:00
Michael Comella
f6404a2008 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20540: always swipe twice to openSettings in ThreeDotMenuMainRobot. 2021-07-28 15:29:03 +00:00
Mozilla L10n Automation Bot
0e280db7ac [fenix] Import l10n. 2021-07-28 14:26:32 +00:00
codrut.topliceanu
8593bfd0fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20440 - Forces TopSitePager bind if no. of pages changed 2021-07-27 16:19:31 +00:00
Sebastian Kaspari
cb0f5facd9 [fenix] Render debug info screen with Jetpack Compose. 2021-07-27 09:54:24 +00:00
Christian Sadilek
3bc9ed6cba [fenix] Fix init order in TrackingProtectionExceptionsViewTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
0f8e4450a2 [fenix] Fix race condition in ShareViewModelTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
2a6d83146a [fenix] Remove unused imports in PwaOnboardingObserverTest.kt 2021-07-27 10:08:32 +02:00
Christian Sadilek
a56fdc175c [fenix] Use MainCoroutineRule in PwaOnboardingObserverTest 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
2e02e54516 [fenix] Update Robolectric and mockk. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
ccd84ee8e5 [fenix] Remove over-eager protobuf stripping. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
70ae207572 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19662: Use Java 11. 2021-07-27 10:08:32 +02:00
Oana Horvath
1e55287003 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20297: close tab to avoid saving the same tab to collection 2021-07-27 07:12:37 +00:00
Mozilla L10n Automation Bot
5e82503179 [fenix] Import l10n. 2021-07-27 00:30:24 +00:00
codrut.topliceanu
ac4779de6d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20449 - Fixes Show most visited sites crash on disable 2021-07-26 21:23:56 +00:00
mcarare
9348be6526 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Update AC version 2021-07-26 13:59:46 +00:00
mcarare
bb27316944 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20425: Do not show recent bookmarks older than 10 days. 2021-07-26 13:59:46 +00:00
Mozilla L10n Automation Bot
ff3191f966 [fenix] Import l10n. 2021-07-26 00:30:01 +00:00
Mozilla L10n Automation Bot
b87268288e [fenix] Import l10n. 2021-07-25 00:35:01 +00:00
Mozilla L10n Automation Bot
4a13b27102 [fenix] Import l10n. 2021-07-24 00:37:36 +00:00
Mugurell
2f57358d6a [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Re-enable shortcutButtonTest 
The issue affecting this was resolved in AC.
 2021-07-23 10:47:33 +00:00
Mugurell
df0b2e0d59 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20402 - Re-enable "in progress media tab" 
The crash for when media starts playing in a custom tab is now resolved in AC.
 2021-07-22 22:28:54 +00:00
Gabriel Luong
1341b1e7cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 2021-07-22 22:28:54 +00:00
Gabriel Luong
229aab88f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20438 - Display a list of history metadata groups 2021-07-22 19:19:50 +00:00
Mozilla L10n Automation Bot
5daa184477 [fenix] Import l10n. 2021-07-22 16:24:18 +00:00
Michael Comella
f6e71d4e40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: correct spacing in comment on how to run 
Co-authored-by: Jonathan Almeida <git@jonalmeida.com>
 2021-07-22 15:24:35 +00:00
Michael Comella
40fed783ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/19901: integrate Jetback Benchmark (microbenchmark). 2021-07-22 15:24:35 +00:00
Christian Sadilek
35538a209f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16330: Remove remaining usages of Sentry.capture 2021-07-21 20:07:30 +00:00
Mozilla L10n Automation Bot
64571cf4c7 [fenix] Import l10n. 2021-07-21 14:36:56 +00:00
codrut.topliceanu
8541d3f449 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20367 - Fixes removeAllTabs adding to recently closed 
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
 2021-07-20 22:00:04 +00:00
Arturo Mejia
24e2991759 [fenix] Fix search_add_custom_engine_search_string_example lint warning. 2021-07-20 22:00:04 +00:00
jhugman
cc44b33f9d [fenix] Allow branch enrollment and unenrollment in Nimbus secret menu (https://github.com/mozilla-mobile/fenix/pull/20050) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-20 15:45:37 +00:00
codrut.topliceanu
8e35c61327 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15499 - Smoothly updates topSites list on remove 
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
 2021-07-20 15:07:16 +00:00
Mozilla L10n Automation Bot
b8836b3eec [fenix] Import l10n. 2021-07-20 00:40:11 +00:00
Mugurell
603bbdd520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20420 - Temporarily disable SearchTest#shortcutButtonTest 2021-07-19 10:12:41 +00:00
Sebastian Kaspari
b637a576f2 [fenix] Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1. 2021-07-19 09:20:50 +00:00
Sebastian Kaspari
d9ca412bec [fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 2021-07-19 09:20:50 +00:00
Jonathan Almeida
0522cbe007 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20402: Disable LastMediaAccessMiddleware temporarily 
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.

The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.

For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
 2021-07-17 01:21:13 +00:00
Mozilla L10n Automation Bot
cccfc982f5 [fenix] Import l10n. 2021-07-17 00:27:34 +00:00
Mozilla L10n Automation Bot
ed598f1183 [fenix] Import l10n. 2021-07-16 00:34:42 +00:00
Roger Yang
9df7c99ed2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19847: Add telemetry for the default browser notification 2021-07-15 19:35:45 +00:00
Oana Horvath
276cd60ed4 [fenix] No issue: adds warning comment to beta & release running tests 2021-07-15 19:03:13 +00:00
Roger Yang
674dbafd94 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20307: Clear sharedViewModel selectedFolder when backing out of bookmark fragment 2021-07-15 15:28:29 +00:00
Roger Yang
213df0b403 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19989: Add rounded corners to recently tabs' icon 2021-07-15 14:20:11 +00:00
Mugurell
e469026805 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19933 - Show a media tab item on homescreen for the last tab with media 2021-07-15 10:05:20 +03:00
Roger Yang
e671e5314e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19846: Make sure default browser notification only happens once 2021-07-15 02:17:24 +00:00
Mozilla L10n Automation Bot
814f0ef0c9 [fenix] Import l10n. 2021-07-15 00:29:47 +00:00
Mugurell
1c733e918e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20229 - Use the AC common implementation for ads/search telemetry 
Everything should work exactly as before.
 2021-07-14 17:55:24 +03:00
mcarare
ef09a9c0e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20292: Use tint for home button icon. 2021-07-14 07:48:13 +00:00
mcarare
e44cc8ee69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17808: Remove deprecated systemUiVisibility and flags. 2021-07-14 07:19:25 +00:00
Mozilla L10n Automation Bot
abfbbbae16 [fenix] Import l10n. 2021-07-14 00:59:46 +00:00
Oana Horvath
972c83ea36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10915: fix tests by removing existing session 2021-07-13 08:18:50 +00:00
Rohan Maity
a92ae5b9b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1268 Add Unit test for PrivateShortcutCreateManager 2021-07-13 10:48:52 +03:00
Mozilla L10n Automation Bot
44ddf895ce [fenix] Import l10n. 2021-07-13 00:39:50 +00:00
Mozilla L10n Automation Bot
fc9aa22b9a [fenix] Import l10n. 2021-07-12 23:27:16 +00:00
Jonathan Almeida
c12a5b98ba [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20320: Use scope from testDispatcher in RecentBookmarksFeatureTest 2021-07-12 23:05:03 +00:00
Jonathan Almeida
c695a5c533 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20267: Filter out network errors from Nimbus 2021-07-12 22:42:05 +00:00
Marc Leclair
4cbc383520 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Restore logic to original behavior 2021-07-12 22:20:03 +00:00
Marc Leclair
e4d8d3e9a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: checkDefaultBrowser moved to helper function 2021-07-12 22:20:03 +00:00
Marc Leclair
6c2115cf4a [fenix] For 19804:Fixed call order in the 2021-07-12 22:20:03 +00:00
Marc Leclair
6e811abdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19804: Changed var isDefaultBrowser to a function 
The change to the function makes it so when the Settings.kt class is initialized, the isDefaultBrowser, which calls the
BrowserCache, won't get called right away. `isDefaultBrowser()` is known to take quite a while on start up on the G5+ (approx
30-40ms).
 2021-07-12 22:20:03 +00:00
Michael Comella
aac9149bb5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20127: fix app_received_intent extras. 
Apparently, it had been using the wrong mapping this whole time. I can't
wrap my head around fenix's glean wrapper so I'm not sure if this
resulted in bugs or if my change changes the behavior. However, I don't
think anyone is using this probe so I'm requesting to remove it. If we
don't end up removing it, then we can check for bugs/changes in
behavior. This isn't ideal but I'd rather not spend the time on it if we
don't have to.
 2021-07-12 21:53:54 +00:00
Michael Comella
154defa3b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup from metrics.yaml. 2021-07-12 21:53:54 +00:00
Michael Comella
f59df714f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20127: remove app_opened_all_startup integration. 2021-07-12 21:53:54 +00:00
Mozilla L10n Automation Bot
f183e9a9ef [fenix] Import l10n. 2021-07-11 00:30:23 +00:00
Mozilla L10n Automation Bot
44e9c55c64 [fenix] Import l10n. 2021-07-10 00:33:37 +00:00
Roger Yang
37758f8934 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20285: Remove unused GeckoProvider 2021-07-09 22:40:26 +00:00
Elise Richards
611774676d [fenix] For FNX-22339: Recently saved bookmarks (https://github.com/mozilla-mobile/fenix/pull/19835) 
* Title and button for home screen recently saved bookmarks section

Create bookmark item view with favicon and title

* View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

Make a use case for retrieving and updating the list of recently saved bookmarks

Add adapter items and define header viewholder binding

Use session interactor for header button clicks. Bind in the adapter

* Retrieve list of bookmarks asynchronously on home

Interactor and controller tests

Address review comments

Split up tests for recent bookmarks

Update to new interactors

Dark mode and light mode styles

Refactor bookmarks home stuff

* Add RecentBookmarksFeature to home

Move interactor to SessionControlInteractor

Clean up lint, styles, and dimens.

* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.

* View holder tests

* Match ux to designs for colors, margins, and scrolling

* Clean up clean up

* Tests for the view bound feature

* Controller test

* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-07-09 19:36:20 +00:00
Mozilla L10n Automation Bot
b76fe64eb3 [fenix] Import l10n. 2021-07-09 00:35:12 +00:00
Roger Yang
38cce79e1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Update default browser notification strings 2021-07-08 22:04:13 +00:00
Roger Yang
9fdd99943e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Only add default browser notification work if work is not pending 2021-07-08 18:36:14 +00:00
Roger Yang
048abd7f4c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846: Show Default Browser Notification if browser is not default 2021-07-08 17:52:08 +00:00
codrut.topliceanu
02d170a5b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20257 - Sets min no. of grid columns to 2 in TabsTray 2021-07-08 14:54:43 +00:00
codrut.topliceanu
ae19555d25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20250 - Adds FLAG_SECURE to TabsTray dialog 2021-07-08 08:49:06 +00:00
codrut.topliceanu
c805dd3320 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17855 - Stops SecureWindowFeature from removing FLAG_SECURE 2021-07-08 08:02:35 +00:00
Mozilla L10n Automation Bot
da25ab1b8e [fenix] Import l10n. 2021-07-08 00:38:02 +00:00
Grisha Kruglov
21dda6b6ab [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20276: Fall-back to URL parsing for tabs with parents to obtain search terms 2021-07-07 15:01:26 +00:00
Oana Horvath
1fa807ca1f [fenix] No issue: New UI smoke test for the Language menu 2021-07-07 12:18:16 +00:00
mcarare
42bfec3846 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20029: Remove animations when recreating activity on locale change. 2021-07-07 10:12:51 +00:00
codrut.topliceanu
55c0be886f [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Adds kdoc to TopSitePagerPayload 2021-07-07 07:22:45 +00:00
codrut.topliceanu
58657ebdef [fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Fixes top sites refresh and interactability 2021-07-07 07:22:45 +00:00
Mozilla L10n Automation Bot
a2c509b9af [fenix] Import l10n. 2021-07-07 00:36:50 +00:00
Roger Yang
d6150b8310 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20274: Limit about:config to Nightly and Beta 2021-07-06 23:32:16 +00:00
Roger Yang
50101046c3 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090: Show snackbar on adding to bookmarks from tabs tray 2021-07-06 22:13:38 +00:00
mcarare
613671c9c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in onboarding cards. 2021-07-06 16:29:09 +00:00