Commit Graph

7488 Commits (3d169a733d371d02351ee6327a0d7304aa2497d0)

Author SHA1 Message Date
Arturo Mejia 20a8a184a4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25212: Add tabs prioritization 2 years ago
Mugurell 300de19e05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Improve stories impressions recording.
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
2 years ago
Mugurell 5f946b6b22 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Consider the toolbar when reporting stories visibility
The toolbar may appear over the Pocket stories causing our functionality for
reporting when a specific story is visible to misreport.
At the moment hardcoding the toolbar height in the visibility checks seems like
the best solution to ensure reliable data.
2 years ago
Mugurell ce4bf5a766 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Allow the Pocket section to settle before reporting impressions
Currently just a hack that will ensure more reliable data.
This will have to be re-evaluated after the homescreen is migrated to compose.
2 years ago
Mugurell 364842f946 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Pace and rotate sponsored stories
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2 years ago
Roger Yang 791aec3396 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24299: Do not show history search engine in the search settings 2 years ago
Mozilla L10n Automation Bot e8eb107f90 [fenix] Import l10n. 2 years ago
Arturo Mejia 796da01ae6 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose"
This reverts commit b9e0a18233c0d30efd5f058eb3b7d24188ac5353.
2 years ago
Noah Bond df77449cbf [fenix] For https://github.com/mozilla-mobile/fenix/issues/25291 - Swap the new TextButton composable into WallpaperSettings 2 years ago
Noah Bond e07652bf38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25291 - Create a TextButton composable component 2 years ago
Roger Yang a61c3a778a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24299: Sort unified search selector menu items based on user settings 2 years ago
mcarare a3e50fb337 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25313: Handle exceptions when getting ClipData.Item. 2 years ago
Mugurell 3f15a9079e [fenix] For https://github.com/mozilla-mobile/fenix/issues/25311 - Set tokens used when communicating with Pocket 2 years ago
Arturo Mejia fc40fd435b [fenix] For https://github.com/mozilla-mobile/fenix/issues/25374: Skip action validation for control messages 2 years ago
AndiAJ 21d35adf8b [fenix] Disable failing useAppWhileTabIsCrashedTest UI test 2 years ago
AndiAJ 6703f0c16c [fenix] For https://github.com/mozilla-mobile/fenix/issues/25002 https://github.com/mozilla-mobile/fenix/issues/25184 and https://github.com/mozilla-mobile/fenix/issues/23417 fix testDownloadCompleteNotification testDownloadPrompt and testCloseDownloadPrompt 2 years ago
AndiAJ eda0ae4b34 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23481 fix disabled openLinkInAppTest UI test 2 years ago
Mugurell 4c02271ae0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Old imports cleanup.
Importing `R.string` does allow to avoid the `R` when using a String from
Resources but seems like a small gain to break app consistency.
2 years ago
Mugurell 0bfec6d6c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Show sponsored stories on debug only
The design asks for a new row in between the primary and the secondary text so
I went with making "ListItemTabSurface" public allowing for customizing the
content it will show but keeping the same layout and general UX.
2 years ago
Mugurell d5902b7a02 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Rename PocketStoriesChange to PocketStoriesClean
PocketStoriesChange was called only once - to clean the shown stories when the
user gets to the homescreen and the Pocket feature is disabled - useful for the
situations in which the user returns after disabling the feature in settings.

Populating the store with recommended stories to show was already happening
based on 'PocketStoriesCategoriesChange' and sponsored stories will be added by
using 'PocketSponsoredStoriesChange' so renaming 'PocketStoriesChange' will
help on reducing any confusion in the future.

Also added documentation for all Pocket related actions from AppStore and
removed the 'UndocumentedPublicClass' detekt suppressions.
2 years ago
Mugurell 67cc604dab [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Download sponsored stories on debug only 2 years ago
Mugurell f28fbf3240 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Use the `PocketStory` supertype
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2 years ago
Mugurell 15677b59b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Hardcode showing at max 8 Pocket stories
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2 years ago
AndiAJ 2f0189a2eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/23600 fix flaky saveLoginsInPWATest UI test 2 years ago
sarah541 633377e903 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose 2 years ago
Mozilla L10n Automation Bot f707f47355 [fenix] Import l10n. 2 years ago
mike a cc9d82fd20 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/25368: duplicate items in history
Change pagination to be based on loadSize of DataSource
2 years ago
mcarare 5a8a6a6e76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25360: Selectively update addresses preference only when needed. 2 years ago
Mozilla L10n Automation Bot 9e971eb249 [fenix] Import l10n. 2 years ago
AndiAJ 10ce734500 [fenix] Disable failing audioPlaybackSystemNotificationTest UI test 2 years ago
Alexandru2909 a59f065051 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23173 - CheckChanged use a single variable instead of two for checked status 2 years ago
Alexandru2909 7804a4ec12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23670 - Update collection on tab removal 2 years ago
mcarare f12935a278 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24968: Add preference for enabling/disabling addresses autofill.
For https://github.com/mozilla-mobile/fenix/issues/24968: Add preference for enabling/disabling addresses autofill.
2 years ago
Mozilla L10n Automation Bot e88c4a6675 [fenix] Import l10n. 2 years ago
Mozilla L10n Automation Bot 3a7a6a345b [fenix] Import l10n. 2 years ago
Robert-Aron293 a9aea04a85 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22310 - Change tab holder's checkbox state when pressing "Select All"/"Deselect All" 2 years ago
Roger Yang 348f43b2bd [fenix] Close https://github.com/mozilla-mobile/fenix/issues/25170: Fix flaky search fragment store tests 2 years ago
Roger Yang 5106048974 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/25288: Disable autocomplete for unified history search 2 years ago
JLRoberts 22923597c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23700 - HistoryFragment: Exit edit mode when multi-selection is opened in tabs or shared.
This mirrors behavior currently in Bookmarks library with the same actions.
2 years ago
Gabriel Luong b04e075f51 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24991 - Refactor the HomeMenu creation from HomeFragment to HomeMenuBuilder 2 years ago
Mozilla L10n Automation Bot 4eb6d2ea18 [fenix] Import l10n. 2 years ago
MatthewTighe 2e29b9ef7c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/24917: add country dropdown to address editor 2 years ago
Gabriel Luong e62e502664 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25119 - Add Secondary, Tertiary and Destructive Button composable components 2 years ago
James Hugman 7db1b80fb3 [fenix] Fixup tests 2 years ago
James Hugman bab0149d64 [fenix] Filter messaging experiments from the Studies screen 2 years ago
bendk 1894c0528d [fenix] Added features to support application-services branch builds (https://github.com/mozilla-mobile/fenix/pull/22945)
- Added support for `localProperties.branchBuild.application-services`
  and `localProperties.branchBuild.android-components`.  These work like
  the autoPublish properties. However, rather than
  auto-building/publishing application-services/android-components as
  part of the fenix build, we build it ahead of time with a specific
  version name, then specify that version in `local.properties` as
  `localProperties.branchBuild.application-services.version`.
- Added support for the `localProperties.branchBuild.fenix` gradle
  property to set the version for fenito set the version for fenix
- Added support for the absolute paths when running the substutition
  scripts.

The plan is to use this feature to build/test fenix using a particular
checkout of application-services and androd-components, with the
versions set to the git commit id.
2 years ago
AndiAJ 1c07fa2ccf [fenix] Fix externalLinkPWATest UI test 2 years ago
Gabriel Luong df143ec5b5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24936 - Replace ListItemIcon with IconButton and Icon 2 years ago
Mozilla L10n Automation Bot 2a79e80bac [fenix] Import l10n. 2 years ago
Roger Yang 2609047630 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24299: Add history to the search engine menu 2 years ago
Gabriel Luong 4c967a37ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/25264 - Refactor toShortUrl extension function from TabSessionState to String 2 years ago
Mugurell 7d02d4cbf2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24316 - Migrate TabInCollectionViewHolder to Compose 2 years ago
jhugman df4ea50387 [fenix] Change FxNimbus/Nimbus startup sequence (https://github.com/mozilla-mobile/fenix/pull/25266)
* Change FxNimbus initialization sequence

Add cache invalidation

* Change ordering of message restoration and Nimbus initialization

* Address reviewer comments
2 years ago
AndiAJ 5c658c4189 [fenix] Disable failing verifyContextMixedVariations UI test 2 years ago
AndiAJ c5d5b3e372 [fenix] Disable failing selectTabOnLongTapTest UI test 2 years ago
MatthewTighe fa8deb452c [fenix] for https://github.com/mozilla-mobile/fenix/issues/25167: ignore handleDeleteSingle and handleDeleteMultiple tests due to intermittent failures with coroutines 2 years ago
Mozilla L10n Automation Bot 6e17a4aec1 [fenix] Import l10n. 2 years ago
Arturo Mejia 73811608f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25209: Avoid trying to download wallpapers without a server URL. 2 years ago
Arturo Mejia 902dea1e28 [fenix] No issue: Add extension function to TabSessionState for shortening urls safely. 2 years ago
sarah541 e2aecb47b5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25176 - Refactor TabTitle and TabSubtitle 2 years ago
Oana Horvath 840cf3a041 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20754: Fix scrolling issues and re-enable verifyAboutFirefoxPreview 2 years ago
dlp d31e8ae93d [fenix] For https://github.com/mozilla-mobile/fenix/issues/24660 - Overrided contentsSameAs inside TabInCollectionItem class. 2 years ago
Mozilla L10n Automation Bot 53f52a4bc5 [fenix] Import l10n. 2 years ago
Arturo Mejia 994fdaec0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/25145: Unify behavior for opening systems setting for updating the default browser preference 2 years ago
Mozilla L10n Automation Bot 4befb1746f [fenix] Import l10n. 2 years ago
Mozilla L10n Automation Bot 8984a3ec33 [fenix] Import l10n. 2 years ago
Arturo Mejia 82a0a4f1f0 [fenix] Revert "Change FxNimbus initialization sequence (https://github.com/mozilla-mobile/fenix/pull/25089)"
This reverts commit b7427874e73ebaad5f8553b7a8614a7babdc8baa.
2 years ago
jhugman 5beb1da884 [fenix] Change FxNimbus initialization sequence (https://github.com/mozilla-mobile/fenix/pull/25089)
* Change FxNimbus initialization sequence

* Add cache invalidation
2 years ago
dlp 771d109712 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24666 Changed trackingProtectionLayout's bottomToTop constraint from clearSiteDataLayout clearSiteDataDivider 2 years ago
Mozilla L10n Automation Bot 08e24f8278 [fenix] Import l10n. 2 years ago
Mozilla L10n Automation Bot 28b98bdc3a [fenix] Import l10n. 2 years ago
Gabriel Luong 34e226adc0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25179 - Display a save or update credit card prompt 2 years ago
Mugurell c1e91e6f0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Disable ui tests code affected by the migration
After migrating to compose identifying widgets and interacting with them will
need to be updated.
Checked with Oana about the approach, commenting the code seems better.
2 years ago
Mugurell 7185eee3df [fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Replace the xml based CollectionViewHolder with a composable 2 years ago
Mugurell d92adcff12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Move CollectionViewHolder to home/collections
Doing just a file move in a separate commit will ensure git history of the file
is kept when this will be later updated.
2 years ago
Mugurell 577090cccf [fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Complete removing the broken code for focusing the newly created collection
The removal was initially scheduled to happen in the PR for https://github.com/mozilla-mobile/fenix/issues/24333
but landed separately in https://github.com/mozilla-mobile/fenix/pull/25045.
These are two small leftovers.
2 years ago
AndiAJ 38852866e1 [fenix] Disable failing useAddonsInPrivateModeTest UI test 2 years ago
Mozilla L10n Automation Bot 347c59702f [fenix] Import l10n. 2 years ago
sarah541 d2fa53ff1d [fenix] For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose 2 years ago
Mugurell d75322cbaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/25167 - Disable "handleDeleteAbnormal" as intermittently failing. 2 years ago
MatthewTighe a5643471f2 [fenix] for https://github.com/mozilla-mobile/fenix/issues/24931: create address label and description based on available data 2 years ago
Aaron Train 05d51d4bcb [fenix] For https://github.com/mozilla-mobile/fenix/issues/25132 - Catch intermittent RuntimeException in early getInstrumentation() call
fix: ktlint
2 years ago
Mugurell c6bb6c247e [fenix] For https://github.com/mozilla-mobile/fenix/issues/23876 - Update kotlinx-coroutines to 1.6.1. Refactor runBlocking in tests.
After the update `TestCoroutineDispatcher`, `TestCoroutineScope` and
`runBlockingTest` are deprecated.
Instead of these new `TestDispatcher`, `TestScope` and `runTest` APIs are used.

Took the oportunity to also replace most of the `runBlocking` calls with the
new `runTest` specially designed for running coroutines in tests API.
2 years ago
AndiAJ f14b746b89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24998 fix flaky deleteDeleteBrowsingHistoryDataTest UI test 2 years ago
mcarare c7115455e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24966: Navigate back to previous screen when the last address is deleted. 2 years ago
mcarare 785b88334c [fenix] For https://github.com/mozilla-mobile/fenix/issues/24919: Add option menu in the address editor. 2 years ago
mcarare adc764ca0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/24854: Add ability to delete an existing address. 2 years ago
mcarare 02fb70abf9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24855: Allow updating info for an existing address. 2 years ago
bendk 81e4534da1 [fenix] Application services 93.0.1 (https://github.com/mozilla-mobile/fenix/pull/24904)
* Fixup breaking changes from AppServices upgrade to 93.0.0

* android-components RemoteTabsStorage now requires a Context param

* Update Android Components version to 102.0.20220509214046

Co-authored-by: James Hugman <james@hugman.tv>
Co-authored-by: Mark Hammond <mhammond@skippinet.com.au>
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Mozilla L10n Automation Bot c9b171f119 [fenix] Import l10n. 2 years ago
Roger Yang 116e8f7702 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24738: hide the QR code button when switching to none default search engine 2 years ago
Gabriel Luong 4d5c8f5ce3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25113 - Remove showClearSiteData feature flag 2 years ago
AndiAJ 9490fea9e9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23816 fix disabled verifyMultipleLoginsSelectionsTest UI test 2 years ago
Mozilla L10n Automation Bot cad6b21cd1 [fenix] Import l10n. 2 years ago
AndiAJ 13204c826a [fenix] For https://github.com/mozilla-mobile/fenix/issues/24993 and https://github.com/mozilla-mobile/fenix/issues/25085 fix flaky UI tests 2 years ago
Mozilla L10n Automation Bot 7f700b0c2f [fenix] Import l10n. 2 years ago
Arturo Mejia 3b29180062 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25142 increase the EXPECTED_NUMBER_OF_INFLATION to count for the messaging framework message. 2 years ago
Arturo Mejia 95c9a2412c [fenix] For https://github.com/mozilla-mobile/fenix/issues/25142 increase the EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN to count for the messaging framework message. 2 years ago
Arturo Mejia 3e1fb47096 [fenix] Disable intermittent tests https://github.com/mozilla-mobile/fenix/issues/20754. 2 years ago
Arturo Mejia a567877e46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25110: Enable the messaging framework feature 2 years ago