Commit Graph

6784 Commits (00cc662e9fa514f7d362b068630277d220aef324)

Author SHA1 Message Date
Roger Yang 5cc5b50595 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22550: Refactor search term tab grouping logic to rely on middleware 3 years ago
Grigory Kruglov 8c61f0c754 [fenix] Adjust logins diffing logic for recyclerview 3 years ago
Grigory Kruglov b322e4c19b [fenix] Scroll to top of logins screen after list changes 3 years ago
Grigory Kruglov 364f558857 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22795: Stop trimming login origins on sorting
Due to the async nature (??) of the trimming code, this is causing severe performance issues
during search.

Looking back through commits, doesn't seem like there's a particularly good reason we were trimming here. All I could find is https://github.com/mozilla-mobile/fenix/pull/9986 (comment) which is lacking explanation of why this is actually useful.

And currently, we're dealing with an origin (not a full url when this was initially written, I think), i.e. https://accounts.firefox.com vs https://accounts.firefox.com/signin. So, the suffix stripping isn't even doing much beyond removing com in vast majority of cases.

So, seems like all of this trimming stuff can be cleaned up.
3 years ago
Mozilla L10n Automation Bot 64a9715198 [fenix] Import l10n. 3 years ago
mcarare e9d42361a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22559: Update leak canary version to 2.8.1 3 years ago
Gabriel Luong 993c0f9ede [fenix] For https://github.com/mozilla-mobile/fenix/issues/23128 - Remove @color/mozac_widget_favicon_border_dark_theme redirection 3 years ago
Gabriel Luong 12d0f4fa56 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23128 - Remove @color/mozac_widget_favicon_background_dark_theme redirection 3 years ago
Gabriel Luong fa2f68cae1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23128 - Remove @color/mozac_widget_favicon_border_light_theme redirection 3 years ago
Gabriel Luong 549755704f [fenix] For https://github.com/mozilla-mobile/fenix/issues/23128 - Remove @color/mozac_widget_favicon_background_light_theme redirection 3 years ago
Gabriel Luong e0ae5ef818 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23128 - Remove @color/mozac_widget_favicon_[background|border]_private_theme redirection 3 years ago
Gabriel Luong 0ed13fe6ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/23156 - Remove all unused strings marked moz:removedIn <= 95 3 years ago
Brais Gabín 26a4ec05d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23142 - Fix license formatting in tests 3 years ago
Mozilla L10n Automation Bot a8913b7103 [fenix] Import l10n. 3 years ago
Elise Richards 158dfd8154 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22869: Data review for renewing january metrics 3 years ago
Elise Richards 798e455d78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22869: Renew metrics expiring in January 3 years ago
Mozilla L10n Automation Bot 4962eed016 [fenix] Import l10n. 3 years ago
Arturo Mejia 5f4efe1638 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23104: Don't adjust the theme for the default wallpaper. 3 years ago
Mozilla L10n Automation Bot 06d677cbda [fenix] Import l10n. 3 years ago
Gabriel Luong b4037b4851 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22675 - Replace collection color icon variables with the icon design color tokens 3 years ago
Alexandru2909 5158e38ce9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19567 - Change SavedLogins and LoginDetail fragments to extend SecureFragment 3 years ago
Gabriel Luong f793e5e988 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Add Border Inverted design token 3 years ago
Gabriel Luong 7fddab3048 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Change design token name from Border Selected to Border Accent 3 years ago
Gabriel Luong 1d3e76f885 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Update Border Divider to Border Default 3 years ago
Gabriel Luong f97de9afe4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Rename design token name from Border Default to Border Form Default 3 years ago
Gabriel Luong 96ce53ae8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Update the dark theme colors of Action Primary to Violet60
- Updates the description of Action Primary to include "Chip selected"
3 years ago
Gabriel Luong f3e72c7602 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Update the dark theme Action Secondary color to DarkGrey10 3 years ago
Gabriel Luong 7a1fe9836a [fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Change the light theme color for Form Selected, Form On, Icon Button, Layer Accent, Border Selected to Ink20 3 years ago
mcarare be7ae5e488 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22577: Update work manager version to 2.7.1 3 years ago
Mozilla L10n Automation Bot c7c24a5bfd [fenix] Import l10n. 3 years ago
Gabriel Luong c8ebd54b76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22975 - Replace aboutLink attribute with Text Accent color token 3 years ago
Gabriel Luong 7ef7a37e24 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23076 - Clean up unneeded FeatureFlags 3 years ago
Mozilla L10n Automation Bot 996fc1b8cd [fenix] Import l10n. 3 years ago
Gabriel Luong 970b6107b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23071 - Replace @color/tab_tray_selected_mask_normal_theme with @color/fx_mobile_layer_color_accent_nonopaque 3 years ago
MickeyMoz 0a5e26c940 [fenix] Update Android Components version to 97.0.20220104190053. 3 years ago
Arturo Mejia 0b88222bf5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22851: Adjust theme based on the selected wallpaper. 3 years ago
Mozilla L10n Automation Bot d6cca53ac2 [fenix] Import l10n. 3 years ago
Gabriel Luong 3084f14346 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22978 - Replace @color/foundation_normal_theme with @color/fx_mobile_layer_color_1 3 years ago
Gabriel Luong ceb30bfaa7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23049 - Update the color for @color/fx_mobile_layer_color_accent_nonopaque 3 years ago
Gabriel Luong 33c8f813a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23049 - Update the colors of @color/fx_mobile_action_color_primary 3 years ago
Gabriel Luong 1c0b502f97 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23049 - Consolidate @color/fx_mobile_text_color_accent with @color/fx_mobile_text_color_action
- Removes @color/fx_mobile_text_color_action
- Use the colors from @color/fx_mobile_text_color_action in @color/fx_mobile_text_color_accent
3 years ago
Arturo Mejia b2329b0802 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22995: Address crash when switching languages. 3 years ago
Aaron Train 08a83e287d [fenix] No issue: Try out RetryTestRule in SmokeTest UI test class (https://github.com/mozilla-mobile/fenix/pull/22868)
* Add RetryTestRule to SmokeTest UI tests

* fix: newline in RetryTestRule.kt

fix: switch off generic Throwable

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
mcarare 1facaaf775 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22879: Filter default engines when sending telemetry.
Filter out custom engines that are not well known search domains.
3 years ago
Gabriel Luong cb307f7bd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23017 - Ignore ExtraTranslation in our lint-baseline 3 years ago
Mozilla L10n Automation Bot 579968221c [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 0190e82e9e [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot e752fba41e [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 02318ce631 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot a742f46a1a [fenix] Import l10n. 3 years ago
mike a deb174462d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10737: Searching a language/saved password displays a misplaced "x".
Setting max width for the search view in language settings and saved logins screens. Removed SyncAuthClosed event from LocaleSettingsFragment, an apparent copy-paste.
3 years ago
Mozilla L10n Automation Bot 8a591ac6e2 [fenix] Import l10n. 3 years ago
Gabriel Luong ed58de80f6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22973 - Remove @color/contrast_text_light_theme redirection 3 years ago
Gabriel Luong dde2d7edd7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22983 - Remove @color/destructive_button_text_color redirection 3 years ago
TasosB 7c78a27e27 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21483 - Remove light theme tinting of folder icon in the Bookmark view 3 years ago
TasosB 59ce66c404 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21483 - Use primaryText attribute for download icons fill color 3 years ago
Gabriel Luong ea66e3c8a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22971 - Remove @color/above_dark_theme redirection 3 years ago
Mozilla L10n Automation Bot 29534669d6 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot f8f9be73a5 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot d0dae450d9 [fenix] Import l10n. 3 years ago
rxu a8084ee002 [fenix] Pass distribution_id to Socorro crash report 3 years ago
Mozilla L10n Automation Bot f3e51f1055 [fenix] Import l10n. 3 years ago
Gabriel Luong 0a558bf3bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Add Form On, Form Off, Indicator Active, Indicator Inactive color tokens 3 years ago
Gabriel Luong 3079590c50 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Remove Control Active color token 3 years ago
Gabriel Luong 23dfc29dfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Update description of Layer Accent color token 3 years ago
Gabriel Luong 5db66444ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Update description of Text Inverted color token 3 years ago
Gabriel Luong 47729fd237 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Remove Control Dark design color token 3 years ago
Gabriel Luong f6f0964023 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Rename Action Disabled to Form Disabled for the design color tokens 3 years ago
Gabriel Luong 2db2c4fb36 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Update Control to Form Surface design colors 3 years ago
Gabriel Luong c16c812f68 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Add Form Selected design color token 3 years ago
Gabriel Luong cfa4cc5471 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Update Action Teritary to Form Default design colors 3 years ago
Gabriel Luong 4cf43391b9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Change Pill button to Chip for Action Secondary design color token description 3 years ago
Gabriel Luong bd932f1fed [fenix] For https://github.com/mozilla-mobile/fenix/issues/22965 - Remove Toolbar background from the description of Layer 3 design color token 3 years ago
Roger Yang 9bb5e0a621 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22754: Customize home button should work on fresh install 3 years ago
Arturo Mejia 8dcd6a7faf [fenix] For https://github.com/mozilla-mobile/fenix/issues/22851: Optimize wallpaper testing images. 3 years ago
Roger Yang a9360bb98a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22561: Fix tab group titles colour when in private mode 3 years ago
mcarare afddd6ec32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22415: Remove element type from content descriptions.
Adding the type to content description is not advised according to a11y guidelines.
3 years ago
Gabriel Luong fb8b281431 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/22777 - Replace about_link_normal_theme with fx_mobile_text_color_action"
This reverts commit 18d66ce1e3e246a4c190e03ca07cf85937e1047c.
3 years ago
mavduevskiy e88bda15df [fenix] For https://github.com/mozilla-mobile/fenix/issues/18160: Show a prompt when trying to leave private browsing with active downloads (https://github.com/mozilla-mobile/fenix/pull/22912)
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
Mozilla L10n Automation Bot 4a8c0d59cc [fenix] Import l10n. 3 years ago
Grisha Kruglov c367072d11 [fenix] Refactor History types to eliminate nullability
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.

With this refactor, we entirely eliminate nullability from these types.
3 years ago
Grisha Kruglov b13e149900 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22764: Convert History.id to an Int position
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.

This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
Mugurell ae7909671e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22852 - Add a new "Storage access" permission 3 years ago
Arturo Mejia 9e15247269 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22931 Only enable wallpapers on normal mode 3 years ago
mcarare 4e6406e15e [fenix] For https://github.com/mozilla-mobile/fenix/issues/20513: Use UrlMetricType for search engine submission url. 3 years ago
Roger Yang 1735a245c0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22736: Do not remove focus from toolbar when scrolling 3 years ago
Arturo Mejia 5143063813 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 toggle wallpapers when tap on the Firefox logo 3 years ago
rxu de1e52a234 [fenix] Add default topsite MeiTuan for MozillaOnline builds 3 years ago
Mozilla L10n Automation Bot f110c8eca9 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 574136432c [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot dad42ce9a1 [fenix] Import l10n. 3 years ago
Matt Tighe 1c898c756c [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22889: add bottom spacer to onboarding adapter 3 years ago
Mugurell 0244f2156f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22508 - Increase menu height to avoid it become scrollable
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
3 years ago
Roger Yang 11417996c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22671: Show correct time groups header in history 3 years ago
mcarare 4cd7064540 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22450: Replace quit icon with AC one. 3 years ago
Mozilla L10n Automation Bot 67f56b7031 [fenix] Import l10n. 3 years ago
Grisha Kruglov 6b7cdce783 [fenix] Fix breaking change in KeyProvider
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
3 years ago
Grisha Kruglov 4ad2c1c592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22569: Remove allopen plugin and Mockable annotations 3 years ago
rxu 803549e11f [fenix] Modify strings for Privacy notice for MozillaOnline builds 3 years ago
Mozilla L10n Automation Bot 6a54899d0c [fenix] Import l10n. 3 years ago
Gabriel Luong 6f331743d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22858 - Set all @color/tab_tray_item_media_stroke usages to @color/photonWhite 3 years ago
Matt Tighe 817760d64c [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/20833: move home recycler bottom margin into standalone item 3 years ago
Gabriel Luong 816677db45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22842 - Use gradient color tokens for Reader mode gradient 3 years ago
Gabriel Luong a9a26965ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/22836 - Replace primary_text_private_theme with fx_mobile_private_text_color_primary color token 3 years ago
Noah Bond d8bee937cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/22832 - Added parameters to base Text composables 3 years ago
Arturo Mejia 49444cfdf7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 add wallpapers feature flag 3 years ago
Gabriel Luong 85d4b025a4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove unused tabTrayHeadingIcon and tabTrayHeadingIconInactive attributes 3 years ago
Gabriel Luong f0638c8294 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove @color/tab_tray_heading_icon_inactive_dark_theme redirection 3 years ago
Gabriel Luong e2c76c0ad2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22839 - Remove @color/tab_tray_heading_icon_dark_theme redirection 3 years ago
Mozilla L10n Automation Bot fc74ae29e8 [fenix] Import l10n. 3 years ago
Gabriel Luong 8ecbffef61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22808 - Add private theme design tokens 3 years ago
Gabriel Luong 8b0a49c9fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/22809 - Use the design tokens for the Scrim Start/End colors 3 years ago
Gabriel Luong 57b78972f6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22812 - Remove unused shadow attribute 3 years ago
Gabriel Luong 949545d88a [fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayToolbarBackground attribute 3 years ago
Gabriel Luong bbafc879ce [fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayItemSelectedBackground attribute 3 years ago
Gabriel Luong 0364ad33e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22800 - Remove unused tabTrayItemBackground attribute 3 years ago
Mozilla L10n Automation Bot 64157037c5 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 267118527e [fenix] Import l10n. 3 years ago
Gabriel Luong 7f1918bd32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Update the colors for Scrim Start/End design tokens 3 years ago
Gabriel Luong 7c9e44b61d [fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Swap the colors for Gradient Start/End design tokens 3 years ago
Gabriel Luong eecb775f83 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Add Icon Gradient Start/End color tokens 3 years ago
Gabriel Luong e0d4f0b496 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Rename fx_mobile_icon_color_notice color token to fx_mobile_icon_color_information 3 years ago
Matt Tighe 4b6a1d2256 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/22688: remove inactive_tabs_recently_closed probe 3 years ago
Gabriel Luong 861609816d [fenix] For https://github.com/mozilla-mobile/fenix/issues/22777 - Replace about_link_normal_theme with fx_mobile_text_color_action 3 years ago
Gabriel Luong 257c8a0f13 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22779 - Remove @color/inset_light_theme redirection 3 years ago
mcarare 7b2460a2e5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22784: Show collection snackbar only if fragment is still attached. 3 years ago
mcarare 01c4bf049a [fenix] For https://github.com/mozilla-mobile/fenix/issues/17130: Replace hardcoded strings with string resources. 3 years ago
Mozilla L10n Automation Bot 9d53193299 [fenix] Import l10n. 3 years ago
aime Soriano Pastor 37ec88478e [fenix] For https://github.com/mozilla-mobile/fenix/issues/9294: Add option to clear current site data in quick settings dialog. 3 years ago
Gabriel Luong 433ae3f6c5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22694 - Remove primary_text_dark_theme usage 3 years ago
MickeyMoz 4b3e25dcf6 [fenix] Update Android Components version to 97.0.20211208143435. 3 years ago
Mozilla L10n Automation Bot ab220e2995 [fenix] Import l10n. 3 years ago
Jonathan Almeida 4d889b852a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22757: Check the parent cast to AbstractBrowserTrayList first
We re-use the same ViewHolders in search term groups, so when we need to
cast to a AbstractBrowserTrayList for tab reordering, we need to check
our parent correctly first.
3 years ago
Christian Sadilek f32aab496e [fenix] Support tab movement/reordering (https://github.com/mozilla-mobile/fenix/pull/22751)
* Adds basic support for tab reordering via drag-and-drop selected tabs

* ktlint/detekt formatting

* Use defaultTabsFilter (now not private) instead of getter

* Convert from position+filter API to target+placeAfter
Unfortunately I still need the filter passed around a bit

* Handle inactive tabs' holder being children of the RecyclerView of the normal tabs
Don't go through LayoutManager needlessly

* Non-working use tabID the whole way. Does not compile.

* Fix to do direct tab ID and use grid setting directly

* Remove non-null assertion. Now fully works for "other" tabs.

* Prevent grouped tabs from being dragged

* Remove unused import

* Add/fix comments

* Do API version check and use deprecated startDrag if too old.

* Build process fails: both outdated and too new, so reverting to just too new

* Use deprecated function and suppress warning

* fix space

* Suppress "TooManyFunctions" on DefaultTabsTrayController

* Repeatedly update tab movement during drag

* Remove multi-tab movement, only allow dragging if tab groups disabled, fix tab positioning during movement
I'm forced to suppress LongParameterList to get the settings information where it needs to go though

* Remove settings argument and corresponding long args suppression: instead get settings from parent AbstractBrowserTrayList's context

* New UI: Select a tab and then, while holding down, start dragging

* Revert to using before/after boolean to accomodate delays
Move drag transparency to start of drag

* Use new BlankDragShadowBuilder and DraggableItemAnimator to handle tab movement

* Replace Pair<>s with data classes

* Only drag if exactly 1 tab selected, don't consume drag event if not used

* Auto-scroll tab tray while dragging near top/bottom edge

* Remove unexpected scrolling on tab bind (triggered when tab is selected)

* Fix broken scroll behavior during dragging

* Cleanup for ktlint/detekt

* Constantly set elevation during drag in case of update
Clean code at drag start

* Add custom drag start behavior

* Add drag distance constant, do all touch-drag behavior in OnTouchListener

* Disable parent vertical scrolling on drag start, fix detekt ComplexCondition

* Minor cleanup/comments

* Revert removal of scroll on bind, this was related to something different

* Correction to prepareForDrop to match documentation- doesn't seem to have any effect

* Simplify via unchecked typecast, use ViewCompat

* Use ViewConfiguration.scaledTouchSlop instead of arbitrary 30px

* Added tabReorderingFeature flag, split drag interactor to separate function to satisfy complexity requirement

Co-authored-by: Steven Knipe <ssk97@case.edu>
Co-authored-by: ssk97 <knipesteven@gmail.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
Christian Sadilek 5daf8934ca [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21759: Do not render home fragment when launching to tab
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
3 years ago
Mozilla L10n Automation Bot 43c3c127aa [fenix] Import l10n. 3 years ago
Gabriel Luong 4a932557ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/22741 - Remove all unused strings marked moz:removedIn <= 94 3 years ago
Christian Sadilek 6b9dc4c958 [fenix] Introduce timeout for capturing thumbnail in BrowserAnimator 3 years ago
Christian Sadilek 9150d8061b [fenix] Prevent flash when navigating to home 3 years ago
Christian Sadilek 57f46aa08e [fenix] Fix BrowserRobot.goToHomescreen to wait for home screen to be rendered
It was previously just waiting for the application to be idle, which
is not a reliable check in case the navigation to home is triggered
on completion of an async operation i.e., the app / main thread may
be idle, but the navigation to home hasn't completed yet.

goToHomeScreen further needs to wait for the browser fragment's
home button to exist before clicking it.
3 years ago
Mugurell bc4f92afd1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22445 - Improve the scrolling behavior for Recently visited
One important issue was that the items are smaller that the width of the
screen and so a bit of the next column would be showing also and user could
interact with this only peaking items and a long press would open a dropdown
menu with no place to anchor it.
To mitigate this:
- the items will now snap to the next position when scrolling so that we'll
always show at least one column in it's entirety.
- menus are enabled only if more than half of the item is visible effectively
disabling clicks on that peaking area of neighbour columns.

This patch also updates the divider for history groups which previously wasn't
showing.
3 years ago
Gabriel Luong 96b41c0003 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22729 - Tag unused strings for removal 3 years ago
Andrei Joltan edd33f2685 [fenix] [UI Smoke Tests] New undoDeleteBookmarkFolderTest UI test and Improve coverage for deleteNonEmptyBookmarkFolderTest UI test (https://github.com/mozilla-mobile/fenix/pull/22587)
* New undoDeleteBookmarkFolderTest smoke UI test

* Improve coverage for deleteNonEmptyBookmarkFolderTest UI smoke test

Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot 87203e4afb [fenix] Import l10n. 3 years ago
Gabriel Luong 206074a45e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22702 - Replace home_show_all_button_text with fx_mobile_text_color_action color token 3 years ago
Gabriel Luong c467be006e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22725 - Regenerate lint-baselint.xml 3 years ago
Gabriel Luong e7f3dd478a [fenix] For https://github.com/mozilla-mobile/fenix/issues/22701 - Replace whats_new_notification_color with fx_mobile_icon_color_notice color token 3 years ago
Gabriel Luong 2400e44396 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22712 - Remove unused menuCategoryText attribute 3 years ago
Gabriel Luong 2989b4385d [fenix] For https://github.com/mozilla-mobile/fenix/issues/22696 - Remove unused tab_header.xml resource 3 years ago
Gabriel Luong 2c3f13900f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22708 - Remove unused syncedTabsSeparator attribute 3 years ago
Sarah Khan 202b3bf08f [fenix] For https://github.com/mozilla-mobile/fenix/issues/22495 - Disable inactive tabs survey 3 years ago
Gabriel Luong 7ee3adbe81 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22698 - Remove unused mozac_browser_menu_item_switch.xml resource 3 years ago
Mozilla L10n Automation Bot 519b761344 [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 106b8a60ec [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 196ccab368 [fenix] Import l10n. 3 years ago
Noah Bond 563c1f8610 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22691 - Add Composables for Primary and Secondary text 3 years ago
Gabriel Luong ab52526074 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22676 - Replace top_site_title_text with fx_mobile_text_color_primary color token 3 years ago
Oana Horvath a776cabd2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21002: Add testETPOffGlobally UI smoke test 3 years ago
Gabriel Luong 9c7e54ea87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22654 - Add new color tokens provided by the design systems to colors.xml 3 years ago
Gabriel Luong 175a230b50 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22637 - Add new color tokens provided by the mobile styles to FirefoxTheme 3 years ago
Mozilla L10n Automation Bot a1b0dd184a [fenix] Import l10n. 3 years ago
Noah Bond a13e904d34 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22516 - Fixed alignment of "Show all" buttons on the homescreen (https://github.com/mozilla-mobile/fenix/pull/22650)
* For https://github.com/mozilla-mobile/fenix/issues/22516 - Fixed show all button alignment with section headers on the Homepage

* For https://github.com/mozilla-mobile/fenix/issues/22516 - Added correct content description back in for recently visited show all button

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek 33e5a1ee35 [fenix] Refactor: Move historymetadata classes in separate package 3 years ago
AndiAJ 5959b0a309 [fenix] Refactor recently closed tabs UI smoke tests 3 years ago
AndiAJ c9a18b8b03 [fenix] Move verifyRecentlyClosedTabsListTest UI test from SmokeTest class 3 years ago
AndiAJ 771d143c12 [fenix] Disable failing verifyUndoSnackBarTest UI test 3 years ago
Sebastian Kaspari e76776647c [fenix] Android Autofill: Enable keyboard inline autofill suggestions 3 years ago
Roger Yang 9534fa2356 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20701: Dismiss keyboard when scrolling home screen 3 years ago
Mozilla L10n Automation Bot 313a3a6504 [fenix] Import l10n. 3 years ago
rxu 892989f0dd [fenix] Add distribution_id into first session ping 3 years ago
Mozilla L10n Automation Bot 3de1b505c2 [fenix] Import l10n. 3 years ago
Gabriel Luong 7b54536a7e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22592 - Refactor hideOnboardingIfNeeded() calls when the home menu items are tapped 3 years ago
Mugurell f70dfb6ef9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22534 - Show history highlights and groups in "Recently visited" (https://github.com/mozilla-mobile/fenix/pull/22535)
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update homescreen section name to "Recently visited"

* For https://github.com/mozilla-mobile/fenix/issues/22534 - Show both history highlights and groups in Recently visited

For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.

Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.

A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.

* For https://github.com/mozilla-mobile/fenix/issues/22534 - Rename and refactor historymetadata to recentvisits

The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home

* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update UI tests to account for the new items space on the screen

Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.

Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.

* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>

* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond 97e59a9717 [fenix] Tab group count telemetry (https://github.com/mozilla-mobile/fenix/pull/22479)
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Refactored tab sorter metrics into a middleware

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created distribution metric for tab group sizes

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created tests for tabs tray middleware

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Merge fixes

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added PR number to metric

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added missing line to middleware to have the Store process actions

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Updated metric expiration to December

* For https://github.com/mozilla-mobile/fenix/issues/22410 - PR Feedback

* For https://github.com/mozilla-mobile/fenix/issues/22410 - Removed else from middleware when
3 years ago
Mozilla L10n Automation Bot be8dce555b [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 6f49599ea3 [fenix] Import l10n. 3 years ago
Gabriel Luong c7aea80bb2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22595 - Remove unused OnboardingAutomaticSignInViewHolder 3 years ago
Sebastian Kaspari f1a4296eb6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22552: Optimize PNGs with ImageOptim 3 years ago
Gabriel Luong 5b069b2ece [fenix] For https://github.com/mozilla-mobile/fenix/issues/22211 - Use Hero images for Recent Bookmarks 3 years ago
Arturo Mejia 72a0b5703c [fenix] Update Android Components version to 96.0.20211125162700. 3 years ago
Arturo Mejia 4cc4e1c67d [fenix] Improve loading URLs 3 years ago
Sebastian Kaspari 798c9bc294 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22580: Track APK size in perfherder 3 years ago
Sebastian Kaspari a65a9591b8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731: Disable suspending of engine sessions under memory pressure in Nightly 3 years ago
Mugurell e665397890 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display individual tab if part of the Jump back in tabs group
We'll show as a recent tab the next most recent tab not part of the last active
search group.
3 years ago
Mugurell 3dea07855e [fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display history group if already in Jump back in 3 years ago
AndiAJ c09104308d [fenix] New text search UI smoke tests 3 years ago
Mugurell 364119deea [fenix] For https://github.com/mozilla-mobile/fenix/issues/22502 - Keep the previous string resource until safe to remove
See https://github.com/mozilla-mobile/fenix/issues/20871
3 years ago
Matt Tighe 369af67f41 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22321: Add temporary protoc version workaround for M1 Macbooks 3 years ago
Gabriel Luong 6b5ce4d387 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22488 - Fix intermittent test failure with InactiveTabsControllerTest 3 years ago
Gabriel Luong 100d5372ee [fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose 3 years ago
AndiAJ f2e74f31f8 [fenix] Improve expand/collapse collection UI test coverage 3 years ago
AndiAJ 62560b4d5c [fenix] Improve collection deletion UI coverage 3 years ago
Grisha Kruglov ca22bb6ceb [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22499: Emit search group disband action on history group removal
This is needed to prevent removed search groups from coming back after
user interacts with the tab. E.g. if we don't fire this action, upon
interaction with the tab after a corresponding search group was removed
we will end up creating metadat with the deleted 'searchTerms' (they'll
be read from the 'historyMetadata' state on the tab).

At this point we probably want to start encapsulating all of this in a
use case - let's do that separately in
https://github.com/mozilla-mobile/android-components/issues/11309, and
just fix the bug for now.
3 years ago
Oana Horvath bb36ddee12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21002: improves the share tabs smoke tests coverage 3 years ago
Mozilla L10n Automation Bot b764027bc0 [fenix] Import l10n. 3 years ago
Arturo Mejia 1284096722 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/22537 crash: BookmarkFragment is attached to a context 3 years ago
Arturo Mejia 5737a5533c [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/5298 the same page appears in the History section multiple times 3 years ago
Mugurell 86f80f2652 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22502 - Update "Jump back in" group's subtitle format 3 years ago
Mozilla L10n Automation Bot 5183cd3c4d [fenix] Import l10n. 3 years ago
Mozilla L10n Automation Bot 748f15bc2d [fenix] Import l10n. 3 years ago