Commit Graph

51312 Commits

Author SHA1 Message Date
Rubidium
2606f5409a Fix: leaking file descriptors
(cherry picked from commit 495d73a67f)
2021-05-30 07:52:55 +01:00
Rubidium
7c4d803265 Fix: memory leak due to assigning result of strdup to a std::string
(cherry picked from commit 296194ad36)
2021-05-30 07:52:46 +01:00
Jonathan G Rennison
bf87578173 Fix #264: Crash before calling SDL_SetTextInputRect with no window focused 2021-05-30 07:38:37 +01:00
rubidium42
62e3bfd684 Fix #9243: [Network] For a dedicated server use a fallback client and server name
Also warn when the client or server name has not been set and provide pointers on how to set them

(cherry picked from commit 0968d009c8)
2021-05-30 06:45:44 +01:00
Jonathan G Rennison
f703e23322 Fix assert fail when ChooseTrainTrack called on disallowed 90 degree turn 2021-05-29 02:22:27 +01:00
Jonathan G Rennison
c0bf8476b1 Tracerestrict: Fix PBS entry signal conditional with signalled tunnel/bridges 2021-05-26 01:26:28 +01:00
Jonathan G Rennison
0579c8755c Add tracerestrict action: No PBS signal back PF penalty 2021-05-25 18:50:36 +01:00
Jonathan G Rennison
112b235b71 Fix name prefix of TraceRestrictNewsControlField enum values 2021-05-25 18:21:24 +01:00
Jonathan G Rennison
f2aa034a58
Merge pull request #261 from telk5093/jgrpp
Update: Korean translation for v0.41.2 + a
2021-05-22 10:07:13 +01:00
TELK
6113fd9bf0 Update: Korean translation for v0.41.2 2021-05-22 12:56:11 +09:00
TELK
81da69e278 Update: Korean translation for STR_CHEAT_TOWN_RATING 2021-05-22 12:56:10 +09:00
Jonathan G Rennison
06d92a97b6
Merge pull request #259 from unbeatable-101/jgrpp
Add installation instructions
2021-05-21 20:43:40 +01:00
Jonathan G Rennison
903ca18c01 Version: Committing version data for tag: jgrpp-0.41.2 2021-05-21 20:18:02 +01:00
Jonathan G Rennison
900a93ac59 Debug: Add sprite dumping to vehicle debug windows 2021-05-21 19:36:19 +01:00
Jonathan G Rennison
6f10b01ba2 Debug: Add general mechanism to dump a sprite group chain 2021-05-21 19:35:22 +01:00
Jonathan G Rennison
12e00624ba Debug: Fix scrollbar count and logged end marker in extra info only mode 2021-05-21 19:16:38 +01:00
Jonathan G Rennison
5d8f459066 Debug: Add button to debug window to log contents to console 2021-05-21 19:00:18 +01:00
Jonathan G Rennison
30409192f0 Fix f5183807: Tree planting scaling on extra large maps 2021-05-21 18:40:10 +01:00
PeterN
f5183807fe Fix #9242: Tree tick handler did not scale by map size. (#9246)
This means that random tree generation density is higher on small maps and lower on large maps. This difference is enough to make the Lumber Mill impractical to use on large maps.

This change skips ticks on maps smaller than 256x256 and increases iterations or shortens the interval on maps larger than 256x256.

(cherry picked from commit b972ed8604)
2021-05-21 18:32:53 +01:00
frosch
c2fce47340 Fix #9256, 12e43c697d: invalid read after free. (#9258)
This also changes ScriptEventVehicleAutoReplaced when replacing wagons:
The event is now only spawned, if the head engine changes, so only if the VehicleID of the consist changes.
Previously replacing wagons spawned an event with OldVehicleID==NewVehicleID.

(cherry picked from commit 5bd8144853)
2021-05-21 18:32:53 +01:00
PeterN
dcb0cc2c52 Fix #9186: Fix incorrect bounding box height causing station sprite glitch. (#9187)
Increased height of small station building bounding box to cover the build rather than just the platform.

(cherry picked from commit ba193f2e23)
2021-05-21 18:29:45 +01:00
PeterN
8677a2a4a2 Fix #9063: Caption of news window incorrectly aligned. (#9252)
(cherry picked from commit 7b7dbbc935)
2021-05-21 18:29:30 +01:00
Jonathan G Rennison
6d3a1935a0 Fix "(undefined string)" message when SlError called when saving 2021-05-21 02:05:18 +01:00
Jonathan G Rennison
66289bbda4 Log packet size parse failures in NetworkTCPSocketHandler 2021-05-21 01:42:31 +01:00
Jonathan G Rennison
6d58115458 Net: Log sent and received game packets with type and status names 2021-05-21 01:40:00 +01:00
Jonathan G Rennison
7677d2d01a Fix mishandling of PACKET_SERVER_MAP_BEGIN queuing at server
This could result in broken packet framing in the TCP stream
2021-05-21 00:58:24 +01:00
Jonathan G Rennison
7c706923f8 Fix a15e26f3: Leftover debugging statement 2021-05-20 22:07:38 +01:00
Jonathan G Rennison
31aec93cca Fix leftover strings in Frisian language 2021-05-20 22:05:13 +01:00
Jonathan G Rennison
3ecda2b735 Fix handling of SlError when called from game thread 2021-05-20 20:20:45 +01:00
Jonathan G Rennison
a8157770df Add fast path to vehicle var 0x42 if only upper byte is required 2021-05-20 18:34:06 +01:00
Jonathan G Rennison
aa0c1ba2e0 Only update vehicle image when in the vicinity of a viewport
This reduces the performance impact of expensive NewGRF
graphics chains.
2021-05-20 18:03:11 +01:00
Jonathan G Rennison
3e8ee4f49f Remove "Disable vehicle image update" setting 2021-05-19 20:42:04 +01:00
Milek7
7ab6ab7400 Fix: missing <limits> include in network/core/packet.h (#9123)
(cherry picked from commit a341852cd5)
2021-05-19 18:19:59 +01:00
Jonathan G Rennison
55915d8d55 Elide vehicle random trigger callbacks 2021-05-18 22:14:19 +01:00
Jonathan G Rennison
6ea97d6068 Viewport: Cache viewport areas for use in MarkAllViewportsDirty 2021-05-18 21:37:05 +01:00
Jonathan G Rennison
a15e26f369 NewGRF: Elide unmasked vehicle callbacks where possible
This includes:
* CBID_VEHICLE_32DAY_CALLBACK
* CBID_VEHICLE_REFIT_COST
* CBID_VEHICLE_MODIFY_PROPERTY
  This is on a per-property basis

The main benefit of this is to avoid callbacks not handled by the
vehicle's current sprite group from using the full graphics chain as
the "default" branch in the callback switch.
In the case where the graphics chain is long/expensive, a lot of work
had to be done before a callback failure result was eventually returned.
2021-05-18 19:07:44 +01:00
William Davis
8cf798d1e1
Added --cask to the command
Not needed, but nice to have
2021-05-18 09:48:05 -04:00
William Davis
8a924f5f0b
Update README.md 2021-05-17 16:28:37 -04:00
William Davis
064b9c59b5
Added link to installation.md 2021-05-17 16:27:50 -04:00
William Davis
9f85bca2db
Update README.md 2021-05-17 16:26:51 -04:00
William Davis
07de486c2b
Update README.md 2021-05-17 16:26:30 -04:00
William Davis
5027916471
Create installation.md 2021-05-17 16:25:23 -04:00
Rubidium
7274432987 Fix #9267, 47a99bb: [Squirrel] Heap use after free
Due to 47a99bb the order of elements in the garbage collection chain has
changed causing the class to be finalised before the instances of that class.
Since the instance's array of member values depends on the size of the values
in the class, the class finalisation resetting that size to 0 causes not all
finalisations to run, which subsequently causes a heap use after free. So,
just set the SQObjectPtrs to 'null' during the finalisation of the SQClass
so the SQInstance can release all instance variables during its finalisation.

(cherry picked from commit 5c01f9ea52)

See: #256
2021-05-16 09:54:56 +01:00
Jonathan G Rennison
8eb34b2f10 Do not attach temporary wagons to free wagon chains when autoreplacing
See: https://github.com/OpenTTD/OpenTTD/issues/9264
2021-05-15 22:32:50 +01:00
Jonathan G Rennison
f3e0507c54 Network: Include extra info in PACKET_CLIENT_ERROR packets
Log more details in server when PACKET_CLIENT_ERROR received
2021-05-14 20:31:31 +01:00
Jonathan G Rennison
e04218b528 Network: Log received packets at log level net=3 2021-05-14 19:34:15 +01:00
PeterN
66cac92028 Fix #9202: Invalid test for unset NewGRF override mapping. (#9226)
(cherry picked from commit 3d9436bd75)
2021-05-14 18:33:19 +01:00
Patric Stout
457b4f80b6 Fix 91b8ce07: dedicated servers could no longer create screenshots (#9232)
Although most commands are not useful on a dedicated server,
screenshot commands should be dequeued.

(cherry picked from commit 56050fc96f)
2021-05-14 18:25:34 +01:00
PeterN
f52da3de3a Codechange: Don't save unused NewGRF override mappings. (#9202)
(cherry picked from commit 69e5da0b54)
2021-05-14 18:15:17 +01:00
William Davis
879de9781b Change: Use gender-neutral pronouns in console command messages (and comments) (#9203)
(cherry picked from commit 881e1da51d)
2021-05-14 18:15:00 +01:00