Commit Graph

53430 Commits (ac1071f4fcbbacc46af7354359ce7028183d5478)
 

Author SHA1 Message Date
Jonathan G Rennison ae746a1af4 VarAction2: Fix tracking of whether a sprite group needs var 1C 2 years ago
Jonathan G Rennison e497f0e78d Fix crash in tooltip window UpdateWidgetSize due to not using saved string 2 years ago
Jonathan G Rennison cd4a9fba68 Fix viewport map mode bridges/tunnels not appearing dotted at high zoom 2 years ago
Jonathan G Rennison 9be7fef875 Documentation: Fix road stop one way state variable values 2 years ago
Patric Stout 77a85e9b4c
Fix: CmdSetAutoReplace didn't validate group type and engine type match (#9950)
Basically, you could setup an auto-replace in a group for trains
to replace a ship with another ship.

Most of the code is surprisingly okay with this, it is only the
group statistics that doesn't like this.
2 years ago
Patric Stout 979704271b
Fix: reverse train direction command did not validate the given vehicle properly (#9947)
You could give a wagon in the chain to reverse (which makes no
functional sense ofc). In result, only parts of the vehicle were
reversing, leading to weird crashes.
2 years ago
Patric Stout 055121df80
Fix: depot-related commands did not validate depot tiles properly (#9948)
The bug comes in two slices:

1) the functions never actually checked if "tile" was a depot tile.
   This allowed executing the function on tile 0, where are the
   things like shadows of aircrafts are.
2) BuildDepotVehicleList() first checked if a vehicle is in a depot
   before checking if it was a primary vehicle. This is invalid
   for aircraft.

Fixing the first hides the second, and fixing the second makes the
first non-exploitable. But, fixing both felt like the best thing
to do.
2 years ago
Patric Stout 100aca1848
Fix: CmdRemoveRoadStop didn't validate the height property properly (#9945)
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.

But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
2 years ago
Patric Stout 9957675a66
Fix: autoreplace command did not validate the vehicle argument properly (#9946)
It first checked if the vehicle was in the depot, which for some types
is only a valid action for the primary vehicle. Afterwards, it checked
if the vehicle was a primary vehicle.
2 years ago
Patric Stout 4651ad94fe
Fix: commands with a RoadType in their arguments were not validated properly (#9944)
Although it was checked that RoadType was not 63 (INVALID_ROADTYPE),
and all values lower than 63 are fine, it also allowed values higher
than 63. As the RoadType is a "byte", it could contain values up
to 255.
2 years ago
Patric Stout 6810d09c1b
Fix: commands with Axis in their arguments were not validated properly (#9943)
When you don't type an Enum, it is a signed value. To validate
if an Axis is valid, it is checked to be lower than AXIS_END. Which
is the case for any value below 0.
2 years ago
Michael Lutz dd93244853 Fix: The first tile in commands received from a client wasn't validated properly. 2 years ago
Jonathan G Rennison 23e057cfac Don't apply show signals using default graphics settings for custom styles 2 years ago
Jonathan G Rennison 23bd1cb567
Merge pull request #404 from telk5093/jgrpp
Update: Korean translation up to 0.48.0
2 years ago
TELK f2838768ca Update: Korean translation up to 0.48.0 2 years ago
TELK 3cace09207 Update: Match the lines of Korean lang. file with english's one 2 years ago
Jonathan G Rennison 96c63ab7fc Remove incorrect comment 2 years ago
Jonathan G Rennison c851c7a797 Documentation: Remove incorrect note about new landscape variables 2 years ago
Jonathan G Rennison 7c37208777 Correct spelling error in readme 2 years ago
Jonathan G Rennison 8c8dcb0002 Version: Committing version data for tag: jgrpp-0.48.0 2 years ago
Jonathan G Rennison 752e46dfcb Merge branch 'master' into jgrpp
# Conflicts:
#	src/station_cmd.cpp
2 years ago
glx22 44e3b05c50 Fix: Use more selectivity when building SSE specific code
See: https://github.com/OpenTTD/OpenTTD/issues/9935

(cherry picked from commit c3f55d53405af04bfe928d9e1a815e06c187ca50)
2 years ago
Jonathan G Rennison 432717b21d Enabled shared orders and occupancy buttons for competitor order windows 2 years ago
Jonathan G Rennison 4e8a8a5e0a Add conditional order to test if last/next dispatch slot is first/last 2 years ago
Jonathan G Rennison 116ddf4b35 Fix timetable automation with conditional order sequences 2 years ago
Jonathan G Rennison da57d75165 Debug: Print lookahead approach speeds for stations (using current order) 2 years ago
Jonathan G Rennison c6ae82b611 Fix 9ff161e4 boosting lookahead braking stats but not actual brake forces 2 years ago
Jonathan G Rennison bd28d5a239 Use order state at reservation time for signal mode tracerestrict eval 2 years ago
Jonathan G Rennison 12566f05ca Add tracerestrict actions used flags for order conditionals present 2 years ago
Jonathan G Rennison a5fb39b388 Use shunt for combined shunt/normal for routes into a bay with shunt exit 2 years ago
Jonathan G Rennison f98f5fd291 Fix not being able to build waypoints when custom types no longer present
And a custom type was previously selected
2 years ago
Jonathan G Rennison c19bd4473f Add signal style flag to require realistic braking 2 years ago
Jonathan G Rennison bdd97f1aea Add debug build console command to run tile loop handler on tile 2 years ago
Jonathan G Rennison e399853f2c Fix aspect propagation issues with combined shunt/normal signals 2 years ago
Jonathan G Rennison 05c7c528f5 Fix a6e3467d: Don't do cargo consistency checks after overriding cargo
This falsely triggers warning messages
2 years ago
Jonathan G Rennison 19af139631 Fix #9937: Station industries_near incorrect after removing part moved sign
RecomputeCatchment was being called before moving the sign tile
instead of afterwards
2 years ago
Jonathan G Rennison 6150edd3b4 Fix Station industries_near incorrect after removing part moved sign
RecomputeCatchment was being called before moving the sign tile
instead of afterwards

See: https://github.com/OpenTTD/OpenTTD/issues/9937
2 years ago
Jonathan G Rennison 91e0529a39 Fix train variable 0x63 using wrong rail type on dual rail type tiles 2 years ago
translators f72b9fa767 Update: Translations from eints
italian: 22 changes by Rivarossi
2 years ago
Jonathan G Rennison e6a6b50675 Include signal combined/normal style mask in aspect cfg hash 2 years ago
Jonathan G Rennison 1422cc871c Fix signal aspect re-calculation in bidi signal blocks with no junctions 2 years ago
Jonathan G Rennison e747f96c78 Fix signal aspect re-calculation with combined normal/shunt 2 years ago
Jonathan G Rennison d48912aa15 Add setting to show full group hierarchy in group names 2 years ago
Jonathan G Rennison d4a813e92e Show group name when grouping vehicles by shared orders
If all vehicles in shared order set are in the same group
2 years ago
Jonathan G Rennison 6a69a5495f Add tracerestrict action to set combined normal/shunt signal mode
Add associated conditional to get reservation end tile
2 years ago
Jonathan G Rennison 52f28eb5c1 Tracerestrict GUI: Refactor string handling for realistic braking warning 2 years ago
Jonathan G Rennison ae47b1636a Add a set of temporary std::strings which can be referenced by StringID 2 years ago
Jonathan G Rennison 4747e1d1d0 Merge PR #403 into jgrpp 2 years ago
Melvin Vermeeren d48234c81b
Add GUI setting to show order occupancy by default 2 years ago
Jonathan G Rennison 78ae295dfe Add combined normal and shunt aspect signal style flag 2 years ago