8a2df4be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21986 Confirmation when people set tabs to auto-close
...
For https://github.com/mozilla-mobile/fenix/issues/22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
af4a03a0f3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21714 : Login button visibility fix on saved logins page
3 years ago
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
b566e3ed7f
[fenix] Import l10n.
3 years ago
e7695f25ef
[fenix] Import l10n.
3 years ago
3516c38f1f
[fenix] Import l10n.
3 years ago
2a52bffeae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
1336a4f72d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
9a784f8484
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
91e7121fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
2f7d5c03f6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
888e9365cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22095 : fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test
3 years ago
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
d09f8d1a00
[fenix] Import l10n.
3 years ago
53db79d50e
[fenix] No issue: Only report telemetry when tabs tray is first opened
3 years ago
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
8fc6c5952f
[fenix] No issue: use Fact.value as detailText for markers.
...
This allows Facts emitted from ac to provide more details in markers.
3 years ago
9688a90c29
[fenix] No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
...
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
e17721e795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20754 : fix intermittent click failure in verifyAboutFirefoxPreview test
3 years ago
99988cd74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22065 fix flaky privateTabsTrayWithOpenedTabTest UI test ( https://github.com/mozilla-mobile/fenix/pull/22068 )
...
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
c4bce2422e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21207 fix flaky updateSavedLoginTest UI test
3 years ago
231ee9a9c3
[fenix] Import l10n.
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
f3f8f717f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Update SelectableChip button background colors
3 years ago
6f80d2871f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22032 - Fix horizontal margin on private home screen
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
e8cd66b619
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue40 in place of #0090ED
3 years ago
e7f6b6fc14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey20 in place of https://github.com/mozilla-mobile/fenix/pull/4A4A55
3 years ago
0abac59277
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink30 in place of #FF6BBA
3 years ago
f928428f5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
c3d86f8dc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet30 in place of #C689FF
3 years ago
1a01f638c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow90 in place of https://github.com/mozilla-mobile/fenix/issues/960E18
3 years ago
4783442368
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed40 in place of #FF6A75
3 years ago
98dd4016ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey50 in place oof #32313C
3 years ago
521b564fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue50 in place of #0060DF
3 years ago
a77c5b8fad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen70 in place of #.008787
3 years ago
18a9ffed66
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonInk20 in place of https://github.com/mozilla-mobile/fenix/pull/312A64
3 years ago
013530110e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet50 in place of https://github.com/mozilla-mobile/fenix/issues/9059ff
3 years ago
2e762f0327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow70 in place of #C45A27
3 years ago
9a901e0cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonYellow60 in place of #E27F2E
3 years ago
453c6f9f8d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonGreen60 in place of https://github.com/mozilla-mobile/fenix/pull/2AC3A2
3 years ago
e5a197c402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPink60 in place of #E31587
3 years ago
bfce9bc796
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonDarkGrey90 in place of https://github.com/mozilla-mobile/fenix/issues/15141A
3 years ago
a8cdbb4524
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet40 in place of #AB71FF
3 years ago
a63441e402
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue60 in place of #0250BB
3 years ago
c07d13ba2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonRed70 in place of #C50042
3 years ago
648f3261c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonPurple50 in place of #B833E1
3 years ago
d50ff294a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonViolet60 in place of https://github.com/mozilla-mobile/fenix/pull/7542E5
3 years ago
ebcc1024ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonWhite in place of #FFFFFF
3 years ago
98c315c7e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlack in place of #FF000000
3 years ago
d51e2df39a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21935 - Use photonBlue30 in place of #00B3F4
3 years ago
d7521f168e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22005 - Ensure deleted items are removed from the list
3 years ago
0a5ba09d26
[fenix] Import l10n.
3 years ago
aabd1999ee
[fenix] CI for 21827 ( https://github.com/mozilla-mobile/fenix/pull/22004 )
...
* Remove redundant calls to setHasOptionsMenu(false)
Fix memory leaks for credit card and login fragments
* Fixes:
Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt
* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
3 years ago
906b7a168c
[fenix] Import l10n.
3 years ago
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
c1c42385c4
[fenix] Improve tabsSettingsMenuItemsTest UI test coverage
3 years ago
bee0854156
[fenix] Import l10n.
3 years ago
70919737fd
[fenix] Import l10n.
3 years ago
952ba35095
[fenix] Import l10n.
3 years ago
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
299406fc89
[fenix] Import l10n.
3 years ago
09d1c997d8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21944 : Top sites rendered slowly on first load of HomeFragment
3 years ago
b7a03ea6d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : linting fixes
...
For https://github.com/mozilla-mobile/fenix/issues/21700 : nit fixes
3 years ago
c261feb602
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Added option to open in browser instead of automatically doing it
3 years ago
c558e11cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : fixed comments
3 years ago
60fa679e9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21700 : Created benchmark script runner and edited benchmark gradle file
3 years ago
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
5372f1bcca
[fenix] Make linters happy
3 years ago
84773fa9a2
[fenix] Register the logins key provider
...
This is required for sync to work
3 years ago
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
0672471708
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21906 ⁃ Remove old copy form inactive tabs section
3 years ago
c8d89a3bba
[fenix] Fix for ambiguous tabstray_title and with text matcher for audio page
3 years ago
45bdd68df1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21769 fix flaky tabMediaControlButtonTest Ui test
3 years ago
f5fa9d4217
[fenix] No issue: Always show Make inactive for debug builds
3 years ago
fa4b9996c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21887 - Update Home background color to LightGrey20
3 years ago
1e84ef3843
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21573 : Add shadow to recent bookmarks section
3 years ago
ac7e445eb0
[fenix] Import l10n.
3 years ago
ed3560d1b9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21917 : Update pocket stories card elevation to match other cards
3 years ago
18a8788812
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707 : Correct search grouping logic in extensions
...
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.
The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.
Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
cb7cc7a7eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources
3 years ago
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
4fee8036a0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794 : Remove rotation; rely on state activated
...
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
7638040a3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest
3 years ago
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
1bb5f1479d
[fenix] Disable editCustomSearchEngineTest UI test
3 years ago
d6ae910c74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK.
3 years ago
6a7c42a398
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test
3 years ago
f0091a768c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test
3 years ago
ec442f575f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings
3 years ago
7f9dab5654
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest
3 years ago
3ea7755592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005 : fixed ETP status info display
3 years ago
Arturo Mejia
Mayank Agarwal
Mugurell
Mozilla L10n Automation Bot
Michael Comella
Oana Horvath
Roger Yang
Andrei Joltan
AndiAJ
Gabriel Luong
xlog-null
Noah Bond
Christian Sadilek
Marc Leclair
Jonathan Almeida
Grisha Kruglov
Ben Dean-Kawamura
sunil9211