2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Commit Graph

3422 Commits

Author SHA1 Message Date
Simon Chae
d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
Sawyer Blatz
b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 2020-05-08 12:04:15 -07:00
codrut.topliceanu
d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Mozilla L10n Automation Bot
824022c28d Import l10n. 2020-05-08 08:44:39 -07:00
Arturo Mejia
ca01965f90 Fix PictureInPictureFeature breaking change 2020-05-08 11:42:06 -04:00
ekager
7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 2020-05-08 14:00:09 +03:00
Oana Horvath
edff0d8e2c
fix #10468: wait for main menu to disappear after creating bookmark (#10478) 2020-05-08 12:58:32 +03:00
ValentinTimisica
f63cb4e09f For #10244: Creates drawable for add-ons private browsing label.
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
2020-05-07 17:27:46 -07:00
Sawyer Blatz
a01881067f For #8643: Updates colors of onboarding accents 2020-05-07 17:24:54 -07:00
Sawyer Blatz
5f11c5e648 For #9857: Updates onboarding button styles 2020-05-07 17:24:54 -07:00
Jeff Boek
58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu
eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ekager
138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 2020-05-07 10:17:42 -07:00
Sawyer Blatz
02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 2020-05-07 08:57:20 -07:00
Jonathan Almeida
57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 2020-05-07 11:44:19 -04:00
ValentinTimisica
77705d1a27 For #9505: Adds tests for sort saved logins 2020-05-07 08:43:59 -07:00
ValentinTimisica
24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
2020-05-07 08:43:59 -07:00
TejaswiKarasani
2e45244b6c
no issue: Added settings_privacy_items_test (#10474) 2020-05-07 07:45:48 -07:00
mcarare
9177871edc For #10408: Check current destination before navigating. 2020-05-07 09:35:10 +03:00
ekager
9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 2020-05-06 23:24:46 -07:00
ekager
9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 2020-05-07 09:20:49 +03:00
Mozilla L10n Automation Bot
c8d8a700fe Import l10n. 2020-05-06 18:14:28 -07:00
Michael Comella
4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 2020-05-06 17:27:58 -07:00
David Walsh
8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Simon Chae
609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 2020-05-06 13:58:42 -04:00
Simon Chae
a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 2020-05-06 13:17:17 -04:00
Mihai Branescu
6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu
cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Mihai Branescu
03726384de For #8643 and #7606 - Changed styles for most onboarding cards 2020-05-06 09:18:27 +03:00
Mihai Branescu
048d22dbcf For #8643 and #7606 - added styles and new colors 2020-05-06 09:18:27 +03:00
Mihai Branescu
18b6c29b4a For #8643 and #7606 - added new svgs for onboarding illustrations
RTL for toolbar are still missing
2020-05-06 09:18:27 +03:00
Mihai Branescu
fab52c9702 For #8643 - removed all onboarding-related PNGs 2020-05-06 09:18:27 +03:00
Mihai Branescu
77912b29fb For #8643 - Replaced onboarding theme/toolbar assets 2020-05-06 09:18:27 +03:00
Mozilla L10n Automation Bot
0b82f8e996 Import l10n. 2020-05-05 17:34:05 -07:00
Arturo Mejia
398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek
fee09c3092 No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek
d72e455c0d No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
kglazko
c0c41dfd74
No Issue Reenable testDownloadPrompt (#10407)
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
2020-05-05 11:24:16 -07:00
Mihai Adrian
43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
David Walsh
5087bcf9f6
For #10395 - Improve alignment of close buttons with menu in tab tray (#10405) 2020-05-05 11:16:47 -07:00
David Walsh
249e0cd4e8
For #10159 - Tab tray bottom toolbar colors (#10326) 2020-05-05 11:16:09 -07:00
Mihai Adrian
5106134786
For #10408: Dismiss menu when navigating away. (#10415)
The menu is dismissed when toolbar view is detached from window.
2020-05-05 11:15:30 -07:00
Mozilla L10n Automation Bot
d2a3613b73 Import l10n. 2020-05-05 09:11:03 +03:00
David Walsh
542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 2020-05-04 22:51:07 -04:00
Michael Comella
2773a9e0a9 No issue: losslessly compress image assets.
Using ImageOptim. Results: 110 KB out of 1.9 MB (5.7%).
2020-05-04 14:54:46 -07:00
Jeff Boek
81d0db76e9
For #10395 - Fixes tab tray bar dimensions to better align with the browser toolbar (#10400) 2020-05-04 12:44:37 -05:00
Alessio Placitelli
14e58c9353 Fixup the BaselinePingTest 2020-05-04 10:37:44 +03:00
Mozilla L10n Automation Bot
34f2350ada Import l10n. 2020-05-04 10:31:35 +03:00
Mugurell
c6c5777090 For #10322 - Update Glean - total_uri_count documentation
total_uri_count continues to accurately track the URLs visited by the user in
the current session.
Websites can though programmatically redirect users to a new URL using simple
javascript even without user interaction.
This needs to be documented for future references.
2020-05-01 18:34:39 -07:00
Mozilla L10n Automation Bot
5abe3ac877 Import l10n. 2020-05-01 18:34:10 -07:00
Sören Hentzschel
10d07912da no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek
94cd195dc7
Adds swipe to delete tab (#10355)
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
2020-05-01 15:45:51 -05:00
Simon Chae
3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek
5c7e9b98cd
Fix home navigation (#10350) 2020-05-01 12:46:02 -05:00
Mozilla L10n Automation Bot
95b29f2f60 Import l10n. 2020-04-30 17:38:35 -07:00
Jeff Boek
a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
2020-04-30 15:53:10 -05:00
Sawyer Blatz
f7dcb9f7b3 For #9208: Make slight modifications to tip layout 2020-04-30 11:57:43 -07:00
David Walsh
7ec4bc9d76 For #10159 - Implement new tab tray colors 2020-04-30 08:56:40 -07:00
Michael Droettboom
c6086103b4 Update generated docs 2020-04-30 08:37:22 -07:00
Michael Droettboom
c373af5d46 Fix glinter errors 2020-04-30 08:37:22 -07:00
Chenxia Liu
390c5a0189 Issue #7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti
4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
2020-04-30 13:38:52 +03:00
David Walsh
688c377197 For 10296 - Implement tab tray dimension changes 2020-04-29 21:28:36 -07:00
Arturo Mejia
56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager
2e27bbd15d No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Mozilla L10n Automation Bot
6d1a2ca797 Import l10n. 2020-04-29 17:55:53 -07:00
Sawyer Blatz
38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 2020-04-29 14:03:59 -07:00
mcarare
4006501d41 For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
mcarare
80f74ac611 For #9728: Change SearchView hint color inside app. 2020-04-29 11:20:18 -07:00
ekager
52d09930a6 No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea
02bd0cc203 For issue #8648 2020-04-29 09:48:42 -07:00
Mozilla L10n Automation Bot
cdbaa52cab Import l10n. 2020-04-28 17:33:33 -07:00
Jonathan Almeida
76002c5987 Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Oana Horvath
2c18c255da
For #9783: bring app in focus with sendSingleTapToScreen for UI test (#10136) 2020-04-28 10:46:42 -04:00
Sören Hentzschel
f0e659bfdb For #9880 - fixed sync settings style 2020-04-28 09:06:36 +03:00
Falaye Iyanuoluwa
c86209ff98 Closes #9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
Mozilla L10n Automation Bot
b7ea583250 Import l10n. 2020-04-28 08:35:44 +03:00
mcarare
7409dc2bae For #10083: Do not cut off thumb when it is in pressed state 2020-04-27 21:19:44 -07:00
mcarare
3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh
6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Christian Sadilek
87c95a64d3 Configure M2 AMO collection for all builds 2020-04-27 18:33:31 -04:00
Mozilla L10n Automation Bot
88f4e5f217 Import l10n. 2020-04-28 00:28:46 +03:00
Arturo Mejia
a8843def6c Fix CrashReporterService breaking changes 2020-04-27 16:43:05 -04:00
Arturo Mejia
e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
Oana Horvath
21894a3cea
Added new bookmarks tests (#9878)
Fix for #7417: Fix and re-enable disabled tests
2020-04-27 18:15:27 +03:00
ekager
a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
Mihai Branescu
f10e202a1e For #6557 - added web-extension for cookies 2020-04-24 15:47:48 -07:00
mcarare
996dabae8b For #10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
mcarare
0f3d4e4cbe For #10188: Fix xml indentations and properties order. 2020-04-24 13:28:53 -07:00
mcarare
e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
2020-04-24 13:28:29 -07:00
mcarare
3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
ekager
59484208d6 No issue: Update Private Browsing placeholder string 2020-04-24 11:39:14 -07:00
Mihai Branescu
8a80fbe14c For #6558 - change from modifying event to event listener
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
2020-04-24 09:28:40 -07:00
Mihai Branescu
8e66e19dbb For #6558 - remove baidu and yahoo from monitored pages
These two do not contain ad servers, so we don't need to unnecessarily monitor them
2020-04-24 09:28:40 -07:00
Mihai Branescu
c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Mihai Branescu
c4f7972f2b For #6558 - added web extension for extracting document urls 2020-04-24 09:28:40 -07:00
Simon Chae
f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
Oana Horvath
e4764592fd
fix private notification text (#10192) 2020-04-24 17:55:46 +03:00
mcarare
2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
2020-04-24 16:42:47 +03:00
Arturo Mejia
956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
2020-04-23 10:33:36 -07:00
Simon Chae
b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
2020-04-23 08:17:42 -07:00
mcarare
72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
JLRoberts
26e8d9bcca For #9550 - Don't overlap search with shortcuts text
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
2020-04-23 11:21:53 +03:00
mcarare
e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Sawyer Blatz
95f26f1fdc
For #9946: Update FennecBeta branding (#10066) 2020-04-22 15:19:24 -07:00
Roger Yang
0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
Mozilla L10n Automation Bot
c702de05f9 Import l10n. 2020-04-21 09:04:12 +03:00
ekager
a1554834f9 Adds destructive colors for private theme 2020-04-20 23:00:41 -07:00
codrut.topliceanu
d80005235f For #8546 - Overrides for new TextInputLayout colors 2020-04-20 23:00:41 -07:00
ekager
66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
isabelrios
587bdfbd7b
For #8081 - UI screenshots tests update (#10023) 2020-04-20 10:39:56 -04:00
Ryan Kelly
8ebb891bf8 Some cleanups for running the sync integration tests 2020-04-18 02:30:44 -07:00
Grisha Kruglov
853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
2020-04-17 23:57:43 -07:00
Jonathan Almeida
c16283a923 For #9932: Fix navigation icon theme missing from migration UI
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
2020-04-17 22:45:30 -07:00
Sawyer Blatz
89cfa3ea9a For #9808: Fix scrolling cutoff on homescreen 2020-04-17 19:58:22 -07:00
Sawyer Blatz
a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang
40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
ec1d4e8fca For #8399: Hide keyboard to prevent content resizes
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
2020-04-17 12:07:44 -07:00
Emily Kager
d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment (#10009)
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
2020-04-17 11:50:56 -07:00
Jonathan Almeida
cab0bfc073 For #8422: Add more misc migration UI fixes 2020-04-17 14:22:25 -04:00
Michael Comella
909ee734bf For #8803 - post: update metrics & pings data review URL. 2020-04-17 09:11:58 -07:00
Michael Comella
f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
2888d66ce0 For #8803 - review: move forward metric expiration date.
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
2020-04-17 09:11:58 -07:00
Michael Comella
f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
dbf733d70a For #8803: add StartupFrameworkStartMeasurement.
This class controls the central logic around the metrics we want to
record.
2020-04-17 09:11:58 -07:00
Michael Comella
7f618a6a7c For #8803: add Stat and test.
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
2020-04-17 09:11:58 -07:00
Michael Comella
a0c4b33b0f For #8803: add StartupTimeline ping type and framework_start metrics. 2020-04-17 09:11:58 -07:00
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016)
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
2020-04-17 08:57:36 -07:00
ekager
6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
2020-04-16 21:00:27 -07:00
Mihai Adrian
72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot
dbbd048b6c
Import l10n. (#10011) 2020-04-16 20:32:21 -07:00
Emily Kager
1df9c53b9f
Fix: Set correct height for EditText (#10014)
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
2020-04-16 20:31:25 -07:00
Mihai Eduard Badea
725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
5a2a779ef5 For #9565: Adjust padding and height to allow longer text 2020-04-16 20:10:45 -07:00
mcarare
e87ea301ab For #9536: Update tests to check opened tab is in same browsing mode 2020-04-16 19:50:25 -07:00
mcarare
83d2208c6b For #9536: Open report issue tab depending on current browsing mode.
Checking if session is private uses the new browser state API.
2020-04-16 19:50:25 -07:00
mcarare
8440f1867a For #9989: Add start & end margin to button. 2020-04-16 19:43:34 -07:00
Sawyer Blatz
1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
ekager
6df11619fd No issue: Uses NeutralButton for Migration Activity 2020-04-16 13:14:34 -07:00
Jonathan Almeida
2bb1b6edad For #8422: Add misc migration UI fixes 2020-04-16 12:02:02 -07:00
Jonathan Almeida
25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot
3e8836f71a Import l10n. 2020-04-16 10:13:30 +03:00
ekager
688a33522b For #9516 - Adds selectable background to dialog and snackbar buttons 2020-04-16 10:13:08 +03:00
Sawyer Blatz
8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
Jonathan Almeida
997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
e97904662c Remove duplicate FirebasePushService
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
2020-04-15 17:55:12 -04:00
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
2020-04-15 13:20:06 -07:00
Michael Comella
f0464b9e72
For #9644: restrict deps to specific repositories (#9649)
* For #9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For #9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For #9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For #9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
2020-04-15 10:54:36 -07:00
ValentinTimisica
c7b123cfea
Fixes #9710: Vertically aligns users_count with rating (#9950) 2020-04-15 10:51:55 -07:00
ekager
aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Jeff Boek
06f1b6c992
No Issue - Fixes nav_graph issues (#9926) 2020-04-15 08:34:45 -07:00
Arturo Mejia
37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot
9a298ea6ba Import l10n. 2020-04-15 03:50:48 +03:00
ekager
2056b6f2ff Update UI test to match Support Page title 2020-04-14 11:34:55 -07:00
ekager
55b04b9885 Update Server.dev to Server.stage to fix A-S upgrade breaking change 2020-04-14 11:34:55 -07:00
Arturo Mejia
8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot
69c7196e77 Import l10n. 2020-04-14 09:54:30 +03:00
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
Arturo Mejia
eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager
8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
5039546dc5 For #7208 For #7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
Christian Sadilek
152642d98d Configure M2 AMO collection for Nightly/Debug 2020-04-13 10:42:39 -04:00
Oana Horvath
52857b09d7
fix #9670 intermittent tests (#9767)
also disabled intermittent closePrivateTabsNotification
2020-04-13 13:17:35 +03:00
mcarare
8cdc523de9 For #9698: Add unit tests for Context extension getStringWithArgSafe 2020-04-13 09:40:00 +03:00
mcarare
a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
e1bc8dc190 Import l10n. 2020-04-13 09:38:41 +03:00
Mugurell
b72c223244
For #7157 - Set BrowserMenu width to be max 314 dp (#9731)
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
2020-04-10 10:17:07 -07:00
mcarare
1881975a31 For #9793: Adjust relative positions to provide correct a11y traversal 2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
c31c198d54 Import l10n. 2020-04-09 17:38:37 -07:00
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
ed466d34f7 Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
12d486bf02
Issue #9682: Reduces size of branding (#9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
a12cb5b0c3 Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
9305331a56 For #9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
376740cd2c For #9631: replace assertk assertions with junit.
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191)
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
3789f50423 Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
2d55b07935 Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
cac8115e55 For #9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
9e470c93ca Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
b35704beed Closes #9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
b2da0bd922
For #9670: Disabled intermittent tabMediaControlButton test (#9679)
and removed file created by mistake -e

added reason for disabled tests
2020-04-03 20:39:33 +03:00
Mugurell
904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
51a76651d6 For #9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
b60a21c08d For #9605: Add LintUnitTestRunner gradle task.
This will prevent us from regressing on adding older versions of the
unit test runner.
2020-04-03 09:27:49 -07:00
Michael Comella
efef8eaba0 For #9605: TestApplication -> FenixRobolectricTestApplication.
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
Michael Comella
8df49473c0 For #9605: move TestApplication to the helpers package.
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
Michael Comella
6e0d851da3 For #9605: replace unit test runners with FenixRobolectricTestRunner.
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
Michael Comella
b0cfa3ee5c For #9605: add FenixRobolectricTestRunner.
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
Michael Comella
392dda5eda For #9605: remove unnecessary @RunWith(Robolectric in unit tests.
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
Michael Comella
f2acef66b5 For #9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
Aaron Train
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest (#9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
8413b8133d Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
4a8dc5b54f No issue: add kdoc to HomeActivity.
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
8c43935ba3
For #7978 - Put views above button in scrollView (#8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
7043f9ee4e
For #9604: Swap and adjust margin with padding to avoid text being cut (#9617) 2020-04-02 09:40:29 -07:00