Commit Graph

4405 Commits (3727d55b889b78f929b517e3caa8f153e44908d7)

Author SHA1 Message Date
Matt Tighe f146cefcb8 closes #23662: replace wallpaper thumbnail lazyverticalgrid with manual scroll layout 2 years ago
Gabriel Luong 5bbf8437b3 For #23711 - Replace @color/primary_text_normal_theme with @color/fx_mobile_text_color_primary 2 years ago
Rohan Maity df0d196759 For #20634 remove some lint issues from baseline 2 years ago
Matt Tighe 9643e96244 fixes #23644: reload wallpapers on orientation change 2 years ago
Arturo Mejia 11601770eb For #23679 Update the wallpaper settings switch text 2 years ago
Gabriel Luong 37a0edceb6 For #23431 - Display the order of Contile Top Sites correctly 2 years ago
Mugurell 5bd6f1cb8c For #21854 - Split the big ComposeView in 3 smaller ones
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
mcarare 18f785ddb9 For #22958: Set content description only when view is visible.
This avoids additional processing.
2 years ago
Alexandru2909 2d75ff7d47 For #14321 - Dismiss search dialog buttons on edit cancel 2 years ago
Alexandru2909 d7803e6dc7 For #14954 - Use TabSessionState.id to check if tab is selected 2 years ago
Noah Bond c0942eadb2 For #23526 - Add telemetry for Contile interactions 2 years ago
jhugman b230c39a7f
Fixes #23492: Perf regression of calling isFirefoxDefault from main thread (#23556)
* Fixes #23492 — Fixup perf regression of calling isFirefoxDefault from the main thread

* Tightening of near defunct default browser message

* Fixup early crash in debug build

* ktlint
2 years ago
Matt Tighe 0c297dcee2 closes #23540: scale wallpaper and translate to bottom of image 2 years ago
Roger Yang 1d1412c766 Close #23626: Do not exit edit mode in history search toolbar 2 years ago
Matt Tighe 24d2abd2b2 fixes #23619: use well-defined name for fetching remote wallpaper assets 2 years ago
Sarah Khan 26c7562e62 For #23596 and #23309 - Add deeplink to wallpaper settings 2 years ago
Matt Tighe b7b601eee1 closes #23616: add final path separator to reote path 2 years ago
Arturo Mejia c90dcaa314 For #23577: Make description text on the wallpapers settings page align with the start of the switch 2 years ago
Roger Yang 1e90235dcc Close #10046: Add history search 2 years ago
Geordan Neukum 23036680c2 For #16395 - Use Secondary Text for the Site Permissions subtext 2 years ago
Arturo Mejia dc3a44d4f9 For #23574: Remove stale partial bitmaps created while downloading wallpapers 2 years ago
Gabriel Luong 1484f77bdb For #23575 - Use design system colors for the Pocket filter and Customize homepage buttons 2 years ago
Matt Tighe 9b9d08c7d1 closes #23565: expire remote wallpapers but let users keep selected 2 years ago
Arturo Mejia e290bc1bd6 For #23563: Address time out crash when downloading wallpaper 2 years ago
Gabriel Luong 6f2af25a60 For #23558 - Update menu copy for What's new and Customize homepage 2 years ago
Mugurell 0be470a104 For #21009 - New Recently closed tabs telemetry
This adds a new `recently_closed_tabs` category with then events for all user
interactions on the screen.

The already existent `events.recently_closed_tabs_opened` is still kept for a
bit more time to still have this data available while the new telemetry ride
the trains but can later be removed in favor of this newly added events.
2 years ago
Lucius C e73deb23ac
For #13336: Open bookmarks in current tab (#23169)
* For #13336: Open bookmarks in current tab

* For #13336: Fix tests to verify bookmark opening in current tab

* Change test name for handleBookmarkTapped
2 years ago
Matt Tighe 0837197d84 closes #23514: add firefox wallpapers 2 years ago
Arturo Mejia fdb2006c85 For #23498 add content description for wallpapers 2 years ago
Christian Sadilek 892e65f8e8 Issue #12731: Disable TrimMemoryMiddleware on all channels
This was already disabled in Nightly over two months ago
and seems to work much better combined with latest fixes
in GV (see links inline for details.)
2 years ago
Gabriel Luong 39c6067b03
For #23350 - Revert changes from removing duplicate icons that already exists in ui-icons (#23527)
* Revert "For #23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"

This reverts commit 12347c9999.

* Revert "For #23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"

This reverts commit bbf6ce3f0c.

* Revert "For #23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"

This reverts commit 930c7bf3b3.

* Revert "For #23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"

This reverts commit 9069b57c24.

* Revert "For #23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"

This reverts commit 53216f3f4a.

* Revert "For #23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"

This reverts commit 9ee9aafd87.

* Revert "For #23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"

This reverts commit b045a5e203.

* Revert "For #23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"

This reverts commit 62842db131.

* Revert "For #23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"

This reverts commit c020a9da10.

* Revert "For #23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"

This reverts commit ca67b0a752.

* Revert "For #23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"

This reverts commit 02d9197945.

* Revert "For #23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"

This reverts commit cf8592c709.

* Revert "For #23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"

This reverts commit a1ac019024.

* Revert "For #23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"

This reverts commit 541c56b589.

* Revert "For #23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"

This reverts commit 4d8adce85e.

* Revert "For #23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"

This reverts commit ef026d3ec2.

* Revert "For #23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"

This reverts commit 18591d5dd8.

* Revert "For #23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"

This reverts commit ad33e3c1e1.

* Revert "For #23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"

This reverts commit a9f0fefac2.

* Revert "For #23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"

This reverts commit 33dc752ef2.

* Revert "For #23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"

This reverts commit 5bf937cfd3.

* Revert "For #23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"

This reverts commit 0fadd68112.

* Revert "For #23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"

This reverts commit bea766e785.

* Revert "For #23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"

This reverts commit 5a6f349ea8.

* Revert "For #23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"

This reverts commit ae38410106.

* Revert "For #23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"

This reverts commit 9352946afc.
2 years ago
Matthew Tighe 9dc0506ec2
closes #23504: download focus wallpapers at runtime (#23505)
* closes #23504: download focus wallpapers at runtime

* address pr feedback

* only download wallpapers if feature flag is set
2 years ago
Gabriel Luong a14e6ddde3 For #23433 - Align the provided top sites to the design spec 2 years ago
Gabriel Luong 42ac6feb0c For #23424 - Part 2: Add context menu for contile top sites 2 years ago
Gabriel Luong 532bb9a38a For #23424 - Part 1: Refactor TopSiteItemMenu into its own file 2 years ago
Arturo Mejia 2533c91da5 For #23440,#23441,#23442 remove adapting themes after switching wallpapers 2 years ago
Gabriel Luong 62b10690f8 For #23450 - Add Text Accent Disabled design token 2 years ago
Gabriel Luong cc3c68c24b For #23450 - Rename design token Border Default to Border Primary 2 years ago
jhugman 82a6f8cae4
First use of Nimbus FML plugin (#23400)
* Consume Nimbus FML plugin

* Convert Homescreen to use FML

* Convert nimbusValidation to use FML

* Convert legacy experiments to use the feature API and FML

Remove dead helper code and documentation

* Fixup failing test

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Gabriel Luong 6596f4c28b For #23432 - Use the imageUrl as the favicon for a provided top site 2 years ago
Arturo Mejia 393de99196 For #22851 Add logo animation for wallpapers 2 years ago
Matt Tighe d23fb30151 replace WallpaperFeatureDiscovered probe with WallpaperSettingsOpened 2 years ago
Matt Tighe a419a6963c add events based on feedback 2 years ago
Matt Tighe a5f540568e update based on PR feedback and data review 2 years ago
Matt Tighe eed42ee96b closes #23381: add telemetry for wallpapers feature 2 years ago
Gabriel Luong e5e7e6dbcf For #23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig 2 years ago
Matt Tighe 670657b484 fixes #23404: add switch to wallpaper settings to disable tap-to-change 2 years ago
Gabriel Luong dff7c2813c For #23374 - Update Layer 1 and Layer 3 to match design system 2 years ago
Gabriel Luong 245fb03c6a For #23374 - Update description of Layer Accent 2 years ago
Gabriel Luong 0cc1346736 For #23374 - Add Text Action Primary, Secondary, Tertiary, Tertiary Active design tokens 2 years ago
Gabriel Luong ff2a65239e For #23374 - Update Text Inverted, Icon Inverted to Text On Color, Icon On Color 2 years ago
Gabriel Luong 5aa9daeede For #23374 - Add Action Quarternary design token 2 years ago
Gabriel Luong 3958b51685 For #23374 - Update Layer2 dark theme color to DarkGrey30 2 years ago
Gabriel Luong cc0515430b For #23374 - Add Dialog and Banner to Layer 2 description 2 years ago
Gabriel Luong b86c1fc5e7 For #23374 - Update Text Warning and Icon Warning colors to match design system 2 years ago
Gabriel Luong 169fc77256 For #23374 - Update Action Secondary colors and Add Action Tertiary 2 years ago
Gabriel Luong 27cec04f1a For #23374 - Update Border Disabled colors to match design system 2 years ago
Gabriel Luong bcc4d0bbc7 For #23374 - Update Icon Disabled colors to match design system 2 years ago
Gabriel Luong cf55261e13 For #23374 - Update Text Accent color to photonViolet20 2 years ago
Sarah541 ef5966cddd
For #22576 - Indicate mutability flag for PendingIntent
* For #22576 - Indicate mutability flag for PendingIntent

* Fix lint issues

* Make Analytics Pending Intent flag mutable

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Sammy Khamis 6f9e725ec5 add invalid URL error to show up when trying to save an invalid bookmark 2 years ago
Sammy Khamis 7d34fbb87d fix fenix crashing when trying to add an invalid bookmark 2 years ago
Mugurell 5c1953d792 For #22314 - Reuse existing tab for search group items 2 years ago
Arturo Mejia dc0f50b590 For #22851: Load wallpapers dynamically from the assets directory. 2 years ago
Sammy Khamis 088339c4de changes to fix up issues with places uniffication 2 years ago
Gabriel Luong bbf6ce3f0c For #23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share 2 years ago
Gabriel Luong ca67b0a752 For #23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin 2 years ago
Gabriel Luong 02d9197945 For #23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search 2 years ago
Gabriel Luong cf8592c709 For #23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode 2 years ago
Gabriel Luong 541c56b589 For #23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login 2 years ago
Gabriel Luong ef026d3ec2 For #23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download 2 years ago
Gabriel Luong 18591d5dd8 For #23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock 2 years ago
Gabriel Luong ad33e3c1e1 For #23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop 2 years ago
Gabriel Luong a9f0fefac2 For #23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close 2 years ago
Gabriel Luong 33dc752ef2 For #23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete 2 years ago
Gabriel Luong bea766e785 For #23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back 2 years ago
Gabriel Luong ae38410106 For #23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new 2 years ago
Gabriel Luong 9352946afc For #23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions 2 years ago
Roger Yang f8b0dd6e7e No issue: Remove showHistorySearchGroups feature flag 2 years ago
mcarare a6abaf7cf9 Set a minimum number of sites a search group should contain. 2 years ago
Gabriel Luong 70882179a0 For #23304 - Add a setting for enabling Contile 2 years ago
Noah Bond 157acdf7fc For #23159 - Created setting to turn off the Contile feature 2 years ago
Gabriel Luong ce6917a542 For #23293 - Add @color/fx_mobile_icon_color_primary_inactive and @color/fx_mobile_icon_color_active 2 years ago
mcarare 305b527b05 For #23256: Close quick settings sheet when displaying clear dialog. 2 years ago
mcarare 0496249fe4 For #23256: Pass navController instance instead of lambda. 2 years ago
Alexandru2909 811375275b For #23272 - AddLoginFragment use showKeyboard from Components 2 years ago
Gabriel Luong 268ba9b39d For #23266 - Update the tabs tray multi-select background color to @color/fx_mobile_layer_color_accent 2 years ago
Roger Yang 829c06ebe4 Close #23250: Remove duplicate sites within a time period in history 2 years ago
Gabriel Luong 26b65a2a23 For #22727 - Add Contile to Top Sites 2 years ago
mcarare 64a8932e3c For #22477: Ignore null and empty values for share data title. 2 years ago
Sarah Khan e9a4272e82 For #23138 - Close recently visited menu on orientation change 2 years ago
Matt Tighe dd4cf9164d closes #23220: show snackbar on wallpaper selection 2 years ago
Matt Tighe 0b99c2e67d fixes #22943: update androidx.lifecycle to 2.4.0 2 years ago
Gabriel Luong 2baa4efa8d For #23193 - Remove @color/toolbar_[start|center|end]-gradient_normal_theme redirection 2 years ago
Gabriel Luong 88ed50888d For #23187 - Replace @color/notification_accent_color_normal_theme with @color/fx_mobile_text_color_accent 2 years ago
Alexandru2909 cf83b3050b For #8108 - Add BrowserToolbar option to remove url from TopSites 2 years ago
Matthew Tighe ce1c4093fa
closes #22831: add wallpaper settings screen (#23145)
* closes #22831: add wallpaper settings screen

* address PR and UX feedback

* rebase upstream and adjust settings correctly
2 years ago
Arturo Mejia d1ace92e64 Revert "For #22851: Add logo animation for wallpapers."
This reverts commit d089f007
2 years ago
Arturo Mejia d089f00793 For #22851: Add logo animation for wallpapers. 2 years ago
Arturo Mejia 2bba66fb58 For #23144 Address regression in COLD start 2 years ago
mcarare afd13fec85 For #21744: Replace InputMethodManager's deprecated toggleSoftInput. 2 years ago
mcarare 58a6fafabc For #22383: Propagate ViewTreeLifecycleOwner to composable view holders. 2 years ago
Roger Yang 047ec890b2 Closes #22550: Refactor search term tab grouping logic to rely on middleware 2 years ago
Grigory Kruglov d161e46383 Adjust logins diffing logic for recyclerview 3 years ago
Grigory Kruglov e67753fb4b Scroll to top of logins screen after list changes 3 years ago
Grigory Kruglov 1b305c1398 For #22795: Stop trimming login origins on sorting
Due to the async nature (??) of the trimming code, this is causing severe performance issues
during search.

Looking back through commits, doesn't seem like there's a particularly good reason we were trimming here. All I could find is #9986 (comment) which is lacking explanation of why this is actually useful.

And currently, we're dealing with an origin (not a full url when this was initially written, I think), i.e. https://accounts.firefox.com vs https://accounts.firefox.com/signin. So, the suffix stripping isn't even doing much beyond removing com in vast majority of cases.

So, seems like all of this trimming stuff can be cleaned up.
3 years ago
Arturo Mejia 28928e4bdd For #23104: Don't adjust the theme for the default wallpaper. 3 years ago
Alexandru2909 7b04eba324 For #19567 - Change SavedLogins and LoginDetail fragments to extend SecureFragment 3 years ago
Gabriel Luong 873d8257d1 For #23086 - Add Border Inverted design token 3 years ago
Gabriel Luong a39224e44b For #23086 - Change design token name from Border Selected to Border Accent 3 years ago
Gabriel Luong 2ad2691724 For #23086 - Update Border Divider to Border Default 3 years ago
Gabriel Luong fc9310dc83 For #23086 - Rename design token name from Border Default to Border Form Default 3 years ago
Gabriel Luong 11e0df20df For #23086 - Update the dark theme colors of Action Primary to Violet60
- Updates the description of Action Primary to include "Chip selected"
3 years ago
Gabriel Luong 65b84c10bc For #23086 - Update the dark theme Action Secondary color to DarkGrey10 3 years ago
Gabriel Luong 1b7918f6d0 For #23086 - Change the light theme color for Form Selected, Form On, Icon Button, Layer Accent, Border Selected to Ink20 3 years ago
Gabriel Luong 76fb147ed8 For #23076 - Clean up unneeded FeatureFlags 3 years ago
MickeyMoz 96b96fbfdb Update Android Components version to 97.0.20220104190053. 3 years ago
Arturo Mejia 09fdee6510 For #22851: Adjust theme based on the selected wallpaper. 3 years ago
Gabriel Luong ddc806e8bc For #22978 - Replace @color/foundation_normal_theme with @color/fx_mobile_layer_color_1 3 years ago
Gabriel Luong 7c12e9c970 For #23049 - Update the color for @color/fx_mobile_layer_color_accent_nonopaque 3 years ago
Gabriel Luong f863864c50 For #23049 - Update the colors of @color/fx_mobile_action_color_primary 3 years ago
Gabriel Luong 986a57d40b For #23049 - Consolidate @color/fx_mobile_text_color_accent with @color/fx_mobile_text_color_action
- Removes @color/fx_mobile_text_color_action
- Use the colors from @color/fx_mobile_text_color_action in @color/fx_mobile_text_color_accent
3 years ago
Arturo Mejia 277e94881b For #22995: Address crash when switching languages. 3 years ago
mcarare cdbe7983f5 For #22879: Filter default engines when sending telemetry.
Filter out custom engines that are not well known search domains.
3 years ago
mike a 46b5dd2706 Closes #10737: Searching a language/saved password displays a misplaced "x".
Setting max width for the search view in language settings and saved logins screens. Removed SyncAuthClosed event from LocaleSettingsFragment, an apparent copy-paste.
3 years ago
TasosB 05e6ba40b4 For #21483 - Remove light theme tinting of folder icon in the Bookmark view 3 years ago
rxu 2203ebf923 Pass distribution_id to Socorro crash report 3 years ago
Gabriel Luong c50073f7e4 For #22965 - Add Form On, Form Off, Indicator Active, Indicator Inactive color tokens 3 years ago
Gabriel Luong 3ffece2b87 For #22965 - Remove Control Active color token 3 years ago
Gabriel Luong 38c55dbbc0 For #22965 - Update description of Layer Accent color token 3 years ago
Gabriel Luong a7e78a19d0 For #22965 - Update description of Text Inverted color token 3 years ago
Gabriel Luong c9cb55cf3f For #22965 - Remove Control Dark design color token 3 years ago
Gabriel Luong 945dde72e3 For #22965 - Rename Action Disabled to Form Disabled for the design color tokens 3 years ago
Gabriel Luong 97c42ca84e For #22965 - Update Control to Form Surface design colors 3 years ago
Gabriel Luong 5bea4554ad For #22965 - Add Form Selected design color token 3 years ago
Gabriel Luong c9bc38d67c For #22965 - Update Action Teritary to Form Default design colors 3 years ago
Gabriel Luong 1cf91a2ef4 For #22965 - Change Pill button to Chip for Action Secondary design color token description 3 years ago
Gabriel Luong 16bf150fb9 For #22965 - Remove Toolbar background from the description of Layer 3 design color token 3 years ago
Roger Yang 0b0f69ab4e Closes #22754: Customize home button should work on fresh install 3 years ago
mavduevskiy 89f5e96d73
For #18160: Show a prompt when trying to leave private browsing with active downloads (#22912)
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
Grisha Kruglov 5bbfd49e1d Refactor History types to eliminate nullability
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.

With this refactor, we entirely eliminate nullability from these types.
3 years ago
Grisha Kruglov 836ff1151b Closes #22764: Convert History.id to an Int position
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.

This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
Mugurell 34c0a17b4d For #22852 - Add a new "Storage access" permission 3 years ago
Arturo Mejia cf31bc408a For #22931 Only enable wallpapers on normal mode 3 years ago
mcarare 00280d3b65 For #20513: Use UrlMetricType for search engine submission url. 3 years ago
Roger Yang 22bcdeafe0 Closes #22736: Do not remove focus from toolbar when scrolling 3 years ago
Arturo Mejia 7a44412619 For #22851 toggle wallpapers when tap on the Firefox logo 3 years ago
rxu 073fd89390 Add default topsite MeiTuan for MozillaOnline builds 3 years ago
Matt Tighe db71d8dfe7 fixes #22889: add bottom spacer to onboarding adapter 3 years ago
Mugurell eb2ec677ca For #22508 - Increase menu height to avoid it become scrollable
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
3 years ago